Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-17 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63856/#review191348
---


Ship it!




Ship It!

- Na Li


On Nov. 16, 2017, 6:54 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63856/
> ---
> 
> (Updated Nov. 16, 2017, 6:54 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and 
> kalyan kumar kalvagadda.
> 
> 
> Bugs: sentry-2048
> https://issues.apache.org/jira/browse/sentry-2048
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> This patch bumps the version of Hive to 2.3.2. There were some Hive 
> configurations that causes conflict with Sentry (see tests about what 
> changed).
> 
> 
> Diffs
> -
> 
>   pom.xml 7476b4f11647d8e2816e531c919f00c073774019 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java
>  d11b2617d5f0a3e4801261c4cfbc05dd2c957e48 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java
>  b531976095a191208c2516424f3bc1260f6ba77f 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryFilterDDLTask.java
>  672acb6316cb58c1430e2296461f794692e9e99e 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
>  61052cf261ecd6111e9b65803a43161e5a3d451c 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
>  802bf9c452f96f6a28e704d645be7d77db4b4011 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
>  d1f071ebb926d99848907359bcdbcf5b7e1b615b 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
>  2e299a9487f624a40dab05d682c83d2525b1461a 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java
>  1596bce925915a56218ad9745ebf3c8648b6c593 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHiveMetaStoreClient.java
>  cfc5c04c057d552fdfe3059d6cdde82ef40c8535 
>   
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
>  de073edc5d803bb87951b46bd5ebe7c38d196667 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
>  95bbaeb5a678ee4b1e7adaab9985346027ecfc24 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  3c8b70ec3db59a4e6de6a7fb8b1509c4fe228c25 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java
>  c2fee2af1e0f66accdb416f2a1710042ea186d68 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java
>  64c639439db51e00bc293a7ededa248c8ea45bfe 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java
>  d0139ad0b7c7f73e1fa6766869c392f6086678a4 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
>  7f53527e6f76f079b82b0566ac1d293327cf87be 
>   sentry-tests/sentry-tests-solr/pom.xml 
> 723fa9d1991315ed2a182fd5ffcf9974848dbe77 
> 
> 
> Diff: https://reviews.apache.org/r/63856/diff/2/
> 
> 
> Testing
> ---
> 
> All unit tests passed on Jenkins.
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-16 Thread kalyan kumar kalvagadda via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63856/#review191252
---


Ship it!




Ship It!

- kalyan kumar kalvagadda


On Nov. 16, 2017, 6:54 p.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63856/
> ---
> 
> (Updated Nov. 16, 2017, 6:54 p.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and 
> kalyan kumar kalvagadda.
> 
> 
> Bugs: sentry-2048
> https://issues.apache.org/jira/browse/sentry-2048
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> This patch bumps the version of Hive to 2.3.2. There were some Hive 
> configurations that causes conflict with Sentry (see tests about what 
> changed).
> 
> 
> Diffs
> -
> 
>   pom.xml 7476b4f11647d8e2816e531c919f00c073774019 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java
>  d11b2617d5f0a3e4801261c4cfbc05dd2c957e48 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java
>  b531976095a191208c2516424f3bc1260f6ba77f 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryFilterDDLTask.java
>  672acb6316cb58c1430e2296461f794692e9e99e 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
>  61052cf261ecd6111e9b65803a43161e5a3d451c 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
>  802bf9c452f96f6a28e704d645be7d77db4b4011 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
>  d1f071ebb926d99848907359bcdbcf5b7e1b615b 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
>  2e299a9487f624a40dab05d682c83d2525b1461a 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java
>  1596bce925915a56218ad9745ebf3c8648b6c593 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHiveMetaStoreClient.java
>  cfc5c04c057d552fdfe3059d6cdde82ef40c8535 
>   
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
>  de073edc5d803bb87951b46bd5ebe7c38d196667 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
>  95bbaeb5a678ee4b1e7adaab9985346027ecfc24 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  3c8b70ec3db59a4e6de6a7fb8b1509c4fe228c25 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java
>  c2fee2af1e0f66accdb416f2a1710042ea186d68 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java
>  64c639439db51e00bc293a7ededa248c8ea45bfe 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java
>  d0139ad0b7c7f73e1fa6766869c392f6086678a4 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
>  7f53527e6f76f079b82b0566ac1d293327cf87be 
>   sentry-tests/sentry-tests-solr/pom.xml 
> 723fa9d1991315ed2a182fd5ffcf9974848dbe77 
> 
> 
> Diff: https://reviews.apache.org/r/63856/diff/2/
> 
> 
> Testing
> ---
> 
> All unit tests passed on Jenkins.
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-16 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63856/
---

(Updated Nov. 16, 2017, 6:54 p.m.)


Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan 
kumar kalvagadda.


Bugs: sentry-2048
https://issues.apache.org/jira/browse/sentry-2048


Repository: sentry


Description
---

This patch bumps the version of Hive to 2.3.2. There were some Hive 
configurations that causes conflict with Sentry (see tests about what changed).


Diffs (updated)
-

  pom.xml 7476b4f11647d8e2816e531c919f00c073774019 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java
 d11b2617d5f0a3e4801261c4cfbc05dd2c957e48 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java
 b531976095a191208c2516424f3bc1260f6ba77f 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryFilterDDLTask.java
 672acb6316cb58c1430e2296461f794692e9e99e 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
 61052cf261ecd6111e9b65803a43161e5a3d451c 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
 802bf9c452f96f6a28e704d645be7d77db4b4011 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
 d1f071ebb926d99848907359bcdbcf5b7e1b615b 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
 2e299a9487f624a40dab05d682c83d2525b1461a 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java
 1596bce925915a56218ad9745ebf3c8648b6c593 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHiveMetaStoreClient.java
 cfc5c04c057d552fdfe3059d6cdde82ef40c8535 
  
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
 de073edc5d803bb87951b46bd5ebe7c38d196667 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
 95bbaeb5a678ee4b1e7adaab9985346027ecfc24 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
 3c8b70ec3db59a4e6de6a7fb8b1509c4fe228c25 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java
 c2fee2af1e0f66accdb416f2a1710042ea186d68 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java
 64c639439db51e00bc293a7ededa248c8ea45bfe 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java
 d0139ad0b7c7f73e1fa6766869c392f6086678a4 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
 7f53527e6f76f079b82b0566ac1d293327cf87be 
  sentry-tests/sentry-tests-solr/pom.xml 
723fa9d1991315ed2a182fd5ffcf9974848dbe77 


Diff: https://reviews.apache.org/r/63856/diff/2/

Changes: https://reviews.apache.org/r/63856/diff/1-2/


Testing
---

All unit tests passed on Jenkins.


Thanks,

Sergio Pena

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-16 Thread Sergio Pena via Review Board 


> On Nov. 16, 2017, 3:49 p.m., Na Li wrote:
> > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
> > Lines 382 (patched)
> > 
> >
> > is this just temporary solution to return null?
> > 
> > When we want to support row filtering, should we change the 
> > implementation here?

Sentry does not support row filtering nor column masking. This method must be 
overriden, but we cannot add any implementation yet.


- Sergio


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63856/#review191187
---


On Nov. 16, 2017, 1:15 a.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63856/
> ---
> 
> (Updated Nov. 16, 2017, 1:15 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and 
> kalyan kumar kalvagadda.
> 
> 
> Bugs: sentry-2048
> https://issues.apache.org/jira/browse/sentry-2048
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> This patch bumps the version of Hive to 2.3.2. There were some Hive 
> configurations that causes conflict with Sentry (see tests about what 
> changed).
> 
> 
> Diffs
> -
> 
>   pom.xml 7476b4f11647d8e2816e531c919f00c073774019 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java
>  d11b2617d5f0a3e4801261c4cfbc05dd2c957e48 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java
>  b531976095a191208c2516424f3bc1260f6ba77f 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryFilterDDLTask.java
>  672acb6316cb58c1430e2296461f794692e9e99e 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
>  61052cf261ecd6111e9b65803a43161e5a3d451c 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
>  802bf9c452f96f6a28e704d645be7d77db4b4011 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
>  d1f071ebb926d99848907359bcdbcf5b7e1b615b 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
>  2e299a9487f624a40dab05d682c83d2525b1461a 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java
>  1596bce925915a56218ad9745ebf3c8648b6c593 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHiveMetaStoreClient.java
>  cfc5c04c057d552fdfe3059d6cdde82ef40c8535 
>   
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
>  de073edc5d803bb87951b46bd5ebe7c38d196667 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
>  95bbaeb5a678ee4b1e7adaab9985346027ecfc24 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  3c8b70ec3db59a4e6de6a7fb8b1509c4fe228c25 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java
>  c2fee2af1e0f66accdb416f2a1710042ea186d68 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java
>  64c639439db51e00bc293a7ededa248c8ea45bfe 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java
>  d0139ad0b7c7f73e1fa6766869c392f6086678a4 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
>  7f53527e6f76f079b82b0566ac1d293327cf87be 
>   sentry-tests/sentry-tests-solr/pom.xml 
> 723fa9d1991315ed2a182fd5ffcf9974848dbe77 
> 
> 
> Diff: https://reviews.apache.org/r/63856/diff/1/
> 
> 
> Testing
> ---
> 
> All unit tests passed on Jenkins.
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-16 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63856/#review191187
---




sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java
Lines 142 (patched)


some typo in the comment "is data is" should be "its data is"

"added inserted" should be "already inserted"



sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java
Lines 157 (patched)


same issue here



sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java
Lines 127 (patched)


fix typo for added methods



sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
Lines 382 (patched)


is this just temporary solution to return null?

When we want to support row filtering, should we change the implementation 
here?


- Na Li


On Nov. 16, 2017, 1:15 a.m., Sergio Pena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63856/
> ---
> 
> (Updated Nov. 16, 2017, 1:15 a.m.)
> 
> 
> Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and 
> kalyan kumar kalvagadda.
> 
> 
> Bugs: sentry-2048
> https://issues.apache.org/jira/browse/sentry-2048
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> This patch bumps the version of Hive to 2.3.2. There were some Hive 
> configurations that causes conflict with Sentry (see tests about what 
> changed).
> 
> 
> Diffs
> -
> 
>   pom.xml 7476b4f11647d8e2816e531c919f00c073774019 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java
>  d11b2617d5f0a3e4801261c4cfbc05dd2c957e48 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java
>  b531976095a191208c2516424f3bc1260f6ba77f 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryFilterDDLTask.java
>  672acb6316cb58c1430e2296461f794692e9e99e 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
>  61052cf261ecd6111e9b65803a43161e5a3d451c 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
>  802bf9c452f96f6a28e704d645be7d77db4b4011 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
>  d1f071ebb926d99848907359bcdbcf5b7e1b615b 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
>  2e299a9487f624a40dab05d682c83d2525b1461a 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java
>  1596bce925915a56218ad9745ebf3c8648b6c593 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHiveMetaStoreClient.java
>  cfc5c04c057d552fdfe3059d6cdde82ef40c8535 
>   
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
>  de073edc5d803bb87951b46bd5ebe7c38d196667 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
>  95bbaeb5a678ee4b1e7adaab9985346027ecfc24 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
>  3c8b70ec3db59a4e6de6a7fb8b1509c4fe228c25 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java
>  c2fee2af1e0f66accdb416f2a1710042ea186d68 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java
>  64c639439db51e00bc293a7ededa248c8ea45bfe 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java
>  d0139ad0b7c7f73e1fa6766869c392f6086678a4 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
>  7f53527e6f76f079b82b0566ac1d293327cf87be 
>   sentry-tests/sentry-tests-solr/pom.xml 
> 723fa9d1991315ed2a182fd5ffcf9974848dbe77 
> 
>

Review Request 63856: SENTRY-2048: Bump Hive version to 2.3.2

2017-11-15 Thread Sergio Pena via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63856/
---

Review request for sentry, Alexander Kolbasov, Colm O hEigeartaigh, and kalyan 
kumar kalvagadda.


Bugs: sentry-2048
https://issues.apache.org/jira/browse/sentry-2048


Repository: sentry


Description
---

This patch bumps the version of Hive to 2.3.2. There were some Hive 
configurations that causes conflict with Sentry (see tests about what changed).


Diffs
-

  pom.xml 7476b4f11647d8e2816e531c919f00c073774019 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java
 d11b2617d5f0a3e4801261c4cfbc05dd2c957e48 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java
 b531976095a191208c2516424f3bc1260f6ba77f 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryFilterDDLTask.java
 672acb6316cb58c1430e2296461f794692e9e99e 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
 61052cf261ecd6111e9b65803a43161e5a3d451c 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
 802bf9c452f96f6a28e704d645be7d77db4b4011 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
 d1f071ebb926d99848907359bcdbcf5b7e1b615b 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
 2e299a9487f624a40dab05d682c83d2525b1461a 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryHiveAuthorizerImpl.java
 1596bce925915a56218ad9745ebf3c8648b6c593 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHiveMetaStoreClient.java
 cfc5c04c057d552fdfe3059d6cdde82ef40c8535 
  
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java
 de073edc5d803bb87951b46bd5ebe7c38d196667 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java
 95bbaeb5a678ee4b1e7adaab9985346027ecfc24 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java
 3c8b70ec3db59a4e6de6a7fb8b1509c4fe228c25 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java
 c2fee2af1e0f66accdb416f2a1710042ea186d68 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java
 64c639439db51e00bc293a7ededa248c8ea45bfe 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java
 d0139ad0b7c7f73e1fa6766869c392f6086678a4 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java
 7f53527e6f76f079b82b0566ac1d293327cf87be 
  sentry-tests/sentry-tests-solr/pom.xml 
723fa9d1991315ed2a182fd5ffcf9974848dbe77 


Diff: https://reviews.apache.org/r/63856/diff/1/


Testing
---

All unit tests passed on Jenkins.


Thanks,

Sergio Pena