Re: Review Request 66065: SENTRY-2160: Add owner in create table notification event

2018-03-20 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66065/#review199568
---


Ship it!




Ship It!

- Na Li


On March 14, 2018, 2:36 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66065/
> ---
> 
> (Updated March 14, 2018, 2:36 p.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2160
> https://issues.apache.org/jira/browse/SENTRY-2160
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> When creating notification event in SentryJSONCreateTableMessage owner 
> information from the Table instance should be updated properly.
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
>  61d94819816ab281207d14bf68791325af635c11 
>   
> sentry-binding/sentry-binding-hive-follower/src/test/java/org/apache/sentry/binding/metastore/messaging/json/TestSentryJSONCreateTableMessage.java
>  PRE-CREATION 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java
>  61e3f06159ec96f345145cb2b3ed6aac2abbe0ae 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java
>  923fafff128b17981b62f5dcf1e872ab27434b5f 
> 
> 
> Diff: https://reviews.apache.org/r/66065/diff/1/
> 
> 
> Testing
> ---
> 
> Added new tests an also made sure that all the tests passed.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 66065: SENTRY-2160: Add owner in create table notification event

2018-03-20 Thread kalyan kumar kalvagadda via Review Board 


> On March 14, 2018, 3:53 p.m., Na Li wrote:
> > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
> > Line 33 (original), 35 (patched)
> > 
> >
> > need to add change in SentryJSONMessageFactory.java

There are two constrcutors defined for this class. This constructor in not used 
used.


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66065/#review199171
---


On March 14, 2018, 2:36 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66065/
> ---
> 
> (Updated March 14, 2018, 2:36 p.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2160
> https://issues.apache.org/jira/browse/SENTRY-2160
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> When creating notification event in SentryJSONCreateTableMessage owner 
> information from the Table instance should be updated properly.
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
>  61d94819816ab281207d14bf68791325af635c11 
>   
> sentry-binding/sentry-binding-hive-follower/src/test/java/org/apache/sentry/binding/metastore/messaging/json/TestSentryJSONCreateTableMessage.java
>  PRE-CREATION 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java
>  61e3f06159ec96f345145cb2b3ed6aac2abbe0ae 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java
>  923fafff128b17981b62f5dcf1e872ab27434b5f 
> 
> 
> Diff: https://reviews.apache.org/r/66065/diff/1/
> 
> 
> Testing
> ---
> 
> Added new tests an also made sure that all the tests passed.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 66065: SENTRY-2160: Add owner in create table notification event

2018-03-20 Thread kalyan kumar kalvagadda via Review Board 


> On March 14, 2018, 3:45 p.m., Na Li wrote:
> > sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
> > Line 33 (original), 35 (patched)
> > 
> >
> > should the caller that creates this mssge be updated as well? The 
> > constructor should provide different parameters now.

There are two constrcutors defined for this class. This constructor in not used 
used.


- kalyan kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66065/#review199170
---


On March 14, 2018, 2:36 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66065/
> ---
> 
> (Updated March 14, 2018, 2:36 p.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2160
> https://issues.apache.org/jira/browse/SENTRY-2160
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> When creating notification event in SentryJSONCreateTableMessage owner 
> information from the Table instance should be updated properly.
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
>  61d94819816ab281207d14bf68791325af635c11 
>   
> sentry-binding/sentry-binding-hive-follower/src/test/java/org/apache/sentry/binding/metastore/messaging/json/TestSentryJSONCreateTableMessage.java
>  PRE-CREATION 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java
>  61e3f06159ec96f345145cb2b3ed6aac2abbe0ae 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java
>  923fafff128b17981b62f5dcf1e872ab27434b5f 
> 
> 
> Diff: https://reviews.apache.org/r/66065/diff/1/
> 
> 
> Testing
> ---
> 
> Added new tests an also made sure that all the tests passed.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 66065: SENTRY-2160: Add owner in create table notification event

2018-03-14 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66065/#review199171
---




sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
Line 33 (original), 35 (patched)


need to add change in SentryJSONMessageFactory.java


- Na Li


On March 14, 2018, 2:36 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66065/
> ---
> 
> (Updated March 14, 2018, 2:36 p.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2160
> https://issues.apache.org/jira/browse/SENTRY-2160
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> When creating notification event in SentryJSONCreateTableMessage owner 
> information from the Table instance should be updated properly.
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
>  61d94819816ab281207d14bf68791325af635c11 
>   
> sentry-binding/sentry-binding-hive-follower/src/test/java/org/apache/sentry/binding/metastore/messaging/json/TestSentryJSONCreateTableMessage.java
>  PRE-CREATION 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java
>  61e3f06159ec96f345145cb2b3ed6aac2abbe0ae 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java
>  923fafff128b17981b62f5dcf1e872ab27434b5f 
> 
> 
> Diff: https://reviews.apache.org/r/66065/diff/1/
> 
> 
> Testing
> ---
> 
> Added new tests an also made sure that all the tests passed.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Re: Review Request 66065: SENTRY-2160: Add owner in create table notification event

2018-03-14 Thread Na Li via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66065/#review199170
---




sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
Line 33 (original), 35 (patched)


should the caller that creates this mssge be updated as well? The 
constructor should provide different parameters now.


- Na Li


On March 14, 2018, 2:36 p.m., kalyan kumar kalvagadda wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66065/
> ---
> 
> (Updated March 14, 2018, 2:36 p.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2160
> https://issues.apache.org/jira/browse/SENTRY-2160
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> When creating notification event in SentryJSONCreateTableMessage owner 
> information from the Table instance should be updated properly.
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
>  61d94819816ab281207d14bf68791325af635c11 
>   
> sentry-binding/sentry-binding-hive-follower/src/test/java/org/apache/sentry/binding/metastore/messaging/json/TestSentryJSONCreateTableMessage.java
>  PRE-CREATION 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollower.java
>  61e3f06159ec96f345145cb2b3ed6aac2abbe0ae 
>   
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java
>  923fafff128b17981b62f5dcf1e872ab27434b5f 
> 
> 
> Diff: https://reviews.apache.org/r/66065/diff/1/
> 
> 
> Testing
> ---
> 
> Added new tests an also made sure that all the tests passed.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>