Re: Review Request 69201: SENTRY-2436 Add annotations for classes that are used in binding as public
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69201/#review210239 --- Xinran, What is the purpose of such annotation? - kalyan kumar kalvagadda On Oct. 29, 2018, 4:45 p.m., Xinran Tinney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69201/ > --- > > (Updated Oct. 29, 2018, 4:45 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > Sentry bindings are using some of the classes in sentry.core and common. > These classes are annotated as public > > > Diffs > - > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActiveRoleSet.java > c24a6cde > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java > 88457c0d > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java > e36b09a1 > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/DBModelAction.java > c5842d98 > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/DBModelAuthorizable.java > 4ce01b2c > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Database.java > e8dc1406 > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Server.java > 41693c25 > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Table.java > 5a981588 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationProvider.java > aecfe5b5 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java > 761fb527 > > > Diff: https://reviews.apache.org/r/69201/diff/1/ > > > Testing > --- > > mvn clean install > > > Thanks, > > Xinran Tinney > >
Re: Review Request 69201: SENTRY-2436 Add annotations for classes that are used in binding as public
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69201/#review210172 --- Ship it! Ship It! - Sergio Pena On Oct. 29, 2018, 4:45 p.m., Xinran Tinney wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69201/ > --- > > (Updated Oct. 29, 2018, 4:45 p.m.) > > > Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. > > > Repository: sentry > > > Description > --- > > Sentry bindings are using some of the classes in sentry.core and common. > These classes are annotated as public > > > Diffs > - > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActiveRoleSet.java > c24a6cde > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java > 88457c0d > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java > e36b09a1 > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/DBModelAction.java > c5842d98 > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/DBModelAuthorizable.java > 4ce01b2c > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Database.java > e8dc1406 > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Server.java > 41693c25 > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Table.java > 5a981588 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationProvider.java > aecfe5b5 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java > 761fb527 > > > Diff: https://reviews.apache.org/r/69201/diff/1/ > > > Testing > --- > > mvn clean install > > > Thanks, > > Xinran Tinney > >
Review Request 69201: SENTRY-2436 Add annotations for classes that are used in binding as public
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69201/ --- Review request for sentry, kalyan kumar kalvagadda, Na Li, and Sergio Pena. Repository: sentry Description --- Sentry bindings are using some of the classes in sentry.core and common. These classes are annotated as public Diffs - sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActiveRoleSet.java c24a6cde sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Subject.java 88457c0d sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Column.java e36b09a1 sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/DBModelAction.java c5842d98 sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/DBModelAuthorizable.java 4ce01b2c sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Database.java e8dc1406 sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Server.java 41693c25 sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Table.java 5a981588 sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationProvider.java aecfe5b5 sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ProviderBackend.java 761fb527 Diff: https://reviews.apache.org/r/69201/diff/1/ Testing --- mvn clean install Thanks, Xinran Tinney
