Re: Review Request 69501: SENTRY-2466: Create generic sentry store metrics

2018-12-12 Thread Na Li via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69501/#review211250
---


Ship it!




Ship It!

- Na Li


On Dec. 3, 2018, 5:22 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69501/
> ---
> 
> (Updated Dec. 3, 2018, 5:22 p.m.)
> 
> 
> Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and 
> Sergio Pena.
> 
> 
> Bugs: SENTRY-2466
> https://issues.apache.org/jira/browse/SENTRY-2466
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Right now there are no metrics generated for table SENTRY_GM_PRIVILEGE. Thats 
> useful information not being displayed
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>  214d78c53 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  e2d6c85ac 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java
>  e48eea377 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
>  8cea3398f 
> 
> 
> Diff: https://reviews.apache.org/r/69501/diff/1/
> 
> 
> Testing
> ---
> 
> $ mvn -f sentry-service/sentry-service-server/pom.xml test 
> -Dtest=TestSentryPolicyStoreProcessor
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>



Re: Review Request 69501: SENTRY-2466: Create generic sentry store metrics

2018-12-12 Thread Haley Reeve via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69501/#review211236
---


Ship it!




Ship It!

- Haley Reeve


On Dec. 3, 2018, 5:22 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69501/
> ---
> 
> (Updated Dec. 3, 2018, 5:22 p.m.)
> 
> 
> Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and 
> Sergio Pena.
> 
> 
> Bugs: SENTRY-2466
> https://issues.apache.org/jira/browse/SENTRY-2466
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Right now there are no metrics generated for table SENTRY_GM_PRIVILEGE. Thats 
> useful information not being displayed
> 
> 
> Diffs
> -
> 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java
>  214d78c53 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
>  e2d6c85ac 
>   
> sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreInterface.java
>  e48eea377 
>   
> sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryPolicyStoreProcessor.java
>  8cea3398f 
> 
> 
> Diff: https://reviews.apache.org/r/69501/diff/1/
> 
> 
> Testing
> ---
> 
> $ mvn -f sentry-service/sentry-service-server/pom.xml test 
> -Dtest=TestSentryPolicyStoreProcessor
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>