Re: Review Request 69561: SENTRY-2480: Change processDropDatabase to call removeAllPaths
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69561/ --- (Updated Dec. 17, 2018, 6:53 p.m.) Review request for sentry and kalyan kumar kalvagadda. Changes --- Fixed test failure Bugs: SENTRY-2480 https://issues.apache.org/jira/browse/SENTRY-2480 Repository: sentry Description --- Right now it calls removePaths. Remove paths has a bug that it doesn't check if all associated paths are deleted and the object should be deleted Diffs (updated) - sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java ab262d0a8 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestNotificationProcessor.java f227bb458 Diff: https://reviews.apache.org/r/69561/diff/2/ Changes: https://reviews.apache.org/r/69561/diff/1-2/ Testing (updated) --- $ mvn -f sentry-service/sentry-service-server/pom.xml test -Dtest=TestNotificationProcessor Thanks, Arjun Mishra
Re: Review Request 69561: SENTRY-2480: Change processDropDatabase to call removeAllPaths
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69561/#review211257 --- Ship it! Looks good. Wait for the tests to complete. - kalyan kumar kalvagadda On Dec. 12, 2018, 9:19 p.m., Arjun Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69561/ > --- > > (Updated Dec. 12, 2018, 9:19 p.m.) > > > Review request for sentry and kalyan kumar kalvagadda. > > > Bugs: SENTRY-2480 > https://issues.apache.org/jira/browse/SENTRY-2480 > > > Repository: sentry > > > Description > --- > > Right now it calls removePaths. Remove paths has a bug that it doesn't check > if all associated paths are deleted and the object should be deleted > > > Diffs > - > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/NotificationProcessor.java > ab262d0a8 > > > Diff: https://reviews.apache.org/r/69561/diff/1/ > > > Testing > --- > > > Thanks, > > Arjun Mishra > >
Review Request 69561: SENTRY-2480: Change processDropDatabase to call removeAllPaths
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69561/ --- Review request for sentry and kalyan kumar kalvagadda. Bugs: SENTRY-2480 https://issues.apache.org/jira/browse/SENTRY-2480 Repository: sentry Description --- Right now it calls removePaths. Remove paths has a bug that it doesn't check if all associated paths are deleted and the object should be deleted Testing --- Thanks, Arjun Mishra
