Re: Review Request 69832: SENTRY-2488: Add privilege cache to sentry hive bindings in DefaultAccessValidator

[Arjun Mishra via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69832/
---

(Updated Jan. 29, 2019, 6:47 p.m.)


Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, and Na Li.


Changes
---

Fixed a bug where we try to clear an Immutable Set.


Bugs: SENTRY-2488
https://issues.apache.org/jira/browse/SENTRY-2488


Repository: sentry


Description
---

We are not consistent with behavior in SentryHiveMetaStoreHook (not used 
anymore) which would cache privileges when authorizing show databases or show 
tables command. This needs to be added back


Diffs (updated)
-

  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
 9de47b338 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
 63d8d1c09 
  
sentry-provider/sentry-provider-cache/src/main/java/org/apache/sentry/provider/cache/SimplePrivilegeCache.java
 0ad4616c0 


Diff: https://reviews.apache.org/r/69832/diff/3/

Changes: https://reviews.apache.org/r/69832/diff/2-3/


Testing
---


Thanks,

Arjun Mishra

Re: Review Request 69832: SENTRY-2488: Add privilege cache to sentry hive bindings in DefaultAccessValidator

[Arjun Mishra via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69832/
---

(Updated Jan. 24, 2019, 9:35 p.m.)


Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, and Na Li.


Changes
---

Post feebdack


Bugs: SENTRY-2488
https://issues.apache.org/jira/browse/SENTRY-2488


Repository: sentry


Description
---

We are not consistent with behavior in SentryHiveMetaStoreHook (not used 
anymore) which would cache privileges when authorizing show databases or show 
tables command. This needs to be added back


Diffs (updated)
-

  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
 9de47b338 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
 63d8d1c09 


Diff: https://reviews.apache.org/r/69832/diff/2/

Changes: https://reviews.apache.org/r/69832/diff/1-2/


Testing
---


Thanks,

Arjun Mishra

Re: Review Request 69832: SENTRY-2488: Add privilege cache to sentry hive bindings in DefaultAccessValidator

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69832/#review212289
---


Fix it, then Ship it!




Fix it and ship it.


sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
Lines 248-250 (original), 247-256 (patched)


Add comments to new API explaining what it does.



sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
Line 831 (original), 831 (patched)


This need not be a public API. Instead you could use no modifier limititng 
it to the package.


- kalyan kumar kalvagadda


On Jan. 24, 2019, 6:23 p.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69832/
> ---
> 
> (Updated Jan. 24, 2019, 6:23 p.m.)
> 
> 
> Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: SENTRY-2488
> https://issues.apache.org/jira/browse/SENTRY-2488
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> We are not consistent with behavior in SentryHiveMetaStoreHook (not used 
> anymore) which would cache privileges when authorizing show databases or show 
> tables command. This needs to be added back
> 
> 
> Diffs
> -
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
>  9de47b338 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
>  63d8d1c09 
> 
> 
> Diff: https://reviews.apache.org/r/69832/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Review Request 69832: SENTRY-2488: Add privilege cache to sentry hive bindings in DefaultAccessValidator

[Arjun Mishra via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69832/
---

Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, and Na Li.


Bugs: SENTRY-2488
https://issues.apache.org/jira/browse/SENTRY-2488


Repository: sentry


Description
---

We are not consistent with behavior in SentryHiveMetaStoreHook (not used 
anymore) which would cache privileges when authorizing show databases or show 
tables command. This needs to be added back


Diffs
-

  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/DefaultSentryValidator.java
 9de47b338 
  
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBindingHookBase.java
 63d8d1c09 


Diff: https://reviews.apache.org/r/69832/diff/1/


Testing
---


Thanks,

Arjun Mishra