Re: Review Request 70337: SENTRY-2511: Debug level logging on HMSPaths significantly affects performance

[kalyan kumar kalvagadda via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70337/#review214210
---


Ship it!




Looks good.

- kalyan kumar kalvagadda


On March 29, 2019, 1:01 a.m., Arjun Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70337/
> ---
> 
> (Updated March 29, 2019, 1:01 a.m.)
> 
> 
> Review request for sentry and kalyan kumar kalvagadda.
> 
> 
> Bugs: SENTRY-2511
> https://issues.apache.org/jira/browse/SENTRY-2511
> 
> 
> Repository: sentry
> 
> 
> Description
> ---
> 
> Newer logging changes were made to HMSPath to help identify the corrupt 
> cache. However when there are large number of partitions logging changes made 
> makes the processing or creation of an update very slow
> 
> 
> Diffs
> -
> 
>   
> sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
>  c49e24427 
> 
> 
> Diff: https://reviews.apache.org/r/70337/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Arjun Mishra
> 
>

Review Request 70337: SENTRY-2511: Debug level logging on HMSPaths significantly affects performance

[Arjun Mishra via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70337/
---

Review request for sentry and kalyan kumar kalvagadda.


Bugs: SENTRY-2511
https://issues.apache.org/jira/browse/SENTRY-2511


Repository: sentry


Description
---

Newer logging changes were made to HMSPath to help identify the corrupt cache. 
However when there are large number of partitions logging changes made makes 
the processing or creation of an update very slow


Diffs
-

  
sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/HMSPaths.java
 c49e24427 


Diff: https://reviews.apache.org/r/70337/diff/1/


Testing
---


Thanks,

Arjun Mishra