Re: [DISCUSSION][Samples] E-commerce sample project want to merge into servicecomb-samples
Please submit your PR step by step, you can submit several PRs with small change set (less than 1000 lines of change). No one can review a big PR once. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Fri, Nov 15, 2019 at 3:13 PM 郑志鹏 wrote: > > Hi, > Yes, That's application I mean, but the already existed houserush > directory in master branch is just a framework without any code. There is > also a houserush-sample branch which have some early stage code in it. > We already developed a full functional application with 2 passionate > guys. And for now, I want to submit a big PR.
Re: [DISCUSSION][Samples] E-commerce sample project want to merge into servicecomb-samples
Hi, Yes, That's application I mean, but the already existed houserush directory in master branch is just a framework without any code. There is also a houserush-sample branch which have some early stage code in it. We already developed a full functional application with 2 passionate guys. And for now, I want to submit a big PR.
Re: [DISCUSSION][Samples] E-commerce sample project want to merge into servicecomb-samples
Is there any update of your project. I just realized there is a houserush application[1] in the servicecomb-samples. Do you mean the same project here? [1]https://github.com/apache/servicecomb-samples/tree/master/houserush Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Nov 12, 2019 at 8:27 PM Willem Jiang wrote: > > Could you share the link of your project? > BTW, as all the samples are separated, we don't need to create another > branch for merging it. > > Willem Jiang > > Twitter: willemjiang > Weibo: 姜宁willem > > On Tue, Nov 12, 2019 at 11:16 AM 郑志鹏 wrote: > > > > Hi, All > > > > I have created e-commerce project as a ServiceComb sample project for user > > guiding purpose with two other passionate guys. It's not perfect but it's > > working. I want merge it into servicecomb-samples first, so there maybe > > have more people would want to work with us to optimize it together. We > > can merge it into a non-master branch first. > > > > -- > > Best Wishes & Regards > > ——— > > Alec Zheng
Re: [DISCUSSION][Samples] E-commerce sample project want to merge into servicecomb-samples
+1 and feel free to raise the PR. 郑志鹏 于2019年11月12日周二 上午11:16写道： > Hi, All > > I have created e-commerce project as a ServiceComb sample project for user > guiding purpose with two other passionate guys. It's not perfect but it's > working. I want merge it into servicecomb-samples first, so there maybe > have more people would want to work with us to optimize it together. We > can merge it into a non-master branch first. > > -- > Best Wishes & Regards > ——— > Alec Zheng >
Re: [DISCUSSION][Samples] E-commerce sample project want to merge into servicecomb-samples
Could you share the link of your project? BTW, as all the samples are separated, we don't need to create another branch for merging it. Willem Jiang Twitter: willemjiang Weibo: 姜宁willem On Tue, Nov 12, 2019 at 11:16 AM 郑志鹏 wrote: > > Hi, All > > I have created e-commerce project as a ServiceComb sample project for user > guiding purpose with two other passionate guys. It's not perfect but it's > working. I want merge it into servicecomb-samples first, so there maybe > have more people would want to work with us to optimize it together. We > can merge it into a non-master branch first. > > -- > Best Wishes & Regards > ——— > Alec Zheng
