[GitHub] WillemJiang commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center
WillemJiang commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160025526 ## File path: spring-boot-starter/spring-boot-starter-discovery/src/main/java/io/servicecomb/springboot/starter/discovery/CseRoutesProperties.java ## @@ -1,42 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed with - * this work for additional information regarding copyright ownership. - * The ASF licenses this file to You under the Apache License, Version 2.0 - * (the "License"); you may not use this file except in compliance with - * the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package io.servicecomb.springboot.starter.discovery; Review comment: Why do we remove this package? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] WillemJiang commented on a change in pull request #492: [SCB-184]Provide starters for Spring Cloud to using service-center and config-center
WillemJiang commented on a change in pull request #492: [SCB-184]Provide
starters for Spring Cloud to using service-center and config-center
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160025475
##
File path:
spring-boot-starter/spring-boot-starter-discovery/src/main/java/io/servicecomb/springboot/starter/discovery/CseDiscoveryClientConfiguration.java
##
@@ -17,33 +17,17 @@
package io.servicecomb.springboot.starter.discovery;
import org.springframework.boot.autoconfigure.AutoConfigureBefore;
-import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.cloud.client.discovery.DiscoveryClient;
import
org.springframework.cloud.client.discovery.noop.NoopDiscoveryClientAutoConfiguration;
-import org.springframework.cloud.netflix.zuul.filters.ZuulProperties;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
-import org.springframework.context.annotation.Primary;
-
-import io.servicecomb.core.provider.consumer.ConsumerProviderManager;
+import org.springframework.core.annotation.Order;
@AutoConfigureBefore(NoopDiscoveryClientAutoConfiguration.class)
@Configuration
public class CseDiscoveryClientConfiguration {
-
- @Bean
- public CseDiscoveryProperties cseDiscoveryProperties() {
-return new CseDiscoveryProperties();
- }
-
- @Bean
- @ConditionalOnBean(ZuulProperties.class)
- public CseRoutesProperties cseRoutesProperties(ConsumerProviderManager
manager) {
-return new CseRoutesProperties(manager);
- }
-
@Bean
- @Primary
+ @Order(5000)
Review comment:
Is there any other client need to be found?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
