[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-12 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r181286536
 
 

 ##
 File path: 
demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
 ##
 @@ -147,4 +168,73 @@ private static void testRawJsonParam(RestTemplate 
template, String cseUrlPrefix)
 TestMgr.check("hello Tom",
 template.postForObject(cseUrlPrefix + "/compute/testrawjson", 
jsonPerson, String.class));
   }
+
+  private static void testValidatorAddFail(RestTemplate template, String 
cseUrlPrefix) {
+Map params = new HashMap<>();
+params.put("a", "5");
+params.put("b", "3");
+boolean isExcep = false;
+try {
+  template.postForObject(cseUrlPrefix + "add", params, Integer.class);
+} catch (InvocationException e) {
+  isExcep = true;
+  TestMgr.check(490, e.getStatus().getStatusCode());
+}
+
+TestMgr.check(true, isExcep);
+  }
+
+  private static void testValidatorAddSuccess(RestTemplate template, String 
cseUrlPrefix) {
+Map params = new HashMap<>();
+params.put("a", "5");
+params.put("b", "20");
+int result = template.postForObject(cseUrlPrefix + "add", params, 
Integer.class);
+TestMgr.check(25, result);
+  }
+
+  private static void testValidatorSayHiFail(RestTemplate template, String 
cseUrlPrefix) {
+boolean isExcep = false;
+try {
+  template.exchange(cseUrlPrefix + "sayhi/{name}", HttpMethod.PUT, null, 
String.class, "te");
+} catch (InvocationException e) {
+  isExcep = true;
+  TestMgr.check(490, e.getStatus().getStatusCode());
+}
+TestMgr.check(true, isExcep);
+  }
+
+  private static void testValidatorSayHiSuccess(RestTemplate template, String 
cseUrlPrefix) {
+ResponseEntity responseEntity =
+template.exchange(cseUrlPrefix + "sayhi/{name}", HttpMethod.PUT, null, 
String.class, "world");
+TestMgr.check(202, responseEntity.getStatusCode());
+TestMgr.check("world sayhi", responseEntity.getBody());
+  }
+
+  private static void testValidatorExchangeFail(RestTemplate template, String 
cseUrlPrefix) {
+HttpHeaders headers = new HttpHeaders();
+headers.add("Accept", MediaType.APPLICATION_JSON);
+Student student = new Student();
+student.setName("");
+student.setAge(25);
+boolean isExcep = false;
+try {
+  HttpEntity requestEntity = new HttpEntity<>(student, headers);
+  template.exchange(cseUrlPrefix + "/sayhello",
+  HttpMethod.POST,
+  requestEntity,
+  Student.class);
+} catch (InvocationException e) {
+  isExcep = true;
+  TestMgr.check(490, e.getStatus().getStatusCode());
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-12 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r181286527
 
 

 ##
 File path: 
demo/demo-jaxrs/jaxrs-client/src/main/java/org/apache/servicecomb/demo/jaxrs/client/JaxrsClient.java
 ##
 @@ -147,4 +168,73 @@ private static void testRawJsonParam(RestTemplate 
template, String cseUrlPrefix)
 TestMgr.check("hello Tom",
 template.postForObject(cseUrlPrefix + "/compute/testrawjson", 
jsonPerson, String.class));
   }
+
+  private static void testValidatorAddFail(RestTemplate template, String 
cseUrlPrefix) {
+Map params = new HashMap<>();
+params.put("a", "5");
+params.put("b", "3");
+boolean isExcep = false;
+try {
+  template.postForObject(cseUrlPrefix + "add", params, Integer.class);
+} catch (InvocationException e) {
+  isExcep = true;
+  TestMgr.check(490, e.getStatus().getStatusCode());
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-09 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r180302280
 
 

 ##
 File path: 
demo/demo-validator/validator-client/src/main/java/org/apache/servicecomb/demo/validator/client/CodeFirstValidatorRestTemplate.java
 ##
 @@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.validator.client;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import org.apache.servicecomb.core.Const;
+import org.apache.servicecomb.core.CseContext;
+import org.apache.servicecomb.demo.DemoConst;
+import org.apache.servicecomb.demo.TestMgr;
+import org.apache.servicecomb.swagger.invocation.context.ContextUtils;
+import org.apache.servicecomb.swagger.invocation.context.InvocationContext;
+import org.springframework.http.HttpMethod;
+import org.springframework.http.HttpStatus;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.client.RestTemplate;
+
+public class CodeFirstValidatorRestTemplate {
+  protected void changeTransport(String microserviceName, String transport) {
+
CseContext.getInstance().getConsumerProviderManager().setTransport(microserviceName,
 transport);
+TestMgr.setMsg(microserviceName, transport);
+  }
+
+  public void testCodeFirst(RestTemplate template, String microserviceName, 
String basePath) {
+String cseUrlPrefix = "cse://" + microserviceName + basePath;
+for (String transport : DemoConst.transports) {
+  changeTransport(microserviceName, transport);
+  testAllTransport(microserviceName, template, cseUrlPrefix);
+}
+  }
+
+  protected void testAllTransport(String microserviceName, RestTemplate 
template, String cseUrlPrefix) {
+testCodeFirstAdd(template, cseUrlPrefix);
+testCodeFirstAddForException(template, cseUrlPrefix);
+testCodeFirstSayHi(template, cseUrlPrefix);
+testCodeFirstSayHiForException(template, cseUrlPrefix);
+testTraceIdOnContextContainsTraceId(template, cseUrlPrefix);
+  }
+
+  protected void checkStatusCode(String microserviceName, int 
expectStatusCode, HttpStatus httpStatus) {
+TestMgr.check(expectStatusCode, httpStatus.value());
+  }
+
+  protected void testCodeFirstSayHi(RestTemplate template, String 
cseUrlPrefix) {
+ResponseEntity responseEntity =
+template.exchange(cseUrlPrefix + "sayhi/{name}", HttpMethod.PUT, null, 
String.class, "world");
+TestMgr.check(202, responseEntity.getStatusCode());
+TestMgr.check("world sayhi", responseEntity.getBody());
+  }
+
+  protected void testCodeFirstSayHiForException(RestTemplate template, String 
cseUrlPrefix) {
+boolean isExcep = false;
+try {
+  template.exchange(cseUrlPrefix + "sayhi/{name}", HttpMethod.PUT, null, 
String.class, "te");
+} catch (Exception e) {
+  isExcep = true;
+}
+TestMgr.check(true, isExcep);
+  }
+
+  protected void testCodeFirstAdd(RestTemplate template, String cseUrlPrefix) {
+Map params = new HashMap<>();
+params.put("a", "5");
+params.put("b", "20");
+int result =
+template.postForObject(cseUrlPrefix + "add", params, Integer.class);
+TestMgr.check(25, result);
+  }
+
+  protected void testCodeFirstAddForException(RestTemplate template, String 
cseUrlPrefix) {
+Map params = new HashMap<>();
+params.put("a", "5");
+params.put("b", "3");
+boolean isExcep = false;
+try {
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-09 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r180302115
 
 

 ##
 File path: demo/demo-validator/pom.xml
 ##
 @@ -0,0 +1,35 @@
+
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+   xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+   4.0.0
+   
+   org.apache.servicecomb.demo
+   demo-parent
+   1.0.0-m2-SNAPSHOT
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-09 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r180302126
 
 

 ##
 File path: demo/demo-validator/validator-client/pom.xml
 ##
 @@ -0,0 +1,58 @@
+
+
+
+http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;
+   xmlns="http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;>
+   4.0.0
+   
+   org.apache.servicecomb.demo
+   demo-validator
+   1.0.0-m2-SNAPSHOT
+   
+   validator-client
+   Java Chassis::Demo::Validator::Client
+
+   
+   
+   org.apache.servicecomb.demo
+   demo-schema
+   
+   
+   org.apache.servicecomb
+   provider-jaxrs
+   
+   
+   org.apache.servicecomb
+   provider-springmvc
+   
+   
+
+   
+   
org.apache.servicecomb.demo.jaxrs.client.JaxrsClient
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-09 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r180302239
 
 

 ##
 File path: 
demo/demo-validator/validator-client/src/main/java/org/apache/servicecomb/demo/validator/client/CodeFirstRestTemplateValidator.java
 ##
 @@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.demo.validator.client;
+
+import org.apache.servicecomb.demo.CodeFirstRestTemplate;
+import org.apache.servicecomb.demo.TestMgr;
+import org.springframework.web.client.RestTemplate;
+
+public class CodeFirstRestTemplateValidator extends CodeFirstRestTemplate {
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-09 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r180301954
 
 

 ##
 File path: 
core/src/test/java/org/apache/servicecomb/core/definition/schema/TestProducerSchemaFactory.java
 ##
 @@ -1,5 +1,5 @@
 /*
- * Licensed to the Apache Software Foundation (ASF) under one or more
+* Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-09 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r18288
 
 

 ##
 File path: 
swagger/swagger-invocation/invocation-validator/src/main/java/org/apache/servicecomb/swagger/invocation/validator/ParameterValidator.java
 ##
 @@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.swagger.invocation.validator;
+
+import java.util.Set;
+
+import javax.validation.ConstraintViolation;
+import javax.validation.ConstraintViolationException;
+import javax.validation.Validation;
+import javax.validation.ValidatorFactory;
+import javax.validation.executable.ExecutableValidator;
+import javax.validation.groups.Default;
+
+import org.apache.servicecomb.swagger.engine.SwaggerProducerOperation;
+import org.apache.servicecomb.swagger.invocation.SwaggerInvocation;
+import 
org.apache.servicecomb.swagger.invocation.extension.ProducerInvokeExtension;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ParameterValidator implements ProducerInvokeExtension {
+
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(ParameterValidator.class);
+
+  private static ExecutableValidator executableValidator;
+
+  @Override
+  public  void beforeMethodInvoke(SwaggerInvocation invocation, 
SwaggerProducerOperation producerOperation,
+  Object[] args)
+  throws ConstraintViolationException {
+
+if (null == executableValidator) {
+  ValidatorFactory factory = Validation.buildDefaultValidatorFactory();
+  executableValidator = factory.getValidator().forExecutables();
+}
+Set violations =
+
executableValidator.validateParameters(producerOperation.getProducerInstance(),
+producerOperation.getProducerMethod(),
+args,
+Default.class);
+if (violations.size() > 0) {
+  LOGGER.warn("Parameter validation failed : " + violations.toString());
+  throw new ConstraintViolationException(violations.toString(), 
violations);
+}
+  }
+
+  @Override
+  public int getOrder() {
+return 100;
 
 Review comment:
   When user custom exception with higher order , it will override the default 
behavior, user can customize the error codes, message ..etc.The same is tested.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-09 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r17479
 
 

 ##
 File path: 
swagger/swagger-invocation/invocation-validator/src/main/java/org/apache/servicecomb/swagger/invocation/validator/ParameterValidator.java
 ##
 @@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.swagger.invocation.validator;
+
+import java.util.Set;
+
+import javax.validation.ConstraintViolation;
+import javax.validation.ConstraintViolationException;
+import javax.validation.Validation;
+import javax.validation.ValidatorFactory;
+import javax.validation.executable.ExecutableValidator;
+import javax.validation.groups.Default;
+
+import org.apache.servicecomb.swagger.engine.SwaggerProducerOperation;
+import org.apache.servicecomb.swagger.invocation.SwaggerInvocation;
+import 
org.apache.servicecomb.swagger.invocation.extension.ProducerInvokeExtension;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class ParameterValidator implements ProducerInvokeExtension {
+
+  private static final Logger LOGGER = 
LoggerFactory.getLogger(ParameterValidator.class);
+
+  private static ExecutableValidator executableValidator;
+
+  @Override
+  public  void beforeMethodInvoke(SwaggerInvocation invocation, 
SwaggerProducerOperation producerOperation,
+  Object[] args)
+  throws ConstraintViolationException {
+
+if (null == executableValidator) {
+  ValidatorFactory factory = Validation.buildDefaultValidatorFactory();
+  executableValidator = factory.getValidator().forExecutables();
+}
+Set violations =
+
executableValidator.validateParameters(producerOperation.getProducerInstance(),
+producerOperation.getProducerMethod(),
+args,
+Default.class);
+if (violations.size() > 0) {
+  LOGGER.warn("Parameter validation failed : " + violations.toString());
+  throw new ConstraintViolationException(violations.toString(), 
violations);
 
 Review comment:
   Fixed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-09 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r179997373
 
 

 ##
 File path: 
swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/extension/ProducerInvokeExtension.java
 ##
 @@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.swagger.invocation.extension;
+
+import org.apache.servicecomb.swagger.engine.SwaggerProducerOperation;
+import org.apache.servicecomb.swagger.invocation.SwaggerInvocation;
+
+
+public interface ProducerInvokeExtension {
+
+  public int getOrder();
+
+   void beforeMethodInvoke(SwaggerInvocation invocation, 
SwaggerProducerOperation producerOperation,
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-04-08 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r179983363
 
 

 ##
 File path: 
swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/exception/ExceptionToResponseConverter.java
 ##
 @@ -22,5 +22,9 @@
 public interface ExceptionToResponseConverter {
   Class getExceptionClass();
 
+  default int getOrder() {
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-03-30 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r178294392
 
 

 ##
 File path: swagger/swagger-invocation/invocation-core/pom.xml
 ##
 @@ -37,6 +37,14 @@
swagger-generator-jaxrs
test

+   
 
 Review comment:
   fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] acsukesh commented on a change in pull request #627: [SCB-292] chassis support standard parameter validation

2018-03-30 Thread GitBox
acsukesh commented on a change in pull request #627: [SCB-292] chassis support 
standard parameter validation
URL: 
https://github.com/apache/incubator-servicecomb-java-chassis/pull/627#discussion_r178243832
 
 

 ##
 File path: 
swagger/swagger-invocation/invocation-core/src/main/java/org/apache/servicecomb/swagger/invocation/extension/AbstractProducerInvokeExtension.java
 ##
 @@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.swagger.invocation.extension;
+
+public abstract class AbstractProducerInvokeExtension implements 
ProducerInvokeExtension {
 
 Review comment:
   Fixed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services