[GitHub] codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data
codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674481 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=h1) Report > Merging [#346](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/f55a89ceacb4bebf79c33c917402076b2aeaed2d?src=pr=desc) will **increase** coverage by `0.02%`. > The diff coverage is `80%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=tree) ```diff @@Coverage Diff @@ ## master #346 +/- ## == + Coverage 69.92% 69.95% +0.02% == Files 17 17 Lines3412 3418 +6 == + Hits 2386 2391 +5 - Misses861 863 +2 + Partials 165 164 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `71.32% <100%> (+0.18%)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `48.36% <75%> (+0.61%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=footer). Last update [f55a89c...a3883fe](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data
codecov-io commented on issue #346: SCB-565 Register instance with the same id will create redundant endpoint index data URL: https://github.com/apache/incubator-servicecomb-service-center/pull/346#issuecomment-387674481 # [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=h1) Report > Merging [#346](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/f55a89ceacb4bebf79c33c917402076b2aeaed2d?src=pr=desc) will **decrease** coverage by `0.45%`. > The diff coverage is `80%`. [](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=tree) ```diff @@Coverage Diff @@ ## master #346 +/- ## == - Coverage 69.92% 69.47% -0.46% == Files 17 17 Lines3412 3420 +8 == - Hits 2386 2376 -10 - Misses861 880 +19 + Partials 165 164 -1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=tree) | Coverage Δ | | |---|---|---| | [server/service/instances.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvaW5zdGFuY2VzLmdv) | `71.13% <100%> (ø)` | :arrow_up: | | [server/service/util/instance\_util.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9pbnN0YW5jZV91dGlsLmdv) | `48.92% <77.77%> (+1.17%)` | :arrow_up: | | [server/service/util/dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `53.92% <0%> (-2.62%)` | :arrow_down: | | [server/service/rule.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346/diff?src=pr=tree#diff-c2VydmVyL3NlcnZpY2UvcnVsZS5nbw==) | `77.25% <0%> (+0.42%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=footer). Last update [f55a89c...a3883fe](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/346?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
