Re: [DISCUSSION][Toolkit] Integrate oas-validator compliance functionality

2019-11-05 Thread Bin Ma
Sure,I think it is feasible.


Wishes & Regards
---
Mabin



Daniel Qian  于2019年11月5日周二 下午1:43写道:

> Hi Ma, since we discussed about compatibility check sub command to be:
> cc / checkcompatibility .[1]
> So, we can also use cs / checkstyle here.
>
> [1]:
> https://lists.apache.org/thread.html/c88cda03ec52182482679bd9be36b9ad57bc8d03ee43a4912ad38d90@%3Cdev.servicecomb.apache.org%3E
>
> Daniel Qian  于2019年11月1日周五 下午5:11写道:
> >
> > PR[1] created
> >
> > [1] https://github.com/apache/servicecomb-toolkit/pull/42
> >
> > Willem Jiang  于2019年11月1日周五 下午12:26写道:
> > >
> > > Hi Daniel
> > >
> > > Yeah, I think it's a very good idea.
> > > Looking forward your PR.
> > >
> > > Willem Jiang
> > >
> > > Twitter: willemjiang
> > > Weibo: 姜宁willem
> > >
> > > On Wed, Oct 30, 2019 at 10:31 AM Daniel Qian 
> wrote:
> > > >
> > > > I created an issue SCB-1553[1] to integrate oas-validator compliance
> > > > check to toolkit cli.
> > > >
> > > > I suggest the usage like this:
> > > >
> > > > java -jar toolkit-cli-{version}.jar checkstyle
> /path/to/openapiv3.yaml
> > > >
> > > > I prefer checksytle because of it's clearer than compliance.
> > > >
> > > > oas-validator compliance doc could be found here[2]
> > > >
> > > > [1] https://issues.apache.org/jira/projects/SCB/issues/SCB-1553
> > > > [2]
> https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%90%88%E8%A7%84%E6%80%A7%E6%A0%A1%E9%AA%8C
> > > >
> > > > --
> > > > Daniel Qian
> > > >
> > > > 博客:https://segmentfault.com/u/chanjarster
> > > > github:https://github.com/chanjarster
> >
> >
> >
> > --
> > Daniel Qian
> >
> > 博客:https://segmentfault.com/u/chanjarster
> > github:https://github.com/chanjarster
>
>
>
> --
> Daniel Qian
>
> 博客:https://segmentfault.com/u/chanjarster
> github:https://github.com/chanjarster
>


Re: [DISCUSSION][Toolkit] Integrate oas-validator compliance functionality

2019-11-04 Thread Daniel Qian
Hi Ma, since we discussed about compatibility check sub command to be:
cc / checkcompatibility .[1]
So, we can also use cs / checkstyle here.

[1]: 
https://lists.apache.org/thread.html/c88cda03ec52182482679bd9be36b9ad57bc8d03ee43a4912ad38d90@%3Cdev.servicecomb.apache.org%3E

Daniel Qian  于2019年11月1日周五 下午5:11写道:
>
> PR[1] created
>
> [1] https://github.com/apache/servicecomb-toolkit/pull/42
>
> Willem Jiang  于2019年11月1日周五 下午12:26写道:
> >
> > Hi Daniel
> >
> > Yeah, I think it's a very good idea.
> > Looking forward your PR.
> >
> > Willem Jiang
> >
> > Twitter: willemjiang
> > Weibo: 姜宁willem
> >
> > On Wed, Oct 30, 2019 at 10:31 AM Daniel Qian  wrote:
> > >
> > > I created an issue SCB-1553[1] to integrate oas-validator compliance
> > > check to toolkit cli.
> > >
> > > I suggest the usage like this:
> > >
> > > java -jar toolkit-cli-{version}.jar checkstyle /path/to/openapiv3.yaml
> > >
> > > I prefer checksytle because of it's clearer than compliance.
> > >
> > > oas-validator compliance doc could be found here[2]
> > >
> > > [1] https://issues.apache.org/jira/projects/SCB/issues/SCB-1553
> > > [2] 
> > > https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%90%88%E8%A7%84%E6%80%A7%E6%A0%A1%E9%AA%8C
> > >
> > > --
> > > Daniel Qian
> > >
> > > 博客:https://segmentfault.com/u/chanjarster
> > > github:https://github.com/chanjarster
>
>
>
> --
> Daniel Qian
>
> 博客:https://segmentfault.com/u/chanjarster
> github:https://github.com/chanjarster



-- 
Daniel Qian

博客:https://segmentfault.com/u/chanjarster
github:https://github.com/chanjarster


Re: [DISCUSSION][Toolkit] Integrate oas-validator compliance functionality

2019-11-01 Thread Daniel Qian
PR[1] created

[1] https://github.com/apache/servicecomb-toolkit/pull/42

Willem Jiang  于2019年11月1日周五 下午12:26写道:
>
> Hi Daniel
>
> Yeah, I think it's a very good idea.
> Looking forward your PR.
>
> Willem Jiang
>
> Twitter: willemjiang
> Weibo: 姜宁willem
>
> On Wed, Oct 30, 2019 at 10:31 AM Daniel Qian  wrote:
> >
> > I created an issue SCB-1553[1] to integrate oas-validator compliance
> > check to toolkit cli.
> >
> > I suggest the usage like this:
> >
> > java -jar toolkit-cli-{version}.jar checkstyle /path/to/openapiv3.yaml
> >
> > I prefer checksytle because of it's clearer than compliance.
> >
> > oas-validator compliance doc could be found here[2]
> >
> > [1] https://issues.apache.org/jira/projects/SCB/issues/SCB-1553
> > [2] 
> > https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%90%88%E8%A7%84%E6%80%A7%E6%A0%A1%E9%AA%8C
> >
> > --
> > Daniel Qian
> >
> > 博客:https://segmentfault.com/u/chanjarster
> > github:https://github.com/chanjarster



-- 
Daniel Qian

博客:https://segmentfault.com/u/chanjarster
github:https://github.com/chanjarster


Re: [DISCUSSION][Toolkit] Integrate oas-validator compliance functionality

2019-10-31 Thread Willem Jiang
Hi Daniel

Yeah, I think it's a very good idea.
Looking forward your PR.

Willem Jiang

Twitter: willemjiang
Weibo: 姜宁willem

On Wed, Oct 30, 2019 at 10:31 AM Daniel Qian  wrote:
>
> I created an issue SCB-1553[1] to integrate oas-validator compliance
> check to toolkit cli.
>
> I suggest the usage like this:
>
> java -jar toolkit-cli-{version}.jar checkstyle /path/to/openapiv3.yaml
>
> I prefer checksytle because of it's clearer than compliance.
>
> oas-validator compliance doc could be found here[2]
>
> [1] https://issues.apache.org/jira/projects/SCB/issues/SCB-1553
> [2] 
> https://github.com/apache/servicecomb-toolkit/blob/import-oas-validator/oas-validator/README.md#%E5%90%88%E8%A7%84%E6%80%A7%E6%A0%A1%E9%AA%8C
>
> --
> Daniel Qian
>
> 博客:https://segmentfault.com/u/chanjarster
> github:https://github.com/chanjarster