[GitHub] [shiro] fpapon commented on issue #137: Build
fpapon commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-496602102 > Thanks for taking this on! > > I think we should try to simplify this a little more to make this easier for contributors. > Maybe ending with something like `mvn clean install -Pci` or possibly three options "normal", `ci`, `fast` > Anything more advanced, and someone can start adding other maven plugin flags? > > Thinking (typing) out loud, but my main concern is when submodules are hidden behind profiles, IDE's and cross project dependencies can start seeing issues that are not obvious at first. My personal pref is to to still process the module, but skip the tests via a profile (this assumes that the compile/packaging is fast enough to impact developers) >  Yeah I like it :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [shiro] fpapon commented on a change in pull request #137: Build
fpapon commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r288206310 ## File path: pom.xml ## @@ -1474,5 +1478,54 @@ + +samples + +samples + + + +rat + +integration-tests +test-coverage +samples + + +apache-rat:check + + +org.apache.rat +apache-rat-plugin +0.12 + +false + + +verify + +check + + + + Review comment: I add a rat profile because I move some module out of the default build, so the plugin failed to scan them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [shiro] bdemers commented on issue #137: Build
bdemers commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-496511288 Thanks for taking this on! I think we should try to simplify this a little more to make this easier for contributors. Maybe ending with something like `mvn clean install -Pci` or possibly three options "normal", `ci`, `fast` Anything more advanced, and someone can start adding other maven plugin flags? Thinking (typing) out loud, but my main concern is when submodules are hidden behind profiles, IDE's and cross project dependencies can start seeing issues that are not obvious at first. My personal pref is to to still process the module, but skip the tests via a profile (this assumes that the compile/packaging is fast enough to impact developers)  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
