[GitHub] [shiro] asfgit commented on issue #140: Reduce shiro test logging level to INFO
asfgit commented on issue #140: Reduce shiro test logging level to INFO URL: https://github.com/apache/shiro/pull/140#issuecomment-497857314 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/99/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [shiro] bdemers commented on issue #140: Reduce shiro test logging level to INFO
bdemers commented on issue #140: Reduce shiro test logging level to INFO URL: https://github.com/apache/shiro/pull/140#issuecomment-497839283 @fpapon, related to your build cleanup PRs I have mixed feelings about this, as generally I think extra logging is useful for CI, but in general I would typically just run the test locally and configure the logging i'd need at that point. Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [shiro] asfgit commented on issue #137: Build
asfgit commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-497836128 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/Shiro-pr/98/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [shiro] bdemers commented on a change in pull request #137: Build
bdemers commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r289524251 ## File path: pom.xml ## @@ -1457,6 +1468,9 @@ ci + +false + Review comment: WOW, I didn't realize how slow the jacoco merge was. I haven't seen this with other builds This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [shiro] fpapon commented on a change in pull request #137: Build
fpapon commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r289519208 ## File path: pom.xml ## @@ -1354,6 +1355,16 @@ + +fast + +true +true + + +clean install Review comment: ok I will remove clean goal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [shiro] bdemers commented on a change in pull request #137: Build
bdemers commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r289518821 ## File path: pom.xml ## @@ -1457,6 +1468,9 @@ ci + +false + Review comment: I'm pulling this up locally, to poke around. I'll get back to you shortly. Thanks again for keeping this moving!! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [shiro] bdemers commented on a change in pull request #137: Build
bdemers commented on a change in pull request #137: Build URL: https://github.com/apache/shiro/pull/137#discussion_r289518585 ## File path: pom.xml ## @@ -1354,6 +1355,16 @@ + +fast + +true +true + + +clean install Review comment: I really like default goals, but for the fast profile `clean` probably shouldn't be used, Maven is much better about incremental builds now a days This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [shiro] fpapon commented on issue #137: Build
fpapon commented on issue #137: Build URL: https://github.com/apache/shiro/pull/137#issuecomment-497822375 @bdemers are you ok with the lastest changes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
