Re: Provide additional informations like email, name ...

[Benjamin Marwell]

Hi Mike!

Thanks for your suggestion! I do like the idea, but we need to make it
fit into Shiro's existing API without changing/breaking it. Extending
is okay.

I couldn't find any other LDAP/AD fields you're referencing. Some
(like email) would need to be settable.
I can imagine LDAP and AD realms could get a new setter method like
"setPrincipalDataLoader(PrincipalDataLoader pdl)" which corresponds to
your tooling.
But the realms are hard to access once authc and authz are done.

In general, here's my slight +1, but we need some more comments from
the other maintainers.

Sorry for the late reply!

- Ben

Am Di., 25. Jan. 2022 um 16:57 Uhr schrieb Mike Hummel :
>
> Hello,
>
> I just subscribed to this list. Hopefully I'm right here with my request.
>
> I'm using shiro in my oss and employers eco system to implement security. And 
> I did some around improvements and maybe it will be possible to move some of 
> them in the library itself - or change behaviour if possible.
>
> One of them is the option to provide additional information about the 
> subject. LDAP or other sources are already implemented ans so it is also 
> possible to provide information like email, address, first, last name and 
> more.
>
> Therefore I implemented an interface
>
> https://github.com/mhus-info/mhus-lib/blob/master/lib-core/src/main/java/de/mhus/lib/core/aaa/PrincipalDataRealm.java
>  
> 
>
> and a container object
>
> https://github.com/mhus-info/mhus-lib/blob/master/lib-core/src/main/java/de/mhus/lib/core/aaa/PrincipalData.java
>  
> 
>
> and tooling (not so important)
>
> https://github.com/mhus-info/mhus-lib/blob/1569bfc3dbae18c2df913fa8ab1ea63c99250ae8/lib-core/src/main/java/de/mhus/lib/core/aaa/Aaa.java#L568
>  
> 
>
>
> to extend realm behaviour.
>
>
>
>
> I could prepare a pull request if wanted.
>
>
> Best regards,
>
> Mike

[GitHub] [shiro-site] bmarwell opened a new pull request #153: [SHIRO-868] download URLs for the archive will now point to archive.a…

[GitBox]

bmarwell opened a new pull request #153:
URL: https://github.com/apache/shiro-site/pull/153


   …pache.org.
   
   fixes SHIRO-868


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@shiro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [shiro-site] bmarwell commented on pull request #152: [SHIRO-838] promote source release with SHA-512

[GitBox]

bmarwell commented on pull request #152:
URL: https://github.com/apache/shiro-site/pull/152#issuecomment-1059745107


   > one aspect I don't know how to code: latest release source release is 
expected to be downloaded from distribution area = like it is done currently
   > 
   > but older releases are expected to be removed from distribution area, and 
instead downloaded from archive: https://archive.apache.org/dist/shiro/
   
   Thanks, will do in another PR :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@shiro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [shiro-site] bmarwell merged pull request #152: [SHIRO-838] promote source release with SHA-512

[GitBox]

bmarwell merged pull request #152:
URL: https://github.com/apache/shiro-site/pull/152


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@shiro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [shiro-site] hboutemy commented on pull request #152: [SHIRO-838] promote source release with SHA-512

[GitBox]

hboutemy commented on pull request #152:
URL: https://github.com/apache/shiro-site/pull/152#issuecomment-1059719888


   one aspect I don't know how to code:
   latest release source release is expected to be downloaded from distribution 
area = like it is done currently
   
   but older releases are expected to be removed from distribution area, and 
instead downloaded from archive: https://archive.apache.org/dist/shiro/


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@shiro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org