[GitHub] [shiro-site] fpapon commented on pull request #131: [jbake] migrate authentication.md.vtl

2021-11-16 Thread GitBox 


fpapon commented on pull request #131:
URL: https://github.com/apache/shiro-site/pull/131#issuecomment-969988377


   @bmarwell admonitions updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@shiro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [shiro-site] fpapon commented on pull request #131: [jbake] migrate authentication.md.vtl

2021-11-15 Thread GitBox 


fpapon commented on pull request #131:
URL: https://github.com/apache/shiro-site/pull/131#issuecomment-969957843


   > Added a couple of minor tweaks:
   > 
   > * added missing images
   > 
   > * removed code formatting from the header that contained `Subject`s
   > 
   > 
   > in: 
[56ec53b](https://github.com/apache/shiro-site/commit/56ec53bdaf08f89b66597ed98be881689d62eb3e)
   
   Thanks @bdemers I forget to check the image :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@shiro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [shiro-site] fpapon commented on pull request #131: [jbake] migrate authentication.md.vtl

2021-11-15 Thread GitBox 


fpapon commented on pull request #131:
URL: https://github.com/apache/shiro-site/pull/131#issuecomment-969949533


   > We should rethink the use of admonitions in general, while we are at it.
   
   yes, for now I just convert from what we have currently in MD but we can 
re-think the level.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@shiro.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org