[GitHub] [singa] XJDKC commented on pull request #708: SINGA-510 Improvement of Time Profiling Function
XJDKC commented on pull request #708: URL: https://github.com/apache/singa/pull/708#issuecomment-632978715 OK This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] XJDKC commented on a change in pull request #708: SINGA-510 Improvement of Time Profiling Function
XJDKC commented on a change in pull request #708:
URL: https://github.com/apache/singa/pull/708#discussion_r429511478
##
File path: src/core/scheduler/scheduler.cc
##
@@ -325,9 +337,10 @@ void Graph::RunGraph() {
}
}
+ EvaluateTimeElapsed();
Review comment:
I think we should call the step function before EvaluateTimeElapsed.
Otherwise, it may have problems when dividing the time if the skip_iteration is
zero.
##
File path: src/core/scheduler/scheduler.cc
##
@@ -325,9 +337,10 @@ void Graph::RunGraph() {
}
}
+ EvaluateTimeElapsed();
+
// increment iteration counter
step();
Review comment:
Remember to clear the elapsed time and the iteration when resetting the
graph.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #697: New Model Layer Operator API
lgtm-com[bot] commented on pull request #697: URL: https://github.com/apache/singa/pull/697#issuecomment-632984557 This pull request **introduces 5 alerts** and **fixes 11** when merging ac7ccd38bf3e4afae447f741aaee6a6348c281ab into 84de1af8428d3796e3f99b215570a54d6f975a94 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-4d811d3bf9ea8e55de1c0b8cbda3226f556e2c5d) **new alerts:** * 1 for Unused local variable * 1 for Missing call to \_\_init\_\_ during object initialization * 1 for Mismatch between signature and use of an overridden method * 1 for Wrong number of arguments in a call * 1 for Wrong number of arguments in a class instantiation **fixed alerts:** * 8 for Missing call to \_\_init\_\_ during object initialization * 2 for Unreachable code * 1 for Mismatch between signature and use of an overridden method This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] nudles commented on pull request #708: SINGA-510 Improvement of Time Profiling Function
nudles commented on pull request #708: URL: https://github.com/apache/singa/pull/708#issuecomment-632977682 @XJDKC pls help review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] chrishkchris commented on a change in pull request #708: SINGA-510 Improvement of Time Profiling Function
chrishkchris commented on a change in pull request #708:
URL: https://github.com/apache/singa/pull/708#discussion_r429513662
##
File path: src/core/scheduler/scheduler.cc
##
@@ -325,9 +337,10 @@ void Graph::RunGraph() {
}
}
+ EvaluateTimeElapsed();
Review comment:
Addressed
In the revised version, we call the step function before EvaluateTimeElapsed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [singa] chrishkchris commented on pull request #708: SINGA-510 Improvement of Time Profiling Function
chrishkchris commented on pull request #708: URL: https://github.com/apache/singa/pull/708#issuecomment-632984166 Addressed the comments, a test: ``` root@71ac539cda77:~/dcsysh/singa/examples/cnn# python3 benchmark.py --verbosity 1 100%|##| 100/100 [00:15<00:00, 6.62it/s] Throughput = 211.74177390107678 per second TotalTime=15.11274766921997 Total=0.1511274766921997 Time Profiling: Forward Propagation Time : 0.0442915 sec Backward Propagation Time : 0.101003 sec ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] chrishkchris commented on a change in pull request #708: SINGA-510 Improvement of Time Profiling Function
chrishkchris commented on a change in pull request #708:
URL: https://github.com/apache/singa/pull/708#discussion_r429513576
##
File path: src/core/scheduler/scheduler.cc
##
@@ -325,9 +337,10 @@ void Graph::RunGraph() {
}
}
+ EvaluateTimeElapsed();
+
// increment iteration counter
step();
Review comment:
Addressed
Added iteration_=0 in Graph::reset, the elapsed time will be cleared in
Graph::Reset together with node as well
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #697: New Model Layer Operator API
dcslin commented on pull request #697: URL: https://github.com/apache/singa/pull/697#issuecomment-632984025 setup the overall framework for save load states This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] chrishkchris commented on a change in pull request #708: SINGA-510 Improvement of Time Profiling Function
chrishkchris commented on a change in pull request #708:
URL: https://github.com/apache/singa/pull/708#discussion_r429513576
##
File path: src/core/scheduler/scheduler.cc
##
@@ -325,9 +337,10 @@ void Graph::RunGraph() {
}
}
+ EvaluateTimeElapsed();
+
// increment iteration counter
step();
Review comment:
Addressed
Added iteration_=0 in Graph::reset, the elapsed time will be cleared in
Graph::rest together with node as well
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [singa] agnesnatasya commented on issue #700: Expand the model zoo (example model set)
agnesnatasya commented on issue #700: URL: https://github.com/apache/singa/issues/700#issuecomment-632762216 I will try to work on the ShuffleNet This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] chrishkchris opened a new pull request #708: SINGA-510 Improvement of Time Profiling Function
chrishkchris opened a new pull request #708: URL: https://github.com/apache/singa/pull/708 There are several improvement in the time profiling function 1. Greatly reduced the measurement overhead: In the new version, we synchronize the cudastream only one time at the end of iteration. The previous version needs to synchronize cudastream whenever it measures each operation, so it introduced time overhead. 2. Can skip the initial iterations for time profiling. It can be set using the function SetSkipIteration, while the default is 5 iterations. 3. Modify the benchmark.py for resnet 50 benchmark time profiling. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] chrishkchris commented on pull request #708: SINGA-510 Improvement of Time Profiling Function
chrishkchris commented on pull request #708: URL: https://github.com/apache/singa/pull/708#issuecomment-632817048 Results: ``` root@71ac539cda77:~/dcsysh/singa/examples/cnn# python3 benchmark.py --verbosity 1 100%|##| 100/100 [00:15<00:00, 6.42it/s] Throughput = 205.34910581511633 per second TotalTime=15.583218574523926 Total=0.15583218574523927 Time Profiling: Forward Propagation Time : 0.0456643 sec Backward Propagation Time : 0.104244 sec ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] dcslin commented on pull request #697: New Model Layer Operator API
dcslin commented on pull request #697: URL: https://github.com/apache/singa/pull/697#issuecomment-632811131 consolidating some designs of layer method with rulin TODO: 5. [rulin & shicong] compile / do_init: separate the initialzation and forward propagation for each layers, create name of each layer 7. [shicong] save_states/load_states/set_states: recursive logic」 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #703: Refactor sonnx, test cases and examples
lgtm-com[bot] commented on pull request #703: URL: https://github.com/apache/singa/pull/703#issuecomment-632892891 This pull request **introduces 7 alerts** and **fixes 1** when merging cfa8878316e69cb16939995980d04babc27af8c2 into 84de1af8428d3796e3f99b215570a54d6f975a94 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-52b892dfd7c8f23ce3a1253d1e23bd6fef568789) **new alerts:** * 4 for Duplicate key in dict literal * 2 for Unused local variable * 1 for Wrong number of arguments in a class instantiation **fixed alerts:** * 1 for Unused local variable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [singa] lgtm-com[bot] commented on pull request #703: Refactor sonnx, test cases and examples
lgtm-com[bot] commented on pull request #703: URL: https://github.com/apache/singa/pull/703#issuecomment-632895642 This pull request **introduces 7 alerts** and **fixes 1** when merging 03c28cada62ee1acd3c5c9b17292a90d878ea98b into 84de1af8428d3796e3f99b215570a54d6f975a94 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-a824e28c19728987e20806abbf1456326ecc44f6) **new alerts:** * 4 for Duplicate key in dict literal * 2 for Unused local variable * 1 for Wrong number of arguments in a class instantiation **fixed alerts:** * 1 for Unused local variable This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
