[jira] [Created] (SINGA-491) Code Cleaning with the Reference of LGTM Analysis Result
YEUNG SAI HO created SINGA-491: -- Summary: Code Cleaning with the Reference of LGTM Analysis Result Key: SINGA-491 URL: https://issues.apache.org/jira/browse/SINGA-491 Project: Singa Issue Type: Improvement Components: Core Reporter: YEUNG SAI HO Code Cleaning with the Reference of LGTM Analysis Result Since LGTM has been applied for our code analysis (see SINGA-484), I added this JIRA ticket so I can also help cleaning the code. At my first glance, the code cleaning according to many issues alerted by LGTM seems to be not difficult for me. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SINGA-484) Code analysis with LGTM
[ https://issues.apache.org/jira/browse/SINGA-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933989#comment-16933989 ] ASF subversion and git services commented on SINGA-484: --- Commit 6f8bf57df515cb5e3aebad1bcfefadc3d702bc45 in incubator-singa's branch refs/heads/master from Moaz Reyad [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=6f8bf57 ] SINGA-484 Add header guard > Code analysis with LGTM > --- > > Key: SINGA-484 > URL: https://issues.apache.org/jira/browse/SINGA-484 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > As the code of SINGA is growing, we need to keep the code quality higher to > avoid bugs or security issues. > [LGTM|https://lgtm.com/] is a free tool for continuous security analysis. > At the time of creating this issue, the quality of SINGA's C++ and Python > code are both at [grade|https://lgtm.com/help/lgtm/project-scoring-grading] D > (between A+ and E, this is a low grade). > There are some [alerts for > SINGA|https://lgtm.com/projects/g/apache/incubator-singa/alerts/?mode=list] > that should be fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SINGA-484) Code analysis with LGTM
[ https://issues.apache.org/jira/browse/SINGA-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933990#comment-16933990 ] ASF subversion and git services commented on SINGA-484: --- Commit 8faa633bd84a56a7a92f82ead04c634172cd67a5 in incubator-singa's branch refs/heads/master from Moaz Reyad [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=8faa633 ] SINGA-484 Remove unused imports > Code analysis with LGTM > --- > > Key: SINGA-484 > URL: https://issues.apache.org/jira/browse/SINGA-484 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > As the code of SINGA is growing, we need to keep the code quality higher to > avoid bugs or security issues. > [LGTM|https://lgtm.com/] is a free tool for continuous security analysis. > At the time of creating this issue, the quality of SINGA's C++ and Python > code are both at [grade|https://lgtm.com/help/lgtm/project-scoring-grading] D > (between A+ and E, this is a low grade). > There are some [alerts for > SINGA|https://lgtm.com/projects/g/apache/incubator-singa/alerts/?mode=list] > that should be fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SINGA-484) Code analysis with LGTM
[ https://issues.apache.org/jira/browse/SINGA-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933988#comment-16933988 ] ASF subversion and git services commented on SINGA-484: --- Commit 0a4cd380df57927c622642f8ccda85217e43d173 in incubator-singa's branch refs/heads/master from Moaz Reyad [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=0a4cd38 ] SINGA-484 Remove const modifier that has no effect > Code analysis with LGTM > --- > > Key: SINGA-484 > URL: https://issues.apache.org/jira/browse/SINGA-484 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > As the code of SINGA is growing, we need to keep the code quality higher to > avoid bugs or security issues. > [LGTM|https://lgtm.com/] is a free tool for continuous security analysis. > At the time of creating this issue, the quality of SINGA's C++ and Python > code are both at [grade|https://lgtm.com/help/lgtm/project-scoring-grading] D > (between A+ and E, this is a low grade). > There are some [alerts for > SINGA|https://lgtm.com/projects/g/apache/incubator-singa/alerts/?mode=list] > that should be fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SINGA-484) Code analysis with LGTM
[ https://issues.apache.org/jira/browse/SINGA-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933991#comment-16933991 ] ASF subversion and git services commented on SINGA-484: --- Commit e31f0f5f24686a92beeb3fde8789e0c5990201b8 in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=e31f0f5 ] Merge pull request #529 from moazreyad/SINGA-484 SINGA-484 Code analysis with LGTM > Code analysis with LGTM > --- > > Key: SINGA-484 > URL: https://issues.apache.org/jira/browse/SINGA-484 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > As the code of SINGA is growing, we need to keep the code quality higher to > avoid bugs or security issues. > [LGTM|https://lgtm.com/] is a free tool for continuous security analysis. > At the time of creating this issue, the quality of SINGA's C++ and Python > code are both at [grade|https://lgtm.com/help/lgtm/project-scoring-grading] D > (between A+ and E, this is a low grade). > There are some [alerts for > SINGA|https://lgtm.com/projects/g/apache/incubator-singa/alerts/?mode=list] > that should be fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SINGA-484) Code analysis with LGTM
[ https://issues.apache.org/jira/browse/SINGA-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933992#comment-16933992 ] ASF subversion and git services commented on SINGA-484: --- Commit e31f0f5f24686a92beeb3fde8789e0c5990201b8 in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=e31f0f5 ] Merge pull request #529 from moazreyad/SINGA-484 SINGA-484 Code analysis with LGTM > Code analysis with LGTM > --- > > Key: SINGA-484 > URL: https://issues.apache.org/jira/browse/SINGA-484 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > As the code of SINGA is growing, we need to keep the code quality higher to > avoid bugs or security issues. > [LGTM|https://lgtm.com/] is a free tool for continuous security analysis. > At the time of creating this issue, the quality of SINGA's C++ and Python > code are both at [grade|https://lgtm.com/help/lgtm/project-scoring-grading] D > (between A+ and E, this is a low grade). > There are some [alerts for > SINGA|https://lgtm.com/projects/g/apache/incubator-singa/alerts/?mode=list] > that should be fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SINGA-484) Code analysis with LGTM
[ https://issues.apache.org/jira/browse/SINGA-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933987#comment-16933987 ] ASF subversion and git services commented on SINGA-484: --- Commit 3a2cc96371ba9fe03121cc6063bd34bc15bec51f in incubator-singa's branch refs/heads/master from Moaz Reyad [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=3a2cc96 ] SINGA-484 Code analysis with LGTM > Code analysis with LGTM > --- > > Key: SINGA-484 > URL: https://issues.apache.org/jira/browse/SINGA-484 > Project: Singa > Issue Type: Improvement >Reporter: Moaz Reyad >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > As the code of SINGA is growing, we need to keep the code quality higher to > avoid bugs or security issues. > [LGTM|https://lgtm.com/] is a free tool for continuous security analysis. > At the time of creating this issue, the quality of SINGA's C++ and Python > code are both at [grade|https://lgtm.com/help/lgtm/project-scoring-grading] D > (between A+ and E, this is a low grade). > There are some [alerts for > SINGA|https://lgtm.com/projects/g/apache/incubator-singa/alerts/?mode=list] > that should be fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-singa] nudles merged pull request #529: SINGA-484 Code analysis with LGTM
nudles merged pull request #529: SINGA-484 Code analysis with LGTM URL: https://github.com/apache/incubator-singa/pull/529 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SINGA-490) Optimize performance of stochastic gradient descent (SGD)
[ https://issues.apache.org/jira/browse/SINGA-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933985#comment-16933985 ] ASF subversion and git services commented on SINGA-490: --- Commit 00803696ea35623182ab7b50ca0c6af0450e043c in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=0080369 ] Merge pull request #535 from chrishkchris/SINGA-490 SINGA-490 Optimize performance of stochastic gradient descent (SGD) > Optimize performance of stochastic gradient descent (SGD) > - > > Key: SINGA-490 > URL: https://issues.apache.org/jira/browse/SINGA-490 > Project: Singa > Issue Type: Improvement > Components: Core >Reporter: YEUNG SAI HO >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > I create a new Jira ticket to optimize the performance of stochastic gradient > descent (SGD). > The first step is to fuse the small operations so as to increase GPU > computation efficiency and decrease latency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SINGA-490) Optimize performance of stochastic gradient descent (SGD)
[ https://issues.apache.org/jira/browse/SINGA-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933984#comment-16933984 ] ASF subversion and git services commented on SINGA-490: --- Commit a8db8fa661f66b3d8e785aaba33f4aa10cb58379 in incubator-singa's branch refs/heads/master from Chris Yeung [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=a8db8fa ] SINGA-490 Replace with in-place elementwise mult > Optimize performance of stochastic gradient descent (SGD) > - > > Key: SINGA-490 > URL: https://issues.apache.org/jira/browse/SINGA-490 > Project: Singa > Issue Type: Improvement > Components: Core >Reporter: YEUNG SAI HO >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > I create a new Jira ticket to optimize the performance of stochastic gradient > descent (SGD). > The first step is to fuse the small operations so as to increase GPU > computation efficiency and decrease latency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SINGA-490) Optimize performance of stochastic gradient descent (SGD)
[ https://issues.apache.org/jira/browse/SINGA-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933986#comment-16933986 ] ASF subversion and git services commented on SINGA-490: --- Commit 00803696ea35623182ab7b50ca0c6af0450e043c in incubator-singa's branch refs/heads/master from Wei Wang [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=0080369 ] Merge pull request #535 from chrishkchris/SINGA-490 SINGA-490 Optimize performance of stochastic gradient descent (SGD) > Optimize performance of stochastic gradient descent (SGD) > - > > Key: SINGA-490 > URL: https://issues.apache.org/jira/browse/SINGA-490 > Project: Singa > Issue Type: Improvement > Components: Core >Reporter: YEUNG SAI HO >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > I create a new Jira ticket to optimize the performance of stochastic gradient > descent (SGD). > The first step is to fuse the small operations so as to increase GPU > computation efficiency and decrease latency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SINGA-490) Optimize performance of stochastic gradient descent (SGD)
[ https://issues.apache.org/jira/browse/SINGA-490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933983#comment-16933983 ] ASF subversion and git services commented on SINGA-490: --- Commit f6d5f2d6c71e61dd1b7937c887bca670b16a3770 in incubator-singa's branch refs/heads/master from chrishkchris [ https://gitbox.apache.org/repos/asf?p=incubator-singa.git;h=f6d5f2d ] SINGA-490 Optimize performance of stochastic gradient descent (SGD) > Optimize performance of stochastic gradient descent (SGD) > - > > Key: SINGA-490 > URL: https://issues.apache.org/jira/browse/SINGA-490 > Project: Singa > Issue Type: Improvement > Components: Core >Reporter: YEUNG SAI HO >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > I create a new Jira ticket to optimize the performance of stochastic gradient > descent (SGD). > The first step is to fuse the small operations so as to increase GPU > computation efficiency and decrease latency. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [incubator-singa] nudles merged pull request #533: fixed operation add assertion for convolution
nudles merged pull request #533: fixed operation add assertion for convolution URL: https://github.com/apache/incubator-singa/pull/533 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-singa] nudles merged pull request #535: SINGA-490 Optimize performance of stochastic gradient descent (SGD)
nudles merged pull request #535: SINGA-490 Optimize performance of stochastic gradient descent (SGD) URL: https://github.com/apache/incubator-singa/pull/535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-singa] dcslin commented on issue #533: fixed operation add assertion for convolution
dcslin commented on issue #533: fixed operation add assertion for convolution URL: https://github.com/apache/incubator-singa/pull/533#issuecomment-533383280 Hi @nudles , this is ready for merge. thanks to @chrishkchris This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
