[GitHub] wu-sheng closed pull request #712: Adjust document
wu-sheng closed pull request #712: Adjust document URL: https://github.com/apache/incubator-skywalking/pull/712 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #712: Adjust document
coveralls commented on issue #712: Adjust document URL: https://github.com/apache/incubator-skywalking/pull/712#issuecomment-354393103 [](https://coveralls.io/builds/14834658) Coverage remained the same at 22.945% when pulling **00523c9dfd10aa87988788717674d7d52e157406 on adjust-document** into **63070e5024f44e86d66acf8bdccb50a0955cd907 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new pull request #712: Adjust document
wu-sheng opened a new pull request #712: Adjust document URL: https://github.com/apache/incubator-skywalking/pull/712 * Remove jcenter links. 5.0 will release under asf * Update `trace data protocol cn` to 5.0 * Add EN project build document * Adjust documents menu * fix some links This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #711: Update readme to update architecture and make document easier to find.
wu-sheng closed pull request #711: Update readme to update architecture and make document easier to find. URL: https://github.com/apache/incubator-skywalking/pull/711 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #711: Update readme to update architecture and make document easier to find.
coveralls commented on issue #711: Update readme to update architecture and make document easier to find. URL: https://github.com/apache/incubator-skywalking/pull/711#issuecomment-354296863 [](https://coveralls.io/builds/14827198) Coverage remained the same at 22.945% when pulling **5795b17606497f99cc9bb10ec39901dc9ea0b2db on feature/new-architecture-graph** into **96e0420ea8c524461a05a8186d5e1f33fd651eb6 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #711: Update readme to update architecture and make document easier to find.
coveralls commented on issue #711: Update readme to update architecture and make document easier to find. URL: https://github.com/apache/incubator-skywalking/pull/711#issuecomment-354296287 [](https://coveralls.io/builds/14827178) Coverage remained the same at 22.945% when pulling **5795b17606497f99cc9bb10ec39901dc9ea0b2db on feature/new-architecture-graph** into **96e0420ea8c524461a05a8186d5e1f33fd651eb6 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new pull request #711: Update readme to update architecture and make document easier to find.
wu-sheng opened a new pull request #711: Update readme to update architecture and make document easier to find. URL: https://github.com/apache/incubator-skywalking/pull/711 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #710: [Agent] fix the context is incorrect issue
wu-sheng closed pull request #710: [Agent] fix the context is incorrect issue URL: https://github.com/apache/incubator-skywalking/pull/710 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/AsyncCallInterceptor.java b/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/AsyncCallInterceptor.java index 60dfbce05..1ae84ef10 100644 --- a/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/AsyncCallInterceptor.java +++ b/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/AsyncCallInterceptor.java @@ -64,9 +64,12 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr EnhanceRequiredInfo enhanceRequiredInfo = (EnhanceRequiredInfo)objInst.getSkyWalkingDynamicField(); Request request = (Request)enhanceRequiredInfo.getRealCallEnhance().getSkyWalkingDynamicField(); -ContextCarrier contextCarrier = new ContextCarrier(); + HttpUrl requestUrl = request.url(); -AbstractSpan span = ContextManager.createExitSpan(requestUrl.uri().getPath(), contextCarrier, requestUrl.host() + ":" + requestUrl.port()); +AbstractSpan span = ContextManager.createExitSpan(requestUrl.uri().getPath(), requestUrl.host() + ":" + requestUrl.port()); +ContextManager.continued(enhanceRequiredInfo.getContextSnapshot()); +ContextCarrier contextCarrier = new ContextCarrier(); +ContextManager.inject(contextCarrier); span.setComponent(ComponentsDefine.OKHTTP); Tags.HTTP.METHOD.set(span, request.method()); Tags.URL.set(span, requestUrl.uri().toString()); @@ -86,7 +89,7 @@ public void beforeMethod(EnhancedInstance objInst, Method method, Object[] allAr } headersField.set(request, headerBuilder.build()); -ContextManager.continued(enhanceRequiredInfo.getContextSnapshot()); + } @Override This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #710: [Agent] fix the context is incorrect issue
coveralls commented on issue #710: [Agent] fix the context is incorrect issue URL: https://github.com/apache/incubator-skywalking/pull/710#issuecomment-354254805 [](https://coveralls.io/builds/14824338) Coverage decreased (-0.001%) to 22.945% when pulling **18ad96a643b19e9b87c86a7e89f5638dd880a88e on ascrutae:fix/okhttp-issue** into **4a98bc94aad5d1a07dc67e6fd194265072df00e8 on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] clevertension commented on issue #659: [Agent] Spring Bean Plugin
clevertension commented on issue #659: [Agent] Spring Bean Plugin URL: https://github.com/apache/incubator-skywalking/issues/659#issuecomment-354254616 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #708: skywalking???sun.net.www.protocol.http.HttpURLConnection????
wu-sheng commented on issue #708: skywalking???sun.net.www.protocol.http.HttpURLConnection URL: https://github.com/apache/incubator-skywalking/issues/708#issuecomment-354254457 @haofeiL I have explained this offline, right? So, I am closing this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed issue #708: skywalking???sun.net.www.protocol.http.HttpURLConnection????
wu-sheng closed issue #708: skywalking???sun.net.www.protocol.http.HttpURLConnection URL: https://github.com/apache/incubator-skywalking/issues/708 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xiaoyang2008mmm commented on issue #659: [Agent] Spring Bean Plugin
xiaoyang2008mmm commented on issue #659: [Agent] Spring Bean Plugin URL: https://github.com/apache/incubator-skywalking/issues/659#issuecomment-354254344 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae opened a new pull request #710: [Agent] fix the context is incorrect issue
ascrutae opened a new pull request #710: [Agent] fix the context is incorrect issue URL: https://github.com/apache/incubator-skywalking/pull/710 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #707: Init ui-protocol
coveralls commented on issue #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#issuecomment-354250408 [](https://coveralls.io/builds/14824044) Coverage decreased (-0.06%) to 22.946% when pulling **d3b357a447a6cf4b024cb72b7630fb748e9d5eab on feature/ui-protocol** into **720f4048acfe424e98e2746ea19fd623e948b8e3 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #707: Init ui-protocol
wu-sheng commented on issue #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#issuecomment-354248977 @hanahmily @peng-yongsheng All services finished. And I added a readme.md to index the `graphqls` files This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
