[GitHub] WillemJiang commented on issue #752: Please add DISCLAIMER about the skywalking website
WillemJiang commented on issue #752: Please add DISCLAIMER about the skywalking website URL: https://github.com/apache/incubator-skywalking/issues/752#issuecomment-357492518 It's the header, I think you can seach "Apache Skywalking" for it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #753: Create DISCLAIMER
coveralls commented on issue #753: Create DISCLAIMER URL: https://github.com/apache/incubator-skywalking/pull/753#issuecomment-357488076 [](https://coveralls.io/builds/15040712) Coverage remained the same at 22.129% when pulling **b81fc9153e9143110b9a8880c0b9a19c2c48f7dd on DISCLAIMER** into **d937cfa4858d2a55773d229b57e47266ab0cf3a2 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #751: Update NOTICE.txt
wu-sheng closed pull request #751: Update NOTICE.txt URL: https://github.com/apache/incubator-skywalking/pull/751 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #751: Update NOTICE.txt
coveralls commented on issue #751: Update NOTICE.txt URL: https://github.com/apache/incubator-skywalking/pull/751#issuecomment-357483404 [](https://coveralls.io/builds/15040308) Coverage remained the same at 22.129% when pulling **18a83ce414e17c97e2bf99751fc1b9359b5e9b5f on update-year** into **657b1a20549b9e13cf691081d5ddccedf347362e on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new issue #90: Add NOTICE file to describe the related licenses
wu-sheng opened a new issue #90: Add NOTICE file to describe the related licenses URL: https://github.com/apache/incubator-skywalking-ui/issues/90 By following ASF rules, each release project should have a `NOTICE.txt` file, including all related projects and their license. But be attention, any GPL(v2, v3) and Commercial licenses are now allowed. Here is the example: https://github.com/apache/incubator-skywalking/blob/master/NOTICE.txt This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng opened a new pull request #751: Update NOTICE.txt
wu-sheng opened a new pull request #751: Update NOTICE.txt URL: https://github.com/apache/incubator-skywalking/pull/751 Update year to 2018 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng commented on issue #748: Support for MicroProfile OpenTracing?
wu-sheng commented on issue #748: Support for MicroProfile OpenTracing? URL: https://github.com/apache/incubator-skywalking/issues/748#issuecomment-357445999 Welcome to help us in CDI and JAX-RS. Maybe you can start a pull request for each one or both? Then we can discuss the details. If you have any issue, when working on the pull request, please let me know. Glad to help. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] johnament commented on issue #748: Support for MicroProfile OpenTracing?
johnament commented on issue #748: Support for MicroProfile OpenTracing? URL: https://github.com/apache/incubator-skywalking/issues/748#issuecomment-357441820 Hi @wu-sheng yes, I think at the core having support for the OT APIs make sense. Looking at the spec, everything else seems more closely related to JAX-RS support. I'd be happy to help you out with a CDI extension and JAX-RS support, as it could be of use to other users. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wu-sheng closed pull request #747: Ci from cache
wu-sheng closed pull request #747: Ci from cache URL: https://github.com/apache/incubator-skywalking/pull/747 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #732: Adjust ui-query protocol
coveralls commented on issue #732: Adjust ui-query protocol URL: https://github.com/apache/incubator-skywalking/pull/732#issuecomment-357440670 [](https://coveralls.io/builds/15036239) Coverage remained the same at 22.004% when pulling **691fb78bc9834bcaf41ed0c292c54cd8b072108c on fix/graphql/node-nullable** into **10ef53e6c2a2e670133b3d1eb5b79d4613820bc7 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] coveralls commented on issue #747: Ci from cache
coveralls commented on issue #747: Ci from cache URL: https://github.com/apache/incubator-skywalking/pull/747#issuecomment-357440052 [](https://coveralls.io/builds/15036167) Coverage increased (+0.1%) to 22.129% when pulling **33616bc5bd72c6ffe4191694e2d3faac0dd19b48 on ci-from-cache** into **225e6bb9fc96dc14ed218b762d9a9a88bdaa2e38 on master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ascrutae closed pull request #750: Changed boolean type to integer, true: 1, false: 0.
ascrutae closed pull request #750: Changed boolean type to integer, true: 1,
false: 0.
URL: https://github.com/apache/incubator-skywalking/pull/750
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/apm-collector/apm-collector-analysis/analysis-jvm/jvm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/jvm/provider/service/MemoryMetricService.java
b/apm-collector/apm-collector-analysis/analysis-jvm/jvm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/jvm/provider/service/MemoryMetricService.java
index c9ed19bed..97e1d7fd0 100644
---
a/apm-collector/apm-collector-analysis/analysis-jvm/jvm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/jvm/provider/service/MemoryMetricService.java
+++
b/apm-collector/apm-collector-analysis/analysis-jvm/jvm-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/jvm/provider/service/MemoryMetricService.java
@@ -22,6 +22,7 @@
import
org.apache.skywalking.apm.collector.analysis.jvm.define.service.IMemoryMetricService;
import org.apache.skywalking.apm.collector.core.graph.Graph;
import org.apache.skywalking.apm.collector.core.graph.GraphManager;
+import org.apache.skywalking.apm.collector.core.util.BooleanUtils;
import org.apache.skywalking.apm.collector.core.util.Const;
import org.apache.skywalking.apm.collector.core.util.ObjectUtils;
import org.apache.skywalking.apm.collector.storage.table.jvm.MemoryMetric;
@@ -53,7 +54,7 @@ public void send(int instanceId, long timeBucket, boolean
isHeap, long init, lon
memoryMetric.setId(id);
memoryMetric.setMetricId(metricId);
memoryMetric.setInstanceId(instanceId);
-memoryMetric.setIsHeap(isHeap);
+memoryMetric.setIsHeap(BooleanUtils.booleanToValue(isHeap));
memoryMetric.setInit(init);
memoryMetric.setMax(max);
memoryMetric.setUsed(used);
diff --git
a/apm-collector/apm-collector-analysis/analysis-register/register-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/register/provider/register/ApplicationRegisterSerialWorker.java
b/apm-collector/apm-collector-analysis/analysis-register/register-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/register/provider/register/ApplicationRegisterSerialWorker.java
index 0562c9485..686320b54 100644
---
a/apm-collector/apm-collector-analysis/analysis-register/register-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/register/provider/register/ApplicationRegisterSerialWorker.java
+++
b/apm-collector/apm-collector-analysis/analysis-register/register-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/register/provider/register/ApplicationRegisterSerialWorker.java
@@ -25,6 +25,7 @@
import org.apache.skywalking.apm.collector.cache.CacheModule;
import
org.apache.skywalking.apm.collector.cache.service.ApplicationCacheService;
import org.apache.skywalking.apm.collector.core.module.ModuleManager;
+import org.apache.skywalking.apm.collector.core.util.BooleanUtils;
import org.apache.skywalking.apm.collector.core.util.Const;
import org.apache.skywalking.apm.collector.storage.StorageModule;
import
org.apache.skywalking.apm.collector.storage.dao.register.IApplicationRegisterDAO;
@@ -65,7 +66,7 @@ public ApplicationRegisterSerialWorker(ModuleManager
moduleManager) {
userApplication.setApplicationCode(Const.USER_CODE);
userApplication.setApplicationId(Const.NONE_APPLICATION_ID);
userApplication.setAddressId(Const.NONE);
-userApplication.setIsAddress(false);
+userApplication.setIsAddress(BooleanUtils.FALSE);
applicationRegisterDAO.save(userApplication);
newApplication = new Application();
diff --git
a/apm-collector/apm-collector-analysis/analysis-register/register-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/register/provider/register/InstanceRegisterSerialWorker.java
b/apm-collector/apm-collector-analysis/analysis-register/register-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/register/provider/register/InstanceRegisterSerialWorker.java
index 654e5b69d..de5a8c131 100644
---
a/apm-collector/apm-collector-analysis/analysis-register/register-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/register/provider/register/InstanceRegisterSerialWorker.java
+++
b/apm-collector/apm-collector-analysis/analysis-register/register-provider/src/main/java/org/apache/skywalking/apm/collector/analysis/register/provider/register/InstanceRegisterSerialWorker.java
@@ -25,6 +25,7 @@
import org.apache.skywalking.apm.collector.cache.CacheModule;
import
[GitHub] peng-yongsheng opened a new pull request #750: Changed boolean type to integer, true: 1, false: 0.
peng-yongsheng opened a new pull request #750: Changed boolean type to integer, true: 1, false: 0. URL: https://github.com/apache/incubator-skywalking/pull/750 Because of integer is more suitable for H2 storage. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
