[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159122520 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract +**apm-ui-protocol** declares all services, using GraphQL API style, which provide by Collector UI module. + +## Services +### [Common](common.graphqls) + +Include common objects, which used in global + +### [Overview Layer Service](overview-layer.graphqls) + +Query data without specific application, server or service. It includes info for overview the whole cluster. + +### [Application Layer Service](application-layer.graphqls) + +Query application related data with specific application code. + +### [Server Layer Service](server-layer.graphqls) + +Query server related data with specific server id. + +### [Service Layer Service](service-layer.graphqls) + +Query service related data with specific service id + +### [Trace Service](trace.graphqls) + +Query trace by some conditions. + +### [Alarm Service](alarm.graphqls) + +Query alarm info. + +## Version +1.0-alpha Review comment: For the `*.graphqls` file name format ,I prefer to use [k8s style](https://github.com/kubernetes/kubernetes/tree/master/api/swagger-spec) @wu-sheng This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159122274 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract +**apm-ui-protocol** declares all services, using GraphQL API style, which provide by Collector UI module. + +## Services +### [Common](common.graphqls) + +Include common objects, which used in global + +### [Overview Layer Service](overview-layer.graphqls) + +Query data without specific application, server or service. It includes info for overview the whole cluster. + +### [Application Layer Service](application-layer.graphqls) + +Query application related data with specific application code. + +### [Server Layer Service](server-layer.graphqls) + +Query server related data with specific server id. + +### [Service Layer Service](service-layer.graphqls) + +Query service related data with specific service id + +### [Trace Service](trace.graphqls) + +Query trace by some conditions. + +### [Alarm Service](alarm.graphqls) + +Query alarm info. + +## Version +1.0-alpha Review comment: For instance `http://collector.host/graphql/v1alpha/`,`http://collector.host/graphql/v1alpha1/`,`http://collector.host/graphql/v1beta/`,`http://collector.host/graphql/v1beta2/`,`http://collector.host/graphql/v1/` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159122274 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract +**apm-ui-protocol** declares all services, using GraphQL API style, which provide by Collector UI module. + +## Services +### [Common](common.graphqls) + +Include common objects, which used in global + +### [Overview Layer Service](overview-layer.graphqls) + +Query data without specific application, server or service. It includes info for overview the whole cluster. + +### [Application Layer Service](application-layer.graphqls) + +Query application related data with specific application code. + +### [Server Layer Service](server-layer.graphqls) + +Query server related data with specific server id. + +### [Service Layer Service](service-layer.graphqls) + +Query service related data with specific service id + +### [Trace Service](trace.graphqls) + +Query trace by some conditions. + +### [Alarm Service](alarm.graphqls) + +Query alarm info. + +## Version +1.0-alpha Review comment: For instance `http://collector.host/graphql/v1alpha/`,`http://collector.host/graphql/v1alpha1/`,`http://collector.host/graphql/v1beta/`,`http://collector.host/graphql/v1beta2/`,,`http://collector.host/graphql/v1/` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159122274 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract +**apm-ui-protocol** declares all services, using GraphQL API style, which provide by Collector UI module. + +## Services +### [Common](common.graphqls) + +Include common objects, which used in global + +### [Overview Layer Service](overview-layer.graphqls) + +Query data without specific application, server or service. It includes info for overview the whole cluster. + +### [Application Layer Service](application-layer.graphqls) + +Query application related data with specific application code. + +### [Server Layer Service](server-layer.graphqls) + +Query server related data with specific server id. + +### [Service Layer Service](service-layer.graphqls) + +Query service related data with specific service id + +### [Trace Service](trace.graphqls) + +Query trace by some conditions. + +### [Alarm Service](alarm.graphqls) + +Query alarm info. + +## Version +1.0-alpha Review comment: For instance `http://collector.host/graphql/v1alpha/` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159121276 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract +**apm-ui-protocol** declares all services, using GraphQL API style, which provide by Collector UI module. + +## Services +### [Common](common.graphqls) + +Include common objects, which used in global + +### [Overview Layer Service](overview-layer.graphqls) + +Query data without specific application, server or service. It includes info for overview the whole cluster. + +### [Application Layer Service](application-layer.graphqls) + +Query application related data with specific application code. + +### [Server Layer Service](server-layer.graphqls) + +Query server related data with specific server id. + +### [Service Layer Service](service-layer.graphqls) + +Query service related data with specific service id + +### [Trace Service](trace.graphqls) + +Query trace by some conditions. + +### [Alarm Service](alarm.graphqls) + +Query alarm info. + +## Version +1.0-alpha Review comment: With reference to [REST API Versioning](https://restfulapi.net/versioning/) , I prefer to use `v1alpha` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol
hanahmily commented on a change in pull request #707: Init ui-protocol
URL:
https://github.com/apache/incubator-skywalking/pull/707#discussion_r159121314
##
File path:
apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/overview-layer.graphqls
##
@@ -0,0 +1,37 @@
+# Query the cluster brief based on the given duration
+type ClusterBrief {
+numOfApplication: Int
+numOfService: Int
+numOfDatabase: Int
+numOfCache: Int
+numOfMQ: Int
+}
+
+# Query the trend of alarm rate based on the given duration
+type AlarmTrend {
+numOfAlarmRate: [Int]!
+}
+
+# Query all conjectural applications based on the given duration
+# All applications here are not installed agent.
+type ConjecturalAppBrief {
+apps: [ConjecturalApp!]
+}
+
+# The basic info of the conjectural application,
+# includes the type and num of same type application
+type ConjecturalApp {
+# The display name of the application
+# e.g. MySQL, RocketMQ, Kafka, Nginx
+name: String!
+num: Int!
+}
+
+extend type Query {
+getClusterTopology(duration: Duration!): Topology
Review comment:
I agree with @wu-sheng
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159121276 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract +**apm-ui-protocol** declares all services, using GraphQL API style, which provide by Collector UI module. + +## Services +### [Common](common.graphqls) + +Include common objects, which used in global + +### [Overview Layer Service](overview-layer.graphqls) + +Query data without specific application, server or service. It includes info for overview the whole cluster. + +### [Application Layer Service](application-layer.graphqls) + +Query application related data with specific application code. + +### [Server Layer Service](server-layer.graphqls) + +Query server related data with specific server id. + +### [Service Layer Service](service-layer.graphqls) + +Query service related data with specific service id + +### [Trace Service](trace.graphqls) + +Query trace by some conditions. + +### [Alarm Service](alarm.graphqls) + +Query alarm info. + +## Version +1.0-alpha Review comment: With reference to [REST API Versioning](http://searchmicroservices.techtarget.com/definition/RESTful-API) , I prefer to use `v1alpha` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol
hanahmily commented on a change in pull request #707: Init ui-protocol
URL:
https://github.com/apache/incubator-skywalking/pull/707#discussion_r159121188
##
File path:
apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/application-layer.graphqls
##
@@ -0,0 +1,37 @@
+# ApplicationNode represents this node is under monitoring by agent.
+type ApplicationNode implements Node {
+id: ID!
+name: String!
+type: String
+# Success rate of all incoming requests.
+# Max value is 100.
+# 2 Digits after floating point.
+sla: Float!
+# The number of incoming calls
+calls: Long!
+# ref: http://www.apdex.org/
+# Max value is 1
+# 2 Digits after floating point.
+apdex: Float!
+# The number of servers in the application code
+numOfServer: Int!
+# The number of servers alerting
+numOfServerAlarm: Int!
+# The number of services alerting
+numOfServiceAlarm: Int!
+}
+
+# The conjectural node generated by exit span
+type ConjecturalNode implements Node {
+id: ID!
+name: String!
+type: String
+}
+
+
+extend type Query {
+ getAllApplication(duration: Duration!): [ApplicationNode]
+ getApplicationTopology(appId: ID!, duration: Duration!): Topology
Review comment:
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hanahmily commented on a change in pull request #707: Init ui-protocol
hanahmily commented on a change in pull request #707: Init ui-protocol URL: https://github.com/apache/incubator-skywalking/pull/707#discussion_r159121157 ## File path: apm-protocol/apm-ui-protocol/src/main/resources/ui-graphql/README.md ## @@ -0,0 +1,34 @@ +# Abstract +**apm-ui-protocol** declares all services, using GraphQL API style, which provide by Collector UI module. + +## Services +### [Common](common.graphqls) + +Include common objects, which used in global + +### [Overview Layer Service](overview-layer.graphqls) + +Query data without specific application, server or service. It includes info for overview the whole cluster. + +### [Application Layer Service](application-layer.graphqls) + +Query application related data with specific application code. + +### [Server Layer Service](server-layer.graphqls) + +Query server related data with specific server id. + +### [Service Layer Service](service-layer.graphqls) + +Query service related data with specific service id + +### [Trace Service](trace.graphqls) + +Query trace by some conditions. + +### [Alarm Service](alarm.graphqls) + +Query alarm info. + +## Version +1.0-alpha Review comment: With reference to [REST API Versioning](http://searchmicroservices.techtarget.com/definition/RESTful-API) , I prefer to use `v1alpha` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
