[GitHub] wdengw commented on issue #886: Got IllegalArgumentExceptions when calling SpanBuilder.asChildOf()
wdengw commented on issue #886: Got IllegalArgumentExceptions when calling
SpanBuilder.asChildOf()
URL:
https://github.com/apache/incubator-skywalking/issues/886#issuecomment-370829788
The fix does eliminated the exception. Traces are record and shown on UI.
But the traces are not able go across distributed services, it only work for
local traces.
I am curious that the
{code}
public SpanContext extract(Format format, C carrier) {
return new SkywalkingContext();
}
{code}
Doesn't take any information form the carrier to create the context. The
OpenTracing API spec expect that, for HTTP request, HTTP headers are used to
pass TraceContext across machines. How does Skywalking manage to pass
TraceContext between remote services?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] wdengw commented on issue #886: Got IllegalArgumentExceptions when calling SpanBuilder.asChildOf()
wdengw commented on issue #886: Got IllegalArgumentExceptions when calling
SpanBuilder.asChildOf()
URL:
https://github.com/apache/incubator-skywalking/issues/886#issuecomment-370829788
I am using the 3.2.6 version. I tried to make the same code changes locally
but found that on 3.2.6 version, SkywalkingTracerExtractInterceptor.java
doesn't reference TextMapContext at all. Please advice how to make the changes
on 3.2.6.
A side question: I am curious that the
{code}
public SpanContext extract(Format format, C carrier) {
return new SkywalkingContext();
}
{code}
Doesn't take any information form the carrier to create the context. The
OpenTracing API spec expect that, for HTTP request, HTTP headers are used to
pass TraceContext across machines. How does Skywalking manage to pass
TraceContext between services?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
