Re: [slf4j-dev] New Class
Ceki Gulcu skrev den 16-11-2008 22:20: I believe the javaassit library should also be optional. Thank you for bringing it up. I believe it also was at one time, but I probably accidentially messed it up. It is needed for compilation. What is the proper way to indicate to a project using it that it should pick up the javaassist dependency for tests? -- Thorbjørn Ravn Andersen ...plus... Tubular Bells! ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev
Re: [slf4j-dev] New Class
You can look at the dependency for commons-lang in the pom. You should also update your documentation to let users know they will have to specify the dependency in their pom. Ceki Gulcu wrote: Optional means that the artifact is not exported transitively. It should not affect the compile or test class paths. Thorbjørn Ravn Andersen wrote: Ceki Gulcu skrev den 16-11-2008 22:20: I believe the javaassit library should also be optional. Thank you for bringing it up. I believe it also was at one time, but I probably accidentially messed it up. It is needed for compilation. What is the proper way to indicate to a project using it that it should pick up the javaassist dependency for tests? ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev
Re: [slf4j-dev] New Class
Ceki Gulcu skrev: Optional means that the artifact is not exported transitively. It should not affect the compile or test class paths. Ok, then let's take the how to test-debate now :) The problem is that in order to do the testing the ext.jar must be built and used, but as far as I can see the test phase happens before the installation phase. Hence I tried moving the testing to another maven project but then it needs to know which Javassist library to use to do this properly. Right now I am including the relative path to the library retrieved by maven in the built jar, but this is rather sneaky I think. Suggestions? -- Thorbjørn Ravn Andersen ...plus... Tubular Bells! ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev
Re: [slf4j-dev] New Class
See http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html. Maven has a process-test-classes phase after test-compile and before test. You want to add a jar plugin that runs in that phase and have it create the jar you need for testing in the target directory. A second alternative is to run your tests during the integration-test phase. It is possible, but tricky, to configure the surefire plugin to run in both the test and integration-test phases by disabling tests on the plugin and then configuring executions in the plugin where the tests are enabled. If you'd like to try this and have no idea what I am talking about let me know and I will post an example. On Mon, Nov 17, 2008 at 10:12 AM, Thorbjørn Ravn Andersen [EMAIL PROTECTED]wrote: Ceki Gulcu skrev: Optional means that the artifact is not exported transitively. It should not affect the compile or test class paths. Ok, then let's take the how to test-debate now :) The problem is that in order to do the testing the ext.jar must be built and used, but as far as I can see the test phase happens before the installation phase. Hence I tried moving the testing to another maven project but then it needs to know which Javassist library to use to do this properly. Right now I am including the relative path to the library retrieved by maven in the built jar, but this is rather sneaky I think. Suggestions? -- Thorbjørn Ravn Andersen ...plus... Tubular Bells! ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev
Re: [slf4j-dev] New Class
Hello Ralph, Thorbjørn, How about using the 'integration' module? It is designed for testing after all the SLF4J jars have been already produced. ralph.goers @dslextreme.com wrote: See http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html. Maven has a process-test-classes phase after test-compile and before test. You want to add a jar plugin that runs in that phase and have it create the jar you need for testing in the target directory. A second alternative is to run your tests during the integration-test phase. It is possible, but tricky, to configure the surefire plugin to run in both the test and integration-test phases by disabling tests on the plugin and then configuring executions in the plugin where the tests are enabled. If you'd like to try this and have no idea what I am talking about let me know and I will post an example. On Mon, Nov 17, 2008 at 10:12 AM, Thorbjørn Ravn Andersen [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Ceki Gulcu skrev: Optional means that the artifact is not exported transitively. It should not affect the compile or test class paths. Ok, then let's take the how to test-debate now :) The problem is that in order to do the testing the ext.jar must be built and used, but as far as I can see the test phase happens before the installation phase. Hence I tried moving the testing to another maven project but then it needs to know which Javassist library to use to do this properly. Right now I am including the relative path to the library retrieved by maven in the built jar, but this is rather sneaky I think. Suggestions? -- Thorbjørn Ravn Andersen ...plus... Tubular Bells! ___ dev mailing list dev@slf4j.org mailto:dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev
Re: [slf4j-dev] New Class
Needles to say, the 'integration' module is part of SLF4J: http://svn.slf4j.org/viewvc/slf4j/trunk/ http://svn.slf4j.org/viewvc/slf4j/trunk/integration/ Ceki Gulcu wrote: Hello Ralph, Thorbjørn, How about using the 'integration' module? It is designed for testing after all the SLF4J jars have been already produced. ralph.goers @dslextreme.com wrote: See http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html. Maven has a process-test-classes phase after test-compile and before test. You want to add a jar plugin that runs in that phase and have it create the jar you need for testing in the target directory. A second alternative is to run your tests during the integration-test phase. It is possible, but tricky, to configure the surefire plugin to run in both the test and integration-test phases by disabling tests on the plugin and then configuring executions in the plugin where the tests are enabled. If you'd like to try this and have no idea what I am talking about let me know and I will post an example. On Mon, Nov 17, 2008 at 10:12 AM, Thorbjørn Ravn Andersen [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Ceki Gulcu skrev: Optional means that the artifact is not exported transitively. It should not affect the compile or test class paths. Ok, then let's take the how to test-debate now :) The problem is that in order to do the testing the ext.jar must be built and used, but as far as I can see the test phase happens before the installation phase. Hence I tried moving the testing to another maven project but then it needs to know which Javassist library to use to do this properly. Right now I am including the relative path to the library retrieved by maven in the built jar, but this is rather sneaky I think. Suggestions? -- Thorbjørn Ravn Andersen ...plus... Tubular Bells! ___ dev mailing list dev@slf4j.org mailto:dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev
Re: [slf4j-dev] New Class
Do we have commit privs for that? Ralph On Mon, Nov 17, 2008 at 11:24 AM, Ceki Gulcu [EMAIL PROTECTED] wrote: Hello Ralph, Thorbjørn, How about using the 'integration' module? It is designed for testing after all the SLF4J jars have been already produced. ralph.goers @dslextreme.com wrote: See http://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html . Maven has a process-test-classes phase after test-compile and before test. You want to add a jar plugin that runs in that phase and have it create the jar you need for testing in the target directory. A second alternative is to run your tests during the integration-test phase. It is possible, but tricky, to configure the surefire plugin to run in both the test and integration-test phases by disabling tests on the plugin and then configuring executions in the plugin where the tests are enabled. If you'd like to try this and have no idea what I am talking about let me know and I will post an example. On Mon, Nov 17, 2008 at 10:12 AM, Thorbjørn Ravn Andersen [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Ceki Gulcu skrev: Optional means that the artifact is not exported transitively. It should not affect the compile or test class paths. Ok, then let's take the how to test-debate now :) The problem is that in order to do the testing the ext.jar must be built and used, but as far as I can see the test phase happens before the installation phase. Hence I tried moving the testing to another maven project but then it needs to know which Javassist library to use to do this properly. Right now I am including the relative path to the library retrieved by maven in the built jar, but this is rather sneaky I think. Suggestions? -- Thorbjørn Ravn Andersen ...plus... Tubular Bells! ___ dev mailing list dev@slf4j.org mailto:dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev
Re: [slf4j-dev] New Class
Hello Ralph, Ralph Goers wrote: I added a new class to slf4j-ext. Should I create a bug to track it? I don't see the normal maven changes.xml either so I guess that isn't part of the process? You can just document its addition in news.html. On a related note, the class I added has a dependency on commons-lang. I made it optional so that users of XLogger wouldn't be required to bring it in. In this particular context making it an optional dependency seems to me like the right thing to do. However, the Javaassist library isn't optional so it would be brought in under the same circumstances. Should that be optional also? Or should I just have let commons-lang be required? I believe the javaassit library should also be optional. Thank you for bringing it up. Cheers, Ralph -- Ceki Gülcü Logback: The reliable, generic, fast and flexible logging framework for Java. http://logback.qos.ch ___ dev mailing list dev@slf4j.org http://www.slf4j.org/mailman/listinfo/dev
