[jira] Closed: (SLING-1519) URL Mappings for URL paths containing - does not work
[ https://issues.apache.org/jira/browse/SLING-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-1519. --- URL Mappings for URL paths containing - does not work --- Key: SLING-1519 URL: https://issues.apache.org/jira/browse/SLING-1519 Project: Sling Issue Type: Bug Components: JCR Affects Versions: JCR Resource 2.0.6 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: JCR Resource 2.0.8 Consider the following mapping for JCR Resource Resolver URL Mapping: /content/somesite/en-us/-/ This breaks, because the dash in en-us is considered a separator instead of being part of the incoming URL path thus giving a mapping /content/somesite/en -- us/-/ To fix this situation in a broader context the - should be replaced as the character indicating bidirectional mapping by a : and the code adapted to not break on dashes any more. For backwards compatibility, the dash should still be supported as a bidirectional indicator. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-1519) URL Mappings for URL paths containing - does not work
[ https://issues.apache.org/jira/browse/SLING-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-1519: Fix Version/s: (was: JCR Resource 2.0.10) JCR Resource 2.0.8 It seems we forgot to set 2.0.8 as the version where this has been fixed. Therefore closing this now URL Mappings for URL paths containing - does not work --- Key: SLING-1519 URL: https://issues.apache.org/jira/browse/SLING-1519 Project: Sling Issue Type: Bug Components: JCR Affects Versions: JCR Resource 2.0.6 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: JCR Resource 2.0.8 Consider the following mapping for JCR Resource Resolver URL Mapping: /content/somesite/en-us/-/ This breaks, because the dash in en-us is considered a separator instead of being part of the incoming URL path thus giving a mapping /content/somesite/en -- us/-/ To fix this situation in a broader context the - should be replaced as the character indicating bidirectional mapping by a : and the code adapted to not break on dashes any more. For backwards compatibility, the dash should still be supported as a bidirectional indicator. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
GSoC 2011
Hi there, I wanted to ask if you are planning to participate in GSoC 2011. I would love to get involved in OpenSource development and Sling is particularly interesting. I already have some Web-dev and Java experience (JSE, JEE, Eclipse RCP amongst others). You can find some information about my background on Xinghttps://www.xing.com/profile/Christian_Weiss27 . Maybe you have some open tasks that are good starting points for an enthusiastic student/contributer in the context of GSoC. Cheers, Christian
Re: GSoC 2011
Hi Christian, On Fri, Feb 18, 2011 at 2:28 PM, Christian Weiß christ...@weiss2.de wrote: ... I wanted to ask if you are planning to participate in GSoC 2011. I would love to get involved in OpenSource development and Sling is particularly interesting Of course, it's the best web framework around! ;-) I am planning to suggest and mentor one or two projects, no precise spec at this point but that will be in the testing domain probably. Justin started working on test coverage reports that include our integration tests, finishing this integration might be a starting point, which would help uncover areas where more tests are needed, in order to implement them. And I don't think we have any integrated performance tests, that's also an area worth exploring. ...I already have some Web-dev and Java experience (JSE, JEE, Eclipse RCP amongst others). You can find some information about my background on Xinghttps://www.xing.com/profile/Christian_Weiss27... Cool - any other idea is welcome, of course. -Bertrand
[jira] Created: (SLING-1984) [Patch] Support for running individual test method in junit module and integration with eclipse runner
[Patch] Support for running individual test method in junit module and integration with eclipse runner -- Key: SLING-1984 URL: https://issues.apache.org/jira/browse/SLING-1984 Project: Sling Issue Type: Improvement Components: Testing Reporter: Pooja Kothari Priority: Minor -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SLING-1984) [Patch] Support for running individual test method in junit module and integration with eclipse runner
[ https://issues.apache.org/jira/browse/SLING-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pooja Kothari updated SLING-1984: - Attachment: junit-patch [Patch] Support for running individual test method in junit module and integration with eclipse runner -- Key: SLING-1984 URL: https://issues.apache.org/jira/browse/SLING-1984 Project: Sling Issue Type: Improvement Components: Testing Reporter: Pooja Kothari Priority: Minor Attachments: junit-patch -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Sling 6 end game
Hi all, AFAICT (and as I wrote on the users list) we are almost through with the releases of the bundles making up Sling 6. The last votes should close within a few hours. Please correct me if I am wrong. So, next step would be to shoot for the Sling 6 release, which is probably as simple as releasing the Launchpad Builder project. As a convenience we may still provide a Sling 6 tag which would offer a single/simple download of all bundles comprising Sling 6; but I think we should not release that because we have done single bundle releases already and building the same tags again would result in multiple binaries (yet built off the same tags) to be built with the same version numbers. I don't want to go there WDYT ? Regards Felix
[jira] Assigned: (SLING-1984) [Patch] Support for running individual test method in junit module and integration with eclipse runner
[ https://issues.apache.org/jira/browse/SLING-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz reassigned SLING-1984: -- Assignee: Bertrand Delacretaz [Patch] Support for running individual test method in junit module and integration with eclipse runner -- Key: SLING-1984 URL: https://issues.apache.org/jira/browse/SLING-1984 Project: Sling Issue Type: Improvement Components: Testing Reporter: Pooja Kothari Assignee: Bertrand Delacretaz Priority: Minor Attachments: junit-patch -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Sling 6 end game
Hi, Felix Meschberger wrote Hi all, AFAICT (and as I wrote on the users list) we are almost through with the releases of the bundles making up Sling 6. The last votes should close within a few hours. Please correct me if I am wrong. :) I just found out today that we should release the jcr resource bundle to have a working web console plugin; I'll start the vote either today or on monday. So, next step would be to shoot for the Sling 6 release, which is probably as simple as releasing the Launchpad Builder project. As a convenience we may still provide a Sling 6 tag which would offer a single/simple download of all bundles comprising Sling 6; but I think we should not release that because we have done single bundle releases already and building the same tags again would result in multiple binaries (yet built off the same tags) to be built with the same version numbers. I don't want to go there WDYT ? I think we should provide a download of all the source code and javadocs. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
[jira] Commented: (SLING-1939) wrong character encoding for compiled JSP scripts
[ https://issues.apache.org/jira/browse/SLING-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12996447#comment-12996447 ] Felix Meschberger commented on SLING-1939: -- Can you provide such a JSP as an attachement please ? Thanks. wrong character encoding for compiled JSP scripts - Key: SLING-1939 URL: https://issues.apache.org/jira/browse/SLING-1939 Project: Sling Issue Type: Bug Components: Scripting Affects Versions: Scripting JSP 2.0.12 Reporter: Victor Saar Priority: Minor I have a JSP that contains some static text with special chars (e.g. umlauts). Though the JSP itself seems to be correctly encoded as UTF-8, the compiled .java class under /var/classes/... shows these characters wrongly encoded. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [VOTE] Release Apache Sling Servlets Get 2.1.2
+1 Carsten Carsten Ziegeler wrote Hi, this is another set of new releases for SLING-6. This release fixes one issue: SLING-1965. Staging repository: https://repository.apache.org/content/repositories/orgapachesling-006/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 006 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
[VOTE RESULT] Release Apache Sling Servlets Get 2.1.2
The vote to release Apache Sling Servlets Get 2.1.2 passed with 4 binding +1 votes from Felix Meschberger, Bertrand Delacretaz, and Carsten Ziegeler. No other votes have been cast. Thanks vor voting, I'll upload the release asap. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
Re: [VOTE RESULT] Release Apache Sling Servlets Get 2.1.2
Carsten Ziegeler wrote The vote to release Apache Sling Servlets Get 2.1.2 passed with 4 binding +1 votes from Felix Meschberger, Bertrand Delacretaz, and Carsten Ziegeler. Ok...actually I can count to four..I forgot to mention Ian Boston (sorry!) Carsten No other votes have been cast. Thanks vor voting, I'll upload the release asap. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
Re: Sling 6 end game
On Fri, Feb 18, 2011 at 4:11 PM, Carsten Ziegeler cziege...@apache.org wrote: Felix Meschberger wrote ...As a convenience we may still provide a Sling 6 tag which would offer a single/simple download of all bundles comprising Sling 6; but I think we should not release that because we have done single bundle releases already and building the same tags again would result in multiple binaries (yet built off the same tags) to be built with the same version numbers. I don't want to go there I think we should provide a download of all the source code and javadocs. I agree with releasing an archive of the sling6 source code based on an SVN tag, but as Carsten says source code and javadocs only. And the launchpad builder module as binaries. -Bertrand
Re: JCR / Jackrabbit AdapterFactory
Hi, Am Samstag, den 12.02.2011, 20:55 + schrieb Justin Edelson: Felix- I think this should be merged in to bundles. Can I make one suggestion - how about supporting resourceResolver.adaptTo(JackrabbitSession.class) ? It would simplify the code in http://svn.apache.org/repos/asf/sling/whiteboard/fmeschbe/adapterfactory/src/main/java/org/apache/sling/jcr/jackrabbit/adapterfactory/PrincipalManagementAdapterFactory.java and http://svn.apache.org/repos/asf/sling/whiteboard/fmeschbe/adapterfactory/src/main/java/org/apache/sling/jcr/jackrabbit/adapterfactory/UserManagementAdapterFactory.java Just a thought... Excellent idea and since this is concerned with Jackrabbit speciality it would also be part of this adapter factory bundle. Done in Rev. 1072021. Regards Felix Justin On 2/8/11 8:22 AM, Felix Meschberger wrote: Hi all, I have created a simple AdapterFactory bundle for JCR and Jackrabbit which adapts ResourceResolver to various other objects like Jackrabbit User or Principal [1]. I consider moving this to contrib or shall we move this to bundles ? WDYT ? Regards Felix [1] http://svn.apache.org/repos/asf/sling/whiteboard/fmeschbe/adapterfactory
Re: How should the case where sling:resourceType is a multi-valued property be handled?
Hi,
sling:resourceType is not expected to be multi-value and the Node based
resources don't support it.
I am undecided: The keep-the-concepts-clean part of my mind says this
should be considered an error. On the other hand maybe just be graceful,
using the first value and log a warn message might be useful, too...
Regards
Felix
Am Samstag, den 12.02.2011, 01:30 + schrieb Justin Edelson:
I ran into a strange issue today where the sling:resourceType property
was multi-valued on one of my nodes.
This produced an error because this code from JcrItemResource assumes
it is a single-valued property:
if
(node.hasProperty(JcrResourceConstants.SLING_RESOURCE_TYPE_PROPERTY))
{
result =
node.getProperty(JcrResourceConstants.SLING_RESOURCE_TYPE_PROPERTY).getValue().getString();
}
I was thinking that if sling:resourceType is multi-valued, the first
value should be used and a warning logged.
WDYT?
Justin
Re: How should the case where sling:resourceType is a multi-valued property be handled?
On Sat, Feb 12, 2011 at 2:30 AM, Justin Edelson jus...@justinedelson.com wrote: ...I was thinking that if sling:resourceType is multi-valued, the first value should be used and a warning logged I think I'd fail loudly on that one, it could be very confusing to troubleshoot otherwise? -Bertrand
[jira] Commented: (SLING-1984) [Patch] Support for running individual test method in junit module and integration with eclipse runner
[
https://issues.apache.org/jira/browse/SLING-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12996465#comment-12996465
]
Bertrand Delacretaz commented on SLING-1984:
Thanks very much for this contribution, here are my comments after reviewing it
- I'll number my comments to make it easier to reply.
1. Can you confirm the use case? IIUC the goal is to allow executing tests from
an IDE - for example if you execute your RemoteJUnit4Test in your IDE, it runs
on a remote Sling instance and you get tests results in the IDE, exactly as if
the test ran locally.
Can you also debug the tests remotely when doing that?
2. I'd rather put those new classes in a separate junit remote module, to
keep the dependencies of the junit core module minimal, so that it can be
reused in other OSGi environments. No big deal, I could do that refactoring
after we apply your patch.
3. Using Logger instead of System.out or err is preferred (ExecutionRule.java)
4. Your patches to RequestInfo break the current navigation in tests, for
example currently a GET on /system/sling/junit/org.apache.foo.html selects all
test classes that start with org.apache.foo. I'd like to keep this, and use
request parameters only when absolutely required, which I think is the case for
selecting a method in a test class.
5. Do you think OUTPUT_FORMAT_PARAMETER is needed? The extension should be
sufficient to select the output format?
6. Why this change in JUnitServlet? I think it breaks things (and I should add
tests for said things ;-)
final String pi = request.getPathInfo();
-if(pi == null) {
+if(request.getParameterMap() == null) {
7. For us to apply the patch we need the Grant license to ASF for inclusion in
ASF works checkbox to be checked when uploading a patch - if you agree and are
allowed to do that, of course.
Don't be put off by the long list of comments!
I'm sure this can be very useful for people who use IDEs to run tests, but I
don't usually do that so I'll need to understand the context better - again
thanks, and feel free to discuss things on the Sling dev list if it's easier,
see
http://sling.apache.org/site/project-information.html#ProjectInformation-lists
[Patch] Support for running individual test method in junit module and
integration with eclipse runner
--
Key: SLING-1984
URL: https://issues.apache.org/jira/browse/SLING-1984
Project: Sling
Issue Type: Improvement
Components: Testing
Reporter: Pooja Kothari
Assignee: Bertrand Delacretaz
Priority: Minor
Attachments: junit-patch
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SLING-1985) NullPointerException on ResourceResolver.getAttribute(String) for anonymous login
NullPointerException on ResourceResolver.getAttribute(String) for anonymous login - Key: SLING-1985 URL: https://issues.apache.org/jira/browse/SLING-1985 Project: Sling Issue Type: Bug Components: JCR Affects Versions: JCR Resource 2.0.8 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: JCR Resource 2.0.12 When creating a ResourceResolver with ResolverResolverFactory.getResourceResolver(null) any call to ResourceResolver.getAttribute(String) may result in a NullPointerException because the orginalAuthInfo field is null and access is not guarded -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-1985) NullPointerException on ResourceResolver.getAttribute(String) for anonymous login
[ https://issues.apache.org/jira/browse/SLING-1985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-1985. -- Resolution: Fixed Fix Version/s: (was: JCR Resource 2.0.12) JCR Resource 2.0.10 Fixed in Rev. 1072037. NullPointerException on ResourceResolver.getAttribute(String) for anonymous login - Key: SLING-1985 URL: https://issues.apache.org/jira/browse/SLING-1985 Project: Sling Issue Type: Bug Components: JCR Affects Versions: JCR Resource 2.0.8 Reporter: Felix Meschberger Assignee: Felix Meschberger Fix For: JCR Resource 2.0.10 When creating a ResourceResolver with ResolverResolverFactory.getResourceResolver(null) any call to ResourceResolver.getAttribute(String) may result in a NullPointerException because the orginalAuthInfo field is null and access is not guarded -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: Sling 6 end game
On 18 Feb 2011, at 15:20, Bertrand Delacretaz wrote: On Fri, Feb 18, 2011 at 4:11 PM, Carsten Ziegeler cziege...@apache.org wrote: Felix Meschberger wrote ...As a convenience we may still provide a Sling 6 tag which would offer a single/simple download of all bundles comprising Sling 6; but I think we should not release that because we have done single bundle releases already and building the same tags again would result in multiple binaries (yet built off the same tags) to be built with the same version numbers. I don't want to go there I think we should provide a download of all the source code and javadocs. I agree with releasing an archive of the sling6 source code based on an SVN tag, but as Carsten says source code and javadocs only. And the launchpad builder module as binaries. that makes sense to me, Ian -Bertrand
Re: GSoC 2011
How about a Spring/Sling framework/mechanism which allows Spring apps to be developed in OSGi but be able to integrate with Sling views and resource resolution? I'm being a little selfish in this but if there was a steer from sling developers who can air out all the issues involved, then it's something the greater community of sling (and CQ/CRX) users can make use of. How the framework splits responsibilities between spring and sling can be part of the research. I'm interested in seeing what are the problems involved that need to be solved (web extender implementations, having sling resolution and spring controllers sitting side by side, etc...) I'd be willing to provide advice on some lessons I've learned on projects as well. Sarwar On Fri, Feb 18, 2011 at 1:50 PM, Bertrand Delacretaz bdelacre...@apache.org wrote: Hi Christian, On Fri, Feb 18, 2011 at 2:28 PM, Christian Weiß christ...@weiss2.de wrote: ... I wanted to ask if you are planning to participate in GSoC 2011. I would love to get involved in OpenSource development and Sling is particularly interesting Of course, it's the best web framework around! ;-) I am planning to suggest and mentor one or two projects, no precise spec at this point but that will be in the testing domain probably. Justin started working on test coverage reports that include our integration tests, finishing this integration might be a starting point, which would help uncover areas where more tests are needed, in order to implement them. And I don't think we have any integrated performance tests, that's also an area worth exploring. ...I already have some Web-dev and Java experience (JSE, JEE, Eclipse RCP amongst others). You can find some information about my background on Xinghttps://www.xing.com/profile/Christian_Weiss27... Cool - any other idea is welcome, of course. -Bertrand
Re: How should the case where sling:resourceType is a multi-valued property be handled?
On 18 Feb 2011, at 15:30, Bertrand Delacretaz wrote: On Sat, Feb 12, 2011 at 2:30 AM, Justin Edelson jus...@justinedelson.com wrote: ...I was thinking that if sling:resourceType is multi-valued, the first value should be used and a warning logged I think I'd fail loudly on that one, it could be very confusing to troubleshoot otherwise? Having spent some time in a debugger with resource type and servlet resolution getting extreemly confused about the bindings to servlets, opting servlets and selectors simple would be better. Also result = node.getProperty(JcrResourceConstants.SLING_RESOURCE_TYPE_PROPERTY).getValue().getString(); } is going to be used all over the place in client code since sling:resourceType has been assumed by many to be part of a defacto schema. Ian -Bertrand
[jira] Created: (SLING-1986) RequestLogger and RequestLoggerService have wrong metatype information
RequestLogger and RequestLoggerService have wrong metatype information -- Key: SLING-1986 URL: https://issues.apache.org/jira/browse/SLING-1986 Project: Sling Issue Type: Bug Components: Engine Affects Versions: Engine 2.2.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.2.2 Due to FELIX-2835, RequestLogger and RequestLoggerService have broken metatype information. The values for the options are wrong. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SLING-1986) RequestLogger and RequestLoggerService have wrong metatype information
[ https://issues.apache.org/jira/browse/SLING-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-1986. - Resolution: Fixed Using annotations now RequestLogger and RequestLoggerService have wrong metatype information -- Key: SLING-1986 URL: https://issues.apache.org/jira/browse/SLING-1986 Project: Sling Issue Type: Bug Components: Engine Affects Versions: Engine 2.2.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Engine 2.2.2 Due to FELIX-2835, RequestLogger and RequestLoggerService have broken metatype information. The values for the options are wrong. -- This message is automatically generated by JIRA. - For more information on JIRA, see: http://www.atlassian.com/software/jira
Hudson build is back to normal : sling-trunk-1.6 #782
See https://hudson.apache.org/hudson/job/sling-trunk-1.6/782/changes
