Jenkins build is back to stable : sling-trunk-1.5 » Apache Sling Launchpad Testing #1708
See https://builds.apache.org/job/sling-trunk-1.5/org.apache.sling$org.apache.sling.launchpad.testing/1708/
Jenkins build is back to stable : sling-trunk-1.5 #1708
See https://builds.apache.org/job/sling-trunk-1.5/1708/changes
Build failed in Jenkins: sling-samples-1.5 #360
See https://builds.apache.org/job/sling-samples-1.5/360/ -- [...truncated 492 lines...] [INFO] Writing abstract service descriptor https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/post-servlet-extensions/target/scr-plugin-generated/OSGI-INF/scr-plugin/scrinfo.xml with 2 entries. [INFO] Generating 2 Service Component Descriptors to https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/post-servlet-extensions/target/scr-plugin-generated/OSGI-INF/serviceComponents.xml mojoSucceeded org.apache.felix:maven-scr-plugin:1.7.2(generate-scr-scrdescriptor) mojoStarted org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources)[INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/post-servlet-extensions/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-resources-plugin:2.4.3:testResources (default-testResources) @ org.apache.sling.samples.post-servlet-extensions --- mojoSucceeded org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-testResources) mojoStarted org.apache.maven.plugins:maven-compiler-plugin:2.3.2(default-testCompile)[INFO] No sources to compile [INFO] [INFO] --- maven-compiler-plugin:2.3.2:testCompile (default-testCompile) @ org.apache.sling.samples.post-servlet-extensions --- mojoSucceeded org.apache.maven.plugins:maven-compiler-plugin:2.3.2(default-testCompile) mojoStarted org.apache.maven.plugins:maven-surefire-plugin:2.7.2(default-test)[INFO] Surefire report directory: https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/post-servlet-extensions/target/surefire-reports [INFO] [INFO] --- maven-surefire-plugin:2.7.2:test (default-test) @ org.apache.sling.samples.post-servlet-extensions --- --- T E S T S --- There are no tests to run. Results : Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 mojoSucceeded org.apache.maven.plugins:maven-surefire-plugin:2.7.2(default-test) [JENKINS] Recording test results[INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0 mojoStarted org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default) [INFO] [INFO] --- animal-sniffer-maven-plugin:1.7:check (default) @ org.apache.sling.samples.post-servlet-extensions --- mojoSucceeded org.codehaus.mojo:animal-sniffer-maven-plugin:1.7(default) mojoStarted org.apache.felix:maven-bundle-plugin:2.0.1(default-bundle) [INFO] [INFO] --- maven-bundle-plugin:2.0.1:bundle (default-bundle) @ org.apache.sling.samples.post-servlet-extensions --- mojoSucceeded org.apache.felix:maven-bundle-plugin:2.0.1(default-bundle) forkedProjectStarted org.apache.sling.samples:org.apache.sling.samples.post-servlet-extensions:0.1.0-SNAPSHOT mojoStarted org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java) [INFO] [INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ org.apache.sling.samples.post-servlet-extensions --- mojoSucceeded org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java) Jul 17, 2012 10:32:45 AM hudson.maven.ExecutedMojo init WARNING: Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo forkedProjectSucceeded org.apache.sling.samples:org.apache.sling.samples.post-servlet-extensions:0.1.0-SNAPSHOT mojoStarted org.apache.maven.plugins:maven-source-plugin:2.1.2(attach-sources) [INFO] [INFO] --- maven-source-plugin:2.1.2:jar (attach-sources) @ org.apache.sling.samples.post-servlet-extensions --- [INFO] META-INF already added, skipping [INFO] META-INF already added, skipping [INFO] META-INF/LICENSE already added, skipping [INFO] META-INF/NOTICE already added, skipping [INFO] META-INF/DEPENDENCIES already added, skipping [INFO] Building jar: https://builds.apache.org/job/sling-samples-1.5/ws/contrib-1.5/post-servlet-extensions/target/org.apache.sling.samples.post-servlet-extensions-0.1.0-SNAPSHOT-sources.jar [INFO] META-INF already added, skipping [INFO] META-INF already added, skipping [INFO] META-INF/LICENSE already added, skipping [INFO] META-INF/NOTICE already added, skipping [INFO] META-INF/DEPENDENCIES already added, skipping mojoSucceeded org.apache.maven.plugins:maven-source-plugin:2.1.2(attach-sources) mojoStarted org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1(default)[INFO] Checking legal files in: org.apache.sling.samples.post-servlet-extensions-0.1.0-SNAPSHOT.jar [INFO] Checking legal files in: org.apache.sling.samples.post-servlet-extensions-0.1.0-SNAPSHOT-sources.jar [INFO] [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ org.apache.sling.samples.post-servlet-extensions --- mojoSucceeded org.codehaus.mojo:ianal-maven-plugin:1.0-alpha-1(default) mojoStarted org.apache.maven.plugins:maven-install-plugin:2.3.1(default-install)[INFO] Installing
Build failed in Jenkins: sling-samples-1.5 » Apache Sling Sample Application #360
See https://builds.apache.org/job/sling-samples-1.5/org.apache.sling.samples$org.apache.sling.samples.simple-demo/360/ -- projectStarted org.apache.sling.samples:org.apache.sling.samples.simple-demo:2.0.3-SNAPSHOT [INFO] [INFO] [INFO] Building Apache Sling Sample Application 2.0.3-SNAPSHOT [INFO] mojoStarted org.apache.maven.plugins:maven-clean-plugin:2.4.1(default-clean)[INFO] Deleting https://builds.apache.org/job/sling-samples-1.5/org.apache.sling.samples$org.apache.sling.samples.simple-demo/ws/target [INFO] [INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ org.apache.sling.samples.simple-demo --- mojoSucceeded org.apache.maven.plugins:maven-clean-plugin:2.4.1(default-clean) mojoStarted org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java) [INFO] [INFO] --- maven-enforcer-plugin:1.0:enforce (enforce-java) @ org.apache.sling.samples.simple-demo --- mojoSucceeded org.apache.maven.plugins:maven-enforcer-plugin:1.0(enforce-java) mojoStarted org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default) [INFO] [INFO] --- maven-remote-resources-plugin:1.1:process (default) @ org.apache.sling.samples.simple-demo --- mojoSucceeded org.apache.maven.plugins:maven-remote-resources-plugin:1.1(default) mojoStarted org.apache.sling:maven-jcrocm-plugin:2.0.4-incubator(generate-JCR-OCM-descriptor) [INFO] [INFO] --- maven-jcrocm-plugin:2.0.4-incubator:ocm (generate-JCR-OCM-descriptor) @ org.apache.sling.samples.simple-demo --- [INFO] Generating 2 OCM Mapping Descriptors to https://builds.apache.org/job/sling-samples-1.5/org.apache.sling.samples$org.apache.sling.samples.simple-demo/ws/target/sling-generated/SLING-INF/mappings.xml mojoSucceeded org.apache.sling:maven-jcrocm-plugin:2.0.4-incubator(generate-JCR-OCM-descriptor) mojoStarted org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources)[INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] [INFO] --- maven-resources-plugin:2.4.3:resources (default-resources) @ org.apache.sling.samples.simple-demo --- [INFO] Copying 6 resources [INFO] Copying 3 resources [INFO] Copying 1 resource mojoSucceeded org.apache.maven.plugins:maven-resources-plugin:2.4.3(default-resources) mojoStarted org.apache.maven.plugins:maven-antrun-plugin:1.6(default) [INFO] [INFO] --- maven-antrun-plugin:1.6:run (default) @ org.apache.sling.samples.simple-demo --- [INFO] Executing tasks main: [echo] WARNING (SLING-443/SLING-1782) ** [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you set [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see SLING-443 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks mojoSucceeded org.apache.maven.plugins:maven-antrun-plugin:1.6(default) mojoStarted org.apache.maven.plugins:maven-compiler-plugin:2.3.2(default-compile)[INFO] Compiling 4 source files to https://builds.apache.org/job/sling-samples-1.5/org.apache.sling.samples$org.apache.sling.samples.simple-demo/ws/target/classes [INFO] [INFO] --- maven-compiler-plugin:2.3.2:compile (default-compile) @ org.apache.sling.samples.simple-demo --- mojoSucceeded org.apache.maven.plugins:maven-compiler-plugin:2.3.2(default-compile) mojoStarted org.apache.sling:maven-jspc-plugin:2.0.4-incubator(compile-jsp) [INFO] [INFO] --- maven-jspc-plugin:2.0.4-incubator:jspc (compile-jsp) @ org.apache.sling.samples.simple-demo --- mojoSucceeded org.apache.sling:maven-jspc-plugin:2.0.4-incubator(compile-jsp) mojoStarted org.apache.felix:maven-scr-plugin:1.7.2(generate-scr-scrdescriptor) [INFO] [INFO] --- maven-scr-plugin:1.7.2:scr (generate-scr-scrdescriptor) @ org.apache.sling.samples.simple-demo --- mojoFailed org.apache.felix:maven-scr-plugin:1.7.2(generate-scr-scrdescriptor) projectFailed org.apache.sling.samples:org.apache.sling.samples.simple-demo:2.0.3-SNAPSHOT
[jira] [Created] (SLING-2534) Strings of zero length on update in post servlet delete the property
Endolf created SLING-2534: - Summary: Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. String properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endolf updated SLING-2534: -- Description: According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. (was: According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. String properties with a zero length should be blanked instead of deleted.) Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Endolf updated SLING-2534: -- Attachment: blankstrings.patch I have tested this (but not very thoroughly) for string properties as this has the behaviour we expect in our application. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2533) ResourceCollector fails to resolve selector scripts when no extension is used
[ https://issues.apache.org/jira/browse/SLING-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416257#comment-13416257 ] Carsten Ziegeler commented on SLING-2533: - Maybe supporting the accept header directly in Sling would be a good idea - not really sure. This is not the first time I hear the request for it :) So far, users solved it by having a request filter upfront which checked if there is no extension but a usable accept header and then simply rewrote the request url path by appending the correct extension. All requests getting into Sling use a proper extension. Not the nicest solution but does the trick. ResourceCollector fails to resolve selector scripts when no extension is used - Key: SLING-2533 URL: https://issues.apache.org/jira/browse/SLING-2533 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Resolver 2.1.2 Environment: this applies to version 2.1.3-SNAPSHOT Reporter: Tyson Norris Attachments: sling-2533.patch A specific use case where this comes up is: request: http://localhost:4502/content/test/include In JCR repo: - node at content/test/include has sling:resourceType=test/main - script to render this resource is /apps/test/main/GET.jsp - script to render different type with selector referneced via: sling:include resourceType=test/sometype replaceSelectors=special/ - script to render the different type is /apps/test/sometype/special.jsp in this case, special.jsp script is only resoved if renamed to special.GET.jsp Note that: - no extension on requested URL - using a replaced selector in sling:include should behave similar to specifying an exentsion when the extension is null, I think. See attached patch to ResourceCollector and ScriptSelectionTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2533) ResourceCollector fails to resolve selector scripts when no extension is used
[ https://issues.apache.org/jira/browse/SLING-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416263#comment-13416263 ] Felix Meschberger commented on SLING-2533: -- Would specifying the extension in sling:include be tolerable? If this would not be possible (yet), I would consider this a valid extension, yes. And IIRC there has been some discussion around this, but I fail to remember any outcome. So far, users solved it by having a request filter upfront which checked if there is no extension but a usable accept header and then simply rewrote the request url path by appending the correct extension. IMHO this sounds like sensible. OTOH we could as well implement this support when deciding the extension and there is none really. ResourceCollector fails to resolve selector scripts when no extension is used - Key: SLING-2533 URL: https://issues.apache.org/jira/browse/SLING-2533 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Resolver 2.1.2 Environment: this applies to version 2.1.3-SNAPSHOT Reporter: Tyson Norris Attachments: sling-2533.patch A specific use case where this comes up is: request: http://localhost:4502/content/test/include In JCR repo: - node at content/test/include has sling:resourceType=test/main - script to render this resource is /apps/test/main/GET.jsp - script to render different type with selector referneced via: sling:include resourceType=test/sometype replaceSelectors=special/ - script to render the different type is /apps/test/sometype/special.jsp in this case, special.jsp script is only resoved if renamed to special.GET.jsp Note that: - no extension on requested URL - using a replaced selector in sling:include should behave similar to specifying an exentsion when the extension is null, I think. See attached patch to ResourceCollector and ScriptSelectionTest -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2535) QuartzScheduler:ApacheSling thread group remaining after stopping the scheduler bundle
Felix Meschberger created SLING-2535: Summary: QuartzScheduler:ApacheSling thread group remaining after stopping the scheduler bundle Key: SLING-2535 URL: https://issues.apache.org/jira/browse/SLING-2535 Project: Sling Issue Type: Bug Components: Commons Affects Versions: Commons Scheduler 2.3.4 Reporter: Felix Meschberger When the Scheduler bundle is stopped, the threads (probably the thread pool) is cleaned away but the thread group QuartzScheduler:ApacheSling remains. For ultimate cleanup, I would think the thread group should also be destroyed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416273#comment-13416273 ] Justin Edelson commented on SLING-2534: --- Patch isn't backwards compatible. I think you'll need to specify this behavior via an additional parameter, e.g. myStringProp@DeleteIfBlank=false Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (SLING-2536) JcrResourceBundle breaks the contract of getLocale
Endolf created SLING-2536: - Summary: JcrResourceBundle breaks the contract of getLocale Key: SLING-2536 URL: https://issues.apache.org/jira/browse/SLING-2536 Project: Sling Issue Type: Bug Affects Versions: i18n 2.2.2 Reporter: Endolf The javadoc for getLocale state that it should return the locale of this bundle or the locale of the fallback. Currently JcrResourceBundle always returns the requested locale even if there is no mix:language for that locale. e.g. Only a mix:language with a jcr:language en is in the jcr, a request for a resource bundle of sv will return a ResourceBundle object where getLocale returns sv. This should return en according to the javadoc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416281#comment-13416281 ] Endolf commented on SLING-2534: --- That parameter would be problematic as this is only valid for strings, all other types cannot have no value. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416283#comment-13416283 ] James Phillpotts commented on SLING-2534: - While I agree this isn't very backwards compatible, as the reporter has said, Sling is behaving in a way that disagrees with the JCR specs, so I think it should be fixed as described. Existing applications that are depending on delete-on-blank functionality can use the @Delete annotation to maintain their expected functionality? Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416311#comment-13416311 ] Carsten Ziegeler commented on SLING-2534: - We can't force each and every user to change their existing clients - JCR handles empty string values which is correct from their pov; this is about the Sling Post Servlet where it has been decided in the beginning to treat empty values as non existing. Therefore the underlying property is removed from the repository. This is a pure design choice at that point of time. Looking back, this decision might be wrong, but there are a lot of Sling users out there relying on this fact. In a lot of cases, for rendering content it doesn't make a difference if a property is not existing or empty. But I understand that there might be applications which treat this differently - which is totally fine. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? (Just a general comment, I think the post servlet is doing too much magic and maybe it's time to create a new post servlet) Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416320#comment-13416320 ] James Phillpotts commented on SLING-2534: - The servlet-level configuration switch would be quite a good solution, as you can then just put your application into jcr-compliant-empty-string mode? It should probably also be added to the documentation. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416322#comment-13416322 ] Carsten Ziegeler commented on SLING-2534: - Yes, the switch would do that - however, just to clarify, empty strings withing Sling are treated as what they are, just empty strings in all other places - except the Sling post servlet (which is by design this way). So this is not about being jcr compliant or not being jcr compliant :) Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416329#comment-13416329 ] James Phillpotts commented on SLING-2534: - True :) I guess like you say, it's just that the post servlet is doing some extra magic here that some people might not expect. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416384#comment-13416384 ] Justin Edelson edited comment on SLING-2534 at 7/17/12 5:34 PM: bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too coarse-grained. was (Author: justinedelson): bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too course-grained. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416384#comment-13416384 ] Justin Edelson commented on SLING-2534: --- bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too course-grained. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416384#comment-13416384 ] Justin Edelson edited comment on SLING-2534 at 7/17/12 5:35 PM: bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too coarse-grained and would end up breaking application components which depend upon the current behavior. was (Author: justinedelson): bq. That parameter would be problematic as this is only valid for strings, all other types cannot have no value. I appreciate the backwards compatibility issue with the patch. How is this problematic? The parameter would just be ignored for non-string properties? bq. One solution would be to add a configuration switch to the post servlet where the current default behaviour can be changed to treat empty strings as empty strings. However, this would be a global switch. Or we could add a special request parameter like :deleteEmptyStringIfBlank=false which you could use on your requests? IMHO, applying this on the global or even request level is too coarse-grained. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416390#comment-13416390 ] Endolf edited comment on SLING-2534 at 7/17/12 5:39 PM: Just have the global parameter as defaulted to the existing behaviour. was (Author: endolf): Just have the parameter as defaulted to the existing behaviour?. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2534) Strings of zero length on update in post servlet delete the property
[ https://issues.apache.org/jira/browse/SLING-2534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13416390#comment-13416390 ] Endolf commented on SLING-2534: --- Just have the parameter as defaulted to the existing behaviour?. Strings of zero length on update in post servlet delete the property Key: SLING-2534 URL: https://issues.apache.org/jira/browse/SLING-2534 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.1.2 Reporter: Endolf Attachments: blankstrings.patch According to JCR specs, for string type properties, a blank string should be a valid value. Currently the post servlet delets any property where 1 or less values are specifed and the 1 value has a 0 length. I think string properties with a zero length should be blanked instead of deleted. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
