[jira] [Commented] (SLING-2718) Add integration test for the error handling mechanism
[ https://issues.apache.org/jira/browse/SLING-2718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568624#comment-13568624 ] Antonio Sanso commented on SLING-2718: -- adding more ITs in rev. 1441365 Add integration test for the error handling mechanism -- Key: SLING-2718 URL: https://issues.apache.org/jira/browse/SLING-2718 Project: Sling Issue Type: Improvement Components: Launchpad Reporter: Antonio Sanso Assignee: Antonio Sanso Priority: Minor Attachments: SLING-2718-patch.txt It would be nice to have some integration tests for the error handling mechanism described in http://sling.apache.org/site/errorhandling.html. I am attaching a patch that will contain the skeleton of such tests. Once committed I will extend it further. WDYT? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Jenkins build is back to stable : sling-trunk-1.6 ยป Apache Sling Launchpad Testing #1565
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.testing/1565/
[jira] [Created] (SLING-2721) Integration test for JAXB marhsalling
Robert Munteanu created SLING-2721: -- Summary: Integration test for JAXB marhsalling Key: SLING-2721 URL: https://issues.apache.org/jira/browse/SLING-2721 Project: Sling Issue Type: Test Components: Testing Reporter: Robert Munteanu Priority: Trivial Add an integration test to verify that JAXB marshalling works out of the box, without touching the current thread's context ClassLoader. I assume that this has recently improved due to the XML system bundle extension, and I'd like to have an IT in place to make sure it continues to work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2721) Integration test for JAXB marhsalling
[ https://issues.apache.org/jira/browse/SLING-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-2721: --- Attachment: SLING-2721-1.patch Patch which provides the ITs. Note that for JAXB to work I needed to make the integration tests based on Java 6. Integration test for JAXB marhsalling - Key: SLING-2721 URL: https://issues.apache.org/jira/browse/SLING-2721 Project: Sling Issue Type: Test Components: Testing Reporter: Robert Munteanu Priority: Trivial Attachments: SLING-2721-1.patch Add an integration test to verify that JAXB marshalling works out of the box, without touching the current thread's context ClassLoader. I assume that this has recently improved due to the XML system bundle extension, and I'd like to have an IT in place to make sure it continues to work. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
RE: Writing a Java 6-only integration test
-Original Message- From: Bertrand Delacretaz [mailto:bdelacre...@apache.org] Sent: Thursday, January 31, 2013 6:44 PM To: dev@sling.apache.org Subject: Re: Writing a Java 6-only integration test On Thu, Jan 31, 2013 at 5:42 PM, Felix Meschberger fmesc...@adobe.com wrote: ...I think we discussed this already. But maybe we should just come to a conclusion, that Sling requires Java 6 We could probably use JUnit categories to segregate tests...but I was going to say the exact same thing, it's probably safe to drop Java 5 now. -Bertrand I've submitted a patch with SLING-2721 which updates just the requirements for the integrationtest module to run on Java 6. Let's see where that takes us... Robert [1]: https://issues.apache.org/jira/browse/SLING-2721
Jenkins build is still unstable: sling-trunk-1.6 #1565
See https://builds.apache.org/job/sling-trunk-1.6/changes
Sling Error handling
Hi *,
while working on SLING-2718 [0] I have noticed something that made me wonder.
In particular if you see [1] I had to comment one line of my test in order to
pass it
public void test_500_errorhandling() throws IOException{
final String expected = Internal Server Error (500) - custom
error page;
final String url = testNodePath +SELECTOR_500+.html;
assertContains(getContent(url, CONTENT_TYPE_HTML,null,500),
expected);
//assertNotContains(getContent(url,
CONTENT_TYPE_HTML,null,200), All good);
}
In a nutshell it seems that if there is some servlet that is sending a 500
error (response.sendError(500)) and output something after e.g. All good
(maybe this is the wrong part...) and a 500.jsp exists, Sling will show both:
- the error page 500.jsp
- and the the extra output (e.g. All good)
Sorry if the questions sounds silly but is this normal or I might have hit some
bug?
Regards
Antonio
[0] https://issues.apache.org/jira/browse/SLING-2718
[1]
https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/servlets/resolver/errorhandler/ErrorHandlingTest.java
[jira] [Created] (SLING-2722) Add support for transitive partialbundlelist dependencies with the maven-launchpad-plugin
Rupert Westenthaler created SLING-2722: -- Summary: Add support for transitive partialbundlelist dependencies with the maven-launchpad-plugin Key: SLING-2722 URL: https://issues.apache.org/jira/browse/SLING-2722 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Rupert Westenthaler While the maven-launchpad-plugin does support the inclusion of partialbundlelist by adding dependencies with the typepartialbundlelist/type to the pom.xml file. It does only consider direct dependencies and not transitive one. Transitive dependencies would allow to create partial bundle list that add to (depend on) others. This allows to make bundle lists self consistent without repeating bundles (e.g. common libraries) over and over again. It would also allow to define bundle lists for different 'levels': low level lists for managing modules requires by services that are than merged to an higher level bundle list that covers a user level feature. To give a simplified Example: In Apache Stanbol I would like to use this feature to create bundlelists like * Apache OpenNLP * Stanbol Enhancer component * OpenNLP based NLP processing Enhancement Engines * depends on OpenNLP * depends on Stanbol Enahncer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2722) Add support for transitive partialbundlelist dependencies with the maven-launchpad-plugin
[ https://issues.apache.org/jira/browse/SLING-2722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rupert Westenthaler updated SLING-2722: --- Attachment: SLING-2722_maven-launchpad-plugin_transitive_partialbundlelist_dependencies.patch Attached a patch that changes the AbstractUsingBundleListMojo to use the MavenProject#getArtifacts() instead of MavenProject#project.getDependencyArtifacts to search for dependencies with the type partialbundlelist. This had the desired effect for me, but I am not sure if this might introduce undesired side effects Add support for transitive partialbundlelist dependencies with the maven-launchpad-plugin - Key: SLING-2722 URL: https://issues.apache.org/jira/browse/SLING-2722 Project: Sling Issue Type: Improvement Components: Maven Plugins and Archetypes Reporter: Rupert Westenthaler Attachments: SLING-2722_maven-launchpad-plugin_transitive_partialbundlelist_dependencies.patch While the maven-launchpad-plugin does support the inclusion of partialbundlelist by adding dependencies with the typepartialbundlelist/type to the pom.xml file. It does only consider direct dependencies and not transitive one. Transitive dependencies would allow to create partial bundle list that add to (depend on) others. This allows to make bundle lists self consistent without repeating bundles (e.g. common libraries) over and over again. It would also allow to define bundle lists for different 'levels': low level lists for managing modules requires by services that are than merged to an higher level bundle list that covers a user level feature. To give a simplified Example: In Apache Stanbol I would like to use this feature to create bundlelists like * Apache OpenNLP * Stanbol Enhancer component * OpenNLP based NLP processing Enhancement Engines * depends on OpenNLP * depends on Stanbol Enahncer -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Dist directory is now managed through SVN
Hi, our dist directory (www.apache.org/dist/sling) is now managed through svn. So updating: https://dist.apache.org/repos/dist/release/sling/ automatically gets the updates to that directory - no need to ssh login to the server anymore for uploading dist. Regards Carsten -- Carsten Ziegeler cziege...@apache.org
Integration test for delivering Email
Hi, Since Sling now delivers a system bundle extension fragment for JAF and the latest JavaMail releases ( 1.4.5 verified ) are now valid OSGi bundles, it is possible to send email from Sling by just installing the javax.mail:mail bundle. To celebrate this happy event I'd like to add an integration test for it, which would do the following: Setup: - install the javax.mail bundle ( unless we decide to ship it by default, but I doubt that ) - deploy a JSP file which delivers an email to localhost - start a local SMTP server using Wiser [1] Test: - access the JSP file to deliver the mail - verify that wiser has received the email message Teardown: - uninstall the javax.mail bundle - uninstall the JSP file - stop the SMTP server So my questions are: 1. Do you think this is worth having as an IT in Sling? 2. Do you have any hints on how I can deploy an additional bundle for the integration test? Thanks, Robert [1]: http://code.google.com/p/subethasmtp/wiki/Wiser
Re: Sling Error handling
Hi,
if you call sendError writing output is not allowed. From the spec:
These methods [sendError, sendRedirect] will have the side effect of
committing the response, if it has
not already been committed, and terminating it. No further output to the client
should be made by the servlet after these methods are called. If data
is written to
the response after these methods are called, the data is ignored.
As it seems that Sling is handling the sendError call (to invoke the
error script) it should throw an exception when All good is tried to
be written..which results in calling the error script :)
Regards
Carsten
2013/2/1 Antonio Sanso asa...@adobe.com:
Hi *,
while working on SLING-2718 [0] I have noticed something that made me wonder.
In particular if you see [1] I had to comment one line of my test in order to
pass it
public void test_500_errorhandling() throws IOException{
final String expected = Internal Server Error (500) - custom
error page;
final String url = testNodePath +SELECTOR_500+.html;
assertContains(getContent(url, CONTENT_TYPE_HTML,null,500),
expected);
//assertNotContains(getContent(url,
CONTENT_TYPE_HTML,null,200), All good);
}
In a nutshell it seems that if there is some servlet that is sending a 500
error (response.sendError(500)) and output something after e.g. All good
(maybe this is the wrong part...) and a 500.jsp exists, Sling will show
both:
- the error page 500.jsp
- and the the extra output (e.g. All good)
Sorry if the questions sounds silly but is this normal or I might have hit
some bug?
Regards
Antonio
[0] https://issues.apache.org/jira/browse/SLING-2718
[1]
https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/servlets/resolver/errorhandler/ErrorHandlingTest.java
--
Carsten Ziegeler
cziege...@apache.org
