Re: [VOTE] Release Apache Sling Web Console Security Provider 1.1.2
Hi Carsten Sorry for the delay. I just looked at the issues for this version and I am a bit confused as to SLING-3273 and SLING-3271: Both are tagged for this release, have commits but are unresolved. Is this an omission are they really incomplete ? Thanks Felix Am 15.12.2013 um 22:46 schrieb Carsten Ziegeler cziege...@apache.org: Anyone? 2013/12/12 Carsten Ziegeler cziege...@apache.org +1 2013/12/12 Carsten Ziegeler cziege...@apache.org Hi, its time for a new release of the security provider Sling Web Console Security Provider 1.1.2 https://issues.apache.org/jira/browse/SLING/fixforversion/12325305 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-046/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 046 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org
Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Launchpad Base #2065
See https://builds.apache.org/job/sling-trunk-1.6/org.apache.sling$org.apache.sling.launchpad.base/2065/
Jenkins build is back to stable : sling-trunk-1.6 #2065
See https://builds.apache.org/job/sling-trunk-1.6/2065/changes
Jenkins build became unstable: sling-oak-it-1.6 » Apache Sling Launchpad Testing #14
See https://builds.apache.org/job/sling-oak-it-1.6/org.apache.sling$org.apache.sling.launchpad.testing/14/
Jenkins build became unstable: sling-oak-it-1.6 #14
See https://builds.apache.org/job/sling-oak-it-1.6/14/
[jira] [Updated] (SLING-920) Sling Jenkins setup
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-920: -- Summary: Sling Jenkins setup (was: Sling buildbot setup) Sling Jenkins setup --- Key: SLING-920 URL: https://issues.apache.org/jira/browse/SLING-920 Project: Sling Issue Type: Task Components: Testing Reporter: Bertrand Delacretaz Use this issue to record changes to the Hudson continuous environment setup at http://hudson.zones.apache.org/hudson/view/Sling/ -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Jenkins build is back to stable : sling-trunk-1.7 » Apache Sling Resource-Based Discovery Service #436
See https://builds.apache.org/job/sling-trunk-1.7/org.apache.sling$org.apache.sling.discovery.impl/436/
Jenkins build is back to stable : sling-trunk-1.7 #436
See https://builds.apache.org/job/sling-trunk-1.7/436/changes
Build failed in Jenkins: sling-contrib-1.6 » Apache Sling JCR Resource Security #1108
See https://builds.apache.org/job/sling-contrib-1.6/org.apache.sling$org.apache.sling.jcr.resourcesecurity/1108/ -- [INFO] [INFO] [INFO] Building Apache Sling JCR Resource Security 0.0.1-SNAPSHOT [INFO] Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.resourceaccesssecurity/0.0.1-SNAPSHOT/maven-metadata.xml Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.resourceaccesssecurity/0.0.1-SNAPSHOT/org.apache.sling.resourceaccesssecurity-0.0.1-SNAPSHOT.pom [WARNING] The POM for org.apache.sling:org.apache.sling.resourceaccesssecurity:jar:0.0.1-SNAPSHOT is missing, no dependency information available Downloading: http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.resourceaccesssecurity/0.0.1-SNAPSHOT/org.apache.sling.resourceaccesssecurity-0.0.1-SNAPSHOT.jar
Build failed in Jenkins: sling-contrib-1.6 #1108
See https://builds.apache.org/job/sling-contrib-1.6/1108/changes Changes: [rombert] Add extensions/sling-pax-util to the contrib reactor This is needed to allow the i18n module to succesfully build. -- [...truncated 2665 lines...] [echo] WARNING (SLING-443/SLING-1782) ** [echo] On most platforms, you'll get OutOfMemoryErrors when building unless you set [echo] on 32bit platforms: MAVEN_OPTS=-Xmx256M -XX:MaxPermSize=256M, see SLING-443 [echo] on 64bit platforms: MAVEN_OPTS=-Xmx512M -XX:MaxPermSize=512M, see SLING-1782 [echo] ** [INFO] Executed tasks [INFO] [INFO] --- maven-compiler-plugin:2.5.1:compile (default-compile) @ org.apache.sling.jcr.compiler --- [INFO] Compiling 2 source files to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/compiler/target/classes [INFO] [INFO] --- maven-scr-plugin:1.14.0:scr (generate-scr-scrdescriptor) @ org.apache.sling.jcr.compiler --- [INFO] Writing 1 Service Component Descriptors to https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/compiler/target/scr-plugin-generated/OSGI-INF/org.apache.sling.jcr.compiler.impl.JcrJavaCompilerImpl.xml [INFO] [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ org.apache.sling.jcr.compiler --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/compiler/src/test/resources [INFO] Copying 3 resources [INFO] [INFO] --- maven-compiler-plugin:2.5.1:testCompile (default-testCompile) @ org.apache.sling.jcr.compiler --- [INFO] No sources to compile [INFO] [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ org.apache.sling.jcr.compiler --- [INFO] [INFO] --- animal-sniffer-maven-plugin:1.9:check (default) @ org.apache.sling.jcr.compiler --- [INFO] Checking unresolved references to org.codehaus.mojo.signature:java15:1.0 [INFO] [INFO] --- maven-bundle-plugin:2.4.0:bundle (default-bundle) @ org.apache.sling.jcr.compiler --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @ org.apache.sling.jcr.compiler --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run (set-bundle-required-execution-environment) @ org.apache.sling.jcr.compiler --- [INFO] Executing tasks main: [INFO] Executed tasks [WARNING] Failed to getClass for org.apache.maven.plugin.source.SourceJarMojo [INFO] [INFO] --- maven-source-plugin:2.2.1:jar (attach-sources) @ org.apache.sling.jcr.compiler --- [INFO] Building jar: https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/compiler/target/org.apache.sling.jcr.compiler-2.1.1-SNAPSHOT-sources.jar [INFO] [INFO] --- maven-site-plugin:3.2:attach-descriptor (attach-descriptor) @ org.apache.sling.jcr.compiler --- [INFO] [INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ org.apache.sling.jcr.compiler --- [INFO] Checking legal files in: org.apache.sling.jcr.compiler-2.1.1-SNAPSHOT.jar [INFO] Checking legal files in: org.apache.sling.jcr.compiler-2.1.1-SNAPSHOT-sources.jar [INFO] [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ org.apache.sling.jcr.compiler --- [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/compiler/target/org.apache.sling.jcr.compiler-2.1.1-SNAPSHOT.jar to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.jcr.compiler/2.1.1-SNAPSHOT/org.apache.sling.jcr.compiler-2.1.1-SNAPSHOT.jar [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/compiler/pom.xml to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.jcr.compiler/2.1.1-SNAPSHOT/org.apache.sling.jcr.compiler-2.1.1-SNAPSHOT.pom [INFO] Installing https://builds.apache.org/job/sling-contrib-1.6/ws/contrib-1.6/jcr/compiler/target/org.apache.sling.jcr.compiler-2.1.1-SNAPSHOT-sources.jar to /home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.jcr.compiler/2.1.1-SNAPSHOT/org.apache.sling.jcr.compiler-2.1.1-SNAPSHOT-sources.jar [INFO] [INFO] --- maven-bundle-plugin:2.4.0:install (default-install) @ org.apache.sling.jcr.compiler --- [INFO] Local OBR update disabled (enable with -DobrRepository) [INFO] [INFO] [INFO] Building Apache Sling JCR Prefs 1.0.1-SNAPSHOT [INFO] [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ org.apache.sling.jcr.prefs --- [INFO] [INFO] --- maven-enforcer-plugin:1.0.1:enforce (enforce-java) @ org.apache.sling.jcr.prefs --- [INFO] [INFO] --- maven-antrun-plugin:1.7:run
[jira] [Commented] (SLING-3286) Remove plugin version overrides from poms
[ https://issues.apache.org/jira/browse/SLING-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848944#comment-13848944 ] Robert Munteanu commented on SLING-3286: Sorry, I did not realize that the maven-bundle-plugin overrides where left there on purpose, just remembered about [Maven Bundle Plugin 2.4 causing problems|http://sling.markmail.org/thread/76chwpxh5wsmg55b]. Is there a discussion/bug report for the maven-bundle-plugin about this change? If there isn't, I'll start one. Remove plugin version overrides from poms - Key: SLING-3286 URL: https://issues.apache.org/jira/browse/SLING-3286 Project: Sling Issue Type: Task Reporter: Robert Munteanu Assignee: Robert Munteanu Multiple modules specify their own versions instead of picking up the one from the parent pom. For consistency and for making sure that we always get the upgrades, all these modules should have the same versions. Situations where this isn't possible should be clearly documented in the pom. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Re: [VOTE] Release Apache Sling Web Console Security Provider 1.1.2
Hi Felix, uh...sorry, I forgot to resolve them - both are done Thanks Carsten 2013/12/16 Felix Meschberger fmesc...@adobe.com Hi Carsten Sorry for the delay. I just looked at the issues for this version and I am a bit confused as to SLING-3273 and SLING-3271: Both are tagged for this release, have commits but are unresolved. Is this an omission are they really incomplete ? Thanks Felix Am 15.12.2013 um 22:46 schrieb Carsten Ziegeler cziege...@apache.org: Anyone? 2013/12/12 Carsten Ziegeler cziege...@apache.org +1 2013/12/12 Carsten Ziegeler cziege...@apache.org Hi, its time for a new release of the security provider Sling Web Console Security Provider 1.1.2 https://issues.apache.org/jira/browse/SLING/fixforversion/12325305 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-046/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 046 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org
[jira] [Resolved] (SLING-3273) Switch to login page if user is not allowed to access the web console
[ https://issues.apache.org/jira/browse/SLING-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3273. - Resolution: Fixed Switch to login page if user is not allowed to access the web console - Key: SLING-3273 URL: https://issues.apache.org/jira/browse/SLING-3273 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Web Console Security Provider 1.1.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Web Console Security Provider 1.1.2 RIght now if the current user is not allowed to access the web console, forbidden is returned - we should rather redirect to the login page instead -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Resolved] (SLING-3271) Make Sling imports dynamic
[ https://issues.apache.org/jira/browse/SLING-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-3271. - Resolution: Fixed Imports are dynamic now Make Sling imports dynamic -- Key: SLING-3271 URL: https://issues.apache.org/jira/browse/SLING-3271 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Web Console Security Provider 1.1.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Web Console Security Provider 1.1.2 Currently the imports to sling auth core and sling api resource are mandatory, this means the security provider is only active if Sling is running. These imports should rather be dynamic as the provider should also run if only the repository is available -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (SLING-3179) Implement solution to the Authentication Handler Credential Validation Problem
[ https://issues.apache.org/jira/browse/SLING-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothee Maret updated SLING-3179: -- Attachment: SLING-3179.patch Implement solution to the Authentication Handler Credential Validation Problem -- Key: SLING-3179 URL: https://issues.apache.org/jira/browse/SLING-3179 Project: Sling Issue Type: Bug Components: API, JCR, ResourceResolver Affects Versions: JCR Base 2.1.2, API 2.4.2, Resource Resolver 1.0.6 Reporter: Felix Meschberger Assignee: Antonio Sanso Attachments: SLING-3179.diff, SLING-3179.patch The proposal [Solving the Authentication Handler Credential Validation Problem|https://cwiki.apache.org/confluence/display/SLING/Solving+the+Authentication+Handler+Credential+Validation+Problem] should be implemented. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (SLING-3179) Implement solution to the Authentication Handler Credential Validation Problem
[ https://issues.apache.org/jira/browse/SLING-3179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848967#comment-13848967 ] Timothee Maret commented on SLING-3179: --- [~asanso], I have uploaded the svn patch, see SLING-3179.patch Regarding the implementation, it follows the patterns in org.apache.sling.resourceresolver.impl.ResourceResolverFactoryActivator Implement solution to the Authentication Handler Credential Validation Problem -- Key: SLING-3179 URL: https://issues.apache.org/jira/browse/SLING-3179 Project: Sling Issue Type: Bug Components: API, JCR, ResourceResolver Affects Versions: JCR Base 2.1.2, API 2.4.2, Resource Resolver 1.0.6 Reporter: Felix Meschberger Assignee: Antonio Sanso Attachments: SLING-3179.diff, SLING-3179.patch The proposal [Solving the Authentication Handler Credential Validation Problem|https://cwiki.apache.org/confluence/display/SLING/Solving+the+Authentication+Handler+Credential+Validation+Problem] should be implemented. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (SLING-3286) Remove plugin version overrides from poms
[ https://issues.apache.org/jira/browse/SLING-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848971#comment-13848971 ] Carsten Ziegeler commented on SLING-3286: - I asked on the Felix list about this - and got no reply - according to the bundle plugin documentation, however, this behaviour is correct (at least one can read it like that), as * means, that *all* required imports are added. There is no mentioning that dynamic imports should be excluded by default. However of course, I don't see any use case, where you want a package in both lists...so I guess I new issue is a good idea Remove plugin version overrides from poms - Key: SLING-3286 URL: https://issues.apache.org/jira/browse/SLING-3286 Project: Sling Issue Type: Task Reporter: Robert Munteanu Assignee: Robert Munteanu Multiple modules specify their own versions instead of picking up the one from the parent pom. For consistency and for making sure that we always get the upgrades, all these modules should have the same versions. Situations where this isn't possible should be clearly documented in the pom. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Re: [VOTE] Release Apache Sling Web Console Security Provider 1.1.2
Hi Carsten Am 16.12.2013 um 10:34 schrieb Carsten Ziegeler cziege...@apache.org: uh...sorry, I forgot to resolve them - both are done Excellent. Thanks. So here is my +1 Regards Felix Thanks Carsten 2013/12/16 Felix Meschberger fmesc...@adobe.com Hi Carsten Sorry for the delay. I just looked at the issues for this version and I am a bit confused as to SLING-3273 and SLING-3271: Both are tagged for this release, have commits but are unresolved. Is this an omission are they really incomplete ? Thanks Felix Am 15.12.2013 um 22:46 schrieb Carsten Ziegeler cziege...@apache.org: Anyone? 2013/12/12 Carsten Ziegeler cziege...@apache.org +1 2013/12/12 Carsten Ziegeler cziege...@apache.org Hi, its time for a new release of the security provider Sling Web Console Security Provider 1.1.2 https://issues.apache.org/jira/browse/SLING/fixforversion/12325305 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-046/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 046 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org
[jira] [Commented] (SLING-3286) Remove plugin version overrides from poms
[ https://issues.apache.org/jira/browse/SLING-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13848974#comment-13848974 ] Felix Meschberger commented on SLING-3286: -- bq. However of course, I don't see any use case, where you want a package in both lists...so I guess I new issue is a good idea While there probably is no practical use case for having both (mandatory) static and dynamic imports, there are explanations for having optional static and dynamic imports at the same time: The resolver is allowed to eagerly resolve a dependency which might give some performance improvement. Remove plugin version overrides from poms - Key: SLING-3286 URL: https://issues.apache.org/jira/browse/SLING-3286 Project: Sling Issue Type: Task Reporter: Robert Munteanu Assignee: Robert Munteanu Multiple modules specify their own versions instead of picking up the one from the parent pom. For consistency and for making sure that we always get the upgrades, all these modules should have the same versions. Situations where this isn't possible should be clearly documented in the pom. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (SLING-3288) Specify project.reporting.outputEncoding
Robert Munteanu created SLING-3288: -- Summary: Specify project.reporting.outputEncoding Key: SLING-3288 URL: https://issues.apache.org/jira/browse/SLING-3288 Project: Sling Issue Type: Improvement Components: General Reporter: Robert Munteanu Assignee: Robert Munteanu Priority: Minor Fix For: Parent 19 The maven-failsafe-plugin uses the project.reporting.outputEncoding property to determine the output encoding. This is missing from our projects and leads to warnings when failsafe is executed. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Resolved] (SLING-3288) Specify project.reporting.outputEncoding
[ https://issues.apache.org/jira/browse/SLING-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-3288. Resolution: Fixed Fixed in http://svn.apache.org/r1551153 Specify project.reporting.outputEncoding Key: SLING-3288 URL: https://issues.apache.org/jira/browse/SLING-3288 Project: Sling Issue Type: Improvement Components: General Reporter: Robert Munteanu Assignee: Robert Munteanu Priority: Minor Fix For: Parent 19 The maven-failsafe-plugin uses the project.reporting.outputEncoding property to determine the output encoding. This is missing from our projects and leads to warnings when failsafe is executed. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Jenkins build is back to stable : sling-oak-it-1.6 » Apache Sling Launchpad Testing #15
See https://builds.apache.org/job/sling-oak-it-1.6/org.apache.sling$org.apache.sling.launchpad.testing/15/
Jenkins build is back to stable : sling-oak-it-1.6 #15
See https://builds.apache.org/job/sling-oak-it-1.6/15/
[jira] [Reopened] (SLING-3262) Upgrade embedded jackrabbit-jcr-server version in o.a.s.jcr.webdav
[ https://issues.apache.org/jira/browse/SLING-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger reopened SLING-3262: -- JCR-3209 added a LockTokenMapper class which is required to be embeded WebDAV bundle (the DavEx bundle already has it by embedding all of the webdav.jcr.* packages). Need to update the WebDAV bundle to include all of the webdav.jcr.lock package. Upgrade embedded jackrabbit-jcr-server version in o.a.s.jcr.webdav -- Key: SLING-3262 URL: https://issues.apache.org/jira/browse/SLING-3262 Project: Sling Issue Type: Improvement Components: JCR Affects Versions: JCR Webdav 2.2.0, JCR DavEx 1.2.0 Reporter: Jukka Zitting Assignee: Felix Meschberger Fix For: Launchpad Builder 7, JCR Webdav 2.2.2, JCR DavEx 1.2.2 The WebDAV functionality in Jackrabbit has improved since the 2.4.4 version currently included in the o.a.s.jcr.webdav bundle. Most notably JCR-3630 fixes an XSS issue that is still present in 2.4.4. It would thus be a good idea to upgrade the jackrabbit-jcr-server dependency to 2.4.5 (to get the JCR-3630 fix) or to 2.6.4 (for JCR-3630 and other fixes/improvements). -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Resolved] (SLING-3262) Upgrade embedded jackrabbit-jcr-server version in o.a.s.jcr.webdav
[ https://issues.apache.org/jira/browse/SLING-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Meschberger resolved SLING-3262. -- Resolution: Fixed The WebDAV bundle now includes all classes of the org.apache.jackrabbit.webdav.jcr.lock package. Fixed in Rev. 1551160 Upgrade embedded jackrabbit-jcr-server version in o.a.s.jcr.webdav -- Key: SLING-3262 URL: https://issues.apache.org/jira/browse/SLING-3262 Project: Sling Issue Type: Improvement Components: JCR Affects Versions: JCR Webdav 2.2.0, JCR DavEx 1.2.0 Reporter: Jukka Zitting Assignee: Felix Meschberger Fix For: Launchpad Builder 7, JCR Webdav 2.2.2, JCR DavEx 1.2.2 The WebDAV functionality in Jackrabbit has improved since the 2.4.4 version currently included in the o.a.s.jcr.webdav bundle. Most notably JCR-3630 fixes an XSS issue that is still present in 2.4.4. It would thus be a good idea to upgrade the jackrabbit-jcr-server dependency to 2.4.5 (to get the JCR-3630 fix) or to 2.6.4 (for JCR-3630 and other fixes/improvements). -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (SLING-3289) o.a.s.event.it.IgnoreQueueTest causes buildbot timeout sometimes
[ https://issues.apache.org/jira/browse/SLING-3289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bertrand Delacretaz updated SLING-3289: --- Attachment: build42.log o.a.s.event.it.IgnoreQueueTest causes buildbot timeout sometimes Key: SLING-3289 URL: https://issues.apache.org/jira/browse/SLING-3289 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Event 3.3.0 Reporter: Bertrand Delacretaz Priority: Minor Attachments: build42.log http://ci.apache.org/builders/sling-trunk-oak/builds/42 failed with a timeout that's apparently caused by the IgnoreQueueTest integration test. I'll attach the stdio logs, which show this before the timeout: 16.12.2013 05:19:23.193 *WARN* [ Apche Sling JCR Resource Event Queue Processor for path '/'] org.apache.felix.eventadmin EventAdmin: Blacklisting ServiceReference [[org.apache.sling.event.jobs.JobManager, org.osgi.service.event.EventHandler, org.apache.sling.discovery.TopologyEventListener, java.lang.Runnable] | Bundle(org.apache.sling.event [66])] due to timeout! -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (SLING-3289) o.a.s.event.it.IgnoreQueueTest causes buildbot timeout sometimes
Bertrand Delacretaz created SLING-3289: -- Summary: o.a.s.event.it.IgnoreQueueTest causes buildbot timeout sometimes Key: SLING-3289 URL: https://issues.apache.org/jira/browse/SLING-3289 Project: Sling Issue Type: Bug Components: Extensions Affects Versions: Event 3.3.0 Reporter: Bertrand Delacretaz Priority: Minor Attachments: build42.log http://ci.apache.org/builders/sling-trunk-oak/builds/42 failed with a timeout that's apparently caused by the IgnoreQueueTest integration test. I'll attach the stdio logs, which show this before the timeout: 16.12.2013 05:19:23.193 *WARN* [ Apche Sling JCR Resource Event Queue Processor for path '/'] org.apache.felix.eventadmin EventAdmin: Blacklisting ServiceReference [[org.apache.sling.event.jobs.JobManager, org.osgi.service.event.EventHandler, org.apache.sling.discovery.TopologyEventListener, java.lang.Runnable] | Bundle(org.apache.sling.event [66])] due to timeout! -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Re: buildbot failure in ASF Buildbot on sling-trunk-oak
On Mon, Dec 16, 2013 at 6:39 AM, build...@apache.org wrote: The Buildbot has detected a new failure on builder sling-trunk-oak while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/sling-trunk-oak/builds/42 Looks like a new intermittent testing issue, I have created SLING-3289 and made it a blocker for SLING-3234 which keeps track of those. -Bertrand
buildbot failure in ASF Buildbot on sling-trunk
The Buildbot has detected a new failure on builder sling-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/sling-trunk/builds/58 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: osiris_ubuntu Build Reason: scheduler Build Source Stamp: [branch sling/trunk] 1551160 Blamelist: fmeschbe BUILD FAILED: failed compile sincerely, -The Buildbot
Re: [ResourceAccessSecurity] Returns NonExistingResource if acess is denied
Hi Are you talking about ResourceAccessSecurityImpl.getReadableResource ? Yes, I agree, that returning NonExistingResource is indeed violating the API spec which states null is to be returned if the resource is not readable. Regards Felix Am 16.12.2013 um 08:00 schrieb Carsten Ziegeler cziege...@apache.org: Hi, while looking at the ResourceAccessSecurity implementation I noticed that it returns a NonExistingResource if read access is denied. I think it simply should return null. Thoughts? Regards Carsten -- Carsten Ziegeler cziege...@apache.org
Jenkins build became unstable: sling-oak-it-1.6 » Apache Sling Launchpad Testing #16
See https://builds.apache.org/job/sling-oak-it-1.6/org.apache.sling$org.apache.sling.launchpad.testing/16/
Jenkins build became unstable: sling-oak-it-1.6 #16
See https://builds.apache.org/job/sling-oak-it-1.6/16/
[jira] [Commented] (SLING-920) Sling Jenkins setup
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849098#comment-13849098 ] Robert Munteanu commented on SLING-920: --- Updated sling-samples-1.6: * run on only the ubuntu slaves which were recently updated to OpenJDK 7 - see INFRA-6218 * changes lifecycles phases to clean install instead of clean deploy, since we don't rely on those snapshots being deployed Sling Jenkins setup --- Key: SLING-920 URL: https://issues.apache.org/jira/browse/SLING-920 Project: Sling Issue Type: Task Components: Testing Reporter: Bertrand Delacretaz Use this issue to record changes to the Hudson continuous environment setup at http://hudson.zones.apache.org/hudson/view/Sling/ -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Re: [ResourceAccessSecurity] Returns NonExistingResource if acess is denied
+0.5 I'm aware of this contract but just did check when the NonExistingResource would be valid to be used. Looking at [0] you could read this to be a correct behavior as well. There is currently a gap between the behavior of .resolve() and .getResource() where getResource would return null and .resolve() should return a NonExistingResource. I'm pretty sure there is a reason for that, but I couldn't find it. So could anyone enlighten me befor I can give full +1 from my side? :) Best regards Dominik [0] http://sling.apache.org/apidocs/sling5/org/apache/sling/api/resource/Resource.html#RESOURCE_TYPE_NON_EXISTING On Mon, Dec 16, 2013 at 11:54 AM, Felix Meschberger fmesc...@adobe.comwrote: Hi Are you talking about ResourceAccessSecurityImpl.getReadableResource ? Yes, I agree, that returning NonExistingResource is indeed violating the API spec which states null is to be returned if the resource is not readable. Regards Felix Am 16.12.2013 um 08:00 schrieb Carsten Ziegeler cziege...@apache.org: Hi, while looking at the ResourceAccessSecurity implementation I noticed that it returns a NonExistingResource if read access is denied. I think it simply should return null. Thoughts? Regards Carsten -- Carsten Ziegeler cziege...@apache.org
Jenkins build is back to normal : sling-samples-1.6 » Apache Sling Sample Application #432
See https://builds.apache.org/job/sling-samples-1.6/org.apache.sling.samples$org.apache.sling.samples.simple-demo/432/
Jenkins build is back to normal : sling-samples-1.6 #432
See https://builds.apache.org/job/sling-samples-1.6/432/
Jenkins build is back to stable : sling-oak-it-1.6 » Apache Sling Launchpad Testing #17
See https://builds.apache.org/job/sling-oak-it-1.6/org.apache.sling$org.apache.sling.launchpad.testing/17/
Jenkins build is back to stable : sling-oak-it-1.6 #17
See https://builds.apache.org/job/sling-oak-it-1.6/17/
[jira] [Updated] (SLING-3281) Expose more information on the replication queues
[ https://issues.apache.org/jira/browse/SLING-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated SLING-3281: --- Summary: Expose more information on the replication queues (was: Expose replication queue items information) Expose more information on the replication queues - Key: SLING-3281 URL: https://issues.apache.org/jira/browse/SLING-3281 Project: Sling Issue Type: Task Components: Extensions Reporter: Tommaso Teofili Attachments: SLING-3281.2.patch, SLING-3281.patch It'd be useful to have more information on the items contained in a replication queue being still be able to process one item at a time. This will ease the monitoring of what's in the replication queues. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (SLING-3281) Expose replication queue items information
[ https://issues.apache.org/jira/browse/SLING-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated SLING-3281: --- Attachment: SLING-3281.2.patch Expose replication queue items information -- Key: SLING-3281 URL: https://issues.apache.org/jira/browse/SLING-3281 Project: Sling Issue Type: Task Components: Extensions Reporter: Tommaso Teofili Attachments: SLING-3281.2.patch, SLING-3281.patch It'd be useful to have more information on the items contained in a replication queue being still be able to process one item at a time. This will ease the monitoring of what's in the replication queues. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (SLING-3281) Expose more information on the replication queues
[ https://issues.apache.org/jira/browse/SLING-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated SLING-3281: --- Description: It'd be useful to have more information on: 1. the items contained in a replication queue being still be able to process one item at a time. 2. This will ease the monitoring of what's in the replication queues. was: It'd be useful to have more information on the items contained in a replication queue being still be able to process one item at a time. This will ease the monitoring of what's in the replication queues. Expose more information on the replication queues - Key: SLING-3281 URL: https://issues.apache.org/jira/browse/SLING-3281 Project: Sling Issue Type: Task Components: Extensions Reporter: Tommaso Teofili Attachments: SLING-3281.2.patch, SLING-3281.patch It'd be useful to have more information on: 1. the items contained in a replication queue being still be able to process one item at a time. 2. This will ease the monitoring of what's in the replication queues. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (SLING-3281) Expose more information on the replication queues
[ https://issues.apache.org/jira/browse/SLING-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tommaso Teofili updated SLING-3281: --- Description: It'd be useful to have more information on: 1. the items contained in a replication queue being still be able to process one item at a time. 2. how to remove a specific item This will ease the monitoring of what's in the replication queues and also to use queues as the buffer to pull items from a remote instance. was: It'd be useful to have more information on: 1. the items contained in a replication queue being still be able to process one item at a time. 2. This will ease the monitoring of what's in the replication queues. Expose more information on the replication queues - Key: SLING-3281 URL: https://issues.apache.org/jira/browse/SLING-3281 Project: Sling Issue Type: Task Components: Extensions Reporter: Tommaso Teofili Attachments: SLING-3281.2.patch, SLING-3281.patch It'd be useful to have more information on: 1. the items contained in a replication queue being still be able to process one item at a time. 2. how to remove a specific item This will ease the monitoring of what's in the replication queues and also to use queues as the buffer to pull items from a remote instance. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (SLING-3281) Expose more information on the replication queues
[ https://issues.apache.org/jira/browse/SLING-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849208#comment-13849208 ] Tommaso Teofili commented on SLING-3281: second patch provides more changes on the queue side, also allowing a specific agent to be used just to put items in the queue and eventually let a remote one pull items from there (to do this an async package importer has been introduced) Expose more information on the replication queues - Key: SLING-3281 URL: https://issues.apache.org/jira/browse/SLING-3281 Project: Sling Issue Type: Task Components: Extensions Reporter: Tommaso Teofili Attachments: SLING-3281.2.patch, SLING-3281.patch It'd be useful to have more information on: 1. the items contained in a replication queue being still be able to process one item at a time. 2. how to remove a specific item This will ease the monitoring of what's in the replication queues and also to use queues as the buffer to pull items from a remote instance. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (SLING-3290) Long startup time with many vanityPath or alias
Antonio Sanso created SLING-3290:
Summary: Long startup time with many vanityPath or alias
Key: SLING-3290
URL: https://issues.apache.org/jira/browse/SLING-3290
Project: Sling
Issue Type: Improvement
Reporter: Antonio Sanso
When many vanityPath or alias are present the system take long time to startup
, Same when a vanityPath/alias is removed or updated .
The reason behind is the usage of a query that updates the global mapentry.
I have added a new Test to the performance test suite and this is the outcome
{code}
0 vanityPath16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath 111ms
1000 vanityPath 200ms
1 vanityPath1173ms
3 vanityPath3358ms
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Updated] (SLING-3290) Long startup time with many vanityPath or alias
[
https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso updated SLING-3290:
-
Description:
When many vanityPath or alias are present the system take long time to startup
, Same when a vanityPath/alias is removed or updated .
The reason behind is the usage of a query that updates the global mapentry.
I have added a new Test to the performance test suite and this is the outcome
{quote}
0 vanityPath16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath 111ms
1000 vanityPath 200ms
1 vanityPath1173ms
3 vanityPath3358ms
{quote}
was:
When many vanityPath or alias are present the system take long time to startup
, Same when a vanityPath/alias is removed or updated .
The reason behind is the usage of a query that updates the global mapentry.
I have added a new Test to the performance test suite and this is the outcome
{code}
0 vanityPath16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath 111ms
1000 vanityPath 200ms
1 vanityPath1173ms
3 vanityPath3358ms
{code}
Long startup time with many vanityPath or alias
---
Key: SLING-3290
URL: https://issues.apache.org/jira/browse/SLING-3290
Project: Sling
Issue Type: Improvement
Reporter: Antonio Sanso
When many vanityPath or alias are present the system take long time to
startup , Same when a vanityPath/alias is removed or updated .
The reason behind is the usage of a query that updates the global mapentry.
I have added a new Test to the performance test suite and this is the outcome
{quote}
0 vanityPath 16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath111ms
1000 vanityPath 200ms
1 vanityPath 1173ms
3 vanityPath 3358ms
{quote}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849231#comment-13849231 ] Antonio Sanso commented on SLING-2727: -- [~andrei.dulvac] sorry to bother you again but I have (finally ) tried to apply the patch but something seems to be missing e.g. IdentifiableTestCase et al Allow PerformanceRunner to run tests provided by a factory method - Key: SLING-2727 URL: https://issues.apache.org/jira/browse/SLING-2727 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Assignee: Antonio Sanso Priority: Minor Labels: PatchAvailable Attachments: performance_factory.patch, performance_factory.svn.patch, performance_reportlogger.patch, performance_reportlogger.svn.patch 1. I have modified PerformanceRunner to be able to run tests provided through a factory method annotated with @PerformanceTestFactory, when used with @PerformanceTestSuites. The method can be used (this is optional) on a test case object that is added to the ParameterizedTestList returned by the @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, the behaviour stays the same as before. If a @PerformanceTestFactory exists, the PerformanceRunner adds all the test case instances returned by the factory to the testObjects list, instead of the test case itself. Optionally, the test cases can implement an IdentifiableTestCase interface, which gives the ability to have custom names for tests running on different instances. The motivation behind this is that a suite can contain test cases that are different logically, but the test case should be able to be parameterized. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Assigned] (SLING-3291) Extend performace test suite to include latest changes in Sling
[ https://issues.apache.org/jira/browse/SLING-3291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Antonio Sanso reassigned SLING-3291: Assignee: Antonio Sanso Extend performace test suite to include latest changes in Sling --- Key: SLING-3291 URL: https://issues.apache.org/jira/browse/SLING-3291 Project: Sling Issue Type: Improvement Reporter: Antonio Sanso Assignee: Antonio Sanso The performance suite at the moment tests the performance against older version of the jcr resource bundle . It would be nice to have it working against org.apache.sling.jcr.resource version 2.0.10 (soon to be released) -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (SLING-3291) Extend performace test suite to include latest changes in Sling
Antonio Sanso created SLING-3291: Summary: Extend performace test suite to include latest changes in Sling Key: SLING-3291 URL: https://issues.apache.org/jira/browse/SLING-3291 Project: Sling Issue Type: Improvement Reporter: Antonio Sanso The performance suite at the moment tests the performance against older version of the jcr resource bundle . It would be nice to have it working against org.apache.sling.jcr.resource version 2.0.10 (soon to be released) -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Assigned] (SLING-3290) Long startup time with many vanityPath or alias
[
https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso reassigned SLING-3290:
Assignee: Antonio Sanso
Long startup time with many vanityPath or alias
---
Key: SLING-3290
URL: https://issues.apache.org/jira/browse/SLING-3290
Project: Sling
Issue Type: Improvement
Reporter: Antonio Sanso
Assignee: Antonio Sanso
When many vanityPath or alias are present the system take long time to
startup , Same when a vanityPath/alias is removed or updated .
The reason behind is the usage of a query that updates the global mapentry.
I have added a new Test to the performance test suite and this is the outcome
{quote}
0 vanityPath 16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath111ms
1000 vanityPath 200ms
1 vanityPath 1173ms
3 vanityPath 3358ms
{quote}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (SLING-2729) Performance Testing suite: Modified ReportLogger to log the test case name
[
https://issues.apache.org/jira/browse/SLING-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849238#comment-13849238
]
Antonio Sanso commented on SLING-2729:
--
[~andrei.dulvac] isn't this already covered here
{code}
String resultFileName = className;
if
(reportlevel.equals(PerformanceRunner.ReportLevel.ClassLevel)){
writeReportClassLevel(resultFileName, testSuiteName,
statistics);
}else if
(reportlevel.equals(PerformanceRunner.ReportLevel.MethodLevel)){
resultFileName = test + . + name;
writeReportMethodLevel(resultFileName,
testSuiteName, statistics);
}
{code}
Performance Testing suite: Modified ReportLogger to log the test case name
---
Key: SLING-2729
URL: https://issues.apache.org/jira/browse/SLING-2729
Project: Sling
Issue Type: Improvement
Components: Testing
Reporter: Antonio Sanso
Assignee: Antonio Sanso
Priority: Minor
Labels: PatchAvailable
Attachments: performance_reportlogger.patch
Modified ReportLogger to log the test case name as well. Also, changed the
method signatures so that it's clear what is being logged. This works with
patch 1 to distinguish between different test case instances
The motivation behind this is that a suite can contain test cases that are
different logically, but the test case should be able to be parameterized.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (SLING-3290) Long startup time with many vanityPath or alias
[
https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849240#comment-13849240
]
Antonio Sanso commented on SLING-3290:
--
{code}
0 vanityPath 16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath 111ms
1000 vanityPath 200ms
1 vanityPath 1173ms
3 vanityPath 3358ms
{code}
Long startup time with many vanityPath or alias
---
Key: SLING-3290
URL: https://issues.apache.org/jira/browse/SLING-3290
Project: Sling
Issue Type: Improvement
Reporter: Antonio Sanso
Assignee: Antonio Sanso
When many vanityPath or alias are present the system take long time to
startup , Same when a vanityPath/alias is removed or updated .
The reason behind is the usage of a query that updates the global mapentry.
I have added a new Test to the performance test suite and this is the outcome
{code}
0 vanityPath 16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath111ms
1000 vanityPath 200ms
1 vanityPath 1173ms
3 vanityPath 3358ms
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Updated] (SLING-3290) Long startup time with many vanityPath or alias
[
https://issues.apache.org/jira/browse/SLING-3290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Antonio Sanso updated SLING-3290:
-
Description:
When many vanityPath or alias are present the system take long time to startup
, Same when a vanityPath/alias is removed or updated .
The reason behind is the usage of a query that updates the global mapentry.
I have added a new Test to the performance test suite and this is the outcome
{code}
0 vanityPath16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath 111ms
1000 vanityPath 200ms
1 vanityPath1173ms
3 vanityPath3358ms
{code}
was:
When many vanityPath or alias are present the system take long time to startup
, Same when a vanityPath/alias is removed or updated .
The reason behind is the usage of a query that updates the global mapentry.
I have added a new Test to the performance test suite and this is the outcome
{quote}
0 vanityPath16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath 111ms
1000 vanityPath 200ms
1 vanityPath1173ms
3 vanityPath3358ms
{quote}
Long startup time with many vanityPath or alias
---
Key: SLING-3290
URL: https://issues.apache.org/jira/browse/SLING-3290
Project: Sling
Issue Type: Improvement
Reporter: Antonio Sanso
Assignee: Antonio Sanso
When many vanityPath or alias are present the system take long time to
startup , Same when a vanityPath/alias is removed or updated .
The reason behind is the usage of a query that updates the global mapentry.
I have added a new Test to the performance test suite and this is the outcome
{code}
0 vanityPath 16ms
1 vanityPath 19ms
10 vanityPath 70ms
100 vanityPath111ms
1000 vanityPath 200ms
1 vanityPath 1173ms
3 vanityPath 3358ms
{code}
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (SLING-2729) Performance Testing suite: Modified ReportLogger to log the test case name
[ https://issues.apache.org/jira/browse/SLING-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849249#comment-13849249 ] Andrei Dulvac commented on SLING-2729: -- Hi [~asanso], that's just the filename, the patch extends the text file content to log the testcase name inside the file. It is kind of required for the other patch, which allows parameterizable tests. Performance Testing suite: Modified ReportLogger to log the test case name --- Key: SLING-2729 URL: https://issues.apache.org/jira/browse/SLING-2729 Project: Sling Issue Type: Improvement Components: Testing Reporter: Antonio Sanso Assignee: Antonio Sanso Priority: Minor Labels: PatchAvailable Attachments: performance_reportlogger.patch Modified ReportLogger to log the test case name as well. Also, changed the method signatures so that it's clear what is being logged. This works with patch 1 to distinguish between different test case instances The motivation behind this is that a suite can contain test cases that are different logically, but the test case should be able to be parameterized. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849262#comment-13849262 ] Andrei Dulvac commented on SLING-2727: -- [~asanso], It's my fault. I used git and the *.svn.patch I've uploaded didn't take adds into consideration. And the two solutions are either the one doing the patch uses git apply, or I'll provide a proper svn patch. I'll upload them asap. Allow PerformanceRunner to run tests provided by a factory method - Key: SLING-2727 URL: https://issues.apache.org/jira/browse/SLING-2727 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Assignee: Antonio Sanso Priority: Minor Labels: PatchAvailable Attachments: performance_factory.patch, performance_factory.svn.patch, performance_reportlogger.patch, performance_reportlogger.svn.patch 1. I have modified PerformanceRunner to be able to run tests provided through a factory method annotated with @PerformanceTestFactory, when used with @PerformanceTestSuites. The method can be used (this is optional) on a test case object that is added to the ParameterizedTestList returned by the @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, the behaviour stays the same as before. If a @PerformanceTestFactory exists, the PerformanceRunner adds all the test case instances returned by the factory to the testObjects list, instead of the test case itself. Optionally, the test cases can implement an IdentifiableTestCase interface, which gives the ability to have custom names for tests running on different instances. The motivation behind this is that a suite can contain test cases that are different logically, but the test case should be able to be parameterized. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (SLING-2729) Performance Testing suite: Modified ReportLogger to log the test case name
[
https://issues.apache.org/jira/browse/SLING-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849264#comment-13849264
]
Antonio Sanso commented on SLING-2729:
--
[~andrei.dulvac]
bq. that's just the filename
actually not :) it is also reflected in the content
{code}
writer.format(
%-40.40s|%-80.80s|%-40.40s|%-20.20s|%7.0f|%9.0f|%9.0f|%9.0f|%9.0f%n,
testSuiteName,
className,
methodName,
getDate(),
statistics.getMin(),
statistics.getPercentile(10.0),
statistics.getPercentile(50.0),
statistics.getPercentile(90.0),
statistics.getMax());
} finally {
{code}
Performance Testing suite: Modified ReportLogger to log the test case name
---
Key: SLING-2729
URL: https://issues.apache.org/jira/browse/SLING-2729
Project: Sling
Issue Type: Improvement
Components: Testing
Reporter: Antonio Sanso
Assignee: Antonio Sanso
Priority: Minor
Labels: PatchAvailable
Attachments: performance_reportlogger.patch
Modified ReportLogger to log the test case name as well. Also, changed the
method signatures so that it's clear what is being logged. This works with
patch 1 to distinguish between different test case instances
The motivation behind this is that a suite can contain test cases that are
different logically, but the test case should be able to be parameterized.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Commented] (SLING-2729) Performance Testing suite: Modified ReportLogger to log the test case name
[
https://issues.apache.org/jira/browse/SLING-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849280#comment-13849280
]
Andrei Dulvac commented on SLING-2729:
--
With the patch, it looks like this:
{code}
try {
if (needsPrefix) {
writer.format(
%-40.40s|%-120.120s|%-80.80s|%-40.40s| DateTime
| min | 10%% | 50%% | 90%% | max%n,
Test Suite,
Test Case,
Test Class,
Test Method);
}
writer.format(
%-40.40s|%-120.120s|%-80.80s|%-40.40s|%-20.20s|%7.0f|%9.0f|%9.0f|%9.0f|%9.0f%n,
testSuiteName,
(testCaseName.length() 120) ? (testCaseName)
: (testCaseName.substring(0, 115) + [...]),
className,
methodName,
getDate(),
statistics.getMin(),
statistics.getPercentile(10.0),
statistics.getPercentile(50.0),
statistics.getPercentile(90.0),
statistics.getMax());
} finally {
writer.close();
}
{code}
That allows a custom testcase name, which is needed if you're running the same
test class and method with different parameters.
Performance Testing suite: Modified ReportLogger to log the test case name
---
Key: SLING-2729
URL: https://issues.apache.org/jira/browse/SLING-2729
Project: Sling
Issue Type: Improvement
Components: Testing
Reporter: Antonio Sanso
Assignee: Antonio Sanso
Priority: Minor
Labels: PatchAvailable
Attachments: performance_reportlogger.patch
Modified ReportLogger to log the test case name as well. Also, changed the
method signatures so that it's clear what is being logged. This works with
patch 1 to distinguish between different test case instances
The motivation behind this is that a suite can contain test cases that are
different logically, but the test case should be able to be parameterized.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Updated] (SLING-2729) Performance Testing suite: Modified ReportLogger to log the test case name
[ https://issues.apache.org/jira/browse/SLING-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2729: - Attachment: performance_reportlogger-svn.patch Performance Testing suite: Modified ReportLogger to log the test case name --- Key: SLING-2729 URL: https://issues.apache.org/jira/browse/SLING-2729 Project: Sling Issue Type: Improvement Components: Testing Reporter: Antonio Sanso Assignee: Antonio Sanso Priority: Minor Labels: PatchAvailable Attachments: performance_reportlogger-svn.patch, performance_reportlogger.patch Modified ReportLogger to log the test case name as well. Also, changed the method signatures so that it's clear what is being logged. This works with patch 1 to distinguish between different test case instances The motivation behind this is that a suite can contain test cases that are different logically, but the test case should be able to be parameterized. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: (was: performance_reportlogger.svn.patch) Allow PerformanceRunner to run tests provided by a factory method - Key: SLING-2727 URL: https://issues.apache.org/jira/browse/SLING-2727 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Assignee: Antonio Sanso Priority: Minor Labels: PatchAvailable Attachments: performance_factory.patch 1. I have modified PerformanceRunner to be able to run tests provided through a factory method annotated with @PerformanceTestFactory, when used with @PerformanceTestSuites. The method can be used (this is optional) on a test case object that is added to the ParameterizedTestList returned by the @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, the behaviour stays the same as before. If a @PerformanceTestFactory exists, the PerformanceRunner adds all the test case instances returned by the factory to the testObjects list, instead of the test case itself. Optionally, the test cases can implement an IdentifiableTestCase interface, which gives the ability to have custom names for tests running on different instances. The motivation behind this is that a suite can contain test cases that are different logically, but the test case should be able to be parameterized. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: (was: performance_factory.svn.patch) Allow PerformanceRunner to run tests provided by a factory method - Key: SLING-2727 URL: https://issues.apache.org/jira/browse/SLING-2727 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Assignee: Antonio Sanso Priority: Minor Labels: PatchAvailable Attachments: performance_factory.patch 1. I have modified PerformanceRunner to be able to run tests provided through a factory method annotated with @PerformanceTestFactory, when used with @PerformanceTestSuites. The method can be used (this is optional) on a test case object that is added to the ParameterizedTestList returned by the @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, the behaviour stays the same as before. If a @PerformanceTestFactory exists, the PerformanceRunner adds all the test case instances returned by the factory to the testObjects list, instead of the test case itself. Optionally, the test cases can implement an IdentifiableTestCase interface, which gives the ability to have custom names for tests running on different instances. The motivation behind this is that a suite can contain test cases that are different logically, but the test case should be able to be parameterized. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Commented] (SLING-2729) Performance Testing suite: Modified ReportLogger to log the test case name
[ https://issues.apache.org/jira/browse/SLING-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13849310#comment-13849310 ] Andrei Dulvac commented on SLING-2729: -- Attached working svn patch Performance Testing suite: Modified ReportLogger to log the test case name --- Key: SLING-2729 URL: https://issues.apache.org/jira/browse/SLING-2729 Project: Sling Issue Type: Improvement Components: Testing Reporter: Antonio Sanso Assignee: Antonio Sanso Priority: Minor Labels: PatchAvailable Attachments: performance_reportlogger-svn.patch, performance_reportlogger.patch Modified ReportLogger to log the test case name as well. Also, changed the method signatures so that it's clear what is being logged. This works with patch 1 to distinguish between different test case instances The motivation behind this is that a suite can contain test cases that are different logically, but the test case should be able to be parameterized. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Updated] (SLING-2727) Allow PerformanceRunner to run tests provided by a factory method
[ https://issues.apache.org/jira/browse/SLING-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-2727: - Attachment: performance_factory-svn.patch Attached working svn patch Allow PerformanceRunner to run tests provided by a factory method - Key: SLING-2727 URL: https://issues.apache.org/jira/browse/SLING-2727 Project: Sling Issue Type: Improvement Components: Testing Reporter: Andrei Dulvac Assignee: Antonio Sanso Priority: Minor Labels: PatchAvailable Attachments: performance_factory-svn.patch, performance_factory.patch 1. I have modified PerformanceRunner to be able to run tests provided through a factory method annotated with @PerformanceTestFactory, when used with @PerformanceTestSuites. The method can be used (this is optional) on a test case object that is added to the ParameterizedTestList returned by the @PerformanceTestSuite method. If there is no @PerformanceTestFactory method, the behaviour stays the same as before. If a @PerformanceTestFactory exists, the PerformanceRunner adds all the test case instances returned by the factory to the testObjects list, instead of the test case itself. Optionally, the test cases can implement an IdentifiableTestCase interface, which gives the ability to have custom names for tests running on different instances. The motivation behind this is that a suite can contain test cases that are different logically, but the test case should be able to be parameterized. -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Re: [VOTE] Release Apache Sling Web Console Security Provider 1.1.2
+1 regards, Karl On Mon, Dec 16, 2013 at 6:12 PM, Mike Müller mike...@mysign.ch wrote: Here's my +1 Best regards mike -Original Message- From: Felix Meschberger [mailto:fmesc...@adobe.com] Sent: Monday, December 16, 2013 10:48 AM To: dev@sling.apache.org Subject: Re: [VOTE] Release Apache Sling Web Console Security Provider 1.1.2 Hi Carsten Am 16.12.2013 um 10:34 schrieb Carsten Ziegeler cziege...@apache.org: uh...sorry, I forgot to resolve them - both are done Excellent. Thanks. So here is my +1 Regards Felix Thanks Carsten 2013/12/16 Felix Meschberger fmesc...@adobe.com Hi Carsten Sorry for the delay. I just looked at the issues for this version and I am a bit confused as to SLING-3273 and SLING-3271: Both are tagged for this release, have commits but are unresolved. Is this an omission are they really incomplete ? Thanks Felix Am 15.12.2013 um 22:46 schrieb Carsten Ziegeler cziege...@apache.org : Anyone? 2013/12/12 Carsten Ziegeler cziege...@apache.org +1 2013/12/12 Carsten Ziegeler cziege...@apache.org Hi, its time for a new release of the security provider Sling Web Console Security Provider 1.1.2 https://issues.apache.org/jira/browse/SLING/fixforversion/12325305 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-046/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 046 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This vote will be open for 72 hours. Regards Carsten -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Carsten Ziegeler cziege...@apache.org -- Karl Pauls karlpa...@gmail.com http://twitter.com/karlpauls http://www.linkedin.com/in/karlpauls https://profiles.google.com/karlpauls
Re: [ResourceAccessSecurity] Returns NonExistingResource if acess is denied
On 16.12.2013, at 04:38, Dominik Süß dominik.su...@gmail.com wrote: There is currently a gap between the behavior of .resolve() and .getResource() where getResource would return null and .resolve() should return a NonExistingResource. I'm pretty sure there is a reason for that, but I couldn't find it. Oh, yes, there is a good reason for that: - resolve() is used for request processing, where it is necessary to handle the non-existing case with the special sling:nonexisting resource type and the original path info - getResource() is the more raw access, similar to JCR Session.getNode() (*) Applications would always use getResource() and handle the null check. resolve() is mostly only for the sling engine, or if you have some more complex internal forwarding etc. that requires to replicate Sling's resolution behavior. (*) yes, getNode() throws an exception, but that's similar to returning null compared to returning a special NonExistingResource object Cheers, Alex
Re: [ResourceAccessSecurity] Returns NonExistingResource if acess is denied
Yepp, exactly - so a resource provider and that includes the resource access security implementation should never return a NonExistingResource - otherwise the getResource() contract of the ResourceResolver will be broken. So, I'll go ahead and change this Thanks Carsten 2013/12/17 Alexander Klimetschek aklim...@adobe.com On 16.12.2013, at 04:38, Dominik Süß dominik.su...@gmail.com wrote: There is currently a gap between the behavior of .resolve() and .getResource() where getResource would return null and .resolve() should return a NonExistingResource. I'm pretty sure there is a reason for that, but I couldn't find it. Oh, yes, there is a good reason for that: - resolve() is used for request processing, where it is necessary to handle the non-existing case with the special sling:nonexisting resource type and the original path info - getResource() is the more raw access, similar to JCR Session.getNode() (*) Applications would always use getResource() and handle the null check. resolve() is mostly only for the sling engine, or if you have some more complex internal forwarding etc. that requires to replicate Sling's resolution behavior. (*) yes, getNode() throws an exception, but that's similar to returning null compared to returning a special NonExistingResource object Cheers, Alex -- Carsten Ziegeler cziege...@apache.org
[jira] [Closed] (SLING-3273) Switch to login page if user is not allowed to access the web console
[ https://issues.apache.org/jira/browse/SLING-3273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3273. --- Switch to login page if user is not allowed to access the web console - Key: SLING-3273 URL: https://issues.apache.org/jira/browse/SLING-3273 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Web Console Security Provider 1.1.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Web Console Security Provider 1.1.2 RIght now if the current user is not allowed to access the web console, forbidden is returned - we should rather redirect to the login page instead -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Closed] (SLING-3271) Make Sling imports dynamic
[ https://issues.apache.org/jira/browse/SLING-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler closed SLING-3271. --- Make Sling imports dynamic -- Key: SLING-3271 URL: https://issues.apache.org/jira/browse/SLING-3271 Project: Sling Issue Type: Improvement Components: Extensions Affects Versions: Web Console Security Provider 1.1.0 Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Web Console Security Provider 1.1.2 Currently the imports to sling auth core and sling api resource are mandatory, this means the security provider is only active if Sling is running. These imports should rather be dynamic as the provider should also run if only the repository is available -- This message was sent by Atlassian JIRA (v6.1.4#6159)
Re: [ResourceAccessSecurity] Returns NonExistingResource if acess is denied
Ah ok thanks, wasn't really sure about that due to the alternative resolve signature with request but I should have read the classdescription which is pretty clear. So +1 from my side as well. Best regards Dominik Am 16.12.2013 21:38 schrieb Alexander Klimetschek aklim...@adobe.com: On 16.12.2013, at 04:38, Dominik Süß dominik.su...@gmail.com wrote: There is currently a gap between the behavior of .resolve() and .getResource() where getResource would return null and .resolve() should return a NonExistingResource. I'm pretty sure there is a reason for that, but I couldn't find it. Oh, yes, there is a good reason for that: - resolve() is used for request processing, where it is necessary to handle the non-existing case with the special sling:nonexisting resource type and the original path info - getResource() is the more raw access, similar to JCR Session.getNode() (*) Applications would always use getResource() and handle the null check. resolve() is mostly only for the sling engine, or if you have some more complex internal forwarding etc. that requires to replicate Sling's resolution behavior. (*) yes, getNode() throws an exception, but that's similar to returning null compared to returning a special NonExistingResource object Cheers, Alex
