[jira] [Commented] (SLING-3477) BackgroundHttpServletRequest incompatible with Enging 2.3.0

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948969#comment-13948969
 ] 

Carsten Ziegeler commented on SLING-3477:
-

As there is no stacktrace attached, I can only guess where the problem lies, 
but I've committed a potential fix in rev 1582206

[~chkeller] Could you please give this a try?

> BackgroundHttpServletRequest incompatible with Enging 2.3.0
> ---
>
> Key: SLING-3477
> URL: https://issues.apache.org/jira/browse/SLING-3477
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Christan Keller
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Background Servlet 1.0.0
>
>
> Engine 2.3.0 changed the ParameterSupport.
> It uses the ServletRequest#getInputStream to access Parameters.
> The BackgroundExecution has an on implemenation of HttpServletRequest that 
> throws a RuntimeException for this method.
> Thus even with engine 2.3.2 (Sling-3439) the creation of a 
> BackgroundExecutionJob fails.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3477) BackgroundHttpServletRequest incompatible with Enging 2.3.0

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-3477:


Fix Version/s: Background Servlet 1.0.0

> BackgroundHttpServletRequest incompatible with Enging 2.3.0
> ---
>
> Key: SLING-3477
> URL: https://issues.apache.org/jira/browse/SLING-3477
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Christan Keller
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Background Servlet 1.0.0
>
>
> Engine 2.3.0 changed the ParameterSupport.
> It uses the ServletRequest#getInputStream to access Parameters.
> The BackgroundExecution has an on implemenation of HttpServletRequest that 
> throws a RuntimeException for this method.
> Thus even with engine 2.3.2 (Sling-3439) the creation of a 
> BackgroundExecutionJob fails.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Assigned] (SLING-3477) BackgroundHttpServletRequest incompatible with Enging 2.3.0

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reassigned SLING-3477:
---

Assignee: Carsten Ziegeler

> BackgroundHttpServletRequest incompatible with Enging 2.3.0
> ---
>
> Key: SLING-3477
> URL: https://issues.apache.org/jira/browse/SLING-3477
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Christan Keller
>Assignee: Carsten Ziegeler
>Priority: Minor
>
> Engine 2.3.0 changed the ParameterSupport.
> It uses the ServletRequest#getInputStream to access Parameters.
> The BackgroundExecution has an on implemenation of HttpServletRequest that 
> throws a RuntimeException for this method.
> Thus even with engine 2.3.2 (Sling-3439) the creation of a 
> BackgroundExecutionJob fails.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Build failed in Jenkins: sling-contrib-1.6 #1115

[Apache Jenkins Server]

See 

Changes:

[cziegeler] Use released Sling API 2.7.0

[cziegeler] Use released Sling API 2.7.0

[olli] SLING-3027 use latest releases (Sling API, Sling JMX Provider and Sling 
JCR Resource)

[tommaso] SLING-3471 - added IT for agent commands

[tommaso] SLING-3470 - Improved coverage of agent and importer resources

[tommaso] SLING-3470 - added base class for all ITs, added IT for package 
importers, minor improvements to agent IT

[cziegeler] Use released api for release

[cziegeler] [maven-release-plugin] prepare for next development iteration

[cziegeler] [maven-release-plugin] prepare release 
org.apache.sling.jmx.provider-1.0.2

[cziegeler] Use released api for release

[cziegeler] Switch to current snapshot of api until release is out

[cziegeler] [maven-release-plugin] prepare for next development iteration

[cziegeler] [maven-release-plugin] prepare release 
org.apache.sling.resourcemerger-1.1.2

[cziegeler] Use released Sling API

[tommaso] SLING-3456 - added 2 missing Test annotations

[tommaso] SLING-3456 - added tests for other default agents resources

[tommaso] SLING-3456 - improved default agent configurations IT to check for 
all the configs provided by replication.core

[olli] SLING-3017 add tests for bundle states

[olli] SLING-3017 add more helper methods, use dynamic (free) ports for Karaf

[olli] SLING-3027 minor cleanup and update

[tommaso] SLING-3456 - using released sling.api

[tommaso] SLING-3456 - missing changes on replication/core from Marius patch

[tommaso] SLING-3456 - missing changes on replication/core from Marius patch

[tommaso] SLING-3456 - added replication.it bundle

[tommaso] SLING-3456 - moving contrib/extensions/replication into 
contrib/extensions/replication/core

[tommaso] SLING-3456 - moving contrib/extensions/replication into 
contrib/extensions/replication/core

[olli] SLING-3027 switch to snapshots to fix dependencies where needed

[tommaso] SLING-3352 - applied Marius's patch to expose OSGI configuration via 
HTTP

--
[...truncated 1594 lines...]
... 31 more
Caused by: java.io.IOException: Error resolving artifact 
org.apache.sling:org.apache.sling.launchpad:xml:bundlelist:7-SNAPSHOT: Could 
not find artifact 
org.apache.sling:org.apache.sling.launchpad:xml:bundlelist:7-SNAPSHOT in 
central (http://repo1.maven.org/maven2/)
at 
org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:258)
at 
org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolveFile(AetherBasedResolver.java:239)
at 
org.ops4j.pax.url.mvn.internal.AetherBasedResolver.resolve(AetherBasedResolver.java:223)
at 
org.ops4j.pax.url.mvn.internal.Connection.getInputStream(Connection.java:122)
at java.net.URL.openStream(URL.java:1010)
at 
org.apache.sling.paxexam.util.SlingPaxOptions.dumpMvnUrlToTmpFile(SlingPaxOptions.java:204)
at 
org.apache.sling.paxexam.util.SlingPaxOptions.slingBundleList(SlingPaxOptions.java:121)
... 34 more


Results :

Tests in error: 
  initializationError(org.apache.sling.i18n.it.ResourceBundleProviderIT)

Tests run: 1, Failures: 0, Errors: 1, Skipped: 0

[WARNING] File encoding has not been set, using platform encoding 
ANSI_X3.4-1968, i.e. build is platform dependent!
[JENKINS] Recording test results
[INFO] 
[INFO] --- ianal-maven-plugin:1.0-alpha-1:verify-legal-files (default) @ 
org.apache.sling.i18n ---
[INFO] Checking legal files in: org.apache.sling.i18n-2.2.9-SNAPSHOT.jar
[INFO] Checking legal files in: org.apache.sling.i18n-2.2.9-SNAPSHOT-sources.jar
[INFO] 
[INFO] --- maven-failsafe-plugin:2.12.4:verify (default) @ 
org.apache.sling.i18n ---
[INFO] Failsafe report directory: 

[WARNING] File encoding has not been set, using platform encoding 
ANSI_X3.4-1968, i.e. build is platform dependent!
[ERROR] There are test failures.

Please refer to 

 for the individual test results.
[JENKINS] Recording test results[INFO] 
[INFO] --- maven-install-plugin:2.3.1:install (default-install) @ 
org.apache.sling.i18n ---
[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.i18n/2.2.9-SNAPSHOT/org.apache.sling.i18n-2.2.9-SNAPSHOT.jar

[INFO] Installing 

 to 
/home/jenkins/jenkins-slave/maven-repositories/1/org/apache/sling/org.apache.sling.i18n/2.2.9-SNAPSHOT/org.apache.sling.i18n-2.2.9-SNAPSHOT.pom
[INFO] Installing 

Build failed in Jenkins: sling-contrib-1.6 » Apache Sling MongoDB Resource Provider #1115

[Apache Jenkins Server]

See 


--
[INFO] 
[INFO] 
[INFO] Building Apache Sling MongoDB Resource Provider 0.0.1-SNAPSHOT
[INFO] 
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.api/2.6.1-SNAPSHOT/maven-metadata.xml
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.api/2.6.1-SNAPSHOT/org.apache.sling.api-2.6.1-SNAPSHOT.pom
[WARNING] The POM for org.apache.sling:org.apache.sling.api:jar:2.6.1-SNAPSHOT 
is missing, no dependency information available
Downloading: 
http://repository.apache.org/snapshots/org/apache/sling/org.apache.sling.api/2.6.1-SNAPSHOT/org.apache.sling.api-2.6.1-SNAPSHOT.jar
[JENKINS] Archiving disabled

Jenkins build is back to normal : sling-contrib-1.6 » Apache Sling JMX Resource Provider #1115

[Apache Jenkins Server]

See 

Jenkins build became unstable: sling-trunk-1.7 #455

[Apache Jenkins Server]

See 

Jenkins build became unstable: sling-trunk-1.7 » Apache Sling Dynamic Class Loader Support #455

[Apache Jenkins Server]

See 

[jira] [Comment Edited] (SLING-3481) AbstractSlingRepository2.login().getRepository() not symmetric

[Tobias Bocanegra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948336#comment-13948336
 ] 

Tobias Bocanegra edited comment on SLING-3481 at 3/26/14 7:10 PM:
--

Attached patch that solves the top most problem within the SessionProxy. But 
I'm not sure if this is the correct place, nor worth the effort as the original 
session object gets lost over {{getItem(*)}} calls anyways.


was (Author: tripod):
Attached patch that solves the top most problem within the SessionProxy. But 
I'm not sure if this is the correct place, nor worth the effort as the original 
repository object gets lost over getItem(*) calls anyways.

> AbstractSlingRepository2.login().getRepository() not symmetric
> --
>
> Key: SLING-3481
> URL: https://issues.apache.org/jira/browse/SLING-3481
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Affects Versions: JCR Base 2.2.2
>Reporter: Tobias Bocanegra
>Priority: Minor
> Fix For: JCR Base 2.2.4
>
> Attachments: SLING-3481.r1582018..patch
>
>
> the AbstractSlingRepository2.login() returns a session, which does not return 
> the same repository object in 'getRepository()'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3481) AbstractSlingRepository2.login().getRepository() not symmetric

[Tobias Bocanegra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra updated SLING-3481:


Attachment: SLING-3481.r1582018..patch

Attached patch that solves the top most problem within the SessionProxy. But 
I'm not sure if this is the correct place, nor worth the effort as the original 
repository object gets lost over getItem(*) calls anyways.

> AbstractSlingRepository2.login().getRepository() not symmetric
> --
>
> Key: SLING-3481
> URL: https://issues.apache.org/jira/browse/SLING-3481
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Affects Versions: JCR Base 2.2.2
>Reporter: Tobias Bocanegra
>Priority: Minor
> Fix For: JCR Base 2.2.4
>
> Attachments: SLING-3481.r1582018..patch
>
>
> the AbstractSlingRepository2.login() returns a session, which does not return 
> the same repository object in 'getRepository()'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Comment Edited] (SLING-3481) AbstractSlingRepository2.login().getRepository() not symmetric

[Tobias Bocanegra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948336#comment-13948336
 ] 

Tobias Bocanegra edited comment on SLING-3481 at 3/26/14 7:10 PM:
--

Attached patch that solves the top most problem within the SessionProxy. But 
I'm not sure if this is the correct place, nor worth the effort as the original 
session object gets lost over {{getItem()}} calls anyways.


was (Author: tripod):
Attached patch that solves the top most problem within the SessionProxy. But 
I'm not sure if this is the correct place, nor worth the effort as the original 
session object gets lost over {{getItem(*)}} calls anyways.

> AbstractSlingRepository2.login().getRepository() not symmetric
> --
>
> Key: SLING-3481
> URL: https://issues.apache.org/jira/browse/SLING-3481
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Affects Versions: JCR Base 2.2.2
>Reporter: Tobias Bocanegra
>Priority: Minor
> Fix For: JCR Base 2.2.4
>
> Attachments: SLING-3481.r1582018..patch
>
>
> the AbstractSlingRepository2.login() returns a session, which does not return 
> the same repository object in 'getRepository()'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3481) AbstractSlingRepository2.login().getRepository() not symmetric

[Tobias Bocanegra (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra updated SLING-3481:


Priority: Minor  (was: Major)

> AbstractSlingRepository2.login().getRepository() not symmetric
> --
>
> Key: SLING-3481
> URL: https://issues.apache.org/jira/browse/SLING-3481
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Affects Versions: JCR Base 2.2.2
>Reporter: Tobias Bocanegra
>Priority: Minor
> Fix For: JCR Base 2.2.4
>
>
> the AbstractSlingRepository2.login() returns a session, which does not return 
> the same repository object in 'getRepository()'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: AbstractSlingRepository2.login().getRepository() not symmetric

[Tobias Bocanegra]

Of course the problem goes further, so that
session.getNode().getSession().getRepository() then does not return
the original repository. so eventually we need to decorate all items
and items of items that return the session again.

regards, toby

On Wed, Mar 26, 2014 at 11:28 AM, Tobias Bocanegra  wrote:
> Hi,
>
> It looks like the AbstractSlingRepository2.login() returns a session,
> which does not return the same repository object in 'getRepository()'.
>
> I created an issue and will try to provide a patch.
> regards, toby
>
> [0] https://issues.apache.org/jira/browse/SLING-3481

[jira] [Commented] (SLING-3481) AbstractSlingRepository2.login().getRepository() not symmetric

[Tobias Bocanegra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948297#comment-13948297
 ] 

Tobias Bocanegra commented on SLING-3481:
-

the problem goes further, even if the session is decorated to return the 
correct repository, all items created from the session would need to return the 
outer session.

eg:
{code}
session.getNode().getSession() != session;
{code}


> AbstractSlingRepository2.login().getRepository() not symmetric
> --
>
> Key: SLING-3481
> URL: https://issues.apache.org/jira/browse/SLING-3481
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Affects Versions: JCR Base 2.2.2
>Reporter: Tobias Bocanegra
> Fix For: JCR Base 2.2.4
>
>
> the AbstractSlingRepository2.login() returns a session, which does not return 
> the same repository object in 'getRepository()'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Jenkins build is still unstable: sling-trunk-1.6 #2085

[Apache Jenkins Server]

See 

[jira] [Created] (SLING-3481) AbstractSlingRepository2.login().getRepository() not symmetric

[Tobias Bocanegra (JIRA)]

Tobias Bocanegra created SLING-3481:
---

 Summary: AbstractSlingRepository2.login().getRepository() not 
symmetric
 Key: SLING-3481
 URL: https://issues.apache.org/jira/browse/SLING-3481
 Project: Sling
  Issue Type: Bug
  Components: General
Affects Versions: JCR Base 2.2.2
Reporter: Tobias Bocanegra
 Fix For: JCR Base 2.2.4


the AbstractSlingRepository2.login() returns a session, which does not return 
the same repository object in 'getRepository()'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

AbstractSlingRepository2.login().getRepository() not symmetric

[Tobias Bocanegra]

Hi,

It looks like the AbstractSlingRepository2.login() returns a session,
which does not return the same repository object in 'getRepository()'.

I created an issue and will try to provide a patch.
regards, toby

[0] https://issues.apache.org/jira/browse/SLING-3481

[jira] [Commented] (SLING-3481) AbstractSlingRepository2.login().getRepository() not symmetric

[Tobias Bocanegra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948270#comment-13948270
 ] 

Tobias Bocanegra commented on SLING-3481:
-

for example, this does not work:

{code}
@Refererence
SlingRepository repo;

Session s = repo.login(...);
SlingRepository r = (SlingRepository) s.getRepository();
{code}


> AbstractSlingRepository2.login().getRepository() not symmetric
> --
>
> Key: SLING-3481
> URL: https://issues.apache.org/jira/browse/SLING-3481
> Project: Sling
>  Issue Type: Bug
>  Components: General
>Affects Versions: JCR Base 2.2.2
>Reporter: Tobias Bocanegra
> Fix For: JCR Base 2.2.4
>
>
> the AbstractSlingRepository2.login() returns a session, which does not return 
> the same repository object in 'getRepository()'.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Jenkins build became unstable: sling-trunk-1.6 » Apache Sling SLF4J Implementation (Logback) #2085

[Apache Jenkins Server]

See 

Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Dynamic Class Loader Support #2085

[Apache Jenkins Server]

See 

Jenkins build became unstable: sling-trunk-1.6 » Apache Sling Resource-Based Discovery Service #2085

[Apache Jenkins Server]

See 

Jenkins build is back to stable : sling-trunk-1.6 » Apache Sling Sample Integration Tests #2085

[Apache Jenkins Server]

See 

Jenkins and Buildbot jobs not triggering

[Robert Munteanu]

Hi,

The Sling Jenkins builds were broken due to a config change related to
Maven versions, and the Buildbot slave seems to be offline.

I hopefully fixed the Jenkins config but I have no idea what to do
about Buildbot. Can someone look into it?

Thanks,

Robert

-- 
http://robert.muntea.nu/

[jira] [Commented] (SLING-920) Sling Jenkins setup

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948086#comment-13948086
 ] 

Robert Munteanu commented on SLING-920:
---

Updated sling-trunk-1.6 and sling-trunk-1.7 to fix job execution. Previously, 
they would fail with

{code}FATAL: Failed to install 
http://archive.apache.org/dist/maven/binaries/apache-maven-3.0.4-bin.zip to 
/home/hudson/tools/maven/apache-maven-3.0.4{code}

This was previously discussed on bui...@apache.org, but I don't have the link 
at hand.

> Sling Jenkins setup
> ---
>
> Key: SLING-920
> URL: https://issues.apache.org/jira/browse/SLING-920
> Project: Sling
>  Issue Type: Task
>  Components: Testing
>Reporter: Bertrand Delacretaz
>
> Use this issue to record changes to the Hudson continuous environment setup 
> at http://hudson.zones.apache.org/hudson/view/Sling/



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3478) Facilitate writing of integration tests for multiple instances

[Marius Petria (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Petria updated SLING-3478:
-

Attachment: SLING-3478.1.patch

Hi Bertrand,

I dropped the base class and instead made it an utility class 
SlingInstanceManager. A test with multiple instances will look like this:

{code}
public class MultipleOsgiConsoleTest {

SlingInstanceManager manager = new SlingInstanceManager("instance1", 
"instance2");


@Test
public void testSomeConsolePaths() throws Exception {
for (SlingInstance slingInstance : manager.getInstances()) {
testSomeConsolePaths(slingInstance);
}
}
   .
}
{code}

> Facilitate writing of integration tests for multiple instances
> --
>
> Key: SLING-3478
> URL: https://issues.apache.org/jira/browse/SLING-3478
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Marius Petria
> Attachments: SLING-3478.1.patch, SLING-3478.patch
>
>
> Facilitate writing of integration tests for multiple instances. This is 
> needed for better testing features like replication or topology discovery.
> Create a base class for such tests and a way to configure multiple instances 
> and also sample integration test.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: Bootstrap configs that depend on run modes, how?

[Carsten Ziegeler]

Hi,

you can just put your config in a directory which has the name of the run
mode, the Sling launchpad supports this.

Regards
Carsten


2014-03-26 16:19 GMT+01:00 Bertrand Delacretaz :

> Hi,
>
> For SLING-3479 we're looking for a way to switch between the tar and
> mongo backends when running on Oak.
>
> Using run modes should allow for switching between those configs - do
> we have an out-of-the box mechanism for OSGi configs that are selected
> by run mode before the content repository is active?
>
> What comes to mind is creating two bundles, one for each run mode, and
> have their activator create default configs for each backend if no
> config is present yet, as we do in the jackrabbit server bundle
> activator (verifyConfig method). But maybe there's a simpler way that
> does not require configuring additional installer components.
>
> -Bertrand
>
> [1]
> https://svn.apache.org/repos/asf/sling/trunk/bundles/jcr/jackrabbit-server/src/main/java/org/apache/sling/jcr/jackrabbit/server/impl/Activator.java
>



-- 
Carsten Ziegeler
cziege...@apache.org

[jira] [Commented] (SLING-3480) Adding test for replication config delete

[Tommaso Teofili (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948012#comment-13948012
 ] 

Tommaso Teofili commented on SLING-3480:


thanks Marius, I'll have a look at your patch later today or tomorrow

> Adding test for replication config delete
> -
>
> Key: SLING-3480
> URL: https://issues.apache.org/jira/browse/SLING-3480
> Project: Sling
>  Issue Type: Test
>  Components: Extensions
>Reporter: Marius Petria
>Priority: Minor
> Attachments: SLING-3480.patch
>
>
> Adding test for replication config delete and also fixing the test for config 
> create,



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3480) Adding test for replication config delete

[Marius Petria (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Petria updated SLING-3480:
-

Attachment: SLING-3480.patch

I have fixed the test for creation of configs and added new ones for update and 
delete.

> Adding test for replication config delete
> -
>
> Key: SLING-3480
> URL: https://issues.apache.org/jira/browse/SLING-3480
> Project: Sling
>  Issue Type: Test
>  Components: Extensions
>Reporter: Marius Petria
>Priority: Minor
> Attachments: SLING-3480.patch
>
>
> Adding test for replication config delete and also fixing the test for config 
> create,



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Created] (SLING-3480) Adding test for replication config delete

[Marius Petria (JIRA)]

Marius Petria created SLING-3480:


 Summary: Adding test for replication config delete
 Key: SLING-3480
 URL: https://issues.apache.org/jira/browse/SLING-3480
 Project: Sling
  Issue Type: Test
  Components: Extensions
Reporter: Marius Petria
Priority: Minor


Adding test for replication config delete and also fixing the test for config 
create,



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Bootstrap configs that depend on run modes, how?

[Bertrand Delacretaz]

Hi,

For SLING-3479 we're looking for a way to switch between the tar and
mongo backends when running on Oak.

Using run modes should allow for switching between those configs - do
we have an out-of-the box mechanism for OSGi configs that are selected
by run mode before the content repository is active?

What comes to mind is creating two bundles, one for each run mode, and
have their activator create default configs for each backend if no
config is present yet, as we do in the jackrabbit server bundle
activator (verifyConfig method). But maybe there's a simpler way that
does not require configuring additional installer components.

-Bertrand

[1] 
https://svn.apache.org/repos/asf/sling/trunk/bundles/jcr/jackrabbit-server/src/main/java/org/apache/sling/jcr/jackrabbit/server/impl/Activator.java

[jira] [Commented] (SLING-3479) Upgrade Oak Repository Server bundle to Oak 0.20

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947985#comment-13947985
 ] 

Bertrand Delacretaz commented on SLING-3479:


Thanks for your patch! It seems like Oak 0.20 should be out soon so we might 
wait for that.

We don't usually test run modes in code, but rather use different components or 
configurations for each run mode, and activate only the relevant ones.

I'm not sure how that works for the kind of bootstrap configurations that you 
have here. Sling will pick up configurations under ${sling.home}/config but I 
don't think those are run mode dependent. I'll ask on list.

[1] 
https://svn.apache.org/repos/asf/sling/trunk/bundles/jcr/jackrabbit-server/src/main/java/org/apache/sling/jcr/jackrabbit/server/impl/Activator.java

> Upgrade Oak Repository Server bundle to Oak 0.20
> 
>
> Key: SLING-3479
> URL: https://issues.apache.org/jira/browse/SLING-3479
> Project: Sling
>  Issue Type: Improvement
>  Components: Oak
>Reporter: Artyom Stetsenko
>Priority: Minor
> Attachments: SLING-3479-Oak018.patch
>
>
> Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
> upgrade it to the latest Oak version*.
> * Oak 0.20 is being targeted instead of the currently latest release 0.19 
> because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak 
> to fail



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (SLING-3478) Facilitate writing of integration tests for multiple instances

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947960#comment-13947960
 ] 

Bertrand Delacretaz commented on SLING-3478:


Hi, sorry I overlooked that you were looking at the newer testing/tools. If we 
can move away from requiring base classes there as well that would be good - 
while keeping backwards compatibility of course.

The story is that the bundles/commons/testing module was created early in the 
Sling history, and it it is still used by the launchpad/integration-tests 
module that tests Sling itself, we didn't want to adapt all those tests.

But we recommend that people use the more modern testing/tools, so unless your 
multiple instances tests are meant to be used inside the Sling codebase it's 
fine for you to work in there. We should merge both approaches eventually, but 
that's not planned right now.

> Facilitate writing of integration tests for multiple instances
> --
>
> Key: SLING-3478
> URL: https://issues.apache.org/jira/browse/SLING-3478
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Marius Petria
> Attachments: SLING-3478.patch
>
>
> Facilitate writing of integration tests for multiple instances. This is 
> needed for better testing features like replication or topology discovery.
> Create a base class for such tests and a way to configure multiple instances 
> and also sample integration test.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Comment Edited] (SLING-3479) Upgrade Oak Repository Server bundle to Oak 0.20

[Artyom Stetsenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947944#comment-13947944
 ] 

Artyom Stetsenko edited comment on SLING-3479 at 3/26/14 2:14 PM:
--

Added a patch upgrading to Oak 0.18; [OAK-1581] fix must be applied manually to 
a 0.18 release.


was (Author: artyomstetsenko):
Added a patch upgrading to Oak 0.18; [OAK-1581] must be applied manually to an 
0.18 release.

> Upgrade Oak Repository Server bundle to Oak 0.20
> 
>
> Key: SLING-3479
> URL: https://issues.apache.org/jira/browse/SLING-3479
> Project: Sling
>  Issue Type: Improvement
>  Components: Oak
>Reporter: Artyom Stetsenko
>Priority: Minor
> Attachments: SLING-3479-Oak018.patch
>
>
> Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
> upgrade it to the latest Oak version*.
> * Oak 0.20 is being targeted instead of the currently latest release 0.19 
> because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak 
> to fail



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3479) Upgrade Oak Repository Server bundle to Oak 0.20

[Artyom Stetsenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artyom Stetsenko updated SLING-3479:


Attachment: SLING-3479-Oak018.patch

Added a patch upgrading to Oak 0.18; [OAK-1581] must be applied manually to an 
0.18 release.

> Upgrade Oak Repository Server bundle to Oak 0.20
> 
>
> Key: SLING-3479
> URL: https://issues.apache.org/jira/browse/SLING-3479
> Project: Sling
>  Issue Type: Improvement
>  Components: Oak
>Reporter: Artyom Stetsenko
>Priority: Minor
> Attachments: SLING-3479-Oak018.patch
>
>
> Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
> upgrade it to the latest Oak version*.
> * Oak 0.20 is being targeted instead of the currently latest release 0.19 
> because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak 
> to fail



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3479) Upgrade Oak Repository Server bundle to Oak 0.20

[Artyom Stetsenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artyom Stetsenko updated SLING-3479:


Description: 
Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
upgrade it to the latest Oak version*.

* Oak 0.20 is being targeted instead of the currently latest release 0.19 
because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak to 
fail

  was:
Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
upgrade it to the latest Oak version(*y).

(*y) Oak 0.20 is being targeted instead of the currently latest release 0.19 
because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak to 
fail


> Upgrade Oak Repository Server bundle to Oak 0.20
> 
>
> Key: SLING-3479
> URL: https://issues.apache.org/jira/browse/SLING-3479
> Project: Sling
>  Issue Type: Improvement
>  Components: Oak
>Reporter: Artyom Stetsenko
>Priority: Minor
>
> Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
> upgrade it to the latest Oak version*.
> * Oak 0.20 is being targeted instead of the currently latest release 0.19 
> because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak 
> to fail



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3479) Upgrade Oak Repository Server bundle to Oak 0.20

[Artyom Stetsenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artyom Stetsenko updated SLING-3479:


Description: 
Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
upgrade it to the latest Oak version(*y).

(*y) Oak 0.20 is being targeted instead of the currently latest release 0.19 
because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak to 
fail

  was:
Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
upgrade it to the latest Oak version*.

* Oak 0.20 is being targeted instead of the currently latest release 0.19 
because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak to 
fail


> Upgrade Oak Repository Server bundle to Oak 0.20
> 
>
> Key: SLING-3479
> URL: https://issues.apache.org/jira/browse/SLING-3479
> Project: Sling
>  Issue Type: Improvement
>  Components: Oak
>Reporter: Artyom Stetsenko
>Priority: Minor
>
> Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
> upgrade it to the latest Oak version(*y).
> (*y) Oak 0.20 is being targeted instead of the currently latest release 0.19 
> because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak 
> to fail



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3479) Upgrade Oak Repository Server bundle to Oak 0.20

[Artyom Stetsenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artyom Stetsenko updated SLING-3479:


Description: 
Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
upgrade it to the latest Oak version(*).

(*) Oak 0.20 is being targeted instead of the currently latest release 0.19 
because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak to 
fail

  was:
Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
upgrade it to the latest Oak version(*).

(*) Oak 0.20 is being targeted instead of the currently latest release 0.19 
because of [OAK-1493], which causes a test at bundles/jcr/it-jackrabbit-oak to 
fail


> Upgrade Oak Repository Server bundle to Oak 0.20
> 
>
> Key: SLING-3479
> URL: https://issues.apache.org/jira/browse/SLING-3479
> Project: Sling
>  Issue Type: Improvement
>  Components: Oak
>Reporter: Artyom Stetsenko
>Priority: Minor
>
> Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
> upgrade it to the latest Oak version(*).
> (*) Oak 0.20 is being targeted instead of the currently latest release 0.19 
> because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak 
> to fail



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3479) Upgrade Oak Repository Server bundle to Oak 0.20

[Artyom Stetsenko (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artyom Stetsenko updated SLING-3479:


Description: 
Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
upgrade it to the latest Oak version*.

* Oak 0.20 is being targeted instead of the currently latest release 0.19 
because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak to 
fail

  was:
Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
upgrade it to the latest Oak version(*).

(*) Oak 0.20 is being targeted instead of the currently latest release 0.19 
because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak to 
fail


> Upgrade Oak Repository Server bundle to Oak 0.20
> 
>
> Key: SLING-3479
> URL: https://issues.apache.org/jira/browse/SLING-3479
> Project: Sling
>  Issue Type: Improvement
>  Components: Oak
>Reporter: Artyom Stetsenko
>Priority: Minor
>
> Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
> upgrade it to the latest Oak version*.
> * Oak 0.20 is being targeted instead of the currently latest release 0.19 
> because of [OAK-1581], which causes a test at bundles/jcr/it-jackrabbit-oak 
> to fail



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Created] (SLING-3479) Upgrade Oak Repository Server bundle to Oak 0.20

[Artyom Stetsenko (JIRA)]

Artyom Stetsenko created SLING-3479:
---

 Summary: Upgrade Oak Repository Server bundle to Oak 0.20
 Key: SLING-3479
 URL: https://issues.apache.org/jira/browse/SLING-3479
 Project: Sling
  Issue Type: Improvement
  Components: Oak
Reporter: Artyom Stetsenko
Priority: Minor


Oak Repository Server bundle currently runs on Oak 0.10. It would be nice to 
upgrade it to the latest Oak version(*).

(*) Oak 0.20 is being targeted instead of the currently latest release 0.19 
because of [OAK-1493], which causes a test at bundles/jcr/it-jackrabbit-oak to 
fail



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (SLING-3478) Facilitate writing of integration tests for multiple instances

[Marius Petria (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947786#comment-13947786
 ] 

Marius Petria commented on SLING-3478:
--

Hi Bertrand,

It seems that there are (at least) two bundles providing test utilities for 
integration tests. I was using [1] for my tests and did not even know about [2] 
(the one that you are referring to).
Which is the difference between the two? At first look it seems that [1] allows 
more customization, in particular installing additional bundles while [2] seems 
appropriate for testing OOTB  functionality.

Do you suggest to keep using [1] but switch from using base classes to utility 
classes in the same way you are using it for [2]?

[1] 
https://svn.apache.org/repos/asf/sling/trunk/testing/tools/src/main/java/org/apache/sling/testing/tools/sling/SlingTestBase.java
[2] 
https://svn.apache.org/repos/asf/sling/trunk/bundles/commons/testing/src/main/java/org/apache/sling/commons/testing/integration/HttpTestBase.java


> Facilitate writing of integration tests for multiple instances
> --
>
> Key: SLING-3478
> URL: https://issues.apache.org/jira/browse/SLING-3478
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Marius Petria
> Attachments: SLING-3478.patch
>
>
> Facilitate writing of integration tests for multiple instances. This is 
> needed for better testing features like replication or topology discovery.
> Create a base class for such tests and a way to configure multiple instances 
> and also sample integration test.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (SLING-3478) Facilitate writing of integration tests for multiple instances

[Bertrand Delacretaz (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947720#comment-13947720
 ] 

Bertrand Delacretaz commented on SLING-3478:


Note that in the meantime I've been moving to utility classes instead of those 
base classes, which create a lot of coupling in the tests classes that can 
usually be avoided. See for example JspForwardTest [1] which uses the recently 
added HttpTest utility class and does not need to inherit from anything.

If you could take the opportunity to refactor this into utility classes that 
might be good. Happy to discuss the design on list if needed.

[1] 
https://svn.apache.org/repos/asf/sling/trunk/launchpad/integration-tests/src/main/java/org/apache/sling/launchpad/webapp/integrationtest/JspForwardTest.java

> Facilitate writing of integration tests for multiple instances
> --
>
> Key: SLING-3478
> URL: https://issues.apache.org/jira/browse/SLING-3478
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Marius Petria
> Attachments: SLING-3478.patch
>
>
> Facilitate writing of integration tests for multiple instances. This is 
> needed for better testing features like replication or topology discovery.
> Create a base class for such tests and a way to configure multiple instances 
> and also sample integration test.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Comment Edited] (SLING-3478) Facilitate writing of integration tests for multiple instances

[Marius Petria (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947709#comment-13947709
 ] 

Marius Petria edited comment on SLING-3478 at 3/26/14 9:24 AM:
---

I have refactored the original SlingTestBase to reuse most of the code and 
settings for MultipleSlingTestBase. Also, I have added the 
MultipleOsgiConsoleTest to show how this can be used.

A test that needs multiple instance should extend MultipleSlingTestBase and 
declare the names of the instances that it needs to use. The instance names are 
used to retrieve configuration properties from system properties (they are used 
as a prefixes).

{code}

   ...
   ${http.port}
   
${instance1.http.port}
   
${instance2.http.port}
   ...

{code}

{code}
public class MultipleOsgiConsoleTest extends MultipleSlingTestBase {

public MultipleOsgiConsoleTest() {
super("instance1", "instance2");
}

@Test
public void testSomeConsolePaths() throws Exception {
for (SlingInstance slingInstance : getInstances()) {
testSomeConsolePaths(slingInstance);
}
}
{code}


was (Author: mpetria):
I have refactored the original SlingTestBase to reuse most of the code and 
settings for MultipleSlingTestBase. Also, I have added the 
MultipleOsgiConsoleTest to show how this can be used.

A test that needs multiple instance should extend MultipleSlingTestBase and 
declare the names of the instances that it needs to use. The instance names are 
used to retrieve configuration properties from system properties (they are used 
as a prefixes).

{code}
${instance1.http.port}
${instance2.http.port}
{code}

{code}
public class MultipleOsgiConsoleTest extends MultipleSlingTestBase {

public MultipleOsgiConsoleTest() {
super("instance1", "instance2");
}

@Test
public void testSomeConsolePaths() throws Exception {
for (SlingInstance slingInstance : getInstances()) {
testSomeConsolePaths(slingInstance);
}
}
{code}

> Facilitate writing of integration tests for multiple instances
> --
>
> Key: SLING-3478
> URL: https://issues.apache.org/jira/browse/SLING-3478
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Marius Petria
> Attachments: SLING-3478.patch
>
>
> Facilitate writing of integration tests for multiple instances. This is 
> needed for better testing features like replication or topology discovery.
> Create a base class for such tests and a way to configure multiple instances 
> and also sample integration test.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Updated] (SLING-3478) Facilitate writing of integration tests for multiple instances

[Marius Petria (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Marius Petria updated SLING-3478:
-

Attachment: SLING-3478.patch

I have refactored the original SlingTestBase to reuse most of the code and 
settings for MultipleSlingTestBase. Also, I have added the 
MultipleOsgiConsoleTest to show how this can be used.

A test that needs multiple instance should extend MultipleSlingTestBase and 
declare the names of the instances that it needs to use. The instance names are 
used to retrieve configuration properties from system properties (they are used 
as a prefixes).

{code}
${instance1.http.port}
${instance2.http.port}
{code}

{code}
public class MultipleOsgiConsoleTest extends MultipleSlingTestBase {

public MultipleOsgiConsoleTest() {
super("instance1", "instance2");
}

@Test
public void testSomeConsolePaths() throws Exception {
for (SlingInstance slingInstance : getInstances()) {
testSomeConsolePaths(slingInstance);
}
}
{code}

> Facilitate writing of integration tests for multiple instances
> --
>
> Key: SLING-3478
> URL: https://issues.apache.org/jira/browse/SLING-3478
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Marius Petria
> Attachments: SLING-3478.patch
>
>
> Facilitate writing of integration tests for multiple instances. This is 
> needed for better testing features like replication or topology discovery.
> Create a base class for such tests and a way to configure multiple instances 
> and also sample integration test.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Created] (SLING-3478) Facilitate writing of integration tests for multiple instances

[Marius Petria (JIRA)]

Marius Petria created SLING-3478:


 Summary: Facilitate writing of integration tests for multiple 
instances
 Key: SLING-3478
 URL: https://issues.apache.org/jira/browse/SLING-3478
 Project: Sling
  Issue Type: Improvement
  Components: Testing
Reporter: Marius Petria


Facilitate writing of integration tests for multiple instances. This is needed 
for better testing features like replication or topology discovery.

Create a base class for such tests and a way to configure multiple instances 
and also sample integration test.





--
This message was sent by Atlassian JIRA
(v6.2#6252)