[jira] [Commented] (SLING-4443) Whitespace removal for Sightly HTML output
[ https://issues.apache.org/jira/browse/SLING-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328803#comment-14328803 ] Konrad Windszus commented on SLING-4443: No, I didn't yet open a JIRA issue for that. Thanks for doing it. I just wanted to reference the discussion because it contains further hints on how this could be implemented. Whitespace removal for Sightly HTML output -- Key: SLING-4443 URL: https://issues.apache.org/jira/browse/SLING-4443 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Dan Chapman Priority: Minor Can there be a way to remove whitespace from Sightly components HTML output, that is created when elements are hidden e.g. span data-sly-test=... Previously in JSPs we could use - trimDirectiveWhitespaces=true -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4442) Invalid parametrization of Sightly statements should lead to exceptions instead of errors
[ https://issues.apache.org/jira/browse/SLING-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-4442: --- Component/s: Scripting Invalid parametrization of Sightly statements should lead to exceptions instead of errors - Key: SLING-4442 URL: https://issues.apache.org/jira/browse/SLING-4442 Project: Sling Issue Type: Improvement Components: Scripting Affects Versions: Scripting Sightly Engine 1.0.0 Reporter: Konrad Windszus Currently invalid parametrization of Sightly statements only leads to errors/warnings in the log. Rather programmatic errors should lead to exceptions so that errors are detected earlier during development and to prevent invalid HTML output due to failures within a Sightly script (a HTML page with a 500 status is the right thing to do IMHO). This affects e.g. # data-sly-include with invalid/empty path # data-sly-resource with empty path # data-sly-call with invalid name (this does not even provide logging currently) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Build failed in Jenkins: sling-trunk-1.6 #3094
See https://builds.apache.org/job/sling-trunk-1.6/3094/changes Changes: [mpetria] SLING-4312: Register an osgi service for each available service user -- [...truncated 10729 lines...] [INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [18.797s] [INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [6.633s] [INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support SUCCESS [5.867s] [INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [4.917s] [INFO] Apache Sling Service User Mapper .. FAILURE [1.792s] [INFO] Apache Sling JCR Resource Resolver SKIPPED [INFO] Apache Sling Testing OSGi Mock SKIPPED [INFO] Apache Sling Testing JCR Mock . SKIPPED [INFO] Apache Sling Testing Resource Resolver Mock ... SKIPPED [INFO] Apache Sling Testing Sling Mock ... SKIPPED [INFO] Apache Sling Testing Sling Mock Jackrabbit-based Resource Resolver SKIPPED [INFO] Apache Sling Versioning Integration Tests . SKIPPED [INFO] Apache Sling JCR Repository Registration .. SKIPPED [INFO] Apache Sling Simple WebDAV Access to repositories . SKIPPED [INFO] Apache Sling DavEx Access to repositories . SKIPPED [INFO] Apache Sling JCR WebConsole Bundle SKIPPED [INFO] Apache Sling Oak Repository Server SKIPPED [INFO] Apache Sling SlingRepository Integration Tests SKIPPED [INFO] Apache Sling Servlet Resolver . SKIPPED [INFO] Apache Sling Default GET Servlets . SKIPPED [INFO] Apache Sling Default POST Servlets SKIPPED [INFO] Apache Sling Compat Servlets .. SKIPPED [INFO] Apache Sling Scripting Implementation API . SKIPPED [INFO] Apache Sling Scripting Core implementation SKIPPED [INFO] Apache Sling Scripting JavaScript Support . SKIPPED [INFO] Apache Sling Scripting JSP Support SKIPPED [INFO] Apache Sling JSP Tag Library .. SKIPPED [INFO] Apache Sling JSP Standard Tag Library . SKIPPED [INFO] Apache Sling Adapter Manager Implementation ... SKIPPED [INFO] Apache Sling Bundle Resource Provider . SKIPPED [INFO] Apache Sling Distributed Event Admin .. SKIPPED [INFO] Apache Sling Discovery API SKIPPED [INFO] Apache Sling Resource-Based Discovery Service . SKIPPED [INFO] Apache Sling Discovery Support Bundle . SKIPPED [INFO] Apache Sling Discovery Standalone Implementation .. SKIPPED [INFO] Apache Sling Event Support SKIPPED [INFO] Apache Sling Feature Flags SKIPPED [INFO] Apache Sling Filesystem Resource Provider . SKIPPED [INFO] Apache Sling javax.activation bundle .. SKIPPED [INFO] Apache Sling Settings . SKIPPED [INFO] Apache Sling Web Console Branding . SKIPPED [INFO] Apache Sling Web Console Security Provider SKIPPED [INFO] Apache Sling Explorer . SKIPPED [INFO] Apache Sling Health Check Core SKIPPED [INFO] Apache Sling Health Check Annotations . SKIPPED [INFO] Apache Sling Health Check Samples . SKIPPED [INFO] Apache Sling Health Check Support Components .. SKIPPED [INFO] Apache Sling Health Check Webconsole Plugin ... SKIPPED [INFO] Apache Sling Health Check JUnit Bridge SKIPPED [INFO] Apache Sling Health Check Integration Tests ... SKIPPED [INFO] Apache Sling Health Check Reactor POM . SKIPPED [INFO] Apache Sling Resource Access Security . SKIPPED [INFO] Apache Sling Resource Access Security Integration Tests SKIPPED [INFO] Apache Sling Models API ... SKIPPED [INFO] Apache Sling Models Implementation SKIPPED [INFO] Apache Sling Test Tools ... SKIPPED [INFO] Apache Sling Models Integration Tests . SKIPPED [INFO] Apache Sling JUnit Core ... SKIPPED [INFO] Apache Sling JUnit Scriptable Tests Provider .. SKIPPED [INFO] Apache Sling JUnit Health Checks .. SKIPPED [INFO] Apache Sling JUnit Remote Tests Runners ... SKIPPED [INFO] Apache Sling JUnit Performance SKIPPED [INFO] Apache Sling Pax Exam Utilities ... SKIPPED [INFO] Apache Sling Sample Server-Side Tests . SKIPPED [INFO] Apache Sling Failing Server-Side Tests SKIPPED [INFO] Apache Sling Launchpad Application Builder SKIPPED [INFO] Apache Sling Sample Integration Tests . SKIPPED [INFO] Apache Sling Testing Modules Reactor .. SKIPPED [INFO] Apache Sling Installer SKIPPED [INFO] Apache Sling Installer WebConsole Plugin .. SKIPPED
[jira] [Updated] (SLING-4094) Handle PropertyType.UNDEFINED when updating properties
[
https://issues.apache.org/jira/browse/SLING-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu updated SLING-4094:
---
Assignee: Robert Munteanu
Handle PropertyType.UNDEFINED when updating properties
--
Key: SLING-4094
URL: https://issues.apache.org/jira/browse/SLING-4094
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Priority: Minor
Fix For: Sling Eclipse IDE 1.0.6
When synchronizing properties we check if the existing property type and the
new property type match. If they don't we remove the existing property.
However, AFAIU from the Javadocs we should not do that for
PropertyType.UNDEFINED, as
{quote}This constant can be used within a property definition (see 4.7.5
Property Definitions) to specify that the property in question may be of any
type. However, it cannot be the actual type of any property instance. {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release Apache Sling API version 2.9.0
+1 Robert On Fri, Feb 20, 2015 at 12:09 PM, Robert Munteanu romb...@apache.org wrote: On Fri, Feb 20, 2015 at 12:04 PM, Tomek Rękawek tomasz.reka...@cognifide.com wrote: Hello Robert, On Fri, Feb 20, 2015 at 10:13 AM, Robert Munteanu rob...@lmn.ro wrote: I think you should cancel this vote and start a new one, please see [1] I thought about this, but I don't think there is a need to rollback changes in the SVN, as they are not affected by the GPG key. The only place affected by my invalid key was Nexus staging, which I removed and deployed again, with the correct signature. I can repeat the whole process, but the final result (in terms of contents of the SVN and Nexus staging) will be the same as there is right now. Yup, makes sense. Thanks, Robert Also, Carsten gave his +1 :) Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[jira] [Commented] (SLING-4405) Unable to install new bundle using the jar upload mechanism
[ https://issues.apache.org/jira/browse/SLING-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328791#comment-14328791 ] Satya Deep Maheshwari commented on SLING-4405: -- Thanks! This is working fine now. Unable to install new bundle using the jar upload mechanism --- Key: SLING-4405 URL: https://issues.apache.org/jira/browse/SLING-4405 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Tooling Support Install 1.0.0 Reporter: Satya Deep Maheshwari Assignee: Robert Munteanu Fix For: Tooling Support Install 1.0.2 I am experimenting with sling IDE tooling. I am facing a problem wherein I am unable to deploy the bundle for the very first time using it. Once I have uploaded the bundle once using some other means, I am subsequently able to upload successfully using the ide tooling. On debugging this a bit, I see that the on installing the bundle for the very first time, the felix framework attempts to search for the bundle in a non-existent directory which fails with a FileNotFound exception. I compared this with the bundle install done from the felix web console. It looks like IDE tooling uses the InstallServlet mechanism while the web console does not. The InstallServlet tries to determine the location of this bundle if it already exists and if it does not, it sets it to null which later causes the above mentioned problem. Below is the exception trace: 11.02.2015 14:59:49.172 *ERROR* [qtp1941320881-42] ERROR: Error getting location from bundle archive. (java.io.FileNotFoundException: /home/satyadeep/code/sling/sling/felix/bundle181/bundle.location (No such file or directory)) java.io.FileNotFoundException: /home/satyadeep/code/sling/sling/felix/bundle181/bundle.location (No such file or directory) at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.init(FileInputStream.java:146) at org.apache.felix.framework.util.SecureAction.getFileInputStream(SecureAction.java:453) at org.apache.felix.framework.cache.BundleArchive.readLocation(BundleArchive.java:1107) at org.apache.felix.framework.cache.BundleArchive.getLocation(BundleArchive.java:256) at org.apache.felix.framework.BundleImpl._getLocation(BundleImpl.java:621) at org.apache.felix.framework.BundleProtectionDomain$RevisionAsJarURL.create(BundleProtectionDomain.java:335) at org.apache.felix.framework.BundleProtectionDomain$RevisionAsJarURL.access$200(BundleProtectionDomain.java:234) at org.apache.felix.framework.BundleProtectionDomain.init(BundleProtectionDomain.java:385) at org.apache.felix.framework.Felix.setBundleProtectionDomain(Felix.java:938) at org.apache.felix.framework.BundleImpl.addRevision(BundleImpl.java:1219) at org.apache.felix.framework.BundleImpl.init(BundleImpl.java:114) at org.apache.felix.framework.Felix.installBundle(Felix.java:2976) at org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:169) at org.apache.sling.tooling.support.install.impl.InstallServlet.installOrUpdateBundle(InstallServlet.java:242) at org.apache.sling.tooling.support.install.impl.InstallServlet.installBasedOnUploadedJar(InstallServlet.java:149) at org.apache.sling.tooling.support.install.impl.InstallServlet.doPost(InstallServlet.java:101) at javax.servlet.http.HttpServlet.service(HttpServlet.java:641) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at org.apache.felix.http.base.internal.handler.ServletHandler.doHandle(ServletHandler.java:339) at org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:300) at org.apache.felix.http.base.internal.dispatch.ServletPipeline.handle(ServletPipeline.java:93) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:50) at org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:31) at org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47) at org.apache.sling.launchpad.testservices.filters.HttpServiceExtFilter.doFilter(HttpServiceExtFilter.java:27) at org.apache.felix.http.base.internal.handler.FilterHandler.doHandle(FilterHandler.java:108) at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:80) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:46) at org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:31) at
[jira] [Commented] (SLING-4443) Whitespace removal for Sightly HTML output
[ https://issues.apache.org/jira/browse/SLING-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328790#comment-14328790 ] Dan Chapman commented on SLING-4443: Nice one. Does that mean I should close this issue? Whitespace removal for Sightly HTML output -- Key: SLING-4443 URL: https://issues.apache.org/jira/browse/SLING-4443 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Dan Chapman Priority: Minor Can there be a way to remove whitespace from Sightly components HTML output, that is created when elements are hidden e.g. span data-sly-test=... Previously in JSPs we could use - trimDirectiveWhitespaces=true -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (SLING-3854) Add configuration option to restrict service user mapper to system users
[
https://issues.apache.org/jira/browse/SLING-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328780#comment-14328780
]
Marius Petria edited comment on SLING-3854 at 2/20/15 10:30 AM:
Hi [~asanso], is there any reason for which the validation is done at mapping
time not at registration time? That could potentially introduce some
performance problems especially if the validator is hitting the repository.
EDIT: Also, regarding switching to a service user in JcrSystemUserValidator
this will not be very easy probably as it looks like it will cause an infinite
loop.
was (Author: mpetria):
Hi [~asanso], is there any reason for which the validation is done at mapping
time not at registration time? That could potentially introduce some
performance problems especially if the validator is hitting the repository.
Add configuration option to restrict service user mapper to system users
Key: SLING-3854
URL: https://issues.apache.org/jira/browse/SLING-3854
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: angela
Assignee: Antonio Sanso
Fix For: Service User Mapper 1.1.0, JCR Resource 2.5.0
Attachments: SLING-3854-patch2.txt, SLING-3854.patch
JCR-3802 introduces the concept of system users that distinct from regular
user accounts and never have a password set. the API extensions include to
following ability to discover if a given User is actually a system user:
{{User.isSystemUser}}.
It would be good if the service user mapping had a configuration option that
would restrict the mapping to dedicated service users i.e. to users which are
defined to be system users in case sling is running on a JCR repository that
implements jackrabbit API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4377) Add JSR305 nullness annotations to Sling API
[
https://issues.apache.org/jira/browse/SLING-4377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328799#comment-14328799
]
Konrad Windszus commented on SLING-4377:
I also added some documentation now in
http://sling.apache.org/documentation/development/jsr-305.html.
Add JSR305 nullness annotations to Sling API
Key: SLING-4377
URL: https://issues.apache.org/jira/browse/SLING-4377
Project: Sling
Issue Type: Improvement
Components: API
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Fix For: API 2.9.0
Since consumers of the Sling API always have to keep in mind whether a
null-check is necessary it would be good to add JSR 305 annotations to the
API.
See also http://www.mail-archive.com/dev@sling.apache.org/msg42199.html.
At least Eclipse as well as Findbugs are supporting those and Oak Solr is
using those already (https://issues.apache.org/jira/browse/OAK-2303).
Only the following 2 annotations should be used:
# {{@Nonnull}}, for return values which are not supposed to be {{null}} or
parameters which must not be {{null}}.
# {{@CheckForNull}}, for return values wich may be null {{null}}.
Those are the only ones being supported by both Eclipse and Findbugs (compare
with http://sourceforge.net/p/findbugs/bugs/1355/)
{{@Nullable}} is basically ignored by Findbugs
(http://findbugs.sourceforge.net/manual/annotations.html) and should
therefore not be used. The package annotation for the default handling should
also not be used (because either {{@Nullable}} or {{@CheckForNull}} is
ignored by Eclipse then.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4440) Don't remove autoCreated properties
[
https://issues.apache.org/jira/browse/SLING-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328817#comment-14328817
]
Robert Munteanu commented on SLING-4440:
* https://svn.apache.org/viewvc?view=revisionrevision=r1661089 -implemented fix
* https://svn.apache.org/viewvc?view=revisionrevision=r1661092 - simplified
test setup
Don't remove autoCreated properties
---
Key: SLING-4440
URL: https://issues.apache.org/jira/browse/SLING-4440
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.6
The content sync tries to remove auto-created properties when they no longer
exist:
{noformat}
[Worker-1] Thu Feb 19 17:49:35 EET 2015 org.apache.sling.ide.impl-vlt :
Removed property jcr:created from node at
/content/test-root/mapping/jcr:content/par/folder
[Worker-1] Thu Feb 19 17:49:35 EET 2015 org.apache.sling.ide.impl-vlt :
Removed property jcr:createdBy from node at
/content/test-root/mapping/jcr:content/par/folder
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4440) Don't remove autoCreated properties
[
https://issues.apache.org/jira/browse/SLING-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-4440.
Resolution: Fixed
Don't remove autoCreated properties
---
Key: SLING-4440
URL: https://issues.apache.org/jira/browse/SLING-4440
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.6
The content sync tries to remove auto-created properties when they no longer
exist:
{noformat}
[Worker-1] Thu Feb 19 17:49:35 EET 2015 org.apache.sling.ide.impl-vlt :
Removed property jcr:created from node at
/content/test-root/mapping/jcr:content/par/folder
[Worker-1] Thu Feb 19 17:49:35 EET 2015 org.apache.sling.ide.impl-vlt :
Removed property jcr:createdBy from node at
/content/test-root/mapping/jcr:content/par/folder
{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.8 #773
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Commented] (SLING-3854) Add configuration option to restrict service user mapper to system users
[
https://issues.apache.org/jira/browse/SLING-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328821#comment-14328821
]
Antonio Sanso commented on SLING-3854:
--
[~mpetria]
bq. is there any reason for which the validation is done at mapping time not at
registration time?
as you can see from my comment above I had the same concern. Point is that in
some situation (e.g package installation) you can have some time racing
condition where the user is installed after the bundle and this might
invalidate the logic of checking at registration time (see also comment
above from [~fmeschbe]. The JcrSystemUserValidator has a built in cache though
bq. Also, regarding switching to a service user in JcrSystemUserValidator this
will not be very easy probably as it looks like it will cause an infinite loop.
What do you mean, might be just me but I fail to see an infinite loop
Add configuration option to restrict service user mapper to system users
Key: SLING-3854
URL: https://issues.apache.org/jira/browse/SLING-3854
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: angela
Assignee: Antonio Sanso
Fix For: Service User Mapper 1.1.0, JCR Resource 2.5.0
Attachments: SLING-3854-patch2.txt, SLING-3854.patch
JCR-3802 introduces the concept of system users that distinct from regular
user accounts and never have a password set. the API extensions include to
following ability to discover if a given User is actually a system user:
{{User.isSystemUser}}.
It would be good if the service user mapping had a configuration option that
would restrict the mapping to dedicated service users i.e. to users which are
defined to be system users in case sling is running on a JCR repository that
implements jackrabbit API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-3854) Add configuration option to restrict service user mapper to system users
[
https://issues.apache.org/jira/browse/SLING-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328831#comment-14328831
]
Marius Petria commented on SLING-3854:
--
Sorry, I did not see the discussion about the validation time, however it looks
that the last comment on that matter is: it is probably stable enough to
validate at configuration time and not on each access. Anyway, I see that was
discussed thoroughly so I have no more comments on that.
bq. What do you mean, might be just me but I fail to see an infinite loop
Assume in JcrSystemUserValidator you call loginService(validatorService), that
will call getServiceUserID which will go again into validators. Maybe I am just
seeing wrong as I did not actually test that :).
Add configuration option to restrict service user mapper to system users
Key: SLING-3854
URL: https://issues.apache.org/jira/browse/SLING-3854
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: angela
Assignee: Antonio Sanso
Fix For: Service User Mapper 1.1.0, JCR Resource 2.5.0
Attachments: SLING-3854-patch2.txt, SLING-3854.patch
JCR-3802 introduces the concept of system users that distinct from regular
user accounts and never have a password set. the API extensions include to
following ability to discover if a given User is actually a system user:
{{User.isSystemUser}}.
It would be good if the service user mapping had a configuration option that
would restrict the mapping to dedicated service users i.e. to users which are
defined to be system users in case sling is running on a JCR repository that
implements jackrabbit API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-3854) Add configuration option to restrict service user mapper to system users
[
https://issues.apache.org/jira/browse/SLING-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328839#comment-14328839
]
Antonio Sanso commented on SLING-3854:
--
bq. Assume in JcrSystemUserValidator you call loginService(validatorService),
that will call getServiceUserID which will go again into validators.
fair enough. Sorry I did not understand you were talking about the {{//TODO}}.
All I can say is when we tackle the TODO we really need to think about avoid
the situation you describe...
Add configuration option to restrict service user mapper to system users
Key: SLING-3854
URL: https://issues.apache.org/jira/browse/SLING-3854
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: angela
Assignee: Antonio Sanso
Fix For: Service User Mapper 1.1.0, JCR Resource 2.5.0
Attachments: SLING-3854-patch2.txt, SLING-3854.patch
JCR-3802 introduces the concept of system users that distinct from regular
user accounts and never have a password set. the API extensions include to
following ability to discover if a given User is actually a system user:
{{User.isSystemUser}}.
It would be good if the service user mapping had a configuration option that
would restrict the mapping to dedicated service users i.e. to users which are
defined to be system users in case sling is running on a JCR repository that
implements jackrabbit API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4094) Handle PropertyType.UNDEFINED when updating properties
[
https://issues.apache.org/jira/browse/SLING-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328844#comment-14328844
]
Robert Munteanu commented on SLING-4094:
Fixed in https://svn.apache.org/viewvc?view=revisionrevision=r1661098
Handle PropertyType.UNDEFINED when updating properties
--
Key: SLING-4094
URL: https://issues.apache.org/jira/browse/SLING-4094
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Priority: Minor
Fix For: Sling Eclipse IDE 1.0.6
When synchronizing properties we check if the existing property type and the
new property type match. If they don't we remove the existing property.
However, AFAIU from the Javadocs we should not do that for
PropertyType.UNDEFINED, as
{quote}This constant can be used within a property definition (see 4.7.5
Property Definitions) to specify that the property in question may be of any
type. However, it cannot be the actual type of any property instance. {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4444) Include Tooling Support Install Bundle 1.0.2
Robert Munteanu created SLING-: -- Summary: Include Tooling Support Install Bundle 1.0.2 Key: SLING- URL: https://issues.apache.org/jira/browse/SLING- Project: Sling Issue Type: Task Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 Once the release vote is complete, upgrade to the latest version of the bundle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4405) Unable to install new bundle using the jar upload mechanism
[ https://issues.apache.org/jira/browse/SLING-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328796#comment-14328796 ] Robert Munteanu commented on SLING-4405: Good to hear. This should be rolled in the next IDE tooling release so once 1.0.6 is out you won't need to install the bundle manually Unable to install new bundle using the jar upload mechanism --- Key: SLING-4405 URL: https://issues.apache.org/jira/browse/SLING-4405 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Tooling Support Install 1.0.0 Reporter: Satya Deep Maheshwari Assignee: Robert Munteanu Fix For: Tooling Support Install 1.0.2 I am experimenting with sling IDE tooling. I am facing a problem wherein I am unable to deploy the bundle for the very first time using it. Once I have uploaded the bundle once using some other means, I am subsequently able to upload successfully using the ide tooling. On debugging this a bit, I see that the on installing the bundle for the very first time, the felix framework attempts to search for the bundle in a non-existent directory which fails with a FileNotFound exception. I compared this with the bundle install done from the felix web console. It looks like IDE tooling uses the InstallServlet mechanism while the web console does not. The InstallServlet tries to determine the location of this bundle if it already exists and if it does not, it sets it to null which later causes the above mentioned problem. Below is the exception trace: 11.02.2015 14:59:49.172 *ERROR* [qtp1941320881-42] ERROR: Error getting location from bundle archive. (java.io.FileNotFoundException: /home/satyadeep/code/sling/sling/felix/bundle181/bundle.location (No such file or directory)) java.io.FileNotFoundException: /home/satyadeep/code/sling/sling/felix/bundle181/bundle.location (No such file or directory) at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.init(FileInputStream.java:146) at org.apache.felix.framework.util.SecureAction.getFileInputStream(SecureAction.java:453) at org.apache.felix.framework.cache.BundleArchive.readLocation(BundleArchive.java:1107) at org.apache.felix.framework.cache.BundleArchive.getLocation(BundleArchive.java:256) at org.apache.felix.framework.BundleImpl._getLocation(BundleImpl.java:621) at org.apache.felix.framework.BundleProtectionDomain$RevisionAsJarURL.create(BundleProtectionDomain.java:335) at org.apache.felix.framework.BundleProtectionDomain$RevisionAsJarURL.access$200(BundleProtectionDomain.java:234) at org.apache.felix.framework.BundleProtectionDomain.init(BundleProtectionDomain.java:385) at org.apache.felix.framework.Felix.setBundleProtectionDomain(Felix.java:938) at org.apache.felix.framework.BundleImpl.addRevision(BundleImpl.java:1219) at org.apache.felix.framework.BundleImpl.init(BundleImpl.java:114) at org.apache.felix.framework.Felix.installBundle(Felix.java:2976) at org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:169) at org.apache.sling.tooling.support.install.impl.InstallServlet.installOrUpdateBundle(InstallServlet.java:242) at org.apache.sling.tooling.support.install.impl.InstallServlet.installBasedOnUploadedJar(InstallServlet.java:149) at org.apache.sling.tooling.support.install.impl.InstallServlet.doPost(InstallServlet.java:101) at javax.servlet.http.HttpServlet.service(HttpServlet.java:641) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at org.apache.felix.http.base.internal.handler.ServletHandler.doHandle(ServletHandler.java:339) at org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:300) at org.apache.felix.http.base.internal.dispatch.ServletPipeline.handle(ServletPipeline.java:93) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:50) at org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:31) at org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47) at org.apache.sling.launchpad.testservices.filters.HttpServiceExtFilter.doFilter(HttpServiceExtFilter.java:27) at org.apache.felix.http.base.internal.handler.FilterHandler.doHandle(FilterHandler.java:108) at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:80) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:46) at
[jira] [Commented] (SLING-4405) Unable to install new bundle using the jar upload mechanism
[ https://issues.apache.org/jira/browse/SLING-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328797#comment-14328797 ] Robert Munteanu commented on SLING-4405: Good to hear. This should be rolled in the next IDE tooling release so once 1.0.6 is out you won't need to install the bundle manually Unable to install new bundle using the jar upload mechanism --- Key: SLING-4405 URL: https://issues.apache.org/jira/browse/SLING-4405 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Tooling Support Install 1.0.0 Reporter: Satya Deep Maheshwari Assignee: Robert Munteanu Fix For: Tooling Support Install 1.0.2 I am experimenting with sling IDE tooling. I am facing a problem wherein I am unable to deploy the bundle for the very first time using it. Once I have uploaded the bundle once using some other means, I am subsequently able to upload successfully using the ide tooling. On debugging this a bit, I see that the on installing the bundle for the very first time, the felix framework attempts to search for the bundle in a non-existent directory which fails with a FileNotFound exception. I compared this with the bundle install done from the felix web console. It looks like IDE tooling uses the InstallServlet mechanism while the web console does not. The InstallServlet tries to determine the location of this bundle if it already exists and if it does not, it sets it to null which later causes the above mentioned problem. Below is the exception trace: 11.02.2015 14:59:49.172 *ERROR* [qtp1941320881-42] ERROR: Error getting location from bundle archive. (java.io.FileNotFoundException: /home/satyadeep/code/sling/sling/felix/bundle181/bundle.location (No such file or directory)) java.io.FileNotFoundException: /home/satyadeep/code/sling/sling/felix/bundle181/bundle.location (No such file or directory) at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.init(FileInputStream.java:146) at org.apache.felix.framework.util.SecureAction.getFileInputStream(SecureAction.java:453) at org.apache.felix.framework.cache.BundleArchive.readLocation(BundleArchive.java:1107) at org.apache.felix.framework.cache.BundleArchive.getLocation(BundleArchive.java:256) at org.apache.felix.framework.BundleImpl._getLocation(BundleImpl.java:621) at org.apache.felix.framework.BundleProtectionDomain$RevisionAsJarURL.create(BundleProtectionDomain.java:335) at org.apache.felix.framework.BundleProtectionDomain$RevisionAsJarURL.access$200(BundleProtectionDomain.java:234) at org.apache.felix.framework.BundleProtectionDomain.init(BundleProtectionDomain.java:385) at org.apache.felix.framework.Felix.setBundleProtectionDomain(Felix.java:938) at org.apache.felix.framework.BundleImpl.addRevision(BundleImpl.java:1219) at org.apache.felix.framework.BundleImpl.init(BundleImpl.java:114) at org.apache.felix.framework.Felix.installBundle(Felix.java:2976) at org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:169) at org.apache.sling.tooling.support.install.impl.InstallServlet.installOrUpdateBundle(InstallServlet.java:242) at org.apache.sling.tooling.support.install.impl.InstallServlet.installBasedOnUploadedJar(InstallServlet.java:149) at org.apache.sling.tooling.support.install.impl.InstallServlet.doPost(InstallServlet.java:101) at javax.servlet.http.HttpServlet.service(HttpServlet.java:641) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at org.apache.felix.http.base.internal.handler.ServletHandler.doHandle(ServletHandler.java:339) at org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:300) at org.apache.felix.http.base.internal.dispatch.ServletPipeline.handle(ServletPipeline.java:93) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:50) at org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:31) at org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47) at org.apache.sling.launchpad.testservices.filters.HttpServiceExtFilter.doFilter(HttpServiceExtFilter.java:27) at org.apache.felix.http.base.internal.handler.FilterHandler.doHandle(FilterHandler.java:108) at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:80) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:46) at
[jira] [Issue Comment Deleted] (SLING-4405) Unable to install new bundle using the jar upload mechanism
[ https://issues.apache.org/jira/browse/SLING-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-4405: --- Comment: was deleted (was: Good to hear. This should be rolled in the next IDE tooling release so once 1.0.6 is out you won't need to install the bundle manually) Unable to install new bundle using the jar upload mechanism --- Key: SLING-4405 URL: https://issues.apache.org/jira/browse/SLING-4405 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Tooling Support Install 1.0.0 Reporter: Satya Deep Maheshwari Assignee: Robert Munteanu Fix For: Tooling Support Install 1.0.2 I am experimenting with sling IDE tooling. I am facing a problem wherein I am unable to deploy the bundle for the very first time using it. Once I have uploaded the bundle once using some other means, I am subsequently able to upload successfully using the ide tooling. On debugging this a bit, I see that the on installing the bundle for the very first time, the felix framework attempts to search for the bundle in a non-existent directory which fails with a FileNotFound exception. I compared this with the bundle install done from the felix web console. It looks like IDE tooling uses the InstallServlet mechanism while the web console does not. The InstallServlet tries to determine the location of this bundle if it already exists and if it does not, it sets it to null which later causes the above mentioned problem. Below is the exception trace: 11.02.2015 14:59:49.172 *ERROR* [qtp1941320881-42] ERROR: Error getting location from bundle archive. (java.io.FileNotFoundException: /home/satyadeep/code/sling/sling/felix/bundle181/bundle.location (No such file or directory)) java.io.FileNotFoundException: /home/satyadeep/code/sling/sling/felix/bundle181/bundle.location (No such file or directory) at java.io.FileInputStream.open(Native Method) at java.io.FileInputStream.init(FileInputStream.java:146) at org.apache.felix.framework.util.SecureAction.getFileInputStream(SecureAction.java:453) at org.apache.felix.framework.cache.BundleArchive.readLocation(BundleArchive.java:1107) at org.apache.felix.framework.cache.BundleArchive.getLocation(BundleArchive.java:256) at org.apache.felix.framework.BundleImpl._getLocation(BundleImpl.java:621) at org.apache.felix.framework.BundleProtectionDomain$RevisionAsJarURL.create(BundleProtectionDomain.java:335) at org.apache.felix.framework.BundleProtectionDomain$RevisionAsJarURL.access$200(BundleProtectionDomain.java:234) at org.apache.felix.framework.BundleProtectionDomain.init(BundleProtectionDomain.java:385) at org.apache.felix.framework.Felix.setBundleProtectionDomain(Felix.java:938) at org.apache.felix.framework.BundleImpl.addRevision(BundleImpl.java:1219) at org.apache.felix.framework.BundleImpl.init(BundleImpl.java:114) at org.apache.felix.framework.Felix.installBundle(Felix.java:2976) at org.apache.felix.framework.BundleContextImpl.installBundle(BundleContextImpl.java:169) at org.apache.sling.tooling.support.install.impl.InstallServlet.installOrUpdateBundle(InstallServlet.java:242) at org.apache.sling.tooling.support.install.impl.InstallServlet.installBasedOnUploadedJar(InstallServlet.java:149) at org.apache.sling.tooling.support.install.impl.InstallServlet.doPost(InstallServlet.java:101) at javax.servlet.http.HttpServlet.service(HttpServlet.java:641) at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) at org.apache.felix.http.base.internal.handler.ServletHandler.doHandle(ServletHandler.java:339) at org.apache.felix.http.base.internal.handler.ServletHandler.handle(ServletHandler.java:300) at org.apache.felix.http.base.internal.dispatch.ServletPipeline.handle(ServletPipeline.java:93) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:50) at org.apache.felix.http.base.internal.dispatch.HttpFilterChain.doFilter(HttpFilterChain.java:31) at org.apache.sling.launchpad.testservices.filters.TestFilter.doFilter(TestFilter.java:47) at org.apache.sling.launchpad.testservices.filters.HttpServiceExtFilter.doFilter(HttpServiceExtFilter.java:27) at org.apache.felix.http.base.internal.handler.FilterHandler.doHandle(FilterHandler.java:108) at org.apache.felix.http.base.internal.handler.FilterHandler.handle(FilterHandler.java:80) at org.apache.felix.http.base.internal.dispatch.InvocationFilterChain.doFilter(InvocationFilterChain.java:46) at
[jira] [Commented] (SLING-4443) Whitespace removal for Sightly HTML output
[ https://issues.apache.org/jira/browse/SLING-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328805#comment-14328805 ] Feike Visser commented on SLING-4443: - [~radu.cotescu] can you validate if this ticket is tagged correctly for Sightly? Whitespace removal for Sightly HTML output -- Key: SLING-4443 URL: https://issues.apache.org/jira/browse/SLING-4443 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Dan Chapman Priority: Minor Can there be a way to remove whitespace from Sightly components HTML output, that is created when elements are hidden e.g. span data-sly-test=... Previously in JSPs we could use - trimDirectiveWhitespaces=true -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4094) Handle PropertyType.UNDEFINED when updating properties
[
https://issues.apache.org/jira/browse/SLING-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-4094.
Resolution: Fixed
Handle PropertyType.UNDEFINED when updating properties
--
Key: SLING-4094
URL: https://issues.apache.org/jira/browse/SLING-4094
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Priority: Minor
Fix For: Sling Eclipse IDE 1.0.6
When synchronizing properties we check if the existing property type and the
new property type match. If they don't we remove the existing property.
However, AFAIU from the Javadocs we should not do that for
PropertyType.UNDEFINED, as
{quote}This constant can be used within a property definition (see 4.7.5
Property Definitions) to specify that the property in question may be of any
type. However, it cannot be the actual type of any property instance. {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (SLING-4175) Sightly: Do not catch exceptions in ResourceRuntimeExtension and IncludeRuntimeExtension
[
https://issues.apache.org/jira/browse/SLING-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned SLING-4175:
--
Assignee: Konrad Windszus
Sightly: Do not catch exceptions in ResourceRuntimeExtension and
IncludeRuntimeExtension
Key: SLING-4175
URL: https://issues.apache.org/jira/browse/SLING-4175
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Labels: Sightly
Currently all exceptions being thrown during the execution of
data-sly-include and data-sly-resource are caught and only logged.
Instead those exceptions should be just wrapped (to ease debugging during
development) and also to be consistent with {{sling:call}} (SLING-3459).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4175) Sightly: Do not catch exceptions in ResourceRuntimeExtension and IncludeRuntimeExtension
[
https://issues.apache.org/jira/browse/SLING-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-4175.
Resolution: Fixed
Fix Version/s: Scripting Sightly Engine 1.0.0
I fixed this with rev 1661073.
[~santiagozky] Please have a look and then please close the Pull request, since
it should be covered with that commit.
Sightly: Do not catch exceptions in ResourceRuntimeExtension and
IncludeRuntimeExtension
Key: SLING-4175
URL: https://issues.apache.org/jira/browse/SLING-4175
Project: Sling
Issue Type: Bug
Components: Scripting
Reporter: Konrad Windszus
Assignee: Konrad Windszus
Labels: Sightly
Fix For: Scripting Sightly Engine 1.0.0
Currently all exceptions being thrown during the execution of
data-sly-include and data-sly-resource are caught and only logged.
Instead those exceptions should be just wrapped (to ease debugging during
development) and also to be consistent with {{sling:call}} (SLING-3459).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4442) Invalid parametrization of Sightly statements should lead to exceptions instead of errors
Konrad Windszus created SLING-4442: -- Summary: Invalid parametrization of Sightly statements should lead to exceptions instead of errors Key: SLING-4442 URL: https://issues.apache.org/jira/browse/SLING-4442 Project: Sling Issue Type: Improvement Affects Versions: Scripting Sightly Engine 1.0.0 Reporter: Konrad Windszus Currently invalid parametrization of Sightly statements only leads to errors/warnings in the log. Rather programmatic errors should lead to exceptions so that errors are detected earlier during development and to prevent invalid HTML output due to failures within a Sightly script (a HTML page with a 500 status is the right thing to do IMHO). This affects e.g. # data-sly-include with invalid/empty path # data-sly-resource with empty path # data-sly-call with invalid name (this does not even provide logging currently) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release Apache Sling API version 2.9.0
+1 Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
Re: [VOTE] Release Apache Sling API version 2.9.0
Hi Tomek, On Fri, Feb 20, 2015 at 11:04 AM, Tomek Rękawek tomasz.reka...@cognifide.com wrote: Sorry for the duplicate, the previous staging repository was improperly signed (thanks Antonio for pointing this out). Please find the fixed repository details below: I think you should cancel this vote and start a new one, please see [1] Robert [1]: https://sling.apache.org/documentation/development/release-management.html#canceling-the-release [VOTE] Release Apache Sling API version 2.9.0 We solved 7 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12327958 There are still some outstanding issues: https://issues.apache.org/jira/browse/SLING/component/12311944 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1192 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1192 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Tomek On Thu, Feb 19, 2015 at 8:17 PM, Tomek Rękawek tomasz.reka...@cognifide.com wrote: Hello all, On Thu, Feb 19, 2015 at 4:26 PM, Antonio Sanso asa...@adobe.com wrote: hi Tomek, it looks like you did not go through the key creation steps… It's my fault after all. I have a few keys in my GPG keyring and the release process took the first one rather than the one associated with the Apache account. I'll drop the staging repository and create it once more, properly signed this time. Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com -- Sent from my (old) computer
Re: [RT] Using the Provisioning Model
On Wed, 2015-02-18 at 15:52 +0100, Carsten Ziegeler wrote: Am 18.02.15 um 15:20 schrieb Bertrand Delacretaz: Hi, +1 on switching to the provisioning model in general. Same here. On Wed, Feb 18, 2015 at 3:02 PM, Carsten Ziegeler cziege...@apache.org wrote: ...The slingstart plugin does not provide all features, it can just build the launchpad. All other features are missing Which features exactly are missing? The launchpad plugin can start/stop a launchpad, I see other mojos wrt to Pax and Karaf; I guess that's what is missing. Starting/stopping can probably be done outside of that plugin. Yes, we're using the launchpad in our integration tests ( and presumably others are doing that too ). How/Were do you see a replacement being done? Adding Karaf support and generating a feature list out of the model should be fairly easy. Not sure about the CreatePaxRunnerBundleProvisionFileMojo. Karaf and Pax-Runner _should_ be simple, after all they're just generating a list of bundles out of the provisioning model. Robert
[jira] [Commented] (SLING-4428) Sightly: scriptComment and styleComment contexts are not doing anything
[ https://issues.apache.org/jira/browse/SLING-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328684#comment-14328684 ] ASF GitHub Bot commented on SLING-4428: --- Github user vladbailescu closed the pull request at: https://github.com/apache/sling/pull/65 Sightly: scriptComment and styleComment contexts are not doing anything --- Key: SLING-4428 URL: https://issues.apache.org/jira/browse/SLING-4428 Project: Sling Issue Type: Bug Components: Extensions Reporter: Vlad Bailescu Assignee: Robert Munteanu Priority: Minor Fix For: XSS Protection API 1.0.0, Scripting Sightly Engine 1.0.0 The Sightly spec defines scriptComment context but in the current implementation it is not working as expected, as it's treated internally like a JS token. This needs to be fixed so that the comment context will work as expected. The spec will clarify usage of the scriptComment context (it will only be used for block comments, ie: /*...*/) and will also add styleComment (which will behave similarly): https://github.com/Adobe-Marketing-Cloud/sightly-spec/pull/12 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] sling pull request: SLING-4428 - Sightly: scriptComment and styleC...
Github user vladbailescu closed the pull request at: https://github.com/apache/sling/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Updated] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marius Petria updated SLING-4312:
-
Attachment: SLING-4312.diff
Thanks [~cziegeler],
I will apply my changes. I also uploaded the final diff to the issue.
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Attachments: SLING-4312.diff
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4443) Whitespace removal for Sightly HTML output
Dan Chapman created SLING-4443: -- Summary: Whitespace removal for Sightly HTML output Key: SLING-4443 URL: https://issues.apache.org/jira/browse/SLING-4443 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Dan Chapman Priority: Minor Can there be a way to remove whitespace from Sightly components HTML output, that is created when elements are hidden e.g. span data-sly-test=... Previously in JSPs we could use - trimDirectiveWhitespaces=true -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4443) Whitespace removal for Sightly HTML output
[ https://issues.apache.org/jira/browse/SLING-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Chapman updated SLING-4443: --- Component/s: (was: Extensions) Scripting Whitespace removal for Sightly HTML output -- Key: SLING-4443 URL: https://issues.apache.org/jira/browse/SLING-4443 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Dan Chapman Priority: Minor Can there be a way to remove whitespace from Sightly components HTML output, that is created when elements are hidden e.g. span data-sly-test=... Previously in JSPs we could use - trimDirectiveWhitespaces=true -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is still unstable: sling-trunk-1.6 #3093
See https://builds.apache.org/job/sling-trunk-1.6/changes
Re: [VOTE] Release Apache Sling API version 2.9.0
Hello Robert, On Fri, Feb 20, 2015 at 10:13 AM, Robert Munteanu rob...@lmn.ro wrote: I think you should cancel this vote and start a new one, please see [1] I thought about this, but I don't think there is a need to rollback changes in the SVN, as they are not affected by the GPG key. The only place affected by my invalid key was Nexus staging, which I removed and deployed again, with the correct signature. I can repeat the whole process, but the final result (in terms of contents of the SVN and Nexus staging) will be the same as there is right now. Also, Carsten gave his +1 :) Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
Re: [VOTE] Release Apache Sling API version 2.9.0
On Fri, Feb 20, 2015 at 12:04 PM, Tomek Rękawek tomasz.reka...@cognifide.com wrote: Hello Robert, On Fri, Feb 20, 2015 at 10:13 AM, Robert Munteanu rob...@lmn.ro wrote: I think you should cancel this vote and start a new one, please see [1] I thought about this, but I don't think there is a need to rollback changes in the SVN, as they are not affected by the GPG key. The only place affected by my invalid key was Nexus staging, which I removed and deployed again, with the correct signature. I can repeat the whole process, but the final result (in terms of contents of the SVN and Nexus staging) will be the same as there is right now. Yup, makes sense. Thanks, Robert Also, Carsten gave his +1 :) Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328768#comment-14328768
]
Marius Petria commented on SLING-4312:
--
Committed patch in revision 1661081.
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Attachments: SLING-4312.diff
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release Apache Sling API version 2.9.0
Sorry for the duplicate, the previous staging repository was improperly signed (thanks Antonio for pointing this out). Please find the fixed repository details below: [VOTE] Release Apache Sling API version 2.9.0 We solved 7 issues in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12327958 There are still some outstanding issues: https://issues.apache.org/jira/browse/SLING/component/12311944 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1192 You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1192 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours. Regards, Tomek On Thu, Feb 19, 2015 at 8:17 PM, Tomek Rękawek tomasz.reka...@cognifide.com wrote: Hello all, On Thu, Feb 19, 2015 at 4:26 PM, Antonio Sanso asa...@adobe.com wrote: hi Tomek, it looks like you did not go through the key creation steps… It's my fault after all. I have a few keys in my GPG keyring and the release process took the first one rather than the one associated with the Apache account. I'll drop the staging repository and create it once more, properly signed this time. Regards, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
Jenkins build is still unstable: sling-trunk-1.8 #772
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Commented] (SLING-4443) Whitespace removal for Sightly HTML output
[ https://issues.apache.org/jira/browse/SLING-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328767#comment-14328767 ] Konrad Windszus commented on SLING-4443: There was a discussion on the Sling Dev Mailing list about that: http://www.mail-archive.com/dev%40sling.apache.org/msg40525.html. Whitespace removal for Sightly HTML output -- Key: SLING-4443 URL: https://issues.apache.org/jira/browse/SLING-4443 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Dan Chapman Priority: Minor Can there be a way to remove whitespace from Sightly components HTML output, that is created when elements are hidden e.g. span data-sly-test=... Previously in JSPs we could use - trimDirectiveWhitespaces=true -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Build failed in Jenkins: sling-trunk-1.6 #3095
See https://builds.apache.org/job/sling-trunk-1.6/3095/changes Changes: [rombert] Update to tycho 0.22.0 [rombert] SLING-4094 - Handle PropertyType.UNDEFINED when updating properties [rombert] SLING-4440 - Don't remove autoCreated properties Simplify test setup in AddOrUpdateNodeCommandTest [rombert] SLING-4440 - Don't remove autoCreated properties Ensure that auto-created properties are not removed if they're not present in the ResourceProxy -- [...truncated 10641 lines...] [INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [17.409s] [INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [5.902s] [INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support SUCCESS [5.340s] [INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [5.032s] [INFO] Apache Sling Service User Mapper .. FAILURE [1.248s] [INFO] Apache Sling JCR Resource Resolver SKIPPED [INFO] Apache Sling Testing OSGi Mock SKIPPED [INFO] Apache Sling Testing JCR Mock . SKIPPED [INFO] Apache Sling Testing Resource Resolver Mock ... SKIPPED [INFO] Apache Sling Testing Sling Mock ... SKIPPED [INFO] Apache Sling Testing Sling Mock Jackrabbit-based Resource Resolver SKIPPED [INFO] Apache Sling Versioning Integration Tests . SKIPPED [INFO] Apache Sling JCR Repository Registration .. SKIPPED [INFO] Apache Sling Simple WebDAV Access to repositories . SKIPPED [INFO] Apache Sling DavEx Access to repositories . SKIPPED [INFO] Apache Sling JCR WebConsole Bundle SKIPPED [INFO] Apache Sling Oak Repository Server SKIPPED [INFO] Apache Sling SlingRepository Integration Tests SKIPPED [INFO] Apache Sling Servlet Resolver . SKIPPED [INFO] Apache Sling Default GET Servlets . SKIPPED [INFO] Apache Sling Default POST Servlets SKIPPED [INFO] Apache Sling Compat Servlets .. SKIPPED [INFO] Apache Sling Scripting Implementation API . SKIPPED [INFO] Apache Sling Scripting Core implementation SKIPPED [INFO] Apache Sling Scripting JavaScript Support . SKIPPED [INFO] Apache Sling Scripting JSP Support SKIPPED [INFO] Apache Sling JSP Tag Library .. SKIPPED [INFO] Apache Sling JSP Standard Tag Library . SKIPPED [INFO] Apache Sling Adapter Manager Implementation ... SKIPPED [INFO] Apache Sling Bundle Resource Provider . SKIPPED [INFO] Apache Sling Distributed Event Admin .. SKIPPED [INFO] Apache Sling Discovery API SKIPPED [INFO] Apache Sling Resource-Based Discovery Service . SKIPPED [INFO] Apache Sling Discovery Support Bundle . SKIPPED [INFO] Apache Sling Discovery Standalone Implementation .. SKIPPED [INFO] Apache Sling Event Support SKIPPED [INFO] Apache Sling Feature Flags SKIPPED [INFO] Apache Sling Filesystem Resource Provider . SKIPPED [INFO] Apache Sling javax.activation bundle .. SKIPPED [INFO] Apache Sling Settings . SKIPPED [INFO] Apache Sling Web Console Branding . SKIPPED [INFO] Apache Sling Web Console Security Provider SKIPPED [INFO] Apache Sling Explorer . SKIPPED [INFO] Apache Sling Health Check Core SKIPPED [INFO] Apache Sling Health Check Annotations . SKIPPED [INFO] Apache Sling Health Check Samples . SKIPPED [INFO] Apache Sling Health Check Support Components .. SKIPPED [INFO] Apache Sling Health Check Webconsole Plugin ... SKIPPED [INFO] Apache Sling Health Check JUnit Bridge SKIPPED [INFO] Apache Sling Health Check Integration Tests ... SKIPPED [INFO] Apache Sling Health Check Reactor POM . SKIPPED [INFO] Apache Sling Resource Access Security . SKIPPED [INFO] Apache Sling Resource Access Security Integration Tests SKIPPED [INFO] Apache Sling Models API ... SKIPPED [INFO] Apache Sling Models Implementation SKIPPED [INFO] Apache Sling Test Tools ... SKIPPED [INFO] Apache Sling Models Integration Tests . SKIPPED [INFO] Apache Sling JUnit Core ... SKIPPED [INFO] Apache Sling JUnit Scriptable Tests Provider .. SKIPPED [INFO] Apache Sling JUnit Health Checks .. SKIPPED [INFO] Apache Sling JUnit Remote Tests Runners ... SKIPPED [INFO] Apache Sling JUnit Performance SKIPPED [INFO] Apache Sling Pax Exam Utilities ... SKIPPED [INFO] Apache Sling Sample Server-Side Tests . SKIPPED [INFO] Apache Sling Failing Server-Side Tests SKIPPED [INFO] Apache Sling Launchpad
[jira] [Commented] (SLING-4446) AbstractNewSlingApplicationWizard publishes modules which are not deployed
[ https://issues.apache.org/jira/browse/SLING-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328879#comment-14328879 ] Robert Munteanu commented on SLING-4446: Fixed in https://svn.apache.org/viewvc?view=revisionrevision=r1661113 AbstractNewSlingApplicationWizard publishes modules which are not deployed -- Key: SLING-4446 URL: https://issues.apache.org/jira/browse/SLING-4446 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 In AbstractNewSlingApplicationWizard provides a way to skip modules from being deployed on a server with the shouldDeploy method. However, that check is missing when modules are later published so such modules are incorrectly published later on in the wizard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4446) AbstractNewSlingApplicationWizard publishes modules which are not deployed
[ https://issues.apache.org/jira/browse/SLING-4446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-4446. Resolution: Fixed AbstractNewSlingApplicationWizard publishes modules which are not deployed -- Key: SLING-4446 URL: https://issues.apache.org/jira/browse/SLING-4446 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 In AbstractNewSlingApplicationWizard provides a way to skip modules from being deployed on a server with the shouldDeploy method. However, that check is missing when modules are later published so such modules are incorrectly published later on in the wizard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.7 #1484
See https://builds.apache.org/job/sling-trunk-1.7/1484/changes
Jenkins build is still unstable: sling-trunk-1.8 #774
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Created] (SLING-4445) Don't consider files outside the content sync root when exporting a project to the server
Robert Munteanu created SLING-4445:
--
Summary: Don't consider files outside the content sync root when
exporting a project to the server
Key: SLING-4445
URL: https://issues.apache.org/jira/browse/SLING-4445
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.6
The export wizard is available on project nodes. However, the export project
should start at the content sync root, not at the project since we don't care
about those files and they will make the export process fail, e.g.
{noformat}Resource at path /target/classes/etc/designs/ewcmbiz/jquery/js.txt is
not a direct child of
/../../../../target/classes/etc/designs/ewcmbiz/jquery{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4446) AbstractNewSlingApplicationWizard publishes modules which are not deployed
Robert Munteanu created SLING-4446: -- Summary: AbstractNewSlingApplicationWizard publishes modules which are not deployed Key: SLING-4446 URL: https://issues.apache.org/jira/browse/SLING-4446 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 In AbstractNewSlingApplicationWizard provides a way to skip modules from being deployed on a server with the shouldDeploy method. However, that check is missing when modules are later published so such modules are incorrectly published later on in the wizard. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328768#comment-14328768
]
Marius Petria edited comment on SLING-4312 at 2/20/15 12:52 PM:
Committed patch in revision 1661081.
EDIT: I reverted the changes in revision 1661109 because the build on java 1.6
was failing. The fail seems to be cause by an incompatibility between
org.apache.sling.commons.testing.2.0.16 and org.osgi.core.4.3.0
{code}
1.6/trunk/bundles/extensions/serviceusermapper/src/test/java/org/apache/sling/serviceusermapping/impl/ServiceUserMapperImplTest.java:[56,62]
findEntries(java.lang.String,java.lang.String,boolean) in
org.apache.sling.commons.testing.osgi.MockBundle cannot implement
findEntries(java.lang.String,java.lang.String,boolean) in
org.osgi.framework.Bundle; attempting to use incompatible return type
found : java.util.Enumeration?
required: java.util.Enumerationjava.net.URL
{code}
was (Author: mpetria):
Committed patch in revision 1661081.
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Attachments: SLING-4312.diff
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4445) Don't consider files outside the content sync root when exporting a project to the server
[
https://issues.apache.org/jira/browse/SLING-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328871#comment-14328871
]
Robert Munteanu commented on SLING-4445:
Fixed in https://svn.apache.org/viewvc?view=revisionrevision=r1661107
Don't consider files outside the content sync root when exporting a project
to the server
-
Key: SLING-4445
URL: https://issues.apache.org/jira/browse/SLING-4445
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.6
The export wizard is available on project nodes. However, the export project
should start at the content sync root, not at the project since we don't care
about those files and they will make the export process fail, e.g.
{noformat}Resource at path /target/classes/etc/designs/ewcmbiz/jquery/js.txt
is not a direct child of
/../../../../target/classes/etc/designs/ewcmbiz/jquery{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4445) Don't consider files outside the content sync root when exporting a project to the server
[
https://issues.apache.org/jira/browse/SLING-4445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-4445.
Resolution: Fixed
Don't consider files outside the content sync root when exporting a project
to the server
-
Key: SLING-4445
URL: https://issues.apache.org/jira/browse/SLING-4445
Project: Sling
Issue Type: Bug
Components: IDE
Affects Versions: Sling Eclipse IDE 1.0.4
Reporter: Robert Munteanu
Assignee: Robert Munteanu
Fix For: Sling Eclipse IDE 1.0.6
The export wizard is available on project nodes. However, the export project
should start at the content sync root, not at the project since we don't care
about those files and they will make the export process fail, e.g.
{noformat}Resource at path /target/classes/etc/designs/ewcmbiz/jquery/js.txt
is not a direct child of
/../../../../target/classes/etc/designs/ewcmbiz/jquery{noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is back to stable : sling-trunk-1.8 #775
See https://builds.apache.org/job/sling-trunk-1.8/775/changes
Jenkins build is back to stable : sling-trunk-1.7 #1485
See https://builds.apache.org/job/sling-trunk-1.7/1485/changes
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328926#comment-14328926
]
Marius Petria commented on SLING-4312:
--
[~cziegeler], the ServiceUserMapperImplTest uses MockBundle only to produce a
bundle with a custom symbolic name. That can easily be done with mockito
directly without relying on MockBundle [1]. Relying on mockito makes everything
green even on Java 6.
However I have one question: is it ok to introduce the dependency on
osgi.core.4.3.0?
[1]
https://github.com/mpetria/sling/commit/f28a0eca06003f5d5d309ed4797ee01fa557cfa2
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Attachments: SLING-4312.diff
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328926#comment-14328926
]
Marius Petria edited comment on SLING-4312 at 2/20/15 1:47 PM:
---
[~cziegeler], the ServiceUserMapperImplTest uses MockBundle only to produce a
bundle with a custom symbolic name. That can easily be done with mockito
directly without relying on MockBundle [1]. Relying on mockito makes everything
green even on Java 6.
However I have one question: is it ok to introduce the dependency on
osgi.core.4.3.0 for serviceusermapper?
[1]
https://github.com/mpetria/sling/commit/f28a0eca06003f5d5d309ed4797ee01fa557cfa2
was (Author: mpetria):
[~cziegeler], the ServiceUserMapperImplTest uses MockBundle only to produce a
bundle with a custom symbolic name. That can easily be done with mockito
directly without relying on MockBundle [1]. Relying on mockito makes everything
green even on Java 6.
However I have one question: is it ok to introduce the dependency on
osgi.core.4.3.0?
[1]
https://github.com/mpetria/sling/commit/f28a0eca06003f5d5d309ed4797ee01fa557cfa2
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Attachments: SLING-4312.diff
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14328965#comment-14328965
]
Carsten Ziegeler commented on SLING-4312:
-
[~mpetria] I think using mockito is the better way anyway and yes depending on
4.3.0 is fine
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Attachments: SLING-4312.diff
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.8 #777
See https://builds.apache.org/job/sling-trunk-1.8/777/changes
Jenkins build is back to normal : sling-trunk-1.7 #1487
See https://builds.apache.org/job/sling-trunk-1.7/1487/changes
[jira] [Resolved] (SLING-4449) Allow iterating once over String / Number objects
[
https://issues.apache.org/jira/browse/SLING-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-4449.
-
Resolution: Fixed
Fix Version/s: Scripting Sightly Engine 1.0.0
Fixed in
[r1661220|https://svn.apache.org/viewvc?view=revisionrevision=1661220].
Allow iterating once over String / Number objects
-
Key: SLING-4449
URL: https://issues.apache.org/jira/browse/SLING-4449
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
There are use cases where an iteration can be performed on a property that's
not necessary storing a multiple value. For these use cases {{data-sly-list}}
and {{data-sly-repeat}} should be able to iterate once on this value,
essentially transforming the iterated object into a {{Collection}} with one
element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is back to normal : sling-trunk-1.6 #3097
See https://builds.apache.org/job/sling-trunk-1.6/3097/changes
[jira] [Created] (SLING-4449) Allow iterating once over String / Number objects
Radu Cotescu created SLING-4449:
---
Summary: Allow iterating once over String / Number objects
Key: SLING-4449
URL: https://issues.apache.org/jira/browse/SLING-4449
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Radu Cotescu
Assignee: Radu Cotescu
There are use cases where an iteration can be performed on a property that's
not necessary storing a multiple value. For these use cases {{data-sly-list}}
and {{data-sly-repeat}} should be able to iterate once on this value,
essentially transforming the iterated object into a {{Collection}} with one
element.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.6 #3098
See https://builds.apache.org/job/sling-trunk-1.6/3098/changes
Jenkins build is still unstable: sling-trunk-1.8 #778
See https://builds.apache.org/job/sling-trunk-1.8/changes
[jira] [Created] (SLING-4450) Configure the XML validator to not run for content projects
Robert Munteanu created SLING-4450: -- Summary: Configure the XML validator to not run for content projects Key: SLING-4450 URL: https://issues.apache.org/jira/browse/SLING-4450 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 Currently .content.xml files are validated and trigger spurious warnings about No grammar constraints (DTD or XML Schema) referenced in the document. . There seems to be an extension point for achieving this, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=227834 . In the future we could consider providing our own validator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4450) Configure the XML validator to not run for content projects
[ https://issues.apache.org/jira/browse/SLING-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329785#comment-14329785 ] Robert Munteanu commented on SLING-4450: Fixed in https://svn.apache.org/viewvc?view=revisionrevision=r1661243 Configure the XML validator to not run for content projects --- Key: SLING-4450 URL: https://issues.apache.org/jira/browse/SLING-4450 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 Currently .content.xml files are validated and trigger spurious warnings about No grammar constraints (DTD or XML Schema) referenced in the document. . There seems to be an extension point for achieving this, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=227834 . In the future we could consider providing our own validator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (SLING-4450) Configure the XML validator to not run for content projects
[ https://issues.apache.org/jira/browse/SLING-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-4450. Resolution: Fixed Configure the XML validator to not run for content projects --- Key: SLING-4450 URL: https://issues.apache.org/jira/browse/SLING-4450 Project: Sling Issue Type: Improvement Components: IDE Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 Currently .content.xml files are validated and trigger spurious warnings about No grammar constraints (DTD or XML Schema) referenced in the document. . There seems to be an extension point for achieving this, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=227834 . In the future we could consider providing our own validator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: Sightly Integration Test execution fails for me
It's cool that you figured out the culprit so fast. On Thu, Feb 19, 2015 at 11:53 PM, Konrad Windszus konra...@gmx.de wrote: Hi Radu, I use UTF-8 as default encoding as well. The issue only occurs when using it with JDK 1.7.0_55. Using JDK 1.7.0_60 or later solves the issue. So it is probably related to one issue being fixed in 1.7.0_60: http://www.oracle.com/technetwork/java/javase/2col/7u60-bugfixes-2202029.html http://www.oracle.com/technetwork/java/javase/2col/7u60-bugfixes-2202029.html Konrad On 20 Feb 2015, at 02:33, Radu Cotescu r...@cotescu.com wrote: Hi Konrad, The code does indeed rely on the default platform encoding. However, on my Mac, the default encoding is UTF-8. mvn -version Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1; 2014-12-14T09:29:23-08:00) Maven home: /usr/local/Cellar/maven/3.2.5/libexec Java version: 1.7.0_67, vendor: Oracle Corporation Java home: /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: mac os x, version: 10.10.2, arch: x86_64, family: mac Is the encoding different on your box? Regards, Radu On Thu, Feb 19, 2015 at 4:13 AM, Konrad Windszus konra...@gmx.de wrote: I just tried to execute the Sightly Integration Tests and I get the following error: ... Tests run: 336, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.994 sec FAILURE! - in io.sightly.tck.TestsRunner String Expressions: String quotes and escaping - #unicode_escape(io.sightly.tck.tests.TestBuilder$1) Time elapsed: 0.007 sec FAILURE! junit.framework.AssertionFailedError: Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. at junit.framework.Assert.fail(Assert.java:47) at junit.framework.Assert.assertTrue(Assert.java:20) at io.sightly.tck.tests.TestBuilder$1.runTest(TestBuilder.java:146) Results : Failed tests: TestBuilder$1.runTest:146 Expected value 'This 'Atilde;' is a string with unicode escaping' for selector '#unicode_escape'. Instead we got 'This '??' is a string with unicode escaping'. Please check the expected markup from /testfiles/output/exprlang/strings.html. Tests run: 340, Failures: 1, Errors: 0, Skipped: 0 ... This happens with the most recent trunk and I just recompiled the XSS module on my own before that. I am using JDK 1.7.0_55 on a Mac. Any ideas what might be wrong? Is the code relying on the default encoding maybe? Thanks, Konrad
Jenkins build is back to stable : sling-trunk-1.6 #3099
See https://builds.apache.org/job/sling-trunk-1.6/3099/changes
[jira] [Created] (SLING-4451) Opening a resource in the browser does not obey the user's preferences
Robert Munteanu created SLING-4451: -- Summary: Opening a resource in the browser does not obey the user's preferences Key: SLING-4451 URL: https://issues.apache.org/jira/browse/SLING-4451 Project: Sling Issue Type: Bug Components: IDE Affects Versions: Sling Eclipse IDE 1.0.4 Reporter: Robert Munteanu Assignee: Robert Munteanu Fix For: Sling Eclipse IDE 1.0.6 Opening an issue in the browser always opens it in an internal browser, but it should rather obey the user's preference of opening in internal/external browser. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SLING-4447) Improve JavaUseProvider to not fall back to a simple Pojo instanciation in case a Java class with @Model annotation cannot be instanciated
[
https://issues.apache.org/jira/browse/SLING-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329832#comment-14329832
]
Radu Cotescu commented on SLING-4447:
-
What about providing a {{UseProvider}} for Sightly in Sling Models, and make
Sightly an optional dependency for Sling Models? :)
Improve JavaUseProvider to not fall back to a simple Pojo instanciation in
case a Java class with @Model annotation cannot be instanciated
--
Key: SLING-4447
URL: https://issues.apache.org/jira/browse/SLING-4447
Project: Sling
Issue Type: Improvement
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Konrad Windszus
Currently in case a Java class is a Sling Model (i.e. has the Model
annotation) and cannot be instanciated (e.g. required injections not
possible) Sightly falls back to instanciate those as simple Pojos.
This is never good, since a lot of NullPointerException happen then, because
all injections have not been performed then.
Therefore in the following code should be used instead
{code}
if (modelFactory.isModelClass(resource, cls)) {
if (modelFactory.canCreateFromAdaptable(resource, cls)) {
obj = modelFactory.createModel(resource, cls);
} else if (modelFactory.canCreateFromAdaptable(request, cls)) {
obj = modelFactory.createModel(request, cls);
} else {
throw new IllegalStateException(Could not adapt the given Sling Model
from neither resource nor request: + cls);
}
}
{code}
That way, exceptions would be propagated in case a Sling model cannot be
instanciated and developers more easily see why the Sling Model does not work
(instead of running into NullPointerExceptions in their model because it was
instanciated as simple
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build became unstable: sling-trunk-1.7 #1488
See https://builds.apache.org/job/sling-trunk-1.7/1488/changes
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329054#comment-14329054
]
Felix Meschberger commented on SLING-4312:
--
Please, reconsider this ServiceUserMapping service !
This service has two major issues:
# It -exposes- leaks an (administrative) implementation detail to developers:
The service name is internal derived from the bundle providing the service. It
is documented with the bundle how its dervied and its made available to
adminitrators for them to configure the mapping. With this service we expose
this implementation detail to developers. I am really not in favor of such a
thing.
# A service may have multiple subservices. This ServiceUserMapping just exposes
a single sub service. Thus we will have ServiceUserMapping service for each
subservice and thus a proliferation of services whose uses are really limited
to a select few cases.
Also, going back to the original issue: Why do we need this fix (or band-aid,
if you will) ?
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Attachments: SLING-4312.diff
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329073#comment-14329073
]
Bertrand Delacretaz commented on SLING-4312:
Looks like a discussion on our dev list might be a better way to converge on a
solution
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Attachments: SLING-4312.diff
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4312) Register an osgi service for each available service user
[
https://issues.apache.org/jira/browse/SLING-4312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329064#comment-14329064
]
Marius Petria commented on SLING-4312:
--
Hi [~fmeschbe],
1. Actually the serviceName is not necessary to be exposed. We can use only the
subServiceName so I can drop it from the ServiceUserMapping interface.
2. ServiceUserMapping is meant to represent *one* mapping not all.
3. This mechanism is meant to provide a reliable way for a component to start
only when there exists a mapping for the subService it wants to use. The
usecase is that if you want to use loginService in an activate method there is
not way to guarantee that the mapping you need is registered and hence the
ServiceUserMapper.getServiceUserID might fail.
Register an osgi service for each available service user
-
Key: SLING-4312
URL: https://issues.apache.org/jira/browse/SLING-4312
Project: Sling
Issue Type: Improvement
Components: Service User Mapper
Reporter: Marius Petria
Attachments: SLING-4312.diff
In order to only activate osgi components when a service user mapping is
available it would be useful to have an osgi service registered for a service
user. A component can reference the registered service name and only start
when that becomes available.
{code}
@Reference(target=(name=serviceName))
ServiceUserExists userExists;
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: Discuss SLING-4312: Register an osgi service for each available service user
Am 20.02.15 um 18:53 schrieb Marius Petria: Hi, I discovered an issue related to service users. Due to the indeterminism of OSGI a consumer of ServiceUserMapper cannot be sure that getServiceUserID will find a registered mapping even if that mapping has been configured. For example if a component starts roughly at the same time as the mapping is installed it can happen that the calls the component makes to loginService to fail. More concretely that can happen for example if one needs a session in an activate method to register jcr event listener, or to read some configuration properties from the repository. In order to make this behavior more predictable I created an issue [1] proposing to always register an osgi service (I called it ServiceUserMapping) right after a mapping is installed, such that consumer components can reference it and wait for the mapping to be available. I also worked out an implementation in [2]. First, I would like to ask you if you think the problem is valid and if the approach is correct? Second, it will be really helpful if you can also comment on the issue around the provided implementation. In OSGi you should declare your dependencies, which means for components, the only option you have is requiring services. Therefore translating the above problem into service dependencies is imho the right way. Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Commented] (SLING-4447) Improve JavaUseProvider to not fall back to a simple Pojo instanciation in case a Java class with @Model annotation cannot be instanciated
[
https://issues.apache.org/jira/browse/SLING-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329178#comment-14329178
]
Konrad Windszus commented on SLING-4447:
Would it be acceptable for Sightly to have a dependency to Sling Models?
Otherwise the ModelFactory cannot be used. One could make that dependency
optional though (similar to what was done SLING-4161 to make Sling Validation
optional for Sling Models).
Improve JavaUseProvider to not fall back to a simple Pojo instanciation in
case a Java class with @Model annotation cannot be instanciated
--
Key: SLING-4447
URL: https://issues.apache.org/jira/browse/SLING-4447
Project: Sling
Issue Type: Improvement
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Konrad Windszus
Currently in case a Java class is a Sling Model (i.e. has the Model
annotation) and cannot be instanciated (e.g. required injections not
possible) Sightly falls back to instanciate those as simple Pojos.
This is never good, since a lot of NullPointerException happen then, because
all injections have not been performed then.
Therefore in the following code should be used instead
{code}
if (modelFactory.isModelClass(resource, cls)) {
if (modelFactory.canCreateFromAdaptable(resource, cls)) {
obj = modelFactory.createModel(resource, cls);
} else if (modelFactory.canCreateFromAdaptable(request, cls)) {
obj = modelFactory.createModel(request, cls);
} else {
throw new IllegalStateException(Could not adapt the given Sling Model
from neither resource nor request: + cls);
}
}
{code}
That way, exceptions would be propagated in case a Sling model cannot be
instanciated and developers more easily see why the Sling Model does not work
(instead of running into NullPointerExceptions in their model because it was
instanciated as simple
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4447) Improve JavaUseProvider to not fall back to a simple Pojo instanciation in case a Java class with @Model annotation cannot be instanciated
Konrad Windszus created SLING-4447:
--
Summary: Improve JavaUseProvider to not fall back to a simple Pojo
instanciation in case a Java class with @Model annotation cannot be instanciated
Key: SLING-4447
URL: https://issues.apache.org/jira/browse/SLING-4447
Project: Sling
Issue Type: Improvement
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Konrad Windszus
Currently in case a Java class is a Sling Model (i.e. has the Model annotation)
and cannot be instanciated (e.g. required injections not possible) Sightly
falls back to instanciate those as simple Pojos.
This is never good, since a lot of NullPointerException happen then, because
all injections have not been performed then.
Therefore in the following code should be used instead
{code}
if (modelFactory.isModelClass(resource, cls)) {
if (modelFactory.canCreateFromAdaptable(resource, cls)) {
obj = modelFactory.createModel(resource, cls);
} else if (modelFactory.canCreateFromAdaptable(request, cls)) {
obj = modelFactory.createModel(request, cls);
} else {
throw new IllegalStateException(Could not adapt the given Sling Model from
neither resource nor request: + cls);
}
}
{code}
That way, exceptions would be propagated in case a Sling model cannot be
instanciated and developers more easily see why the Sling Model does not work
(instead of running into NullPointerExceptions in their model because it was
instanciated as simple
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Discuss SLING-4312: Register an osgi service for each available service user
Hi, I discovered an issue related to service users. Due to the indeterminism of OSGI a consumer of ServiceUserMapper cannot be sure that getServiceUserID will find a registered mapping even if that mapping has been configured. For example if a component starts roughly at the same time as the mapping is installed it can happen that the calls the component makes to loginService to fail. More concretely that can happen for example if one needs a session in an activate method to register jcr event listener, or to read some configuration properties from the repository. In order to make this behavior more predictable I created an issue [1] proposing to always register an osgi service (I called it ServiceUserMapping) right after a mapping is installed, such that consumer components can reference it and wait for the mapping to be available. I also worked out an implementation in [2]. First, I would like to ask you if you think the problem is valid and if the approach is correct? Second, it will be really helpful if you can also comment on the issue around the provided implementation. Marius [1] https://issues.apache.org/jira/browse/SLING-4312 [2] https://github.com/mpetria/sling/compare/mpetria:trunk...dev-SLING-4312
[jira] [Created] (SLING-4448) Make the RenderUnitProvider fail loudly if the provided identifier does not resolve to a script
Radu Cotescu created SLING-4448:
---
Summary: Make the RenderUnitProvider fail loudly if the provided
identifier does not resolve to a script
Key: SLING-4448
URL: https://issues.apache.org/jira/browse/SLING-4448
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
Currently the {{RenderUnitProvider}} fails silently if the identifier does
not resolve to an existing script. Instead the {{RenderUnitProvider}} should
return a {{ProviderOutcome}} with an explicit failure cause such that the
Use-API fails loudly without having to query the other {{UseProvider}} services.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (SLING-4448) Make the RenderUnitProvider fail loudly if the provided identifier does not resolve to a script
[
https://issues.apache.org/jira/browse/SLING-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329412#comment-14329412
]
Radu Cotescu edited comment on SLING-4448 at 2/20/15 7:35 PM:
--
Fixed in revision
[r1661199|https://svn.apache.org/viewvc?view=revisionrevision=1661199].
was (Author: radu.cotescu):
Fixed in revision
[r1661012|https://svn.apache.org/viewvc?view=revisionrevision=1661012].
Make the RenderUnitProvider fail loudly if the provided identifier does not
resolve to a script
---
Key: SLING-4448
URL: https://issues.apache.org/jira/browse/SLING-4448
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
Currently the {{RenderUnitProvider}} fails silently if the identifier does
not resolve to an existing script. Instead the {{RenderUnitProvider}} should
return a {{ProviderOutcome}} with an explicit failure cause such that the
Use-API fails loudly without having to query the other {{UseProvider}}
services.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (SLING-4448) Make the RenderUnitProvider fail loudly if the provided identifier does not resolve to a script
[
https://issues.apache.org/jira/browse/SLING-4448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-4448.
-
Resolution: Fixed
Fixed in revision
[r1661012|https://svn.apache.org/viewvc?view=revisionrevision=1661012].
Make the RenderUnitProvider fail loudly if the provided identifier does not
resolve to a script
---
Key: SLING-4448
URL: https://issues.apache.org/jira/browse/SLING-4448
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting Sightly Engine 1.0.0
Currently the {{RenderUnitProvider}} fails silently if the identifier does
not resolve to an existing script. Instead the {{RenderUnitProvider}} should
return a {{ProviderOutcome}} with an explicit failure cause such that the
Use-API fails loudly without having to query the other {{UseProvider}}
services.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4443) Whitespace removal for Sightly HTML output
[ https://issues.apache.org/jira/browse/SLING-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329836#comment-14329836 ] Radu Cotescu commented on SLING-4443: - Hi Feike! Yes, I think it's a valid request / concern and I think that [~sseif...@pro-vision.de]'s suggestion from the linked thread makes sense. Whitespace removal for Sightly HTML output -- Key: SLING-4443 URL: https://issues.apache.org/jira/browse/SLING-4443 Project: Sling Issue Type: New Feature Components: Scripting Reporter: Dan Chapman Priority: Minor Can there be a way to remove whitespace from Sightly components HTML output, that is created when elements are hidden e.g. span data-sly-test=... Previously in JSPs we could use - trimDirectiveWhitespaces=true -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Jenkins build is back to stable : sling-trunk-1.8 #779
See https://builds.apache.org/job/sling-trunk-1.8/779/changes
[jira] [Commented] (SLING-4436) org.apache.sling.scripting.sightly does not compile
[
https://issues.apache.org/jira/browse/SLING-4436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14329901#comment-14329901
]
Radu Cotescu commented on SLING-4436:
-
I've renamed my {{settings.xml}} file and the build still works for me:
{noformat}
~/workspace/adobe/code/sling-git-svn/contrib/scripting/sightly/engine (master)
rm -rf ~/.m2/repository/org/apache/sling/org.apache.sling.commons.compiler/
~/workspace/adobe/code/sling-git-svn/contrib/scripting/sightly/engine (master)
rm -rf ~/.m2/repository/org/eclipse/core/resources/
~/workspace/adobe/code/sling-git-svn/contrib/scripting/sightly/engine (master)
subl ~/.m2/settings.xml
~/workspace/adobe/code/sling-git-svn/contrib/scripting/sightly/engine (master)
mv ~/.m2/settings.xml ~/.m2/settings-exp.xml
~/workspace/adobe/code/sling-git-svn/contrib/scripting/sightly/engine (master)
mvn clean package
[INFO] Scanning for projects...
[INFO]
[INFO]
[INFO] Building Apache Sling Scripting Sightly Engine 1.0.0-SNAPSHOT
[INFO]
Downloading:
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.compiler/2.0.0/org.apache.sling.commons.compiler-2.0.0.pom
Downloaded:
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.compiler/2.0.0/org.apache.sling.commons.compiler-2.0.0.pom
(6 KB at 11.7 KB/sec)
Downloading:
https://repo.maven.apache.org/maven2/org/eclipse/core/resources/maven-metadata.xml
Downloading:
http://repository.apache.org/snapshots/org/eclipse/core/resources/maven-metadata.xml
Downloaded:
https://repo.maven.apache.org/maven2/org/eclipse/core/resources/maven-metadata.xml
(367 B at 13.8 KB/sec)
Downloading:
https://repo.maven.apache.org/maven2/org/eclipse/core/resources/3.2.1-R32x_v20060914/resources-3.2.1-R32x_v20060914.pom
Downloaded:
https://repo.maven.apache.org/maven2/org/eclipse/core/resources/3.2.1-R32x_v20060914/resources-3.2.1-R32x_v20060914.pom
(2 KB at 29.0 KB/sec)
Downloading:
https://repo.maven.apache.org/maven2/org/eclipse/core/resources/3.3.0-v20070604/resources-3.3.0-v20070604.pom
Downloaded:
https://repo.maven.apache.org/maven2/org/eclipse/core/resources/3.3.0-v20070604/resources-3.3.0-v20070604.pom
(2 KB at 37.4 KB/sec)
Downloading:
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.compiler/2.0.0/org.apache.sling.commons.compiler-2.0.0.jar
Downloading:
https://repo.maven.apache.org/maven2/org/eclipse/core/resources/3.3.0-v20070604/resources-3.3.0-v20070604.jar
Downloaded:
https://repo.maven.apache.org/maven2/org/eclipse/core/resources/3.3.0-v20070604/resources-3.3.0-v20070604.jar
(663 KB at 2619.6 KB/sec)
Downloaded:
https://repo.maven.apache.org/maven2/org/apache/sling/org.apache.sling.commons.compiler/2.0.0/org.apache.sling.commons.compiler-2.0.0.jar
(3833 KB at 3678.4 KB/sec)
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
org.apache.sling.scripting.sightly ---
[INFO] Deleting
/Users/radu/workspace/adobe/code/sling-git-svn/contrib/scripting/sightly/engine/target
...
---
T E S T S
---
Running
org.apache.sling.scripting.sightly.impl.compiler.SightlyJavaCompilerServiceTest
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.383 sec - in
org.apache.sling.scripting.sightly.impl.compiler.SightlyJavaCompilerServiceTest
Running
org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImplTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.025 sec - in
org.apache.sling.scripting.sightly.impl.engine.runtime.RenderContextImplTest
Running org.apache.sling.scripting.sightly.impl.html.dom.HtmlParserTest
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in
org.apache.sling.scripting.sightly.impl.html.dom.HtmlParserTest
Running org.apache.sling.scripting.sightly.impl.utils.PathInfoTest
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec - in
org.apache.sling.scripting.sightly.impl.utils.PathInfoTest
Results :
Tests run: 16, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- animal-sniffer-maven-plugin:1.11:check (default) @
org.apache.sling.scripting.sightly ---
[INFO] Checking unresolved references to org.codehaus.mojo.signature:java16:1.0
[INFO]
[INFO] --- maven-bundle-plugin:2.4.0:bundle (default-bundle) @
org.apache.sling.scripting.sightly ---
[INFO]
[INFO] maven-source-plugin:2.2.1:jar (attach-sources) generate-sources @
org.apache.sling.scripting.sightly
[INFO]
[INFO] --- maven-enforcer-plugin:1.3.1:enforce (enforce-java) @
org.apache.sling.scripting.sightly ---
[INFO]
[INFO] --- maven-antrun-plugin:1.7:run
(set-bundle-required-execution-environment) @
Build failed in Jenkins: sling-trunk-1.7 #1486
See https://builds.apache.org/job/sling-trunk-1.7/1486/changes Changes: [radu] SLING-4448 - Make the RenderUnitProvider fail loudly if the provided identifier does not resolve to a script * explicitly return a failure cause if the identifier does not resolve to a script -- [...truncated 26328 lines...] [INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [2.732s] [INFO] Apache Sling MIME type mapping support SUCCESS [4.278s] [INFO] Apache Sling Commons OSGi support . SUCCESS [3.756s] [INFO] Apache Sling Scheduler Support SUCCESS [3.240s] [INFO] Apache Sling Testing Utilities SUCCESS [14.274s] [INFO] Apache Sling Thread Dumper SUCCESS [2.548s] [INFO] Apache Sling Thread Support ... SUCCESS [2.896s] [INFO] Apache Sling Authentication Service ... SUCCESS [4.050s] [INFO] Apache Sling Form Based Authentication Handler SUCCESS [7.182s] [INFO] Apache Sling Engine Implementation SUCCESS [17.386s] [INFO] Apache Sling Repository API Bundle SUCCESS [2.410s] [INFO] Apache Sling JCR Base Bundle .. SUCCESS [3.857s] [INFO] Apache Sling JCR ClassLoader .. SUCCESS [4.727s] [INFO] Apache Sling Initial Content Loader ... SUCCESS [5.282s] [INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [15.725s] [INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [3.923s] [INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support SUCCESS [2.998s] [INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [2.426s] [INFO] Apache Sling Service User Mapper .. SUCCESS [3.609s] [INFO] Apache Sling JCR Resource Resolver SUCCESS [38.165s] [INFO] Apache Sling Testing OSGi Mock SUCCESS [4.816s] [INFO] Apache Sling Testing JCR Mock . SUCCESS [3.890s] [INFO] Apache Sling Testing Resource Resolver Mock ... SUCCESS [3.227s] [INFO] Apache Sling Testing Sling Mock ... SUCCESS [8.364s] [INFO] Apache Sling Testing Sling Mock Jackrabbit-based Resource Resolver SUCCESS [12.619s] [INFO] Apache Sling Versioning Integration Tests . SUCCESS [9.907s] [INFO] Apache Sling JCR Repository Registration .. SUCCESS [4.604s] [INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [3.653s] [INFO] Apache Sling DavEx Access to repositories . SUCCESS [3.849s] [INFO] Apache Sling JCR WebConsole Bundle SUCCESS [2.829s] [INFO] Apache Sling Oak Repository Server SUCCESS [4.048s] [INFO] Apache Sling SlingRepository Integration Tests SUCCESS [55.079s] [INFO] Apache Sling Servlet Resolver . SUCCESS [4.893s] [INFO] Apache Sling Default GET Servlets . SUCCESS [4.765s] [INFO] Apache Sling Default POST Servlets SUCCESS [5.182s] [INFO] Apache Sling Compat Servlets .. SUCCESS [2.918s] [INFO] Apache Sling Scripting Implementation API . SUCCESS [2.546s] [INFO] Apache Sling Scripting Core implementation SUCCESS [13.802s] [INFO] Apache Sling Scripting JavaScript Support . SUCCESS [14.925s] [INFO] Apache Sling Scripting JSP Support SUCCESS [6.658s] [INFO] Apache Sling JSP Tag Library .. SUCCESS [5.470s] [INFO] Apache Sling JSP Standard Tag Library . SUCCESS [2.620s] [INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [3.351s] [INFO] Apache Sling Bundle Resource Provider . SUCCESS [2.428s] [INFO] Apache Sling Distributed Event Admin .. SUCCESS [5.208s] [INFO] Apache Sling Discovery API SUCCESS [2.308s] [INFO] Apache Sling Resource-Based Discovery Service . FAILURE [4:02.099s] [INFO] Apache Sling Discovery Support Bundle . SKIPPED [INFO] Apache Sling Discovery Standalone Implementation .. SKIPPED [INFO] Apache Sling Event Support SKIPPED [INFO] Apache Sling Feature Flags SKIPPED [INFO] Apache Sling Filesystem Resource Provider . SKIPPED [INFO] Apache Sling javax.activation bundle .. SKIPPED [INFO] Apache Sling Settings . SKIPPED [INFO] Apache Sling Web Console Branding . SKIPPED [INFO] Apache Sling Web Console Security Provider SKIPPED [INFO] Apache Sling Explorer . SKIPPED [INFO] Apache Sling Health Check Core SKIPPED [INFO] Apache Sling Health Check Annotations . SKIPPED [INFO] Apache Sling Health Check Samples . SKIPPED [INFO] Apache Sling Health Check Support Components .. SKIPPED [INFO] Apache Sling Health Check Webconsole Plugin ... SKIPPED [INFO] Apache Sling Health
