[jira] [Commented] (SLING-4494) Performance: update performance test framework to allow comparison of results
[ https://issues.apache.org/jira/browse/SLING-4494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357004#comment-14357004 ] ASF GitHub Bot commented on SLING-4494: --- GitHub user vladbailescu opened a pull request: https://github.com/apache/sling/pull/69 SLING-4494 - Performance: update performance test framework to allow comparison of results Performance testing features which allow us to not only log tests run time but also compare them and fail in case a certain threshold ratio is surpassed. Added: - Annotations for reference method and performance threshold - Deferred results logging to allow for comparison after all tests ran - Analysis of performance against reference method and threshold enforcement You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladbailescu/sling SLING-4494_performance_framework_update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit c065f663b5cbc46518972281939b231429180f19 Author: vladbailescu baile...@adobe.com Date: 2015-03-11T15:04:02Z @trivial Converted mixed tabs and spaces indentation to spaces commit 7732f003aef962c21e66eb819190521e04cb7f06 Author: vladbailescu baile...@adobe.com Date: 2015-03-11T15:16:43Z SLING-4494 - Performance: update performance test framework to allow comparison of results Performance testing features which allow us to not only log tests run time but also compare them and fail in case a certain threshold ratio is surpassed. Added: - Annotations for reference method and performance threshold - Deferred results logging to allow for comparison after all tests ran - Analysis of performance against reference method and threshold enforcement Performance: update performance test framework to allow comparison of results - Key: SLING-4494 URL: https://issues.apache.org/jira/browse/SLING-4494 Project: Sling Issue Type: Test Reporter: Vlad Bailescu Priority: Minor Update the Sling performance test framework to allow comparison of test results. Specifically, add: - possibility to define a reference test and have the results of other tests compared to it - possibility to log results as a ratio compared to the reference test - possibility to define a maximum threshold and have the framework fail a test if it's ratio against the reference test exceeds this threshold -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] sling pull request: SLING-4493 Sightly: Create performance tests
GitHub user vladbailescu opened a pull request: https://github.com/apache/sling/pull/70 SLING-4493 Sightly: Create performance tests Added: - Sightly performance testing content and scripts - Test suite for JSP, JSP-EL, Sightly Java Use API and Sightly JS Use API You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladbailescu/sling SLING-4493_sightly_performance_tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [VOTE] Release Apache Sling Query version 3.0.0
Hello, may I ask for one more vote, please? Regards, Tomek On Tue, Mar 10, 2015 at 9:14 AM, Carsten Ziegeler cziege...@apache.org wrote: +1 -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[jira] [Commented] (SLING-4492) Prevent configuring the ESAPI policies through random content files
[
https://issues.apache.org/jira/browse/SLING-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357175#comment-14357175
]
Radu Cotescu commented on SLING-4492:
-
I pushed a potential fix in
[r1665939|https://svn.apache.org/viewvc?view=revisionrevision=1665939].
[~fmeschbe], could you please review the commit? If the solution looks good to
you I think we can mark this issue as fixed.
Prevent configuring the ESAPI policies through random content files
---
Key: SLING-4492
URL: https://issues.apache.org/jira/browse/SLING-4492
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: XSS Protection API 1.0.0
Currently the default ESAPI policies are configured through a file from the
repository - {{/libs/sling/xss/config.xml}}. However, the proposed
{{XSSFilter}} API allows filtering using random policy files. The
configuration should be performed only through the
{{/libs/sling/xss/config.xml}} file, or through an {{/apps}} overlay.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4494) Performance: update performance test framework to allow comparison of results
Vlad Bailescu created SLING-4494: Summary: Performance: update performance test framework to allow comparison of results Key: SLING-4494 URL: https://issues.apache.org/jira/browse/SLING-4494 Project: Sling Issue Type: Test Reporter: Vlad Bailescu Priority: Minor Update the Sling performance test framework to allow comparison of test results. Specifically, add: - possibility to define a reference test and have the results of other tests compared to it - possibility to log results as a ratio compared to the reference test - possibility to define a maximum threshold and have the framework fail a test if it's ratio against the reference test exceeds this threshold -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] sling pull request: SLING-4494 - Performance: update performance t...
GitHub user vladbailescu opened a pull request: https://github.com/apache/sling/pull/69 SLING-4494 - Performance: update performance test framework to allow comparison of results Performance testing features which allow us to not only log tests run time but also compare them and fail in case a certain threshold ratio is surpassed. Added: - Annotations for reference method and performance threshold - Deferred results logging to allow for comparison after all tests ran - Analysis of performance against reference method and threshold enforcement You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladbailescu/sling SLING-4494_performance_framework_update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit c065f663b5cbc46518972281939b231429180f19 Author: vladbailescu baile...@adobe.com Date: 2015-03-11T15:04:02Z @trivial Converted mixed tabs and spaces indentation to spaces commit 7732f003aef962c21e66eb819190521e04cb7f06 Author: vladbailescu baile...@adobe.com Date: 2015-03-11T15:16:43Z SLING-4494 - Performance: update performance test framework to allow comparison of results Performance testing features which allow us to not only log tests run time but also compare them and fail in case a certain threshold ratio is surpassed. Added: - Annotations for reference method and performance threshold - Deferred results logging to allow for comparison after all tests ran - Analysis of performance against reference method and threshold enforcement --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[RESULT] [VOTE] Release Apache Sling Query version 3.0.0
Hi, The vote has passed with the following result : +1 (binding): rombert, cziegeler, dklco I will promote the artifacts to the central Maven repository. Could someone copy release to the Sling dist directory? Thanks, Tomek -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[GitHub] sling pull request: SLING-4093 Added performance tests to compare ...
Github user vladbailescu closed the pull request at: https://github.com/apache/sling/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (SLING-4093) run performance tests to compare with JSP and Sightly
[
https://issues.apache.org/jira/browse/SLING-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357025#comment-14357025
]
ASF GitHub Bot commented on SLING-4093:
---
Github user vladbailescu closed the pull request at:
https://github.com/apache/sling/pull/61
run performance tests to compare with JSP and Sightly
-
Key: SLING-4093
URL: https://issues.apache.org/jira/browse/SLING-4093
Project: Sling
Issue Type: Test
Components: Scripting
Reporter: Oliver Lietz
Assignee: Oliver Lietz
Priority: Minor
Fix For: Scripting Thymeleaf 0.0.6
Attachments:
SLING-4093_-_Performance_tests_to_compare_JSP_and_Sightly.patch
find out how Thymeleaf performs
[~klcodanr]:
{quote}
1. Performance:
I found JSP to be roughly 10x faster in contrived tests than Sightly. I've
uploaded a package which can be run on an AEM6 instance showing the
performance difference between the JSP and Sightly text components here:
https://www.danklco.com/assets/Sightly%20Performance%20Test.zip
{quote}
http://mail-archives.apache.org/mod_mbox/sling-dev/201410.mbox/%3cCAHbpyFZ0_f6V7jMTzj=zv0f3wvyjs2oyv6cowx3uucwn2n7...@mail.gmail.com%3e
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SLING-4493) Sightly: Create performance tests
[ https://issues.apache.org/jira/browse/SLING-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357022#comment-14357022 ] ASF GitHub Bot commented on SLING-4493: --- GitHub user vladbailescu opened a pull request: https://github.com/apache/sling/pull/70 SLING-4493 Sightly: Create performance tests Added: - Sightly performance testing content and scripts - Test suite for JSP, JSP-EL, Sightly Java Use API and Sightly JS Use API You can merge this pull request into a Git repository by running: $ git pull https://github.com/vladbailescu/sling SLING-4493_sightly_performance_tests Alternatively you can review and apply these changes as the patch at: https://github.com/apache/sling/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 Sightly: Create performance tests - Key: SLING-4493 URL: https://issues.apache.org/jira/browse/SLING-4493 Project: Sling Issue Type: Test Components: Scripting, Testing Affects Versions: Scripting Sightly Engine 1.0.0 Reporter: Vlad Bailescu Priority: Minor Fix For: Scripting Sightly Engine 1.0.0 Create performance tests for Sightly to evaluate current status and performance impact of changes: - Create test content covering major Sightly features - Test both Java and JS Use API against equivalent JSP scripts - Create tests and set relative thresholds for performance ratio between Sightly and JSP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: [VOTE] Release Apache Sling Query version 3.0.0
+1 On 11 Mar 2015 09:34, Tomek Rękawek tomasz.reka...@cognifide.com wrote: Hello, may I ask for one more vote, please? Regards, Tomek On Tue, Mar 10, 2015 at 9:14 AM, Carsten Ziegeler cziege...@apache.org wrote: +1 -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org -- Tomek Rękawek Senior Software Engineer Cognifide Polska Sp. z o.o. skype: trekawek www.cognifide.com
[jira] [Updated] (SLING-4492) Prevent configuring the ESAPI policies through random content files
[
https://issues.apache.org/jira/browse/SLING-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-4492:
Description: Currently the default ESAPI policies are configured through a
file from the repository - {{/libs/sling/xss/config.xml}}. However, the
proposed {{XSSFilter}} API allows filtering using random policy files. The
configuration should be performed only through the
{{/libs/sling/xss/config.xml}} file, or through an {{/apps}} overlay. (was:
Currently the ESAPI policies are configured through a file from the repository
- {{/libs/sling/xss/config.xml}}. However, the configuration of the XSS bundle
should be made through OSGi mechanisms instead of relying on content structures
and content overlay.
This issue tracks only the removal of the ESAPI configuration from the content.)
Prevent configuring the ESAPI policies through random content files
---
Key: SLING-4492
URL: https://issues.apache.org/jira/browse/SLING-4492
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: XSS Protection API 1.0.0
Currently the default ESAPI policies are configured through a file from the
repository - {{/libs/sling/xss/config.xml}}. However, the proposed
{{XSSFilter}} API allows filtering using random policy files. The
configuration should be performed only through the
{{/libs/sling/xss/config.xml}} file, or through an {{/apps}} overlay.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [VOTE] Release Apache Sling Settings 1.3.6
On Monday 09 March 2015 09:40:21 Carsten Ziegeler wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12328791 +1 O.
Re: [VOTE] Release Apache Sling Event 3.5.4
On Monday 09 March 2015 09:43:01 Carsten Ziegeler wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12329450 +1 O.
Re: [VOTE] Release Apache Sling Resource Merger 1.2.8
On Monday 09 March 2015 09:44:00 Carsten Ziegeler wrote: Hi, We solved 1 issue in this release: https://issues.apache.org/jira/browse/SLING/fixforversion/12329445 +1 O.
[jira] [Commented] (SLING-3829) Add support for Content-Disposition attachment
[
https://issues.apache.org/jira/browse/SLING-3829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14357428#comment-14357428
]
Oliver Lietz commented on SLING-3829:
-
A package or project to throw in a blank AEM or Sling to test the rules would
help.
UrlRewriteFilter can be extended with
{{org.tuckey.web.filters.urlrewrite.Rule}}_s_.
We can extend Sling URL Rewriter with a mechanism to feed the {{UrlRewriter}}
with rules (OSGi services).
We need to find out, if these rule services have already access to all required
resources to make a decision if the filter kicks in.
Add support for Content-Disposition attachment
---
Key: SLING-3829
URL: https://issues.apache.org/jira/browse/SLING-3829
Project: Sling
Issue Type: Improvement
Components: Extensions
Reporter: Antonio Sanso
Assignee: Antonio Sanso
Priority: Minor
In some situation will be useful (and safer) to force Content-Disposition
attachment for some Content-Type (configurable ) under some specific (and
sensitive) path (configurable)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Jenkins build is unstable: sling-trunk-1.8 #832
See https://builds.apache.org/job/sling-trunk-1.8/832/changes
[jira] [Comment Edited] (SLING-3407) ResourceBundleManager API
[ https://issues.apache.org/jira/browse/SLING-3407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13908725#comment-13908725 ] Alexander Klimetschek edited comment on SLING-3407 at 3/12/15 1:24 AM: --- Here is a quick patch (compiles tests success, but not fully tested in reality yet): [^SLING-3407.patch] There are 2 open questions: 1) getDefaultLocale() method: do we need that anymore? See SLING-2577. I don't think a provider should be responsible for the default locale, and with multiple providers it doesn't really make sense anymore. Currently it is a fixed configuration on the JcrResourceBundleProvider and used as a fallback in case a null locale is passed to the provider. But IMO this needs to be handled at higher levels, such as the request object, which already does that - if you pass null as locale, it will use the request.getLocale() method which has its own resolution. getDefaultLocale() is used in the I18nFilter though, as a default fallback for request.getLocale() in some cases (in case it's not a SlingHttpServletRequest afaics). But this is after the RequestLocaleResolver returned null - and I don't think this needs another fallback. One should have the default fallback over in the RequestLocaleResolver. Long story short: don't have getDefaultLocale() on the new RBManager (note: it's currently in the patch), and deprecate it on the RBProvider interface. 2) BUNDLE_REQ_ATTR constant: I moved it over to the new RBManager interface and deprecated it on the RBProvider. But it seems it is not really used - the I18nFilter only reads it from the request attributes, but it never writes it. So application code would have to set it itself, not sure if that is a frequent thing to do. So it might be ok to just keep it on the RBProvider for backwards compatibility and not bring it over and promote it further on RBManager. was (Author: alexander.klimetschek): Here is a quick patch (compiles tests success, but not fully tested in reality yet): [^SLING-3407.patch] There are 2 open questions: 1) getDefaultLocale() method: do we need that anymore? I don't think a provider should be responsible for the default locale, and with multiple providers it doesn't really make sense anymore. Currently it is a fixed configuration on the JcrResourceBundleProvider and used as a fallback in case a null locale is passed to the provider. But IMO this needs to be handled at higher levels, such as the request object, which already does that - if you pass null as locale, it will use the request.getLocale() method which has its own resolution. getDefaultLocale() is used in the I18nFilter though, as a default fallback for request.getLocale() in some cases (in case it's not a SlingHttpServletRequest afaics). But this is after the RequestLocaleResolver returned null - and I don't think this needs another fallback. One should have the default fallback over in the RequestLocaleResolver. Long story short: don't have getDefaultLocale() on the new RBManager (note: it's currently in the patch), and deprecate it on the RBProvider interface. 2) BUNDLE_REQ_ATTR constant: I moved it over to the new RBManager interface and deprecated it on the RBProvider. But it seems it is not really used - the I18nFilter only reads it from the request attributes, but it never writes it. So application code would have to set it itself, not sure if that is a frequent thing to do. So it might be ok to just keep it on the RBProvider for backwards compatibility and not bring it over and promote it further on RBManager. ResourceBundleManager API - Key: SLING-3407 URL: https://issues.apache.org/jira/browse/SLING-3407 Project: Sling Issue Type: New Feature Components: Extensions Reporter: Alexander Klimetschek Labels: i18n Attachments: SLING-3407.patch Currently there is the ResourceBundleProvider service interface, which really is an SPI, now that you can have multiple of them. The right way of accessing them is to get all service references, sort by service ranking (highest first) and then take the result from the first one that doesn't give you a null result (null resource bundle from getResourceBundle()). This is done in the I18nFilter and is quite a bit of boilerplate that client code should not have to worry about. Thus there should be a new API, something like a ResourceBundleManager with the 2 methods for getResourceBundle() (with basename and without). [1] http://svn.apache.org/repos/asf/sling/trunk/contrib/extensions/i18n/src/main/java/org/apache/sling/i18n/impl/I18NFilter.java -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (SLING-4492) Prevent configuring the ESAPI policies through random content files
[
https://issues.apache.org/jira/browse/SLING-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu updated SLING-4492:
Summary: Prevent configuring the ESAPI policies through random content
files (was: Prevent configuring the ESAPI policies through content)
Prevent configuring the ESAPI policies through random content files
---
Key: SLING-4492
URL: https://issues.apache.org/jira/browse/SLING-4492
Project: Sling
Issue Type: Bug
Components: Extensions
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: XSS Protection API 1.0.0
Currently the ESAPI policies are configured through a file from the
repository - {{/libs/sling/xss/config.xml}}. However, the configuration of
the XSS bundle should be made through OSGi mechanisms instead of relying on
content structures and content overlay.
This issue tracks only the removal of the ESAPI configuration from the
content.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SLING-4483) Sightly: data-sly-resource does not properly resolve relative paths
[
https://issues.apache.org/jira/browse/SLING-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vlad Bailescu closed SLING-4483.
Sightly: data-sly-resource does not properly resolve relative paths
---
Key: SLING-4483
URL: https://issues.apache.org/jira/browse/SLING-4483
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting Sightly Engine 1.0.0
Reporter: Vlad Bailescu
Assignee: Radu Cotescu
Priority: Minor
Fix For: Scripting Sightly Engine 1.0.0
The following resource inclusion is not working:
{code:html}
div data-sly-resource=${@ path='.', resourceType='foo/bar'}/div
{code}
The returned error is:
{{org.apache.sling.scripting.sightly.impl.engine.extension.ResourceRuntimeExtension
Script path cannot be empty}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Closed] (SLING-4177) Sightly: StyleString context doesn't properly escape
[
https://issues.apache.org/jira/browse/SLING-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vlad Bailescu closed SLING-4177.
Sightly: StyleString context doesn't properly escape
Key: SLING-4177
URL: https://issues.apache.org/jira/browse/SLING-4177
Project: Sling
Issue Type: Bug
Components: Extensions, Scripting
Reporter: Vlad Bailescu
Assignee: Felix Meschberger
Priority: Minor
Labels: Sightly
Fix For: XSS Protection API 1.0.0, Scripting Sightly Engine 1.0.0
The {{context='styleString'}} expression option seems to escape strings the
same way as {{context='scriptString'}}, but this breaks the string, making
that context unusable. CSS strings are to be escaped {{\HH}} and not {{\xHH}}
like in JS:
https://developer.mozilla.org/en-US/docs/Web/CSS/string
Consider following example:
{code:html}
style
.ft:after { content: ${'\'' @ context='styleString'}; }
.in:after { content: ${'\' @ context='styleString'}; }
/style
{code}
Which currently gets incorrectly rendered as follows:
{code:html}
style
.ft:after { content: \x27; }
.in:after { content: \x22; }
/style
{code}
Following output would have been expected:
{code:html}
style
.ft:after { content: \27; }
.in:after { content: \22; }
/style
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (SLING-4493) Create performance tests for Sightly
Vlad Bailescu created SLING-4493: Summary: Create performance tests for Sightly Key: SLING-4493 URL: https://issues.apache.org/jira/browse/SLING-4493 Project: Sling Issue Type: Test Components: Scripting, Testing Affects Versions: Scripting Sightly Engine 1.0.0 Reporter: Vlad Bailescu Priority: Minor Fix For: Scripting Sightly Engine 1.0.0 Create performance tests for Sightly to evaluate current status and performance impact of changes: - Create test content covering major Sightly features - Test both Java and JS Use API against equivalent JSP scripts - Create tests and set relative thresholds for performance ratio between Sightly and JSP -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (SLING-4428) Sightly: scriptComment and styleComment contexts are not doing anything
[ https://issues.apache.org/jira/browse/SLING-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vlad Bailescu closed SLING-4428. Sightly: scriptComment and styleComment contexts are not doing anything --- Key: SLING-4428 URL: https://issues.apache.org/jira/browse/SLING-4428 Project: Sling Issue Type: Bug Components: Extensions Reporter: Vlad Bailescu Assignee: Robert Munteanu Priority: Minor Fix For: XSS Protection API 1.0.0, Scripting Sightly Engine 1.0.0 The Sightly spec defines scriptComment context but in the current implementation it is not working as expected, as it's treated internally like a JS token. This needs to be fixed so that the comment context will work as expected. The spec will clarify usage of the scriptComment context (it will only be used for block comments, ie: /*...*/) and will also add styleComment (which will behave similarly): https://github.com/Adobe-Marketing-Cloud/sightly-spec/pull/12 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
