[jira] [Commented] (SLING-4568) Performance: MergingResourceProvider.ParentHidingHandler adds about 30% rendering overhead

[Joel Richard (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482696#comment-14482696
 ] 

Joel Richard commented on SLING-4568:
-

[~cziegeler], the cache is bound to a resource resolver and will therefore not 
last longer than the resource resolver itself.

> Performance: MergingResourceProvider.ParentHidingHandler adds about 30% 
> rendering overhead
> --
>
> Key: SLING-4568
> URL: https://issues.apache.org/jira/browse/SLING-4568
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Merger 1.2.8
>Reporter: Joel Richard
>Priority: Critical
>  Labels: performance
> Attachments: SLING-4568.patch
>
>
> When I was analysing all read properties, I noticed a recurring pattern with 
> sling:hideChildren and jcr:primaryType and that more than 40% of the read 
> properties are sling:hideChildren. I figured out that sling:hideChildren is 
> read for all parents in MergingResourceProvider.ParentHidingHandler and that 
> the requests are processed 30-35% faster just by commenting out the 
> constructor code.
> Apache Benchmark results with normal ParentHidingHandler:
> {quote}
>   50%272
>   66%276
>   75%278
>   80%281
>   90%289
>   95%301
>   98%493
>   99%497
> {quote}
> Results with commented out ParentHidingHandler constructor: 
> {quote}
>   50%185
>   66%188
>   75%191
>   80%194
>   90%202
>   95%210
>   98%333
>   99%338
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[RESULT] [VOTE] Release Apache Sling Content Distribution Core version 0.1.1

[Tommaso Teofili]

Hi all,

The vote has passed with the following result :

+1 (binding): Carsten Ziegeler, Robert Munteanu, Daniel Kico
+1 (non binding): Tommaso Teofili, Marius Petria

I will take care of copying this release to the Sling dist directory and
promote the artifacts to the central Maven repository.

Regards,
Tommaso

2015-03-31 11:28 GMT+02:00 Tommaso Teofili :

> Hi all,
>
> This is the vote for the first Sling Content Distribution Core release
> 0.1.1.
>
> We solved 1 issues there:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12329868
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1223/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1223 /tmp/sling-staging
>
> Please cast your vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Thanks and regards,
> Tommaso
>

[jira] [Resolved] (SLING-4580) Remove extra null check for metadata

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-4580.
-
Resolution: Fixed
  Assignee: Carsten Ziegeler

Fixed the test and removed the extra null check in rev 1671746

> Remove extra null check for metadata
> 
>
> Key: SLING-4580
> URL: https://issues.apache.org/jira/browse/SLING-4580
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: i18n 2.4.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: i18n 2.4.2
>
>
> This check in JcrResourceBundle
> if (metadata != null) { // test does not implement metadata
> should be removed and the test be fixed as metadata at runtime is always not 
> null



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4568) Performance: MergingResourceProvider.ParentHidingHandler adds about 30% rendering overhead

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482675#comment-14482675
 ] 

Carsten Ziegeler commented on SLING-4568:
-

How does the cache get invalidated? What stops it from growing indefinitely?

> Performance: MergingResourceProvider.ParentHidingHandler adds about 30% 
> rendering overhead
> --
>
> Key: SLING-4568
> URL: https://issues.apache.org/jira/browse/SLING-4568
> Project: Sling
>  Issue Type: Bug
>  Components: ResourceResolver
>Affects Versions: Resource Merger 1.2.8
>Reporter: Joel Richard
>Priority: Critical
>  Labels: performance
> Attachments: SLING-4568.patch
>
>
> When I was analysing all read properties, I noticed a recurring pattern with 
> sling:hideChildren and jcr:primaryType and that more than 40% of the read 
> properties are sling:hideChildren. I figured out that sling:hideChildren is 
> read for all parents in MergingResourceProvider.ParentHidingHandler and that 
> the requests are processed 30-35% faster just by commenting out the 
> constructor code.
> Apache Benchmark results with normal ParentHidingHandler:
> {quote}
>   50%272
>   66%276
>   75%278
>   80%281
>   90%289
>   95%301
>   98%493
>   99%497
> {quote}
> Results with commented out ParentHidingHandler constructor: 
> {quote}
>   50%185
>   66%188
>   75%191
>   80%194
>   90%202
>   95%210
>   98%333
>   99%338
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4509) Job creation fails if combination of topic and name is too long on OAK

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4509.
---

> Job creation fails if combination of topic and name is too long on OAK
> --
>
> Key: SLING-4509
> URL: https://issues.apache.org/jira/browse/SLING-4509
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.5.4
>Reporter: Will McGauley
>Assignee: Carsten Ziegeler
> Fix For: Event 3.6.0
>
>
> OAK presents limits to the length of node names, intermediate path names, and 
> total path length (at least on MongoMK).  
> Job creation can fail if the combination of the topic length and job name are 
> too long.  The node name used for Jobs should probably be reduced in size by 
> some means so this no longer can occur, or likely wouldn't occur.
> see also OAK-2636 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4491) Potential NPE when JobManagerConfiguration is deactivated

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4491.
---

> Potential NPE when JobManagerConfiguration is deactivated
> -
>
> Key: SLING-4491
> URL: https://issues.apache.org/jira/browse/SLING-4491
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Event 3.5.0, Event 3.5.2, Event 3.5.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Event 3.6.0
>
>
> java.lang.NullPointerException: null
>   at 
> org.apache.sling.event.impl.jobs.config.JobManagerConfiguration.startProcessing(JobManagerConfiguration.java:500)
>   at 
> org.apache.sling.event.impl.jobs.config.JobManagerConfiguration.configurationChanged(JobManagerConfiguration.java:449)
>   at 
> org.apache.sling.event.impl.jobs.config.QueueConfigurationManager.updateListener(QueueConfigurationManager.java:195)
>   at 
> org.apache.sling.event.impl.jobs.config.QueueConfigurationManager.createConfigurationCache(QueueConfigurationManager.java:103)
>   at 
> org.apache.sling.event.impl.jobs.config.QueueConfigurationManager.unbindConfig(QueueConfigurationManager.java:77)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4487) Potential NPE in TimedEventSender

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4487.
---

> Potential NPE in TimedEventSender
> -
>
> Key: SLING-4487
> URL: https://issues.apache.org/jira/browse/SLING-4487
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 3.5.0, Event 3.5.2, Event 3.5.4
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Event 3.6.0
>
>
> When the background thread processes a resource added event, the resource 
> might already be gone again, which results in an NPE and the background 
> thread dies.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4481) Reduce the number of controller threads for queue

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4481.
---

> Reduce the number of controller threads for queue
> -
>
> Key: SLING-4481
> URL: https://issues.apache.org/jira/browse/SLING-4481
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: Event 3.5.2
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Event 3.6.0
>
>
> Right now each queue is using a controller thread which is not taken from a 
> pool. WIth a lot of queues this results in a lot of threads - although a 
> queue is only started if there is a job for that queue, this still can be a 
> significant number.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[VOTE RESULT] Release Apache Sling Event 3.6.0

[Carsten Ziegeler]

The vote passed with five binding +1 votes and 1 non binding +1 vote.

Thanks everyone for voting!

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Closed] (SLING-4510) Sling LogService could provide more usable output

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4510.
---

> Sling LogService could provide more usable output
> -
>
> Key: SLING-4510
> URL: https://issues.apache.org/jira/browse/SLING-4510
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Log Service 1.0.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Minor
> Fix For: Commons Log Service 1.0.4
>
> Attachments: SLING-4510.diff
>
>
> The Sling Log Service generates log messages when services change. However 
> the information in those log messages could be improved. For example the 
> following is a typical log message:
> {code}some.bsn Service [4242] ServiceEvent REGISTERED{code}
> It would be good to expand the log message to include the service's 
> ObjectClass so that you know which service is actually being registered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4552) Escape output in webconsole plugin

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4552.
---

> Escape output in webconsole plugin
> --
>
> Key: SLING-4552
> URL: https://issues.apache.org/jira/browse/SLING-4552
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Log 4.0.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Commons Log 4.0.2
>
>
> We should properly escape the output of the webconsole plugin



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-3705) Update Logback version to 1.1.2

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-3705.
---

> Update Logback version to 1.1.2
> ---
>
> Key: SLING-3705
> URL: https://issues.apache.org/jira/browse/SLING-3705
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Commons Log 4.0.2
>
>
> A new Logback release was done in April [1] 1.1.2. Of the fixes done 
> [LOGBACK-268|http://jira.qos.ch/browse/LOGBACK-268] looks useful and should 
> provide better performance in concurrent environment
> [1] http://logback.qos.ch/news.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4408) Support setting logger levels to Off

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4408.
---

> Support setting logger levels to Off
> 
>
> Key: SLING-4408
> URL: https://issues.apache.org/jira/browse/SLING-4408
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Log 4.0.0
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Commons Log 4.0.2
>
>
> Logback supports it, we just don't expose it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (SLING-4225) The root directory for Sling logging should be configurable explicitly

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-4225.
---

> The root directory for Sling logging should be configurable explicitly
> --
>
> Key: SLING-4225
> URL: https://issues.apache.org/jira/browse/SLING-4225
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Log 4.0.0
>Reporter: Jörg Hoh
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Commons Log 4.0.2
>
> Attachments: SLING-4225.patch
>
>
> The directory, which is used to resolve relative path names against, should 
> be configurable instead of always being ${sling.home}. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[VOTE RESULT] Release Apache Sling Commons Log 4.0.2 and Apache Sling Commons Log Service 1.0.4

[Carsten Ziegeler]

The vote passed with four binding +1 votes.

Thanks everyone!

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling i18n 2.4.0

[Carsten Ziegeler]

Am 05.04.15 um 21:49 schrieb Oliver Lietz:
> On Wednesday 01 April 2015 15:43:00 Carsten Ziegeler wrote:
>> Hi,
>>
>> We solved 3 issues for this release
>> https://issues.apache.org/jira/browse/SLING/fixforversion/12329265
> 
> This looks strange to me:
> 
> if (metadata != null) { // test does not implement metadata

This should be removed and the test should be fixed (SLING-4580).
However I don't
think this blocks the release. metadata is always not null.

> 
> Shouldn't we mock metadata in test instead?
> 
> And we (re)add a Jackrabbit dependency with this release.
> 
Args! This is definitely a regression. I've created SLING-4579 to fix this.
However, I don't think this blocks the release vote for 2.4.0. We can
easily fix it and then release 2.4.2

WDYT?

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Created] (SLING-4580) Remove extra null check for metadata

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-4580:
---

 Summary: Remove extra null check for metadata
 Key: SLING-4580
 URL: https://issues.apache.org/jira/browse/SLING-4580
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: i18n 2.4.0
Reporter: Carsten Ziegeler
 Fix For: i18n 2.4.2


This check in JcrResourceBundle
if (metadata != null) { // test does not implement metadata

should be removed and the test be fixed as metadata at runtime is always not 
null



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (SLING-4579) Regression introduced by SLING-4512 : JCR API used in i18n implementation

[Carsten Ziegeler (JIRA)]

Carsten Ziegeler created SLING-4579:
---

 Summary: Regression introduced by SLING-4512 : JCR API used in 
i18n implementation
 Key: SLING-4579
 URL: https://issues.apache.org/jira/browse/SLING-4579
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: i18n 2.4.0
Reporter: Carsten Ziegeler
Priority: Critical
 Fix For: i18n 2.4.2


The i18n module should be free from JCR API usage to allow it to run on any 
resources providing i18n messages. SLING-4512 unfortunately removed this 
functionality by directly using i18n API



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Jenkins build is unstable: sling-trunk-1.6 #3258

[Apache Jenkins Server]

See 

Jenkins build is back to stable : sling-trunk-1.7 #1649

[Apache Jenkins Server]

See 

Re: Build failed in Jenkins: sling-trunk-1.6 #3256

[Sandro Boehme]

Hi,

I reverted my changes in 'r1671740' and hope it fixes the build.

Best,

Sandro

Am 06.04.15 um 22:14 schrieb Sandro Boehme:

Hi,

somehow I managed to break the build of 'sling-trunk-1.6' by checking
something in to 'contrib/explorers/resourceeditor'. From what I
understand it should not have a dependency to that build, right?
It looks like an integration test of the Event Support project failed.
But I cannot reproduce it.
The failsafe plugin version has been updated at a commit before but the
build was blue.
Does someone have a pointer? The problem is, that I will probably have
no or not a good internet connection during the next 8 days. I will do
my best to fix it. I guess I will not commit short before a vacation again.

Best,

Sandro

Am 06.04.15 um 20:29 schrieb Apache Jenkins Server:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test
(default) on project org.apache.sling.event: Execution default of goal
org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test
failed: The forked VM terminated without saying properly goodbye. VM
crash or System.exit called ?
[ERROR] Command was/bin/sh -c cd

&& /home/jenkins/tools/java/jdk1.6.0_45-32/jre/bin/java -Xmx2048m
-XX:MaxPermSize=512m -jar

Build failed in Jenkins: sling-trunk-1.6 #3257

[Apache Jenkins Server]

See 

Changes:

[radu] releng: added Sightly to contrib reactor

[radu] SLING-4578 - Incorrect Sightly JS Use-API script dependency resolution

* explicitly check component inheritance when resolving script dependencies
* provided tests for Use API dependency inheritance
* made sure IT are run in the same order on all platforms

--
[...truncated 59913 lines...]
[INFO] Apache Sling JSON Library . SUCCESS [13.750s]
[INFO] Apache Sling SLF4J Implementation (Logback) ... SUCCESS [40.991s]
[INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [9.545s]
[INFO] Apache Sling MIME type mapping support  SUCCESS [11.162s]
[INFO] Apache Sling Commons OSGi support . SUCCESS [10.725s]
[INFO] Apache Sling Scheduler Support  SUCCESS [10.040s]
[INFO] Apache Sling Testing Utilities  SUCCESS [20.046s]
[INFO] Apache Sling Thread Dumper  SUCCESS [8.804s]
[INFO] Apache Sling Thread Support ... SUCCESS [9.537s]
[INFO] Apache Sling Authentication Service ... SUCCESS [10.531s]
[INFO] Apache Sling Form Based Authentication Handler  SUCCESS [16.897s]
[INFO] Apache Sling Engine Implementation  SUCCESS [24.848s]
[INFO] Apache Sling Repository API Bundle  SUCCESS [9.296s]
[INFO] Apache Sling Testing JCR Mock . SUCCESS [11.345s]
[INFO] Apache Sling JCR Base Bundle .. SUCCESS [11.578s]
[INFO] Apache Sling JCR ClassLoader .. SUCCESS [9.201s]
[INFO] Apache Sling Initial Content Loader ... SUCCESS [13.651s]
[INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [29.969s]
[INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [11.885s]
[INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support  SUCCESS 
[12.600s]
[INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [15.970s]
[INFO] Apache Sling JCR Resource Resolver  SUCCESS [41.846s]
[INFO] Apache Sling Testing Sling Mock Jackrabbit-based Resource Resolver  
SUCCESS [23.855s]
[INFO] Apache Sling Versioning Integration Tests . SUCCESS [22.406s]
[INFO] Apache Sling JCR Repository Registration .. SUCCESS [12.062s]
[INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [10.030s]
[INFO] Apache Sling DavEx Access to repositories . SUCCESS [18.938s]
[INFO] Apache Sling JCR WebConsole Bundle  SUCCESS [10.377s]
[INFO] Apache Sling Oak Repository Server  SUCCESS [12.440s]
[INFO] Apache Sling SlingRepository Integration Tests  SUCCESS [1:09.027s]
[INFO] Apache Sling Servlet Resolver . SUCCESS [18.058s]
[INFO] Apache Sling Default GET Servlets . SUCCESS [12.080s]
[INFO] Apache Sling Default POST Servlets  SUCCESS [13.509s]
[INFO] Apache Sling Compat Servlets .. SUCCESS [15.598s]
[INFO] Apache Sling Scripting Implementation API . SUCCESS [8.879s]
[INFO] Apache Sling Scripting Core implementation  SUCCESS [23.195s]
[INFO] Apache Sling Scripting JavaScript Support . SUCCESS [19.554s]
[INFO] Apache Sling Scripting JSP Support  SUCCESS [14.947s]
[INFO] Apache Sling JSP Tag Library .. SUCCESS [14.273s]
[INFO] Apache Sling JSP Standard Tag Library . SUCCESS [9.439s]
[INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [11.859s]
[INFO] Apache Sling Bundle Resource Provider . SUCCESS [10.580s]
[INFO] Apache Sling Distributed Event Admin .. SUCCESS [11.366s]
[INFO] Apache Sling Discovery API  SUCCESS [9.035s]
[INFO] Apache Sling Resource-Based Discovery Service . SUCCESS [4:32.098s]
[INFO] Apache Sling Discovery Support Bundle . SUCCESS [8.626s]
[INFO] Apache Sling Discovery Standalone Implementation .. SUCCESS [8.531s]
[INFO] Apache Sling Event Support  SUCCESS [12:13.815s]
[INFO] Apache Sling Feature Flags  SUCCESS [10.148s]
[INFO] Apache Sling Filesystem Resource Provider . SUCCESS [8.975s]
[INFO] Apache Sling javax.activation bundle .. SUCCESS [11.939s]
[INFO] Apache Sling Service User Mapper .. SUCCESS [11.053s]
[INFO] Apache Sling Settings . SUCCESS [9.821s]
[INFO] Apache Sling Web Console Branding . SUCCESS [9.140s]
[INFO] Apache Sling Web Console Security Provider  SUCCESS [9.845s]
[INFO] Apache Sling Explorer . SUCCESS [11.925s]
[INFO] Apache Sling Health Check Core  SUCCESS [15.807s]
[INFO] Apache Sling Health Check Annotations . SUCCESS [9.095s]
[INFO] Apache Sling Health Check Samples ..

Jenkins build is back to stable : sling-trunk-1.8 #938

[Apache Jenkins Server]

See 

Jenkins build became unstable: sling-trunk-1.7 #1648

[Apache Jenkins Server]

See 

[jira] [Resolved] (SLING-4578) Incorrect Sightly JS Use-API script dependency resolution

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-4578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-4578.
-
Resolution: Fixed

Fixed in [r1671688|https://svn.apache.org/r1671688].

> Incorrect Sightly JS Use-API script dependency resolution
> -
>
> Key: SLING-4578
> URL: https://issues.apache.org/jira/browse/SLING-4578
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Affects Versions: Scripting Sightly JS Use Provider 1.0.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
> Fix For: Scripting Sightly JS Use Provider 1.0.2
>
>
> A flaw in the Sightly JS Use-API script resolution can lead to errors in 
> initialising the JavaScript Use-API when the current executed component 
> provides a script with the same name as a dependency of the JavaScript 
> Use-API factories.
> The same error can happen to any other script from the execution flow that 
> has a sibling dependency with a name identical to a script provided by the 
> currently executed component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Build failed in Jenkins: sling-trunk-1.6 #3256

[Sandro Boehme]

Hi,

somehow I managed to break the build of 'sling-trunk-1.6' by checking 
something in to 'contrib/explorers/resourceeditor'. From what I 
understand it should not have a dependency to that build, right?
It looks like an integration test of the Event Support project failed. 
But I cannot reproduce it.
The failsafe plugin version has been updated at a commit before but the 
build was blue.
Does someone have a pointer? The problem is, that I will probably have 
no or not a good internet connection during the next 8 days. I will do 
my best to fix it. I guess I will not commit short before a vacation again.


Best,

Sandro

Am 06.04.15 um 20:29 schrieb Apache Jenkins Server:

[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test (default) 
on project org.apache.sling.event: Execution default of goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.16:integration-test failed: 
The forked VM terminated without saying properly goodbye. VM crash or 
System.exit called ?
[ERROR] Command was/bin/sh -c cd 
 && 
/home/jenkins/tools/java/jdk1.6.0_45-32/jre/bin/java -Xmx2048m -XX:MaxPermSize=512m -jar 

 

 

Build failed in Jenkins: sling-trunk-1.6 #3256

[Apache Jenkins Server]

See 

Changes:

[sboehme] SLING-4555 Resource Editor: fixed e2e tests, node name handling in 
the add node dialog and added an initial version of the add node e2e test

--
[...truncated 48421 lines...]
[INFO] Apache Sling OSGi LogService Implementation ... SUCCESS [4.836s]
[INFO] Apache Sling MIME type mapping support  SUCCESS [5.730s]
[INFO] Apache Sling Commons OSGi support . SUCCESS [5.272s]
[INFO] Apache Sling Scheduler Support  SUCCESS [4.440s]
[INFO] Apache Sling Testing Utilities  SUCCESS [17.019s]
[INFO] Apache Sling Thread Dumper  SUCCESS [4.168s]
[INFO] Apache Sling Thread Support ... SUCCESS [4.045s]
[INFO] Apache Sling Authentication Service ... SUCCESS [9.208s]
[INFO] Apache Sling Form Based Authentication Handler  SUCCESS [10.522s]
[INFO] Apache Sling Engine Implementation  SUCCESS [13.983s]
[INFO] Apache Sling Repository API Bundle  SUCCESS [6.224s]
[INFO] Apache Sling Testing JCR Mock . SUCCESS [5.498s]
[INFO] Apache Sling JCR Base Bundle .. SUCCESS [4.513s]
[INFO] Apache Sling JCR ClassLoader .. SUCCESS [3.454s]
[INFO] Apache Sling Initial Content Loader ... SUCCESS [11.830s]
[INFO] Apache Sling Jackrabbit Embedded Repository ... SUCCESS [16.057s]
[INFO] Apache Sling Jackrabbit UserManager Support ... SUCCESS [4.177s]
[INFO] Apache Sling Jackrabbit JSR-283 Access Control Manager Support  SUCCESS 
[3.873s]
[INFO] Apache Sling Wrapper Bundle for the JCR API ... SUCCESS [3.090s]
[INFO] Apache Sling JCR Resource Resolver  SUCCESS [36.481s]
[INFO] Apache Sling Testing Sling Mock Jackrabbit-based Resource Resolver  
SUCCESS [14.717s]
[INFO] Apache Sling Versioning Integration Tests . SUCCESS [10.242s]
[INFO] Apache Sling JCR Repository Registration .. SUCCESS [7.332s]
[INFO] Apache Sling Simple WebDAV Access to repositories . SUCCESS [7.086s]
[INFO] Apache Sling DavEx Access to repositories . SUCCESS [5.318s]
[INFO] Apache Sling JCR WebConsole Bundle  SUCCESS [3.542s]
[INFO] Apache Sling Oak Repository Server  SUCCESS [5.679s]
[INFO] Apache Sling SlingRepository Integration Tests  SUCCESS [50.579s]
[INFO] Apache Sling Servlet Resolver . SUCCESS [17.228s]
[INFO] Apache Sling Default GET Servlets . SUCCESS [4.552s]
[INFO] Apache Sling Default POST Servlets  SUCCESS [5.282s]
[INFO] Apache Sling Compat Servlets .. SUCCESS [3.713s]
[INFO] Apache Sling Scripting Implementation API . SUCCESS [3.828s]
[INFO] Apache Sling Scripting Core implementation  SUCCESS [11.951s]
[INFO] Apache Sling Scripting JavaScript Support . SUCCESS [11.548s]
[INFO] Apache Sling Scripting JSP Support  SUCCESS [10.252s]
[INFO] Apache Sling JSP Tag Library .. SUCCESS [8.450s]
[INFO] Apache Sling JSP Standard Tag Library . SUCCESS [6.704s]
[INFO] Apache Sling Adapter Manager Implementation ... SUCCESS [3.577s]
[INFO] Apache Sling Bundle Resource Provider . SUCCESS [3.998s]
[INFO] Apache Sling Distributed Event Admin .. SUCCESS [11.709s]
[INFO] Apache Sling Discovery API  SUCCESS [3.680s]
[INFO] Apache Sling Resource-Based Discovery Service . SUCCESS [4:36.912s]
[INFO] Apache Sling Discovery Support Bundle . SUCCESS [3.925s]
[INFO] Apache Sling Discovery Standalone Implementation .. SUCCESS [3.074s]
[INFO] Apache Sling Event Support  FAILURE [5:04.421s]
[INFO] Apache Sling Feature Flags  SKIPPED
[INFO] Apache Sling Filesystem Resource Provider . SKIPPED
[INFO] Apache Sling javax.activation bundle .. SKIPPED
[INFO] Apache Sling Service User Mapper .. SKIPPED
[INFO] Apache Sling Settings . SKIPPED
[INFO] Apache Sling Web Console Branding . SKIPPED
[INFO] Apache Sling Web Console Security Provider  SKIPPED
[INFO] Apache Sling Explorer . SKIPPED
[INFO] Apache Sling Health Check Core  SKIPPED
[INFO] Apache Sling Health Check Annotations . SKIPPED
[INFO] Apache Sling Health Check Samples . SKIPPED
[INFO] Apache Sling Health Check Support Components .. SKIPPED
[INFO] Apache Sling Health Check Webconsole Plugin ... SKIPPED
[INFO] Apache Sling Health Check JUnit Bridge  SKIPPED
[INFO] Apache Sling Health Check Integration Tests ... SKIPPED
[INFO] Apache Sling Health Check Reactor POM . SKIPPED
[INFO] Apache Sling Resource Access Security . SKIPPED
[INFO] Apach

Jenkins build became unstable: sling-trunk-1.8 #937

[Apache Jenkins Server]

See 

Re: build version numbering in sling jenkins build and debian package version number

[Bruce Edge]

From: Robert Munteanu mailto:romb...@apache.org>>
Reply-To: "dev@sling.apache.org" 
mailto:dev@sling.apache.org>>
Date: Monday, April 6, 2015 at 4:12 AM
To: "dev@sling.apache.org" 
mailto:dev@sling.apache.org>>
Subject: Re: build version numbering in sling jenkins build and debian package 
version number

Hi Bruce,

On Fri, 2015-03-27 at 21:28 +, Bruce Edge wrote:
I'd like to make the debian package that's built by jenkins have a unique 
version number that reflects the jenkins build number or some other meaningful 
version string.
Currently it's stuck at "8-SNAPSHOT" because this started off being tied to the 
launchpad build. It's not even related to launchpad any more, so I'd like to 
fix this versioning issue now.
( Side note question, should it be moved out from under 
contrib/launchpad/debian to contrib/debian as it's not related to launchpad 
anymore? )
What is the current mechanism used by the jenkins build to inject version 
numbers into pom files to obtain meaningful versions for the output artifacts?
I've always mvn -DBUILD_NUMBER=${BUILD_NUMBER} clean versions:set to set 
newVersion in the pom, but I don't see this used anywhere in the sling source 
tree.

We probably don't use this since BUILD_NUMBER does not exist outside of
Jenkins.

Lastly, once the .deb package is built with an appropriate version number, 
would it be possible to get this pushed to nexus as part of a release so that 
it's available as a downloadable artifact?
Nexus does support exposing debian packages as artifacts via the deb plugin, so 
my question is, could this be done, rather than "is it possible".

That's a question for infra I guess ( see [1] )

Robert

[1]: https://www.apache.org/dev/infra-contact


This issue has moved on to the next hurdle now.

WRT the version numbering, Tomasz figured out that we could use the maven jdeb 
plugin to extract a build number from the environment regardless of context.
It's currently configured to use:

true
BUILD_NUMBER

this uses the jenkins BUILD_NUMBER, if present, otherwise it expands to the 
SNAPSHOT equivalent, so it works for jenkins and local builds alike.

I just checked on the apache snapshots repo [1] and it's still not visible as 
an artifact, so I'm guessing that nexus is not configured to recognize .deb as 
a manageable artifact extension as this requires an additional nexus plugin [2].

I've emailed infrastruct...@apache.org requesting this. Please advise if there 
is a better contact email for this request.

Although, I did just notice that the current release on nexus is from before 
this change went into the codebase, so it may be that it'll just show up on the 
next release.

[1] 
https://repository.apache.org/content/repositories/snapshots/org/apache/sling/sling-server/8-SNAPSHOT/
[2] https://github.com/inventage/nexus-apt-plugin

-Bruce

[jira] [Commented] (SLING-4447) Improve JavaUseProvider to not fall back to a simple Pojo instantiation in case a Java class with @Model annotation cannot be instantiated

[Radu Cotescu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481332#comment-14481332
 ] 

Radu Cotescu commented on SLING-4447:
-

Besides [~sseif...@pro-vision.de]'s suggestion you should also clean the code 
in order to not use implementation classes from Sightly \[0\]\[1\].

\[0\] - 
https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java#L34
\[1\] - 
https://github.com/apache/sling/blob/trunk/bundles/extensions/models/impl/src/main/java/org/apache/sling/models/impl/sightly/ModelFactoryUseProvider.java#L80

> Improve JavaUseProvider to not fall back to a simple Pojo instantiation in 
> case a Java class with @Model annotation cannot be instantiated
> --
>
> Key: SLING-4447
> URL: https://issues.apache.org/jira/browse/SLING-4447
> Project: Sling
>  Issue Type: Improvement
>  Components: Scripting
>Affects Versions: Scripting Sightly Engine 1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Sling Models Impl 1.2.0
>
> Attachments: SLING-4447-v01.patch
>
>
> Currently in case a Java class is a Sling Model (i.e. has the Model 
> annotation) and cannot be instantiated (e.g. required injections not 
> possible) Sightly falls back to instantiate those as simple Pojos.
> This is never good, since a lot of NullPointerException might happen because 
> all injections have not been performed then.
> Therefore in the following code should be used instead 
> {code}
> if (modelFactory.isModelClass(resource, cls)) {
>   if (modelFactory.canCreateFromAdaptable(resource, cls)) {
> obj = modelFactory.createModel(resource, cls);
>   } else if (modelFactory.canCreateFromAdaptable(request, cls)) {
> obj = modelFactory.createModel(request, cls);
>   } else {
> throw new IllegalStateException("Could not adapt the given Sling Model 
> from neither resource nor request: " + cls);
>   }
> }
> {code}
> That way, exceptions would be propagated in case a Sling model cannot be 
> instantiated and developers more easily see why the Sling Model does not work 
> (instead of running into NullPointerExceptions in their model because it was 
> instantiated as simple Pojo)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: / and /contrib, what goes where and when is stuff 'promoted' and 'demoted'

[Bertrand Delacretaz]

hi Robert,

You're right that this deserves to be clarified.

On Mon, Apr 6, 2015 at 1:06 PM, Robert Munteanu  wrote:
> ...- there are both technical and community requirements for moving stuff
> from /contrib to / , see Bertrand's comment at [1]..

Yes, IMO the main thing is that whatever's not under contrib is
supposed to be maintained, reacting to patch submissions, making
regular releases etc.

OTOH the /contrib modules are maintained on a ad hoc basis, but it's
fine to let them rot for a while if nobody's interested at the moment.

So my criteria for moving something out of contrib is to have several
committers willing to support it (so that collectively we provide good
support) and good test coverage as an objective measurement of the
code's quality.

> - we seem to favour not building links from / to /contrib [2]

Correct, if a non-contrib module depends on  a contrib one, the result
is not guaranteed to be maintained so it should go to contrib ;-)

-Bertrand

Re: [jira] [Commented] (SLING-3987) move from Subversion to Git

[Bruce Edge]

From: Robert Munteanu mailto:romb...@apache.org>>
Reply-To: "dev@sling.apache.org" 
mailto:dev@sling.apache.org>>
Date: Monday, April 6, 2015 at 3:42 AM
To: "dev@sling.apache.org" 
mailto:dev@sling.apache.org>>
Subject: Re: [jira] [Commented] (SLING-3987) move from Subversion to Git

On Mon, 2015-04-06 at 05:35 +, Bruce Edge wrote:
As I understand it, we want to pull in the master version of each
sub-module, not a specific version. This would be analogous a single
trunk checkout that we have today. The build-time bindings will still
be defined in launchpad(s), as they are to day.
Robert
git submodule update does have a -recurse option:
this command will recurse into the registered submodules, and update any nested 
submodules within.
It's just not the default.

I'm not sure I follow. AFAIU submodules ask you to specify a certain
commit for a submodule, like cafebabe or 1234baab . It does not support
symbolic refs like origin/master .

The best that I could find is something like [1]

$ git submodule foreach git pull origin master

Assuming that we have a module named 'build' that aggregates all the
submodules, for each commit to a submodule I would need to update
the .gitmodules file and then commit the change to the 'build' repo.

With gitslave or similar tools the second step is not needed.

Robert

[1]:
http://stackoverflow.com/questions/5828324/update-git-submodule-to-latest-commit-on-origin


I haven't tested it, but this should work for your use case:

git submodule update --remote -merge

The -remote option uses the remote's tracking branch to obtain the SHA-1 rather 
than the superproject's and defaults to master. It will do an implicit fetch of 
the remote branch to determine the current head prior to merging with the 
current superproject's current head of that submodule.

-Bruce

[jira] [Created] (SLING-4578) Incorrect Sightly JS Use-API script dependency resolution

[Radu Cotescu (JIRA)]

Radu Cotescu created SLING-4578:
---

 Summary: Incorrect Sightly JS Use-API script dependency resolution
 Key: SLING-4578
 URL: https://issues.apache.org/jira/browse/SLING-4578
 Project: Sling
  Issue Type: Bug
  Components: Scripting
Affects Versions: Scripting Sightly JS Use Provider 1.0.0
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: Scripting Sightly JS Use Provider 1.0.2


A flaw in the Sightly JS Use-API script resolution can lead to errors in 
initialising the JavaScript Use-API when the current executed component 
provides a script with the same name as a dependency of the JavaScript Use-API 
factories.

The same error can happen to any other script from the execution flow that has 
a sibling dependency with a name identical to a script provided by the 
currently executed component.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (SLING-4026) Adapter Factory Race Condition

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14481140#comment-14481140
 ] 

Robert Munteanu commented on SLING-4026:


You could use the mechanism added in SLING-4217 , e.g. wait for an {{Adaption}} 
service to be registered ( org.apache.sling.adapter 2.1.4 or newer ), e.g.

{code:java}@Reference(referenceInterface = Adaption.class, name = 
"$$scr$$ignore0", strategy = LOOKUP, target = 
"(&(adaptables=com.example.SlingModelExample.class)(adapters=com.example.ExampleComponent))"),{code}

> Adapter Factory Race Condition
> --
>
> Key: SLING-4026
> URL: https://issues.apache.org/jira/browse/SLING-4026
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Adapter 2.1.2
>Reporter: JBodkin
>  Labels: models
> Attachments: racer.zip
>
>
> During initialization of a bundle, it is possible to encounter a race 
> condition in which the BundleTrackerCustomizer::addingBundle(Bundle bundle, 
> BundleEvent event) is triggered after the bundle has begun initialization of 
> a immediate component.
> {code:java}
> @Component(immediate = true)
> @Service
> public class ExampleImpl {
> @Activate
> public void activate(ComponentContext context) {
> Resource resource = 
> // Race condition possible here... Could be executed before the 
> BundleTracker (ModelPackageBundleListener)
> SlingModelExample example = resource.adaptTo(SlingModelExample);
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: build version numbering in sling jenkins build and debian package version number

[Robert Munteanu]

Hi Bruce,

On Fri, 2015-03-27 at 21:28 +, Bruce Edge wrote:
> I'd like to make the debian package that's built by jenkins have a unique 
> version number that reflects the jenkins build number or some other 
> meaningful version string.
> Currently it's stuck at "8-SNAPSHOT" because this started off being tied to 
> the launchpad build. It's not even related to launchpad any more, so I'd like 
> to fix this versioning issue now.
> 
> ( Side note question, should it be moved out from under 
> contrib/launchpad/debian to contrib/debian as it's not related to launchpad 
> anymore? )
> 
> What is the current mechanism used by the jenkins build to inject version 
> numbers into pom files to obtain meaningful versions for the output artifacts?
> 
> I've always mvn -DBUILD_NUMBER=${BUILD_NUMBER} clean versions:set to set 
> newVersion in the pom, but I don't see this used anywhere in the sling source 
> tree.

We probably don't use this since BUILD_NUMBER does not exist outside of
Jenkins.

> 
> Lastly, once the .deb package is built with an appropriate version number, 
> would it be possible to get this pushed to nexus as part of a release so that 
> it's available as a downloadable artifact?
> Nexus does support exposing debian packages as artifacts via the deb plugin, 
> so my question is, could this be done, rather than "is it possible".

That's a question for infra I guess ( see [1] )

Robert

[1]: https://www.apache.org/dev/infra-contact

Re: requirements for including Sightly into Sling Launchpad

[Robert Munteanu]

On Mon, Apr 6, 2015 at 12:55 AM, Radu Cotescu  wrote:
>
> I'm definitely not in favour of snapshot dependencies in the launchpad, so
> we're on the same page here.
>
> What do you mean by tangled dependencies? I know that the launchpad usually
> doesn't contain bundles from contrib so I was thinking about what you're
> suggesting but I just wanted somebody from the PMC to say it.

Tangled is probably not the best word, but for now I'd like to avoid
dependencies from contrib in the main build.

I think it's best if we kept 'Sling-internal' dependencies in the same
reactor and SNAPSHOT if needed, as it's the fastest way to get an
up-to-date launchpad and also to run the integration tests.

I've started a different thread about this, my reply to Oliver's email.

Cheers,

Robert

Re: requirements for including Sightly into Sling Launchpad

[Robert Munteanu]

On Mon, Apr 6, 2015 at 10:58 AM, Oliver Lietz  wrote:
> On Sunday 05 April 2015 21:55:31 Radu Cotescu wrote:
>> Hi Robert,
>
> Hi,
>
>> I'm definitely not in favour of snapshot dependencies in the launchpad, so
>> we're on the same page here.
>>
>> What do you mean by tangled dependencies? I know that the launchpad usually
>> doesn't contain bundles from contrib so I was thinking about what you're
>> suggesting but I just wanted somebody from the PMC to say it.
>
> _contrib_ came to my mind after sending my last mail. What are the plans for
> Sling Start/Launchpad regarding artifacts from contrib? Do we want Sling
> Start/Launchpad to only contain artifacts from bundles onwards and users
> should build their own distributions? Shouldn't be too hard with the new Sling
> Start.

I've started another discussion thread for this, see

"/ and /contrib, what goes where and when is stuff 'promoted' and 'demoted'" [1]

Robert

[1]: http://sling-dev.markmail.org/thread/74ode3yei62cugxv

/ and /contrib, what goes where and when is stuff 'promoted' and 'demoted'

[Robert Munteanu]

Hi,

It seems that this subject keeps popping up, and I'd like to get a
clearer image about how we split stuff between / ( aka 'the main build'
) and /contrib .

What I could gather for now is:

- there are both technical and community requirements for moving stuff
from /contrib to / , see Bertrand's comment at [1]
- we seem to favour not building links from / to /contrib [2]

I think it would be beneficial if someone who already knows this stuff
would share the criteria - if any - so we can document when in the Sling
wiki.

Just to be clear, I'm not trying to change the policy, just to clarify
what the policy is.

Thanks,

Robert


[1]:
https://issues.apache.org/jira/browse/SLING-4161?focusedCommentId=14383711&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14383711
[2]: http://sling-dev.markmail.org/thread/ziazp6mdhij747qq

Re: [jira] [Commented] (SLING-3987) move from Subversion to Git

[Robert Munteanu]

On Mon, 2015-04-06 at 05:35 +, Bruce Edge wrote:
> 
> As I understand it, we want to pull in the master version of each
> sub-module, not a specific version. This would be analogous a single
> trunk checkout that we have today. The build-time bindings will still
> be defined in launchpad(s), as they are to day.
> 
> Robert
> 
> git submodule update does have a -recurse option:
> this command will recurse into the registered submodules, and update any 
> nested submodules within.
> 
> It's just not the default.
> 

I'm not sure I follow. AFAIU submodules ask you to specify a certain
commit for a submodule, like cafebabe or 1234baab . It does not support
symbolic refs like origin/master .

The best that I could find is something like [1]

$ git submodule foreach git pull origin master

Assuming that we have a module named 'build' that aggregates all the
submodules, for each commit to a submodule I would need to update
the .gitmodules file and then commit the change to the 'build' repo.

With gitslave or similar tools the second step is not needed.

Robert

[1]:
http://stackoverflow.com/questions/5828324/update-git-submodule-to-latest-commit-on-origin

Re: need access to Jenkins for setting up Sightly CI job

[Robert Munteanu]

On Sun, 2015-04-05 at 22:03 +, Radu Cotescu wrote:
> Hi Robert,
> 
> Sightly doesn't appear to be built with all the contrib modules [0].

It should be so feel free to include it. 

Robert

> 
> Cheers,
> Radu
> 
> [0] - https://github.com/apache/sling/blob/trunk/contrib/pom.xml
> 
> 
> On Mon 6 Apr 2015 at 00:41 Robert Munteanu  wrote:
> 
> > Hi Radu,
> >
> > On Sat, Apr 4, 2015 at 6:00 PM, Radu Cotescu  wrote:
> > > Hi,
> > >
> > > I'd like to set up a Jenkins job for Sightly in order to make sure that
> > > changes affecting the codebase don't actually break stuff.
> >
> > Isn't Sightly already part of the contrib build?
> >
> > >
> > > Can somebody from the PMC please add my user to the hudson-jobadmin
> > group?
> >
> > That would be the PMC chair, not any PMC members.
> >
> > Robert
> >

Re: requirements for including Sightly into Sling Launchpad

[Oliver Lietz]

On Sunday 05 April 2015 21:55:31 Radu Cotescu wrote:
> Hi Robert,

Hi,

> I'm definitely not in favour of snapshot dependencies in the launchpad, so
> we're on the same page here.
> 
> What do you mean by tangled dependencies? I know that the launchpad usually
> doesn't contain bundles from contrib so I was thinking about what you're
> suggesting but I just wanted somebody from the PMC to say it.

_contrib_ came to my mind after sending my last mail. What are the plans for 
Sling Start/Launchpad regarding artifacts from contrib? Do we want Sling 
Start/Launchpad to only contain artifacts from bundles onwards and users 
should build their own distributions? Shouldn't be too hard with the new Sling 
Start.

Regards,
O.

> Cheers,
> Radu
> 
> On Mon 6 Apr 2015 at 00:46 Robert Munteanu  wrote:
> > On Sat, Apr 4, 2015 at 7:19 PM, Radu Cotescu  wrote:
> > > Hi,
> > > 
> > > Given the recent improvements of the Sightly implementation from Sling I
> > > think that having this scripting engine in the launchpad would be a nice
> > > feature.
> > 
> > Sounds OK to me, as long as we don't introduce SNAPSHOT dependencies,
> > as they will not be buildable in the same reactor.
> > 
> > Wouldn't it be clearer though to move sightly and all its dependencies
> > to /bundles/? I have a documented uneasy feeling about tangled
> > dependencies between our reactor builds.
> > 
> > Cheers,
> > 
> > Robert
> > 
> > > What are the requirements for including Sightly into the launchpad? The
> > > following would be the list of bundles that need to be added
> > > to launchpad/slingstart/src/main/provisioning/sling.txt:
> > > 
> > > # xss
> > > javax.mail/mail/1.4.7
> > > org.apache.sling/org.apache.sling.xss/1.0.2 # contrib/extensions/xss
> > > # i18n
> > > org.apache.sling/org.apache.sling.i18n/2.3.2 # contrib/extensions/i18n
> > > # jcr compiler
> > > org.apache.sling/org.apache.sling.jcr.compiler/2.1.0 #
> > 
> > contrib/jcr/compiler
> > 
> > > # sightly
> > > org.apache.sling/org.apache.sling.scripting.sightly/1.0.0
> > > #contrib/scripting/sightly
> > > org.apache.sling/org.apache.sling.scripting.sightly.js.provider/1.0.0
> > > #contrib/scripting/sightly
> > > org.apache.sling/org.apache.sling.scripting.sightly.repl/1.0.0
> > > #contrib/scripting/sightly
> > > 
> > > Cheers,
> > > Radu
> > 
> > --
> > Sent from my (old) computer