[jira] [Reopened] (SLING-6002) ScriptCacheImpl should move to new ResourceChangeListener API

2016-10-08 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-6002:
-

With SLING-6123 in place, we can get rid of getting the search path from the 
resource resolver

> ScriptCacheImpl should move to new ResourceChangeListener API 
> --
>
> Key: SLING-6002
> URL: https://issues.apache.org/jira/browse/SLING-6002
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Hanish Bansal
>Assignee: Carsten Ziegeler
> Fix For: Scripting Core 2.0.40
>
> Attachments: Patch.txt
>
>
> org.apache.sling.scripting.core.impl.ScriptCacheImpl currently implements 
> org.osgi.service.event.EventHandler Interface. We should start using the new 
> ResourceChangeListener API.
> See [0] for details :
> https://issues.apache.org/jira/browse/SLING-5994



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (SLING-6001) ProcessorManagerImpl should move to new ResourceChangeListener API

2016-10-08 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-6001:
-

With SLING-6123 in place, we can get rid of getting the search path from the 
resource resolver

> ProcessorManagerImpl should move to new ResourceChangeListener API
> ---
>
> Key: SLING-6001
> URL: https://issues.apache.org/jira/browse/SLING-6001
> Project: Sling
>  Issue Type: Task
>  Components: Extensions
>Reporter: Hanish Bansal
>Assignee: Carsten Ziegeler
> Fix For: Rewriter 1.1.6
>
> Attachments: patch.txt
>
>
> org.apache.sling.rewriter.impl.ProcessorManagerImpl currently implements 
> org.osgi.service.event.EventHandler Interface. We should start using the new 
> ResourceChangeListener API.
> See [0] for details :
> https://issues.apache.org/jira/browse/SLING-5994



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (SLING-5999) JcrResourceBundleProvider should move to new ResourceChangeListener API

2016-10-08 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-5999.
---

> JcrResourceBundleProvider should move to new ResourceChangeListener API   
> 
>
> Key: SLING-5999
> URL: https://issues.apache.org/jira/browse/SLING-5999
> Project: Sling
>  Issue Type: Task
>  Components: i18n
>Reporter: Hanish Bansal
>Assignee: Carsten Ziegeler
> Fix For: i18n 2.5.4
>
>
> org.apache.sling.i18n.impl.JcrResourceBundleProvider currently implements 
> org.osgi.service.event.EventHandler Interface. We should start using the new 
> ResourceChangeListener API.
> See [0] for details :
> https://issues.apache.org/jira/browse/SLING-5994



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[VOTE RESULT] Release Apache Sling i18n 2.5.4

2016-10-08 Thread Carsten Ziegeler
The vote passes with three binding +1 votes

 Thanks

Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org



[jira] [Resolved] (SLING-6123) Pass additional information like the search path to the listeners

2016-10-08 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-6123.
-
Resolution: Fixed

Implemented new list type and also make sure that the list is not mutable in 
rev 1763899

> Pass additional information like the search path to the listeners
> -
>
> Key: SLING-6123
> URL: https://issues.apache.org/jira/browse/SLING-6123
> Project: Sling
>  Issue Type: Sub-task
>  Components: API, ResourceResolver
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: API 2.15.0, Resource Resolver 1.4.20
>
>
> Some listeners registers themselve with the special token "." for the search 
> paths, however when they process the event, they have no clue about the 
> search path and it's ordering.
> We could pass the search path as an additional information to the resource 
> change listener



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6123) Pass additional information like the search path to the listeners

2016-10-08 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557982#comment-15557982
 ] 

Carsten Ziegeler commented on SLING-6123:
-

Added the new API in rev 1763898

> Pass additional information like the search path to the listeners
> -
>
> Key: SLING-6123
> URL: https://issues.apache.org/jira/browse/SLING-6123
> Project: Sling
>  Issue Type: Sub-task
>  Components: API, ResourceResolver
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: API 2.15.0, Resource Resolver 1.4.20
>
>
> Some listeners registers themselve with the special token "." for the search 
> paths, however when they process the event, they have no clue about the 
> search path and it's ordering.
> We could pass the search path as an additional information to the resource 
> change listener



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6123) Pass additional information like the search path to the listeners

2016-10-08 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557979#comment-15557979
 ] 

Carsten Ziegeler commented on SLING-6123:
-

We can add a new type ResourceChangeList which extends List
Unfortunately we can't simply change the onChange method as this would not be 
source compatible
However, we can document that the passed in list is of type ResourceChangeList, 
not as nice, but still good enough

> Pass additional information like the search path to the listeners
> -
>
> Key: SLING-6123
> URL: https://issues.apache.org/jira/browse/SLING-6123
> Project: Sling
>  Issue Type: Sub-task
>  Components: API, ResourceResolver
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: API 2.15.0, Resource Resolver 1.4.20
>
>
> Some listeners registers themselve with the special token "." for the search 
> paths, however when they process the event, they have no clue about the 
> search path and it's ordering.
> We could pass the search path as an additional information to the resource 
> change listener



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6123) Pass additional information like the search path to the listeners

2016-10-08 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-6123:
---

 Summary: Pass additional information like the search path to the 
listeners
 Key: SLING-6123
 URL: https://issues.apache.org/jira/browse/SLING-6123
 Project: Sling
  Issue Type: Sub-task
  Components: API, ResourceResolver
Reporter: Carsten Ziegeler
Assignee: Carsten Ziegeler
 Fix For: API 2.15.0, Resource Resolver 1.4.20


Some listeners registers themselve with the special token "." for the search 
paths, however when they process the event, they have no clue about the search 
path and it's ordering.
We could pass the search path as an additional information to the resource 
change listener



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-6122) sling pipes javadoc fails

2016-10-08 Thread Nicolas Peltier (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-6122:
---
Attachment: SLING-6122.patch

fix is in the attached patch

> sling pipes javadoc fails
> -
>
> Key: SLING-6122
> URL: https://issues.apache.org/jira/browse/SLING-6122
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Pipes 0.0.10
>Reporter: Nicolas Peltier
> Attachments: SLING-6122.patch
>
>
> sling pipes javadoc fails, preventing release to be done



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: pipes release 0.0.10

2016-10-08 Thread Nicolas Peltier
Please find issue with patch attached here: 
https://issues.apache.org/jira/browse/SLING-6122
> On Oct 5, 2016, at 8:01 PM, Oliver Lietz  wrote:
> 
> On Wednesday 05 October 2016 16:13:50 Nicolas Peltier wrote:
>> looks like you didn’t push the refactors you were talking about (moving
>> things to impl mostly)
> is a patch on the older version still good? or
>> would you like me to do the refactor as well? 
> 
> Check out from ASF SVN, looks like GitHub sync is still broken.
> 
> O.
> 



[jira] [Created] (SLING-6122) sling pipes javadoc fails

2016-10-08 Thread Nicolas Peltier (JIRA)
Nicolas Peltier created SLING-6122:
--

 Summary: sling pipes javadoc fails
 Key: SLING-6122
 URL: https://issues.apache.org/jira/browse/SLING-6122
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Pipes 0.0.10
Reporter: Nicolas Peltier


sling pipes javadoc fails, preventing release to be done



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6121) Clarify glob pattern handling and support globs and search paths

2016-10-08 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557929#comment-15557929
 ] 

Carsten Ziegeler commented on SLING-6121:
-

[~radu.cotescu] Could you please comment on the questions?

> Clarify glob pattern handling and support globs and search paths
> 
>
> Key: SLING-6121
> URL: https://issues.apache.org/jira/browse/SLING-6121
> Project: Sling
>  Issue Type: Sub-task
>  Components: API, JCR, ResourceResolver
>Reporter: Carsten Ziegeler
> Fix For: JCR Resource 2.8.2, API 2.15.0, Resource Resolver 1.4.20
>
>
> Looking at the documentation of the glob pattern it is a little bit unclear 
> to me:
> Does the part after the prefix "glob:" need to start with a "/" ? If not, 
> what does it mean?
> Is the special token for search paths supported, e.g. glob:./foo/**/*.html ?
> If not, we should implement this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6121) Clarify glob pattern handling and support globs and search paths

2016-10-08 Thread Carsten Ziegeler (JIRA)
Carsten Ziegeler created SLING-6121:
---

 Summary: Clarify glob pattern handling and support globs and 
search paths
 Key: SLING-6121
 URL: https://issues.apache.org/jira/browse/SLING-6121
 Project: Sling
  Issue Type: Sub-task
  Components: API, JCR, ResourceResolver
Reporter: Carsten Ziegeler
 Fix For: JCR Resource 2.8.2, API 2.15.0, Resource Resolver 1.4.20


Looking at the documentation of the glob pattern it is a little bit unclear to 
me:
Does the part after the prefix "glob:" need to start with a "/" ? If not, what 
does it mean?

Is the special token for search paths supported, e.g. glob:./foo/**/*.html ?
If not, we should implement this



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (SLING-6007) XSSFilterImpl should move to new ResourceChangeListener API

2016-10-08 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler reopened SLING-6007:
-

[~radu.cotescu] I think you mentioned that one of the patterns is not correct?

> XSSFilterImpl should move to new ResourceChangeListener API   
> 
>
> Key: SLING-6007
> URL: https://issues.apache.org/jira/browse/SLING-6007
> Project: Sling
>  Issue Type: Task
>  Components: XSS Protection API
>Reporter: Hanish Bansal
>Assignee: Carsten Ziegeler
> Fix For: XSS Protection API 1.0.16
>
> Attachments: SLING-6007.txt
>
>
> org.apache.sling.xss.impl.XSSFilterImpl currently implements 
> org.osgi.service.event.EventHandler Interface. We should start using the new 
> ResourceChangeListener API.
> See [0] for details :
> https://issues.apache.org/jira/browse/SLING-5994



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-6120) Collect logger names which get hit for a given request thread

2016-10-08 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved SLING-6120.

Resolution: Fixed

Now a {{loggerNames}} array would be part of recording which would have name of 
loggers

{code:javascript}
 "loggerNames": [
"org.apache.jackrabbit.oak.cache.CacheLIRS",
"org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate",
"org.apache.jackrabbit.oak.jcr.operations.query",
"org.apache.jackrabbit.oak.jcr.operations.reads",
"org.apache.jackrabbit.oak.jcr.operations.writes",
"org.apache.jackrabbit.oak.plugins.index.lucene.IndexPlanner",
"org.apache.jackrabbit.oak.plugins.index.property.PropertyIndex",
"org.apache.jackrabbit.oak.query.QueryEngineImpl",
"org.apache.jackrabbit.oak.query.QueryImpl",
"org.apache.jackrabbit.oak.query.SQL2Parser",

"org.apache.jackrabbit.oak.security.authentication.LoginContextProviderImpl",

"org.apache.jackrabbit.oak.security.authorization.composite.CompositeAuthorizationConfiguration",

"org.apache.jackrabbit.oak.security.authorization.permission.PermissionStoreImpl",
"org.apache.sling.adapter.internal.AdapterManagerImpl",
"org.apache.sling.commons.compiler.impl.EclipseJavaCompiler",
"org.apache.sling.commons.fsclassloader.impl.FSClassLoaderProvider",
"org.apache.sling.engine.impl.debug.RequestProgressTrackerLogFilter",
"org.apache.sling.engine.impl.request.RequestData",
"org.apache.sling.i18n.impl.JcrResourceBundle",
"org.apache.sling.i18n.impl.JcrResourceBundleProvider",
"org.apache.sling.jcr.resource.internal.JcrSystemUserValidator",
"org.apache.sling.jcr.resource.internal.helper.jcr.JcrItemResourceFactory",
"org.apache.sling.jcr.resource.internal.helper.jcr.JcrNodeResourceIterator",
"org.apache.sling.resourceresolver.impl.ResourceResolverImpl",
"org.apache.sling.resourceresolver.impl.helper.ResourceResolverControl",
"org.apache.sling.rewriter.impl.PipelineImpl",
"org.apache.sling.scripting.core.impl.BindingsValuesProvidersByContextImpl",
"org.apache.sling.scripting.core.impl.DefaultSlingScript",
"org.apache.sling.scripting.jsp.jasper.compiler.Compiler",
"org.apache.sling.scripting.jsp.jasper.compiler.SmapUtil$SDEInstaller",
"org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper",
"org.apache.sling.scripting.jsp.taglib.AbstractDispatcherTagHandler",
"org.apache.sling.servlets.resolver.internal.SlingServletResolver",
"org.eclipse.jetty.io.ChannelEndPoint",
"org.eclipse.jetty.server.HttpConnection"
  ]
{code}

Done with r1763885

> Collect logger names which get hit for a given request thread
> -
>
> Key: SLING-6120
> URL: https://issues.apache.org/jira/browse/SLING-6120
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
> Fix For: Log Tracer 1.0.2
>
>
> To allow better discovery to determine logger names to enabled it would be 
> good to collect name of loggers which get invoked as part of given request 
> processing. 
> These loggers need not log but they might be just check if given logging 
> level is enabled or not. We can collect such logger names and report back as 
> part of recording to allow end user an option to enable "interesting ones"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-6119) Log parameters not captured correctly in few cases

2016-10-08 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved SLING-6119.

Resolution: Fixed

Done with r1763884

> Log parameters not captured correctly in few cases
> --
>
> Key: SLING-6119
> URL: https://issues.apache.org/jira/browse/SLING-6119
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
>
> Tracer also captures the log message parameters separately and provides 
> string representation in recording. In some cases where params are bound to 
> say JCR session there evaluation fails if done outside of session. This 
> causes message like
> {noformat}
> {
> timestamp: 1475920906003,
> level: "TRACE",
> logger: "org.apache.jackrabbit.oak.jcr.operations.writes",
> message: "[session-1987] Setting property 
> [/content/dam/summer_collection/jcr:content/jcr:title]",
> params: [
> "session-1987",
> "[FAILED toString()]"
> ]
> }
> {noformat}
> As a fix the param should be converted to string at time of logging itself



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6120) Collect logger names which get hit for a given request thread

2016-10-08 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created SLING-6120:
--

 Summary: Collect logger names which get hit for a given request 
thread
 Key: SLING-6120
 URL: https://issues.apache.org/jira/browse/SLING-6120
 Project: Sling
  Issue Type: New Feature
  Components: Extensions
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
 Fix For: Log Tracer 1.0.2


To allow better discovery to determine logger names to enabled it would be good 
to collect name of loggers which get invoked as part of given request 
processing. 

These loggers need not log but they might be just check if given logging level 
is enabled or not. We can collect such logger names and report back as part of 
recording to allow end user an option to enable "interesting ones"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-6119) Log parameters not captured correctly in few cases

2016-10-08 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated SLING-6119:
---
Summary: Log parameters not captured correctly in few cases  (was: Log 
parameters not captures correctly in few cases)

> Log parameters not captured correctly in few cases
> --
>
> Key: SLING-6119
> URL: https://issues.apache.org/jira/browse/SLING-6119
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
>
> Tracer also captures the log message parameters separately and provides 
> string representation in recording. In some cases where params are bound to 
> say JCR session there evaluation fails if done outside of session. This 
> causes message like
> {noformat}
> {
> timestamp: 1475920906003,
> level: "TRACE",
> logger: "org.apache.jackrabbit.oak.jcr.operations.writes",
> message: "[session-1987] Setting property 
> [/content/dam/summer_collection/jcr:content/jcr:title]",
> params: [
> "session-1987",
> "[FAILED toString()]"
> ]
> }
> {noformat}
> As a fix the param should be converted to string at time of logging itself



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6119) Log parameters not captures correctly in few cases

2016-10-08 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created SLING-6119:
--

 Summary: Log parameters not captures correctly in few cases
 Key: SLING-6119
 URL: https://issues.apache.org/jira/browse/SLING-6119
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor
 Fix For: Log Tracer 1.0.2


Tracer also captures the log message parameters separately and provides string 
representation in recording. In some cases where params are bound to say JCR 
session there evaluation fails if done outside of session. This causes message 
like

{noformat}
{
timestamp: 1475920906003,
level: "TRACE",
logger: "org.apache.jackrabbit.oak.jcr.operations.writes",
message: "[session-1987] Setting property 
[/content/dam/summer_collection/jcr:content/jcr:title]",
params: [
"session-1987",
"[FAILED toString()]"
]
}
{noformat}

As a fix the param should be converted to string at time of logging itself



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-5762) Relax Sling Log Tracer package imports

2016-10-08 Thread Chetan Mehrotra (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557631#comment-15557631
 ] 

Chetan Mehrotra commented on SLING-5762:


[~empire29] Can you give [attached 
snapshot|^org.apache.sling.tracer-1.0.1-SNAPSHOT.jar] a try to confirm this 
works on such env

> Relax Sling Log Tracer package imports 
> ---
>
> Key: SLING-5762
> URL: https://issues.apache.org/jira/browse/SLING-5762
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Log Tracer 1.0.0
>Reporter: David Gonzalez
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
> Attachments: org.apache.sling.tracer-1.0.1-SNAPSHOT.jar
>
>
> Sling Log Tracer 1.0.0 has tight package import requirements limiting its use 
> across Sling-based applications.
> It would be nice to relax the imports to maximize Log Tracer compatibility 
> with older Sling-based stacks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5762) Relax Sling Log Tracer package imports

2016-10-08 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated SLING-5762:
---
Attachment: org.apache.sling.tracer-1.0.1-SNAPSHOT.jar

> Relax Sling Log Tracer package imports 
> ---
>
> Key: SLING-5762
> URL: https://issues.apache.org/jira/browse/SLING-5762
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Log Tracer 1.0.0
>Reporter: David Gonzalez
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
> Attachments: org.apache.sling.tracer-1.0.1-SNAPSHOT.jar
>
>
> Sling Log Tracer 1.0.0 has tight package import requirements limiting its use 
> across Sling-based applications.
> It would be nice to relax the imports to maximize Log Tracer compatibility 
> with older Sling-based stacks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-5762) Relax Sling Log Tracer package imports

2016-10-08 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved SLING-5762.

Resolution: Fixed

Changed the dependency on commons OSGi to 2.0.6 so as to allow usage in older 
setups like AEM 6.0

Done with r1763880

> Relax Sling Log Tracer package imports 
> ---
>
> Key: SLING-5762
> URL: https://issues.apache.org/jira/browse/SLING-5762
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Log Tracer 1.0.0
>Reporter: David Gonzalez
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
>
> Sling Log Tracer 1.0.0 has tight package import requirements limiting its use 
> across Sling-based applications.
> It would be nice to relax the imports to maximize Log Tracer compatibility 
> with older Sling-based stacks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-6118) Handle empty tracer config header gracefully

2016-10-08 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved SLING-6118.

Resolution: Fixed

Done with 1763881

> Handle empty tracer config header gracefully
> 
>
> Key: SLING-6118
> URL: https://issues.apache.org/jira/browse/SLING-6118
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Chetan Mehrotra
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
>
> In case tracer config header is null request fails with following exception
> {noformat}
> 08.10.2016 14:47:43.920 *WARN* [qtp840310891-62] 
> org.eclipse.jetty.servlet.ServletHandler 
> /content/geometrixx-outdoors/en/women.html
> java.lang.IllegalArgumentException: A header cannot be an empty string.
>   at 
> org.apache.sling.commons.osgi.ManifestHeader.parse(ManifestHeader.java:116)
>   at 
> org.apache.sling.tracer.internal.TracerSet.parseTracerConfigs(TracerSet.java:71)
>   at org.apache.sling.tracer.internal.TracerSet.(TracerSet.java:50)
>   at 
> org.apache.sling.tracer.internal.LogTracer.getTracerContext(LogTracer.java:250)
>   at 
> org.apache.sling.tracer.internal.LogTracer$TracerFilter.doFilter(LogTracer.java:356)
>   at 
> org.apache.felix.http.base.internal.handler.FilterHandler.doHandle(FilterHandler.java:108)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6118) Handle empty tracer config header gracefully

2016-10-08 Thread Chetan Mehrotra (JIRA)
Chetan Mehrotra created SLING-6118:
--

 Summary: Handle empty tracer config header gracefully
 Key: SLING-6118
 URL: https://issues.apache.org/jira/browse/SLING-6118
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Chetan Mehrotra
Assignee: Chetan Mehrotra
Priority: Minor
 Fix For: Log Tracer 1.0.2


In case tracer config header is null request fails with following exception

{noformat}
08.10.2016 14:47:43.920 *WARN* [qtp840310891-62] 
org.eclipse.jetty.servlet.ServletHandler 
/content/geometrixx-outdoors/en/women.html
java.lang.IllegalArgumentException: A header cannot be an empty string.
at 
org.apache.sling.commons.osgi.ManifestHeader.parse(ManifestHeader.java:116)
at 
org.apache.sling.tracer.internal.TracerSet.parseTracerConfigs(TracerSet.java:71)
at org.apache.sling.tracer.internal.TracerSet.(TracerSet.java:50)
at 
org.apache.sling.tracer.internal.LogTracer.getTracerContext(LogTracer.java:250)
at 
org.apache.sling.tracer.internal.LogTracer$TracerFilter.doFilter(LogTracer.java:356)
at 
org.apache.felix.http.base.internal.handler.FilterHandler.doHandle(FilterHandler.java:108)
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-5762) Relax Sling Log Tracer package imports

2016-10-08 Thread Chetan Mehrotra (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra updated SLING-5762:
---
Fix Version/s: Log Tracer 1.0.2

> Relax Sling Log Tracer package imports 
> ---
>
> Key: SLING-5762
> URL: https://issues.apache.org/jira/browse/SLING-5762
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Log Tracer 1.0.0
>Reporter: David Gonzalez
>Assignee: Chetan Mehrotra
>Priority: Minor
> Fix For: Log Tracer 1.0.2
>
>
> Sling Log Tracer 1.0.0 has tight package import requirements limiting its use 
> across Sling-based applications.
> It would be nice to relax the imports to maximize Log Tracer compatibility 
> with older Sling-based stacks.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (SLING-5646) Provide Message oriented Middleware API to support implementation of distributed Jobs API

2016-10-08 Thread Ian Boston (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Boston closed SLING-5646.
-

Bundles have been released.

> Provide Message oriented Middleware API to support implementation of 
> distributed Jobs API
> -
>
> Key: SLING-5646
> URL: https://issues.apache.org/jira/browse/SLING-5646
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ian Boston
>Assignee: Ian Boston
> Fix For: MoM API 1.0.0, MoM JMS 1.0.0
>
>
> See PoC at 
> https://github.com/ieb/sling/tree/jobs_28/contrib/extensions/jobs/mom-api
> Needs to support Pub/Sub style messaging and Queue messaging.
> Must not depend on Jobs API and must not bind to a specific technology.
> Implementations are expected to be JMS or AMPQ based with an initial 
> implementation based on ActiveMQ.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (SLING-5647) Provide ActiveMQ implementation of the MoM API in SLING-5646

2016-10-08 Thread Ian Boston (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Boston closed SLING-5647.
-

Bundles have been released.

> Provide ActiveMQ implementation of the MoM API in SLING-5646
> 
>
> Key: SLING-5647
> URL: https://issues.apache.org/jira/browse/SLING-5647
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Ian Boston
>Assignee: Ian Boston
> Fix For: MoM JMS 1.0.0
>
>
> Provide a default implementation of the MoM API in SLING-5646 using ActiveMQ. 
> The bundle must create and start a running ActiveMQ server without additional 
> intervention and configuration. Ideally the bundle should work in a cluster 
> embedding an ActiveMQ broker into each Sling instance, and ideally the bundle 
> should be able to integrate with an existing ActiveMQ cluster. Based on AMQ 
> documentation all are possible via configuration and no code changes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (SLING-5645) Provide a Jobs API and implementation suitable for widely distributed job processing.

2016-10-08 Thread Ian Boston (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ian Boston closed SLING-5645.
-

Bundles have been released.

> Provide a Jobs API and implementation suitable for widely distributed job 
> processing.
> -
>
> Key: SLING-5645
> URL: https://issues.apache.org/jira/browse/SLING-5645
> Project: Sling
>  Issue Type: New Feature
>Reporter: Ian Boston
>Assignee: Ian Boston
> Fix For: MoM API 1.0.0, MoM JMS 1.0.0, MoM Jobs 1.0.0
>
>
> This issue is to track work on a proof of concept to create a Jobs API and 
> implementation that will work in a distributed environment where the job 
> submitters and job consumers are not necessarily in the same JVM or in the 
> same Sling cluster. 
> Work is being done in a branch at 
> https://github.com/ieb/sling/tree/jobs_28/contrib/extensions/jobs
> Since the implementation needs supporting APIs/Capabilities not already 
> present in Sling. There are some sub-tasks associated with this issue to 
> address those.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[RESULT] [VOTE] Release Apache Sling MoM API, JMS, Jobs version 1.0.0

2016-10-08 Thread Ian Boston
Hi,
The vote passes as follows

+1 Carsten Ziegeler
+1 Timothée Maret
+1 Timothee
+1 Chetan Mehrotra
+1 Karl Pauls
+1 Ian Boston

Thank you all for voting. I will push the release out.

Best Regards
Ian

On 5 October 2016 at 11:46, Ian Boston  wrote:

> Hi,
>
> This is the first release of
> Apache Sling MoM API 1.0.0,
> Apache Sling MoM JMS 1.0.0,
> Apache Sling MoM Jobs 1.0.0
>
> We solved 3 issues over 3 bundles.
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338372
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338373
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338374
>
> There are no outstanding issues
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1528/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1528 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best Regards
> Ian
>


Re: [VOTE] Release Apache Sling MoM API, JMS, Jobs version 1.0.0

2016-10-08 Thread Ian Boston
+1
Ian

On 5 October 2016 at 11:46, Ian Boston  wrote:

> Hi,
>
> This is the first release of
> Apache Sling MoM API 1.0.0,
> Apache Sling MoM JMS 1.0.0,
> Apache Sling MoM Jobs 1.0.0
>
> We solved 3 issues over 3 bundles.
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338372
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338373
> https://issues.apache.org/jira/browse/SLING/fixforversion/12338374
>
> There are no outstanding issues
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1528/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>
> Usage:
> sh check_staged_release.sh 1528 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best Regards
> Ian
>


[jira] [Resolved] (SLING-6117) Hamcrest: Simplify ResourceMatchers method signatures

2016-10-08 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6117.
---
Resolution: Fixed

Completed: At revision: 1763865  


> Hamcrest: Simplify ResourceMatchers method signatures
> -
>
> Key: SLING-6117
> URL: https://issues.apache.org/jira/browse/SLING-6117
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: Apache Sling Testing Hamcrest 1.0.0
>
>
> the resource matching methods of ResourceMatchers should be simplified 
> (before doing the 1.0.0 release):
> * eliminate "resource" prefix from method names, because resource is already 
> in the "ResourceMatchers" class names, and the child methods do not contain 
> this prefix as well
> * allow to specify property maps either as map, or as object vararg array 
> (similar to resource builder and sling mocks)
> existing sling projects using this snapshot release will be updated as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6117) Hamcrest: Simplify ResourceMatchers method signatures

2016-10-08 Thread Stefan Seifert (JIRA)
Stefan Seifert created SLING-6117:
-

 Summary: Hamcrest: Simplify ResourceMatchers method signatures
 Key: SLING-6117
 URL: https://issues.apache.org/jira/browse/SLING-6117
 Project: Sling
  Issue Type: Improvement
  Components: Testing
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Apache Sling Testing Hamcrest 1.0.0


the resource matching methods of ResourceMatchers should be simplified (before 
doing the 1.0.0 release):
* eliminate "resource" prefix from method names, because resource is already in 
the "ResourceMatchers" class names, and the child methods do not contain this 
prefix as well
* allow to specify property maps either as map, or as object vararg array 
(similar to resource builder and sling mocks)

existing sling projects using this snapshot release will be updated as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (SLING-6116) Hamcrest: Add matchers for resource collections and iterators

2016-10-08 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6116.
---
Resolution: Fixed

Completed: At revision: 1763859  


> Hamcrest: Add matchers for resource collections and iterators
> -
>
> Key: SLING-6116
> URL: https://issues.apache.org/jira/browse/SLING-6116
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Affects Versions: Apache Sling Testing Hamcrest 1.0.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
>
> add matchers to ensure a list or iterator of resources has exactly the given 
> list of paths in the given order.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (SLING-6116) Hamcrest: Add matchers for resource collections and iterators

2016-10-08 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert updated SLING-6116:
--
Summary: Hamcrest: Add matchers for resource collections and iterators  
(was: Hamcrest: Add matches for resource collections and iterators)

> Hamcrest: Add matchers for resource collections and iterators
> -
>
> Key: SLING-6116
> URL: https://issues.apache.org/jira/browse/SLING-6116
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Affects Versions: Apache Sling Testing Hamcrest 1.0.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
>
> add matchers to ensure a list or iterator of resources has exactly the given 
> list of paths in the given order.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6116) Hamcrest: Add matches for resource collections and iterators

2016-10-08 Thread Stefan Seifert (JIRA)
Stefan Seifert created SLING-6116:
-

 Summary: Hamcrest: Add matches for resource collections and 
iterators
 Key: SLING-6116
 URL: https://issues.apache.org/jira/browse/SLING-6116
 Project: Sling
  Issue Type: New Feature
  Components: Testing
Affects Versions: Apache Sling Testing Hamcrest 1.0.0
Reporter: Stefan Seifert
Assignee: Stefan Seifert
Priority: Minor


add matchers to ensure a list or iterator of resources has exactly the given 
list of paths in the given order.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (SLING-6058) Context-Aware Config: Property Inheritance/Merging

2016-10-08 Thread Stefan Seifert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15557427#comment-15557427
 ] 

Stefan Seifert commented on SLING-6058:
---

the goal is to introduce a new property {{sling:config-property-inherit}} which 
- if set to true, switches on the property inheritance and merging for 
configurations.

the handling is similar to the implementation of SLING-6059 - it is possible to 
set this flag either on on the configuration resource itself, or on one of its 
parent to activate or deactivate the property inheritance.

with introducing this new property {{sling:config-property-inherit}} we rename 
the property introduced in SLING-6059 to {{sling:config-collection-inherit}}, 
because for the previous name {{sling:config-inherit}} it was not clear if 
collections or properties should be inherited.

> Context-Aware Config: Property Inheritance/Merging
> --
>
> Key: SLING-6058
> URL: https://issues.apache.org/jira/browse/SLING-6058
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
>  Labels: contextaware-config
> Fix For: Context-Aware Configuration 1.0.0
>
>
> currently the context-aware config implementation supports resource 
> inheritance, but not property inheritance, that means no properties gets 
> merged in the resource inheritance chain.
> there was a long discussion on the mailing list about this topics with 
> arguments to support this, and other not to support this
> http://apache-sling.73963.n3.nabble.com/Context-Aware-Configs-Merging-tt4063382.html
> the goal of this ticket is to support it, but make it configurable so it can 
> be switched on and off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (SLING-6058) Context-Aware Config: Property Inheritance/Merging

2016-10-08 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert reassigned SLING-6058:
-

Assignee: Stefan Seifert

> Context-Aware Config: Property Inheritance/Merging
> --
>
> Key: SLING-6058
> URL: https://issues.apache.org/jira/browse/SLING-6058
> Project: Sling
>  Issue Type: New Feature
>  Components: Extensions
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
>Priority: Minor
>  Labels: contextaware-config
> Fix For: Context-Aware Configuration 1.0.0
>
>
> currently the context-aware config implementation supports resource 
> inheritance, but not property inheritance, that means no properties gets 
> merged in the resource inheritance chain.
> there was a long discussion on the mailing list about this topics with 
> arguments to support this, and other not to support this
> http://apache-sling.73963.n3.nabble.com/Context-Aware-Configs-Merging-tt4063382.html
> the goal of this ticket is to support it, but make it configurable so it can 
> be switched on and off.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (SLING-6115) Context-Aware Config: Web Console Plugin

2016-10-08 Thread Stefan Seifert (JIRA)
Stefan Seifert created SLING-6115:
-

 Summary: Context-Aware Config: Web Console Plugin
 Key: SLING-6115
 URL: https://issues.apache.org/jira/browse/SLING-6115
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Reporter: Stefan Seifert
Priority: Minor
 Fix For: Context-Aware Configuration 1.0.0


with the first implementation prototype a web console plugin was included which 
can be used to test/debug configuration resource resolution.

it was not maintained properly during all the refactoring and new features that 
were added since then, thus is quite broken currently.

the web console plugin has to be refactored and fixed, and perhaps enhanced to 
support the new features as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)