[jira] [Closed] (SLING-6859) Make dependency to javax.jcr optional

2017-05-18 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6859.
---

> Make dependency to javax.jcr optional
> -
>
> Key: SLING-6859
> URL: https://issues.apache.org/jira/browse/SLING-6859
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Post 2.3.18
>
>
> This is a follow up of SLING-6723. The importer is currently still tying the 
> post servlet to JCR



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6858) Make use of java.jcr api optional

2017-05-18 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6858.
---

> Make use of java.jcr api optional
> -
>
> Key: SLING-6858
> URL: https://issues.apache.org/jira/browse/SLING-6858
> Project: Sling
>  Issue Type: Improvement
>  Components: Servlets
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Servlets Get 2.1.26
>
>
> This is a follow up of SLING-6705. It seems the original change got lost and 
> right now the default get servlet fails without the JCR API



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[VOTE RESULT] Release Apache Sling Servlets Post 2.3.18

2017-05-18 Thread Carsten Ziegeler
The vote passes with five binding +1 votes

 Thanks

Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[VOTE RESULT] Release Apache Sling Servlets Get 2.1.26

2017-05-18 Thread Carsten Ziegeler
The vote passes with four binding +1 votes

 Thanks

Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[GitHub] sling pull request #233: Launchpad Homepage update for Sling 9

2017-05-18 Thread auniverseaway
GitHub user auniverseaway opened a pull request:

https://github.com/apache/sling/pull/233

Launchpad Homepage update for Sling 9

This PR is to address 
[SLING-6850](https://issues.apache.org/jira/browse/SLING-6850)

The new launchpad homepage is completely redesigned for better information 
architecture while retaining the spirit of the original.

The new homepage is responsive, and leverages flexbox to vertically center 
the content when the viewport is beyond a certain size.

To address front-end productivity, I have added a launchpad clientlib which 
uses SCSS to generate the minified CSS.

To not be heavy handed with an FE build process, I have ***not*** added the 
[frontend-maven-plugin](https://github.com/eirslett/frontend-maven-plugin), so 
overall build time should not be affected. The idea is that the CSS is the CSS, 
and if you want to change it, you can run `npm install` and `gulp` manually.

Let me know if you want any changes @rombert.


![sling-home](https://cloud.githubusercontent.com/assets/1972095/26224923/ee34fa68-3be1-11e7-83f6-dea63b00dc18.jpg)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/auniverseaway/sling 
SLING-6850_Launchpad_Homepage

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #233


commit c3742b5a2a7671475b76e881ac5a4fe731362f0e
Author: Chris Millar 
Date:   2017-05-18T21:40:09Z

Launchpad Homepage update for Sling 9




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (SLING-6850) Address Launchpad homepage information architecture

2017-05-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016524#comment-16016524
 ] 

ASF GitHub Bot commented on SLING-6850:
---

GitHub user auniverseaway opened a pull request:

https://github.com/apache/sling/pull/233

Launchpad Homepage update for Sling 9

This PR is to address 
[SLING-6850](https://issues.apache.org/jira/browse/SLING-6850)

The new launchpad homepage is completely redesigned for better information 
architecture while retaining the spirit of the original.

The new homepage is responsive, and leverages flexbox to vertically center 
the content when the viewport is beyond a certain size.

To address front-end productivity, I have added a launchpad clientlib which 
uses SCSS to generate the minified CSS.

To not be heavy handed with an FE build process, I have ***not*** added the 
[frontend-maven-plugin](https://github.com/eirslett/frontend-maven-plugin), so 
overall build time should not be affected. The idea is that the CSS is the CSS, 
and if you want to change it, you can run `npm install` and `gulp` manually.

Let me know if you want any changes @rombert.


![sling-home](https://cloud.githubusercontent.com/assets/1972095/26224923/ee34fa68-3be1-11e7-83f6-dea63b00dc18.jpg)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/auniverseaway/sling 
SLING-6850_Launchpad_Homepage

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/233.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #233


commit c3742b5a2a7671475b76e881ac5a4fe731362f0e
Author: Chris Millar 
Date:   2017-05-18T21:40:09Z

Launchpad Homepage update for Sling 9




> Address Launchpad homepage information architecture
> ---
>
> Key: SLING-6850
> URL: https://issues.apache.org/jira/browse/SLING-6850
> Project: Sling
>  Issue Type: Improvement
>Reporter: Chris Millar
>Priority: Minor
> Fix For: Launchpad Content 2.0.10
>
> Attachments: Launchpad - Current Design.png, Launchpad - Proposed 
> Design.png
>
>
> The launchpad homepage could use some love...
> # The page is not responsive.
> # Design is dated.
> # The page has several links that are either out of date (composum always 
> installed now), repeated (OSGi console), or not helpful (sign up).
> # Does not speak to audiences of different skill levels.
> *My proposal addresses these concerns with the following updates:*
> # Page is responsive
> # Page is designed to address three audiences:
> ## Brand new developer - Why did I just type `java -jar org.apache.sling`?
> ## Experienced developer - Give me a list of the guts in this site / app. 
> Give me external resources to help keep me going.
> ## Potential Contributor - How do I get involved?
> # Bad / duplicated / unused links have been removed. - I'm looking at you 
> signup page and client test page (which 500s in snapshot).
> # Apache logo has been added.
> # Retained most of the excellent welcome text (with updated links to Oak and 
> Felix).
> # Friendlier colors have been used.
> # Custom font (Open Sans, AL 2.0) has been used instead of Tahoma (not AL 2.0)
> # Slightly larger typography to meet current trends.
> # Used old yellow / blue horizontal rule as the design inspiration for the 
> left rail rule (that uses feather color palette).
> # Built out concise list of top resources for both the current site as well 
> as external resources.
> *Items worth discussing:*
> # Should the first heading under "Resources" be "This Site" or "This 
> Application"?
> # Should the HTL REPL be included in the list of links.
> # Should the Bootstrap clientlibs (used in HTL REPL) be used to build the 
> page even though they are MIT? If not, should we refactor the clientlibs 
> folder so REPL can be self contained and other libraries can also use 
> /etc/clientlibs?
> ## I have a flexbox based grid system I'd be willing to donate / use / 
> document.
> # Other things I'm not thinking of that may be contentious...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: svn commit: r1795540 - in /sling/trunk/bundles/scripting/jsp-taglib: pom.xml src/main/java/org/apache/sling/scripting/jsp/taglib/package-info.java

2017-05-18 Thread Daniel Klco
Radu,

Totally fair. When I roll back to r1795539, I see the following in the
baseline report:

https://gist.github.com/klcodanr/43625af985e2524892c6994c20e8c50f

Thanks,
Dan

On Thu, May 18, 2017 at 12:31 PM, Radu Cotescu  wrote:

> Hi Dan,
>
> Could you please post the report of the baseline plugin before your commit?
>
> At r1795516 I have this:
>
> [INFO] Comparing bundle org.apache.sling.scripting.jsp.taglib version
> 2.2.7-SNAPSHOT to version 2.2.6
> [INFO]
> [INFO]   PACKAGE_NAME   DELTA
>  CUR_VERBASE_VER   REC_VERWARNINGS
> [INFO] = == ==
> == == == ==
> [INFO]   org.apache.sling.scripting.jsp.taglib  unchanged
>  2.2.0  2.2.0  2.2.0  -
> [INFO]
> 
> ---
> [INFO]   org.apache.sling.scripting.jsp.taglib.helpers  unchanged
>  2.2.0  2.2.0  2.2.0  -
> [INFO]
> 
> ---
> [INFO]   org.apache.sling.scripting.jsp.taglib.tei  unchanged
>  2.2.0  2.2.0  2.2.0  -
> [INFO]
> 
> ---
> [INFO] Baseline analysis complete, 0 error(s), 0 warning(s)
>
>
> After your commit I see:
>
> [INFO]   PACKAGE_NAME   DELTA
>  CUR_VERBASE_VER   REC_VERWARNINGS
> [INFO] = == ==
> == == == ==
> [INFO]   org.apache.sling.scripting.jsp.taglib  unchanged
>  2.3.0  2.2.0  2.2.0  Version has been increased but analysis
> detected no changes
> [INFO]  - version 2.2.0
> [INFO]  + version 2.3.0
> [INFO]
> 
> ---
> [INFO]   org.apache.sling.scripting.jsp.taglib.helpers  unchanged
>  2.2.0  2.2.0  2.2.0  -
> [INFO]
> 
> ---
> [INFO]   org.apache.sling.scripting.jsp.taglib.tei  unchanged
>  2.2.0  2.2.0  2.2.0  -
> [INFO]
> 
> ---
> [WARNING] org.apache.sling.scripting.jsp.taglib: Excessive version
> increase; detected 2.3.0, suggested 2.2.0
> [WARNING] org.apache.sling.scripting.jsp.taglib: Version has been
> increased
> but analysis detected no changes; detected 2.3.0, suggested 2.2.0
> [INFO] Baseline analysis complete, 0 error(s), 2 warning(s)
>
>
> I'd really like us to avoid increasing API versions without a good reason.
>
> Thanks,
> Radu
>
> On Thu, 18 May 2017 at 16:38  wrote:
>
> > Author: dklco
> > Date: Thu May 18 14:38:40 2017
> > New Revision: 1795540
> >
> > URL: http://svn.apache.org/viewvc?rev=1795540=rev
> > Log:
> > Fixing baseline issues about the versioning of JSP Taglibs
> >
> > Modified:
> > sling/trunk/bundles/scripting/jsp-taglib/pom.xml
> >
> > sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/
> apache/sling/scripting/jsp/taglib/package-info.java
> >
> > Modified: sling/trunk/bundles/scripting/jsp-taglib/pom.xml
> > URL:
> > http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/
> jsp-taglib/pom.xml?rev=1795540=1795539=1795540=diff
> >
> > 
> ==
> > --- sling/trunk/bundles/scripting/jsp-taglib/pom.xml (original)
> > +++ sling/trunk/bundles/scripting/jsp-taglib/pom.xml Thu May 18 14:38:40
> > 2017
> > @@ -20,7 +20,7 @@
> > 
> >
> > org.apache.sling.scripting.jsp.taglib
> > -   2.2.7-SNAPSHOT
> > +   2.3.0-SNAPSHOT
> > bundle
> >
> > Apache Sling JSP Tag Library
> >
> > Modified:
> > sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/
> apache/sling/scripting/jsp/taglib/package-info.java
> > URL:
> > http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/
> jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/
> taglib/package-info.java?rev=1795540=1795539=1795540=diff
> >
> > 
> ==
> > ---
> > sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/
> apache/sling/scripting/jsp/taglib/package-info.java
> > (original)
> > +++
> > sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/
> apache/sling/scripting/jsp/taglib/package-info.java
> > Thu May 18 14:38:40 2017
> > @@ -16,7 +16,7 @@
> >   * specific language governing permissions and limitations
> >   * under the License.
> >   */
> > -@Version("2.2.0")
> > +@Version("2.3.0")
> >  package 

[jira] [Comment Edited] (SLING-6422) Allow for specifying oak restrictions with repoinit

2017-05-18 Thread Nitin Nizhawan (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016082#comment-16016082
 ] 

Nitin Nizhawan edited comment on SLING-6422 at 5/18/17 5:05 PM:


Also tagging [~anchela] and [~chetanm] for review 
[^SLING6422_interpretparsedrestrictionclause.patch]
CC: [~bdelacretaz]


was (Author: nitin.nizhawan):
Also tagging [~anchela] and [~chetanm] for review
CC: [~bdelacretaz]

> Allow for specifying oak restrictions with repoinit
> ---
>
> Key: SLING-6422
> URL: https://issues.apache.org/jira/browse/SLING-6422
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
> Attachments: SLING6422_interpretparsedrestrictionclause.patch, 
> SLING-6422.patch
>
>
> Allow for specifying oak restrictions with repoinit. Currently repoinit 
> allows one to ADD remove ACLs but there is no way to specify oak restrictions.
> http://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

2017-05-18 Thread Nitin Nizhawan (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016082#comment-16016082
 ] 

Nitin Nizhawan commented on SLING-6422:
---

Also tagging [~anchela] and [~chetanm] for review
CC: [~bdelacretaz]

> Allow for specifying oak restrictions with repoinit
> ---
>
> Key: SLING-6422
> URL: https://issues.apache.org/jira/browse/SLING-6422
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
> Attachments: SLING6422_interpretparsedrestrictionclause.patch, 
> SLING-6422.patch
>
>
> Allow for specifying oak restrictions with repoinit. Currently repoinit 
> allows one to ADD remove ACLs but there is no way to specify oak restrictions.
> http://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: svn commit: r1795540 - in /sling/trunk/bundles/scripting/jsp-taglib: pom.xml src/main/java/org/apache/sling/scripting/jsp/taglib/package-info.java

2017-05-18 Thread Radu Cotescu
Hi Dan,

Could you please post the report of the baseline plugin before your commit?

At r1795516 I have this:

[INFO] Comparing bundle org.apache.sling.scripting.jsp.taglib version
2.2.7-SNAPSHOT to version 2.2.6
[INFO]
[INFO]   PACKAGE_NAME   DELTA
 CUR_VERBASE_VER   REC_VERWARNINGS
[INFO] = == ==
== == == ==
[INFO]   org.apache.sling.scripting.jsp.taglib  unchanged
 2.2.0  2.2.0  2.2.0  -
[INFO]
---
[INFO]   org.apache.sling.scripting.jsp.taglib.helpers  unchanged
 2.2.0  2.2.0  2.2.0  -
[INFO]
---
[INFO]   org.apache.sling.scripting.jsp.taglib.tei  unchanged
 2.2.0  2.2.0  2.2.0  -
[INFO]
---
[INFO] Baseline analysis complete, 0 error(s), 0 warning(s)


After your commit I see:

[INFO]   PACKAGE_NAME   DELTA
 CUR_VERBASE_VER   REC_VERWARNINGS
[INFO] = == ==
== == == ==
[INFO]   org.apache.sling.scripting.jsp.taglib  unchanged
 2.3.0  2.2.0  2.2.0  Version has been increased but analysis
detected no changes
[INFO]  - version 2.2.0
[INFO]  + version 2.3.0
[INFO]
---
[INFO]   org.apache.sling.scripting.jsp.taglib.helpers  unchanged
 2.2.0  2.2.0  2.2.0  -
[INFO]
---
[INFO]   org.apache.sling.scripting.jsp.taglib.tei  unchanged
 2.2.0  2.2.0  2.2.0  -
[INFO]
---
[WARNING] org.apache.sling.scripting.jsp.taglib: Excessive version
increase; detected 2.3.0, suggested 2.2.0
[WARNING] org.apache.sling.scripting.jsp.taglib: Version has been increased
but analysis detected no changes; detected 2.3.0, suggested 2.2.0
[INFO] Baseline analysis complete, 0 error(s), 2 warning(s)


I'd really like us to avoid increasing API versions without a good reason.

Thanks,
Radu

On Thu, 18 May 2017 at 16:38  wrote:

> Author: dklco
> Date: Thu May 18 14:38:40 2017
> New Revision: 1795540
>
> URL: http://svn.apache.org/viewvc?rev=1795540=rev
> Log:
> Fixing baseline issues about the versioning of JSP Taglibs
>
> Modified:
> sling/trunk/bundles/scripting/jsp-taglib/pom.xml
>
> sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/package-info.java
>
> Modified: sling/trunk/bundles/scripting/jsp-taglib/pom.xml
> URL:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp-taglib/pom.xml?rev=1795540=1795539=1795540=diff
>
> ==
> --- sling/trunk/bundles/scripting/jsp-taglib/pom.xml (original)
> +++ sling/trunk/bundles/scripting/jsp-taglib/pom.xml Thu May 18 14:38:40
> 2017
> @@ -20,7 +20,7 @@
> 
>
> org.apache.sling.scripting.jsp.taglib
> -   2.2.7-SNAPSHOT
> +   2.3.0-SNAPSHOT
> bundle
>
> Apache Sling JSP Tag Library
>
> Modified:
> sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/package-info.java
> URL:
> http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/package-info.java?rev=1795540=1795539=1795540=diff
>
> ==
> ---
> sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/package-info.java
> (original)
> +++
> sling/trunk/bundles/scripting/jsp-taglib/src/main/java/org/apache/sling/scripting/jsp/taglib/package-info.java
> Thu May 18 14:38:40 2017
> @@ -16,7 +16,7 @@
>   * specific language governing permissions and limitations
>   * under the License.
>   */
> -@Version("2.2.0")
> +@Version("2.3.0")
>  package org.apache.sling.scripting.jsp.taglib;
>
>  import aQute.bnd.annotation.Version;
> \ No newline at end of file
>
>
>


Re: [DISCUSS] Should we update to the latest supported Jackrabbit Version

2017-05-18 Thread Carsten Ziegeler
Robert Munteanu wrote
> Hi,
> 
> Julian raises a good about us depending on EOL Jackrabbit versions.
> Although I think in practice this isn't a big deal as we mostly depend
> on those versions for compilation and import range calculations,
> perhaps there is a benefit in upgrading to Jackrabbit 2.4.x as a
> baseline.
> 
I see no problem with updating, however I see no real benefit either :)

 Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling Service User Mapper 1.3.2, Apache Sling JCR Base Bundle 3.0.2, Apache Sling Web Console Branding 1.0.2, Apache Sling Engine Implementation 2.6.8

2017-05-18 Thread Carsten Ziegeler
+1

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[DISCUSS] Should we update to the latest supported Jackrabbit Version

2017-05-18 Thread Robert Munteanu
Hi,

Julian raises a good about us depending on EOL Jackrabbit versions.
Although I think in practice this isn't a big deal as we mostly depend
on those versions for compilation and import range calculations,
perhaps there is a benefit in upgrading to Jackrabbit 2.4.x as a
baseline.

Thoughts?

Robert

On Thu, 2017-05-18 at 16:24 +0200, Julian Reschke wrote:
> On 2017-05-18 16:12, Robert Munteanu wrote:
> > ...
> > Nevermind, found http://jackrabbit.apache.org/jcr/downloads#v23.htm
> > l
> > which means that Jackrabbit 2.4.x is the latest supported release.
> 
>  > ...
> 
> Right.
> 
> 



RE: [VOTE] Release Apache Sling Service User Mapper 1.3.2, Apache Sling JCR Base Bundle 3.0.2, Apache Sling Web Console Branding 1.0.2, Apache Sling Engine Implementation 2.6.8

2017-05-18 Thread Stefan Seifert
+1


Re: [VOTE] Release Apache Sling Service User Mapper 1.3.2, Apache Sling JCR Base Bundle 3.0.2, Apache Sling Web Console Branding 1.0.2, Apache Sling Engine Implementation 2.6.8

2017-05-18 Thread Julian Reschke

On 2017-05-18 16:12, Robert Munteanu wrote:

...
Nevermind, found http://jackrabbit.apache.org/jcr/downloads#v23.html
which means that Jackrabbit 2.4.x is the latest supported release.

> ...

Right.




Re: Launchpad Integration Test Errors

2017-05-18 Thread Daniel Klco
I just ran mvn clean install from a fresh clone of the trunk branch in
GitHub and am seeing baseline issues and integration test failures in
sightly. It did seem to resolve the rat issues. Let me look to see if I can
resolve the baseline issue...

On Thu, May 18, 2017 at 9:44 AM, Daniel Klco  wrote:

> I performed a git clean -f and git clean -d, I would assume that should
> return me to a good state but let me try a clean clone off GitHub.
>
> On Thu, May 18, 2017 at 9:41 AM, Carsten Ziegeler 
> wrote:
>
>> Daniel Klco wrote
>> > Hm, I'm trying to do a reactor build on 1795515 and am getting rat
>> errors,
>> > baseline errors and integration testing errors in
>> > bundles/scripting/sightly/testing. Still trying to get a successful
>> reactor
>> > build...
>> >
>>
>> At some point we moved modules around, so you might have stale
>> directories in your checkout. I had them recently as well and ran into
>> similar problems. After removing all of them, the build started working
>> fine.
>>
>>  Regards
>>
>> Carsten
>>
>> --
>> Carsten Ziegeler
>> Adobe Research Switzerland
>> cziege...@apache.org
>>
>
>


Re: [VOTE] Release Apache Sling Service User Mapper 1.3.2, Apache Sling JCR Base Bundle 3.0.2, Apache Sling Web Console Branding 1.0.2, Apache Sling Engine Implementation 2.6.8

2017-05-18 Thread Robert Munteanu
On Thu, 2017-05-18 at 17:11 +0300, Robert Munteanu wrote:
> Hi Julian,
> 
> On Thu, 2017-05-18 at 16:06 +0200, Julian Reschke wrote:
> > On 2017-05-18 15:57, Robert Munteanu wrote:
> > > Hi,
> > > 
> > > On the road to Sling 9, here's a chunk of releases that can
> > > happen
> > > now.
> > > 
> > > We solved 4 issues in these releases
> > > 
> > > https://issues.apache.org/jira/browse/SLING/fixforversion/1234032
> > > 4
> > > (1)
> > > https://issues.apache.org/jira/browse/SLING/fixforversion/1233886
> > > 7
> > > (1)
> > > https://issues.apache.org/jira/browse/SLING/fixforversion/1234057
> > > 5
> > > (1)
> > > https://issues.apache.org/jira/browse/SLING/fixforversion/1233854
> > > 4
> > > (1)
> > > 
> > > Staging repository
> > > 
> > > https://repository.apache.org/content/repositories/orgapachesling
> > > -1
> > > 724
> > > 
> > > You can use this UNIX script to download the release and verify
> > > the
> > > signatures:
> > > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.
> > > sh
> > > 
> > > Usage:
> > > sh check_staged_release.sh 1724 /tmp/sling-staging
> > > 
> > > Please vote to approve this release:
> > > 
> > >   [ ] +1 Approve the release
> > >   [ ]  0 Don't care
> > >   [ ] -1 Don't release, because ...
> > > 
> > > This majority vote is open for at least 72 hours.
> > 
> > 
> > I'll keep asking... :-) Why does this reference Jackrabbit versions
> > that 
> > have been EOL'd years ago?
> 
> I guess you mean JCR Base, right? I guess that for us there is no
> need
> to bump up the version as this only affects compilation and how
> package
> imports are calculated by bnd.
> 
> This allows users of the bundle to decide for themselves which
> version
> of Jackrabbit they want to run against. Note that our current
> launchpad
> is built on Oak 1.6/Jackrabbit 2.14 .
> 
> That being said, I'm not against setting a baseline to the oldest
> stable release of Jackrabbit. Which one is that however? Looking at 
> 
>   http://jackrabbit.apache.org/jcr/index.html
>   http://jackrabbit.apache.org/jcr/news-archive.html
> 
> I only found a reference to 'October 3rd, 2011: End of life of
> Jackrabbit 1.x'

Nevermind, found http://jackrabbit.apache.org/jcr/downloads#v23.html
which means that Jackrabbit 2.4.x is the latest supported release.

> 
> Robert



Re: [VOTE] Release Apache Sling Service User Mapper 1.3.2, Apache Sling JCR Base Bundle 3.0.2, Apache Sling Web Console Branding 1.0.2, Apache Sling Engine Implementation 2.6.8

2017-05-18 Thread Robert Munteanu
Hi Julian,

On Thu, 2017-05-18 at 16:06 +0200, Julian Reschke wrote:
> On 2017-05-18 15:57, Robert Munteanu wrote:
> > Hi,
> > 
> > On the road to Sling 9, here's a chunk of releases that can happen
> > now.
> > 
> > We solved 4 issues in these releases
> > 
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12340324
> > (1)
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12338867
> > (1)
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12340575
> > (1)
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12338544
> > (1)
> > 
> > Staging repository
> > 
> > https://repository.apache.org/content/repositories/orgapachesling-1
> > 724
> > 
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> > 
> > Usage:
> > sh check_staged_release.sh 1724 /tmp/sling-staging
> > 
> > Please vote to approve this release:
> > 
> >   [ ] +1 Approve the release
> >   [ ]  0 Don't care
> >   [ ] -1 Don't release, because ...
> > 
> > This majority vote is open for at least 72 hours.
> 
> 
> I'll keep asking... :-) Why does this reference Jackrabbit versions
> that 
> have been EOL'd years ago?

I guess you mean JCR Base, right? I guess that for us there is no need
to bump up the version as this only affects compilation and how package
imports are calculated by bnd.

This allows users of the bundle to decide for themselves which version
of Jackrabbit they want to run against. Note that our current launchpad
is built on Oak 1.6/Jackrabbit 2.14 .

That being said, I'm not against setting a baseline to the oldest
stable release of Jackrabbit. Which one is that however? Looking at 

  http://jackrabbit.apache.org/jcr/index.html
  http://jackrabbit.apache.org/jcr/news-archive.html

I only found a reference to 'October 3rd, 2011: End of life of
Jackrabbit 1.x'

Robert


Re: [VOTE] Release Apache Sling Service User Mapper 1.3.2, Apache Sling JCR Base Bundle 3.0.2, Apache Sling Web Console Branding 1.0.2, Apache Sling Engine Implementation 2.6.8

2017-05-18 Thread Robert Munteanu
On Thu, 2017-05-18 at 16:57 +0300, Robert Munteanu wrote:
> Please vote to approve this release:

+1

Robert

signature.asc
Description: This is a digitally signed message part


Re: [VOTE] Release Apache Sling Service User Mapper 1.3.2, Apache Sling JCR Base Bundle 3.0.2, Apache Sling Web Console Branding 1.0.2, Apache Sling Engine Implementation 2.6.8

2017-05-18 Thread Julian Reschke

On 2017-05-18 15:57, Robert Munteanu wrote:

Hi,

On the road to Sling 9, here's a chunk of releases that can happen now.

We solved 4 issues in these releases

https://issues.apache.org/jira/browse/SLING/fixforversion/12340324 (1)
https://issues.apache.org/jira/browse/SLING/fixforversion/12338867 (1)
https://issues.apache.org/jira/browse/SLING/fixforversion/12340575 (1)
https://issues.apache.org/jira/browse/SLING/fixforversion/12338544 (1)

Staging repository

https://repository.apache.org/content/repositories/orgapachesling-1724

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1724 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.



I'll keep asking... :-) Why does this reference Jackrabbit versions that 
have been EOL'd years ago?


Best regards, Julian



Re: Build failed in Jenkins: sling-launchpad-builder-1.8 #10564

2017-05-18 Thread Robert Munteanu
On Thu, 2017-05-18 at 13:57 +, Apache Jenkins Server wrote:
> [ERROR] Failed to execute goal on project org.apache.sling.launchpad:
> Could not resolve dependencies for project
> org.apache.sling:org.apache.sling.launchpad:slingstart:9-SNAPSHOT:
> Could not find artifact
> org.apache.sling:org.apache.sling.jcr.base:jar:3.0.3-SNAPSHOT in
> Nexus (http://repository.apache.org/snapshots) -> [Help 1]
> [ERROR] 

Just a temporary failure - the jcr.base SNAPSHOT is being built and
deployed right now.

Robert


[VOTE] Release Apache Sling Service User Mapper 1.3.2, Apache Sling JCR Base Bundle 3.0.2, Apache Sling Web Console Branding 1.0.2, Apache Sling Engine Implementation 2.6.8

2017-05-18 Thread Robert Munteanu
Hi,

On the road to Sling 9, here's a chunk of releases that can happen now.

We solved 4 issues in these releases

https://issues.apache.org/jira/browse/SLING/fixforversion/12340324 (1)
https://issues.apache.org/jira/browse/SLING/fixforversion/12338867 (1)
https://issues.apache.org/jira/browse/SLING/fixforversion/12340575 (1)
https://issues.apache.org/jira/browse/SLING/fixforversion/12338544 (1)

Staging repository

https://repository.apache.org/content/repositories/orgapachesling-1724

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1724 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.


Re: Launchpad Integration Test Errors

2017-05-18 Thread Daniel Klco
Ah, @Radu, the issue I'm having is with launchpad/integration-tests. I can
confirm running mvn clean verify from launchpad/testing works fine.

On Thu, May 18, 2017 at 9:34 AM, Radu Cotescu  wrote:

> Hi Daniel,
>
> What are you trying to run and how?
>
> I get this result when running mvn clean verify in launchpad/testing: Tests
> run: 570, Failures: 0, Errors: 0, Skipped: 2
>
> Cheers,
> Radu
>
> On Thu, 18 May 2017 at 15:19 Daniel Klco  wrote:
>
> > Hm, I'm trying to do a reactor build on 1795515 and am getting rat
> errors,
> > baseline errors and integration testing errors in
> > bundles/scripting/sightly/testing. Still trying to get a successful
> reactor
> > build...
> >
> > On Thu, May 18, 2017 at 2:27 AM, Bertrand Delacretaz <
> > bdelacre...@apache.org
> > > wrote:
> >
> > > On Thu, May 18, 2017 at 8:14 AM, Carsten Ziegeler <
> cziege...@apache.org>
> > > wrote:
> > > > ...I did a full build several times now and I don't get any
> > > > test failures at all...
> > >
> > > Same here, full build at revision 1795477 works.
> > >
> > > -Bertrand
> > >
> >
>


[jira] [Updated] (SLING-6402) Remove loginAdministrative() usage from jcr base

2017-05-18 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-6402:
---
Fix Version/s: (was: JCR Base 3.0.2)
   JCR Base 3.0.4

> Remove loginAdministrative() usage from jcr base
> 
>
> Key: SLING-6402
> URL: https://issues.apache.org/jira/browse/SLING-6402
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Reporter: Antonio Sanso
> Fix For: JCR Base 3.0.4
>
>
> jcr.base has a Loader class which allows to set namespace prefixes and define 
> node types through bundle content.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Launchpad Integration Test Errors

2017-05-18 Thread Daniel Klco
I performed a git clean -f and git clean -d, I would assume that should
return me to a good state but let me try a clean clone off GitHub.

On Thu, May 18, 2017 at 9:41 AM, Carsten Ziegeler 
wrote:

> Daniel Klco wrote
> > Hm, I'm trying to do a reactor build on 1795515 and am getting rat
> errors,
> > baseline errors and integration testing errors in
> > bundles/scripting/sightly/testing. Still trying to get a successful
> reactor
> > build...
> >
>
> At some point we moved modules around, so you might have stale
> directories in your checkout. I had them recently as well and ran into
> similar problems. After removing all of them, the build started working
> fine.
>
>  Regards
>
> Carsten
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziege...@apache.org
>


Re: Launchpad Integration Test Errors

2017-05-18 Thread Carsten Ziegeler
Daniel Klco wrote
> Hm, I'm trying to do a reactor build on 1795515 and am getting rat errors,
> baseline errors and integration testing errors in
> bundles/scripting/sightly/testing. Still trying to get a successful reactor
> build...
> 

At some point we moved modules around, so you might have stale
directories in your checkout. I had them recently as well and ran into
similar problems. After removing all of them, the build started working
fine.

 Regards

Carsten

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: Launchpad Integration Test Errors

2017-05-18 Thread Radu Cotescu
Hi Daniel,

What are you trying to run and how?

I get this result when running mvn clean verify in launchpad/testing: Tests
run: 570, Failures: 0, Errors: 0, Skipped: 2

Cheers,
Radu

On Thu, 18 May 2017 at 15:19 Daniel Klco  wrote:

> Hm, I'm trying to do a reactor build on 1795515 and am getting rat errors,
> baseline errors and integration testing errors in
> bundles/scripting/sightly/testing. Still trying to get a successful reactor
> build...
>
> On Thu, May 18, 2017 at 2:27 AM, Bertrand Delacretaz <
> bdelacre...@apache.org
> > wrote:
>
> > On Thu, May 18, 2017 at 8:14 AM, Carsten Ziegeler 
> > wrote:
> > > ...I did a full build several times now and I don't get any
> > > test failures at all...
> >
> > Same here, full build at revision 1795477 works.
> >
> > -Bertrand
> >
>


Re: Launchpad Integration Test Errors

2017-05-18 Thread Daniel Klco
Hm, I'm trying to do a reactor build on 1795515 and am getting rat errors,
baseline errors and integration testing errors in
bundles/scripting/sightly/testing. Still trying to get a successful reactor
build...

On Thu, May 18, 2017 at 2:27 AM, Bertrand Delacretaz  wrote:

> On Thu, May 18, 2017 at 8:14 AM, Carsten Ziegeler 
> wrote:
> > ...I did a full build several times now and I don't get any
> > test failures at all...
>
> Same here, full build at revision 1795477 works.
>
> -Bertrand
>


Re: Launchpad Integration Test Errors

2017-05-18 Thread Robert Munteanu
Hi Dan,

On Wed, 2017-05-17 at 23:00 -0400, Daniel Klco wrote:
> I don't feel like this was happening until recently. Perhaps
> introduced
> with the recent Commons Scheduler? You can reproduce the issue off
> the
> trunk by running the launchpad integration tests as such:
> 
> mvn test -Dtest=**/integrationtest/**/*Test.java

Maybe you can use git bisect to pinpoint when the problem started
occurring?

Robert


[jira] [Updated] (SLING-6422) Allow for specifying oak restrictions with repoinit

2017-05-18 Thread Nitin Nizhawan (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nitin Nizhawan updated SLING-6422:
--
Attachment: SLING6422_interpretparsedrestrictionclause.patch

[~bdelacretaz] Attaching patch with changes for interpreting parsed restriction 
clauses from repoinit. Please review and merge these 
Also, request you to release repoinit parser, currently patch points to 
SNAPSHOT version of the parser since release version does not have the parser 
changes so needs to be release first.

Thanks
Nitin


> Allow for specifying oak restrictions with repoinit
> ---
>
> Key: SLING-6422
> URL: https://issues.apache.org/jira/browse/SLING-6422
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
> Attachments: SLING6422_interpretparsedrestrictionclause.patch, 
> SLING-6422.patch
>
>
> Allow for specifying oak restrictions with repoinit. Currently repoinit 
> allows one to ADD remove ACLs but there is no way to specify oak restrictions.
> http://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (SLING-6422) Allow for specifying oak restrictions with repoinit

2017-05-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-6422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015683#comment-16015683
 ] 

ASF GitHub Bot commented on SLING-6422:
---

GitHub user nitin-nizhawan opened a pull request:

https://github.com/apache/sling/pull/232

SLING-6422, Allow for specifying oak restrictions with repoinit

   - Interpret parsed restriction clauses from repoinit parser

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-nizhawan/sling 
nnizhawa/SLING_6422InterpretRestrictionClause

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #232


commit 30894d2cd153e54c899ebd8a086d450424eaf759
Author: Nitin Nizhawan 
Date:   2017-05-16T11:01:56Z

SLING-6422, Allow for specifying oak restrictions with repoinit

   - Interpret parsed restriction clauses from repoinit




> Allow for specifying oak restrictions with repoinit
> ---
>
> Key: SLING-6422
> URL: https://issues.apache.org/jira/browse/SLING-6422
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
> Attachments: SLING-6422.patch
>
>
> Allow for specifying oak restrictions with repoinit. Currently repoinit 
> allows one to ADD remove ACLs but there is no way to specify oak restrictions.
> http://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] sling pull request #232: SLING-6422, Allow for specifying oak restrictions w...

2017-05-18 Thread nitin-nizhawan
GitHub user nitin-nizhawan opened a pull request:

https://github.com/apache/sling/pull/232

SLING-6422, Allow for specifying oak restrictions with repoinit

   - Interpret parsed restriction clauses from repoinit parser

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitin-nizhawan/sling 
nnizhawa/SLING_6422InterpretRestrictionClause

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/232.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #232


commit 30894d2cd153e54c899ebd8a086d450424eaf759
Author: Nitin Nizhawan 
Date:   2017-05-16T11:01:56Z

SLING-6422, Allow for specifying oak restrictions with repoinit

   - Interpret parsed restriction clauses from repoinit




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (SLING-6864) Service User Mapping: webconsole.configurationFactory.nameHint Property has to be part of OCD

2017-05-18 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6864.
---
Resolution: Fixed

Completed: At revision: 1795509  


> Service User Mapping: webconsole.configurationFactory.nameHint Property has 
> to be part of OCD
> -
>
> Key: SLING-6864
> URL: https://issues.apache.org/jira/browse/SLING-6864
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Service User Mapper 1.3.0
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: Service User Mapper 1.3.2
>
>
> via the service property {{webconsole.configurationFactory.nameHint}} a name 
> hint pattern can be defined to produce nice names for factory config items in 
> web console.
> this only works if this property definition is part of the OCD - so when 
> migrating from felix to osgi annotations it has to be part of the 
> configuration annotation class.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (SLING-6863) Event: webconsole.configurationFactory.nameHint Property has to be part of OCD

2017-05-18 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6863.
---
Resolution: Fixed

Completed: At revision: 1795508  


> Event: webconsole.configurationFactory.nameHint Property has to be part of OCD
> --
>
> Key: SLING-6863
> URL: https://issues.apache.org/jira/browse/SLING-6863
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: Event 4.2.4
>
>
> via the service property {{webconsole.configurationFactory.nameHint}} a name 
> hint pattern can be defined to produce nice names for factory config items in 
> web console.
> this only works if this property definition is part of the OCD - so when 
> migrating from felix to osgi annotations it has to be part of the 
> configuration annotation class.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (SLING-6864) Service User Mapping: webconsole.configurationFactory.nameHint Property has to be part of OCD

2017-05-18 Thread Stefan Seifert (JIRA)
Stefan Seifert created SLING-6864:
-

 Summary: Service User Mapping: 
webconsole.configurationFactory.nameHint Property has to be part of OCD
 Key: SLING-6864
 URL: https://issues.apache.org/jira/browse/SLING-6864
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Service User Mapper 1.3.0
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Service User Mapper 1.3.2


via the service property {{webconsole.configurationFactory.nameHint}} a name 
hint pattern can be defined to produce nice names for factory config items in 
web console.

this only works if this property definition is part of the OCD - so when 
migrating from felix to osgi annotations it has to be part of the configuration 
annotation class.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (SLING-6863) Event: webconsole.configurationFactory.nameHint Property has to be part of OCD

2017-05-18 Thread Stefan Seifert (JIRA)
Stefan Seifert created SLING-6863:
-

 Summary: Event: webconsole.configurationFactory.nameHint Property 
has to be part of OCD
 Key: SLING-6863
 URL: https://issues.apache.org/jira/browse/SLING-6863
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Event 4.2.4


via the service property {{webconsole.configurationFactory.nameHint}} a name 
hint pattern can be defined to produce nice names for factory config items in 
web console.

this only works if this property definition is part of the OCD - so when 
migrating from felix to osgi annotations it has to be part of the configuration 
annotation class.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6839) Exception inside a task factory brings down installer task

2017-05-18 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6839.
---

> Exception inside a task factory brings down installer task
> --
>
> Key: SLING-6839
> URL: https://issues.apache.org/jira/browse/SLING-6839
> Project: Sling
>  Issue Type: Improvement
>  Components: Installer
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Installer Core 3.8.10
>
>
> If a task factory throws an uncaught exception (like an NPE) this brings down 
> the whole installer tasks and the installer stops working:
> java.lang.NullPointerException: null
> at 
> org.apache.sling.installer.factories.configuration.impl.AbstractConfigTask.(AbstractConfigTask.java:58)
> at 
> org.apache.sling.installer.factories.configuration.impl.ConfigInstallTask.(ConfigInstallTask.java:37)
> at 
> org.apache.sling.installer.factories.configuration.impl.ConfigTaskCreator.createTask(ConfigTaskCreator.java:89)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.getTask(OsgiInstallerImpl.java:674)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.computeTasks(OsgiInstallerImpl.java:654)
> at 
> org.apache.sling.installer.core.impl.OsgiInstallerImpl.run(OsgiInstallerImpl.java:283)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Closed] (SLING-6856) NPE in scheduler whiteboard handler

2017-05-18 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler closed SLING-6856.
---

> NPE in scheduler whiteboard handler
> ---
>
> Key: SLING-6856
> URL: https://issues.apache.org/jira/browse/SLING-6856
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Scheduler 2.6.0
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Blocker
> Fix For: Commons Scheduler 2.6.2
>
>
> Unfortunately  the whiteboard handler for scheduled jobs in 2.6.0 has a 
> severe bug when jobs arrive before the component is activated. A job 
> reference might be set before the scheduler is set, resulting in an NPE



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[VOTE RESULT] Release Apache Sling Commons Scheduler 2.6.2

2017-05-18 Thread Carsten Ziegeler
Vote passes with four binding +1 votes

Thanks
Carsten

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[VOTE RESULT] Release Apache Sling Installer Core 3.8.10

2017-05-18 Thread Carsten Ziegeler
Vote passes with three binding +1 votes

Thanks
Carsten

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


[jira] [Created] (SLING-6862) Add Context-Aware Configuration (API, SPI, Impl) to Launchpad

2017-05-18 Thread Stefan Seifert (JIRA)
Stefan Seifert created SLING-6862:
-

 Summary: Add Context-Aware Configuration (API, SPI, Impl) to 
Launchpad
 Key: SLING-6862
 URL: https://issues.apache.org/jira/browse/SLING-6862
 Project: Sling
  Issue Type: New Feature
  Components: Launchpad
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Launchpad Builder 9


Sling Context-Aware configuration is stable and production ready - it should be 
included in the launchpad.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Resolved] (SLING-6862) Add Context-Aware Configuration (API, SPI, Impl) to Launchpad

2017-05-18 Thread Stefan Seifert (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-6862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-6862.
---
Resolution: Fixed

Completed: At revision: 1795505  


> Add Context-Aware Configuration (API, SPI, Impl) to Launchpad
> -
>
> Key: SLING-6862
> URL: https://issues.apache.org/jira/browse/SLING-6862
> Project: Sling
>  Issue Type: New Feature
>  Components: Launchpad
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: Launchpad Builder 9
>
>
> Sling Context-Aware configuration is stable and production ready - it should 
> be included in the launchpad.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: Launchpad Integration Test Errors

2017-05-18 Thread Bertrand Delacretaz
On Thu, May 18, 2017 at 8:14 AM, Carsten Ziegeler  wrote:
> ...I did a full build several times now and I don't get any
> test failures at all...

Same here, full build at revision 1795477 works.

-Bertrand


Re: [VOTE] Release Apache Sling Servlets Post 2.3.18

2017-05-18 Thread Julian Reschke

On 2017-05-18 08:13, Carsten Ziegeler wrote:

Julian Reschke wrote



Seen in the POM:

org.apache.jackrabbitjackrabbit-jcr-commons1.6.0provided


Why 1.6.0? It has been EOL'd many years ago...


Is something we use from that version broken? :)

We embed two classes from that jar, no runtime dependency.
...



...which makes it actually worse. It's unmaintained code, after all.

(FWIW, why embed???)

Best regards, Julian


Re: Launchpad Integration Test Errors

2017-05-18 Thread Carsten Ziegeler
Interesting, I did a full build several times now and I don't get any
test failures at all.

I doubt that it's related to commons scheduler as this is still on the
old version 2.5.2

Regards
Carsten

Daniel Klco wrote
> Hey All,
> 
> I'm seeing 5 launchpad test errors on the current trunk:
> 
> Failed tests:
> 
>   FullTextIndexingTest.testUploadedPdfIsIndexed:117 RetryLoop failed,
> condition is false after 45 seconds: A document containing 'Excepteur' is
> found under /tmp/test-FullTextIndexingTest
> 
>   FullTextIndexingTest.testUploadedPdfIsIndexed:117 RetryLoop failed,
> condition is false after 45 seconds: A document containing 'some text that
> we will search for' is found under /var/test-FullTextIndexingTest
> 
>   FullTextIndexingTest.testUploadedPdfIsIndexed:117 RetryLoop failed,
> condition is false after 45 seconds: A document containing 'un autre PDF
> pour le test fulltext' is found under /libs/test-FullTextIndexingTest
> 
> 
> InstallManyBundlesTest.installManyBundles:173->installAndCheckBundle:143->assertActiveBundle:112
> Did not get state=Active and version=42.42.42 within 1 msec, got null /
> null
> 
> 
> InstallManyBundlesTest.installAndUpgradeBundleManyTimes:153->installAndCheckBundle:143->assertActiveBundle:112
> Did not get state=Active and version=42.0.0 within 1 msec, got null /
> null
> 
> I don't feel like this was happening until recently. Perhaps introduced
> with the recent Commons Scheduler? You can reproduce the issue off the
> trunk by running the launchpad integration tests as such:
> 
> mvn test -Dtest=**/integrationtest/**/*Test.java
> 
> Thanks,
> Dan
> 


 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org


Re: [VOTE] Release Apache Sling Servlets Post 2.3.18

2017-05-18 Thread Carsten Ziegeler
Julian Reschke wrote

> 
> Seen in the POM:
> 
> org.apache.jackrabbitjackrabbit-jcr-commons1.6.0provided
> 
> 
> Why 1.6.0? It has been EOL'd many years ago...
> 
Is something we use from that version broken? :)

We embed two classes from that jar, no runtime dependency.

Regards
Carsten

 

-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org