[jira] [Resolved] (SLING-7006) When an error occurs, the Sling Post responses contain change log of paths which did not change
[ https://issues.apache.org/jira/browse/SLING-7006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Edelson resolved SLING-7006. --- Resolution: Fixed fixed in r1801663 > When an error occurs, the Sling Post responses contain change log of paths > which did not change > --- > > Key: SLING-7006 > URL: https://issues.apache.org/jira/browse/SLING-7006 > Project: Sling > Issue Type: Bug > Components: Servlets >Affects Versions: Servlets Post 2.3.20 >Reporter: Justin Edelson >Assignee: Justin Edelson > Fix For: Servlets Post 2.3.22 > > > When an error occurs during the handling of a POST request, the change log in > the HTML and JSON response will be populated with paths which did not change. > We should just omit the change log when an error occurs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (SLING-7006) When an error occurs, the Sling Post responses contain change log of paths which did not change
Justin Edelson created SLING-7006: - Summary: When an error occurs, the Sling Post responses contain change log of paths which did not change Key: SLING-7006 URL: https://issues.apache.org/jira/browse/SLING-7006 Project: Sling Issue Type: Bug Components: Servlets Affects Versions: Servlets Post 2.3.20 Reporter: Justin Edelson Assignee: Justin Edelson Fix For: Servlets Post 2.3.22 When an error occurs during the handling of a POST request, the change log in the HTML and JSON response will be populated with paths which did not change. We should just omit the change log when an error occurs. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (SLING-6703) Sling Post Servlet: Do not hide original exception in AbstractPostResponse.setError
[ https://issues.apache.org/jira/browse/SLING-6703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated SLING-6703: --- Description: Currently {{AbstractPostResponse.setError}} (https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java#L221) always ignores the given {{Throwable}} and just creates a new generic {{SlingException}}. To e.g. allow {{SlingPostProcessor}} to throw meaningful exceptions which appear in the response body, the given exception should not be wrapped but just the given throwable's message text should be given out in the document. was: Currently {{AbstractPostResponse.setError}} (https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java#L221) always ignores the given {{Throwable}} and just creates a new generic {{SlingException}}. To e.g. allow {{SlingPostProcessor}} to throw meaningful exceptions which occur in the response body, the given exception should not be wrapped but just the given throwable's message text should be given out in the document. > Sling Post Servlet: Do not hide original exception in > AbstractPostResponse.setError > --- > > Key: SLING-6703 > URL: https://issues.apache.org/jira/browse/SLING-6703 > Project: Sling > Issue Type: Improvement > Components: Servlets >Affects Versions: Servlets Post 2.3.14 >Reporter: Konrad Windszus >Assignee: Konrad Windszus > Fix For: Servlets Post 2.3.16 > > > Currently {{AbstractPostResponse.setError}} > (https://github.com/apache/sling/blob/4df9ab2d6592422889c71fa13afd453a10a5a626/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/AbstractPostResponse.java#L221) > always ignores the given {{Throwable}} and just creates a new generic > {{SlingException}}. > To e.g. allow {{SlingPostProcessor}} to throw meaningful exceptions which > appear in the response body, the given exception should not be wrapped but > just the given throwable's message text should be given out in the document. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-6955) Convert Sling website to JBake and gitpubsub
[ https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082165#comment-16082165 ] Bertrand Delacretaz commented on SLING-6955: Thanks [~sseif...@pro-vision.de] for your feedback! The following commits should have fixed all this, the /ng/ pages are updated: {code} 55a9a87 Hide syntax markers which are not implemented so far 4c87326 Fix SLING-4161 link 2d5d2f3 Fix code blocks which used tabs instead of spaces 337229c Also ignore html code block marker 05478cf Reactivate anchor links to sections 8d63c07 Update TODO in README {code} The code blocks and broken link issues required tweaking the content, due to slight differences in the markdown parsers and slightly incorrect content. The section headers do not display a paragraph sign (not sure how that was implemented) but they point to the section links. The only thing that I didn't fix so far is the "last changed by" information, I'm not sure how to get a reliable last changed date in a simple way. Maybe generating a "page history" link to the Git source of the content would be more useful? For now I have added that to the TODOs at https://github.com/apache/sling-site/blob/master/README.md > Convert Sling website to JBake and gitpubsub > > > Key: SLING-6955 > URL: https://issues.apache.org/jira/browse/SLING-6955 > Project: Sling > Issue Type: Bug > Components: Site >Reporter: Bertrand Delacretaz >Assignee: Bertrand Delacretaz > > I've started experimenting with JBake to generate the Sling website. If that > works well we might switch to that + gitpubsub to have a more flexible way to > generate the site. > My current experiment is at https://github.com/bdelacretaz/sling-jbake, at > this point the site starts looking like the current one and many pages work > well. > Internal links will need to be converted, all *.md files need a more complete > "front matter" section, currently I have a stub for that, and I think images > need to move under the assets folder. > To play with that, generate the site with the bake.sh script (setup > shamelessly copied from https://github.com/apache/incubator-tamaya-site) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: [DISCUSS] wrong conversion typisation in SCD source
Thanks Simo! Cheers, Tim 2017-07-11 13:57 GMT+02:00 Simone Tripodi : > Verified in r1801580[0] > best, > -Simo > > [0] https://svn.apache.org/viewvc?view=revision&revision=1801580 > > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi > > On Tue, Jul 11, 2017 at 11:22 AM, Simone Tripodi > wrote: > >> Hi mates, >> I verified with a test case & the debugger that the warning is not >> harmful and that can be suppressed, the only issue is at compile time but >> at runtime typisation is correct. >> Sorry for the noise! >> -Simo >> >> >> >> http://people.apache.org/~simonetripodi/ >> http://www.99soft.org/ >> >> On Tue, Jul 11, 2017 at 1:06 AM, Tommaso Teofili < >> tommaso.teof...@gmail.com> wrote: >> >>> +1 thanks Simo >>> >>> Il giorno lun 10 lug 2017 alle 16:30 Timothee Maret >>> ha scritto: >>> Hi Simo! I guess the best is to JIRA with a failing test :-) I don't think this is tracked anywhere. Cheers, Timothee 2017-07-10 15:05 GMT+02:00 Simone Tripodi : > Hi mates, > there still is a completely wrong type conversion in the source code which > can potentially throw unexpected troubles... > Did you have a chance already to have a look at it? > Would it be ok filling an issue to track it and avoid to release such > error in the next release? > TIA! > -Simo > > [1] https://svn.apache.org/viewvc/sling/trunk/contrib/ > extensions/distribution/core/src/main/java/org/apache/ > sling/distribution/resources/impl/common/SimpleReadableResource.java? > view=markup#l123 > > http://people.apache.org/~simonetripodi/ > http://twitter.com/simonetripodi > >>> >> >
Re: [DISCUSS] wrong conversion typisation in SCD source
Verified in r1801580[0] best, -Simo [0] https://svn.apache.org/viewvc?view=revision&revision=1801580 http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Tue, Jul 11, 2017 at 11:22 AM, Simone Tripodi wrote: > Hi mates, > I verified with a test case & the debugger that the warning is not harmful > and that can be suppressed, the only issue is at compile time but at > runtime typisation is correct. > Sorry for the noise! > -Simo > > > > http://people.apache.org/~simonetripodi/ > http://www.99soft.org/ > > On Tue, Jul 11, 2017 at 1:06 AM, Tommaso Teofili < > tommaso.teof...@gmail.com> wrote: > >> +1 thanks Simo >> >> Il giorno lun 10 lug 2017 alle 16:30 Timothee Maret >> ha scritto: >> >>> Hi Simo! >>> >>> I guess the best is to JIRA with a failing test :-) >>> I don't think this is tracked anywhere. >>> >>> Cheers, >>> >>> Timothee >>> >>> 2017-07-10 15:05 GMT+02:00 Simone Tripodi : >>> >>> > Hi mates, >>> > there still is a completely wrong type conversion in the source code >>> which >>> > can potentially throw unexpected troubles... >>> > Did you have a chance already to have a look at it? >>> > Would it be ok filling an issue to track it and avoid to release such >>> > error in the next release? >>> > TIA! >>> > -Simo >>> > >>> > [1] https://svn.apache.org/viewvc/sling/trunk/contrib/ >>> > extensions/distribution/core/src/main/java/org/apache/ >>> > sling/distribution/resources/impl/common/SimpleReadableResource.java? >>> > view=markup#l123 >>> > >>> > http://people.apache.org/~simonetripodi/ >>> > http://twitter.com/simonetripodi >>> > >>> >> >
Re: [VOTE] Release Apache Sling Pipes version 1.0.2
On Tue, Jul 11, 2017 at 10:55 AM, Nicolas Peltier wrote: > ...Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1753/ +1 for the release of SHA1(org.apache.sling.pipes-1.0.2-source-release.zip)= a1bdbe4bdeffe748ce225182320a30813100a82e checked signatures, build and svn tag. -Bertrand
[jira] [Resolved] (SLING-7005) Remove Java 7 from build configurations
[ https://issues.apache.org/jira/browse/SLING-7005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-7005. Resolution: Fixed All Java 7 jobs removed > Remove Java 7 from build configurations > --- > > Key: SLING-7005 > URL: https://issues.apache.org/jira/browse/SLING-7005 > Project: Sling > Issue Type: Bug > Components: CI >Reporter: Robert Munteanu >Assignee: Robert Munteanu > > Since the ASF Jenkins instance will stop supporting Maven jobs with Java 7, > we will it from the build configurations. > See > https://lists.apache.org/thread.html/894477abf58220adf27c95b74e0225acfa756e6ed195e40475d1f826@%3Cdev.sling.apache.org%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SLING-7004) Deadlock at startup in Commons Scheduler
[ https://issues.apache.org/jira/browse/SLING-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082065#comment-16082065 ] Carsten Ziegeler commented on SLING-7004: - The schedule method locks the current proxy but then calls unschedule which iterates over all proxies and syncs on each of them. So if schedule is called concurrently with two different proxies this deadlock can occur. I think the easiest solution is to use a single global lock for each operation, instead of smaller individual locks on the proxy level > Deadlock at startup in Commons Scheduler > > > Key: SLING-7004 > URL: https://issues.apache.org/jira/browse/SLING-7004 > Project: Sling > Issue Type: Bug > Components: Commons >Reporter: Chetan Mehrotra > Fix For: Commons Scheduler 2.6.4 > > Attachments: threaddump.log > > > Saw following deadlock in one of the startups with 2.6.2 release. Logs > [attached|^threaddump.log] > {noformat} > Found one Java-level deadlock: > = > "Apache Sling Repository Startup Thread": > waiting to lock monitor 0x7f3eec6eb318 (object 0xe3f944e0, a > org.apache.sling.commons.scheduler.impl.SchedulerProxy), > which is held by "FelixStartLevel" > "FelixStartLevel": > waiting to lock monitor 0x7f3e610de918 (object 0xe798fc58, a > org.apache.sling.commons.scheduler.impl.SchedulerProxy), > which is held by "Apache Sling Repository Startup Thread" > Java stack information for the threads listed above: > === > "Apache Sling Repository Startup Thread": > at > org.apache.sling.commons.scheduler.impl.QuartzScheduler.unschedule(QuartzScheduler.java:555) > - waiting to lock <0xe3f944e0> (a > org.apache.sling.commons.scheduler.impl.SchedulerProxy) > at > org.apache.sling.commons.scheduler.impl.QuartzScheduler.scheduleJob(QuartzScheduler.java:601) > - locked <0xe798fc58> (a > org.apache.sling.commons.scheduler.impl.SchedulerProxy) > at > org.apache.sling.commons.scheduler.impl.QuartzScheduler.schedule(QuartzScheduler.java:532) > at > org.apache.sling.commons.scheduler.impl.WhiteboardHandler.scheduleJob(WhiteboardHandler.java:271) > at > org.apache.sling.commons.scheduler.impl.WhiteboardHandler.trySchedulePeriod(WhiteboardHandler.java:229) > at > org.apache.sling.commons.scheduler.impl.WhiteboardHandler.register(WhiteboardHandler.java:189) > at > org.apache.sling.commons.scheduler.impl.WhiteboardHandler.registerRunnable(WhiteboardHandler.java:146) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:497) > at > org.apache.felix.scr.impl.inject.BaseMethod.invokeMethod(BaseMethod.java:224) > at > org.apache.felix.scr.impl.inject.BaseMethod.access$500(BaseMethod.java:39) > at > org.apache.felix.scr.impl.inject.BaseMethod$Resolved.invoke(BaseMethod.java:617) > at > org.apache.felix.scr.impl.inject.BaseMethod.invoke(BaseMethod.java:501) > at > org.apache.felix.scr.impl.inject.BindMethod.invoke(BindMethod.java:655) > at > org.apache.felix.scr.impl.manager.DependencyManager.doInvokeBindMethod(DependencyManager.java:1722) > at > org.apache.felix.scr.impl.manager.DependencyManager.invokeBindMethod(DependencyManager.java:1699) > at > org.apache.felix.scr.impl.manager.SingleComponentManager.invokeBindMethod(SingleComponentManager.java:372) > at > org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:320) > at > org.apache.felix.scr.impl.manager.DependencyManager$MultipleDynamicCustomizer.addedService(DependencyManager.java:291) > at > org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1215) > at > org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.customizerAdded(ServiceTracker.java:1136) > at > org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.trackAdding(ServiceTracker.java:945) > at > org.apache.felix.scr.impl.manager.ServiceTracker$AbstractTracked.track(ServiceTracker.java:881) > at > org.apache.felix.scr.impl.manager.ServiceTracker$Tracked.serviceChanged(ServiceTracker.java:1167) > at > org.apache.felix.scr.impl.BundleComponentActivator$ListenerInfo.serviceChanged(BundleComponentActivator.java:127) > at > org.apache.felix.framework.EventDispatcher.invokeServiceListenerCallback(EventDispatcher.java:990) > at > org.apac
Re: [Fwd: [JENKINS] [IMPORTANT] - Jenkins Migration and Upgrade (And JDK7 deprecation)]
On Tue, 2017-06-27 at 15:48 +, Stefan Seifert wrote: > i'm ok with 1) > we still have the compile and signature check in the poms. > > i cannot remember any problems in in the last 1-2 years that where > related to differences between the JDK versions. Done via https://issues.apache.org/jira/browse/SLING-7005 . Robert > > stefan > > > -Original Message- > > From: Robert Munteanu [mailto:romb...@apache.org] > > Sent: Tuesday, June 27, 2017 11:39 AM > > To: dev@sling.apache.org > > Subject: [Fwd: [JENKINS] [IMPORTANT] - Jenkins Migration and > > Upgrade (And > > JDK7 deprecation)] > > > > Hi, > > > > In two weeks the ASF Jenkins instance will stop supporting JDK 7 > > for > > Maven jobs (details attached). > > > > There will be an impact for us as we have a large number of jobs > > fitting this description. > > > > There are two ways out: > > > > 1) Remove the Java 7 jobs, as we're moving towards Java 8 anyway > > 2) Switch to the freestyle job type > > > > The downside of 1) is that we will no longer test with Java 7. > > The downside of 2) is that we will no longer have automatic job > > dependencies calculated and we will have to either > > > > a) manually maintain the dependencies between jobs > > b) live with stale jobs and/or manually trigger them > > > > I would incline towards 1), but I would like to hear what others > > think > > as well. > > > > Thanks, > > > > Robert
[jira] [Commented] (SLING-920) Sling Jenkins setup
[ https://issues.apache.org/jira/browse/SLING-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16082030#comment-16082030 ] Robert Munteanu commented on SLING-920: --- Moved {{sling-trunk-tooling-1.7}} to {{sling-trunk-tooling-1.8}} ( see SLING-7005 for reasoning ) > Sling Jenkins setup > --- > > Key: SLING-920 > URL: https://issues.apache.org/jira/browse/SLING-920 > Project: Sling > Issue Type: Task > Components: CI >Reporter: Bertrand Delacretaz > > Use this issue to record changes to the Jenkins setup at > https://builds.apache.org/view/S-Z/view/Sling/ -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: [VOTE] Release Apache Sling Pipes version 1.0.2
On Tue, 2017-07-11 at 10:55 +0200, Nicolas Peltier wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part
Re: [VOTE] Release Apache Sling Pipes version 1.0.2
+1 (non binding) Checked the signatures and build. Regards, Timothee 2017-07-11 10:55 GMT+02:00 Nicolas Peltier : > Hi, > > We solved 13 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12338435 > > There are still some outstanding issues: > https://issues.apache.org/jira/browse/SLING-6593 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1753/ > > You can use this UNIX script to download the release and verify the > signatures: > http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh > > Usage: > sh check_staged_release.sh 1753 /tmp/sling-staging > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. >
[jira] [Created] (SLING-7005) Remove Java 7 from build configurations
Robert Munteanu created SLING-7005: -- Summary: Remove Java 7 from build configurations Key: SLING-7005 URL: https://issues.apache.org/jira/browse/SLING-7005 Project: Sling Issue Type: Bug Components: CI Reporter: Robert Munteanu Assignee: Robert Munteanu Since the ASF Jenkins instance will stop supporting Maven jobs with Java 7, we will it from the build configurations. See https://lists.apache.org/thread.html/894477abf58220adf27c95b74e0225acfa756e6ed195e40475d1f826@%3Cdev.sling.apache.org%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: [DISCUSS] wrong conversion typisation in SCD source
Hi mates, I verified with a test case & the debugger that the warning is not harmful and that can be suppressed, the only issue is at compile time but at runtime typisation is correct. Sorry for the noise! -Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Tue, Jul 11, 2017 at 1:06 AM, Tommaso Teofili wrote: > +1 thanks Simo > > Il giorno lun 10 lug 2017 alle 16:30 Timothee Maret > ha scritto: > >> Hi Simo! >> >> I guess the best is to JIRA with a failing test :-) >> I don't think this is tracked anywhere. >> >> Cheers, >> >> Timothee >> >> 2017-07-10 15:05 GMT+02:00 Simone Tripodi : >> >> > Hi mates, >> > there still is a completely wrong type conversion in the source code >> which >> > can potentially throw unexpected troubles... >> > Did you have a chance already to have a look at it? >> > Would it be ok filling an issue to track it and avoid to release such >> > error in the next release? >> > TIA! >> > -Simo >> > >> > [1] https://svn.apache.org/viewvc/sling/trunk/contrib/ >> > extensions/distribution/core/src/main/java/org/apache/ >> > sling/distribution/resources/impl/common/SimpleReadableResource.java? >> > view=markup#l123 >> > >> > http://people.apache.org/~simonetripodi/ >> > http://twitter.com/simonetripodi >> > >> >
[jira] [Assigned] (SLING-6998) PathPipe should use ResourceUtil.getOrCreateResource
[ https://issues.apache.org/jira/browse/SLING-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-6998: -- Assignee: Nicolas Peltier > PathPipe should use ResourceUtil.getOrCreateResource > > > Key: SLING-6998 > URL: https://issues.apache.org/jira/browse/SLING-6998 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 1.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier > > there is logic duplication there that should go away, plus some missing unit > tests (resolvable with later versions of sling mocks) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[VOTE] Release Apache Sling Pipes version 1.0.2
Hi, We solved 13 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12338435 There are still some outstanding issues: https://issues.apache.org/jira/browse/SLING-6593 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1753/ You can use this UNIX script to download the release and verify the signatures: http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh Usage: sh check_staged_release.sh 1753 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ... This majority vote is open for at least 72 hours.
[jira] [Updated] (SLING-6078) add a fluent api to generate a sling pipe
[ https://issues.apache.org/jira/browse/SLING-6078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier updated SLING-6078: --- Issue Type: New Feature (was: Improvement) > add a fluent api to generate a sling pipe > - > > Key: SLING-6078 > URL: https://issues.apache.org/jira/browse/SLING-6078 > Project: Sling > Issue Type: New Feature > Components: Extensions >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier > Fix For: Pipes 1.0.2 > > > it would be cool that plumber or sthing like PipeBuilder allows to generate a > pipe, writing the serialization of it, with simple API > (thx [~bdelacretaz] for the idea!) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (SLING-7002) PipeBuilder with() API should manage Object, not Strings
[ https://issues.apache.org/jira/browse/SLING-7002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier reassigned SLING-7002: -- Assignee: Nicolas Peltier > PipeBuilder with() API should manage Object, not Strings > > > Key: SLING-7002 > URL: https://issues.apache.org/jira/browse/SLING-7002 > Project: Sling > Issue Type: Bug > Components: Extensions >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier > Fix For: Pipes 1.0.2 > > > with(String,String) API is not working with boolean properties we have in a > few pipes, like Path, or Authorizable. > should be with(String, Object) -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Resolved] (SLING-6998) PathPipe should use ResourceUtil.getOrCreateResource
[ https://issues.apache.org/jira/browse/SLING-6998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Peltier resolved SLING-6998. Resolution: Fixed Fix Version/s: Pipes 1.0.2 fixed in r1801566 > PathPipe should use ResourceUtil.getOrCreateResource > > > Key: SLING-6998 > URL: https://issues.apache.org/jira/browse/SLING-6998 > Project: Sling > Issue Type: Improvement > Components: Extensions >Affects Versions: Pipes 1.0.2 >Reporter: Nicolas Peltier >Assignee: Nicolas Peltier > Fix For: Pipes 1.0.2 > > > there is logic duplication there that should go away, plus some missing unit > tests (resolvable with later versions of sling mocks) -- This message was sent by Atlassian JIRA (v6.4.14#64029)