[jira] [Resolved] (SLING-7165) CAConfig Impl: Potential data loss when saving multiple nested configuration lists

[Stefan Seifert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-7165.
---
Resolution: Fixed

Completed: At revision: 1810138  


> CAConfig Impl: Potential data loss when saving multiple nested configuration 
> lists
> --
>
> Key: SLING-7165
> URL: https://issues.apache.org/jira/browse/SLING-7165
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Context-Aware Configuration Impl 1.4.4
>Reporter: Stefan Seifert
>Assignee: Stefan Seifert
> Fix For: Context-Aware Configuration Impl 1.4.6
>
>
> as reported in https://wcm-io.atlassian.net/browse/WCON-39:
> {quote}
> The following porblem has been discovered by one of our teammates. Consider 
> the following issue.
> * Config A has a list of objects let's call B, where B is an array  of 
> objects, whereeach object in B is a label and list of  objects let's call it 
> C. 
> * Create for each  item in B, a list of items  then save.
> * Try to update the label in any item in B, as a result each sublist  under 
> each object in B, will be deleted as a result. 
> *
> *The problem is i found it in code, you delete all items in the first level, 
> and as a result in the second level. 
> {code}
>  public boolean persistConfigurationCollection(ResourceResolver 
> resourceResolver, String configResourceCollectionParentPath, 
> ConfigurationCollectionPersistData data) {
> if (!this.config.enabled()) {
> return false;
> } else {
> Resource configResourceParent = 
> this.getOrCreateResource(resourceResolver, 
> configResourceCollectionParentPath, data.getProperties());
> // you delete below all list of items. and subnodes of it
> this.deleteChildren(configResourceParent);
> Iterator var5 = data.getItems().iterator();
> while(var5.hasNext()) {
> ConfigurationPersistData item = 
> (ConfigurationPersistData)var5.next();
> String path = configResourceParent.getPath() + "/" + 
> item.getCollectionItemName();
> this.getOrCreateResource(resourceResolver, path, 
> item.getProperties());
> }
> this.commit(resourceResolver, configResourceCollectionParentPath);
> return true;
> }
> }
> {code}
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Ok to replace sling.apache.org with the new JBake-generated site ?

[Justin Edelson]

+1

Thanks for driving this Bertrand!

On Fri, Sep 29, 2017 at 12:50 PM Julian Sedding  wrote:

> Thanks for the great work Bertrand! That should make contributing
> documentation simpler & more transparent.
>
> Regards
> Julian
>
> On Thu, Sep 28, 2017 at 8:21 PM, Stefan Seifert 
> wrote:
> > great, thanks for all the work!
> >
> > btw. on github, there is still a remnant oft he sling-sling-site repo:
> > https://github.com/apache/sling-sling-site
> >
> > and can we enable the "dual master" git mode fort he sling-site repo?
> would be a good testcase for use before doing the full migration.
> > https://github.com/apache/sling-site
> >
> > stefan
> >
> >>-Original Message-
> >>From: Bertrand Delacretaz [mailto:bdelacre...@apache.org]
> >>Sent: Thursday, September 28, 2017 7:23 PM
> >>To: dev
> >>Subject: Re: Ok to replace sling.apache.org with the new JBake-generated
> >>site ?
> >>
> >>On Thu, Sep 28, 2017 at 2:42 PM, Bertrand Delacretaz
> >> wrote:
> ... I have requested activation of the
>  new site, https://issues.apache.org/jira/browse/INFRA-15186 ...
> >>
> >>The new site is live at http://sling.apache.org , source at
> >>https://git-wip-us.apache.org/repos/asf?p=sling-site.git
> >>
> >>-Bertrand
> >
>

Re: Ok to replace sling.apache.org with the new JBake-generated site ?

[Julian Sedding]

Thanks for the great work Bertrand! That should make contributing
documentation simpler & more transparent.

Regards
Julian

On Thu, Sep 28, 2017 at 8:21 PM, Stefan Seifert  wrote:
> great, thanks for all the work!
>
> btw. on github, there is still a remnant oft he sling-sling-site repo:
> https://github.com/apache/sling-sling-site
>
> and can we enable the "dual master" git mode fort he sling-site repo? would 
> be a good testcase for use before doing the full migration.
> https://github.com/apache/sling-site
>
> stefan
>
>>-Original Message-
>>From: Bertrand Delacretaz [mailto:bdelacre...@apache.org]
>>Sent: Thursday, September 28, 2017 7:23 PM
>>To: dev
>>Subject: Re: Ok to replace sling.apache.org with the new JBake-generated
>>site ?
>>
>>On Thu, Sep 28, 2017 at 2:42 PM, Bertrand Delacretaz
>> wrote:
... I have requested activation of the
 new site, https://issues.apache.org/jira/browse/INFRA-15186 ...
>>
>>The new site is live at http://sling.apache.org , source at
>>https://git-wip-us.apache.org/repos/asf?p=sling-site.git
>>
>>-Bertrand
>

Re: Deprecate Commons Testing?

[Julian Sedding]

+ 1 & +1 to stefan's suggestions

Regards
Julian

On Thu, Sep 28, 2017 at 6:07 PM, Stefan Seifert  wrote:
> +1
>
> perhaps we can start making a new release with all classes deprecated, and 
> updating pom references to this.
> then it's easier to find it's usage and replace it when one touches a module.
> replacing all usages at once will be too tedious because the alternatives are 
> not drop-in replacements.
>
> stefan
>
>>-Original Message-
>>From: Konrad Windszus [mailto:konra...@gmx.de]
>>Sent: Thursday, September 28, 2017 1:03 PM
>>To: dev@sling.apache.org
>>Subject: Deprecate Commons Testing?
>>
>>Currently Commons Testing can be found in bundles/commons/testing
>>(https://github.com/apache/sling/tree/trunk/bundles/commons/testing)
>>although I would rather expect it below testing
>>(https://github.com/apache/sling/tree/trunk/testing) in SVN.
>>Apart from that library seems to be rather old and not too actively
>>maintained. For most of its classes there are nowadays better replacements:
>>
>>Package
>>1. o.a.s.commons.testing.integration: Rather either Teleporter or the
>>org.apache.sling.testing.clients should be used
>>2. o.a.s.commons.testing.jcr: jcr-mock should be used instead
>>3. o.a.s.commons.testing.junit: should be converted to rules
>>(org.apache.sling.testing.rules)
>>4. o.a.s.commons.testing.osgi: osgi-mock should be used instead
>>5. o.a.s.commons.testing.sling: sling-mock should be used instead
>>6. org.apache.sling.commons.testing.util: if really useful can maybe moved
>>to sling-mock as well
>>
>>Apart from that there are IMHO better alternatives for all those classes
>>available, there are certain limitations which are IMHO not easy to fix:
>>
>>1. o.a.s.commons.testing.jcr uses Jackrabbit 2 only and never Oak, that
>>means that the ITs are pretty far away from what we ship now in Sling.
>>2. o.a.s.commons.testing.jcr is currently not compatible with Java 9
>>(https://issues.apache.org/jira/browse/SLING-7159)
>>
>>WDYT?
>>Should we add deprecation hints to all those classes pointing to the better
>>alternatives and spin a last release?
>>
>>Currently we have way too many alternatives when it comes to testing
>>support and focusing only on one way of doing things certainly helps to
>>reduce the maintenance effort.
>>The next candidate to deprecate would be Testing Tools...
>>
>>Konrad
>

[jira] [Created] (SLING-7165) CAConfig Impl: Potential data loss when saving multiple nested configuration lists

[Stefan Seifert (JIRA)]

Stefan Seifert created SLING-7165:
-

 Summary: CAConfig Impl: Potential data loss when saving multiple 
nested configuration lists
 Key: SLING-7165
 URL: https://issues.apache.org/jira/browse/SLING-7165
 Project: Sling
  Issue Type: Bug
  Components: Extensions
Affects Versions: Context-Aware Configuration Impl 1.4.4
Reporter: Stefan Seifert
Assignee: Stefan Seifert
 Fix For: Context-Aware Configuration Impl 1.4.6


as reported in https://wcm-io.atlassian.net/browse/WCON-39:

{quote}
The following porblem has been discovered by one of our teammates. Consider the 
following issue.
* Config A has a list of objects let's call B, where B is an array  of objects, 
whereeach object in B is a label and list of  objects let's call it C. 
* Create for each  item in B, a list of items  then save.
* Try to update the label in any item in B, as a result each sublist  under 
each object in B, will be deleted as a result. 
*
*The problem is i found it in code, you delete all items in the first level, 
and as a result in the second level. 
{code}
 public boolean persistConfigurationCollection(ResourceResolver 
resourceResolver, String configResourceCollectionParentPath, 
ConfigurationCollectionPersistData data) {
if (!this.config.enabled()) {
return false;
} else {
Resource configResourceParent = 
this.getOrCreateResource(resourceResolver, configResourceCollectionParentPath, 
data.getProperties());
// you delete below all list of items. and subnodes of it
this.deleteChildren(configResourceParent);
Iterator var5 = data.getItems().iterator();

while(var5.hasNext()) {
ConfigurationPersistData item = 
(ConfigurationPersistData)var5.next();
String path = configResourceParent.getPath() + "/" + 
item.getCollectionItemName();
this.getOrCreateResource(resourceResolver, path, 
item.getProperties());
}

this.commit(resourceResolver, configResourceCollectionParentPath);
return true;
}
}

{code}
{quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [RT] Updates to the provisioning model - run mode

[Carsten Ziegeler]

Stefan Seifert wrote>

>> * No support for run modes in the model - run modes can be modeled
>> through separate features
> 
> is there a plan to generally remove the "run mode" concept from sling - or 
> just not express it in the feature model?
> if it is kept - where come the features and run modes together?
> 

I think we should get away from run modes in general. We should have
never introduced this at runtime to allow code to do different things
depending on the run mode.
However, if someone feels strong about supporting run modes at runtime,
this could be easily implemented: as outlined you would have different
features for the run modes. These could either use an OSGi configuration
or a framework property to indicate the run mode and a service at
runtime can pick this up.

Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

RE: [RT] Updates to the provisioning model - maven coordinates

[Stefan Seifert]

>Carsten Ziegeler wrote>
>
>> Thanks for the pointer Stefan. We should definitely support this, I'll
>> update the code.
>> For some reason we have based the provisioning model and therefore the
>> feature model on
>> https://ops4j1.jira.com/wiki/spaces/paxurl/pages/3833866/Mvn+Protocol
>>
>
>I think the main reason is that Apache Karaf uses this syntax in their
>features.
>
>We can think about supporting both as it is easy to detect which of the
>two is used. When writing we use the maven coordinates.

makes sense, we've done this in CONGA as well [1] - it's easy to distinguish 
them when parsing.

stefan 

[1] http://devops.wcm.io/conga/yaml-definitions.html#Files

RE: [RT] Updates to the provisioning model - run mode

[Stefan Seifert]

>* No support for run modes in the model - run modes can be modeled
>through separate features

is there a plan to generally remove the "run mode" concept from sling - or just 
not express it in the feature model?
if it is kept - where come the features and run modes together?

stefan

Re: [RT] Updates to the provisioning model - maven coordinates

[Carsten Ziegeler]

Carsten Ziegeler wrote>

> Thanks for the pointer Stefan. We should definitely support this, I'll
> update the code.
> For some reason we have based the provisioning model and therefore the
> feature model on
> https://ops4j1.jira.com/wiki/spaces/paxurl/pages/3833866/Mvn+Protocol
> 

I think the main reason is that Apache Karaf uses this syntax in their
features.

We can think about supporting both as it is easy to detect which of the
two is used. When writing we use the maven coordinates.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [RT] Updates to the provisioning model - maven coordinates

[Carsten Ziegeler]

Stefan Seifert wrote>

>> One minor thing, the current proposal uses the Maven coordinates to
>> describe artifacts. It's using the path part of a maven url, so
>> basically group id, artifact id, version are separated by a slash. It
>> seems that the notation of separating these things by a colon is more
>> common/natural. And we'll probably switch to that.
> 
> i always stumbled about this in the current provisioning model as well - 
> afaik this is the most used standard to describe maven artifact coordinates 
> in a single string:
> https://maven.apache.org/pom.html#Maven_Coordinates
> 
> that means the following syntax variants are allowed:
> 
> groupId:artifactId:version
> groupId:artifactId:packaging:version
> groupId:artifactId:packaging:classifier:version

Thanks for the pointer Stefan. We should definitely support this, I'll
update the code.
For some reason we have based the provisioning model and therefore the
feature model on
https://ops4j1.jira.com/wiki/spaces/paxurl/pages/3833866/Mvn+Protocol

> 
> in the slingstart maven plugin we added support for special maven integration:
> - including properties from maven pom inside provisioning model
> - leaving out artifact version from provisioning model and getting it from 
> the pom dependencies
> 
> is it planned to support something like this in sling feature as well? this 
> was very useful when provision models where declared in context of a maven 
> reactor build with all versions in one place (e.g. central parent pom). 
> otherwise you need to define the versions twice - in the maven poms and in 
> the sling feature/provision model, which is a source for errors.
> 
I think the answer is yes and no :)

The feature model itself does not support this - to keep it simple. The
tooling, e.g. the maven tooling can read a file and post process it and
I hope that we can do all the maven magic there without having to bake
something into the model. Properties should be easy, versioning might be
a little bit more tricky, but I think it should be doable.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

RE: [VOTE] Release Apache Sling Thread Support 3.2.10

[Stefan Seifert]

+1

all tests running fine on windows.

stefan

RE: [RT] Updates to the provisioning model - maven coordinates

[Stefan Seifert]

>One minor thing, the current proposal uses the Maven coordinates to
>describe artifacts. It's using the path part of a maven url, so
>basically group id, artifact id, version are separated by a slash. It
>seems that the notation of separating these things by a colon is more
>common/natural. And we'll probably switch to that.

i always stumbled about this in the current provisioning model as well - afaik 
this is the most used standard to describe maven artifact coordinates in a 
single string:
https://maven.apache.org/pom.html#Maven_Coordinates

that means the following syntax variants are allowed:

groupId:artifactId:version
groupId:artifactId:packaging:version
groupId:artifactId:packaging:classifier:version

in the slingstart maven plugin we added support for special maven integration:
- including properties from maven pom inside provisioning model
- leaving out artifact version from provisioning model and getting it from the 
pom dependencies

is it planned to support something like this in sling feature as well? this was 
very useful when provision models where declared in context of a maven reactor 
build with all versions in one place (e.g. central parent pom). otherwise you 
need to define the versions twice - in the maven poms and in the sling 
feature/provision model, which is a source for errors.

stefan 

Re: sling-site git commit: Update README

[Bertrand Delacretaz]

On Fri, Sep 29, 2017 at 3:10 PM, Carsten Ziegeler  wrote:
>  ...What exactly does "sync the `target/sling-site-*` folder to the
> `asf-site` branch" mean?...

I have put suggested commands at https://github.com/apache/sling-site

-Bertrand

[website] tag support added

[Bertrand Delacretaz]

Hi,

Start at http://sling.apache.org/tags/core.html for example.

I have added an initial set of tags to all pages, just did a quick
pass, feel free to tweak!

-Bertrand

Re: sling-site git commit: Update README

[Carsten Ziegeler]

 What exactly does "sync the `target/sling-site-*` folder to the
`asf-site` branch" mean? It would be great to simply have the commands
listed there to do so.

Regards

Carsten


Bertrand Delacretaz wrote
> Repository: sling-site
> Updated Branches:
>   refs/heads/master 9de648ff4 -> b08c52ab6
> 
> 
> Update README
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/sling-site/repo
> Commit: http://git-wip-us.apache.org/repos/asf/sling-site/commit/b08c52ab
> Tree: http://git-wip-us.apache.org/repos/asf/sling-site/tree/b08c52ab
> Diff: http://git-wip-us.apache.org/repos/asf/sling-site/diff/b08c52ab
> 
> Branch: refs/heads/master
> Commit: b08c52ab646afe1fbc3b201834924204c96248d1
> Parents: 9de648f
> Author: Bertrand Delacretaz 
> Authored: Fri Sep 29 12:20:45 2017 +0200
> Committer: Bertrand Delacretaz 
> Committed: Fri Sep 29 12:20:45 2017 +0200
> 
> --
>  README.md | 60 +++---
>  1 file changed, 15 insertions(+), 45 deletions(-)
> --
> 
> 
> http://git-wip-us.apache.org/repos/asf/sling-site/blob/b08c52ab/README.md
> --
> diff --git a/README.md b/README.md
> index 10e7d8b..9ce798e 100644
> --- a/README.md
> +++ b/README.md
> @@ -1,65 +1,35 @@
> -# sling-jbake
> -Experimenting with JBake for the Apache Sling website.
> +# Apache Sling Website
> +This repository contains the content of the http://sling.apache.org/ , which 
> moved in September 2017 from
> +the Apache CMS to this JBake-generated website.
>  
> -See also https://issues.apache.org/jira/browse/SLING-6955
> -
> -## How to build the site locally  
> +## How to build and stage the site locally  
>  Clone this repository, run the below Maven command, http://localhost:8820/ 
> and enjoy.
>  
>  mvn clean package jbake:inline -Djbake.port=8820 
> -Djbake.listenAddress=0.0.0.0
> + 
> +This allows  you to experiment with your changes before eventually 
> publishing them.
>  
>  ## How to publish the website
>  Build the site using `mvn clean package` and then sync the 
> `target/sling-site-*` folder to the `asf-site` branch
>  of this Git repository, commit and push that branch.
>  
> -The ASF's gitpubsub mechanism then synchronizes that content
> -on the http://sling.apache.org website, usually within a few seconds.
> +The ASF's gitpubsub mechanism then synchronizes that content to 
> http://sling.apache.org , usually within a few seconds.
>  
>  ## TODO
> +Here's a rough list of things that need to be done after the 2017 migration 
> to gitpubsub.
>  
> -### apache.org requirements
> -* Activate all the required links checked by https://whimsy.apache.org/site/
> +We'll use jira tickets for more specific things, this is more an overview.
>  
> -### Nice to have
> -* JBake 2.5.x does not support the `[TOC]` macro but apparently that will be 
> available once JBake moves to https://github.com/vsch/flexmark-java , 
> probably in its next version as per 
> [#376](https://github.com/jbake-org/jbake/pull/376). We might wait for that 
> and just mark the TOCs as unsupported for now.
> +* Activate all the required links that https://whimsy.apache.org/site/ checks
>  * The "last changed by" information at the bottom right side of pages is 
> missing, it was quite useful. The format is like `Rev. 1692085 by rombert on 
> Tue, 21 Jul 2015 11:04:15 +`
>  
> -### Final validation, activation etc.
> -* Review all pages
> -* Resync the content with the current Sling website if needed, initially 
> synced at r1798604 and later (September 26th, 2017) resynced to svn revision 
> 1809724
> -
> -### Done
> -* Fix internal links like `refs.project-information.path` 
> -* Page header and footer, logo etc
> -* Remove unused assets files and templates (copied from JBake Groovy sample)
> -* Tables work now, needed the pegdown TABLES extension
> -* Move images and other files to /assets and convert their links
> -* Fix references like `refs.authentication-tasks.headers.excerpt` as well as 
> `.title` references -> replace with copies of those titles and excerpts, or 
> use tags to mark and select
> -* Fix remaining `refs.` links -> those are probably broken anyway
> -* Test the downloads.cgi page, requires an apache.org setup (INFRA-14390) -> 
> done at https://sling.apache.org/ng/downloads.cgi
> -* Fix broken tables: the current pegdown parser has troubles with table 
> cells containing special characters, tables containing a single dash for 
> example need to be converted to `(-)` as a workaround.
> -* Enumerate child pages in documentation/tutorials-how-tos.html and smilar 
> pages -> replaced with a manually generated list.
> -* Sitemap page
> -* Left menu layout is now correct
> -* Breadcrumbs are back.
> -* The `#!xml` and `#!java` code higlighting macros 

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

[Ian Boston (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185731#comment-16185731
 ] 

Ian Boston commented on SLING-7140:
---

Configuration information 
https://gist.github.com/ieb/f9e044e4033b8f810238fe9a27eeaa78

> Support redirects to URLs provided by the underlying datastore.
> ---
>
> Key: SLING-7140
> URL: https://issues.apache.org/jira/browse/SLING-7140
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.26, JCR Resource 3.0.4
>Reporter: Ian Boston
>
> Incorporate changes to allow OAK-6575 to work in Sling, 
> Patch available at 
> https://github.com/apache/sling/compare/trunk...ieb:OAK-6575-3-2
> Cant me applied until OAK-6575 is released in a version suitable for use in 
> Sling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

[Ian Boston (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185711#comment-16185711
 ] 

Ian Boston commented on SLING-7140:
---

Pull request:
https://github.com/apache/sling/pull/252

This depends on
Oak 1.6 Branch https://github.com/apache/jackrabbit-oak/pull/70
there is also 
Oak Trunk https://github.com/apache/jackrabbit-oak/pull/69

Documentation to follow in a Gist


> Support redirects to URLs provided by the underlying datastore.
> ---
>
> Key: SLING-7140
> URL: https://issues.apache.org/jira/browse/SLING-7140
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.26, JCR Resource 3.0.4
>Reporter: Ian Boston
>
> Incorporate changes to allow OAK-6575 to work in Sling, 
> Patch available at 
> https://github.com/apache/sling/compare/trunk...ieb:OAK-6575-3-2
> Cant me applied until OAK-6575 is released in a version suitable for use in 
> Sling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185709#comment-16185709
 ] 

ASF GitHub Bot commented on SLING-7140:
---

GitHub user ieb opened a pull request:

https://github.com/apache/sling/pull/252

SLING-7140 Support redirects to URLs provided by the underlying datastore.

This pull request contains API and pom changes which is why I am not 
committing it directly myself.
It should be squashed into a Single commit.
It depends on https://github.com/apache/jackrabbit-oak/pull/70 being merged 
and OAK 1.6.5 (or 6) being released. It will break a build if Oak 
1.6.5-SNAPSHOT does not contain that pull request.

It enables Sling to redirect requests for binaries held in Oak in a S3 
DataStore to be served by an appropriately configured CloudFront instance.

For more info and documentation see 
https://issues.apache.org/jira/browse/SLING-7140 and 
https://issues.apache.org/jira/browse/OAK-6575

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ieb/sling OAK-6575-3-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #252


commit 1127fb77567f1ca48dc243e4700ed0c0c9dc2808
Author: Ian Boston 
Date:   2017-09-07T08:57:49Z

Proposed implementation in Sling for OAK-6575 patch 3

commit a491430a8b30ec84ef66985f3af81a758eab6022
Author: Ian Boston 
Date:   2017-09-13T23:26:49Z

Using ExternalizableInputStream

commit 66623c7398743aeb141c36f817a850e90d05edf4
Author: Ian Boston 
Date:   2017-09-18T11:10:30Z

Changed suggested by Carsten on the issue, also added Private URI to the 
interface

commit c4d504ef0efc6c9d0bb85060b4b7e793880fe0d9
Author: Ian Boston 
Date:   2017-09-18T12:52:03Z

Fixed URIConverter

commit e11ec2de49b9ba76d762b342439aeeb6f50617c1
Author: Ian Boston 
Date:   2017-09-18T15:03:58Z

Using HelperData instead of Adaptable

commit 7e58c32daa0ce4e1d16ce57b7f5cfa32bd9d876d
Author: Ian Boston 
Date:   2017-09-18T15:11:11Z

Fixed missing annotations

commit e2ded1ccb771a73681d011554deda9a34df398f0
Author: Ian Boston 
Date:   2017-09-26T09:34:51Z

Fixed build issues

commit 9395dcd3b7b8f01de82d608037890ec6aac0c51d
Author: Ian Boston 
Date:   2017-09-26T10:54:02Z

Merge branch 'trunk' into OAK-6575-3-2

commit 7a35cc189031e492f85363b3b1c8b5c3f19ce544
Author: Ian Boston 
Date:   2017-09-29T10:10:45Z

OAK-6575 Fixed startup issues

commit bdce6975a77645e7e88879407c3b2e77fe2c1265
Author: Ian Boston 
Date:   2017-09-29T10:18:57Z

Fixing imports, need to fix my IDE.




> Support redirects to URLs provided by the underlying datastore.
> ---
>
> Key: SLING-7140
> URL: https://issues.apache.org/jira/browse/SLING-7140
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.26, JCR Resource 3.0.4
>Reporter: Ian Boston
>
> Incorporate changes to allow OAK-6575 to work in Sling, 
> Patch available at 
> https://github.com/apache/sling/compare/trunk...ieb:OAK-6575-3-2
> Cant me applied until OAK-6575 is released in a version suitable for use in 
> Sling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] sling pull request #252: SLING-7140 Support redirects to URLs provided by th...

[ieb]

GitHub user ieb opened a pull request:

https://github.com/apache/sling/pull/252

SLING-7140 Support redirects to URLs provided by the underlying datastore.

This pull request contains API and pom changes which is why I am not 
committing it directly myself.
It should be squashed into a Single commit.
It depends on https://github.com/apache/jackrabbit-oak/pull/70 being merged 
and OAK 1.6.5 (or 6) being released. It will break a build if Oak 
1.6.5-SNAPSHOT does not contain that pull request.

It enables Sling to redirect requests for binaries held in Oak in a S3 
DataStore to be served by an appropriately configured CloudFront instance.

For more info and documentation see 
https://issues.apache.org/jira/browse/SLING-7140 and 
https://issues.apache.org/jira/browse/OAK-6575

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ieb/sling OAK-6575-3-2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling/pull/252.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #252


commit 1127fb77567f1ca48dc243e4700ed0c0c9dc2808
Author: Ian Boston 
Date:   2017-09-07T08:57:49Z

Proposed implementation in Sling for OAK-6575 patch 3

commit a491430a8b30ec84ef66985f3af81a758eab6022
Author: Ian Boston 
Date:   2017-09-13T23:26:49Z

Using ExternalizableInputStream

commit 66623c7398743aeb141c36f817a850e90d05edf4
Author: Ian Boston 
Date:   2017-09-18T11:10:30Z

Changed suggested by Carsten on the issue, also added Private URI to the 
interface

commit c4d504ef0efc6c9d0bb85060b4b7e793880fe0d9
Author: Ian Boston 
Date:   2017-09-18T12:52:03Z

Fixed URIConverter

commit e11ec2de49b9ba76d762b342439aeeb6f50617c1
Author: Ian Boston 
Date:   2017-09-18T15:03:58Z

Using HelperData instead of Adaptable

commit 7e58c32daa0ce4e1d16ce57b7f5cfa32bd9d876d
Author: Ian Boston 
Date:   2017-09-18T15:11:11Z

Fixed missing annotations

commit e2ded1ccb771a73681d011554deda9a34df398f0
Author: Ian Boston 
Date:   2017-09-26T09:34:51Z

Fixed build issues

commit 9395dcd3b7b8f01de82d608037890ec6aac0c51d
Author: Ian Boston 
Date:   2017-09-26T10:54:02Z

Merge branch 'trunk' into OAK-6575-3-2

commit 7a35cc189031e492f85363b3b1c8b5c3f19ce544
Author: Ian Boston 
Date:   2017-09-29T10:10:45Z

OAK-6575 Fixed startup issues

commit bdce6975a77645e7e88879407c3b2e77fe2c1265
Author: Ian Boston 
Date:   2017-09-29T10:18:57Z

Fixing imports, need to fix my IDE.




---

FIY, requested move of sling-site repo to Gitbox

[Bertrand Delacretaz]

Hi,

That's at https://issues.apache.org/jira/browse/INFRA-15190 - it would
allow us to see how that works before migrating the rest to Git.

IIUC all committers will need to visite
https://gitbox.apache.org/setup/ to link their Apache and Github
accounts.

-Bertrand

Re: Website ToC considers only h2 and h3

[Bertrand Delacretaz]

On Fri, Sep 29, 2017 at 12:09 PM, Konrad Windszus  wrote:
> I just pushed the change in 
> https://git-wip-us.apache.org/repos/asf?p=sling-site.git;a=commit;h=9de648ff47e1bb0ad6c8309870fca238097a809f.

Thanks, it's live now.

-Bertrand

[jira] [Commented] (SLING-7140) Support redirects to URLs provided by the underlying datastore.

[Ian Boston (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185668#comment-16185668
 ] 

Ian Boston commented on SLING-7140:
---

Update from testing, also reported in Oak 

Tested against Sling Trunk using a patch backported to Oak 1.6. The patches are

https://github.com/apache/jackrabbit-oak/compare/1.6...ieb:OAK-6575-1.6-3?expand=1

and in Sling 

https://github.com/apache/sling/compare/trunk...ieb:OAK-6575-3-2?expand=1

There were 2 fixes to the Oak patch.
Its not viable to put a 4096 bit PKCS8 encoded private key into a OSGi 
property. The Sling provisioning model truncates it and its hard to manage, so 
this has been changed to a file. The file can be relative, but must be 
resolvable from the working directory of the JVM.
In addition a configurable minimum size limit has been added so that small 
files, can be streamed via the JVM if desired.
Also added is a log line to allow audit of all external urls. This might want 
to be at debug level, but for the moment it is at info level.

This changes need to be forward ported to Oak Trunk, although Sling doesn't 
currently use Oak 1.8-SNAPSHOT.


> Support redirects to URLs provided by the underlying datastore.
> ---
>
> Key: SLING-7140
> URL: https://issues.apache.org/jira/browse/SLING-7140
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Affects Versions: Servlets Get 2.1.26, JCR Resource 3.0.4
>Reporter: Ian Boston
>
> Incorporate changes to allow OAK-6575 to work in Sling, 
> Patch available at 
> https://github.com/apache/sling/compare/trunk...ieb:OAK-6575-3-2
> Cant me applied until OAK-6575 is released in a version suitable for use in 
> Sling.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Website ToC considers only h2 and h3

[Konrad Windszus]

I just pushed the change in 
https://git-wip-us.apache.org/repos/asf?p=sling-site.git;a=commit;h=9de648ff47e1bb0ad6c8309870fca238097a809f.

> On 29. Sep 2017, at 11:38, Bertrand Delacretaz  wrote:
> 
> On Fri, Sep 29, 2017 at 11:30 AM, Konrad Windszus  wrote:
>> ... Do you want me to propose something or are you planning to migrate the 
>> Git repo to gitbox soon?..
> 
> If you can implement what you suggest that would be great. A CSS class
> on the main title sounds great.
> 
> Commit to https://git-wip-us.apache.org/repos/asf?p=sling-site.git for
> now and when we move to gitbox we'll take care of that.
> 
> I'll work on the publishing instructions today but it looks like
> Robert has been able to publish already so the README is not totally
> off ;-)
> 
> -Bertrand

Re: Website ToC considers only h2 and h3

[Robert Munteanu]

On Fri, 2017-09-29 at 11:38 +0200, Bertrand Delacretaz wrote:
> On Fri, Sep 29, 2017 at 11:30 AM, Konrad Windszus 
> wrote:
> > ... Do you want me to propose something or are you planning to
> > migrate the Git repo to gitbox soon?..
> 
> If you can implement what you suggest that would be great. A CSS
> class
> on the main title sounds great.
> 
> Commit to https://git-wip-us.apache.org/repos/asf?p=sling-site.git
> for
> now and when we move to gitbox we'll take care of that.
> 
> I'll work on the publishing instructions today but it looks like
> Robert has been able to publish already so the README is not totally
> off ;-)

Yup, it's good enough for me :-)

>From memory, the steps are something like

$ mvn clean package
$ git checkout asf-site
$ rsync -av target/site/ ./

Robert

Re: Website ToC considers only h2 and h3

[Konrad Windszus]

Currently the MD files either start the explicit headlines with an h1 
(https://github.com/apache/sling-site/blob/master/src/main/jbake/content/documentation/development/jsr-305.md)
 or with an h2 (e.g. 
https://github.com/apache/sling-site/blob/master/src/main/jbake/content/documentation/development.md).
To correctly list both variants in the TOC I would recommend to only list the 
h1's which are not a title. For that we could either render the title with a 
dedicated class and then come up with a selector which includes h1, h2 and h3 
(without that specific class). That way the TOC would look correct for all 
variants I think.
If you don't want to introduce a special class for rendering the title we could 
also come up with a selector to select the a tag below an h1/h2/h3 tag.
Another solution would be to not render the title at all as headline but rather 
only in the title tag of the head section...

Do you want me to propose something or are you planning to migrate the Git repo 
to gitbox soon?
Thanks,
Konrad

> On 29. Sep 2017, at 10:49, Bertrand Delacretaz  wrote:
> 
> Hi,
> 
> Konrad Windszus wrote:
>> What is the reason why the selector at
>> https://github.com/apache/sling-site/blob/f7d38e20d4576a37413fb3d31a28060e8dc0ac60/src/main/jbake/templates/page.tpl#L49
>> only lists h2 and h3?
> 
> Omitting h1 avoids duplicating the page title in the ToC, and stopping
> at h3 prevents the ToC from becoming too detailed.
> 
> I think this works well, taking this page as an example:
> http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html
> 
> But I'm open to different views of course, what would you do differently?
> 
> -Bertrand

[jira] [Commented] (SLING-7158) API changes review for Sling

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185564#comment-16185564
 ] 

Robert Munteanu commented on SLING-7158:


Thanks for this report. Apache Sling is a heavy user of OSGi so we ensure that 
our users either get full backwards compatibility or that they understand the 
need for transition as we use semantic versioning for our bundles.

If you think that this can be improved feel free to discuss on 
dev@sling.apache.org

> API changes review for Sling
> 
>
> Key: SLING-7158
> URL: https://issues.apache.org/jira/browse/SLING-7158
> Project: Sling
>  Issue Type: Test
>Reporter: Andrey Ponomarenko
>Priority: Minor
> Attachments: Sling-Report-1.png, Sling-Report-2.png
>
>
> The review of API changes for the Sling library since 2.0.6 version: 
> https://abi-laboratory.pro/java/tracker/timeline/org.apache.sling.api/
> The report is updated three times a week. Hope it will be helpful for users 
> and maintainers of the library.
> The report is generated by https://github.com/lvc/japi-tracker
> Thank you.
> !Sling-Report-1.png|API changes review!
> !Sling-Report-2.png|API symbols timeline!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7158) API changes review for Sling

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7158.

Resolution: Not A Bug

> API changes review for Sling
> 
>
> Key: SLING-7158
> URL: https://issues.apache.org/jira/browse/SLING-7158
> Project: Sling
>  Issue Type: Test
>Reporter: Andrey Ponomarenko
>Priority: Minor
> Attachments: Sling-Report-1.png, Sling-Report-2.png
>
>
> The review of API changes for the Sling library since 2.0.6 version: 
> https://abi-laboratory.pro/java/tracker/timeline/org.apache.sling.api/
> The report is updated three times a week. Hope it will be helpful for users 
> and maintainers of the library.
> The report is generated by https://github.com/lvc/japi-tracker
> Thank you.
> !Sling-Report-1.png|API changes review!
> !Sling-Report-2.png|API symbols timeline!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] sling-site pull request #1: TODO does commit to github work?

[bdelacretaz]

Github user bdelacretaz closed the pull request at:

https://github.com/apache/sling-site/pull/1


---

[GitHub] sling-site issue #1: TODO does commit to github work?

[bdelacretaz]

Github user bdelacretaz commented on the issue:

https://github.com/apache/sling-site/pull/1
  
Looks like we need to move to gitbox to be able to merge PRs from github, 
will look at that.


---

[GitHub] sling-site pull request #1: TODO does commit to github work?

[bdelacretaz]

GitHub user bdelacretaz opened a pull request:

https://github.com/apache/sling-site/pull/1

TODO does commit to github work?



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bdelacretaz/sling-site patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/sling-site/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1


commit 25e4d7310beed7369c93bc915b20f89ebf469f58
Author: Bertrand Delacretaz 
Date:   2017-09-29T09:00:02Z

TODO does commit to github work?




---

Website ToC considers only h2 and h3

[Bertrand Delacretaz]

Hi,

Konrad Windszus wrote:
> What is the reason why the selector at
> https://github.com/apache/sling-site/blob/f7d38e20d4576a37413fb3d31a28060e8dc0ac60/src/main/jbake/templates/page.tpl#L49
> only lists h2 and h3?

Omitting h1 avoids duplicating the page title in the ToC, and stopping
at h3 prevents the ToC from becoming too detailed.

I think this works well, taking this page as an example:
http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html

But I'm open to different views of course, what would you do differently?

-Bertrand

[GitHub] sling pull request #131: Documented the internals of Sling Event, with help ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/sling/pull/131


---

[jira] [Resolved] (SLING-6955) Convert Sling website to JBake and gitpubsub

[Bertrand Delacretaz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-6955.

Resolution: Fixed

http://sling.apache.org/ is now generated from 
https://git-wip-us.apache.org/repos/asf?p=sling-site.git , marking this 
resolved. We'll create more specific tickets if needed.

> Convert Sling website to JBake and gitpubsub
> 
>
> Key: SLING-6955
> URL: https://issues.apache.org/jira/browse/SLING-6955
> Project: Sling
>  Issue Type: Bug
>  Components: Site
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>
> I've started experimenting with JBake to generate the Sling website. If that 
> works well we might switch to that + gitpubsub to have a more flexible way to 
> generate the site.
> My current experiment is at https://github.com/bdelacretaz/sling-jbake, at 
> this point the site starts looking like the current one and many pages work 
> well.  Update: it's now at https://github.com/apache/sling-site
> Internal links will need to be converted, all *.md files need a more complete 
> "front matter" section, currently I have a stub for that, and I think images 
> need to move under the assets folder.
> To play with that, generate the site with the bake.sh script (setup 
> shamelessly copied from https://github.com/apache/incubator-tamaya-site)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Resolved] (SLING-7132) No longer use the animal-sniffer-plugin with JDK >= 9

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-7132.

   Resolution: Fixed
Fix Version/s: Parent 33

Resolved in [r1810066|https://svn.apache.org/r1810066].

> No longer use the animal-sniffer-plugin with JDK >= 9
> -
>
> Key: SLING-7132
> URL: https://issues.apache.org/jira/browse/SLING-7132
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: Parent 32
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
> Fix For: Parent 33
>
>
> With Java 9 there is a new option being supported, namely {{release}}. This 
> does not only set the {{source}} and {{target}} version but also sets a 
> correct bootclasspath (to determine if the correct/available API is being 
> used). For more details look at http://openjdk.java.net/jeps/247. This 
> obsoletes the {{animal-sniffer-maven-plugin}}, as JDK9 ships with 
> bootclasspaths for Java 6, 7 and 8.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7164) Set up the sling aggregtor repository

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-7164:
--

 Summary: Set up the sling aggregtor repository
 Key: SLING-7164
 URL: https://issues.apache.org/jira/browse/SLING-7164
 Project: Sling
  Issue Type: Sub-task
Reporter: Robert Munteanu


This repository should replace the current 'sling' repo as an entry point. It 
should contain a repo manifest ( or similar ) to allow checking out all the 
sling modules and maybe even regenerate a reactor pom.xml file for quick 
operations.

The README should explain a bit more about Sling and our SCM setup and point to 
the sling home page.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7164) Set up the sling aggregator repository

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7164:
---
Summary: Set up the sling aggregator repository  (was: Set up the sling 
aggregtor repository)

> Set up the sling aggregator repository
> --
>
> Key: SLING-7164
> URL: https://issues.apache.org/jira/browse/SLING-7164
> Project: Sling
>  Issue Type: Sub-task
>  Components: Best practices
>Reporter: Robert Munteanu
>
> This repository should replace the current 'sling' repo as an entry point. It 
> should contain a repo manifest ( or similar ) to allow checking out all the 
> sling modules and maybe even regenerate a reactor pom.xml file for quick 
> operations.
> The README should explain a bit more about Sling and our SCM setup and point 
> to the sling home page.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Git migration - final checks

[Robert Munteanu]

Hi Konrad.

On Fri, 2017-09-29 at 10:06 +0200, Konrad Windszus wrote:
> Just one thing: I am wondering why commits which I have done do not
> have a clickable author information, in contrast to the ones from
> Karl or from Oli (can be observed in https://github.com/not-sling/sli
> ng-org.apache.sling.validation.core/commits/master)
> Where is the author information coming from?
> My author ID is kwin in the Apache SVN and I have an account at
> github with the same id.
> Do you have in idea?

I think you should add your apache.org email address to your Github
profile. There is no mapping at the ASF level that I'm aware of.

Thanks,

Robert

> 
> Otherwise it looks really good and thanks a lot for your effort up
> till now.
> Konrad
> 
> > Am 29.09.2017 um 09:37 schrieb Robert Munteanu 
> > :
> > 
> > Hi,
> > 
> >  tldr: please test the test-migrated git repos, we'll migrate soon
> > 
> > The git migration is almost ready to go. We're waiting for infra to
> > reply on how to activate the transition but otherwise we're
> > basically
> > good to go.
> > 
> > I'd like to point you again to our wiki page where the transition
> > is
> > documented
> > 
> >  https://cwiki.apache.org/confluence/display/SLING/Move+from+Subver
> > sio
> > n+to+Git
> > 
> > I've also performed a dry-run migration of all modules to a Github
> > org,
> > to allow everyone to inspect how such a migration would look like.
> > 
> >  https://github.com/not-sling/
> > 
> > The 'sling' repository also contains a repo manifest file which
> > allows
> > you to checkout all the sling projects in one go. This is not
> > necessarily the final format and we may iterate on that a bit more.
> > Just wanted to show that there is a way of getting the repositories
> > in
> > one go.
> > 
> > So please read the wiki page, take a look at the migrated
> > repositories,
> > especially the ones you usually work with, and make sure that
> > everything is put into place.
> > 
> > Unless we have objections or open issues, I will start the
> > migration on
> > Monday October the 9th ( not sure of the time, but as soon as
> > possible
> > in the GMT+2 time zone ).
> > 
> > Thanks,
> > 
> > Robert
> 
> 

[RT] Updates to the provisioning model

[Carsten Ziegeler]

Hi,

as some of you might already have seen or heard during adaptTo, the
whiteboard contains a new feature based model at [1] which is intended
to be a better provisioning model.

The repository at [1] contains a readme which details the reasons and is
a basic description of the approach. But I would like to give some
reasons why the provisioning model in its current form is not ideal.

The idea of a feature is to be the next higher level building block
above bundles. Its a collection of bundles with configurations (and
potentially other artifacts) that work together as a unit. For example,
the Sling scripting + HTL + Sling models could be a feature providing
all necessary building blocks for scripting. An application is then an
assembly of features.

These are some of the disadvantages of the provisioning model:

* Single file can contain more than one feature
* Custom DSL - no standard format (like JSON)
* Inheritance and custom artifacts (content packages) are mixed with
bundles, which makes processing and understanding more complicated
* Adding additional info to artifacts looks strange
* Two formats for configurations and now there is an official JSON based
format defined through OSGi R7
* Strange object relationship between feature and run modes
* API (object relation) differs from text file (to make the text format
easier)
* Tooling only available as maven plugins, not separate usable. So the
processing of the model is not described as part of the model
* Run mode handling is complicating the feature files and processing of
those
* Tightly coupled with the way Sling's launchpad works, therefore no
independent OSGi format

Especially the format of the description lead to start a new approach.
As mentioned above there is now a standard for OSGi configurations in
JSON and there were a lot of complaints that our current format is not
any standard format like JSON or YAML or even XML. If one part is
already JSON, then it makes sense to go with this for the whole format.

In addition there are more basic design criterias:

* A feature is a separate file with a required id and version
* A feature can include other features
* No support for run modes in the model - run modes can be modeled
through separate features
* Extension based approach for things like repoinit or content packages.
* Support OSGi requirements and capabilities for dependency handling
* Describe the processing of features as part of the model
* The description should be independent of how this is later on used,
e.g. a feature can be processed to create a Karaf Feature, a subsystem
or anything else.

The whiteboard contains a first implementation of the feature model
together with some additions:
An analyser and resolver framework which allows to analyse the model
whether all requirements are met and the application should be able to
run. So things like missing bundles (for package exports) can easily be
detected at run time. The resolver can be used to create a minimal
application. It gets a set of features as input that you want to run and
based on requirements and capabilities the resolver will add missing
pieces in the form of features.

Finally there is a launcher which is able to directly run a set of
features (or an application).

I understand that this is a lot of new stuff and some parts are not
completely implemented yet. But I wanted to have something running to
get a sense of feasability before starting a discussion. And now seems
to be a good time to do so.

The long goal is to have a feature model which potentially can have a
much broader use than just Sling. It's totally independent of Sling and
we could think about moving it to Apache Felix. Or Apache Karaf could
potentially replace their model with ours and we could try to make this
an OSGi standard. While imho these things make sense, they take time. In
addition if we can agree that this approach is the way to move forward
we should try to get rid of all other existing approaches and deprecated
them. So we only have one way of doing things.

For the naming, it currently runs under the name "Sling Feature". People
at adaptTo liked the name, but still if someone has an even better idea,
let's discuss it.

One minor thing, the current proposal uses the Maven coordinates to
describe artifacts. It's using the path part of a maven url, so
basically group id, artifact id, version are separated by a slash. It
seems that the notation of separating these things by a colon is more
common/natural. And we'll probably switch to that.

Feedback more than welcome.

[1] https://svn.apache.org/repos/asf/sling/whiteboard/cziegeler/feature/

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: Git migration - final checks

[Konrad Windszus]

Just one thing: I am wondering why commits which I have done do not have a 
clickable author information, in contrast to the ones from Karl or from Oli 
(can be observed in 
https://github.com/not-sling/sling-org.apache.sling.validation.core/commits/master)
Where is the author information coming from?
My author ID is kwin in the Apache SVN and I have an account at github with the 
same id.
Do you have in idea?

Otherwise it looks really good and thanks a lot for your effort up till now.
Konrad

> Am 29.09.2017 um 09:37 schrieb Robert Munteanu :
> 
> Hi,
> 
>  tldr: please test the test-migrated git repos, we'll migrate soon
> 
> The git migration is almost ready to go. We're waiting for infra to
> reply on how to activate the transition but otherwise we're basically
> good to go.
> 
> I'd like to point you again to our wiki page where the transition is
> documented
> 
>  https://cwiki.apache.org/confluence/display/SLING/Move+from+Subversio
> n+to+Git
> 
> I've also performed a dry-run migration of all modules to a Github org,
> to allow everyone to inspect how such a migration would look like.
> 
>  https://github.com/not-sling/
> 
> The 'sling' repository also contains a repo manifest file which allows
> you to checkout all the sling projects in one go. This is not
> necessarily the final format and we may iterate on that a bit more.
> Just wanted to show that there is a way of getting the repositories in
> one go.
> 
> So please read the wiki page, take a look at the migrated repositories,
> especially the ones you usually work with, and make sure that
> everything is put into place.
> 
> Unless we have objections or open issues, I will start the migration on
> Monday October the 9th ( not sure of the time, but as soon as possible
> in the GMT+2 time zone ).
> 
> Thanks,
> 
> Robert

Git migration - final checks

[Robert Munteanu]

Hi,

  tldr: please test the test-migrated git repos, we'll migrate soon

The git migration is almost ready to go. We're waiting for infra to
reply on how to activate the transition but otherwise we're basically
good to go.

I'd like to point you again to our wiki page where the transition is
documented

  https://cwiki.apache.org/confluence/display/SLING/Move+from+Subversio
n+to+Git

I've also performed a dry-run migration of all modules to a Github org,
to allow everyone to inspect how such a migration would look like.

  https://github.com/not-sling/

The 'sling' repository also contains a repo manifest file which allows
you to checkout all the sling projects in one go. This is not
necessarily the final format and we may iterate on that a bit more.
Just wanted to show that there is a way of getting the repositories in
one go.

So please read the wiki page, take a look at the migrated repositories,
especially the ones you usually work with, and make sure that
everything is put into place.

Unless we have objections or open issues, I will start the migration on
Monday October the 9th ( not sure of the time, but as soon as possible
in the GMT+2 time zone ).

Thanks,

Robert

[jira] [Closed] (SLING-7092) Stop using port 8888 as a default for testing

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7092.
--

> Stop using port  as a default for testing
> -
>
> Key: SLING-7092
> URL: https://issues.apache.org/jira/browse/SLING-7092
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Commons Testing 2.1.2
>
>
> We are using two main ports when dealing with Sling:
> - 8080 for 'regular' instances
> -  for 'testing' instances - mainly used in the integration tests
> I usually notice this when I want to try running an IT from my IDE
> against a running Sling instance and it times out looking for something
> on port  .
> I am not familiar with the reasons for using port , but would it be
> worth dropping this port and using 8080 from now on? It would IMO make
> development with Sling simpler.
> See [dev@sling - Drop port 
> ?|https://lists.apache.org/thread.html/a0427df9e994536323d573cbad558b39048775352db3ed5bd20c4f1b@%3Cdev.sling.apache.org%3E]
>  for a longer discussion



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7060) Allow running a test only if a certain bundle is present at a certain version

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7060.
--

> Allow running a test only if a certain bundle is present at a certain version
> -
>
> Key: SLING-7060
> URL: https://issues.apache.org/jira/browse/SLING-7060
> Project: Sling
>  Issue Type: New Feature
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Commons Testing 2.1.2
>
>
> Now that the launchpad is working with releases only, integration tests for 
> yet-unreleased versions should not run, as they would cause a test failure.
> We should add support to HttpTestBase for skipping tests based on the BSN and 
> version.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7101) Teleporter tests fail on Java 9 - java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7101.
--

> Teleporter tests fail on Java 9 - java.lang.NoClassDefFoundError: 
> javax/xml/bind/DatatypeConverter
> --
>
> Key: SLING-7101
> URL: https://issues.apache.org/jira/browse/SLING-7101
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Reporter: Robert Munteanu
>Assignee: Bertrand Delacretaz
> Fix For: JUnit Tests Teleporter 1.0.16
>
>
> When running the Sling ITs on Java 9 I get a number of failures, including a 
> number of teleporter tests. They all fail in a manner similar to.
> {noformat}Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 
> 0.217 sec <<< FAILURE! - in 
> org.apache.sling.launchpad.webapp.integrationtest.repository.SystemUsersTest
> provisioningModelUser(org.apache.sling.launchpad.webapp.integrationtest.repository.SystemUsersTest)
>   Time elapsed: 0.151 sec  <<< ERROR!
> java.lang.NoClassDefFoundError: javax/xml/bind/DatatypeConverter
>   at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:92)
>   at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:220)
>   at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:104)
>   at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:123)
>   at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:258)
>   at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$100(ClientSideTeleporter.java:56)
>   at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$3.evaluate(ClientSideTeleporter.java:300)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
>   at 
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
>   at 
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
> Caused by: java.lang.ClassNotFoundException: javax.xml.bind.DatatypeConverter
>   at 
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:582)
>   at 
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:185)
>   at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:496)
>   at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.setConnectionCredentials(TeleporterHttpClient.java:92)
>   at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.getHttpGetStatus(TeleporterHttpClient.java:220)
>   at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.waitForStatus(TeleporterHttpClient.java:104)
>   at 
> org.apache.sling.testing.teleporter.client.TeleporterHttpClient.installBundle(TeleporterHttpClient.java:123)
>   at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.installTestBundle(ClientSideTeleporter.java:258)
>   at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter.access$100(ClientSideTeleporter.java:56)
>   at 
> org.apache.sling.testing.teleporter.client.ClientSideTeleporter$3.evaluate(ClientSideTeleporter.java:300)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> 

[jira] [Closed] (SLING-7128) slingstart-maven-plugin should respect JAVA_HOME when set

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7128.
--

> slingstart-maven-plugin should respect JAVA_HOME when set
> -
>
> Key: SLING-7128
> URL: https://issues.apache.org/jira/browse/SLING-7128
> Project: Sling
>  Issue Type: Improvement
>  Components: Maven Plugins and Archetypes
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Slingstart Maven Plugin 1.7.10
>
>
> The typical way of configuring a different Java binary to use is by setting 
> the JAVA_HOME environment variable. This allows for instance using a 
> different JVM version than the default one.
> The slingstart-maven-plugin ( in LauncherCallable ) unconditionally uses 
> 'java' as the command name. We should allow for a custom JAVA_HOME to be set.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7083) The StopMojo should block until the process is finished

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7083.
--

> The StopMojo should block until the process is finished
> ---
>
> Key: SLING-7083
> URL: https://issues.apache.org/jira/browse/SLING-7083
> Project: Sling
>  Issue Type: Bug
>  Components: Tooling
>Affects Versions: Slingstart Maven Plugin 1.1.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
> Fix For: Slingstart Maven Plugin 1.7.10
>
>
> Currently the {{StopMojo}} blocks with a timeout only if the instance 
> provides a control port and the stop command is sent to this socket.
> However, if the mojo has to terminate the instance process by itself then it 
> just sends the terminate command without waiting for the process to actually 
> finish. Without blocking, the {{verify}} Maven lifecycle phase will start, 
> although processing of tasks started in the {{post-integration-test}} phase 
> might not have finished.
> One of the potential side-effects of this bug is the inability to properly 
> collect code coverage results with the {{jacoco-maven-plugin}}, because the 
> plugin will start reading the {{*.exec}} file before its agent (usually 
> attached to a Sling instance started by the {{StartMojo}}) had a chance to 
> flush the coverage contents.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7137) Scripting web console plugins no longer listed

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7137.
--

> Scripting web console plugins no longer listed
> --
>
> Key: SLING-7137
> URL: https://issues.apache.org/jira/browse/SLING-7137
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Scripting Core 2.0.48
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7136) Scripting variables web console plugin lists 'all' option for each scripting engine

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7136.
--

> Scripting variables web console plugin lists 'all' option for each scripting 
> engine
> ---
>
> Key: SLING-7136
> URL: https://issues.apache.org/jira/browse/SLING-7136
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Minor
> Fix For: Scripting Core 2.0.48
>
>
> The 'all' option should only be present once.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7138) Some web console plugins in the 'Sling' category don't appear

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7138.
--

> Some web console plugins in the 'Sling' category don't appear
> -
>
> Key: SLING-7138
> URL: https://issues.apache.org/jira/browse/SLING-7138
> Project: Sling
>  Issue Type: Bug
>  Components: Event
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Event 4.2.8
>
>
> Apparently the inconsistent casing in the category name causes some plugins 
> to not be shown.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-6737) Migrate to OSGi R6 annotations

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-6737.
--

> Migrate to OSGi R6 annotations
> --
>
> Key: SLING-6737
> URL: https://issues.apache.org/jira/browse/SLING-6737
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.46
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Scripting Core 2.0.48
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7139) ScriptEngineManagerFactory does not register ScriptEngineFactory references

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7139.
--

> ScriptEngineManagerFactory does not register ScriptEngineFactory references
> ---
>
> Key: SLING-7139
> URL: https://issues.apache.org/jira/browse/SLING-7139
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Scripting Core 2.0.48
>
>
> It seems that the {{bind}} methods are not called any more, the simple fix 
> that I found was
> {noformat}diff --git 
> a/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ScriptEngineManagerFactory.java
>  
> b/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ScriptEngineManagerFactory.java
> index fe60415c17..79fef581eb 100644
> --- 
> a/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ScriptEngineManagerFactory.java
> +++ 
> b/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ScriptEngineManagerFactory.java
> @@ -60,7 +60,9 @@ import org.slf4j.LoggerFactory;
>  name = "ScriptEngineFactory",
>  service = ScriptEngineFactory.class,
>  policy = ReferencePolicy.DYNAMIC,
> -cardinality = ReferenceCardinality.MULTIPLE
> +cardinality = ReferenceCardinality.MULTIPLE,
> +bind = "bindScriptEngineFactory",
> +unbind = "unbindScriptEngineFactory"
>  )
>  )
>  public class ScriptEngineManagerFactory implements BundleListener {
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-6724) Scripting core build fails with "ServiceLookup gave up" during tests

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-6724.
--

> Scripting core build fails with "ServiceLookup gave up" during tests
> 
>
> Key: SLING-6724
> URL: https://issues.apache.org/jira/browse/SLING-6724
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Karl Pauls
>Assignee: Oliver Lietz
> Fix For: Scripting Core 2.0.48
>
>
> Doing:
> {noformat}
> cd bundles/scripting/core
> mvn clean install
> {noformat}
> fails with test errors.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7091) Label and value are interchanged for queue type

[Robert Munteanu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu closed SLING-7091.
--

> Label and value are interchanged for queue type
> ---
>
> Key: SLING-7091
> URL: https://issues.apache.org/jira/browse/SLING-7091
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: Event 4.2.6
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
> Fix For: Event 4.2.8
>
>
> The label and value of the metatype for the queue type are exchanged. The 
> same is true for the priority of the queue and the main queue



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[RESULT] [VOTE] Release Apache Sling Scripting Core implementation 2.0.48, Apache Event Support 4.2.8, Apache Sling SlingStart Maven Plugin 1.7.10, Apache Sling JUnit Tests Teleporter 1.0.16, Apache S

[Robert Munteanu]

Hi,

The vote has passed with the following result :

+1 (binding): Stefan Seifert, Carsten Ziegeler, Robert Munteanu

I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.

Thanks all for voting.

Robert

Re: [VOTE] Release Apache Sling Thread Support 3.2.10

[Carsten Ziegeler]

+1


Robert Munteanu wrote
> 
> Hi, 
> 
> We solved 6 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12335535
> 
> 1 issue in this version is still open as it affects other modules as
> well, but for Commons Threads the fix has been applied.
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1793
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1793 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ] 0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Re: [VOTE] Release Apache Sling Scripting Core implementation 2.0.48, Apache Event Support 4.2.8, Apache Sling SlingStart Maven Plugin 1.7.10, Apache Sling JUnit Tests Teleporter 1.0.16, Apache Sling

[Carsten Ziegeler]

+1


Robert Munteanu wrote
> Anyone else?
> 
> Robert
> 
> On Mon, 2017-09-25 at 13:50 +0200, Robert Munteanu wrote:
>> Hi,
>>
>> This is a catch-all release vote for some modules I saw had changes
>> but
>> no releases. Due to a network hiccup they are split into 2 release
>> repositories.
>>
>> Note that we dropped Commons Threads 3.2.8 due to incomplete fix for
>> SLING-6261 .
>>
>> There are 15 fixes included in these releases
>>
>> - https://issues.apache.org/jira/projects/SLING/versions/12339953 ( 6
>> issues )
>> - https://issues.apache.org/jira/projects/SLING/versions/12341057 ( 2
>> issues )
>> - https://issues.apache.org/jira/projects/SLING/versions/12341406 ( 2
>> issues )
>> - https://issues.apache.org/jira/projects/SLING/versions/12341562 ( 1
>> issue )
>> - https://issues.apache.org/jira/projects/SLING/versions/12339140 ( 4
>> issues )
>>
>>
>> Staging repositories:
>>   - https://repository.apache.org/content/repositories/orgapachesling
>> -1
>> 789
>>   -   - https://repository.apache.org/content/repositories/orgapaches
>> li
>> ng-1790
>>
>>
>> You can use this UNIX script to download the release and verify the
>> signatures:
>> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
>>
>> Usage:
>> sh check_staged_release.sh 1789 /tmp/sling-staging
>> sh check_staged_release.sh 1790 /tmp/sling-staging
>>
>> Please vote to approve this release:
>>
>>   [ ] +1 Approve the release
>>   [ ]  0 Don't care
>>   [ ] -1 Don't release, because ...
>>
>> This majority vote is open for at least 72 hours.
>>
>> Thanks,
>>
>> Robert
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org