Re: Creating a PR for non-Committer

[Andreas Schaefer]

I created two Sling Maven Archetypes:

1. Project

Creates a Content Package (ui.apps) that contains a Bundle (core) as embedded 
object using wcmio content manager maven plugin
to deploy. The ticket tor that is here:

https://issues.apache.org/jira/browse/SLING-7276 


1. Project-All

Creates a Content Package (all) that wraps an Content Package (ui.apps) and a 
Bundle (core) as sub project and embedded object
and then deployed by the wcmio content manager maven plugin. This is the ticket 
for this:

https://issues.apache.org/jira/browse/SLING-7277

Let me know what you think and what can be done to improve it.

Cheers - Andreas Schaefer

> On Nov 28, 2017, at 8:18 AM, Konrad Windszus  wrote:
> 
> Just create a new repo inside your personal Github space. Then create the 
> JIRA and link the repo there.
> Then it should be easy to clone and also push it to a decicated Sling Repo 
> (once that is created).
> 
> Konrad
>> On 28. Nov 2017, at 17:16, Bertrand Delacretaz  
>> wrote:
>> 
>> Hi,
>> 
>> On Tue, Nov 28, 2017 at 5:10 PM, Andreas Schaefer  wrote:
>>> ...What is the best way to create a PR for Sling for a non-committer
>>> when I want to add a new module?...
>> 
>> I don't think you can do that if those new modules are going into new
>> Git repositories (which is our usual plan now).
>> 
>> Best is probably to attach the code as an archive to a jira ticket.
>> 
>> -Bertrand
> 

[jira] [Created] (SLING-7277) Sling Maven Archetype for a Wrapper Content Package with a Content and Bundle

[Andreas Schaefer (JIRA)]

Andreas Schaefer created SLING-7277:
---

 Summary: Sling Maven Archetype for a Wrapper Content Package with 
a Content and Bundle
 Key: SLING-7277
 URL: https://issues.apache.org/jira/browse/SLING-7277
 Project: Sling
  Issue Type: New Feature
  Components: Tooling
 Environment: Sling 9
Reporter: Andreas Schaefer


This Maven Archetype creates a wrapper Content Package (all) that contains an 
OSGi Bundle (core) and a Content Package (ui.apps).

This does the same thing if there is only one content package but for bigger 
projects containing multiple content packages and bundles this can make sure 
that everything is deployed as an atomic file preventing issues with 
dependencies and out of sync content.

The Git Repository for this is here:

https://github.com/headwirecom/sling-project-all-archetype



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7276) Sling Maven Archetype for a Bundle / Content Package project

[Andreas Schaefer (JIRA)]

Andreas Schaefer created SLING-7276:
---

 Summary: Sling Maven Archetype for a Bundle / Content Package 
project
 Key: SLING-7276
 URL: https://issues.apache.org/jira/browse/SLING-7276
 Project: Sling
  Issue Type: New Feature
  Components: Tooling
 Environment: Sling 9
Reporter: Andreas Schaefer


I created a Maven Archetype for Ruben that creates a Sling project composed of 
a Bundle (core) and a Content Package (ui.apps) which contains the Bundle as 
embedded object.

It is deployed using the latest WCMIO Content Package Maven Plugin to deploy to 
Sling using Composum.

The generated contains a shadow module for the core and ui.apps with the 
extension '.example' that is not part of the build but can be copied into the 
active module when desired or deleted by just deleting these folders.

The Git Repository of that can be found here:

https://github.com/headwirecom/sling-project-archetype



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Sling Engine 2.6.10, i18n 2.5.10,feature flags 1.2.2, and security 1.1.10

[Carsten Ziegeler]

+1


Carsten Ziegeler wrote
> Hi,
> 
> We solved 1 issue for Engine 2.6.10
> https://issues.apache.org/jira/projects/SLING/versions/12340607
> 
> We solved 4 issues for i18n 2.5.10
> https://issues.apache.org/jira/projects/SLING/versions/12339949
> 
> We solved 1 issue for Feature Flags 1.2.2
> https://issues.apache.org/jira/projects/SLING/versions/12338140
> 
> We solved 1 issue for Security 1.1.0
> https://issues.apache.org/jira/projects/SLING/versions/12342206
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1821
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh
> 
> Usage:
> sh check_staged_release.sh 1821 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards
> Carsten
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[VOTE] Release Apache Sling Engine 2.6.10, i18n 2.5.10,feature flags 1.2.2, and security 1.1.10

[Carsten Ziegeler]

Hi,

We solved 1 issue for Engine 2.6.10
https://issues.apache.org/jira/projects/SLING/versions/12340607

We solved 4 issues for i18n 2.5.10
https://issues.apache.org/jira/projects/SLING/versions/12339949

We solved 1 issue for Feature Flags 1.2.2
https://issues.apache.org/jira/projects/SLING/versions/12338140

We solved 1 issue for Security 1.1.0
https://issues.apache.org/jira/projects/SLING/versions/12342206

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-1821

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 1821 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards
Carsten
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Updated] (SLING-7190) i18n translations not updated unless bundle is restarted

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-7190:

Fix Version/s: (was: i18n 2.5.10)
   i18n 2.5.12

> i18n translations not updated unless bundle is restarted
> 
>
> Key: SLING-7190
> URL: https://issues.apache.org/jira/browse/SLING-7190
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: i18n 2.5.6
>Reporter: Shivendra Vikram Srinet
> Fix For: i18n 2.5.12
>
>
> Required System Setup - AEM 6.2SP1-CFP6 
> Navigate to - http://localhost:4502/libs/cq/i18n/translator.html
> Select dictionary /libs/granite/i18n 
> Dictionary would get loaded in the UI
> Update fr Translation for 'Create' to any random string
> Click on save
> Change System Language to fr
> Navigate to - http://localhost:4502/sites.html/content
> Check Create button label on the top right. It's not updated
> Restarting the bundle (sling i18n) and refreshing the page loads the new 
> translation. 
> Prior to CFP6 (sling i18n 2.4.4) no restart was required. The bundle 
> automatically got refreshed after any change in the resource. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-6890) Remove usage of o.a.jackrabbit.commons.json from i18n

[Carsten Ziegeler (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler updated SLING-6890:

Fix Version/s: (was: i18n 2.5.10)

> Remove usage of o.a.jackrabbit.commons.json from i18n
> -
>
> Key: SLING-6890
> URL: https://issues.apache.org/jira/browse/SLING-6890
> Project: Sling
>  Issue Type: Sub-task
>  Components: i18n
>Affects Versions: i18n 2.5.8
>Reporter: Karl Pauls
>
> It looks like i18n is using some org.json this time from 
> o.a.jackrabbit.commons.json. We'll have to replace that too I would guess.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] cziegeler closed pull request #1: Fix converting latest Sling Starter app

[GitBox]

cziegeler closed pull request #1: Fix converting latest Sling Starter app
URL: https://github.com/apache/sling-whiteboard/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Creating a PR for non-Committer

[Bertrand Delacretaz]

On Tue, Nov 28, 2017 at 5:18 PM, Konrad Windszus  wrote:
>... Just create a new repo inside your personal Github space. Then create the 
>JIRA and link the repo there.
> Then it should be easy to clone and also push it to a decicated Sling Repo 
> (once that is created)...

+1, forget what I said ;-)

-Bertrand

Re: Creating a PR for non-Committer

[Konrad Windszus]

Just create a new repo inside your personal Github space. Then create the JIRA 
and link the repo there.
Then it should be easy to clone and also push it to a decicated Sling Repo 
(once that is created).

Konrad
> On 28. Nov 2017, at 17:16, Bertrand Delacretaz  wrote:
> 
> Hi,
> 
> On Tue, Nov 28, 2017 at 5:10 PM, Andreas Schaefer  wrote:
>> ...What is the best way to create a PR for Sling for a non-committer
>> when I want to add a new module?...
> 
> I don't think you can do that if those new modules are going into new
> Git repositories (which is our usual plan now).
> 
> Best is probably to attach the code as an archive to a jira ticket.
> 
> -Bertrand

Re: Creating a PR for non-Committer

[Bertrand Delacretaz]

On Tue, Nov 28, 2017 at 5:16 PM, Bertrand Delacretaz
 wrote:
> ...Best is probably to attach the code as an archive to a jira ticket...

Or add them to https://github.com/apache/sling-whiteboard so we can
have a closer look before deciding where they go?

-Bertrand

Re: Creating a PR for non-Committer

[Bertrand Delacretaz]

Hi,

On Tue, Nov 28, 2017 at 5:10 PM, Andreas Schaefer  wrote:
> ...What is the best way to create a PR for Sling for a non-committer
> when I want to add a new module?...

I don't think you can do that if those new modules are going into new
Git repositories (which is our usual plan now).

Best is probably to attach the code as an archive to a jira ticket.

-Bertrand

Creating a PR for non-Committer

[Andreas Schaefer]

Hi

What is the best way to create a PR for Sling for a non-committer
when I want to add a new module?

I created PRs for two maven archetypes but they were not reviewed
and so I want to reissue them.

Cheers - Andreas Schaefer

Re: Sling Tooling IDE and IntelliJ

[Andreas Schaefer]

Hi

My project is based on what the Bundle Initial Content Sling Maven Archetype
creates but added a Sling Model to it.

So, it does not have a META-INF/MANIFEST.MF and running it from the command
line there are not errors or warnings reported.

This is the build section in the POM:




org.apache.felix
maven-bundle-plugin
true
3.2.0

${basedir}/target/classes
NONE

true

sling

http://sling.apache.org


${project.artifactId}



SLING-INF/nodetypes/nodetypes.cnd



SLING-INF/scripts;overwrite:=true;uninstall:=true;path:=/apps/my/node,

SLING-INF/content;overwrite:=true;uninstall:=true;path:=/content,

SLING-INF/apps/testBundleApps;overwrite:=true;uninstall:=true;path:=/apps/testBundleApps


org.apache.sling.ui.testModelUI



 
org.apache.sling
maven-sling-plugin
2.1.0

http://localhost:8080/system/console
admin
admin





Cheers - Andy Schaefer

> On Nov 28, 2017, at 3:19 AM, Robert Munteanu  wrote:
> 
> On Fri, 2017-11-24 at 09:42 -0800, Andreas Schaefer wrote:
>> On another note I created a OSGi Bundle with Sling-Initial-Content
>> and it deploys
>> and works just fine. That said using the latest Eclipse with the
>> Sling Plugin trying
>> to deploy it fails as it tells me that I am missing a META-
>> INF/MANIFEST.MF.
>> 
>> !ENTRY org.apache.sling.ide.eclipse-core 2 0 2017-11-24 09:34:33.327
>> !MESSAGE Project P/sling-initial-content-bundle does not have a META-
>> INF/MANIFEST.MF (yet) - not publishing this time
> 
> Do you have a META-INF/MANIFEST.MF file under /target/classes? If not,
> do you have any error/warning markers in your pom.xml file?
> 
>> 
>> Any way to make this deploy?
>> 
>> Am I correct assuming that the Sling Plugin on Eclipse should deploy
>> a module
>> automatically or does it require a “Publish” on the Server?
> 
> Yes, it should deploy it automatically.
> 
> Robert

Re: Usage of feature-modelconverter

[Robert Munteanu]

:-)

Thanks for the review. Would be nice to also look into https://github.c
om/apache/sling-whiteboard/pull/1/ when you have the time ( you merged 
https://github.com/apache/sling-whiteboard/pull/2/ )

Robert

On Tue, 2017-11-28 at 13:42 +0100, Carsten Ziegeler wrote:
> thanks, yes we had different descriptions on how the mvn id works
> (whether version is the last or the third element). So I implemented
> both :) (just kidding)
> 
> According to https://maven.apache.org/pom.html#Maven_Coordinates it's
> now correct, version is always the last part
> 
> Regards
> 
> Carsten
> 
> 
> Robert Munteanu wrote
> > Ack. I think I fixed it, but a review would be good
> > 
> >   https://github.com/apache/sling-whiteboard/pull/1
> > 
> > Thanks,
> > 
> > Robert
> > 
> > On Tue, 2017-11-28 at 11:10 +0100, Carsten Ziegeler wrote:
> > > Hi,
> > > 
> > > at first look this seems to be a bug when reading the slingstart
> > > model
> > > as clearly generated/:boot/1.0.0 is nowhere to be found in that
> > > model.
> > > 
> > > So far I've only tested converting models which did not have an
> > > include
> > > and that worked months ago when I checked last time :) So I guess
> > > we
> > > have to debug and see what is going wrong.
> > > 
> > > For the options with -f you can either point to a file or a
> > > directory
> > > of
> > > files. If you don't specify the -a option you should get a set of
> > > feature files. If you specify -a you get an application json with
> > > a
> > > combination of all features.
> > > 
> > > Regards
> > > 
> > > Carsten
> > > 
> > > 
> > > Robert Munteanu wrote
> > > > Hi,
> > > > 
> > > > I am trying to use the upcoming feature converter to generate a
> > > > feature
> > > > descriptor from a slingstart package.
> > > > 
> > > > I am unsure however what the various arguments to. I tried
> > > > doing
> > > > something like
> > > > 
> > > >   $ java -jar target/org.apache.sling.feature.modelconverter-
> > > > 0.0.1-
> > > > SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
> > > > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.s
> > > > tart
> > > > er/1
> > > > 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> > > > slingfeature.txt
> > > > 
> > > > But the program complains about invalid mvn coordinates:
> > > > 
> > > > [INFO] Apache Sling Provisiong Model to Feature Application
> > > > Converter
> > > > [INFO] 
> > > > [INFO] Assembling model...
> > > > [INFO] - reading model
> > > > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.s
> > > > tart
> > > > er/1
> > > > 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> > > > slingfeature.txt
> > > > [INFO] - reading model
> > > > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.s
> > > > ampl
> > > > e.sl
> > > > ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-
> > > > slingfeature.txt
> > > > Exception in thread "main" java.lang.IllegalArgumentException:
> > > > Invalid
> > > > mvn coordinates: generated/:boot/1.0.0
> > > > at
> > > > org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:1
> > > > 64)
> > > > at
> > > > org.apache.sling.feature.modelconverter.impl.Main.buildFeatures
> > > > (Mai
> > > > n.ja
> > > > va:283)
> > > > at
> > > > org.apache.sling.feature.modelconverter.impl.Main.main(Main.jav
> > > > a:23
> > > > 4)
> > > > 
> > > > How can I use the model converter to generate an application
> > > > descriptor
> > > > from an existing slingstart?
> > > > 
> > > > Thanks,
> > > > 
> > > > Robert
> > > > 

[jira] [Updated] (SLING-7275) update sling pipes documentation

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7275:
---
Fix Version/s: pipes 2.0.0

> update sling pipes documentation
> 
>
> Key: SLING-7275
> URL: https://issues.apache.org/jira/browse/SLING-7275
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> Documentation should be much clearer (in several pages, with nested details 
> only if needed), and adapted to pipes 2.0.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7275) update sling pipes documentation

[Nicolas Peltier (JIRA)]

Nicolas Peltier created SLING-7275:
--

 Summary: update sling pipes documentation
 Key: SLING-7275
 URL: https://issues.apache.org/jira/browse/SLING-7275
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 2.0.0
Reporter: Nicolas Peltier


Documentation should be much clearer (in several pages, with nested details 
only if needed), and adapted to pipes 2.0.0



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7251) Fix pipes plumber servlet IT

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7251:
---
Fix Version/s: pipes 2.0.0

> Fix pipes plumber servlet IT 
> -
>
> Key: SLING-7251
> URL: https://issues.apache.org/jira/browse/SLING-7251
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> new Plumber servlet IT fail. This should be fixed



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7250) allow non persisted configurations for pipe

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7250:
---
Fix Version/s: pipes 2.0.0

> allow non persisted configurations for pipe
> ---
>
> Key: SLING-7250
> URL: https://issues.apache.org/jira/browse/SLING-7250
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> for some usage of the pipe builder, it might be useful not to persist pipes 
> before executing them



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SLING-7173) Add JMX data for pipes

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7173:
---
Fix Version/s: pipes 2.0.0

> Add JMX data for pipes
> --
>
> Key: SLING-7173
> URL: https://issues.apache.org/jira/browse/SLING-7173
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
> Fix For: pipes 2.0.0
>
>
> some JMX data would be interesting to expose :
> - pipe occurence calls #,
> - mean time per pipe, 
> - ...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] cziegeler closed pull request #2: Fix ArtifactId.toMvnId to be symmetrical with fromMvnId

[GitBox]

cziegeler closed pull request #2: Fix ArtifactId.toMvnId to be symmetrical with 
fromMvnId
URL: https://github.com/apache/sling-whiteboard/pull/2
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Usage of feature-modelconverter

[Carsten Ziegeler]

thanks, yes we had different descriptions on how the mvn id works
(whether version is the last or the third element). So I implemented
both :) (just kidding)

According to https://maven.apache.org/pom.html#Maven_Coordinates it's
now correct, version is always the last part

Regards

Carsten


Robert Munteanu wrote
> Ack. I think I fixed it, but a review would be good
> 
>   https://github.com/apache/sling-whiteboard/pull/1
> 
> Thanks,
> 
> Robert
> 
> On Tue, 2017-11-28 at 11:10 +0100, Carsten Ziegeler wrote:
>> Hi,
>>
>> at first look this seems to be a bug when reading the slingstart
>> model
>> as clearly generated/:boot/1.0.0 is nowhere to be found in that
>> model.
>>
>> So far I've only tested converting models which did not have an
>> include
>> and that worked months ago when I checked last time :) So I guess we
>> have to debug and see what is going wrong.
>>
>> For the options with -f you can either point to a file or a directory
>> of
>> files. If you don't specify the -a option you should get a set of
>> feature files. If you specify -a you get an application json with a
>> combination of all features.
>>
>> Regards
>>
>> Carsten
>>
>>
>> Robert Munteanu wrote
>>> Hi,
>>>
>>> I am trying to use the upcoming feature converter to generate a
>>> feature
>>> descriptor from a slingstart package.
>>>
>>> I am unsure however what the various arguments to. I tried doing
>>> something like
>>>
>>>   $ java -jar target/org.apache.sling.feature.modelconverter-0.0.1-
>>> SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
>>> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.start
>>> er/1
>>> 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
>>> slingfeature.txt
>>>
>>> But the program complains about invalid mvn coordinates:
>>>
>>> [INFO] Apache Sling Provisiong Model to Feature Application
>>> Converter
>>> [INFO] 
>>> [INFO] Assembling model...
>>> [INFO] - reading model
>>> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.start
>>> er/1
>>> 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
>>> slingfeature.txt
>>> [INFO] - reading model
>>> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.sampl
>>> e.sl
>>> ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-
>>> slingfeature.txt
>>> Exception in thread "main" java.lang.IllegalArgumentException:
>>> Invalid
>>> mvn coordinates: generated/:boot/1.0.0
>>> at
>>> org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:164)
>>> at
>>> org.apache.sling.feature.modelconverter.impl.Main.buildFeatures(Mai
>>> n.ja
>>> va:283)
>>> at
>>> org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:23
>>> 4)
>>>
>>> How can I use the model converter to generate an application
>>> descriptor
>>> from an existing slingstart?
>>>
>>> Thanks,
>>>
>>> Robert
>>>
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[GitHub] rombert opened a new pull request #2: Fix ArtifactId.toMvnId to be symmetrical with fromMvnId

[GitBox]

rombert opened a new pull request #2: Fix ArtifactId.toMvnId to be symmetrical 
with fromMvnId
URL: https://github.com/apache/sling-whiteboard/pull/2
 
 
   The fromMvnId method expects the values in the 
`groupId:artifactId[:packaging[:classifier]]:version` format, but toMvnId was 
outputting them in the `groupId:artifactId:version[:packaging[:classifier]]` 
format.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Usage of feature-modelconverter

[Robert Munteanu]

Ack. I think I fixed it, but a review would be good

  https://github.com/apache/sling-whiteboard/pull/1

Thanks,

Robert

On Tue, 2017-11-28 at 11:10 +0100, Carsten Ziegeler wrote:
> Hi,
> 
> at first look this seems to be a bug when reading the slingstart
> model
> as clearly generated/:boot/1.0.0 is nowhere to be found in that
> model.
> 
> So far I've only tested converting models which did not have an
> include
> and that worked months ago when I checked last time :) So I guess we
> have to debug and see what is going wrong.
> 
> For the options with -f you can either point to a file or a directory
> of
> files. If you don't specify the -a option you should get a set of
> feature files. If you specify -a you get an application json with a
> combination of all features.
> 
> Regards
> 
> Carsten
> 
> 
> Robert Munteanu wrote
> > Hi,
> > 
> > I am trying to use the upcoming feature converter to generate a
> > feature
> > descriptor from a slingstart package.
> > 
> > I am unsure however what the various arguments to. I tried doing
> > something like
> > 
> >   $ java -jar target/org.apache.sling.feature.modelconverter-0.0.1-
> > SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
> > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.start
> > er/1
> > 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> > slingfeature.txt
> > 
> > But the program complains about invalid mvn coordinates:
> > 
> > [INFO] Apache Sling Provisiong Model to Feature Application
> > Converter
> > [INFO] 
> > [INFO] Assembling model...
> > [INFO] - reading model
> > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.start
> > er/1
> > 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> > slingfeature.txt
> > [INFO] - reading model
> > /home/robert/.m2/repository/org/apache/sling/org.apache.sling.sampl
> > e.sl
> > ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-
> > slingfeature.txt
> > Exception in thread "main" java.lang.IllegalArgumentException:
> > Invalid
> > mvn coordinates: generated/:boot/1.0.0
> > at
> > org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:164)
> > at
> > org.apache.sling.feature.modelconverter.impl.Main.buildFeatures(Mai
> > n.ja
> > va:283)
> > at
> > org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:23
> > 4)
> > 
> > How can I use the model converter to generate an application
> > descriptor
> > from an existing slingstart?
> > 
> > Thanks,
> > 
> > Robert
> > 

[GitHub] rombert opened a new pull request #1: Fix converting latest Sling Starter app

[GitBox]

rombert opened a new pull request #1: Fix converting latest Sling Starter app
URL: https://github.com/apache/sling-whiteboard/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Sling Tooling IDE and IntelliJ

[Robert Munteanu]

On Fri, 2017-11-24 at 09:42 -0800, Andreas Schaefer wrote:
> On another note I created a OSGi Bundle with Sling-Initial-Content
> and it deploys
> and works just fine. That said using the latest Eclipse with the
> Sling Plugin trying
> to deploy it fails as it tells me that I am missing a META-
> INF/MANIFEST.MF.
> 
> !ENTRY org.apache.sling.ide.eclipse-core 2 0 2017-11-24 09:34:33.327
> !MESSAGE Project P/sling-initial-content-bundle does not have a META-
> INF/MANIFEST.MF (yet) - not publishing this time

Do you have a META-INF/MANIFEST.MF file under /target/classes? If not,
do you have any error/warning markers in your pom.xml file?

> 
> Any way to make this deploy?
> 
> Am I correct assuming that the Sling Plugin on Eclipse should deploy
> a module
> automatically or does it require a “Publish” on the Server?

Yes, it should deploy it automatically.

Robert

Re: Sling Tooling IDE and IntelliJ

[Robert Munteanu]

On Thu, 2017-11-23 at 14:56 -0800, Andreas Schaefer wrote:
> Hi Robert
> 
> See my notes inlined:
> 
> > On Nov 22, 2017, at 1:25 AM, Robert Munteanu 
> > wrote:
> > 
> > Hi Andreas,
> > 
> > On Tue, 2017-11-21 at 15:42 -0800, Andreas Schaefer wrote:
> > > Hi
> > > 
> > > Last and this year I am working on a IntelliJ Plugin to help
> > > develop
> > > Sling / AEM
> > > projects. Since the start I ran into issue with the Sling Tooling
> > > IDE
> > > code base
> > > as the code is geared towards Eclipse and its use of OSGi.
> > > Despite
> > > several
> > > tries to come up with a resolution to create a code base that
> > > would
> > > work equally
> > > all for IntelliJ and Eclipse there was not progress made towards
> > > a
> > > solution.
> > 
> > Yes, I am aware of that :-( I still don't have a good answer on how
> > to
> > build AEM and IntelliJ plugins together. If you have examples or
> > ideas
> > how to do that I'd be happy to work towards that goal.
> > 
> > The idea would be simple: allow plain Maven artifacts to be
> > consumed by
> > both an IntelliJ Maven build and an Eclipse Maven build. This is
> > currently complicated due to the Tycho/p2 implementation which
> > requires
> > p2 update sites over http.
> 
> There are a few things that I needs to be done:
> 
> 1. Make common code like impl-vlt eclipse agnostic. If you want or
> need
> an Activator / Logger then we can create an interface and then you
> wrap
> this in an eclipse module.
> 
> 2. Shared code that interacts with the IDE needs to be written in a
> way
> that each plugin can extend or delegate it and the common code is
> left
> in a non-eclipse module. IntelliJ right now uses a class that
> contains common
> IDE code and its access to the remote server. Then IntelliJ plugin is
> extending that class providing the integration with IntelliJ.
> 
> I would be willing to create the same wrapper for Eclipse if someone
> can
> show where to find the necessary Eclipse code like IServer, IFile etc
> and 
> the implementation of it. I tried to find it but could not find in a
> reasonable
> amount of time.

I agree with all of those. But first we need a build solution. If we
make the code independent from Eclipse and OSGi ( BTW, PojoSR/Felix
Connect would be an option I guess for IntelliJ ) then we still have
the problem of building the code in the same reactor and reusing code
between IntelliJ and Eclipse. We have a way forward for making impl-vlt 
IntelliJ-compatible, but not for a build solution. So that's point #0
IMO.
> > > 2. IntelliJ (and I assume Eclipse) Plugin cannot import resources
> > > from Sling / AEM
> > > from a Sling Content Bundle
> > 
> > With the same understanding of content bundles, we only support
> > content
> > packages. That was the pattern we saw most used developing AEM and
> > Sling apps, and that is the one we support right now.
> 
> If my content is stored in a SLING-INF folder can I import a resource
> from Sling using the plugin?

No, not at the moment. Much of the code is written behind APIs and it
would not be a moderate-size effort to add support for another
implementation that works with the content loader format and allow
multiple implementations to coexist at runtime.

> 
> > 
> > > 
> > > 3. IntelliJ and Sling (AFAIK) do not support OSGi bundle
> > > deployment
> > > as part of a
> > > JCR Package which can lead to problems with OSGi bundles in Sling
> > > (not sure about
> > > AEM). This is an general issue with embedded bundles when they
> > > are
> > > deployed
> > > both as embedded and standalone archive.
> > 
> > I'm curious, why would you want to deploy an OSGi bundle when
> > working
> > on a content package? I would rather configure them as bundle
> > modules
> > and allow deployment to work independently of content packages.
> > 
> > Is it only because the bundle is deployed by both the JCR installer
> > and
> > then also via the Web Console? If so, I'd like to hear some
> > examples of
> > what goes wrong, to see if we can fix them or work around them.
> 
> Having my bundles embedded inside a Content Package is to make sure
> that both are in sync. For example if I updated my page (resource) as
> well
> as the Sling Model it uses then I can deploy it together. 
> 
> I installed Eclipse Oxygen, the latest from Sling (Git) and started
> it. Then
> I took a sling project that has a core (OSGi bundle) and an ui.apps
> that
> has the core embedded but also contains resources. When I deploy this
> manually (via Maven) then any updates to the core bundle will not be
> taken effect in Sling until I deploy it again from Maven.
> 
> This is AFAIK due to the fact that the bundle from the package
> overrides
> any deployments directly to the OSGi container and this is also a
> problem
> if someone deploys the bundle manually or through bundle deployment
> tool after a JCR package with that bundle is deployed.

Deployments through the OSGi console should work, even if the bundle
was 

Re: Usage of feature-modelconverter

[Carsten Ziegeler]

Hi,

at first look this seems to be a bug when reading the slingstart model
as clearly generated/:boot/1.0.0 is nowhere to be found in that model.

So far I've only tested converting models which did not have an include
and that worked months ago when I checked last time :) So I guess we
have to debug and see what is going wrong.

For the options with -f you can either point to a file or a directory of
files. If you don't specify the -a option you should get a set of
feature files. If you specify -a you get an application json with a
combination of all features.

Regards

Carsten


Robert Munteanu wrote
> Hi,
> 
> I am trying to use the upcoming feature converter to generate a feature
> descriptor from a slingstart package.
> 
> I am unsure however what the various arguments to. I tried doing
> something like
> 
>   $ java -jar target/org.apache.sling.feature.modelconverter-0.0.1-
> SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.starter/1
> 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> slingfeature.txt
> 
> But the program complains about invalid mvn coordinates:
> 
> [INFO] Apache Sling Provisiong Model to Feature Application Converter
> [INFO] 
> [INFO] Assembling model...
> [INFO] - reading model
> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.starter/1
> 0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
> slingfeature.txt
> [INFO] - reading model
> /home/robert/.m2/repository/org/apache/sling/org.apache.sling.sample.sl
> ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-slingfeature.txt
> Exception in thread "main" java.lang.IllegalArgumentException: Invalid
> mvn coordinates: generated/:boot/1.0.0
>   at
> org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:164)
>   at
> org.apache.sling.feature.modelconverter.impl.Main.buildFeatures(Main.ja
> va:283)
>   at
> org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:234)
> 
> How can I use the model converter to generate an application descriptor
> from an existing slingstart?
> 
> Thanks,
> 
> Robert
> 
-- 
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

Usage of feature-modelconverter

[Robert Munteanu]

Hi,

I am trying to use the upcoming feature converter to generate a feature
descriptor from a slingstart package.

I am unsure however what the various arguments to. I tried doing
something like

  $ java -jar target/org.apache.sling.feature.modelconverter-0.0.1-
SNAPSHOT.jar -u file:///home/robert/.m2/repository -f
/home/robert/.m2/repository/org/apache/sling/org.apache.sling.starter/1
0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
slingfeature.txt

But the program complains about invalid mvn coordinates:

[INFO] Apache Sling Provisiong Model to Feature Application Converter
[INFO] 
[INFO] Assembling model...
[INFO] - reading model
/home/robert/.m2/repository/org/apache/sling/org.apache.sling.starter/1
0-SNAPSHOT/org.apache.sling.starter-10-20171109.131304-92-
slingfeature.txt
[INFO] - reading model
/home/robert/.m2/repository/org/apache/sling/org.apache.sling.sample.sl
ingshot/0.8.0/org.apache.sling.sample.slingshot-0.8.0-slingfeature.txt
Exception in thread "main" java.lang.IllegalArgumentException: Invalid
mvn coordinates: generated/:boot/1.0.0
at
org.apache.sling.feature.ArtifactId.fromMvnId(ArtifactId.java:164)
at
org.apache.sling.feature.modelconverter.impl.Main.buildFeatures(Main.ja
va:283)
at
org.apache.sling.feature.modelconverter.impl.Main.main(Main.java:234)

How can I use the model converter to generate an application descriptor
from an existing slingstart?

Thanks,

Robert

Re: [VOTE] Release Apache Sling Commons Log 5.1.0

[Karl Pauls]

+1

regards,

Karl

On Monday, November 27, 2017, Stefan Seifert  wrote:

> +1
>
>

-- 
Karl Pauls
karlpa...@gmail.com

[jira] [Updated] (SLING-7134) Script execution order is not deterministic on Java 9

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-7134:

Summary: Script execution order is not deterministic on Java 9  (was: 
Script execution order is not deterministic)

> Script execution order is not deterministic on Java 9
> -
>
> Key: SLING-7134
> URL: https://issues.apache.org/jira/browse/SLING-7134
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting, Servlets
>Reporter: Robert Munteanu
>Assignee: Radu Cotescu
> Fix For: Servlets Resolver 2.4.16, Scripting Core 2.0.52
>
> Attachments: scripting-engines-java-9.png
>
>
> When starting up the Sling launchpad with Java 9 and accessing 
> http://localhost:8080/bin/browser.html I get an empty page and the following 
> stack trace in the error log
> {noformat}18.09.2017 23:50:44.656 *ERROR* [127.0.0.1 [1505767840754] GET 
> /bin/browser.html HTTP/1.1] org.apache.sling.engine.impl.SlingRequestProcesso
> rImpl service: Uncaught SlingException
> jdk.nashorn.internal.runtime.ECMAException: ReferenceError: "window" is not 
> defined
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:319)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:291)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.objects.Global.__noSuchProperty__(Global.java:1615)
> at 
> jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$1$\^eval\_.:program(:5)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:652)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:513)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:517)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:420)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.access$300(NashornScriptEngine.java:72)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine$3.eval(NashornScriptEngine.java:513)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
> at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:77)
> at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.dispatchRequest(SlingRequestProcessorImpl.java:322)
> at 
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.dispatch(SlingRequestDispatcher.java:211)
> at 
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.include(SlingRequestDispatcher.java:104)
> at 
> org.apache.sling.scripting.jsp.taglib.IncludeTagHandler.dispatch(IncludeTagHandler.java:54)
> at 
> org.apache.sling.scripting.jsp.taglib.AbstractDispatcherTagHandler.doEndTag(AbstractDispatcherTagHandler.java:129)
> at 
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspx_meth_sling_005finclude_005f0(edi
> tdialog_jsp.java:128)
> at 
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspService(editdialog_jsp.java:99)
> at 
> org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:342)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:97)
> at 
> 

[jira] [Updated] (SLING-7134) Script execution order is not deterministic

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-7134:

Fix Version/s: Servlets Resolver 2.4.16
   Scripting Core 2.0.52

> Script execution order is not deterministic
> ---
>
> Key: SLING-7134
> URL: https://issues.apache.org/jira/browse/SLING-7134
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting, Servlets
>Reporter: Robert Munteanu
>Assignee: Radu Cotescu
> Fix For: Servlets Resolver 2.4.16, Scripting Core 2.0.52
>
> Attachments: scripting-engines-java-9.png
>
>
> When starting up the Sling launchpad with Java 9 and accessing 
> http://localhost:8080/bin/browser.html I get an empty page and the following 
> stack trace in the error log
> {noformat}18.09.2017 23:50:44.656 *ERROR* [127.0.0.1 [1505767840754] GET 
> /bin/browser.html HTTP/1.1] org.apache.sling.engine.impl.SlingRequestProcesso
> rImpl service: Uncaught SlingException
> jdk.nashorn.internal.runtime.ECMAException: ReferenceError: "window" is not 
> defined
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:319)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:291)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.objects.Global.__noSuchProperty__(Global.java:1615)
> at 
> jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$1$\^eval\_.:program(:5)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:652)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:513)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:517)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:420)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.access$300(NashornScriptEngine.java:72)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine$3.eval(NashornScriptEngine.java:513)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
> at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:77)
> at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.dispatchRequest(SlingRequestProcessorImpl.java:322)
> at 
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.dispatch(SlingRequestDispatcher.java:211)
> at 
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.include(SlingRequestDispatcher.java:104)
> at 
> org.apache.sling.scripting.jsp.taglib.IncludeTagHandler.dispatch(IncludeTagHandler.java:54)
> at 
> org.apache.sling.scripting.jsp.taglib.AbstractDispatcherTagHandler.doEndTag(AbstractDispatcherTagHandler.java:129)
> at 
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspx_meth_sling_005finclude_005f0(edi
> tdialog_jsp.java:128)
> at 
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspService(editdialog_jsp.java:99)
> at 
> org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:342)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:97)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory$JspScriptEngine.eval(JspScriptEngineFactory.java:603)
> at 
> 

[jira] [Updated] (SLING-7134) Script execution order is not deterministic

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-7134:

Summary: Script execution order is not deterministic  (was: Composum does 
not work with Java 9 )

> Script execution order is not deterministic
> ---
>
> Key: SLING-7134
> URL: https://issues.apache.org/jira/browse/SLING-7134
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting, Servlets
>Reporter: Robert Munteanu
>Assignee: Radu Cotescu
> Attachments: scripting-engines-java-9.png
>
>
> When starting up the Sling launchpad with Java 9 and accessing 
> http://localhost:8080/bin/browser.html I get an empty page and the following 
> stack trace in the error log
> {noformat}18.09.2017 23:50:44.656 *ERROR* [127.0.0.1 [1505767840754] GET 
> /bin/browser.html HTTP/1.1] org.apache.sling.engine.impl.SlingRequestProcesso
> rImpl service: Uncaught SlingException
> jdk.nashorn.internal.runtime.ECMAException: ReferenceError: "window" is not 
> defined
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:319)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:291)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.objects.Global.__noSuchProperty__(Global.java:1615)
> at 
> jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$1$\^eval\_.:program(:5)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:652)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:513)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:517)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:420)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.access$300(NashornScriptEngine.java:72)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine$3.eval(NashornScriptEngine.java:513)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
> at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:77)
> at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.dispatchRequest(SlingRequestProcessorImpl.java:322)
> at 
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.dispatch(SlingRequestDispatcher.java:211)
> at 
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.include(SlingRequestDispatcher.java:104)
> at 
> org.apache.sling.scripting.jsp.taglib.IncludeTagHandler.dispatch(IncludeTagHandler.java:54)
> at 
> org.apache.sling.scripting.jsp.taglib.AbstractDispatcherTagHandler.doEndTag(AbstractDispatcherTagHandler.java:129)
> at 
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspx_meth_sling_005finclude_005f0(edi
> tdialog_jsp.java:128)
> at 
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspService(editdialog_jsp.java:99)
> at 
> org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:342)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:97)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory$JspScriptEngine.eval(JspScriptEngineFactory.java:603)
> at 
> 

[jira] [Updated] (SLING-7134) Script execution order is not deterministic

[Radu Cotescu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu updated SLING-7134:

Component/s: Servlets

> Script execution order is not deterministic
> ---
>
> Key: SLING-7134
> URL: https://issues.apache.org/jira/browse/SLING-7134
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting, Servlets
>Reporter: Robert Munteanu
>Assignee: Radu Cotescu
> Attachments: scripting-engines-java-9.png
>
>
> When starting up the Sling launchpad with Java 9 and accessing 
> http://localhost:8080/bin/browser.html I get an empty page and the following 
> stack trace in the error log
> {noformat}18.09.2017 23:50:44.656 *ERROR* [127.0.0.1 [1505767840754] GET 
> /bin/browser.html HTTP/1.1] org.apache.sling.engine.impl.SlingRequestProcesso
> rImpl service: Uncaught SlingException
> jdk.nashorn.internal.runtime.ECMAException: ReferenceError: "window" is not 
> defined
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.error(ECMAErrors.java:57)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:319)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ECMAErrors.referenceError(ECMAErrors.java:291)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.objects.Global.__noSuchProperty__(Global.java:1615)
> at 
> jdk.scripting.nashorn.scripts/jdk.nashorn.internal.scripts.Script$Recompilation$1$\^eval\_.:program(:5)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunctionData.invoke(ScriptFunctionData.java:652)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptFunction.invoke(ScriptFunction.java:513)
> at 
> jdk.scripting.nashorn/jdk.nashorn.internal.runtime.ScriptRuntime.apply(ScriptRuntime.java:517)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.evalImpl(NashornScriptEngine.java:420)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine.access$300(NashornScriptEngine.java:72)
> at 
> jdk.scripting.nashorn/jdk.nashorn.api.scripting.NashornScriptEngine$3.eval(NashornScriptEngine.java:513)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:386)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.eval(DefaultSlingScript.java:184)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.service(DefaultSlingScript.java:491)
> at 
> org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
> at 
> org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
> at 
> org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:77)
> at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:282)
> at 
> org.apache.sling.engine.impl.SlingRequestProcessorImpl.dispatchRequest(SlingRequestProcessorImpl.java:322)
> at 
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.dispatch(SlingRequestDispatcher.java:211)
> at 
> org.apache.sling.engine.impl.request.SlingRequestDispatcher.include(SlingRequestDispatcher.java:104)
> at 
> org.apache.sling.scripting.jsp.taglib.IncludeTagHandler.dispatch(IncludeTagHandler.java:54)
> at 
> org.apache.sling.scripting.jsp.taglib.AbstractDispatcherTagHandler.doEndTag(AbstractDispatcherTagHandler.java:129)
> at 
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspx_meth_sling_005finclude_005f0(edi
> tdialog_jsp.java:128)
> at 
> org.apache.jsp.libs.composum.nodes.console.components.codeeditor.editdialog.editdialog_jsp._jspService(editdialog_jsp.java:99)
> at 
> org.apache.sling.scripting.jsp.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
> at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:502)
> at 
> org.apache.sling.scripting.jsp.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:449)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.callJsp(JspScriptEngineFactory.java:342)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory.access$100(JspScriptEngineFactory.java:97)
> at 
> org.apache.sling.scripting.jsp.JspScriptEngineFactory$JspScriptEngine.eval(JspScriptEngineFactory.java:603)
> at 
> org.apache.sling.scripting.core.impl.DefaultSlingScript.call(DefaultSlingScript.java:388)
> at 
>