date:20171218

[Fwd: [sling-tooling-scm] branch master updated: Add utility script for generating jira links to commits]

2017-12-18 Thread Robert Munteanu

Hi,

Just FYI, if you want to generate links for commits and paste them in
Jira there's now a simple way to do it via the jira_link_for_commit.sh
script.

I symlink it to $HOME/bin and invoke it via

  jira_link_for_commit.sh | xclip 

(I think for Mac you need to replace xclip with something else)

which places the link in the clipboard and makes it quite easy to add
this information to Jira.

Thanks,

Robert--- Begin Message ---
This is an automated email from the ASF dual-hosted git repository.

rombert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-tooling-scm.git


The following commit(s) were added to refs/heads/master by this push:
 new 9d97aba  Add utility script for generating jira links to commits
9d97aba is described below

commit 9d97ababc34f330f885f2548741544c9b16e724b
Author: Robert Munteanu 
AuthorDate: Mon Dec 18 23:20:12 2017 +0200

Add utility script for generating jira links to commits
---
 scripts/jira_link_for_commit.sh | 12 
 1 file changed, 12 insertions(+)

diff --git a/scripts/jira_link_for_commit.sh b/scripts/jira_link_for_commit.sh
new file mode 100755
index 000..f524463
--- /dev/null
+++ b/scripts/jira_link_for_commit.sh
@@ -0,0 +1,12 @@
+#!/bin/sh -e
+
+if [ $# -eq 0 ]; then
+commit=HEAD
+else
+commit=$1
+fi
+hash=$(git rev-parse --short ${commit})
+base=$(git remote get-url origin)
+url=${base%.git}/commit/${hash}
+
+echo "[commit ${hash}|${url}]"

-- 
To stop receiving notification emails like this one, please contact
['"comm...@sling.apache.org" '].
--- End Message ---

[jira] [Resolved] (SLING-7317) Update to maven-bundle-plugin 3.4.0

2017-12-18 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-7317.

Resolution: Fixed

Fixed in [commit 7bef541|https://github.com/apache/sling-parent/commit/7bef541]


> Update to maven-bundle-plugin 3.4.0
> ---
>
> Key: SLING-7317
> URL: https://issues.apache.org/jira/browse/SLING-7317
> Project: Sling
>  Issue Type: Improvement
>  Components: General
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
> Fix For: Parent 33
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7317) Update to maven-bundle-plugin 3.4.0

2017-12-18 Thread Robert Munteanu (JIRA)

Robert Munteanu created SLING-7317:
--

 Summary: Update to maven-bundle-plugin 3.4.0
 Key: SLING-7317
 URL: https://issues.apache.org/jira/browse/SLING-7317
 Project: Sling
  Issue Type: Improvement
  Components: General
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: Parent 33






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

2017-12-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295335#comment-16295335
 ] 

ASF GitHub Bot commented on SLING-7313:
---

kwin commented on issue #1: SLING-7313 refresh the resource type resolver as 
well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#issuecomment-352504439
 
 
   @jsedding Please check again. The only thing I am not sure about is 
concurrency here. May this context be used from two different threads? If so 
isn't it dangerous to not synchronize close and refresh? After the check for 
null the context may have been closed in another thread... Then an NPE would be 
thrown...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ResourceResolverImpl#refresh should also refresh the internal 
> resourceTyperesourceResolver
> --
>
> Key: SLING-7313
> URL: https://issues.apache.org/jira/browse/SLING-7313
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.32
>Reporter: Julian Sedding
>Priority: Minor
> Attachments: refresh-session.txt
>
>
> I noticed warning log messages due to long-lived Oak sessions (see 
> attachment) and traced them back to a long-lived service {{ResourceResolver}} 
> in the I18N code ({{JcrResourceBundleProvider}}). Care is taken to 
> periodically refresh this {{ResourceResolver}}, however, the {{#refresh()}} 
> call is not propagated to the internal {{resourceTypeResourceResolver}} used 
> by {{ResourceResolverImpl}} and thus a warning is logged.
> This could be solved by using short-lived RRs in the I18N code, but I think 
> we should also refresh the internal {{resourceTypeResourceResolver}} used by 
> {{ResourceResolverImpl}} when RR is refreshed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] kwin commented on issue #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox

kwin commented on issue #1: SLING-7313 refresh the resource type resolver as 
well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#issuecomment-352504439
 
 
   @jsedding Please check again. The only thing I am not sure about is 
concurrency here. May this context be used from two different threads? If so 
isn't it dangerous to not synchronize close and refresh? After the check for 
null the context may have been closed in another thread... Then an NPE would be 
thrown...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

2017-12-18 Thread Konrad Windszus

Hi Oli,
Could you do me a favour and start the Maven build with debug options and set a 
breakpoint to 
https://github.com/apache/sling-slingstart-maven-plugin/blob/c74831bd13e988e87192eadf75de5dc6daacd61d/src/main/java/org/apache/sling/maven/slingstart/PomArtifactVersionResolver.java#L55
 
.
Basically that condition should be true and return the proper version. I am 
wondering why this is not the case on your computer.

> On 18. Dec 2017, at 15:14, Oliver Lietz  wrote:
> 
> On Monday 18 December 2017 14:53:50 Konrad Windszus wrote:
>> There is a dependency from Validation Core to SlingStart Maven Plugin 1.7.14
>> (which is not yet released to Maven Central). An older version of
>> SlingStart Maven Plugin does not allow to leave out the version here from
>> the provisioning model. This is a chicken/egg problem. But switching to the
>> latest SNAPSHOT (i.e. slingstart-maven-plugin 1.7.15-SNAPSHOT) temporarily
>> should allow you to build again.
> 
> That's not the problem as I have built 1.7.14 yesterday around 2 pm (it's in 
> my local Maven repo) and the error is the same with 1.7.15-SNAPSHOT.
> 
> O.
> 
>>> On 18. Dec 2017, at 14:29, Oliver Lietz  wrote:
>>> 
>>> On Sunday 17 December 2017 13:04:41 Konrad Windszus wrote:
 Hi,
 
 We solved several issues in these releases:
 
 SlingStart Maven Plugin:
 https://issues.apache.org/jira/projects/SLING/versions/12342309
 Validation
 Core & Test Services:
 https://issues.apache.org/jira/projects/SLING/versions/12342296
>>> 
>>> The latest changes in Validation Core break my aggregator [1] build:
>>> 
>>> beat:repos olli$ mvn clean install
>>> [INFO] Scanning for projects...
>>> [INFO] Extended Maven classpath (scope 'provided') by the dependencies
>>> extracted from the Sling model.
>>> [ERROR] Internal error: java.lang.IllegalArgumentException: Unable to
>>> resolve dependency:
>>> mvn:org.apache.sling/org.apache.sling.validation.core/LATEST -> [Help 1]
>>> org.apache.maven.InternalErrorException: Internal error:
>>> java.lang.IllegalArgumentException: Unable to resolve dependency:
>>> mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
>>> 
>>>   at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:122)
>>>   at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
>>>   at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
>>>   at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
>>>   at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>>>   at sun.reflect.NativeMethodAccessorImpl.invoke
>>> 
>>> (NativeMethodAccessorImpl.java:62)
>>> 
>>>   at sun.reflect.DelegatingMethodAccessorImpl.invoke
>>> 
>>> (DelegatingMethodAccessorImpl.java:43)
>>> 
>>>   at java.lang.reflect.Method.invoke (Method.java:498)
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
>>> 
>>> (Launcher.java:289)
>>> 
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.launch
>>> 
>>> (Launcher.java:229)
>>> 
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
>>> 
>>> (Launcher.java:415)
>>> 
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.main
>>> 
>>> (Launcher.java:356)
>>> Caused by: java.lang.IllegalArgumentException: Unable to resolve
>>> dependency: mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
>>> 
>>>   at org.apache.sling.maven.slingstart.PomArtifactVersionResolver.resolve
>>> 
>>> (PomArtifactVersionResolver.java:63)
>>> 
>>>   at
>>> 
>>> org.apache.sling.provisioning.model.ModelResolveUtility.resolveArtifactVer
>>> sion (ModelResolveUtility.java:94)
>>> 
>>>   at
>>> 
>>> org.apache.sling.provisioning.model.EffectiveModelProcessor.processArtifac
>>> t
>>> (EffectiveModelProcessor.java:51)
>>> 
>>>   at org.apache.sling.provisioning.model.ModelProcessor.process
>>> 
>>> (ModelProcessor.java:62)
>>> 
>>>   at org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel
>>> 
>>> (ModelUtility.java:155)
>>> 
>>>   at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies
>>> 
>>> (ModelPreprocessor.java:164)
>>> 
>>>   at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies
>>> 
>>> (ModelPreprocessor.java:88)
>>> 
>>>   at
>>> 
>>> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProj
>>> ectsRead (DependencyLifecycleParticipant.java:78)
>>> 
>>>   at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
>>>   at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
>>>   at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
>>>   at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
>>>   at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
>>>   at org.apache.maven.cli.MavenCli.main

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

2017-12-18 Thread Konrad Windszus

Ok, I will check once more.
Thanks
Konrad

> On 18. Dec 2017, at 15:14, Oliver Lietz  wrote:
> 
> On Monday 18 December 2017 14:53:50 Konrad Windszus wrote:
>> There is a dependency from Validation Core to SlingStart Maven Plugin 1.7.14
>> (which is not yet released to Maven Central). An older version of
>> SlingStart Maven Plugin does not allow to leave out the version here from
>> the provisioning model. This is a chicken/egg problem. But switching to the
>> latest SNAPSHOT (i.e. slingstart-maven-plugin 1.7.15-SNAPSHOT) temporarily
>> should allow you to build again.
> 
> That's not the problem as I have built 1.7.14 yesterday around 2 pm (it's in 
> my local Maven repo) and the error is the same with 1.7.15-SNAPSHOT.
> 
> O.
> 
>>> On 18. Dec 2017, at 14:29, Oliver Lietz  wrote:
>>> 
>>> On Sunday 17 December 2017 13:04:41 Konrad Windszus wrote:
 Hi,
 
 We solved several issues in these releases:
 
 SlingStart Maven Plugin:
 https://issues.apache.org/jira/projects/SLING/versions/12342309
 Validation
 Core & Test Services:
 https://issues.apache.org/jira/projects/SLING/versions/12342296
>>> 
>>> The latest changes in Validation Core break my aggregator [1] build:
>>> 
>>> beat:repos olli$ mvn clean install
>>> [INFO] Scanning for projects...
>>> [INFO] Extended Maven classpath (scope 'provided') by the dependencies
>>> extracted from the Sling model.
>>> [ERROR] Internal error: java.lang.IllegalArgumentException: Unable to
>>> resolve dependency:
>>> mvn:org.apache.sling/org.apache.sling.validation.core/LATEST -> [Help 1]
>>> org.apache.maven.InternalErrorException: Internal error:
>>> java.lang.IllegalArgumentException: Unable to resolve dependency:
>>> mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
>>> 
>>>   at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:122)
>>>   at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
>>>   at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
>>>   at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
>>>   at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>>>   at sun.reflect.NativeMethodAccessorImpl.invoke
>>> 
>>> (NativeMethodAccessorImpl.java:62)
>>> 
>>>   at sun.reflect.DelegatingMethodAccessorImpl.invoke
>>> 
>>> (DelegatingMethodAccessorImpl.java:43)
>>> 
>>>   at java.lang.reflect.Method.invoke (Method.java:498)
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
>>> 
>>> (Launcher.java:289)
>>> 
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.launch
>>> 
>>> (Launcher.java:229)
>>> 
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
>>> 
>>> (Launcher.java:415)
>>> 
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.main
>>> 
>>> (Launcher.java:356)
>>> Caused by: java.lang.IllegalArgumentException: Unable to resolve
>>> dependency: mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
>>> 
>>>   at org.apache.sling.maven.slingstart.PomArtifactVersionResolver.resolve
>>> 
>>> (PomArtifactVersionResolver.java:63)
>>> 
>>>   at
>>> 
>>> org.apache.sling.provisioning.model.ModelResolveUtility.resolveArtifactVer
>>> sion (ModelResolveUtility.java:94)
>>> 
>>>   at
>>> 
>>> org.apache.sling.provisioning.model.EffectiveModelProcessor.processArtifac
>>> t
>>> (EffectiveModelProcessor.java:51)
>>> 
>>>   at org.apache.sling.provisioning.model.ModelProcessor.process
>>> 
>>> (ModelProcessor.java:62)
>>> 
>>>   at org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel
>>> 
>>> (ModelUtility.java:155)
>>> 
>>>   at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies
>>> 
>>> (ModelPreprocessor.java:164)
>>> 
>>>   at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies
>>> 
>>> (ModelPreprocessor.java:88)
>>> 
>>>   at
>>> 
>>> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProj
>>> ectsRead (DependencyLifecycleParticipant.java:78)
>>> 
>>>   at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
>>>   at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
>>>   at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
>>>   at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
>>>   at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
>>>   at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
>>>   at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>>>   at sun.reflect.NativeMethodAccessorImpl.invoke
>>> 
>>> (NativeMethodAccessorImpl.java:62)
>>> 
>>>   at sun.reflect.DelegatingMethodAccessorImpl.invoke
>>> 
>>> (DelegatingMethodAccessorImpl.java:43)
>>> 
>>>   at java.lang.reflect.Method.invoke (Method.java:498)
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
>>> 
>>> (Launcher.java:289)
>>> 
>>>   at org.codehaus.plexus.classworlds.launcher.Launcher.launch
>>> 
>>> (Launcher.java:229)
>>> 
>>>   at

RE: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

2017-12-18 Thread Stefan Seifert

+1

CVE-2017-15700 - Apache Sling Authentication Service vulnerability

2017-12-18 Thread Antonio Sanso

Severity: High

Vendor: The Apache Software Foundation

Versions Affected:
Apache Sling Authentication Service 1.4.0

Description:
A flaw in the org.apache.sling.auth.core.AuthUtil#isRedirectValid method allows 
an attacker, through the Sling login form, to trick a victim to send over their 
credentials.

Mitigation:
Users should upgrade to version 1.4.2 or later of the Apache Sling 
Authentication Service module

Credit:
François Lajeunesse-Robert

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

2017-12-18 Thread Oliver Lietz

On Monday 18 December 2017 14:53:50 Konrad Windszus wrote:
> There is a dependency from Validation Core to SlingStart Maven Plugin 1.7.14
> (which is not yet released to Maven Central). An older version of
> SlingStart Maven Plugin does not allow to leave out the version here from
> the provisioning model. This is a chicken/egg problem. But switching to the
> latest SNAPSHOT (i.e. slingstart-maven-plugin 1.7.15-SNAPSHOT) temporarily
> should allow you to build again.

That's not the problem as I have built 1.7.14 yesterday around 2 pm (it's in 
my local Maven repo) and the error is the same with 1.7.15-SNAPSHOT.

O.

> > On 18. Dec 2017, at 14:29, Oliver Lietz  wrote:
> > 
> > On Sunday 17 December 2017 13:04:41 Konrad Windszus wrote:
> >> Hi,
> >> 
> >> We solved several issues in these releases:
> >> 
> >> SlingStart Maven Plugin:
> >> https://issues.apache.org/jira/projects/SLING/versions/12342309
> >> Validation
> >> Core & Test Services:
> >> https://issues.apache.org/jira/projects/SLING/versions/12342296
> > 
> > The latest changes in Validation Core break my aggregator [1] build:
> > 
> > beat:repos olli$ mvn clean install
> > [INFO] Scanning for projects...
> > [INFO] Extended Maven classpath (scope 'provided') by the dependencies
> > extracted from the Sling model.
> > [ERROR] Internal error: java.lang.IllegalArgumentException: Unable to
> > resolve dependency:
> > mvn:org.apache.sling/org.apache.sling.validation.core/LATEST -> [Help 1]
> > org.apache.maven.InternalErrorException: Internal error:
> > java.lang.IllegalArgumentException: Unable to resolve dependency:
> > mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
> > 
> >at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:122)
> >at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> >at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> >at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> >at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> >at sun.reflect.NativeMethodAccessorImpl.invoke
> > 
> > (NativeMethodAccessorImpl.java:62)
> > 
> >at sun.reflect.DelegatingMethodAccessorImpl.invoke
> > 
> > (DelegatingMethodAccessorImpl.java:43)
> > 
> >at java.lang.reflect.Method.invoke (Method.java:498)
> >at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> > 
> > (Launcher.java:289)
> > 
> >at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> > 
> > (Launcher.java:229)
> > 
> >at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> > 
> > (Launcher.java:415)
> > 
> >at org.codehaus.plexus.classworlds.launcher.Launcher.main
> > 
> > (Launcher.java:356)
> > Caused by: java.lang.IllegalArgumentException: Unable to resolve
> > dependency: mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
> > 
> >at org.apache.sling.maven.slingstart.PomArtifactVersionResolver.resolve
> > 
> > (PomArtifactVersionResolver.java:63)
> > 
> >at
> > 
> > org.apache.sling.provisioning.model.ModelResolveUtility.resolveArtifactVer
> > sion (ModelResolveUtility.java:94)
> > 
> >at
> > 
> > org.apache.sling.provisioning.model.EffectiveModelProcessor.processArtifac
> > t
> > (EffectiveModelProcessor.java:51)
> > 
> >at org.apache.sling.provisioning.model.ModelProcessor.process
> > 
> > (ModelProcessor.java:62)
> > 
> >at org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel
> > 
> > (ModelUtility.java:155)
> > 
> >at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies
> > 
> > (ModelPreprocessor.java:164)
> > 
> >at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies
> > 
> > (ModelPreprocessor.java:88)
> > 
> >at
> > 
> > org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProj
> > ectsRead (DependencyLifecycleParticipant.java:78)
> > 
> >at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
> >at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> >at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> >at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> >at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> >at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> >at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> >at sun.reflect.NativeMethodAccessorImpl.invoke
> > 
> > (NativeMethodAccessorImpl.java:62)
> > 
> >at sun.reflect.DelegatingMethodAccessorImpl.invoke
> > 
> > (DelegatingMethodAccessorImpl.java:43)
> > 
> >at java.lang.reflect.Method.invoke (Method.java:498)
> >at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> > 
> > (Launcher.java:289)
> > 
> >at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> > 
> > (Launcher.java:229)
> > 
> >at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> > 
> > (Launcher.java:415)
> > 
> >

[jira] [Resolved] (SLING-7259) Repo Init: Empty glob causes repo-init fail

2017-12-18 Thread Bertrand Delacretaz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz resolved SLING-7259.

Resolution: Duplicate

> Repo Init: Empty glob causes repo-init fail
> ---
>
> Key: SLING-7259
> URL: https://issues.apache.org/jira/browse/SLING-7259
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Lydia Puric
>
> According to 
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html
>  empty glob is supported to restrict access only the node but not its 
> subtrees. 
> Doing this it causes the repo-init to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7259) Repo Init: Empty glob causes repo-init fail

2017-12-18 Thread Bertrand Delacretaz (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295022#comment-16295022
 ] 

Bertrand Delacretaz commented on SLING-7259:


Duplicate of SLING-7280

> Repo Init: Empty glob causes repo-init fail
> ---
>
> Key: SLING-7259
> URL: https://issues.apache.org/jira/browse/SLING-7259
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: Lydia Puric
>
> According to 
> https://jackrabbit.apache.org/oak/docs/security/authorization/restriction.html
>  empty glob is supported to restrict access only the node but not its 
> subtrees. 
> Doing this it causes the repo-init to fail.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

2017-12-18 Thread Konrad Windszus

There is a dependency from Validation Core to SlingStart Maven Plugin 1.7.14 
(which is not yet released to Maven Central). An older version of SlingStart 
Maven Plugin does not allow to leave out the version here from the provisioning 
model.
This is a chicken/egg problem. But switching to the latest SNAPSHOT (i.e. 
slingstart-maven-plugin 1.7.15-SNAPSHOT) temporarily should allow you to build 
again.

> On 18. Dec 2017, at 14:29, Oliver Lietz  wrote:
> 
> On Sunday 17 December 2017 13:04:41 Konrad Windszus wrote:
>> Hi,
>> 
>> We solved several issues in these releases:
>> 
>> SlingStart Maven Plugin:
>> https://issues.apache.org/jira/projects/SLING/versions/12342309 Validation
>> Core & Test Services:
>> https://issues.apache.org/jira/projects/SLING/versions/12342296
> 
> The latest changes in Validation Core break my aggregator [1] build:
> 
> beat:repos olli$ mvn clean install
> [INFO] Scanning for projects...
> [INFO] Extended Maven classpath (scope 'provided') by the dependencies 
> extracted from the Sling model.
> [ERROR] Internal error: java.lang.IllegalArgumentException: Unable to resolve 
> dependency: mvn:org.apache.sling/org.apache.sling.validation.core/LATEST -> 
> [Help 1]
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.IllegalArgumentException: Unable to resolve dependency: 
> mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
>at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:122)
>at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
>at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
>at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
>at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>at java.lang.reflect.Method.invoke (Method.java:498)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
>at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
>at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> Caused by: java.lang.IllegalArgumentException: Unable to resolve dependency: 
> mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
>at org.apache.sling.maven.slingstart.PomArtifactVersionResolver.resolve 
> (PomArtifactVersionResolver.java:63)
>at 
> org.apache.sling.provisioning.model.ModelResolveUtility.resolveArtifactVersion
>  
> (ModelResolveUtility.java:94)
>at 
> org.apache.sling.provisioning.model.EffectiveModelProcessor.processArtifact 
> (EffectiveModelProcessor.java:51)
>at org.apache.sling.provisioning.model.ModelProcessor.process 
> (ModelProcessor.java:62)
>at org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel 
> (ModelUtility.java:155)
>at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies 
> (ModelPreprocessor.java:164)
>at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies 
> (ModelPreprocessor.java:88)
>at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProjectsRead
>  
> (DependencyLifecycleParticipant.java:78)
>at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
>at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
>at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
>at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
>at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
>at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
>at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
>at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
>at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
>at java.lang.reflect.Method.invoke (Method.java:498)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
>at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
>at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
>at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/InternalErrorException
> 
> Adding a version back for Validation Core unbreaks the build.
> 
> Regards,
> O.

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

2017-12-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295002#comment-16295002
 ] 

ASF GitHub Bot commented on SLING-7313:
---

kwin commented on a change in pull request #1: SLING-7313 refresh the resource 
type resolver as well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157487858
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/helper/ResourceResolverControl.java
 ##
 @@ -148,12 +148,20 @@ private void logout() {
 }
 
 /**
- * Refreshes all refreshable providers.
+ * Refreshes all refreshable providers as well as the resolver used for 
resource types.
  */
 public void refresh(@Nonnull final ResourceResolverContext context) {
 for (final AuthenticatedResourceProvider p : 
context.getProviderManager().getAllUsedRefreshable()) {
 p.refresh();
 }
+if (this.resourceTypeResourceResolver != null) {
+try {
+this.resourceTypeResourceResolver.close();
+} catch ( final Throwable t) {
+// the resolver (or the underlying provider) might already be 
terminated (bundle stopped etc.)
 
 Review comment:
   Ok, agree.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ResourceResolverImpl#refresh should also refresh the internal 
> resourceTyperesourceResolver
> --
>
> Key: SLING-7313
> URL: https://issues.apache.org/jira/browse/SLING-7313
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.32
>Reporter: Julian Sedding
>Priority: Minor
> Attachments: refresh-session.txt
>
>
> I noticed warning log messages due to long-lived Oak sessions (see 
> attachment) and traced them back to a long-lived service {{ResourceResolver}} 
> in the I18N code ({{JcrResourceBundleProvider}}). Care is taken to 
> periodically refresh this {{ResourceResolver}}, however, the {{#refresh()}} 
> call is not propagated to the internal {{resourceTypeResourceResolver}} used 
> by {{ResourceResolverImpl}} and thus a warning is logged.
> This could be solved by using short-lived RRs in the I18N code, but I think 
> we should also refresh the internal {{resourceTypeResourceResolver}} used by 
> {{ResourceResolverImpl}} when RR is refreshed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

2017-12-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294999#comment-16294999
 ] 

ASF GitHub Bot commented on SLING-7313:
---

kwin commented on a change in pull request #1: SLING-7313 refresh the resource 
type resolver as well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157487797
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/helper/ResourceResolverControl.java
 ##
 @@ -148,12 +148,20 @@ private void logout() {
 }
 
 /**
- * Refreshes all refreshable providers.
+ * Refreshes all refreshable providers as well as the resolver used for 
resource types.
  */
 public void refresh(@Nonnull final ResourceResolverContext context) {
 for (final AuthenticatedResourceProvider p : 
context.getProviderManager().getAllUsedRefreshable()) {
 p.refresh();
 }
+if (this.resourceTypeResourceResolver != null) {
+try {
+this.resourceTypeResourceResolver.close();
 
 Review comment:
   Yes, of course. Good catch


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ResourceResolverImpl#refresh should also refresh the internal 
> resourceTyperesourceResolver
> --
>
> Key: SLING-7313
> URL: https://issues.apache.org/jira/browse/SLING-7313
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.32
>Reporter: Julian Sedding
>Priority: Minor
> Attachments: refresh-session.txt
>
>
> I noticed warning log messages due to long-lived Oak sessions (see 
> attachment) and traced them back to a long-lived service {{ResourceResolver}} 
> in the I18N code ({{JcrResourceBundleProvider}}). Care is taken to 
> periodically refresh this {{ResourceResolver}}, however, the {{#refresh()}} 
> call is not propagated to the internal {{resourceTypeResourceResolver}} used 
> by {{ResourceResolverImpl}} and thus a warning is logged.
> This could be solved by using short-lived RRs in the I18N code, but I think 
> we should also refresh the internal {{resourceTypeResourceResolver}} used by 
> {{ResourceResolverImpl}} when RR is refreshed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] kwin commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox

kwin commented on a change in pull request #1: SLING-7313 refresh the resource 
type resolver as well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157487858
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/helper/ResourceResolverControl.java
 ##
 @@ -148,12 +148,20 @@ private void logout() {
 }
 
 /**
- * Refreshes all refreshable providers.
+ * Refreshes all refreshable providers as well as the resolver used for 
resource types.
  */
 public void refresh(@Nonnull final ResourceResolverContext context) {
 for (final AuthenticatedResourceProvider p : 
context.getProviderManager().getAllUsedRefreshable()) {
 p.refresh();
 }
+if (this.resourceTypeResourceResolver != null) {
+try {
+this.resourceTypeResourceResolver.close();
+} catch ( final Throwable t) {
+// the resolver (or the underlying provider) might already be 
terminated (bundle stopped etc.)
 
 Review comment:
   Ok, agree.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kwin commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox

kwin commented on a change in pull request #1: SLING-7313 refresh the resource 
type resolver as well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157487797
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/helper/ResourceResolverControl.java
 ##
 @@ -148,12 +148,20 @@ private void logout() {
 }
 
 /**
- * Refreshes all refreshable providers.
+ * Refreshes all refreshable providers as well as the resolver used for 
resource types.
  */
 public void refresh(@Nonnull final ResourceResolverContext context) {
 for (final AuthenticatedResourceProvider p : 
context.getProviderManager().getAllUsedRefreshable()) {
 p.refresh();
 }
+if (this.resourceTypeResourceResolver != null) {
+try {
+this.resourceTypeResourceResolver.close();
 
 Review comment:
   Yes, of course. Good catch


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

2017-12-18 Thread Oliver Lietz

On Sunday 17 December 2017 13:04:41 Konrad Windszus wrote:
> Hi,
> 
> We solved several issues in these releases:
> 
> SlingStart Maven Plugin:
> https://issues.apache.org/jira/projects/SLING/versions/12342309 Validation
> Core & Test Services:
> https://issues.apache.org/jira/projects/SLING/versions/12342296

The latest changes in Validation Core break my aggregator [1] build:

beat:repos olli$ mvn clean install
[INFO] Scanning for projects...
[INFO] Extended Maven classpath (scope 'provided') by the dependencies 
extracted from the Sling model.
[ERROR] Internal error: java.lang.IllegalArgumentException: Unable to resolve 
dependency: mvn:org.apache.sling/org.apache.sling.validation.core/LATEST -> 
[Help 1]
org.apache.maven.InternalErrorException: Internal error: 
java.lang.IllegalArgumentException: Unable to resolve dependency: 
mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:122)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: java.lang.IllegalArgumentException: Unable to resolve dependency: 
mvn:org.apache.sling/org.apache.sling.validation.core/LATEST
at org.apache.sling.maven.slingstart.PomArtifactVersionResolver.resolve 
(PomArtifactVersionResolver.java:63)
at 
org.apache.sling.provisioning.model.ModelResolveUtility.resolveArtifactVersion 
(ModelResolveUtility.java:94)
at 
org.apache.sling.provisioning.model.EffectiveModelProcessor.processArtifact 
(EffectiveModelProcessor.java:51)
at org.apache.sling.provisioning.model.ModelProcessor.process 
(ModelProcessor.java:62)
at org.apache.sling.provisioning.model.ModelUtility.getEffectiveModel 
(ModelUtility.java:155)
at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies 
(ModelPreprocessor.java:164)
at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies 
(ModelPreprocessor.java:88)
at 
org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProjectsRead

(DependencyLifecycleParticipant.java:78)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/InternalErrorException

Adding a version back for Validation Core unbreaks the build.

Regards,
O.

 [1] https://github.com/oliverlietz/apache-sling-aggregator

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

2017-12-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294899#comment-16294899
 ] 

ASF GitHub Bot commented on SLING-7313:
---

jsedding commented on a change in pull request #1: SLING-7313 refresh the 
resource type resolver as well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157258185
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/helper/ResourceResolverControl.java
 ##
 @@ -148,12 +148,20 @@ private void logout() {
 }
 
 /**
- * Refreshes all refreshable providers.
+ * Refreshes all refreshable providers as well as the resolver used for 
resource types.
  */
 public void refresh(@Nonnull final ResourceResolverContext context) {
 for (final AuthenticatedResourceProvider p : 
context.getProviderManager().getAllUsedRefreshable()) {
 p.refresh();
 }
+if (this.resourceTypeResourceResolver != null) {
+try {
+this.resourceTypeResourceResolver.close();
+} catch ( final Throwable t) {
+// the resolver (or the underlying provider) might already be 
terminated (bundle stopped etc.)
 
 Review comment:
   I would definitely log this Throwable, probably at warn level. Or not catch 
it at all, because it should not happen (tm) ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ResourceResolverImpl#refresh should also refresh the internal 
> resourceTyperesourceResolver
> --
>
> Key: SLING-7313
> URL: https://issues.apache.org/jira/browse/SLING-7313
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.32
>Reporter: Julian Sedding
>Priority: Minor
> Attachments: refresh-session.txt
>
>
> I noticed warning log messages due to long-lived Oak sessions (see 
> attachment) and traced them back to a long-lived service {{ResourceResolver}} 
> in the I18N code ({{JcrResourceBundleProvider}}). Care is taken to 
> periodically refresh this {{ResourceResolver}}, however, the {{#refresh()}} 
> call is not propagated to the internal {{resourceTypeResourceResolver}} used 
> by {{ResourceResolverImpl}} and thus a warning is logged.
> This could be solved by using short-lived RRs in the I18N code, but I think 
> we should also refresh the internal {{resourceTypeResourceResolver}} used by 
> {{ResourceResolverImpl}} when RR is refreshed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

2017-12-18 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294900#comment-16294900
 ] 

ASF GitHub Bot commented on SLING-7313:
---

jsedding commented on a change in pull request #1: SLING-7313 refresh the 
resource type resolver as well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157257991
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/helper/ResourceResolverControl.java
 ##
 @@ -148,12 +148,20 @@ private void logout() {
 }
 
 /**
- * Refreshes all refreshable providers.
+ * Refreshes all refreshable providers as well as the resolver used for 
resource types.
  */
 public void refresh(@Nonnull final ResourceResolverContext context) {
 for (final AuthenticatedResourceProvider p : 
context.getProviderManager().getAllUsedRefreshable()) {
 p.refresh();
 }
+if (this.resourceTypeResourceResolver != null) {
+try {
+this.resourceTypeResourceResolver.close();
 
 Review comment:
   I think you meant to call #refresh() here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ResourceResolverImpl#refresh should also refresh the internal 
> resourceTyperesourceResolver
> --
>
> Key: SLING-7313
> URL: https://issues.apache.org/jira/browse/SLING-7313
> Project: Sling
>  Issue Type: Improvement
>  Components: ResourceResolver
>Affects Versions: Resource Resolver 1.5.32
>Reporter: Julian Sedding
>Priority: Minor
> Attachments: refresh-session.txt
>
>
> I noticed warning log messages due to long-lived Oak sessions (see 
> attachment) and traced them back to a long-lived service {{ResourceResolver}} 
> in the I18N code ({{JcrResourceBundleProvider}}). Care is taken to 
> periodically refresh this {{ResourceResolver}}, however, the {{#refresh()}} 
> call is not propagated to the internal {{resourceTypeResourceResolver}} used 
> by {{ResourceResolverImpl}} and thus a warning is logged.
> This could be solved by using short-lived RRs in the I18N code, but I think 
> we should also refresh the internal {{resourceTypeResourceResolver}} used by 
> {{ResourceResolverImpl}} when RR is refreshed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] jsedding commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox

jsedding commented on a change in pull request #1: SLING-7313 refresh the 
resource type resolver as well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157257991
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/helper/ResourceResolverControl.java
 ##
 @@ -148,12 +148,20 @@ private void logout() {
 }
 
 /**
- * Refreshes all refreshable providers.
+ * Refreshes all refreshable providers as well as the resolver used for 
resource types.
  */
 public void refresh(@Nonnull final ResourceResolverContext context) {
 for (final AuthenticatedResourceProvider p : 
context.getProviderManager().getAllUsedRefreshable()) {
 p.refresh();
 }
+if (this.resourceTypeResourceResolver != null) {
+try {
+this.resourceTypeResourceResolver.close();
 
 Review comment:
   I think you meant to call #refresh() here.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jsedding commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

2017-12-18 Thread GitBox

jsedding commented on a change in pull request #1: SLING-7313 refresh the 
resource type resolver as well
URL: 
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/1#discussion_r157258185
 
 

 ##
 File path: 
src/main/java/org/apache/sling/resourceresolver/impl/helper/ResourceResolverControl.java
 ##
 @@ -148,12 +148,20 @@ private void logout() {
 }
 
 /**
- * Refreshes all refreshable providers.
+ * Refreshes all refreshable providers as well as the resolver used for 
resource types.
  */
 public void refresh(@Nonnull final ResourceResolverContext context) {
 for (final AuthenticatedResourceProvider p : 
context.getProviderManager().getAllUsedRefreshable()) {
 p.refresh();
 }
+if (this.resourceTypeResourceResolver != null) {
+try {
+this.resourceTypeResourceResolver.close();
+} catch ( final Throwable t) {
+// the resolver (or the underlying provider) might already be 
terminated (bundle stopped etc.)
 
 Review comment:
   I would definitely log this Throwable, probably at warn level. Or not catch 
it at all, because it should not happen (tm) ;)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Resolved] (SLING-7167) Adjust READMEs

2017-12-18 Thread Oliver Lietz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7167.
-
Resolution: Done

> Adjust READMEs
> --
>
> Key: SLING-7167
> URL: https://issues.apache.org/jira/browse/SLING-7167
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>
> * remove outdated information (/)
> * switch from plain text to Markdown (/)
> * add uniform header linking to Sling project (/)
> * add README where missing (/)
> Uniform header:
> 
> {noformat}
> # Apache Sling ... [module name from POM]
> This module is part of the [Apache Sling](https://sling.apache.org) project.
> {noformat}
> 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (SLING-7167) Adjust READMEs

2017-12-18 Thread Oliver Lietz (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189515#comment-16189515
 ] 

Oliver Lietz edited comment on SLING-7167 at 12/18/17 11:47 AM:


All of our modules in {{/trunk}} which are not of packaging type {{pom}} are 
adjusted.

*302 artifacts where packaging is not pom:*

* {{adapter-annotations}}
* {{apache-sling-jar-resource-bundle}}
* {{htl-maven-plugin}}
* {{jspc-maven-plugin}}
* {{launchpad-comparator}}
* {{maven-jcrocm-plugin}}
* {{maven-launchpad-plugin}}
* {{maven-sling-plugin}}
* {{org.apache.sling.adapter}}
* {{org.apache.sling.api}}
* {{org.apache.sling.auth.core}}
* {{org.apache.sling.auth.form}}
* {{org.apache.sling.auth.xing.api}}
* {{org.apache.sling.auth.xing.login}}
* {{org.apache.sling.auth.xing.oauth}}
* {{org.apache.sling.bnd.models}}
* {{org.apache.sling.bundleresource.impl}}
* {{org.apache.sling.caconfig.api}}
* {{org.apache.sling.caconfig.bnd-plugin}}
* {{org.apache.sling.caconfig.impl}}
* {{org.apache.sling.caconfig.integration-tests}}
* {{org.apache.sling.caconfig.spi}}
* {{org.apache.sling.cassandra}}
* {{org.apache.sling.commons.cache.api}}
* {{org.apache.sling.commons.cache.container-test}}
* {{org.apache.sling.commons.cache.ehcache}}
* {{org.apache.sling.commons.cache.impl}}
* {{org.apache.sling.commons.cache.infinispan}}
* {{org.apache.sling.commons.cache.portal}}
* {{org.apache.sling.commons.classloader}}
* {{org.apache.sling.commons.compiler}}
* {{org.apache.sling.commons.contentdetection}}
* {{org.apache.sling.commons.fsclassloader}}
* {{org.apache.sling.commons.html}}
* {{org.apache.sling.commons.johnzon}}
* {{org.apache.sling.commons.log}}
* {{org.apache.sling.commons.log.webconsole}}
* {{org.apache.sling.commons.logservice}}
* {{org.apache.sling.commons.messaging}}
* {{org.apache.sling.commons.messaging.mail}}
* {{org.apache.sling.commons.metrics}}
* {{org.apache.sling.commons.metrics-rrd4j}}
* {{org.apache.sling.commons.mime}}
* {{org.apache.sling.commons.osgi}}
* {{org.apache.sling.commons.scheduler}}
* {{org.apache.sling.commons.testing}}
* {{org.apache.sling.commons.threaddump}}
* {{org.apache.sling.commons.threads}}
* {{org.apache.sling.crankstart.launcher}}
* {{org.apache.sling.crankstart.test.services}}
* {{org.apache.sling.cransktart.test.model}}
* {{org.apache.sling.datasource}}
* {{org.apache.sling.discovery.api}}
* {{org.apache.sling.discovery.base}}
* {{org.apache.sling.discovery.commons}}
* {{org.apache.sling.discovery.impl}}
* {{org.apache.sling.discovery.oak}}
* {{org.apache.sling.discovery.standalone}}
* {{org.apache.sling.discovery.support}}
* {{org.apache.sling.distribution.api}}
* {{org.apache.sling.distribution.avro-serializer}}
* {{org.apache.sling.distribution.core}}
* {{org.apache.sling.distribution.it}}
* {{org.apache.sling.distribution.kryo-serializer}}
* {{org.apache.sling.distribution.sample}}
* {{org.apache.sling.dynamic-include}}
* {{org.apache.sling.engine}}
* {{org.apache.sling.event}}
* {{org.apache.sling.event.api}}
* {{org.apache.sling.event.dea}}
* {{org.apache.sling.extensions.classloader-leak-detector}}
* {{org.apache.sling.extensions.logback-groovy-fragment}}
* {{org.apache.sling.extensions.slf4j.mdc}}
* {{org.apache.sling.extensions.webconsolebranding}}
* {{org.apache.sling.extensions.webconsolesecurityprovider}}
* {{org.apache.sling.featureflags}}
* {{org.apache.sling.fragment.activation}}
* {{org.apache.sling.fragment.nashorn}}
* {{org.apache.sling.fragment.transaction}}
* {{org.apache.sling.fragment.ws}}
* {{org.apache.sling.fragment.xml}}
* {{org.apache.sling.fsresource}}
* {{org.apache.sling.hapi}}
* {{org.apache.sling.hapi.client}}
* {{org.apache.sling.hapi.samplecontent}}
* {{org.apache.sling.hc.annotations}}
* {{org.apache.sling.hc.api}}
* {{org.apache.sling.hc.core}}
* {{org.apache.sling.hc.it}}
* {{org.apache.sling.hc.junit.bridge}}
* {{org.apache.sling.hc.samples}}
* {{org.apache.sling.hc.support}}
* {{org.apache.sling.hc.webconsole}}
* {{org.apache.sling.i18n}}
* {{org.apache.sling.ide.api}}
* {{org.apache.sling.ide.api-test}}
* {{org.apache.sling.ide.artifacts}}
* {{org.apache.sling.ide.eclipse-core}}
* {{org.apache.sling.ide.eclipse-m2e-core}}
* {{org.apache.sling.ide.eclipse-m2e-test}}
* {{org.apache.sling.ide.eclipse-m2e-ui}}
* {{org.apache.sling.ide.eclipse-sightly-core}}
* {{org.apache.sling.ide.eclipse-sightly-ui}}
* {{org.apache.sling.ide.eclipse-test}}
* {{org.apache.sling.ide.eclipse-ui}}
* {{org.apache.sling.ide.feature}}
* {{org.apache.sling.ide.impl-resource}}
* {{org.apache.sling.ide.impl-resource-test}}
* {{org.apache.sling.ide.impl-vlt}}
* {{org.apache.sling.ide.impl-vlt-test}}
* {{org.apache.sling.ide.m2e-feature}}
* {{org.apache.sling.ide.p2update}}
* {{org.apache.sling.ide.sightly-feature}}
* {{org.apache.sling.ide.source-bundle}}
* {{org.apache.sling.ide.vlt-wrapper}}
* {{org.apache.sling.installer.console}}
* {{org.apache.sling.installer.core}}
*

[jira] [Updated] (SLING-7157) metatype.properties file must not be in OSGI-INF/metatype

2017-12-18 Thread Antonio Sanso (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso updated SLING-7157:
-
Fix Version/s: (was: Auth Core 1.4.2)
   Auth Core 1.4.4

> metatype.properties file must not be in OSGI-INF/metatype
> -
>
> Key: SLING-7157
> URL: https://issues.apache.org/jira/browse/SLING-7157
> Project: Sling
>  Issue Type: Bug
>Affects Versions: JCR Web Console 1.0.2, JCR Registration 1.0.2, JCR 
> ClassLoader 3.2.2, Form Based Authentication 1.0.8, Settings 1.3.8, Commons 
> Threads 3.2.6, Auth Core 1.4.0, SLF4J MDC Filter 1.0.0, Authentication XING 
> OAuth 0.0.2, Authentication XING Login 0.0.2, URL Rewriter 0.0.2, DataSource 
> Provider 1.0.4, NoSQL MongoDB Resource Provider 1.1.0, Commons Log 5.0.2, 
> Discovery Impl 1.2.12, Discovery Oak 1.2.18, JCR Davex 1.3.8, JCR Webdav 
> 2.3.8, JCR Installer 3.1.26
>Reporter: Carsten Ziegeler
>Priority: Blocker
> Fix For: JCR Web Console 1.0.4, JCR ClassLoader 3.2.4, Form Based 
> Authentication 1.0.10, Settings 1.3.10, Auth Core 1.4.4, Mongo Resource 
> Provider 1.0.0, Authentication XING OAuth 0.0.4, Authentication XING Login 
> 0.0.4, DataSource Provider 1.0.4, URL Rewriter 0.0.4, Commons Log 5.1.0, 
> Commons Threads 3.2.10, SLF4J MDC Filter 1.0.2, JCR Webdav 2.3.10, JCR 
> Installer 3.1.28, Discovery Impl 1.2.14, Discovery Oak 1.2.24, JCR Davex 
> 1.3.12
>
>
> According to the spec the metatype.properties file must not be inside the 
> OSGI-INF/metatype directory. This is against the spec, so we should move it 
> to OSGI-INF/l10n
> We probably should also upgrade the maven-scr-plugin for this 1.25.0
> I found the following files:
> ./bundles/auth/core/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/auth/form/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/commons/log/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/commons/threads/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/extensions/discovery/impl/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/extensions/discovery/oak/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/extensions/settings/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/classloader/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/davex/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/registration/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/webconsole/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./bundles/jcr/webdav/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/auth/org.apache.sling.auth.xing.login/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/auth/org.apache.sling.auth.xing.oauth/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/datasource/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/mongodb/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/slf4j-mdc/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/startup-filter/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./contrib/extensions/urlrewriter/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./installer/providers/jcr/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./samples/path-based-rtp/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./samples/workspacepicker/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./testing/junit/core/src/main/resources/OSGI-INF/metatype/metatype.properties
> ./testing/junit/healthcheck/src/main/resources/OSGI-INF/metatype/metatype.properties



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Closed] (SLING-7243) Improve validation in AuthUtil.isRedirectValid

2017-12-18 Thread Antonio Sanso (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antonio Sanso closed SLING-7243.


> Improve validation in AuthUtil.isRedirectValid
> --
>
> Key: SLING-7243
> URL: https://issues.apache.org/jira/browse/SLING-7243
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Reporter: Antonio Sanso
>Assignee: Antonio Sanso
>Priority: Minor
> Fix For: Auth Core 1.4.2
>
>
> The validation in {{AuthUtil.isRedirectValid}} might be improved.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[RESULT][VOTE] Release Apache Sling Authentication Service 1.4.2

2017-12-18 Thread Antonio Sanso

the vote passed with 4 binding +1s

Re: [VOTE] Release Apache Sling Authentication Service 1.4.2

2017-12-18 Thread Antonio Sanso

+1
On Dec 15, 2017, at 8:13 AM, Antonio Sanso  wrote:

> Hi,
> 
> We solved 1 issue in this release:
> 
> https://issues.apache.org/jira/browse/SLING-7243
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1837/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 1837  /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.

[jira] [Resolved] (SLING-7316) Update Tika to 1.17

2017-12-18 Thread Oliver Lietz (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7316.
-
Resolution: Done

> Update Tika to 1.17
> ---
>
> Key: SLING-7316
> URL: https://issues.apache.org/jira/browse/SLING-7316
> Project: Sling
>  Issue Type: Task
>  Components: Karaf
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
> Fix For: Karaf Features 0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7316) Update Tika to 1.17

2017-12-18 Thread Oliver Lietz (JIRA)

Oliver Lietz created SLING-7316:
---

 Summary: Update Tika to 1.17
 Key: SLING-7316
 URL: https://issues.apache.org/jira/browse/SLING-7316
 Project: Sling
  Issue Type: Task
  Components: Karaf
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Karaf Features 0.2.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (SLING-7315) Update Oak to 1.6.7

2017-12-18 Thread Oliver Lietz (JIRA)

Oliver Lietz created SLING-7315:
---

 Summary: Update Oak to 1.6.7
 Key: SLING-7315
 URL: https://issues.apache.org/jira/browse/SLING-7315
 Project: Sling
  Issue Type: Task
  Components: Karaf
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: Karaf Features 0.2.0






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[Fwd: [sling-tooling-scm] branch master updated: Add utility script for generating jira links to commits]

[jira] [Resolved] (SLING-7317) Update to maven-bundle-plugin 3.4.0

[jira] [Created] (SLING-7317) Update to maven-bundle-plugin 3.4.0

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

[GitHub] kwin commented on issue #1: SLING-7313 refresh the resource type resolver as well

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

RE: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

CVE-2017-15700 - Apache Sling Authentication Service vulnerability

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

[jira] [Resolved] (SLING-7259) Repo Init: Empty glob causes repo-init fail

[jira] [Commented] (SLING-7259) Repo Init: Empty glob causes repo-init fail

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

[GitHub] kwin commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

[GitHub] kwin commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

Re: [VOTE] Release Apache Sling SlingStart Maven Plugin 1.7.14 and Apache Sling Validation Core & Test Services version 1.0.4

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

[jira] [Commented] (SLING-7313) ResourceResolverImpl#refresh should also refresh the internal resourceTyperesourceResolver

[GitHub] jsedding commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

[GitHub] jsedding commented on a change in pull request #1: SLING-7313 refresh the resource type resolver as well

[jira] [Resolved] (SLING-7167) Adjust READMEs

[jira] [Comment Edited] (SLING-7167) Adjust READMEs

[jira] [Updated] (SLING-7157) metatype.properties file must not be in OSGI-INF/metatype

[jira] [Closed] (SLING-7243) Improve validation in AuthUtil.isRedirectValid

[RESULT][VOTE] Release Apache Sling Authentication Service 1.4.2

Re: [VOTE] Release Apache Sling Authentication Service 1.4.2

[jira] [Resolved] (SLING-7316) Update Tika to 1.17

[jira] [Created] (SLING-7316) Update Tika to 1.17

[jira] [Created] (SLING-7315) Update Oak to 1.6.7

31 matches

Site Navigation

Mail list logo

Footer information