[jira] [Commented] (SLING-7423) Support OAK 1.8 in JCR Oak Server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338881#comment-16338881
 ] 

ASF GitHub Bot commented on SLING-7423:
---

cschneider commented on issue #1: SLING-7423 Migrate to Oak 1.8
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-360388364
 
 
   Should we then have a branch for this or simply keep the PRs open?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OAK 1.8 in JCR Oak Server
> -
>
> Key: SLING-7423
> URL: https://issues.apache.org/jira/browse/SLING-7423
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: JCR Oak Server 1.1.4
>Reporter: Christian Schneider
>Assignee: Oliver Lietz
>Priority: Major
>
> The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API 
> was changed in an incompatible way. We should adapt to these changes. See 
> below for the changed classes.
> 1.6
> import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; 
> import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider;
> 1.7
> import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.InitialContent; -> oak-core
> import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; 
> -> oak-core
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cschneider commented on issue #1: SLING-7423 Migrate to Oak 1.8

[GitBox]

cschneider commented on issue #1: SLING-7423 Migrate to Oak 1.8
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-360388364
 
 
   Should we then have a branch for this or simply keep the PRs open?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7423) Support OAK 1.8 in JCR Oak Server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338817#comment-16338817
 ] 

ASF GitHub Bot commented on SLING-7423:
---

rombert commented on issue #1: SLING-7423 Migrate to Oak 1.8
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-360376671
 
 
   That would require a discussion on dev@sling IMO - moving to another Oak 
branch is a big change. I personally would like to see it happen after we are 
done releasing Sling 10, which is unfortunately blocked on 2 releases ( i18n 
and commons.threads ).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OAK 1.8 in JCR Oak Server
> -
>
> Key: SLING-7423
> URL: https://issues.apache.org/jira/browse/SLING-7423
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: JCR Oak Server 1.1.4
>Reporter: Christian Schneider
>Assignee: Oliver Lietz
>Priority: Major
>
> The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API 
> was changed in an incompatible way. We should adapt to these changes. See 
> below for the changed classes.
> 1.6
> import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; 
> import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider;
> 1.7
> import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.InitialContent; -> oak-core
> import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; 
> -> oak-core
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rombert commented on issue #1: SLING-7423 Migrate to Oak 1.8

[GitBox]

rombert commented on issue #1: SLING-7423 Migrate to Oak 1.8
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-360376671
 
 
   That would require a discussion on dev@sling IMO - moving to another Oak 
branch is a big change. I personally would like to see it happen after we are 
done releasing Sling 10, which is unfortunately blocked on 2 releases ( i18n 
and commons.threads ).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Please welcome Chris Millar, Sling committer

[Andreas Schaefer]

Welcome Chris

> On Jan 24, 2018, at 12:15 PM, Robert Munteanu  wrote:
> 
> Hi Sling community,
> 
> Based on his ongoing and valuable contributions to the project, the
> Sling PMC has elected Chris Millar as a Sling committer, and he has
> accepted the invitation.
> 
> Please join me in welcoming him!
> 
> Chris - if you want to honor the old tradition of new committers
> briefly introducing themselves to the list, feel free. And maybe take
> the time to verify your Git permissions and update http://sling.apache.
> org/project-information/project-team.html :-)
> 
> Best,
> 
> Robert
> 
> 

Re: Please welcome Chris Millar, Sling committer

[Jason E Bailey]

Welcome Chris!

Thanks
- Jason

On Wed, Jan 24, 2018, at 3:15 PM, Robert Munteanu wrote:
> Hi Sling community,
> 
> Based on his ongoing and valuable contributions to the project, the
> Sling PMC has elected Chris Millar as a Sling committer, and he has
> accepted the invitation.
> 
> Please join me in welcoming him!
> 
> Chris - if you want to honor the old tradition of new committers
> briefly introducing themselves to the list, feel free. And maybe take
> the time to verify your Git permissions and update http://sling.apache.
> org/project-information/project-team.html :-)
> 
> Best,
> 
> Robert
> 
> 

[jira] [Commented] (SLING-7423) Support OAK 1.8 in JCR Oak Server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338193#comment-16338193
 ] 

ASF GitHub Bot commented on SLING-7423:
---

cschneider commented on issue #1: SLING-7423 Migrate to Oak 1.8
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-360268133
 
 
   This does not work in Oak 1.8. I also did a PR for the karaf features 
though. Should I also look into the starter?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OAK 1.8 in JCR Oak Server
> -
>
> Key: SLING-7423
> URL: https://issues.apache.org/jira/browse/SLING-7423
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: JCR Oak Server 1.1.4
>Reporter: Christian Schneider
>Assignee: Oliver Lietz
>Priority: Major
>
> The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API 
> was changed in an incompatible way. We should adapt to these changes. See 
> below for the changed classes.
> 1.6
> import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; 
> import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider;
> 1.7
> import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.InitialContent; -> oak-core
> import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; 
> -> oak-core
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cschneider commented on issue #1: SLING-7423 Migrate to Oak 1.8

[GitBox]

cschneider commented on issue #1: SLING-7423 Migrate to Oak 1.8
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-360268133
 
 
   This does not work in Oak 1.8. I also did a PR for the karaf features 
though. Should I also look into the starter?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7423) Support OAK 1.8 in JCR Oak Server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338181#comment-16338181
 ] 

ASF GitHub Bot commented on SLING-7423:
---

rombert commented on issue #1: SLING-7423 Migrate to Oak 1.8
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-360265729
 
 
   Does this still work with Oak 1.6? Otherwise the bundle will not work in the 
current starter.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OAK 1.8 in JCR Oak Server
> -
>
> Key: SLING-7423
> URL: https://issues.apache.org/jira/browse/SLING-7423
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: JCR Oak Server 1.1.4
>Reporter: Christian Schneider
>Assignee: Oliver Lietz
>Priority: Major
>
> The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API 
> was changed in an incompatible way. We should adapt to these changes. See 
> below for the changed classes.
> 1.6
> import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; 
> import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider;
> 1.7
> import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.InitialContent; -> oak-core
> import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; 
> -> oak-core
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rombert commented on issue #1: SLING-7423 Migrate to Oak 1.8

[GitBox]

rombert commented on issue #1: SLING-7423 Migrate to Oak 1.8
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1#issuecomment-360265729
 
 
   Does this still work with Oak 1.6? Otherwise the bundle will not work in the 
current starter.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7443) Actual build for standalone jar is not working with latest JDK

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338180#comment-16338180
 ] 

Robert Munteanu commented on SLING-7443:


What exact version did you try, released 9 or 10-SNAPSHOT built from git? 
Version 10-SNAPSHOT will work with Java 9 if you add {--add-modules 
java.se.ee}}, while version 9 will only work with Java 8.

> Actual build for standalone jar is not working with latest JDK
> --
>
> Key: SLING-7443
> URL: https://issues.apache.org/jira/browse/SLING-7443
> Project: Sling
>  Issue Type: Bug
>  Components: Launchpad
> Environment: Windows 10, JDK 9 or latest 1.8
>Reporter: frederic rougeot
>Priority: Major
>  Labels: starter
>
> I tried to use your standalone jar with latest JDK, I mean JDK 9, or JDK 
> 1.8.0_162b12, but it does not work ... The following log is encountered with 
> JDK 1.8.162 when launching java -jar org.apache.sling.launchpad-9.jar:
> 24.01.2018 15:45:34.872 *ERROR* [FelixStartLevel] ERROR: Bundle '18' Error 
> starting 
> slinginstall:C:\projets\Veolia\tools\sling\startup\1\slf4j-api-1.7.21.jar 
> (org.osgi.framework.BundleException: Unable to resolve slf4j.api [18](R 
> 18.0): missing requirement [slf4j.api [18](R 18.0)] ...
>  
> So I will try now with JDK 1.8.0.161 (a colleague tells me it was quite OK 
> with JDK 1.8.0.77à



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Please welcome Chris Millar, Sling committer

[Robert Munteanu]

Hi Sling community,

Based on his ongoing and valuable contributions to the project, the
Sling PMC has elected Chris Millar as a Sling committer, and he has
accepted the invitation.

Please join me in welcoming him!

Chris - if you want to honor the old tradition of new committers
briefly introducing themselves to the list, feel free. And maybe take
the time to verify your Git permissions and update http://sling.apache.
org/project-information/project-team.html :-)

Best,

Robert

Re: Bundle Archetype inside Git Repo is not compiling

[Robert Munteanu]

On Wed, 2018-01-24 at 21:46 +0200, Robert Munteanu wrote:
> On Sun, 2018-01-21 at 12:27 +, Stefan Seifert wrote:
> > this parent pom is currently under voting in context of sling 10
> > and
> > only available in the staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-1
> > 85
> > 7/
> > 
> > once the voting is complete it will be available on maven central
> > as
> > well.
> 
> Typically we don't leave artifacts unbuildable, but I ran out of time
> doing it since this was such a large release. I'll change the
> archetypes to reference to 6-SNAPSHOT, as the release seems to take a
> bit longer.
> 
> Robert

It seems Oli beat me to it, but the builds fail due to 

  https://issues.apache.org/jira/browse/INFRA-15815

Robert

Re: Bundle Archetype inside Git Repo is not compiling

[Robert Munteanu]

On Sun, 2018-01-21 at 12:27 +, Stefan Seifert wrote:
> this parent pom is currently under voting in context of sling 10 and
> only available in the staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-185
> 7/
> 
> once the voting is complete it will be available on maven central as
> well.

Typically we don't leave artifacts unbuildable, but I ran out of time
doing it since this was such a large release. I'll change the
archetypes to reference to 6-SNAPSHOT, as the release seems to take a
bit longer.

Robert

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338125#comment-16338125
 ] 

Robert Munteanu commented on SLING-7432:


[~kwin] - I am working on removing all thread locals as well, I assume this 
might trip to the save/restore logic. I'm running the tests as we speak and 
I'll compare with your changes as well.

> Thread pool clean up code can lead to infinite loops in ThreadLocal.get
> ---
>
> Key: SLING-7432
> URL: https://issues.apache.org/jira/browse/SLING-7432
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Threads 3.2.10
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: Commons Threads 3.2.14
>
>
> The thread local clean up code added in SLING-6261 leads to Threads stuck in 
> {{ThreadLocal.get}}.
> I am working on a simplified test case, but the stack trace is similar to
> {noformat}
> "pool-1-thread-1" prio=10 tid=0x7f47f4374800 nid=0xb19 runnable 
> [0x7f47e734e000]
>java.lang.Thread.State: RUNNABLE
>   at java.lang.ThreadLocal$ThreadLocalMap.set(ThreadLocal.java:429)
>   at java.lang.ThreadLocal$ThreadLocalMap.access$100(ThreadLocal.java:261)
>   at java.lang.ThreadLocal.set(ThreadLocal.java:183)
>   at 
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocalsTest$RunnableImplementation.run(ThreadPoolExecutorCleaningThreadLocalsTest.java:100)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7444) Container and Reference Pipe (others?) are missing debug or trace logs

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7444.

   Resolution: Fixed
Fix Version/s: pipes 2.0.0

> Container and Reference Pipe (others?) are missing debug or trace logs
> --
>
> Key: SLING-7444
> URL: https://issues.apache.org/jira/browse/SLING-7444
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Trivial
> Fix For: pipes 2.0.0
>
>
> in case things go wrong, it's hard to see what's wrong



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7444) Container and Reference Pipe (others?) are missing debug or trace logs

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7444:
--

Assignee: Nicolas Peltier

> Container and Reference Pipe (others?) are missing debug or trace logs
> --
>
> Key: SLING-7444
> URL: https://issues.apache.org/jira/browse/SLING-7444
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Trivial
>
> in case things go wrong, it's hard to see what's wrong



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7444) Container and Reference Pipe (others?) are missing debug or trace logs

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier updated SLING-7444:
---
Priority: Trivial  (was: Major)

> Container and Reference Pipe (others?) are missing debug or trace logs
> --
>
> Key: SLING-7444
> URL: https://issues.apache.org/jira/browse/SLING-7444
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 1.1.0
>Reporter: Nicolas Peltier
>Priority: Trivial
>
> in case things go wrong, it's hard to see what's wrong



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cschneider commented on a change in pull request #1: Sling 7437

[GitBox]

cschneider commented on a change in pull request #1: Sling 7437
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/1#discussion_r163601930
 
 

 ##
 File path: pom.xml
 ##
 @@ -72,11 +80,11 @@
 
 javax.jcr
 jcr
-2.0
 
 
 org.osgi
 osgi.annotation
+6.0.1
 
 Review comment:
   Thanks .. somehow overlooked the link. I also wrongly simply removed the 
dependency instead of using the new groupId and artifactId. Now it works fine. 
Will update my PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kwin commented on a change in pull request #1: Sling 7437

[GitBox]

kwin commented on a change in pull request #1: Sling 7437
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/1#discussion_r163599157
 
 

 ##
 File path: pom.xml
 ##
 @@ -72,11 +80,11 @@
 
 javax.jcr
 jcr
-2.0
 
 
 org.osgi
 osgi.annotation
+6.0.1
 
 Review comment:
   Pretty extensively commented in 
https://github.com/apache/sling-parent/blob/0f5091f47716d3738efda90ec2b5e67c942a9226/pom.xml#L1199


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cschneider commented on a change in pull request #1: Sling 7437

[GitBox]

cschneider commented on a change in pull request #1: Sling 7437
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/1#discussion_r163598648
 
 

 ##
 File path: pom.xml
 ##
 @@ -72,11 +80,11 @@
 
 javax.jcr
 jcr
-2.0
 
 
 org.osgi
 osgi.annotation
+6.0.1
 
 Review comment:
   I was not able to find the correct annotation to set the version without 
this dep. Can you point me to some place where the correct one is used?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cschneider commented on a change in pull request #1: Sling 7437

[GitBox]

cschneider commented on a change in pull request #1: Sling 7437
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/1#discussion_r163598115
 
 

 ##
 File path: pom.xml
 ##
 @@ -22,11 +22,11 @@
 
 org.apache.sling
 sling
-32
+33-SNAPSHOT
 
 Review comment:
   Thanks. Did not know this. I used the version from the jcr oak server 
bundle. I will update my PRs on both projects to use the release version.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kwin commented on a change in pull request #1: Sling 7437

[GitBox]

kwin commented on a change in pull request #1: Sling 7437
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/1#discussion_r163597436
 
 

 ##
 File path: pom.xml
 ##
 @@ -72,11 +80,11 @@
 
 javax.jcr
 jcr
-2.0
 
 
 org.osgi
 osgi.annotation
+6.0.1
 
 Review comment:
   Please use the annotation dependency defined in the parent's depMgmt.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kwin commented on a change in pull request #1: Sling 7437

[GitBox]

kwin commented on a change in pull request #1: Sling 7437
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/1#discussion_r163597258
 
 

 ##
 File path: pom.xml
 ##
 @@ -22,11 +22,11 @@
 
 org.apache.sling
 sling
-32
+33-SNAPSHOT
 
 
 org.apache.sling.jcr.registration
-bundle
+jar
 
 Review comment:
   This is the default, rather leave it out.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kwin commented on a change in pull request #1: Sling 7437

[GitBox]

kwin commented on a change in pull request #1: Sling 7437
URL: 
https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/1#discussion_r163597184
 
 

 ##
 File path: pom.xml
 ##
 @@ -22,11 +22,11 @@
 
 org.apache.sling
 sling
-32
+33-SNAPSHOT
 
 Review comment:
   33 has been released, please don't rely on snapshots for parent versions 
(https://issues.apache.org/jira/browse/INFRA-15815)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cschneider opened a new pull request #1: Sling 7437

[GitBox]

cschneider opened a new pull request #1: Sling 7437
URL: https://github.com/apache/sling-org-apache-sling-jcr-registration/pull/1
 
 
   Update to current master, bnd-maven-plugin. 
   Opening pacakge import range for 
org.apache.jackrabbit.rmi.remote;version='[2,4)';resolution:=optional,\
org.apache.jackrabbit.rmi.server;version='[2,4)';resolution:=optional,\
   as it seems to be compatible


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7437) Support Oak 1.8 in org.apache.sling.jcr.registration

[Christian Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337833#comment-16337833
 ] 

Christian Schneider commented on SLING-7437:


I found that the new package version is 3 and that the update should be 
compatible. So I intend to simply open the version range.

> Support Oak 1.8 in org.apache.sling.jcr.registration
> 
>
> Key: SLING-7437
> URL: https://issues.apache.org/jira/browse/SLING-7437
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Registration 1.0.4
>Reporter: Christian Schneider
>Priority: Major
>
> JCR Registration is not compatible to Oak 1.8. We need to migrate it.
> I will provide a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337818#comment-16337818
 ] 

Konrad Windszus commented on SLING-7432:


[~rombert] Please check out the branch from 
https://github.com/apache/sling-org-apache-sling-commons-threads/compare/bugfix/SLING-7432?expand=1.
 There I added some logging (therefore please do not merge as is) and also I 
cleaned up the logic a bit where the old thread local state is being stored. 
This is now no longer internally relying on thread locals. Please check if that 
fixes the issue on your side already. If not the logging should give further 
hints on why you run into an infinite loop (hopefully).

> Thread pool clean up code can lead to infinite loops in ThreadLocal.get
> ---
>
> Key: SLING-7432
> URL: https://issues.apache.org/jira/browse/SLING-7432
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Threads 3.2.10
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: Commons Threads 3.2.14
>
>
> The thread local clean up code added in SLING-6261 leads to Threads stuck in 
> {{ThreadLocal.get}}.
> I am working on a simplified test case, but the stack trace is similar to
> {noformat}
> "pool-1-thread-1" prio=10 tid=0x7f47f4374800 nid=0xb19 runnable 
> [0x7f47e734e000]
>java.lang.Thread.State: RUNNABLE
>   at java.lang.ThreadLocal$ThreadLocalMap.set(ThreadLocal.java:429)
>   at java.lang.ThreadLocal$ThreadLocalMap.access$100(ThreadLocal.java:261)
>   at java.lang.ThreadLocal.set(ThreadLocal.java:183)
>   at 
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocalsTest$RunnableImplementation.run(ThreadPoolExecutorCleaningThreadLocalsTest.java:100)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7444) Container and Reference Pipe (others?) are missing debug or trace logs

[Nicolas Peltier (JIRA)]

Nicolas Peltier created SLING-7444:
--

 Summary: Container and Reference Pipe (others?) are missing debug 
or trace logs
 Key: SLING-7444
 URL: https://issues.apache.org/jira/browse/SLING-7444
 Project: Sling
  Issue Type: Improvement
  Components: Extensions
Affects Versions: pipes 1.1.0
Reporter: Nicolas Peltier


in case things go wrong, it's hard to see what's wrong



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7443) Actual build for standalone jar is not working with latest JDK

[frederic rougeot (JIRA)]

frederic rougeot created SLING-7443:
---

 Summary: Actual build for standalone jar is not working with 
latest JDK
 Key: SLING-7443
 URL: https://issues.apache.org/jira/browse/SLING-7443
 Project: Sling
  Issue Type: Bug
  Components: Launchpad
 Environment: Windows 10, JDK 9 or latest 1.8
Reporter: frederic rougeot


I tried to use your standalone jar with latest JDK, I mean JDK 9, or JDK 
1.8.0_162b12, but it does not work ... The following log is encountered with 
JDK 1.8.162 when launching java -jar org.apache.sling.launchpad-9.jar:

24.01.2018 15:45:34.872 *ERROR* [FelixStartLevel] ERROR: Bundle '18' Error 
starting 
slinginstall:C:\projets\Veolia\tools\sling\startup\1\slf4j-api-1.7.21.jar 
(org.osgi.framework.BundleException: Unable to resolve slf4j.api [18](R 18.0): 
missing requirement [slf4j.api [18](R 18.0)] ...

 

So I will try now with JDK 1.8.0.161 (a colleague tells me it was quite OK with 
JDK 1.8.0.77à



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7437) Support Oak 1.8 in org.apache.sling.jcr.registration

[Christian Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337676#comment-16337676
 ] 

Christian Schneider commented on SLING-7437:


I found the newest version has the packages:

org.apache.jackrabbit.rmi.remote;resolution:=optional;version="[2.0,3)",
org.apache.jackrabbit.rmi.server;resolution:=optional;version="[2.0,3)",

as an optional dependency. So the bundle resolves but I am not sure if this is 
good enough. Digging some more.

 

> Support Oak 1.8 in org.apache.sling.jcr.registration
> 
>
> Key: SLING-7437
> URL: https://issues.apache.org/jira/browse/SLING-7437
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Registration 1.0.4
>Reporter: Christian Schneider
>Priority: Major
>
> JCR Registration is not compatible to Oak 1.8. We need to migrate it.
> I will provide a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7438) Migrate pax exam test module to Oak 1.8

[Christian Schneider (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337674#comment-16337674
 ] 

Christian Schneider commented on SLING-7438:


I already provided a PR for the karaf features. See linked issue. 

As far as I understood the pax exam options are generated from the karaf 
features. How can I do this?

 

> Migrate pax exam test module to Oak 1.8
> ---
>
> Key: SLING-7438
> URL: https://issues.apache.org/jira/browse/SLING-7438
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Reporter: Christian Schneider
>Priority: Major
>
> We need to adapt the pax exam testing module to Oak 1.8. This is more than 
> just updating the version as Oak 1.8 needs a few more bundles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7442) Update karaf features to Oak 1.8.0

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337665#comment-16337665
 ] 

ASF GitHub Bot commented on SLING-7442:
---

cschneider opened a new pull request #1: SLING-7442 Update Oak to 1.8.0
URL: https://github.com/apache/sling-org-apache-sling-karaf-features/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Update karaf features to Oak 1.8.0
> --
>
> Key: SLING-7442
> URL: https://issues.apache.org/jira/browse/SLING-7442
> Project: Sling
>  Issue Type: Improvement
>  Components: Karaf
>Affects Versions: Karaf Features 0.2.0
>Reporter: Christian Schneider
>Priority: Major
> Fix For: Karaf Features 0.2.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cschneider opened a new pull request #1: SLING-7442 Update Oak to 1.8.0

[GitBox]

cschneider opened a new pull request #1: SLING-7442 Update Oak to 1.8.0
URL: https://github.com/apache/sling-org-apache-sling-karaf-features/pull/1
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (SLING-7442) Update karaf features to Oak 1.8.0

[Christian Schneider (JIRA)]

Christian Schneider created SLING-7442:
--

 Summary: Update karaf features to Oak 1.8.0
 Key: SLING-7442
 URL: https://issues.apache.org/jira/browse/SLING-7442
 Project: Sling
  Issue Type: Improvement
  Components: Karaf
Affects Versions: Karaf Features 0.2.0
Reporter: Christian Schneider
 Fix For: Karaf Features 0.2.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7435) Authorizable pipe autocreate group does not handle dryRun

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7435.

   Resolution: Fixed
Fix Version/s: pipes 2.0.0

> Authorizable pipe autocreate group does not handle dryRun
> -
>
> Key: SLING-7435
> URL: https://issues.apache.org/jira/browse/SLING-7435
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.0.0
>
>
> autocreateGroup does not handle dry Run



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7435) Authorizable pipe autocreate group does not handle dryRun

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier reassigned SLING-7435:
--

Assignee: Nicolas Peltier

> Authorizable pipe autocreate group does not handle dryRun
> -
>
> Key: SLING-7435
> URL: https://issues.apache.org/jira/browse/SLING-7435
> Project: Sling
>  Issue Type: Bug
>  Components: Extensions
>Affects Versions: pipes 2.0.0
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
>
> autocreateGroup does not handle dry Run



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7423) Support OAK 1.8 in JCR Oak Server

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz reassigned SLING-7423:
---

Assignee: Oliver Lietz

> Support OAK 1.8 in JCR Oak Server
> -
>
> Key: SLING-7423
> URL: https://issues.apache.org/jira/browse/SLING-7423
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: JCR Oak Server 1.1.4
>Reporter: Christian Schneider
>Assignee: Oliver Lietz
>Priority: Major
>
> The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API 
> was changed in an incompatible way. We should adapt to these changes. See 
> below for the changed classes.
> 1.6
> import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; 
> import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider;
> 1.7
> import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.InitialContent; -> oak-core
> import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; 
> -> oak-core
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7440) Update Jackrabbit to 2.16.0

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7440.
-
Resolution: Done

> Update Jackrabbit to 2.16.0
> ---
>
> Key: SLING-7440
> URL: https://issues.apache.org/jira/browse/SLING-7440
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Oak Server 1.1.6
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7441) Update Oak to 1.6.8

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7441.
-
Resolution: Done

> Update Oak to 1.6.8
> ---
>
> Key: SLING-7441
> URL: https://issues.apache.org/jira/browse/SLING-7441
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Oak Server 1.1.6
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7439) Update Pax Exam to 4.11

[Oliver Lietz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-7439.
-
Resolution: Done

> Update Pax Exam to 4.11
> ---
>
> Key: SLING-7439
> URL: https://issues.apache.org/jira/browse/SLING-7439
> Project: Sling
>  Issue Type: Task
>  Components: JCR
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: JCR Oak Server 1.1.6
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7441) Update Oak to 1.6.8

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7441:
---

 Summary: Update Oak to 1.6.8
 Key: SLING-7441
 URL: https://issues.apache.org/jira/browse/SLING-7441
 Project: Sling
  Issue Type: Task
  Components: JCR
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: JCR Oak Server 1.1.6






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7439) Update Pax Exam to 4.11

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7439:
---

 Summary: Update Pax Exam to 4.11
 Key: SLING-7439
 URL: https://issues.apache.org/jira/browse/SLING-7439
 Project: Sling
  Issue Type: Task
  Components: JCR
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: JCR Oak Server 1.1.6






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7440) Update Jackrabbit to 2.16.0

[Oliver Lietz (JIRA)]

Oliver Lietz created SLING-7440:
---

 Summary: Update Jackrabbit to 2.16.0
 Key: SLING-7440
 URL: https://issues.apache.org/jira/browse/SLING-7440
 Project: Sling
  Issue Type: Task
  Components: JCR
Reporter: Oliver Lietz
Assignee: Oliver Lietz
 Fix For: JCR Oak Server 1.1.6






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] cschneider opened a new pull request #1: SLING-7423 Migrate to Oak 1.8

[GitBox]

cschneider opened a new pull request #1: SLING-7423 Migrate to Oak 1.8
URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1
 
 
   For the tests I did the update to Oak 1.8 locally at first. I will also 
provide a PR for the pax exam testing bundle to reflect the change to Oak 1.8.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-7423) Support OAK 1.8 in JCR Oak Server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337428#comment-16337428
 ] 

ASF GitHub Bot commented on SLING-7423:
---

cschneider opened a new pull request #1: SLING-7423 Migrate to Oak 1.8
URL: https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/1
 
 
   For the tests I did the update to Oak 1.8 locally at first. I will also 
provide a PR for the pax exam testing bundle to reflect the change to Oak 1.8.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support OAK 1.8 in JCR Oak Server
> -
>
> Key: SLING-7423
> URL: https://issues.apache.org/jira/browse/SLING-7423
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: JCR Oak Server 1.1.4
>Reporter: Christian Schneider
>Priority: Major
>
> The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API 
> was changed in an incompatible way. We should adapt to these changes. See 
> below for the changed classes.
> 1.6
> import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; 
> import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider;
> 1.7
> import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.InitialContent; -> oak-core
> import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; 
> -> oak-core
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7432) Thread pool clean up code can lead to infinite loops in ThreadLocal.get

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337329#comment-16337329
 ] 

Konrad Windszus commented on SLING-7432:


I unfortunately don't have any reference but right after creating the thread 
(i.e. in the {{beforeExecute}} method) it already has 7 thread locals attached 
(i.e. size is 7). Some of them are integers. Don't know for what they are used 
internally.

> Thread pool clean up code can lead to infinite loops in ThreadLocal.get
> ---
>
> Key: SLING-7432
> URL: https://issues.apache.org/jira/browse/SLING-7432
> Project: Sling
>  Issue Type: Bug
>  Components: Commons
>Affects Versions: Commons Threads 3.2.10
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Blocker
> Fix For: Commons Threads 3.2.14
>
>
> The thread local clean up code added in SLING-6261 leads to Threads stuck in 
> {{ThreadLocal.get}}.
> I am working on a simplified test case, but the stack trace is similar to
> {noformat}
> "pool-1-thread-1" prio=10 tid=0x7f47f4374800 nid=0xb19 runnable 
> [0x7f47e734e000]
>java.lang.Thread.State: RUNNABLE
>   at java.lang.ThreadLocal$ThreadLocalMap.set(ThreadLocal.java:429)
>   at java.lang.ThreadLocal$ThreadLocalMap.access$100(ThreadLocal.java:261)
>   at java.lang.ThreadLocal.set(ThreadLocal.java:183)
>   at 
> org.apache.sling.commons.threads.impl.ThreadPoolExecutorCleaningThreadLocalsTest$RunnableImplementation.run(ThreadPoolExecutorCleaningThreadLocalsTest.java:100)
>   at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:262)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
>   at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7438) Migrate pax exam test module to Oak 1.8

[Christian Schneider (JIRA)]

Christian Schneider created SLING-7438:
--

 Summary: Migrate pax exam test module to Oak 1.8
 Key: SLING-7438
 URL: https://issues.apache.org/jira/browse/SLING-7438
 Project: Sling
  Issue Type: Improvement
  Components: Testing
Reporter: Christian Schneider


We need to adapt the pax exam testing module to Oak 1.8. This is more than just 
updating the version as Oak 1.8 needs a few more bundles.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7437) Support Oak 1.8 in org.apache.sling.jcr.registration

[Christian Schneider (JIRA)]

Christian Schneider created SLING-7437:
--

 Summary: Support Oak 1.8 in org.apache.sling.jcr.registration
 Key: SLING-7437
 URL: https://issues.apache.org/jira/browse/SLING-7437
 Project: Sling
  Issue Type: Improvement
Affects Versions: JCR Registration 1.0.4
Reporter: Christian Schneider


JCR Registration is not compatible to Oak 1.8. We need to migrate it.
I will provide a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7437) Support Oak 1.8 in org.apache.sling.jcr.registration

[Christian Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated SLING-7437:
---
Component/s: JCR

> Support Oak 1.8 in org.apache.sling.jcr.registration
> 
>
> Key: SLING-7437
> URL: https://issues.apache.org/jira/browse/SLING-7437
> Project: Sling
>  Issue Type: Improvement
>  Components: JCR
>Affects Versions: JCR Registration 1.0.4
>Reporter: Christian Schneider
>Priority: Major
>
> JCR Registration is not compatible to Oak 1.8. We need to migrate it.
> I will provide a PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7423) Support OAK 1.8 in JCR Oak Server

[Christian Schneider (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Schneider updated SLING-7423:
---
Summary: Support OAK 1.8 in JCR Oak Server  (was: Support OAK 1.8)

> Support OAK 1.8 in JCR Oak Server
> -
>
> Key: SLING-7423
> URL: https://issues.apache.org/jira/browse/SLING-7423
> Project: Sling
>  Issue Type: Improvement
>Affects Versions: JCR Oak Server 1.1.4
>Reporter: Christian Schneider
>Priority: Major
>
> The oak server bundle currently does not work with Oak 1.7 and 1.8 as the API 
> was changed in an incompatible way. We should adapt to these changes. See 
> below for the changed classes.
> 1.6
> import org.apache.jackrabbit.oak.plugins.index.aggregate.NodeAggregator; 
> import org.apache.jackrabbit.oak.plugins.nodetype.write.InitialContent;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexEditorProvider;
> import org.apache.jackrabbit.oak.spi.whiteboard.WhiteboardIndexProvider;
> 1.7
> import org.apache.jackrabbit.oak.spi.query.QueryIndex.NodeAggregator; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.InitialContent; -> oak-core
> import org.apache.jackrabbit.oak.spi.query.WhiteboardIndexProvider; -> 
> oak-query-spi
> import org.apache.jackrabbit.oak.plugins.index.WhiteboardIndexEditorProvider; 
> -> oak-core
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)