[jira] [Commented] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Alex Ramos (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369484#comment-16369484
 ] 

Alex Ramos commented on SLING-7501:
---

JCRVLT-197 also is a potential culprit. My projects have multiple filter roots 
as described. Unfortunately the specific symptoms are not detailed out in this 
ticket, so I can't confirm it's "the one".

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Alex Ramos (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369481#comment-16369481
 ] 

Alex Ramos commented on SLING-7501:
---

Without digging into the code and just looking at the descriptions, I think it 
might be JCRVLT-177. I also linked to JCRVLT-255 as I think the fix for that 
should be watched.

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369473#comment-16369473
 ] 

Konrad Windszus commented on SLING-7501:


[~atrsd] Can you please still point me to the JCRVLT issue which has been fixed 
in more recent releases? I could not find anything related in the release notes 
of either 3.1.40 
([https://issues.apache.org/jira/projects/JCRVLT/versions/12339160)] nor 3.1.42 
(https://issues.apache.org/jira/projects/JCRVLT/versions/12341017).

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Alex Ramos (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369472#comment-16369472
 ] 

Alex Ramos commented on SLING-7501:
---

I've tested with the latest 1.2.1-SNAPSHOT and I can confirm the issue is 
resolved. Thank you

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Minimum JCR access rights for a path-based Sling servlet

2018-02-19 Thread Konrad Windszus
Sorry for the noise, actually no right is necessary as correctly stated in the 
wiki. I had an issue with the user provisioning process.
Konrad

> On 19. Feb 2018, at 18:01, Konrad Windszus  wrote:
> 
> Although it is currently stated at 
> https://sling.apache.org/documentation/the-sling-engine/servlets.html#caveats-when-binding-servlets-by-path
>  
> 
>  that no JCR repository acls are evaluated when accessing a servlet 
> registered by path I always get back a 401 when trying to access such a 
> servlet with an unprivileged user. Is there some minimum repository right 
> being evaluated beforehand (i.e. by a servlet filter or the Sling Main 
> Servlet somehow?).
> Thanks for your input,
> Konrad
> 



Minimum JCR access rights for a path-based Sling servlet

2018-02-19 Thread Konrad Windszus
Although it is currently stated at 
https://sling.apache.org/documentation/the-sling-engine/servlets.html#caveats-when-binding-servlets-by-path
 

 that no JCR repository acls are evaluated when accessing a servlet registered 
by path I always get back a 401 when trying to access such a servlet with an 
unprivileged user. Is there some minimum repository right being evaluated 
beforehand (i.e. by a servlet filter or the Sling Main Servlet somehow?).
Thanks for your input,
Konrad



[GitHub] cziegeler commented on issue #5: Some suggested changes to the Sling Feature model requirements

2018-02-19 Thread GitBox
cziegeler commented on issue #5: Some suggested changes to the Sling Feature 
model requirements
URL: https://github.com/apache/sling-whiteboard/pull/5#issuecomment-366743471
 
 
   Thanks for the updates!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cziegeler closed pull request #5: Some suggested changes to the Sling Feature model requirements

2018-02-19 Thread GitBox
cziegeler closed pull request #5: Some suggested changes to the Sling Feature 
model requirements
URL: https://github.com/apache/sling-whiteboard/pull/5
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/featuremodel/readme.md b/featuremodel/readme.md
index eb8c6df..40fc31b 100644
--- a/featuremodel/readme.md
+++ b/featuremodel/readme.md
@@ -23,7 +23,7 @@ The feature model should meet the following requirements:
 * SFM060 - The feature model should provide support for long and multi-line 
values without creating files that become hard to handle.
 * SFM070 - A feature model must have a unique identifier.
 * SFM080 - A feature model must have a version.
-* SFM090 - A feature module must be referenceable through Apache Maven 
coordinates.
+* SFM090 - A feature model must be referenceable through Apache Maven 
coordinates.
 * SFM100 - It must be possible to specify the bundles belonging to the 
feature, including version.
 * SFM110 - It must be possible to specify the bundles in a feature in terms of 
Apache Maven coordinates.
 * SFM120 - The feature model must allow the specification of the order in 
which the bundles inside the feature are started. This should be relative to 
when the feature itself is started.
@@ -48,6 +48,8 @@ The feature model should meet the following requirements:
 * SFM310 - When features are aggregated, either to create a higher level 
feature or an application, and a bundle/artifact is encountered with different 
versions, the feature model must be capable of only using the bundle/artifact 
with the highest version number.
 * SFM320 - When features are aggregated, either to create a higher level 
feature or an application, and a bundle/artifact is encountered with different 
versions, the feature model must be capable of including both versions 
side-by-side.
 * SFM330 - When features are aggregated, either to create a higher level 
feature or an application, the resulting feature or application must be minimal 
meaning it must not contain additional or unneeded artifacts.
+* SFM340 - The feature model must support controlling of the exported API as 
described in 
https://github.com/apache/sling-whiteboard/blob/master/featuremodel/apicontroller.md
+* SFM350 - The feature model must support explicit ordering of features. It 
must be possible to provide this ordering in separate file.
 
 ## Tooling
 The following requirements relate to tooling around the Feature Model.
@@ -56,11 +58,17 @@ The following requirements relate to tooling around the 
Feature Model.
 * SFT010 - Tooling must support runtime launching with one or more features.
 * SFT020 - Tooling must be able to compute the effective requirements of a 
feature by inspecting the feature's content and combining this with 
requirements specified on the feature itself.
 * SFT030 - Tooling must be able to compute the capabilities of a feature by 
inspecting the feature's content and directly specified capabilities.
-* SFT040 - Given one or more root features, the feature model must be able to 
compute the start order of all resulting features so that dependencies of 
features are started first. Comment(CZ) : Is this tooling or feature model?
+* SFT040 - Given one or more root features, the feature model must be able to 
compute the start order of all resulting features so that dependencies of 
features are started first. 
+  * Comment(CZ) : Is this tooling or feature model?
+  * Comment(DB) : It could be either, but if there is support for explicit 
ordering of features (SFM350) then a tool could compute the ordering beforehand 
and place it in this file.
 * SFT050 - Tooling must be able to find all features that provide the 
capabilities required by a given feature, from a set of available features.
 * SFT060 - It should be possible to dynamically install and uninstall features 
at runtime.
-* SFT070 - The feature model must support variable substitution for its values 
at runtime. Comment(CZ) : What exactly does this mean? Substitution of what?
-* SFT080 - The feature model should allow the arbitrary text files to be 
written to the file system, to support configuration of components that use 
file-based configuration such as properties or XML files, such as web.xml. 
Comment(CZ) : Not sure what this actually means, how does web.xml play a role 
here?
+* SFT070 - The feature model must support variable substitution for its values 
at runtime. 
+  * Comment(CZ) : What exactly does this mean? Substitution of what?
+  * Comment(DB) : Like configuration values or bundle versions. Meaning that 
you can write something like ${db.user} instead of having to hardcode the user 
in the feature file. 
+* SFT080 - The feature model should allow the arbitrary text files to be 
written to the file system, to 

[jira] [Resolved] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread Carsten Ziegeler (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-7496.
-
Resolution: Fixed

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369285#comment-16369285
 ] 

Carsten Ziegeler commented on SLING-7496:
-

Thanks for the updated patches, [~bosschaert]

I added a minor tweak to your patch.

All tests pass now

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369279#comment-16369279
 ] 

ASF GitHub Bot commented on SLING-7496:
---

cziegeler closed pull request #1: SLING-7496 - Fix two failures in 
ConfigInstallTest
URL: https://github.com/apache/sling-org-apache-sling-installer-it/pull/1
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/src/test/java/org/apache/sling/installer/it/ConfigInstallTest.java 
b/src/test/java/org/apache/sling/installer/it/ConfigInstallTest.java
index 6a56db0..f27c16f 100644
--- a/src/test/java/org/apache/sling/installer/it/ConfigInstallTest.java
+++ b/src/test/java/org/apache/sling/installer/it/ConfigInstallTest.java
@@ -16,10 +16,6 @@
  */
 package org.apache.sling.installer.it;
 
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
-
 import java.util.ArrayList;
 import java.util.Dictionary;
 import java.util.Hashtable;
@@ -48,6 +44,10 @@
 import org.osgi.util.tracker.ServiceTracker;
 import org.osgi.util.tracker.ServiceTrackerCustomizer;
 
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+
 @RunWith(PaxExam.class)
 
 public class ConfigInstallTest extends OsgiInstallerTestBase implements 
ConfigurationListener {
@@ -359,6 +359,8 @@ public void testInstallUpdateRemoveConfigFactory() throws 
Exception {
 null, cfgData, null, InstallableResource.TYPE_PROPERTIES, 10);
 installer.updateResources(URL_SCHEME, new InstallableResource[] 
{rsrc}, null);
 
+waitForResource(URL_SCHEME + ":/configA/" + cfgFactoryPid + "-" + 
alias, ResourceState.INSTALLED);
+
 // get factory config
 final Configuration cfg = waitForFactoryConfigValue("After 
installing", cfgFactoryPid, "foo", "bar");
 
@@ -392,6 +394,8 @@ public void testInstallUpdateRemoveTemplateConfigFactory() 
throws Exception {
 null, cfgData, null, InstallableResource.TYPE_PROPERTIES, 10);
 installer.updateResources(URL_SCHEME, new InstallableResource[] 
{rsrc}, null);
 
+waitForResource(URL_SCHEME + ":/configA/" + cfgFactoryPid + "-" + 
alias, ResourceState.INSTALLED);
+
 // get factory config
 final Configuration cfg = waitForFactoryConfigValue("After 
installing", cfgFactoryPid, "foo", "bar");
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369277#comment-16369277
 ] 

ASF GitHub Bot commented on SLING-7496:
---

cziegeler closed pull request #2: SLING-7496 Factory config deleted with 
ConfigAdmin immediately after creation
URL: 
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/main/java/org/apache/sling/installer/factories/configuration/impl/AbstractConfigTask.java
 
b/src/main/java/org/apache/sling/installer/factories/configuration/impl/AbstractConfigTask.java
index c5f4d1d..a1d628a 100644
--- 
a/src/main/java/org/apache/sling/installer/factories/configuration/impl/AbstractConfigTask.java
+++ 
b/src/main/java/org/apache/sling/installer/factories/configuration/impl/AbstractConfigTask.java
@@ -80,7 +80,12 @@ protected String getCompositeAliasPid() {
 if ( this.aliasPid == null || this.factoryPid == null ) {
 return null;
 }
-final String alias = factoryPid + "." + this.aliasPid;
+final String alias;
+if (this.aliasPid.startsWith(this.factoryPid)) {
+alias = this.aliasPid;
+} else {
+alias = this.factoryPid + "." + this.aliasPid;
+}
 final int pos = this.getResource().getEntityId().indexOf(':');
 if ( this.getResource().getEntityId().substring(pos + 1).equals(alias) 
) {
 return null;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] cziegeler closed pull request #2: SLING-7496 Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread GitBox
cziegeler closed pull request #2: SLING-7496 Factory config deleted with 
ConfigAdmin immediately after creation
URL: 
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/2
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/src/main/java/org/apache/sling/installer/factories/configuration/impl/AbstractConfigTask.java
 
b/src/main/java/org/apache/sling/installer/factories/configuration/impl/AbstractConfigTask.java
index c5f4d1d..a1d628a 100644
--- 
a/src/main/java/org/apache/sling/installer/factories/configuration/impl/AbstractConfigTask.java
+++ 
b/src/main/java/org/apache/sling/installer/factories/configuration/impl/AbstractConfigTask.java
@@ -80,7 +80,12 @@ protected String getCompositeAliasPid() {
 if ( this.aliasPid == null || this.factoryPid == null ) {
 return null;
 }
-final String alias = factoryPid + "." + this.aliasPid;
+final String alias;
+if (this.aliasPid.startsWith(this.factoryPid)) {
+alias = this.aliasPid;
+} else {
+alias = this.factoryPid + "." + this.aliasPid;
+}
 final int pos = this.getResource().getEntityId().indexOf(':');
 if ( this.getResource().getEntityId().substring(pos + 1).equals(alias) 
) {
 return null;


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (SLING-7506) org.apache.sling.scripting.jsp.taglib: update esapi dependency

2018-02-19 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-7506:
--
Description: 
To 

  https://mvnrepository.com/artifact/org.owasp.esapi/esapi/2.1.0.1

due to the current transitive dep on

  https://mvnrepository.com/artifact/org.owasp.antisamy/antisamy/1.4.3

which has several CVEs reported against..



> org.apache.sling.scripting.jsp.taglib: update esapi dependency
> --
>
> Key: SLING-7506
> URL: https://issues.apache.org/jira/browse/SLING-7506
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Julian Reschke
>Priority: Major
>
> To 
>   https://mvnrepository.com/artifact/org.owasp.esapi/esapi/2.1.0.1
> due to the current transitive dep on
>   https://mvnrepository.com/artifact/org.owasp.antisamy/antisamy/1.4.3
> which has several CVEs reported against..



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7506) org.apache.sling.scripting.jsp.taglib: update esapi dependency

2018-02-19 Thread Julian Reschke (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated SLING-7506:
--
Component/s: Scripting

> org.apache.sling.scripting.jsp.taglib: update esapi dependency
> --
>
> Key: SLING-7506
> URL: https://issues.apache.org/jira/browse/SLING-7506
> Project: Sling
>  Issue Type: Task
>  Components: Scripting
>Reporter: Julian Reschke
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-7506) org.apache.sling.scripting.jsp.taglib: update esapi dependency

2018-02-19 Thread Julian Reschke (JIRA)
Julian Reschke created SLING-7506:
-

 Summary: org.apache.sling.scripting.jsp.taglib: update esapi 
dependency
 Key: SLING-7506
 URL: https://issues.apache.org/jira/browse/SLING-7506
 Project: Sling
  Issue Type: Task
Reporter: Julian Reschke






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369155#comment-16369155
 ] 

Carsten Ziegeler edited comment on SLING-7496 at 2/19/18 4:02 PM:
--

[~bosschaert] I just looked at what 
ConfigInstallTest#testInstallUpdateRemoveConfigFactory does. As the name says 
it installs a configuration through the installer, updates the config through 
CM and then removes the config through CM.

Now the desired states are:
 * config installed through installer. state = INSTALLED
 * config updated through CM - manual intervention detected, state = IGNORED
 * config removed through CM - manual intervention detected, reverting to the 
config known to the installer, state = INSTALLED

The state needs to switch from INSTALLED to IGNORED when a configuration 
installed through the installer is manually changed. So I think that test case 
is correct


was (Author: cziegeler):
[~bosschaert] I just looked at what 
ConfigInstallTest#testInstallUpdateRemoveConfigFactory does. As the name says 
it installs a configuration through the installer, updates the config through 
CM and then removes the config through CM.

Now the desired states are:
 * config installed through installer. state = INSTALLED
 * config updated through CM - manual intervention detected, state = IGNORED
 * config removed through CM - manual intervention detected, state = IGNORED

The state needs to switch from INSTALLED to IGNORED when a configuration 
installed through the installer is manually changed. So I think that test case 
is correct

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread David Bosschaert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369245#comment-16369245
 ] 

David Bosschaert commented on SLING-7496:
-

Thanks for the feedback [~cziegeler] - I guess in that case the change in 
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/1
 was incorrect. Maybe the best thing to do would be to back it out for the 
moment?

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369155#comment-16369155
 ] 

Carsten Ziegeler edited comment on SLING-7496 at 2/19/18 3:40 PM:
--

[~bosschaert] I just looked at what 
ConfigInstallTest#testInstallUpdateRemoveConfigFactory does. As the name says 
it installs a configuration through the installer, updates the config through 
CM and then removes the config through CM.

Now the desired states are:
 * config installed through installer. state = INSTALLED
 * config updated through CM - manual intervention detected, state = IGNORED
 * config removed through CM - manual intervention detected, state = IGNORED

The state needs to switch from INSTALLED to IGNORED when a configuration 
installed through the installer is manually changed. So I think that test case 
is correct


was (Author: cziegeler):
[~bosschaert] I just looked at what 
ConfigInstallTest#testInstallUpdateRemoveConfigFactory does. As the name says 
it installs a configuration through the installer, updates the config through 
CM and then removes the config through CM.

Now the desired states are:
 * config installed through installer. state = INSTALLED
 * config updated through CM - manual intervention detected, state = IGNORED
 * config removed through CM - manual intervention detected, state = IGNORED

The state needs to switch from INSTALLED to IGNORED when a configuration 
installed through the installer is manually changed. Now the key word hey is 
"changed", the test is actually not changing the configuration just pushing the 
same set of properties again. In that case, yes, the state should stay in 
INSTALLED. Could you please enhance the test, that it actually changes the 
config afterwards and verifies that the state then is IGNORED?

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] bosschaert opened a new pull request #5: Some suggested changes to the Sling Feature model requirements

2018-02-19 Thread GitBox
bosschaert opened a new pull request #5: Some suggested changes to the Sling 
Feature model requirements
URL: https://github.com/apache/sling-whiteboard/pull/5
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Comment Edited] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369155#comment-16369155
 ] 

Carsten Ziegeler edited comment on SLING-7496 at 2/19/18 2:19 PM:
--

[~bosschaert] I just looked at what 
ConfigInstallTest#testInstallUpdateRemoveConfigFactory does. As the name says 
it installs a configuration through the installer, updates the config through 
CM and then removes the config through CM.

Now the desired states are:
 * config installed through installer. state = INSTALLED
 * config updated through CM - manual intervention detected, state = IGNORED
 * config removed through CM - manual intervention detected, state = IGNORED

The state needs to switch from INSTALLED to IGNORED when a configuration 
installed through the installer is manually changed. Now the key word hey is 
"changed", the test is actually not changing the configuration just pushing the 
same set of properties again. In that case, yes, the state should stay in 
INSTALLED. Could you please enhance the test, that it actually changes the 
config afterwards and verifies that the state then is IGNORED?


was (Author: cziegeler):
[~bosschaert] I just looked at what 
ConfigInstallTest#testInstallUpdateRemoveConfigFactory does. As the name says 
it installs a configuration through the installer, updates the config through 
CM and then removes the config through CM.

Now the desired states are:
 * config installed through installer. state = INSTALLED
 * config updated through CM - manual intervention detected, state = IGNORED
 * config removed through CM - manual intervention detected, state = IGNORED

So I think the test is actually correct and the state needs to switch from 
INSTALLED to IGNORED when a configuration installed through the installer is 
manually changed

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369155#comment-16369155
 ] 

Carsten Ziegeler commented on SLING-7496:
-

[~bosschaert] I just looked at what 
ConfigInstallTest#testInstallUpdateRemoveConfigFactory does. As the name says 
it installs a configuration through the installer, updates the config through 
CM and then removes the config through CM.

Now the desired states are:
 * config installed through installer. state = INSTALLED
 * config updated through CM - manual intervention detected, state = IGNORED
 * config removed through CM - manual intervention detected, state = IGNORED

So I think the test is actually correct and the state needs to switch from 
INSTALLED to IGNORED when a configuration installed through the installer is 
manually changed

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: wiki access

2018-02-19 Thread Robert Munteanu
On Fri, 2018-02-16 at 13:26 -0500, Jason E Bailey wrote:
> https://cwiki.apache.org/confluence/display/INFRA/Managing+permission
> s+on+your+project%27s+Confluence+Space
> 
> Referenced back to Admins for the Sling wiki.

I've granted your user permissions on the wiki. Guess I've learned
something new today :-)

Robert


[jira] [Commented] (SLING-5517) Support of startsWith in exclude path of Content Disposition filter

2018-02-19 Thread Alexander Muthmann (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-5517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369109#comment-16369109
 ] 

Alexander Muthmann commented on SLING-5517:
---

We currently have the use-case that we need to serve several svg files 
(image/svg+xml) from a unknown path.

With the current implementation, we don't have any chance to enable the Sling 
Content Disposition Filter as it catches all requests and the svg is not 
displayed but downloaded. 

> Support of startsWith in exclude path of Content Disposition filter
> ---
>
> Key: SLING-5517
> URL: https://issues.apache.org/jira/browse/SLING-5517
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Reporter: Mandeep Gandhi
>Priority: Major
> Fix For: Security 1.0.18
>
>
> Right now exclude path parameter of config of Content Disposition filter 
> takes   specific paths into account. 
> To excluded everything under a give path, an enhancement is required.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread David Bosschaert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369105#comment-16369105
 ] 

David Bosschaert commented on SLING-7496:
-

Hi [~cziegeler] I could be wrong but this is I think the thing that we aimed to 
fix in this issue in the first place. Originally, because of a mismatch in pids 
(that had a double factory pid prefixed) when a configuration was created, it 
was deleted immediately, causing the configuration resource to be assigned the 
IGNORED state. Since that delete is now not happening any more at the initial 
state, the resource stays in the INSTALLED state which seems correct... 

Again, I could be wrong, but this is how I understand it :)

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369102#comment-16369102
 ] 

Robert Munteanu commented on SLING-7501:


[~kwin] - those regressions don't look like they will affect us. But I won't 
release immediately the IDE tooling so we should be able to incorporate 3.1.44 
for this release.

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369100#comment-16369100
 ] 

Konrad Windszus commented on SLING-7501:


Actually 3.1.42 suffers from some other regressions 
(https://www.mail-archive.com/dev@jackrabbit.apache.org/msg40591.html), 
therefore I would suggest we wait for 3.1.44 which should be available soon 
(tm, see https://www.mail-archive.com/dev@jackrabbit.apache.org/msg40607.html).

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread Carsten Ziegeler (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369099#comment-16369099
 ] 

Carsten Ziegeler commented on SLING-7496:
-

[~bosschaert] Why does the test case needs that change?

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread David Bosschaert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369093#comment-16369093
 ] 

David Bosschaert commented on SLING-7496:
-

I created 2 pull requests to address the issue:

https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/2
https://github.com/apache/sling-org-apache-sling-installer-it/pull/1

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] bosschaert opened a new pull request #1: Fix two failures in ConfigInstallTest

2018-02-19 Thread GitBox
bosschaert opened a new pull request #1: Fix two failures in ConfigInstallTest
URL: https://github.com/apache/sling-org-apache-sling-installer-it/pull/1
 
 
   The configurations should not be IGNORED but rather be INSTALLED.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369082#comment-16369082
 ] 

ASF GitHub Bot commented on SLING-7496:
---

bosschaert opened a new pull request #2: SLING-7496 Factory config deleted with 
ConfigAdmin immediately after creation
URL: 
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/2
 
 
   The PID alias should not have the factory pid prefix twice. This fix is
   needed to address the
   ConfigInstallTest.testInstallUpdateRemoveTemplateConfigFactory() failure
   that was introduced with the previous commit for SLING-7496


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] bosschaert opened a new pull request #2: SLING-7496 Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread GitBox
bosschaert opened a new pull request #2: SLING-7496 Factory config deleted with 
ConfigAdmin immediately after creation
URL: 
https://github.com/apache/sling-org-apache-sling-installer-factory-configuration/pull/2
 
 
   The PID alias should not have the factory pid prefix twice. This fix is
   needed to address the
   ConfigInstallTest.testInstallUpdateRemoveTemplateConfigFactory() failure
   that was introduced with the previous commit for SLING-7496


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (SLING-7496) Factory config deleted with ConfigAdmin immediately after creation

2018-02-19 Thread David Bosschaert (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369000#comment-16369000
 ] 

David Bosschaert commented on SLING-7496:
-

Looking at this issue now...

> Factory config deleted with ConfigAdmin immediately after creation
> --
>
> Key: SLING-7496
> URL: https://issues.apache.org/jira/browse/SLING-7496
> Project: Sling
>  Issue Type: Bug
>  Components: Installer
>Affects Versions: Installer Configuration Factory 1.1.2
>Reporter: David Bosschaert
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Installer Configuration Factory 1.2.0
>
>
> In some cases when a factory configuration is created using the OSGi 
> ConfigAdmin API, the configuration gets a call to {{delete()}} immediately 
> when {{update()}} on the configuration is called.
>  
> The issue comes down to the fact that the factory prefix is prepended twice 
> to the configuration at some point in the installer, which is then assigned 
> to the resource {{entityId}}. This mismatch causes the initial configuration 
> to receive a delete callback as the system thinks it's no longer there.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368925#comment-16368925
 ] 

Konrad Windszus edited comment on SLING-7501 at 2/19/18 9:34 AM:
-

Can we please link the according JCRVLT Jira issue of this bug?


was (Author: kwin):
Can we please link the according JCRVLT issue of this bug?

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368925#comment-16368925
 ] 

Konrad Windszus commented on SLING-7501:


Can we please link the according JCRVLT issue of this bug?

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-7501:
--

Assignee: Robert Munteanu

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Assignee: Robert Munteanu
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7501:
---
Fix Version/s: Sling Eclipse IDE 1.2.2

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7501) FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."

2018-02-19 Thread Robert Munteanu (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7501:
---
Affects Version/s: (was: Maven Sling Plugin 2.3.4)
   Sling Eclipse IDE 1.2.0

> FilveVault 3.1.38 breaks the Sling IDE Tools "Import from server..."
> 
>
> Key: SLING-7501
> URL: https://issues.apache.org/jira/browse/SLING-7501
> Project: Sling
>  Issue Type: Bug
>  Components: IDE, Tooling
>Affects Versions: Sling Eclipse IDE 1.2.0
> Environment: All
>Reporter: Alex Ramos
>Priority: Critical
> Fix For: Sling Eclipse IDE 1.2.2
>
>
> Apache Jackrabbit FileVault tool is responsible for Synchronizing files in 
> the File System with content in the JCR repository. Sadly, FileVault version 
> 3.1.38 has a bug that serializes .content.xml file (-the one that contains 
> the node properties-) almost empty.
> Since *AEM plugin for Eclipse* uses Sling-Ide-Tooling internally ([AEM 
> Developer Tools for 
> Eclipse|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fhelpx.adobe.com%2Fexperience-manager%2F6-3%2Fsites%2Fdeveloping%2Fusing%2Faem-eclipse.html]
>  ), and *Sling-Ide-tooling*uses Apache Jackrabbit FileVault tool behind the 
> scenes ([sling-ide-tooling/impl-vlt/src/org/apache/sling/ide at master -  
> apache/sling-ide-tooling -  
> GitHub|https://forums.adobe.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2Fapache%2Fsling-ide-tooling%2Ftree%2Fmaster%2Fimpl-vlt%2Fsrc%2Forg%2Fapache%2Fsling%2Fide]
>  ), we end up having that same issue (-almost empty .content.xml files-) when 
> using AEM plugin for Eclipse.
> This issue is also discussed here: 
> [https://forums.adobe.com/message/10181131#10181131]
> Upgrading to FileVault 3.1.42 (latest) is recommended.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter

2018-02-19 Thread Konrad Windszus (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368874#comment-16368874
 ] 

Konrad Windszus commented on SLING-7504:


That change is easy to do, but the slingstart-maven-plugin will not create the 
according folder by default. Any pointer where that is done in the code already 
for {{sling/installer}} would be helpful.

> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 11
>
>
> Even in the newest Starter 11 the framework property for the Sling File 
> Installer is not set by default. This should be fixed. The relevant framework 
> property is {{sling.fileinstall.dir}}. I propose to set this to 
> {{${sling.home}/install}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7504) Sling File Installer Provider inactive in Sling Starter

2018-02-19 Thread Konrad Windszus (JIRA)

 [ 
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-7504:
---
Description: Even in the newest Starter 11 the framework property for the 
Sling File Installer is not set by default. This should be fixed. The relevant 
framework property is {{sling.fileinstall.dir}}. I propose to set this to 
{{${sling.home}/install}}  (was: Even in the newest Starter 11 the framework 
property for the Sling File Installer is not set by default. This should be 
fixed. The relevant framework property is {{sling.fileinstall.dir}}. I propose 
to set this to {{${sling.launchpad}/install}})

> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 11
>
>
> Even in the newest Starter 11 the framework property for the Sling File 
> Installer is not set by default. This should be fixed. The relevant framework 
> property is {{sling.fileinstall.dir}}. I propose to set this to 
> {{${sling.home}/install}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-7504) Sling File Installer Provider inactive in Sling Starter

2018-02-19 Thread Robert Munteanu (JIRA)

[ 
https://issues.apache.org/jira/browse/SLING-7504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368872#comment-16368872
 ] 

Robert Munteanu commented on SLING-7504:


+1

> Sling File Installer Provider inactive in Sling Starter
> ---
>
> Key: SLING-7504
> URL: https://issues.apache.org/jira/browse/SLING-7504
> Project: Sling
>  Issue Type: Improvement
>  Components: Launchpad
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: Starter 11
>
>
> Even in the newest Starter 11 the framework property for the Sling File 
> Installer is not set by default. This should be fixed. The relevant framework 
> property is {{sling.fileinstall.dir}}. I propose to set this to 
> {{${sling.launchpad}/install}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[RESULT] [VOTE] Release Apache Sling Installer version 3.8.12

2018-02-19 Thread Robert Munteanu
Hi,

The vote has passed with the following result :

+1 (binding): Stefan Seifert, Carsten Ziegeler, Daniel Klco

I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.

Thanks all for voting.

Robert