[jira] [Commented] (SLING-7624) Add OSGi7 component property annotations for Servlet and Filter

[Carsten Ziegeler (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16475295#comment-16475295
 ] 

Carsten Ziegeler commented on SLING-7624:
-

I think SlingServletPath is totally fine - and using this annotation does not 
register it as a servlet, you still need the @Component annotation (and maybe 
specify the service attribute). The annotation really just sets (or gets in an 
implementation) that value

> Add OSGi7 component property annotations for Servlet and Filter
> ---
>
> Key: SLING-7624
> URL: https://issues.apache.org/jira/browse/SLING-7624
> Project: Sling
>  Issue Type: New Feature
>  Components: Servlets
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Previously there were annotations hosted at Felix for Sling Servlets/Filters 
> as custom Felix SCR annotations 
> (https://github.com/apache/felix/tree/trunk/tools/org.apache.felix.scr.annotations/src/main/java/org/apache/felix/scr/annotations/sling).
>  With OSGi R7 and DS 1.4 component property annotations are specified. Sling 
> should provide those annotations in a dedicated new artifact. Compare also 
> with FELIX-5396.
> Those are supported in the upcoming bnd 4.0 
> (https://github.com/bndtools/bnd/issues/2163).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474743#comment-16474743
 ] 

Robert Munteanu commented on SLING-7666:


Thanks for the patch [~igurjar]. I haven't reviewed it yet, but would you 
consider attaching a proper git patch or creating a pull request? This way we 
can properly credit if your your contribution. If not, I will be happy to 
review the patch as-is

> Update sling site documentation for bundle - sling-eventing-and-job-handling
> 
>
> Key: SLING-7666
> URL: https://issues.apache.org/jira/browse/SLING-7666
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: indra kumar gurjar
>Priority: Minor
> Attachments: site.patch
>
>
> The sling sling-eventing-and-job-handling bundle documentation doesn't 
> include information of  "JobExecutor" , it describes only "JobConsumer".
> If consumer needs more features like providing progress information or adding 
> more information of the processing, JobExecutor should be implemented. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [sling-org-apache-sling-commons-html] branch master updated: Activate testing.log for Pax tests

[Oliver Lietz]

On Wednesday 09 May 2018 09:40:28 bdelacre...@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
> 
> bdelacretaz pushed a commit to branch master
> in repository
> https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-html.git
> 
> 
> The following commit(s) were added to refs/heads/master by this push:
>  new e9ffa3b  Activate testing.log for Pax tests
> e9ffa3b is described below
> 
> commit e9ffa3b09a170492258a8513ac0caaac8432caba
> Author: Bertrand Delacretaz 
> AuthorDate: Wed May 9 11:40:00 2018 +0200
> 
> Activate testing.log for Pax tests
> ---
>  .../sling/commons/html/it/HtmlTestSupport.java | 15 ++-
>  src/test/resources/exam.properties | 19 ++
>  src/test/resources/logback.xml | 30
> ++ 3 files changed, 63 insertions(+), 1 deletion(-)
> 
> diff --git
> a/src/test/java/org/apache/sling/commons/html/it/HtmlTestSupport.java
> b/src/test/java/org/apache/sling/commons/html/it/HtmlTestSupport.java index
> 767848f..b1d5b51 100644
> --- a/src/test/java/org/apache/sling/commons/html/it/HtmlTestSupport.java
> +++ b/src/test/java/org/apache/sling/commons/html/it/HtmlTestSupport.java
> @@ -26,6 +26,8 @@ import static
> org.apache.sling.testing.paxexam.SlingVersionResolver.SLING_GROUP_ import
> static org.ops4j.pax.exam.CoreOptions.composite;
>  import static org.ops4j.pax.exam.CoreOptions.junitBundles;
>  import static org.ops4j.pax.exam.CoreOptions.mavenBundle;
> +import static org.ops4j.pax.exam.CoreOptions.systemProperty;
> +import org.ops4j.pax.exam.util.PathUtils;
> 
>  public abstract class HtmlTestSupport extends TestSupport {
> 
> @@ -39,8 +41,19 @@ public abstract class HtmlTestSupport extends TestSupport
> { // testing
> 
> mavenBundle().groupId("org.apache.servicemix.bundles").artifactId("org.apac
> he.servicemix.bundles.hamcrest").versionAsInProject(),
> mavenBundle().groupId("org.apache.commons").artifactId("commons-lang3").ver
> sionAsInProject(), -junitBundles()
> +junitBundles(),
> +logging()
>  );
>  }
> 
> +protected Option logging() {
> +final String filename =
> String.format("file:%s/src/test/resources/logback.xml",
> PathUtils.getBaseDir()); +return composite(
> +systemProperty("logback.configurationFile").value(filename),
> +   
> mavenBundle().groupId("org.slf4j").artifactId("slf4j-api").version("1.7.21"
> ), +   
> mavenBundle().groupId("org.slf4j").artifactId("jcl-over-slf4j").version("1.
> 7.21"), +   
> mavenBundle().groupId("ch.qos.logback").artifactId("logback-core").version(
> "1.1.7"), +   
> mavenBundle().groupId("ch.qos.logback").artifactId("logback-classic").versi
> on("1.1.7") +);
> +}
>  }

Usually the log output in target/failsafe-reports/*-output.txt is sufficient, 
but in case you really want to tune output and use Logback there is 
SlingOptions#logback().

Regards,
O.

> diff --git a/src/test/resources/exam.properties
> b/src/test/resources/exam.properties new file mode 100644
> index 000..c98a668
> --- /dev/null
> +++ b/src/test/resources/exam.properties
> @@ -0,0 +1,19 @@
> +#
> +#  Licensed to the Apache Software Foundation (ASF) under one
> +#  or more contributor license agreements.  See the NOTICE file
> +#  distributed with this work for additional information
> +#  regarding copyright ownership.  The ASF licenses this file
> +#  to you under the Apache License, Version 2.0 (the
> +#  "License"); you may not use this file except in compliance
> +#  with the License.  You may obtain a copy of the License at
> +#
> +#   http://www.apache.org/licenses/LICENSE-2.0
> +#
> +#  Unless required by applicable law or agreed to in writing,
> +#  software distributed under the License is distributed on an
> +#  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> +#  KIND, either express or implied.  See the License for the
> +#  specific language governing permissions and limitations
> +#  under the License.
> +#
> +pax.exam.logging=none
> diff --git a/src/test/resources/logback.xml b/src/test/resources/logback.xml
> new file mode 100644
> index 000..d46a4ae
> --- /dev/null
> +++ b/src/test/resources/logback.xml
> @@ -0,0 +1,30 @@
> +
> +
> +
> +  
> +target/testing.log
> +
> +  %date %level [%thread] %logger{10} [%file : %line]
> %msg%n +
> +  
> +  
> +
> +  
> +

Re: [RESULT] [VOTE] Release Apache Sling Servlet Helpers 1.1.6

[Jason E Bailey]

raising for attention

- Jason

> Can a PMC member please copy this release to the Sling dist directory.
> 
> Thanks
> --
> Jason

[jira] [Commented] (SLING-7159) Java9: Upgrade Jackrabbit Dependencies to make Commons Testing compatible with Java9

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474358#comment-16474358
 ] 

Konrad Windszus commented on SLING-7159:


As Commons Testing is supposed to be deprecated (SLING-7166) I will close this 
as Won't fix.

> Java9: Upgrade Jackrabbit Dependencies to make Commons Testing compatible 
> with Java9
> 
>
> Key: SLING-7159
> URL: https://issues.apache.org/jira/browse/SLING-7159
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Commons Testing 2.1.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Commons Testing 2.1.4
>
>
> Currently when deriving tests from {{RepositoryTestBase}} and running them 
> with Java9 you see an error like 
> {code}
> java.lang.IllegalArgumentException: javax.jcr.RepositoryFactory is not an 
> ImageIO SPI class
>   at 
> java.desktop/javax.imageio.spi.ServiceRegistry.checkClassAllowed(ServiceRegistry.java:745)
>   at 
> java.desktop/javax.imageio.spi.ServiceRegistry.lookupProviders(ServiceRegistry.java:230)
>   at 
> org.apache.jackrabbit.commons.JcrUtils.getRepository(JcrUtils.java:170)
>   at 
> org.apache.jackrabbit.commons.JcrUtils.getRepository(JcrUtils.java:244)
>   at 
> org.apache.sling.commons.testing.jcr.RepositoryUtil.startRepository(RepositoryUtil.java:107)
>   at 
> org.apache.sling.commons.testing.jcr.RepositoryProvider.getRepository(RepositoryProvider.java:68)
>   at 
> org.apache.sling.commons.testing.jcr.RepositoryTestBase.getRepository(RepositoryTestBase.java:67)
>   at 
> org.apache.sling.commons.testing.jcr.RepositoryTestBase.getSession(RepositoryTestBase.java:50)
> ...
> {code}
> This is due to the issue described in JCR-4179. Therefore the jackrabbit 
> dependencies should be upgraded to at least 2.14.3.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7159) Java9: Upgrade Jackrabbit Dependencies to make Commons Testing compatible with Java9

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus resolved SLING-7159.

Resolution: Won't Fix

> Java9: Upgrade Jackrabbit Dependencies to make Commons Testing compatible 
> with Java9
> 
>
> Key: SLING-7159
> URL: https://issues.apache.org/jira/browse/SLING-7159
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Commons Testing 2.1.2
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Commons Testing 2.1.4
>
>
> Currently when deriving tests from {{RepositoryTestBase}} and running them 
> with Java9 you see an error like 
> {code}
> java.lang.IllegalArgumentException: javax.jcr.RepositoryFactory is not an 
> ImageIO SPI class
>   at 
> java.desktop/javax.imageio.spi.ServiceRegistry.checkClassAllowed(ServiceRegistry.java:745)
>   at 
> java.desktop/javax.imageio.spi.ServiceRegistry.lookupProviders(ServiceRegistry.java:230)
>   at 
> org.apache.jackrabbit.commons.JcrUtils.getRepository(JcrUtils.java:170)
>   at 
> org.apache.jackrabbit.commons.JcrUtils.getRepository(JcrUtils.java:244)
>   at 
> org.apache.sling.commons.testing.jcr.RepositoryUtil.startRepository(RepositoryUtil.java:107)
>   at 
> org.apache.sling.commons.testing.jcr.RepositoryProvider.getRepository(RepositoryProvider.java:68)
>   at 
> org.apache.sling.commons.testing.jcr.RepositoryTestBase.getRepository(RepositoryTestBase.java:67)
>   at 
> org.apache.sling.commons.testing.jcr.RepositoryTestBase.getSession(RepositoryTestBase.java:50)
> ...
> {code}
> This is due to the issue described in JCR-4179. Therefore the jackrabbit 
> dependencies should be upgraded to at least 2.14.3.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7624) Add OSGi7 component property annotations for Servlet and Filter

[Konrad Windszus (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474356#comment-16474356
 ] 

Konrad Windszus commented on SLING-7624:


I am trying to extract the prefix to a dedicated single element annotation. 
That would also make it possible to convert {{SlingServletByPath}} to a single 
element annotation. The problem is the class name as we need to generate a 
property called {{sling.servlet.path}}. Therefore we could either name that 
annotation
# {{SlingServletPath}} (not a very nice name, imho, as this doesn't really tell 
that this actually registers this component as Sling servlet) or 
# {{ServletPath}} with {{PREFIX_= "sling."}} or
# {{Path}} with {{PREFIX_= "sling.servlet"}}
None of those options are particularly appealing to me.
[~cziegeler] WDYT?

> Add OSGi7 component property annotations for Servlet and Filter
> ---
>
> Key: SLING-7624
> URL: https://issues.apache.org/jira/browse/SLING-7624
> Project: Sling
>  Issue Type: New Feature
>  Components: Servlets
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Previously there were annotations hosted at Felix for Sling Servlets/Filters 
> as custom Felix SCR annotations 
> (https://github.com/apache/felix/tree/trunk/tools/org.apache.felix.scr.annotations/src/main/java/org/apache/felix/scr/annotations/sling).
>  With OSGi R7 and DS 1.4 component property annotations are specified. Sling 
> should provide those annotations in a dedicated new artifact. Compare also 
> with FELIX-5396.
> Those are supported in the upcoming bnd 4.0 
> (https://github.com/bndtools/bnd/issues/2163).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[indra kumar gurjar (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474309#comment-16474309
 ] 

indra kumar gurjar edited comment on SLING-7666 at 5/14/18 2:58 PM:


[^site.patch] Contains proposed improvements in documentation.

cc [~lnra54] 


was (Author: igurjar):
[^site.patch] Contains proposed improvements in documentation.

 

cc [~lnra54] 

> Update sling site documentation for bundle - sling-eventing-and-job-handling
> 
>
> Key: SLING-7666
> URL: https://issues.apache.org/jira/browse/SLING-7666
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: indra kumar gurjar
>Priority: Minor
> Attachments: site.patch
>
>
> The sling sling-eventing-and-job-handling bundle documentation doesn't 
> include information of  "JobExecutor" , it describes only "JobConsumer".
> If consumer needs more features like providing progress information or adding 
> more information of the processing, JobExecutor should be implemented. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[indra kumar gurjar (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474309#comment-16474309
 ] 

indra kumar gurjar edited comment on SLING-7666 at 5/14/18 2:58 PM:


[^site.patch] Contains proposed improvements in documentation.

 

cc [~lnra54] 


was (Author: igurjar):
[^site.patch] Contains proposed improvements in documentation.

> Update sling site documentation for bundle - sling-eventing-and-job-handling
> 
>
> Key: SLING-7666
> URL: https://issues.apache.org/jira/browse/SLING-7666
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: indra kumar gurjar
>Priority: Minor
> Attachments: site.patch
>
>
> The sling sling-eventing-and-job-handling bundle documentation doesn't 
> include information of  "JobExecutor" , it describes only "JobConsumer".
> If consumer needs more features like providing progress information or adding 
> more information of the processing, JobExecutor should be implemented. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[indra kumar gurjar (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474309#comment-16474309
 ] 

indra kumar gurjar commented on SLING-7666:
---

[^site.patch] Contains proposed improvements in documentation.

> Update sling site documentation for bundle - sling-eventing-and-job-handling
> 
>
> Key: SLING-7666
> URL: https://issues.apache.org/jira/browse/SLING-7666
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: indra kumar gurjar
>Priority: Minor
> Attachments: site.patch
>
>
> The sling sling-eventing-and-job-handling bundle documentation doesn't 
> include information of  "JobExecutor" , it describes only "JobConsumer".
> If consumer needs more features like providing progress information or adding 
> more information of the processing, JobExecutor should be implemented. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[indra kumar gurjar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

indra kumar gurjar updated SLING-7666:
--
Attachment: site.patch

> Update sling site documentation for bundle - sling-eventing-and-job-handling
> 
>
> Key: SLING-7666
> URL: https://issues.apache.org/jira/browse/SLING-7666
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: indra kumar gurjar
>Priority: Minor
> Attachments: site.patch
>
>
> The sling sling-eventing-and-job-handling bundle documentation doesn't 
> include information of  "JobExecutor" , it describes only "JobConsumer".
> If consumer needs more features like providing progress information or adding 
> more information of the processing, JobExecutor should be implemented. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE] Release Apache Slingstart Maven Plugin version 1.8.0

[davidb]

As Konrad found a regression, I'm cancelling this vote.

Best regards,

David

On 11 May 2018 at 14:57, Konrad Windszus  wrote:

> -1 from my side.
>
> I think I found a regression. Compare with https://issues.apache.
> org/jira/browse/SLING-7662?focusedCommentId=16471979&
> page=com.atlassian.jira.plugin.system.issuetabpanels%
> 3Acomment-tabpanel#comment-16471979
> 
> .
> Konrad
>
> On 9. May 2018, at 11:06, dav...@apache.org wrote:
>
> Hi all,
>
> We solved 1 issue in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12342542
>
> As this release adds new functionality the minor version of this component
> is increased.
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-1902
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-
> release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 1902 /tmp/sling-staging
>
> Please vote to approve this release:
>
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Best regards,
>
> David
>
>
>

[jira] [Assigned] (SLING-7662) Cannot use slingstart-maven-plugin for starting a server only with referencing a launchpad by dependency due to the DependencyLifecycleParticipant

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert reassigned SLING-7662:
---

Assignee: David Bosschaert

> Cannot use slingstart-maven-plugin for starting a server only with 
> referencing a launchpad by dependency due to the 
> DependencyLifecycleParticipant
> --
>
> Key: SLING-7662
> URL: https://issues.apache.org/jira/browse/SLING-7662
> Project: Sling
>  Issue Type: Bug
>  Components: Maven Plugins and Archetypes
>Affects Versions: Slingstart Maven Plugin 1.7.16
>Reporter: Konrad Windszus
>Assignee: David Bosschaert
>Priority: Major
>
> Whenever the slingstart-maven-plugin is only used to start a server which is 
> referenced via the parameter {{launchpadDependency}} the following error is 
> being emitted from Maven.
> {code}
> ...
> [ERROR] No model files found in 
> /Users/konradwindszus/workspaces/sling/sling-org-apache-sling-servlets-annotations/src/test/provisioning,
>  and no model inlined in POM. -> [Help 1]
> org.apache.maven.MavenExecutionException: No model files found in 
> /Users/konradwindszus/workspaces/sling/sling-org-apache-sling-servlets-annotations/src/test/provisioning,
>  and no model inlined in POM.
> at org.apache.sling.maven.slingstart.ModelPreprocessor.readLocalModel 
> (ModelPreprocessor.java:552)
> at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies 
> (ModelPreprocessor.java:131)
> at org.apache.sling.maven.slingstart.ModelPreprocessor.addDependencies 
> (ModelPreprocessor.java:89)
> at 
> org.apache.sling.maven.slingstart.DependencyLifecycleParticipant.afterProjectsRead
>  (DependencyLifecycleParticipant.java:100)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:267)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MavenExecutionException
> {code}
> The pom.xml looks like this
> {code}
> ...
> 
> 
> 
> org.apache.sling
> slingstart-maven-plugin
> true
> 
> 
> start-container-before-IT
> 
> start
> 
> 
> 
> 
> org.apache.sling.launchpad
> org.apache.sling
> 9
> 
> 
> 
> 
> stop-container-after-IT
> 
> stop
> 
> 
> 
> ${keepITServerRunning}
> 
> 
> 
> 
> 
> 
> 
> singleinstance
> ${http.port}
> ${sling.vm.options}
> sling/logs/stdout.log
> 
> 
> 
> 
> 
> 
> ...
> {code}
> Actually the DependencyLifecycleParticipant is only relevant for the goals 
> {{prepare-package}} and {{package}}. When the slingstart-maven-plugin is 
> exclusively used to run some tests on a freshly provisioned server leveraging 
> an already existing launchpad/starter the 

[jira] [Updated] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[indra kumar gurjar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

indra kumar gurjar updated SLING-7666:
--
Component/s: (was: API)
 Documentation

> Update sling site documentation for bundle - sling-eventing-and-job-handling
> 
>
> Key: SLING-7666
> URL: https://issues.apache.org/jira/browse/SLING-7666
> Project: Sling
>  Issue Type: Improvement
>  Components: Documentation
>Reporter: indra kumar gurjar
>Priority: Minor
>
> The sling sling-eventing-and-job-handling bundle documentation doesn't 
> include information of  "JobExecutor" , it describes only "JobConsumer".
> If consumer needs more features like providing progress information or adding 
> more information of the processing, JobExecutor should be implemented. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-7661) Provide mechanism to persist error message/s in Sling Jobs API

[indra kumar gurjar (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474261#comment-16474261
 ] 

indra kumar gurjar commented on SLING-7661:
---

[~lnra54] Opened SLING-7666  for updating sling site documentation.

> Provide mechanism to persist error message/s in Sling Jobs API
> --
>
> Key: SLING-7661
> URL: https://issues.apache.org/jira/browse/SLING-7661
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Reporter: Leonardo Rodriguez
>Priority: Minor
>
> The sling Jobs API provides a JobConsumer interface: 
> org.apache.sling.event.jobs.consumer.JobConsumer" and Job interface: 
> org.apache.sling.event.jobs.Job.
> Currently, when a JobConsumer fails, it's supposed to return a 
> JobResult.CANCEL, but there is no way to set an error message.
> Looking at the JCR, we see that such (failed/canceled) jobs are saved to 
> /var/eventing/jobs/cancelled/ with a property 
> "slingevent:finishedState=ERROR".
> It would be beneficial to add a method to the Job interface to set an error 
> String or List for multiple errors (to save stacktrace perhaps). That 
> way if a job fails we can debug the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[indra kumar gurjar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

indra kumar gurjar updated SLING-7666:
--
Description: 
The sling sling-eventing-and-job-handling bundle documentation doesn't include 
information of  "JobExecutor" , it describes only "JobConsumer".

If consumer needs more features like providing progress information or adding 
more information of the processing, JobExecutor should be implemented. 

 

  was:
The sling 

Currently, when a JobConsumer fails, it's supposed to return a 
JobResult.CANCEL, but there is no way to set an error message.

Looking at the JCR, we see that such (failed/canceled) jobs are saved to 
/var/eventing/jobs/cancelled/ with a property "slingevent:finishedState=ERROR".

It would be beneficial to add a method to the Job interface to set an error 
String or List for multiple errors (to save stacktrace perhaps). That 
way if a job fails we can debug the issue.


> Update sling site documentation for bundle - sling-eventing-and-job-handling
> 
>
> Key: SLING-7666
> URL: https://issues.apache.org/jira/browse/SLING-7666
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Reporter: indra kumar gurjar
>Priority: Minor
>
> The sling sling-eventing-and-job-handling bundle documentation doesn't 
> include information of  "JobExecutor" , it describes only "JobConsumer".
> If consumer needs more features like providing progress information or adding 
> more information of the processing, JobExecutor should be implemented. 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[indra kumar gurjar (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

indra kumar gurjar updated SLING-7666:
--
Description: 
The sling 

Currently, when a JobConsumer fails, it's supposed to return a 
JobResult.CANCEL, but there is no way to set an error message.

Looking at the JCR, we see that such (failed/canceled) jobs are saved to 
/var/eventing/jobs/cancelled/ with a property "slingevent:finishedState=ERROR".

It would be beneficial to add a method to the Job interface to set an error 
String or List for multiple errors (to save stacktrace perhaps). That 
way if a job fails we can debug the issue.

  was:
The sling Jobs API provides a JobConsumer interface: 
org.apache.sling.event.jobs.consumer.JobConsumer" and Job interface: 
org.apache.sling.event.jobs.Job.

Currently, when a JobConsumer fails, it's supposed to return a 
JobResult.CANCEL, but there is no way to set an error message.

Looking at the JCR, we see that such (failed/canceled) jobs are saved to 
/var/eventing/jobs/cancelled/ with a property "slingevent:finishedState=ERROR".

It would be beneficial to add a method to the Job interface to set an error 
String or List for multiple errors (to save stacktrace perhaps). That 
way if a job fails we can debug the issue.


> Update sling site documentation for bundle - sling-eventing-and-job-handling
> 
>
> Key: SLING-7666
> URL: https://issues.apache.org/jira/browse/SLING-7666
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Reporter: indra kumar gurjar
>Priority: Minor
>
> The sling 
> Currently, when a JobConsumer fails, it's supposed to return a 
> JobResult.CANCEL, but there is no way to set an error message.
> Looking at the JCR, we see that such (failed/canceled) jobs are saved to 
> /var/eventing/jobs/cancelled/ with a property 
> "slingevent:finishedState=ERROR".
> It would be beneficial to add a method to the Job interface to set an error 
> String or List for multiple errors (to save stacktrace perhaps). That 
> way if a job fails we can debug the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-7666) Update sling site documentation for bundle - sling-eventing-and-job-handling

[indra kumar gurjar (JIRA)]

indra kumar gurjar created SLING-7666:
-

 Summary: Update sling site documentation for bundle - 
sling-eventing-and-job-handling
 Key: SLING-7666
 URL: https://issues.apache.org/jira/browse/SLING-7666
 Project: Sling
  Issue Type: Improvement
  Components: API
Reporter: indra kumar gurjar


The sling Jobs API provides a JobConsumer interface: 
org.apache.sling.event.jobs.consumer.JobConsumer" and Job interface: 
org.apache.sling.event.jobs.Job.

Currently, when a JobConsumer fails, it's supposed to return a 
JobResult.CANCEL, but there is no way to set an error message.

Looking at the JCR, we see that such (failed/canceled) jobs are saved to 
/var/eventing/jobs/cancelled/ with a property "slingevent:finishedState=ERROR".

It would be beneficial to add a method to the Job interface to set an error 
String or List for multiple errors (to save stacktrace perhaps). That 
way if a job fails we can debug the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [proposal][scripting console] http API for terminal usage

[Robert Munteanu]

On Mon, 2018-05-14 at 12:05 +0200, Nicolas Peltier wrote:
> Hey,
> 
> thought about using terminal rather than felix html page for
> scripting
> (when scripting take one line like for pipes, htis might be useful).

The gogo shell can be deployed on Sling and you can make it accessible
via telnet ( unauthenticated, IIRC ) . I think this can also be doable
with SSH.

>From there you can add new Gogo commands from your bundle or an
additional Sling Pipes + Gogo shell bundle.

Is that what you're looking for?

Robert

[jira] [Resolved] (SLING-7661) Provide mechanism to persist error message/s in Sling Jobs API

[Leonardo Rodriguez (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leonardo Rodriguez resolved SLING-7661.
---
Resolution: Not A Problem

Thank you for the information [~igurjar]

The Sling website documentation at: 
[https://sling.apache.org/documentation/bundles/apache-sling-eventing-and-job-handling.html]
 makes no mention of the JobExecutor, but the JobExecutor API provides the 
requested functionality. I would suggest updating the documentation page to 
include the JobExecutor.

> Provide mechanism to persist error message/s in Sling Jobs API
> --
>
> Key: SLING-7661
> URL: https://issues.apache.org/jira/browse/SLING-7661
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Reporter: Leonardo Rodriguez
>Priority: Minor
>
> The sling Jobs API provides a JobConsumer interface: 
> org.apache.sling.event.jobs.consumer.JobConsumer" and Job interface: 
> org.apache.sling.event.jobs.Job.
> Currently, when a JobConsumer fails, it's supposed to return a 
> JobResult.CANCEL, but there is no way to set an error message.
> Looking at the JCR, we see that such (failed/canceled) jobs are saved to 
> /var/eventing/jobs/cancelled/ with a property 
> "slingevent:finishedState=ERROR".
> It would be beneficial to add a method to the Job interface to set an error 
> String or List for multiple errors (to save stacktrace perhaps). That 
> way if a job fails we can debug the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [proposal][scripting console] http API for terminal usage

[Nicolas Peltier]

Hi,

sorry about that, you are right, so:
# on the server side, in addition to what exists already, would be cool
that a given script resource can have "depedencies", and if you "post" to
that script resource, you get dependencies executed before. This would
allow to add a context that makes scripts smaller (and easier to
read/maintain),
# on a client side, a CLI would be nice, yes, that manages default host,
auth, and eventually scripting languages. I can think about nice features
with pipes as it's the one i'm using the most but i think it would be best
to have something more generic

Nicolas

2018-05-14 13:41 GMT+02:00 Ioan Eugen Stan :

> Hi,
>
> Sounds interesting. Are you talking like building a CLI that can be used
> for scripts and maybe more management operations?
>
> Could you please describe in more details how you see this working? I
> think it would be more easy for people to understand your use case.
>
> Thanks,
>
> Eugen Stan
> Netdava International
>
>   Mesaj original
> De la: peltier.nico...@gmail.com
> Trimis: 14 mai 2018 13:05
> Către: dev@sling.apache.org
> Răsp. la: dev@sling.apache.org
> Subiect: [proposal][scripting console] http API for terminal usage
>
> Hey,
>
> thought about using terminal rather than felix html page for scripting
> (when scripting take one line like for pipes, htis might be useful).
>
> Thoughts?
>
> Nicolas
>

[jira] [Commented] (SLING-7661) Provide mechanism to persist error message/s in Sling Jobs API

[indra kumar gurjar (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16474069#comment-16474069
 ] 

indra kumar gurjar commented on SLING-7661:
---

[~lnra54] JobExecutor.process method gives access to JobExecutionContext. We 
can set the error message by 
JobExecutionContext.result().message(errorMsg).failed() and return this result. 

The error message can be retrieved by Job.getResultMessage();

> Provide mechanism to persist error message/s in Sling Jobs API
> --
>
> Key: SLING-7661
> URL: https://issues.apache.org/jira/browse/SLING-7661
> Project: Sling
>  Issue Type: Improvement
>  Components: API
>Reporter: Leonardo Rodriguez
>Priority: Minor
>
> The sling Jobs API provides a JobConsumer interface: 
> org.apache.sling.event.jobs.consumer.JobConsumer" and Job interface: 
> org.apache.sling.event.jobs.Job.
> Currently, when a JobConsumer fails, it's supposed to return a 
> JobResult.CANCEL, but there is no way to set an error message.
> Looking at the JCR, we see that such (failed/canceled) jobs are saved to 
> /var/eventing/jobs/cancelled/ with a property 
> "slingevent:finishedState=ERROR".
> It would be beneficial to add a method to the Job interface to set an error 
> String or List for multiple errors (to save stacktrace perhaps). That 
> way if a job fails we can debug the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [proposal][scripting console] http API for terminal usage

[Ioan Eugen Stan]

Hi, 

Sounds interesting. Are you talking like building a CLI that can be used for 
scripts and maybe more management operations?

Could you please describe in more details how you see this working? I think it 
would be more easy for people to understand your use case. 

Thanks,

Eugen Stan 
Netdava International

  Mesaj original  
De la: peltier.nico...@gmail.com
Trimis: 14 mai 2018 13:05
Către: dev@sling.apache.org
Răsp. la: dev@sling.apache.org
Subiect: [proposal][scripting console] http API for terminal usage

Hey,

thought about using terminal rather than felix html page for scripting
(when scripting take one line like for pipes, htis might be useful).

Thoughts?

Nicolas

[proposal][scripting console] http API for terminal usage

[Nicolas Peltier]

Hey,

thought about using terminal rather than felix html page for scripting
(when scripting take one line like for pipes, htis might be useful).

Thoughts?

Nicolas

[jira] [Commented] (SLING-7660) LogManager configuration "Number of Log Files" limited to 20

[Chetan Mehrotra (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-7660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473899#comment-16473899
 ] 

Chetan Mehrotra commented on SLING-7660:


+1 to increase the size. Not sure on setting it to max. From 
[LOGBACK-266|https://jira.qos.ch/browse/LOGBACK-266] it appears that limit has 
some reasoning. 

bq. It seems the limit is there, since for each roll, where maxIndex=N, there 
are N file renames, and this doesn't scale well up to 100 renames. (Well 
actually it depends on the filesystem)

>From the referred issue it appears that recommendation is to use 
>[SizeAndTimeBasedFNATP|https://logback.qos.ch/manual/appenders.html#SizeAndTimeBasedFNATP]

> LogManager configuration "Number of Log Files" limited to 20
> 
>
> Key: SLING-7660
> URL: https://issues.apache.org/jira/browse/SLING-7660
> Project: Sling
>  Issue Type: Improvement
>  Components: Commons
>Affects Versions: Commons Log 5.1.6
>Reporter: Julian Sedding
>Assignee: Julian Sedding
>Priority: Minor
> Fix For: Commons Log 5.1.8
>
>
> The "Number of Log Files" configuration property for size-based log rotation 
> is capped at 20 (or 21 including the current log file. This limitation comes 
> from [logback's 
> {{FixedWindowRollingPolicy}}|https://github.com/qos-ch/logback/blob/39c7ab9510c4f48ef3fcbef248aac380d3b58235/logback-core/src/main/java/ch/qos/logback/core/rolling/FixedWindowRollingPolicy.java#L47],
>  but can be overridden in a subclass. I propose to override the 
> {{FixedWindowRollingPolicy#getMaxWindowSize}} to return {{Integer.MAX_VALUE}}.
> cc [~chetanm]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-7638) Pipe binding expression instantiation failure should break the containing pipe

[Nicolas Peltier (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Peltier resolved SLING-7638.

   Resolution: Fixed
 Assignee: Nicolas Peltier
Fix Version/s: pipes 2.1.0

> Pipe binding expression instantiation failure should break the containing pipe
> --
>
> Key: SLING-7638
> URL: https://issues.apache.org/jira/browse/SLING-7638
> Project: Sling
>  Issue Type: Improvement
>  Components: Extensions
>Affects Versions: pipes 2.0.2
>Reporter: Nicolas Peltier
>Assignee: Nicolas Peltier
>Priority: Major
> Fix For: pipes 2.1.0
>
>
> now a failed expression instantation just take the source, which is always a 
> problem, the pipe should rather fail



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)