[jira] [Comment Edited] (SLING-8139) Improve support to read/write ACE restrictions from AccessControlUtil

[Eric Norman (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701212#comment-16701212
 ] 

Eric Norman edited comment on SLING-8139 at 11/28/18 7:14 AM:
--

Fixed at: 
[https://github.com/apache/sling-org-apache-sling-jcr-base/commit/fc75d74b664f87d2bd68f10428a88d78a626aa61|https://github.com/apache/sling-org-apache-sling-jcr-base/commit/fc75d74b664f87d2bd68f10428a88d78a626aa61]


was (Author: edn):
Fixed at: 
[https://github.com/apache/sling-org-apache-sling-jcr-base/commit/fc75d74b664f87d2bd68f10428a88d78a626aa61|http://example.com]

> Improve support to read/write ACE restrictions from AccessControlUtil
> -
>
> Key: SLING-8139
> URL: https://issues.apache.org/jira/browse/SLING-8139
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR Base 3.0.4
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Base 3.0.6
>
>
> Support for read/write of restrictions on the ACE has only partially been 
> implemented in the sling jcr.base AccessControlUtil operations. 
>   
>  However it looks like adding support for read/write of ACE restrictions 
> would not be too difficult and it looks like it could be useful to the 
> community.
>   
>  It looks like changes would be needed in the org.apache.sling.jcr.base 
> bundle, specifically these:
>   
>  1. org.apache.sling.jcr.base
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions and multi-value 
> restrictions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8138) Upgrade to jackrabbit 2.16.x and oak 1.8.x

[Eric Norman (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701472#comment-16701472
 ] 

Eric Norman commented on SLING-8138:


1) Sorry about that.  I have fixed the link. 

2) I suppose 1.8.9 would be ok if you prefer.  I chose 1.8.8 since that was the 
version of oak that is currently in the sling-starter distribution so I figured 
it was already tested and likely to work.

> Upgrade to jackrabbit 2.16.x and oak 1.8.x
> --
>
> Key: SLING-8138
> URL: https://issues.apache.org/jira/browse/SLING-8138
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock Oak 2.1.0
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Testing Sling Mock Oak 2.1.2
>
>
> In order to test new functionality added in Oak 1.8, the mock-oak module 
> needs to be updated to use the 1.8.x version of oak and the 2.16.x of 
> jackrabbit 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (SLING-8138) Upgrade to jackrabbit 2.16.x and oak 1.8.x

[Eric Norman (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701074#comment-16701074
 ] 

Eric Norman edited comment on SLING-8138 at 11/28/18 7:09 AM:
--

Fixed at: 
[https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/e33aec3902d538cfaddd0b5b85536221bd9a129d|https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/e33aec3902d538cfaddd0b5b85536221bd9a129d]


was (Author: edn):
Fixed at: 
[https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/e33aec3902d538cfaddd0b5b85536221bd9a129d|http://example.com]

> Upgrade to jackrabbit 2.16.x and oak 1.8.x
> --
>
> Key: SLING-8138
> URL: https://issues.apache.org/jira/browse/SLING-8138
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock Oak 2.1.0
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Testing Sling Mock Oak 2.1.2
>
>
> In order to test new functionality added in Oak 1.8, the mock-oak module 
> needs to be updated to use the 1.8.x version of oak and the 2.16.x of 
> jackrabbit 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8138) Upgrade to jackrabbit 2.16.x and oak 1.8.x

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701456#comment-16701456
 ] 

Julian Reschke commented on SLING-8138:
---

1) Commit link is broken

2) Why not Oak 1.8.9?

> Upgrade to jackrabbit 2.16.x and oak 1.8.x
> --
>
> Key: SLING-8138
> URL: https://issues.apache.org/jira/browse/SLING-8138
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock Oak 2.1.0
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Testing Sling Mock Oak 2.1.2
>
>
> In order to test new functionality added in Oak 1.8, the mock-oak module 
> needs to be updated to use the 1.8.x version of oak and the 2.16.x of 
> jackrabbit 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [HEADS-UP] New repository for org.apache.sling.launchpad.startupmanager

[Oliver Lietz]

On Tuesday 27 November 2018 10:01:37 Bertrand Delacretaz wrote:
> Hi,
> 
> On Tue, Nov 27, 2018 at 9:34 AM Karl Pauls  wrote:
> > ...I think I'll call it:
> > sling-org-apache-sling-launchpad-startupmanager ..
> 
> That works for me and maybe at the same time you can add some info to
> the README about what that module does ;-)

AFAIR we agreed to drop the Launchpad API and removed all usage from Sling's 
bundles. It was only implemented fully in Launchpad Base and not in any other 
launcher. So I wonder why we bring it back now and add support in Feature 
Launcher (?).

Regards,
O.

> -Bertrand

Re: Capabilities

[Oliver Lietz]

On Wednesday 21 November 2018 14:51:56 Carsten Ziegeler wrote:
> Ah ok, thanks
> 
> Can't we use openapi for this?

No, I don't think OpenAPI does help here.

Regards,
O.

> Carsten
> 
> Am 21.11.2018 um 11:06 schrieb Bertrand Delacretaz:
> > On Wed, Nov 21, 2018 at 10:58 AM Carsten Ziegeler  
wrote:
> >> ...Sorry, I guess I missed the whole discussion, what are these
> >> capabilities about?...
> > 
> > My first reply in this thread should explain that:
> > 
> > https://lists.apache.org/thread.html/ddc3c78916531f1ff2c31439f1048c098c04c
> > f1173ceef3067958209@%3Cdev.sling.apache.org%3E
> > 
> > -Bertrand

Support for ACE Restrictions with jackrabbit.accessmanager REST

[Eric Norman]

Hey all,

I've been doing some work to try to solve the issue reported in the thread
at [1] and tracked as SLING-8117


   1.
   
https://lists.apache.org/thread.html/bb7c9bede0274969f4e7c2363a40ebd6d7ee783536ae02ca5642590d@%3Cusers.sling.apache.org%3E


I have a solution working locally and some new unit tests to verify it
works.

I've committed the changes for the first of two steps with these issues:
SLING-8138  for JCR Base
3.0.6

SLING-8139  for Testing
Sling Mock Oak 2.1.2


Would someone be able to review the changes done for those issues and if
there are no objections to the code changes assist with releasing those two
bundles?  I've never done that before and I not sure I even have sufficient
rights to do it.

Once there are released versions of those two bundles, I can commit the
second part of the solution to resolve the remaining two issues:
- SLING-8117  forJCR
Jackrabbit Access Manager 3.0.4


   1. SLING-8118  forJCR
   ContentLoader 2.3.0
   



And if I understand correctly, I will have to wait for released versions of
all 4 of the above bundles before the new integration tests can be
committed to org.apache.sling.launchpad.integration-tests since the
org.apache.sling.starter project isn't allowed to have SNAPSHOT
dependencies?

I'd be happy to answer any questions if you have them.

Regards,
Eric

[jira] [Updated] (SLING-8118) Add support to set ACE restrictions from contentloader

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-8118:
---
Fix Version/s: (was: JCR ContentLoader 2.2.8)
   JCR ContentLoader 2.3.0

> Add support to set ACE restrictions from contentloader
> --
>
> Key: SLING-8118
> URL: https://issues.apache.org/jira/browse/SLING-8118
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR ContentLoader 2.2.6
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR ContentLoader 2.3.0
>
>
> Support for write of restrictions on the ACE has not yet been implemented in 
> the sling jcr.contentloader bundle. 
>   
>  However it looks like adding support for write of ACE restrictions would not 
> be too difficult and it looks like it could be useful to the community.
>   
>  It looks like changes would be needed in a few bundles, specifically these:
>   
>  1. org.apache.sling.jcr.base  ( see SLING-8139  )
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions
>  2. org.apache.sling.jcr.contentloader
>      a) Changes to the ContentCreator and JsonReader to support reading 
> restrictions from the JSON and applying them while loading content into the 
> repository
>  3. Plus some automated tests and updated documentation...
>   
>  SLING-6422 appears to have already added support for setting restrictions 
> for the repoinit style of ACE initialization



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8139) Improve support to read/write ACE restrictions from AccessControlUtil

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-8139.

Resolution: Fixed

Fixed at: 
[https://github.com/apache/sling-org-apache-sling-jcr-base/commit/fc75d74b664f87d2bd68f10428a88d78a626aa61|http://example.com]

> Improve support to read/write ACE restrictions from AccessControlUtil
> -
>
> Key: SLING-8139
> URL: https://issues.apache.org/jira/browse/SLING-8139
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR Base 3.0.4
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Base 3.0.6
>
>
> Support for read/write of restrictions on the ACE has only partially been 
> implemented in the sling jcr.base AccessControlUtil operations. 
>   
>  However it looks like adding support for read/write of ACE restrictions 
> would not be too difficult and it looks like it could be useful to the 
> community.
>   
>  It looks like changes would be needed in the org.apache.sling.jcr.base 
> bundle, specifically these:
>   
>  1. org.apache.sling.jcr.base
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions and multi-value 
> restrictions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8139) Improve support to read/write ACE restrictions from AccessControlUtil

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-8139:
---
Affects Version/s: (was: JCR Jackrabbit Access Manager 3.0.2)

> Improve support to read/write ACE restrictions from AccessControlUtil
> -
>
> Key: SLING-8139
> URL: https://issues.apache.org/jira/browse/SLING-8139
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR Base 3.0.4
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Base 3.0.6
>
>
> Support for read/write of restrictions on the ACE has not yet been 
> implemented in the sling jackrabbit.accessmanager REST operations. 
>   
>  However it looks like adding support for read/write of ACE restrictions 
> would not be too difficult and it looks like it could be useful to the 
> community.
>   
>  It looks like changes would be needed in a few bundles, specifically these:
>   
>  1. org.apache.sling.jcr.base ( common changes with SLING-8118 )
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions
>  2. org.apache.sling.jcr.jackrabbit.accessmanager
>      a) ModifyAce - changes to process posted "restriction" parameters to be 
> set
>      b) GetAcl/GetEffectiveAcl servlets - changes to return the declared 
> restriction values in the returned JSON
>      c) PrivilegesInfo - add methods to read the declared restrictions to be 
> used from scripts who are interested in such things
> 3. Plus some automated tests and updated documentation...
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8117) Add support to read/write ACE restrictions from REST

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-8117:
---
Fix Version/s: (was: JCR Base 3.0.6)

> Add support to read/write ACE restrictions from REST
> 
>
> Key: SLING-8117
> URL: https://issues.apache.org/jira/browse/SLING-8117
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR Jackrabbit Access Manager 3.0.2
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.0.4
>
>
> Support for read/write of restrictions on the ACE has not yet been 
> implemented in the sling jackrabbit.accessmanager REST operations. 
>   
>  However it looks like adding support for read/write of ACE restrictions 
> would not be too difficult and it looks like it could be useful to the 
> community.
>   
>  It looks like changes would be needed in a few bundles, specifically these:
>   
>  1. org.apache.sling.jcr.base ( common changes with SLING-8118 )
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions
>  2. org.apache.sling.jcr.jackrabbit.accessmanager
>      a) ModifyAce - changes to process posted "restriction" parameters to be 
> set
>      b) GetAcl/GetEffectiveAcl servlets - changes to return the declared 
> restriction values in the returned JSON
>      c) PrivilegesInfo - add methods to read the declared restrictions to be 
> used from scripts who are interested in such things
> 3. Plus some automated tests and updated documentation...
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8118) Add support to set ACE restrictions from contentloader

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-8118:
---
Description: 
Support for write of restrictions on the ACE has not yet been implemented in 
the sling jcr.contentloader bundle. 
  
 However it looks like adding support for write of ACE restrictions would not 
be too difficult and it looks like it could be useful to the community.
  
 It looks like changes would be needed in a few bundles, specifically these:
  
 1. org.apache.sling.jcr.base  ( see SLING-8139  )
     a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
methods to support passing in and processing of restrictions
 2. org.apache.sling.jcr.contentloader
     a) Changes to the ContentCreator and JsonReader to support reading 
restrictions from the JSON and applying them while loading content into the 
repository
 3. Plus some automated tests and updated documentation...
  
 SLING-6422 appears to have already added support for setting restrictions for 
the repoinit style of ACE initialization

  was:
Support for write of restrictions on the ACE has not yet been implemented in 
the sling jcr.contentloader bundle. 
 
However it looks like adding support for write of ACE restrictions would not be 
too difficult and it looks like it could be useful to the community.
 
It looks like changes would be needed in a few bundles, specifically these:
 
1. org.apache.sling.jcr.base ( common changes with SLING-8117 )
    a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
methods to support passing in and processing of restrictions
2. org.apache.sling.jcr.contentloader
    a) Changes to the ContentCreator and JsonReader to support reading 
restrictions from the JSON and applying them while loading content into the 
repository
3. Plus some automated tests and updated documentation...
 
SLING-6422 appears to have already added support for setting restrictions for 
the repoinit style of ACE initialization


> Add support to set ACE restrictions from contentloader
> --
>
> Key: SLING-8118
> URL: https://issues.apache.org/jira/browse/SLING-8118
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR ContentLoader 2.2.6
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR ContentLoader 2.2.8
>
>
> Support for write of restrictions on the ACE has not yet been implemented in 
> the sling jcr.contentloader bundle. 
>   
>  However it looks like adding support for write of ACE restrictions would not 
> be too difficult and it looks like it could be useful to the community.
>   
>  It looks like changes would be needed in a few bundles, specifically these:
>   
>  1. org.apache.sling.jcr.base  ( see SLING-8139  )
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions
>  2. org.apache.sling.jcr.contentloader
>      a) Changes to the ContentCreator and JsonReader to support reading 
> restrictions from the JSON and applying them while loading content into the 
> repository
>  3. Plus some automated tests and updated documentation...
>   
>  SLING-6422 appears to have already added support for setting restrictions 
> for the repoinit style of ACE initialization



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8117) Add support to read/write ACE restrictions from REST

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-8117:
---
Description: 
Support for read/write of restrictions on the ACE has not yet been implemented 
in the sling jackrabbit.accessmanager REST operations. 
  
 However it looks like adding support for read/write of ACE restrictions would 
not be too difficult and it looks like it could be useful to the community.
  
 It looks like changes would be needed in a few bundles, specifically these:
  
 1. org.apache.sling.jcr.base ( see SLING-8139  )
     a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
methods to support passing in and processing of restrictions
 2. org.apache.sling.jcr.jackrabbit.accessmanager
     a) ModifyAce - changes to process posted "restriction" parameters to be set
     b) GetAcl/GetEffectiveAcl servlets - changes to return the declared 
restriction values in the returned JSON
     c) PrivilegesInfo - add methods to read the declared restrictions to be 
used from scripts who are interested in such things
 3. Plus some automated tests and updated documentation...
  

  was:
Support for read/write of restrictions on the ACE has not yet been implemented 
in the sling jackrabbit.accessmanager REST operations. 
  
 However it looks like adding support for read/write of ACE restrictions would 
not be too difficult and it looks like it could be useful to the community.
  
 It looks like changes would be needed in a few bundles, specifically these:
  
 1. org.apache.sling.jcr.base ( common changes with SLING-8118 )
     a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
methods to support passing in and processing of restrictions
 2. org.apache.sling.jcr.jackrabbit.accessmanager
     a) ModifyAce - changes to process posted "restriction" parameters to be set
     b) GetAcl/GetEffectiveAcl servlets - changes to return the declared 
restriction values in the returned JSON
     c) PrivilegesInfo - add methods to read the declared restrictions to be 
used from scripts who are interested in such things
3. Plus some automated tests and updated documentation...
  


> Add support to read/write ACE restrictions from REST
> 
>
> Key: SLING-8117
> URL: https://issues.apache.org/jira/browse/SLING-8117
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR Jackrabbit Access Manager 3.0.2
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.0.4
>
>
> Support for read/write of restrictions on the ACE has not yet been 
> implemented in the sling jackrabbit.accessmanager REST operations. 
>   
>  However it looks like adding support for read/write of ACE restrictions 
> would not be too difficult and it looks like it could be useful to the 
> community.
>   
>  It looks like changes would be needed in a few bundles, specifically these:
>   
>  1. org.apache.sling.jcr.base ( see SLING-8139  )
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions
>  2. org.apache.sling.jcr.jackrabbit.accessmanager
>      a) ModifyAce - changes to process posted "restriction" parameters to be 
> set
>      b) GetAcl/GetEffectiveAcl servlets - changes to return the declared 
> restriction values in the returned JSON
>      c) PrivilegesInfo - add methods to read the declared restrictions to be 
> used from scripts who are interested in such things
>  3. Plus some automated tests and updated documentation...
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8117) Add support to read/write ACE restrictions from REST

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-8117:
---
Affects Version/s: (was: JCR Base 3.0.4)

> Add support to read/write ACE restrictions from REST
> 
>
> Key: SLING-8117
> URL: https://issues.apache.org/jira/browse/SLING-8117
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR Jackrabbit Access Manager 3.0.2
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Jackrabbit Access Manager 3.0.4
>
>
> Support for read/write of restrictions on the ACE has not yet been 
> implemented in the sling jackrabbit.accessmanager REST operations. 
>   
>  However it looks like adding support for read/write of ACE restrictions 
> would not be too difficult and it looks like it could be useful to the 
> community.
>   
>  It looks like changes would be needed in a few bundles, specifically these:
>   
>  1. org.apache.sling.jcr.base ( common changes with SLING-8118 )
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions
>  2. org.apache.sling.jcr.jackrabbit.accessmanager
>      a) ModifyAce - changes to process posted "restriction" parameters to be 
> set
>      b) GetAcl/GetEffectiveAcl servlets - changes to return the declared 
> restriction values in the returned JSON
>      c) PrivilegesInfo - add methods to read the declared restrictions to be 
> used from scripts who are interested in such things
> 3. Plus some automated tests and updated documentation...
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8139) Improve support to read/write ACE restrictions from AccessControlUtil

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-8139:
---
Description: 
Support for read/write of restrictions on the ACE has only partially been 
implemented in the sling jcr.base AccessControlUtil operations. 
  
 However it looks like adding support for read/write of ACE restrictions would 
not be too difficult and it looks like it could be useful to the community.
  
 It looks like changes would be needed in the org.apache.sling.jcr.base bundle, 
specifically these:
  
 1. org.apache.sling.jcr.base
     a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
methods to support passing in and processing of restrictions and multi-value 
restrictions

  was:
Support for read/write of restrictions on the ACE has not yet been implemented 
in the sling jackrabbit.accessmanager REST operations. 
  
 However it looks like adding support for read/write of ACE restrictions would 
not be too difficult and it looks like it could be useful to the community.
  
 It looks like changes would be needed in a few bundles, specifically these:
  
 1. org.apache.sling.jcr.base ( common changes with SLING-8118 )
     a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
methods to support passing in and processing of restrictions
 2. org.apache.sling.jcr.jackrabbit.accessmanager
     a) ModifyAce - changes to process posted "restriction" parameters to be set
     b) GetAcl/GetEffectiveAcl servlets - changes to return the declared 
restriction values in the returned JSON
     c) PrivilegesInfo - add methods to read the declared restrictions to be 
used from scripts who are interested in such things
3. Plus some automated tests and updated documentation...
  


> Improve support to read/write ACE restrictions from AccessControlUtil
> -
>
> Key: SLING-8139
> URL: https://issues.apache.org/jira/browse/SLING-8139
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR Base 3.0.4
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Base 3.0.6
>
>
> Support for read/write of restrictions on the ACE has only partially been 
> implemented in the sling jcr.base AccessControlUtil operations. 
>   
>  However it looks like adding support for read/write of ACE restrictions 
> would not be too difficult and it looks like it could be useful to the 
> community.
>   
>  It looks like changes would be needed in the org.apache.sling.jcr.base 
> bundle, specifically these:
>   
>  1. org.apache.sling.jcr.base
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions and multi-value 
> restrictions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8139) Improve support to read/write ACE restrictions from AccessControlUtil

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman updated SLING-8139:
---
Fix Version/s: (was: JCR Jackrabbit Access Manager 3.0.4)

> Improve support to read/write ACE restrictions from AccessControlUtil
> -
>
> Key: SLING-8139
> URL: https://issues.apache.org/jira/browse/SLING-8139
> Project: Sling
>  Issue Type: New Feature
>Affects Versions: JCR Base 3.0.4
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: JCR Base 3.0.6
>
>
> Support for read/write of restrictions on the ACE has not yet been 
> implemented in the sling jackrabbit.accessmanager REST operations. 
>   
>  However it looks like adding support for read/write of ACE restrictions 
> would not be too difficult and it looks like it could be useful to the 
> community.
>   
>  It looks like changes would be needed in a few bundles, specifically these:
>   
>  1. org.apache.sling.jcr.base ( common changes with SLING-8118 )
>      a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
> methods to support passing in and processing of restrictions
>  2. org.apache.sling.jcr.jackrabbit.accessmanager
>      a) ModifyAce - changes to process posted "restriction" parameters to be 
> set
>      b) GetAcl/GetEffectiveAcl servlets - changes to return the declared 
> restriction values in the returned JSON
>      c) PrivilegesInfo - add methods to read the declared restrictions to be 
> used from scripts who are interested in such things
> 3. Plus some automated tests and updated documentation...
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8139) Improve support to read/write ACE restrictions from AccessControlUtil

[Eric Norman (JIRA)]

Eric Norman created SLING-8139:
--

 Summary: Improve support to read/write ACE restrictions from 
AccessControlUtil
 Key: SLING-8139
 URL: https://issues.apache.org/jira/browse/SLING-8139
 Project: Sling
  Issue Type: New Feature
Affects Versions: JCR Base 3.0.4, JCR Jackrabbit Access Manager 3.0.2
Reporter: Eric Norman
Assignee: Eric Norman
 Fix For: JCR Base 3.0.6, JCR Jackrabbit Access Manager 3.0.4


Support for read/write of restrictions on the ACE has not yet been implemented 
in the sling jackrabbit.accessmanager REST operations. 
  
 However it looks like adding support for read/write of ACE restrictions would 
not be too difficult and it looks like it could be useful to the community.
  
 It looks like changes would be needed in a few bundles, specifically these:
  
 1. org.apache.sling.jcr.base ( common changes with SLING-8118 )
     a) Changes to the AccessControlUtil addEntry/replaceAccessControlEntry 
methods to support passing in and processing of restrictions
 2. org.apache.sling.jcr.jackrabbit.accessmanager
     a) ModifyAce - changes to process posted "restriction" parameters to be set
     b) GetAcl/GetEffectiveAcl servlets - changes to return the declared 
restriction values in the returned JSON
     c) PrivilegesInfo - add methods to read the declared restrictions to be 
used from scripts who are interested in such things
3. Plus some automated tests and updated documentation...
  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8138) Upgrade to jackrabbit 2.16.x and oak 1.8.x

[Eric Norman (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Norman resolved SLING-8138.

Resolution: Fixed

Fixed at: 
[https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/e33aec3902d538cfaddd0b5b85536221bd9a129d|http://example.com]

> Upgrade to jackrabbit 2.16.x and oak 1.8.x
> --
>
> Key: SLING-8138
> URL: https://issues.apache.org/jira/browse/SLING-8138
> Project: Sling
>  Issue Type: Improvement
>  Components: Testing
>Affects Versions: Testing Sling Mock Oak 2.1.0
>Reporter: Eric Norman
>Assignee: Eric Norman
>Priority: Major
> Fix For: Testing Sling Mock Oak 2.1.2
>
>
> In order to test new functionality added in Oak 1.8, the mock-oak module 
> needs to be updated to use the 1.8.x version of oak and the 2.16.x of 
> jackrabbit 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8138) Upgrade to jackrabbit 2.16.x and oak 1.8.x

[Eric Norman (JIRA)]

Eric Norman created SLING-8138:
--

 Summary: Upgrade to jackrabbit 2.16.x and oak 1.8.x
 Key: SLING-8138
 URL: https://issues.apache.org/jira/browse/SLING-8138
 Project: Sling
  Issue Type: Improvement
  Components: Testing
Affects Versions: Testing Sling Mock Oak 2.1.0
Reporter: Eric Norman
Assignee: Eric Norman
 Fix For: Testing Sling Mock Oak 2.1.2


In order to test new functionality added in Oak 1.8, the mock-oak module needs 
to be updated to use the 1.8.x version of oak and the 2.16.x of jackrabbit 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8137) Create an analyser that checks the order of API Regions

[David Bosschaert (JIRA)]

David Bosschaert created SLING-8137:
---

 Summary: Create an analyser that checks the order of API Regions
 Key: SLING-8137
 URL: https://issues.apache.org/jira/browse/SLING-8137
 Project: Sling
  Issue Type: Task
  Components: Feature Model
Affects Versions: Feature Model Analyser 0.8.0
Reporter: David Bosschaert
Assignee: David Bosschaert


The order in which API Regions are specified is important since later API 
Regions inherit from earlier API Regions. It should be possible to validate 
that API Regions are specified in the correct order. An analyser can perform 
this check.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8136) Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700405#comment-16700405
 ] 

ASF GitHub Bot commented on SLING-8136:
---

rombert commented on issue #11: SLING-8136 - Analyser fails when javax.*, 
org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11#issuecomment-442056390
 
 
   Well, I guess we could always read them from the 
`org.osgi.framework.system.packages` property and make sure we interpolate 
them, but I did not find a good way of doing that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss 
> imports are found
> ---
>
> Key: SLING-8136
> URL: https://issues.apache.org/jira/browse/SLING-8136
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 0.8.2
>
>
> I've tried running the {{slingfeature-maven-plugin}} to analyse imports and 
> exports using the {{bundle-packages}} analyser.
> This seems to work just fine, just that some packages - found in the issue 
> title - are not seen as being provided by the framework. Some errors that pop 
> up are:
> {noformat}
> [ERROR] Bundle oak-auth-ldap:1.9.11 is importing package(s) org.ietf.jgss in 
> start level 0 but no bundle is exporting these for that start level.
> [ERROR] Bundle oak-lucene:1.9.11 is importing package(s) 
> [org.xml.sax.helpers, org.xml.sax] in start level 0 but no bundle is 
> exporting these for that start level.
> {noformat}
> These packages are provided using an {{org.osgi.framework.system.packages}} 
> framework property, so I guess there is some glue missing to make this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rombert commented on issue #11: SLING-8136 - Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

[GitBox]

rombert commented on issue #11: SLING-8136 - Analyser fails when javax.*, 
org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11#issuecomment-442056390
 
 
   Well, I guess we could always read them from the 
`org.osgi.framework.system.packages` property and make sure we interpolate 
them, but I did not find a good way of doing that.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-8136) Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700401#comment-16700401
 ] 

ASF GitHub Bot commented on SLING-8136:
---

bosschaert commented on issue #11: SLING-8136 - Analyser fails when javax.*, 
org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11#issuecomment-442055861
 
 
   Hi @rombert one thought I have is that it might be an idea to configure the 
packages from the maven plugin configuration rather than hardcoding it? 
Accessing configuration is possible via the 
`AnalyserTaskContext.getConfiguration()` API. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss 
> imports are found
> ---
>
> Key: SLING-8136
> URL: https://issues.apache.org/jira/browse/SLING-8136
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 0.8.2
>
>
> I've tried running the {{slingfeature-maven-plugin}} to analyse imports and 
> exports using the {{bundle-packages}} analyser.
> This seems to work just fine, just that some packages - found in the issue 
> title - are not seen as being provided by the framework. Some errors that pop 
> up are:
> {noformat}
> [ERROR] Bundle oak-auth-ldap:1.9.11 is importing package(s) org.ietf.jgss in 
> start level 0 but no bundle is exporting these for that start level.
> [ERROR] Bundle oak-lucene:1.9.11 is importing package(s) 
> [org.xml.sax.helpers, org.xml.sax] in start level 0 but no bundle is 
> exporting these for that start level.
> {noformat}
> These packages are provided using an {{org.osgi.framework.system.packages}} 
> framework property, so I guess there is some glue missing to make this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] bosschaert commented on issue #11: SLING-8136 - Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

[GitBox]

bosschaert commented on issue #11: SLING-8136 - Analyser fails when javax.*, 
org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: 
https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11#issuecomment-442055861
 
 
   Hi @rombert one thought I have is that it might be an idea to configure the 
packages from the maven plugin configuration rather than hardcoding it? 
Accessing configuration is possible via the 
`AnalyserTaskContext.getConfiguration()` API. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SLING-5648) Make Non-Eclipse Module regular Maven Packages

[Robert Munteanu (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700378#comment-16700378
 ] 

Robert Munteanu commented on SLING-5648:


[~kwin] - sorry, I haven't tried this recently. I will try to set up a fresh 
installation and import.

> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be 
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to 
> support development of it by other IDEs like IntelliJ IDEA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8136) Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700376#comment-16700376
 ] 

ASF GitHub Bot commented on SLING-8136:
---

rombert opened a new pull request #11: SLING-8136 - Analyser fails when 
javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11
 
 
   This is more or less a band-aid, but at least it helps in moving forward 
with using the Analyser tasks.
   
   I'd be happy with a more permanent solution, but I can't seem to find it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss 
> imports are found
> ---
>
> Key: SLING-8136
> URL: https://issues.apache.org/jira/browse/SLING-8136
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Feature Model Analyser 0.8.2
>
>
> I've tried running the {{slingfeature-maven-plugin}} to analyse imports and 
> exports using the {{bundle-packages}} analyser.
> This seems to work just fine, just that some packages - found in the issue 
> title - are not seen as being provided by the framework. Some errors that pop 
> up are:
> {noformat}
> [ERROR] Bundle oak-auth-ldap:1.9.11 is importing package(s) org.ietf.jgss in 
> start level 0 but no bundle is exporting these for that start level.
> [ERROR] Bundle oak-lucene:1.9.11 is importing package(s) 
> [org.xml.sax.helpers, org.xml.sax] in start level 0 but no bundle is 
> exporting these for that start level.
> {noformat}
> These packages are provided using an {{org.osgi.framework.system.packages}} 
> framework property, so I guess there is some glue missing to make this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rombert opened a new pull request #11: SLING-8136 - Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

[GitBox]

rombert opened a new pull request #11: SLING-8136 - Analyser fails when 
javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/11
 
 
   This is more or less a band-aid, but at least it helps in moving forward 
with using the Analyser tasks.
   
   I'd be happy with a more permanent solution, but I can't seem to find it.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Created] (SLING-8136) Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* or org.ietf.jgss imports are found

[Robert Munteanu (JIRA)]

Robert Munteanu created SLING-8136:
--

 Summary: Analyser fails when javax.*, org.xml.sax.*, org.w3c.dom* 
or org.ietf.jgss imports are found
 Key: SLING-8136
 URL: https://issues.apache.org/jira/browse/SLING-8136
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Reporter: Robert Munteanu
 Fix For: Feature Model Analyser 0.8.2


I've tried running the {{slingfeature-maven-plugin}} to analyse imports and 
exports using the {{bundle-packages}} analyser.

This seems to work just fine, just that some packages - found in the issue 
title - are not seen as being provided by the framework. Some errors that pop 
up are:

{noformat}
[ERROR] Bundle oak-auth-ldap:1.9.11 is importing package(s) org.ietf.jgss in 
start level 0 but no bundle is exporting these for that start level.
[ERROR] Bundle oak-lucene:1.9.11 is importing package(s) [org.xml.sax.helpers, 
org.xml.sax] in start level 0 but no bundle is exporting these for that start 
level.
{noformat}

These packages are provided using an {{org.osgi.framework.system.packages}} 
framework property, so I guess there is some glue missing to make this work.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8134) Slingfeature Maven Plugin fails when using external feature as prototype

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-8134.
---
Resolution: Fixed

> Slingfeature Maven Plugin fails when using external feature as prototype
> 
>
> Key: SLING-8134
> URL: https://issues.apache.org/jira/browse/SLING-8134
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 0.8.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: slingfeature-maven-plugin 0.8.2
>
>
> Feature to trigger is simple just reference an external feature:
> {noformat}
> "prototype": {
> "id": ""
> }
> {noformat}
> Looks like this:
> {noformat}
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> Caused by: java.lang.NullPointerException
> at org.apache.sling.feature.maven.ProjectHelper.getOrResolveArtifact 
> (ProjectHelper.java:238)
> at org.apache.sling.feature.maven.Preprocessor$1.provide 
> (Preprocessor.java:477)
> at org.apache.sling.feature.builder.FeatureBuilder.internalAssemble 
> (FeatureBuilder.java:315)
> at org.apache.sling.feature.builder.FeatureBuilder.assemble 
> (FeatureBuilder.java:59)
> at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:214)
> at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:116)
> at 
> org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead
>  (DependencyLifecycleParticipant.java:79)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8133) Feature IO doesn't allow for bundles with same ID and different versions.

[David Bosschaert (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Bosschaert resolved SLING-8133.
-
Resolution: Fixed

Fixed in 
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-feature-io.git;a=commitdiff;h=ded139b9ec1434e6f0e7f59c8c628ddfbf982ba3

> Feature IO doesn't allow for bundles with same ID and different versions.
> -
>
> Key: SLING-8133
> URL: https://issues.apache.org/jira/browse/SLING-8133
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model IO 0.8.0
>Reporter: Karl Pauls
>Assignee: David Bosschaert
>Priority: Major
> Fix For: Feature Model IO 0.8.2
>
>
> Caused by: java.io.IOException: Duplicate bundle 
> org.apache.commons:commons-lang3:3.6
>   at 
> org.apache.sling.feature.io.json.JSONReaderBase.readBundles(JSONReaderBase.java:202)
>   at 
> org.apache.sling.feature.io.json.FeatureJSONReader.readFeature(FeatureJSONReader.java:97)
>   at 
> org.apache.sling.feature.io.json.FeatureJSONReader.read(FeatureJSONReader.java:49)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8135) FeatureBuilder NPE when removing bundle from prototype

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls resolved SLING-8135.
---
Resolution: Fixed

> FeatureBuilder NPE when removing bundle from prototype
> --
>
> Key: SLING-8135
> URL: https://issues.apache.org/jira/browse/SLING-8135
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model 0.8.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: Feature Model 0.8.2
>
>
> When removing a bundle from a prototype that has configurations you get:
> {noformat}
> Caused by: java.lang.NullPointerException
> at org.apache.sling.feature.ArtifactId.fromMvnId (ArtifactId.java:164)
> at org.apache.sling.feature.builder.FeatureBuilder.processPrototype 
> (FeatureBuilder.java:397)
> at org.apache.sling.feature.builder.FeatureBuilder.internalAssemble 
> (FeatureBuilder.java:326)
> at org.apache.sling.feature.builder.FeatureBuilder.assemble 
> (FeatureBuilder.java:59)
> at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:214)
> at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:116)
> at 
> org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead
>  (DependencyLifecycleParticipant.java:79)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8135) FeatureBuilder NPE when removing bundle from prototype

[Karl Pauls (JIRA)]

Karl Pauls created SLING-8135:
-

 Summary: FeatureBuilder NPE when removing bundle from prototype
 Key: SLING-8135
 URL: https://issues.apache.org/jira/browse/SLING-8135
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: Feature Model 0.8.0
Reporter: Karl Pauls
Assignee: Karl Pauls
 Fix For: Feature Model 0.8.2


When removing a bundle from a prototype that has configurations you get:

{noformat}
Caused by: java.lang.NullPointerException
at org.apache.sling.feature.ArtifactId.fromMvnId (ArtifactId.java:164)
at org.apache.sling.feature.builder.FeatureBuilder.processPrototype 
(FeatureBuilder.java:397)
at org.apache.sling.feature.builder.FeatureBuilder.internalAssemble 
(FeatureBuilder.java:326)
at org.apache.sling.feature.builder.FeatureBuilder.assemble 
(FeatureBuilder.java:59)
at org.apache.sling.feature.maven.Preprocessor.process 
(Preprocessor.java:214)
at org.apache.sling.feature.maven.Preprocessor.process 
(Preprocessor.java:116)
at 
org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead
 (DependencyLifecycleParticipant.java:79)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-8134) Slingfeature Maven Plugin fails when using external feature as prototype

[Karl Pauls (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Pauls reassigned SLING-8134:
-

Assignee: Karl Pauls  (was: David Bosschaert)

> Slingfeature Maven Plugin fails when using external feature as prototype
> 
>
> Key: SLING-8134
> URL: https://issues.apache.org/jira/browse/SLING-8134
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: slingfeature-maven-plugin 0.8.0
>Reporter: Karl Pauls
>Assignee: Karl Pauls
>Priority: Major
> Fix For: slingfeature-maven-plugin 0.8.2
>
>
> Feature to trigger is simple just reference an external feature:
> {noformat}
> "prototype": {
> "id": ""
> }
> {noformat}
> Looks like this:
> {noformat}
> org.apache.maven.InternalErrorException: Internal error: 
> java.lang.NullPointerException
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> Caused by: java.lang.NullPointerException
> at org.apache.sling.feature.maven.ProjectHelper.getOrResolveArtifact 
> (ProjectHelper.java:238)
> at org.apache.sling.feature.maven.Preprocessor$1.provide 
> (Preprocessor.java:477)
> at org.apache.sling.feature.builder.FeatureBuilder.internalAssemble 
> (FeatureBuilder.java:315)
> at org.apache.sling.feature.builder.FeatureBuilder.assemble 
> (FeatureBuilder.java:59)
> at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:214)
> at org.apache.sling.feature.maven.Preprocessor.process 
> (Preprocessor.java:116)
> at 
> org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead
>  (DependencyLifecycleParticipant.java:79)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:229)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:415)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:356)
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8134) Slingfeature Maven Plugin fails when using external feature as prototype

[Karl Pauls (JIRA)]

Karl Pauls created SLING-8134:
-

 Summary: Slingfeature Maven Plugin fails when using external 
feature as prototype
 Key: SLING-8134
 URL: https://issues.apache.org/jira/browse/SLING-8134
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: slingfeature-maven-plugin 0.8.0
Reporter: Karl Pauls
Assignee: David Bosschaert
 Fix For: slingfeature-maven-plugin 0.8.2


Feature to trigger is simple just reference an external feature:


{noformat}
"prototype": {
"id": ""
}
{noformat}


Looks like this:

{noformat}
org.apache.maven.InternalErrorException: Internal error: 
java.lang.NullPointerException
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
Caused by: java.lang.NullPointerException
at org.apache.sling.feature.maven.ProjectHelper.getOrResolveArtifact 
(ProjectHelper.java:238)
at org.apache.sling.feature.maven.Preprocessor$1.provide 
(Preprocessor.java:477)
at org.apache.sling.feature.builder.FeatureBuilder.internalAssemble 
(FeatureBuilder.java:315)
at org.apache.sling.feature.builder.FeatureBuilder.assemble 
(FeatureBuilder.java:59)
at org.apache.sling.feature.maven.Preprocessor.process 
(Preprocessor.java:214)
at org.apache.sling.feature.maven.Preprocessor.process 
(Preprocessor.java:116)
at 
org.apache.sling.feature.maven.mojos.DependencyLifecycleParticipant.afterProjectsRead
 (DependencyLifecycleParticipant.java:79)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:264)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
(Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main 
(Launcher.java:356)
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8133) Feature IO doesn't allow for bundles with same ID and different versions.

[Karl Pauls (JIRA)]

Karl Pauls created SLING-8133:
-

 Summary: Feature IO doesn't allow for bundles with same ID and 
different versions.
 Key: SLING-8133
 URL: https://issues.apache.org/jira/browse/SLING-8133
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: Feature Model IO 0.8.0
Reporter: Karl Pauls
Assignee: David Bosschaert
 Fix For: Feature Model IO 0.8.2


Caused by: java.io.IOException: Duplicate bundle 
org.apache.commons:commons-lang3:3.6
at 
org.apache.sling.feature.io.json.JSONReaderBase.readBundles(JSONReaderBase.java:202)
at 
org.apache.sling.feature.io.json.FeatureJSONReader.readFeature(FeatureJSONReader.java:97)
at 
org.apache.sling.feature.io.json.FeatureJSONReader.read(FeatureJSONReader.java:49)




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-5648) Make Non-Eclipse Module regular Maven Packages

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus reassigned SLING-5648:
--

Assignee: Konrad Windszus  (was: Robert Munteanu)

> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be 
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to 
> support development of it by other IDEs like IntelliJ IDEA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Issue Comment Deleted] (SLING-5648) Make Non-Eclipse Module regular Maven Packages

[Konrad Windszus (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated SLING-5648:
---
Comment: was deleted

(was: The problem is most probably a visibility issue: bnd-maven-plugin does 
not notify the Eclipse workspace about its changes: 
https://github.com/bndtools/bnd/issues/2746.)

> Make Non-Eclipse Module regular Maven Packages
> --
>
> Key: SLING-5648
> URL: https://issues.apache.org/jira/browse/SLING-5648
> Project: Sling
>  Issue Type: Improvement
>  Components: IDE
>Affects Versions: Sling Eclipse IDE 1.0.10
>Reporter: Andreas Schaefer
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Sling Eclipse IDE 1.2.4
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Non Eclipse modules like api, artifacts, imll-resource, impl-vlt should be 
> regular Maven packages (jar) instead of eclipse plugins (eclipse-plugin) to 
> support development of it by other IDEs like IntelliJ IDEA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] trekawek commented on a change in pull request #21: Implement missing launchpad services.

[GitBox]

trekawek commented on a change in pull request #21: Implement missing launchpad 
services.
URL: https://github.com/apache/sling-whiteboard/pull/21#discussion_r236573821
 
 

 ##
 File path: 
startupmanager/src/main/java/org/apache/sling/launchpad/startupmanager/StartUpHandlerImpl.java
 ##
 @@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.launchpad.startupmanager;
+
+import org.apache.sling.launchpad.api.StartupHandler;
+import org.apache.sling.launchpad.api.StartupMode;
+import org.osgi.framework.Bundle;
+import org.osgi.framework.ServiceFactory;
+
+public class StartUpHandlerImpl implements StartupHandler
+{
+private final Bundle framework;
+
+public StartUpHandlerImpl(Bundle bundle)
+{
+framework = bundle;
+}
+
+@Override
+public StartupMode getMode()
+{
+return StartupMode.RESTART;
+}
+
+@Override
+public boolean isFinished()
+{
+return framework.getState() == Bundle.ACTIVE;
 
 Review comment:
   I didn't notice that it's bundle "0". Thanks for the explanation!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: [HEADS-UP] New repository for org.apache.sling.launchpad.startupmanager

[Bertrand Delacretaz]

Hi,

On Tue, Nov 27, 2018 at 9:34 AM Karl Pauls  wrote:
> ...I think I'll call it:
> sling-org-apache-sling-launchpad-startupmanager ..

That works for me and maybe at the same time you can add some info to
the README about what that module does ;-)

-Bertrand

[HEADS-UP] New repository for org.apache.sling.launchpad.startupmanager

[Karl Pauls]

All,

I'm going to create a new repository for the
org.apache.sling.launchpad.startupmanager currently in the whiteboard
at:

https://github.com/apache/sling-whiteboard/tree/master/startupmanager

I think I'll call it:

sling-org-apache-sling-launchpad-startupmanager

Since renaming repositories requires ASF infra manual intervention I
just want to make sure nobody has an objection about the names.

In other words, if you have a claim about the names speak now.

regards,

Karl

-- 
Karl Pauls
karlpa...@gmail.com

[GitHub] karlpauls closed pull request #21: Implement missing launchpad services.

[GitBox]

karlpauls closed pull request #21: Implement missing launchpad services.
URL: https://github.com/apache/sling-whiteboard/pull/21
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services