Re: [DISCUSSION] RepoInit Release
I think it's fine to move, however it seems SLING-6423 is partially committed, so this might need some attention before a release (either roleback or finish the work or maybe it's not affecting anything) Regards Carsten Daniel Klco wrote All, I'd like to release org.apache.sling.repoinit.parser and org.apache.sling/org.apache.sling.jcr.repoinit to provide support for specifying groups in repoinit files, however, it appears there are a few seemingly stalled issues which have not had any progress in some time, would anyone be opposed to simply moving these issues to the next release? The issues in question are: https://issues.apache.org/jira/browse/SLING-7147 https://issues.apache.org/jira/browse/SLING-7143 https://issues.apache.org/jira/browse/SLING-6423 Thanks, Dan -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[DISCUSSION] RepoInit Release
All, I'd like to release org.apache.sling.repoinit.parser and org.apache.sling/org.apache.sling.jcr.repoinit to provide support for specifying groups in repoinit files, however, it appears there are a few seemingly stalled issues which have not had any progress in some time, would anyone be opposed to simply moving these issues to the next release? The issues in question are: https://issues.apache.org/jira/browse/SLING-7147 https://issues.apache.org/jira/browse/SLING-7143 https://issues.apache.org/jira/browse/SLING-6423 Thanks, Dan
Re: [DISCUSS] Create new sling repo for org.apache.sling.cli
On Mon, 2019-04-01 at 14:58 +0200, Robert Munteanu wrote: > On Mon, 2019-04-01 at 12:04 +0200, Julian Sedding wrote: > > I agree with Bertrand that "org-apache-sling-cli" is too generic > > and > > may even be misleading for users of Sling. > > > > What about "org-apache-sling-committer-cli"? That makes it explicit > > that the tool is not generally useful, but only for committers of > > Sling? > > I think that's a good compromise, so I propose that we go with > > org-apache-sling-committer-cli > > unless someone has another suggestion. Remembers to create the repository, https://github.com/apache/sling-org-apache-sling-committer-cli is now live. Thanks, Robert
Re: Creating a configuration during startup (was Re: [DISCUSS] Consolidate starter-startup and startupfilter/startupfilter-disabler to use Apache Felix HC ServiceUnavailableFilter)
On Tue, 2019-04-16 at 08:19 +0200, Georg Henzler wrote: > My proposal: We change the provisioning model in a way that all > mentioned configurations become active exactly with the start level > of > org.apache.felix.configadmin. As this is the case from second startup > on > anyway, I suppose there is a very low risk of regressions (I created > [2] > for that.). The same probably has to be changed for the new feature > model (I haven't looked into that yet). +1 Robert
[jira] [Created] (SLING-8356) Increase service.ranking of ResourceTypeBasedResourcePicker
Konrad Windszus created SLING-8356:
--
Summary: Increase service.ranking of
ResourceTypeBasedResourcePicker
Key: SLING-8356
URL: https://issues.apache.org/jira/browse/SLING-8356
Project: Sling
Issue Type: Improvement
Components: Extensions
Affects Versions: Sling Models Impl 1.4.10
Reporter: Konrad Windszus
Fix For: Sling Models Impl 1.4.12
Currently the {{ResourceTypeBasedResourcePicker}}
(https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/ResourceTypeBasedResourcePicker.java#L34)
is always the 2nd last picker and the {{FirstImplementationPicker}}
(https://github.com/apache/sling-org-apache-sling-models-impl/blob/master/src/main/java/org/apache/sling/models/impl/FirstImplementationPicker.java#L36)
is the last picker.
In some cases you are interested to place pickers in between (compare with
https://github.com/adobe/aem-core-wcm-components/issues/546), therefore I would
propose to set the {{service.ranking}} of {{ResourceTypeBasedResourcePicker}}
to {{(Integer.MAX_VALUE - 1000)}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #107 is FIXED
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/107/ for details. No further emails will be sent until the status of the build is changed.
[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #106 is BROKEN
/org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.RequestUriOptingServletTest.log [DEBUG] - excluded target/surefire-reports/org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest.log [DEBUG] - excluded target/surefire-reports/org.apache.sling.launchpad.webapp.integrationtest.DavExIntegrationTest.log [DEBUG] - excluded target/surefire-reports/org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.SelectorServletTest.log [DEBUG] - excluded target/surefire-reports/org.apache.sling.launchpad.webapp.integrationtest.scripting.SlingJSPTaglibTest.log [DEBUG] - excluded target/surefire-reports/org.apache.sling.launchpad.webapp.integrationtest.WebdavOptionsTest.log [DEBUG] - excluded .sling-module.json [DEBUG] - excluded .gitignore [DEBUG] - excluded .git/HEAD [DEBUG] - excluded .git/index [DEBUG] - excluded .git/FETCH_HEAD [DEBUG] - excluded .git/config [DEBUG] - excluded .git/objects/pack/pack-17fca67f52de3bd3b2ec962a7fbf0dfabd111f83.pack [DEBUG] - excluded .git/objects/pack/pack-17fca67f52de3bd3b2ec962a7fbf0dfabd111f83.idx [DEBUG] - excluded .git/info/exclude [DEBUG] - excluded .git/logs/HEAD [DEBUG] - excluded .git/logs/refs/remotes/origin/master [DEBUG] - excluded .git/description [DEBUG] - excluded .git/hooks/applypatch-msg.sample [DEBUG] - excluded .git/hooks/pre-applypatch.sample [DEBUG] - excluded .git/hooks/post-update.sample [DEBUG] - excluded .git/hooks/pre-rebase.sample [DEBUG] - excluded .git/hooks/commit-msg.sample [DEBUG] - excluded .git/hooks/pre-push.sample [DEBUG] - excluded .git/hooks/update.sample [DEBUG] - excluded .git/hooks/prepare-commit-msg.sample [DEBUG] - excluded .git/hooks/pre-commit.sample [DEBUG] - excluded .git/refs/remotes/origin/master [INFO] 7 resources included (use -debug for more details) [DEBUG] - included src/main/provisioning/model.txt [DEBUG] - included src/test/resources/logback-test.xml [DEBUG] - included Jenkinsfile [DEBUG] - included LICENSE [DEBUG] - included pom.xml [DEBUG] - included CODE_OF_CONDUCT.md [DEBUG] - included CONTRIBUTING.md [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 6 licence. [INFO] [INFO] --- maven-failsafe-plugin:2.21.0:verify (default) @ org.apache.sling.launchpad.testing --- [DEBUG] Configuring mojo org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify from plugin realm ClassRealm[plugin>org.apache.maven.plugins:maven-failsafe-plugin:2.21.0, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@5387f9e0] [DEBUG] Configuring mojo 'org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify' with basic configurator --> [DEBUG] (s) basedir = /home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master [DEBUG] (f) encoding = UTF-8 [DEBUG] (s) reportsDirectory = /home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master/target/failsafe-reports [DEBUG] (s) skip = false [DEBUG] (f) summaryFile = /home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master/target/failsafe-reports/failsafe-summary.xml [DEBUG] (s) testClassesDirectory = /home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master/target/test-classes [DEBUG] (s) testFailureIgnore = false [DEBUG] (f) session = org.apache.maven.execution.MavenSession@320be73 [DEBUG] -- end configuration -- [DEBUG] Failsafe report directory: /home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master/target/failsafe-reports [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 03:35 min [INFO] Finished at: 2019-04-16T12:40:06Z [INFO] [INFO] [jenkins-event-spy] Generated /home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master@tmp/withMavenb101a4a5/maven-spy-20190416-123630-905180804741893387345.log [ERROR] Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on project org.apache.sling.launchpad.testing: There are test failures. [ERROR] [ERROR] Please refer to /home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master/target/failsafe-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N].dumpstream. [ERROR] -> [Help 1] org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify (default) on project org.apache.sling.launchpad.testing: There are test failures. Please refer to /home/jenkins/jenkins-slave/workspace/e-sling-launchpad-testing_master/target/failsafe-reports for the individual test results. Please refer to dump files (if any exist) [date]-jvmRun[N].dump, [date].dumpstream and [date]-jvmRun[N]
Re: [VOTE] Release Apache Sling Resource Resolver 1.6.12
+1 On Tue, Apr 16, 2019 at 7:47 AM Robert Munteanu wrote: > On Mon, 2019-04-15 at 15:57 +0200, Karl Pauls wrote: > > Please vote to approve these releases: > > +1 > > Robert >
[jira] [Commented] (SLING-8262) Add SonarQube analysis to Jenkins jobs
[
https://issues.apache.org/jira/browse/SLING-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818937#comment-16818937
]
Robert Munteanu commented on SLING-8262:
Thanks [~bellingard] . ISTR that last time the {{sling}} tag was not set on all
projects, just on {{sling-whiteboard}}. Or maybe that was me :-) But it will do
for now, thanks!
> Add SonarQube analysis to Jenkins jobs
> --
>
> Key: SLING-8262
> URL: https://issues.apache.org/jira/browse/SLING-8262
> Project: Sling
> Issue Type: Improvement
> Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: screenshot-1.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> With the pipeline jobs it becomes simple to run a SonarQube analysis ( see
> https://cwiki.apache.org/confluence/display/INFRA/Multibranch+Pipeline+recipies
> ) so let's do that.
> We should also look if this can be done for pull requests.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SLING-8262) Add SonarQube analysis to Jenkins jobs
[ https://issues.apache.org/jira/browse/SLING-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758292#comment-16758292 ] Robert Munteanu edited comment on SLING-8262 at 4/16/19 12:07 PM: -- *Current status*: * enable SonarCloud analysis for branches and PRs (/) * create shared filter in SonarCloud (/) - https://sonarcloud.io/organizations/apache/projects?sort=-analysis_date&tags=sling * enable SonarQube analysis on pull requests (/) - but see INFRA-18219, some PR builds are not triggered * document onboarding to SonarCloud (x) * document including new admins to SonarCloud (x) * configure Sling-specific quality gate that applies to all Sling projects (?) * configure Sling-specific quality profile that applies to all Sling projects (?) was (Author: rombert): *Current status*: * enable SonarCloud analysis for branches and PRs (/) * create shared filter in SonarCloud (x) * enable SonarQube analysis on pull requests (/) - but see INFRA-18219, some PR builds are not triggered * document onboarding to SonarCloud (x) * document including new admins to SonarCloud (x) * configure Sling-specific quality gate that applies to all Sling projects (?) * configure Sling-specific quality profile that applies to all Sling projects (?) > Add SonarQube analysis to Jenkins jobs > -- > > Key: SLING-8262 > URL: https://issues.apache.org/jira/browse/SLING-8262 > Project: Sling > Issue Type: Improvement > Components: Build and Source Control >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 1h 20m > Remaining Estimate: 0h > > With the pipeline jobs it becomes simple to run a SonarQube analysis ( see > https://cwiki.apache.org/confluence/display/INFRA/Multibranch+Pipeline+recipies > ) so let's do that. > We should also look if this can be done for pull requests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: Repository names for Journal based Sling Content Distribution
On Mon, 2019-04-15 at 11:49 +0300, Robert Munteanu wrote: > On Thu, 2019-04-04 at 22:52 +0200, Timothee Maret wrote: > > The repository names derived from the package names and taking > > conventions > > into account would be the following > > > > sling-org-apache-sling-distribution-journal > > sling-org-apache-sling-distribution-journal-messages > > sling-org-apache-sling-distribution-journal-kafka > > sling-org-apache-sling-distribution-journal-it > > Unless anyone has a different proposal I will create the repositories > as proposed by Timothee tomorrow. I have created the repositories https://github.com/apache/sling-org-apache-sling-distribution-journal https://github.com/apache/sling-org-apache-sling-distribution-journal-messages https://github.com/apache/sling-org-apache-sling-distribution-journal-kafka https://github.com/apache/sling-org-apache-sling-distribution-journal-it They are still empty and probably waiting for the GitHub perms to sync. Timothee, feel free to push the changes and please also add the 'boilerplate' stuff described at https://cwiki.apache.org/confluence/display/SLING/Using+Git+with+Sling#UsingGitwithSling-Boilerplatefiles Thanks! Robert
Re: [VOTE] Release Apache Sling Resource Resolver 1.6.12
On Mon, 2019-04-15 at 15:57 +0200, Karl Pauls wrote: > Please vote to approve these releases: +1 Robert signature.asc Description: This is a digitally signed message part
[jira] [Updated] (SLING-8353) Change embedded ESAPI version in sling.xss
[ https://issues.apache.org/jira/browse/SLING-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu updated SLING-8353: Fix Version/s: XSS Protection API 2.1.8 > Change embedded ESAPI version in sling.xss > -- > > Key: SLING-8353 > URL: https://issues.apache.org/jira/browse/SLING-8353 > Project: Sling > Issue Type: Bug > Components: XSS Protection API >Affects Versions: XSS Protection API 2.1.6 >Reporter: Ashok Kumar >Assignee: Radu Cotescu >Priority: Major > Fix For: XSS Protection API 2.1.8 > > Time Spent: 10m > Remaining Estimate: 0h > > org.apache.sling.xss embeds esapi 2.1.0. It would be good if we update this > to 2.1.0.1 atleast, which would bring more security fixes and still remains > backward compatible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SLING-8353) Change embedded ESAPI version in sling.xss
[ https://issues.apache.org/jira/browse/SLING-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reassigned SLING-8353: --- Assignee: Radu Cotescu > Change embedded ESAPI version in sling.xss > -- > > Key: SLING-8353 > URL: https://issues.apache.org/jira/browse/SLING-8353 > Project: Sling > Issue Type: Bug > Components: XSS Protection API >Affects Versions: XSS Protection API 2.1.6 >Reporter: Ashok Kumar >Assignee: Radu Cotescu >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > org.apache.sling.xss embeds esapi 2.1.0. It would be good if we update this > to 2.1.0.1 atleast, which would bring more security fixes and still remains > backward compatible. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SLING-8262) Add SonarQube analysis to Jenkins jobs
[ https://issues.apache.org/jira/browse/SLING-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818745#comment-16818745 ] Fabrice Bellingard commented on SLING-8262: --- [~rombert] The equivalent of this can be achieved using project tags: [https://sonarcloud.io/organizations/apache/projects?sort=-analysis_date&tags=sling]. To get this, I selected the "sling" tag (available in the "tags" facet on the left). Note that you need to bookmark this URL, since there is no way to "save" this filter in SonarCloud. > Add SonarQube analysis to Jenkins jobs > -- > > Key: SLING-8262 > URL: https://issues.apache.org/jira/browse/SLING-8262 > Project: Sling > Issue Type: Improvement > Components: Build and Source Control >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Attachments: screenshot-1.png > > Time Spent: 1h 20m > Remaining Estimate: 0h > > With the pipeline jobs it becomes simple to run a SonarQube analysis ( see > https://cwiki.apache.org/confluence/display/INFRA/Multibranch+Pipeline+recipies > ) so let's do that. > We should also look if this can be done for pull requests. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
