Feature Model Based Sling Launchpad

2019-04-18 Thread Andreas Schaefer
Hi

Since a few days I try to make Sling Launchpad starting from a Feature Model of 
the Sling Starter kit.

After I converted all the provisioning files to a FM I wanted launch it but 
that does failed due to javax dependency issues.

Eventually I found a solution by adding all the necessary packages to 
org.osgi.framework.system.packages.extra property and that works to most part 
except for exporting javax.xml.stream.

When comparing the FM to the Provisioning Model bundles then I see that in the 
PM bundle 0: org.apache.felix.framework is exporting many javax packages but 
not in the FM launch.

Is there a flag to make this happening?

Thanks - Andy Schaefer

[jira] [Resolved] (SLING-8365) Add unit test for JournalAvailableChecker

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-8365.
---
Resolution: Fixed

> Add unit test for JournalAvailableChecker 
> --
>
> Key: SLING-8365
> URL: https://issues.apache.org/jira/browse/SLING-8365
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> Add unit test coverage to {{JournalAvailableChecker}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8365) Add unit test for JournalAvailableChecker

2019-04-18 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-8365:
-

 Summary: Add unit test for JournalAvailableChecker 
 Key: SLING-8365
 URL: https://issues.apache.org/jira/browse/SLING-8365
 Project: Sling
  Issue Type: Improvement
  Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret
 Fix For: Content Distribution Journal Core 0.1.0


Add unit test coverage to {{JournalAvailableChecker}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8353) Change embedded ESAPI version in sling.xss

2019-04-18 Thread Radu Cotescu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-8353.
-
Resolution: Fixed

Fixed in [commit 
9a04848|https://github.com/apache/sling-org-apache-sling-xss/commit/9a04848] 
and [commit 
458d454|https://github.com/apache/sling-org-apache-sling-xss/commit/458d454].

> Change embedded ESAPI version in sling.xss
> --
>
> Key: SLING-8353
> URL: https://issues.apache.org/jira/browse/SLING-8353
> Project: Sling
>  Issue Type: Bug
>  Components: XSS Protection API
>Affects Versions: XSS Protection API 2.1.6
>Reporter: Ashok Kumar
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: XSS Protection API 2.1.8
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> org.apache.sling.xss embeds esapi 2.1.0. It would be good if we update this 
> to 2.1.0.1 atleast, which would bring more security fixes and still remains 
> backward compatible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


JAX-RS integration

2019-04-18 Thread Patrique Legault
Just out of curiosity will OSGi annotations used within Apache Sling integrate 
with JAX-RS annotations in order to create multiple POST/PUT/DELETE or GET 
endpoints within the same servlet?

I believe this would give the server even more flexibility whern creating CRUD 
operations. Allowing developers to create variations of endpoints with function 
overloading instead of using if-statements within the request object to check 
to see if parameters are there or not.

I believe OSGi annotations are going to support JAX-RS annotations in the near 
future, thus I am wondering if that is something that Sling is looking to 
integrate into the server.

Cheers,


Pat Legault, BSc, MEBT
Senior Developer

Faculté de Génie/Faculty of Engineering
Université d'Ottawa/University of Ottawa
161 Louis-Pasteur
Ottawa, ON
K1N 6N5
Tel: 613-562-5800 ext 3747
LinkedIn: https://www.linkedin.com/in/patrique-legault


JRT Protocol Issue

2019-04-18 Thread Patrique Legault
I am wondering if any of the developers have seen this issue?

It is preventing us from logging into Composum and it seems to be with respect 
to the Eclipse Java Compiler within the Sling Compiler Bundle. We are running 
OpenJDK 11 in a docker container and we receive a unknown protocol JRT error.

Attached is a gist to the issue.

Any help would be appreciated.

https://gist.github.com/pat-lego/671bd9b3eb56f866bc2a73f2d11195d7

Cheers,


Pat Legault, BSc, MEBT
Senior Developer

Faculté de Génie/Faculty of Engineering
Université d'Ottawa/University of Ottawa
161 Louis-Pasteur
Ottawa, ON
K1N 6N5
Tel: 613-562-5800 ext 3747
LinkedIn: https://www.linkedin.com/in/patrique-legault


[jira] [Resolved] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-8357.
---
Resolution: Fixed

> Activate Journal based Sling Content Distribution projects on SonarCloud
> 
>
> Key: SLING-8357
> URL: https://issues.apache.org/jira/browse/SLING-8357
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
> Distribution projects. The repositories are listed below
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>   
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal 
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
> (default-cli) on project org.apache.sling.distribution.journal.messages: 
> You're not authorized to run analysis. Please contact the project 
> administrator. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Timothee Maret (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821252#comment-16821252
 ] 

Timothee Maret commented on SLING-8357:
---

So much green, thanks [~bellingard]!

> Activate Journal based Sling Content Distribution projects on SonarCloud
> 
>
> Key: SLING-8357
> URL: https://issues.apache.org/jira/browse/SLING-8357
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
> Distribution projects. The repositories are listed below
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>   
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal 
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
> (default-cli) on project org.apache.sling.distribution.journal.messages: 
> You're not authorized to run analysis. Please contact the project 
> administrator. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8262) Add SonarQube analysis to Jenkins jobs

2019-04-18 Thread Fabrice Bellingard (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821236#comment-16821236
 ] 

Fabrice Bellingard commented on SLING-8262:
---

My pleasure [~rombert]!

> Add SonarQube analysis to Jenkins jobs
> --
>
> Key: SLING-8262
> URL: https://issues.apache.org/jira/browse/SLING-8262
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: screenshot-1.png
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With the pipeline jobs it becomes simple to run a SonarQube analysis ( see 
> https://cwiki.apache.org/confluence/display/INFRA/Multibranch+Pipeline+recipies
>  ) so let's do that.
> We should also look if this can be done for pull requests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Fabrice Bellingard (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821233#comment-16821233
 ] 

Fabrice Bellingard commented on SLING-8357:
---

[~rombert] & [~marett] Done for the 4 repositories. Enjoy!

> Activate Journal based Sling Content Distribution projects on SonarCloud
> 
>
> Key: SLING-8357
> URL: https://issues.apache.org/jira/browse/SLING-8357
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
> Distribution projects. The repositories are listed below
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>   
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal 
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
> (default-cli) on project org.apache.sling.distribution.journal.messages: 
> You're not authorized to run analysis. Please contact the project 
> administrator. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8360) Move Journal messaging API to messages bundle

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-8360.
---
Resolution: Fixed

> Move Journal messaging API to messages bundle
> -
>
> Key: SLING-8360
> URL: https://issues.apache.org/jira/browse/SLING-8360
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0, Content 
> Distribution Journal Messages 0.1.0
>
>
> The Journal messaging API exported as 
> {{org.apache.sling.distribution.journal}} the package is currently contained 
> in the 
> [sling-org-apache-sling-distribution-journal|https://github.com/apache/sling-org-apache-sling-distribution-journal]
>  bundle. To reduce dependency tree we should move the API (same 
> package/version) to the 
> [sling-org-apache-sling-distribution-journal-messages|https://github.com/apache/sling-org-apache-sling-distribution-journal-messages]
>  bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8360) Move Journal messaging API to messages bundle

2019-04-18 Thread Timothee Maret (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821225#comment-16821225
 ] 

Timothee Maret commented on SLING-8360:
---

Done.

> Move Journal messaging API to messages bundle
> -
>
> Key: SLING-8360
> URL: https://issues.apache.org/jira/browse/SLING-8360
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0, Content 
> Distribution Journal Messages 0.1.0
>
>
> The Journal messaging API exported as 
> {{org.apache.sling.distribution.journal}} the package is currently contained 
> in the 
> [sling-org-apache-sling-distribution-journal|https://github.com/apache/sling-org-apache-sling-distribution-journal]
>  bundle. To reduce dependency tree we should move the API (same 
> package/version) to the 
> [sling-org-apache-sling-distribution-journal-messages|https://github.com/apache/sling-org-apache-sling-distribution-journal-messages]
>  bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [sling-org-apache-sling-xss] raducotescu merged pull request #6: SLING-8353 Change embedded ESAPI version in sling.xss

2019-04-18 Thread GitBox
raducotescu merged pull request #6: SLING-8353 Change embedded ESAPI version in 
sling.xss
URL: https://github.com/apache/sling-org-apache-sling-xss/pull/6
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #109 is FIXED

2019-04-18 Thread Apache Jenkins Server
Please see 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/109/
 for details.

No further emails will be sent until the status of the build is changed.

[jira] [Created] (SLING-8364) Support releases with multiple artifacts

2019-04-18 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-8364:
--

 Summary: Support releases with multiple artifacts
 Key: SLING-8364
 URL: https://issues.apache.org/jira/browse/SLING-8364
 Project: Sling
  Issue Type: Bug
  Components: Tooling
Reporter: Robert Munteanu
Assignee: Robert Munteanu
 Fix For: CLI 1.0.0


With a recent release which includes two artifacts

{noformat}orgapachesling-2067   Apache Sling Parent 35, Apache Sling Bundle 
Parent 35{noformat}

The commands fail, e.g.

{noformat}Failed running command
java.lang.NullPointerException: null
at java.base/java.util.regex.Matcher.getTextLength(Unknown Source)
at java.base/java.util.regex.Matcher.reset(Unknown Source)
at java.base/java.util.regex.Matcher.(Unknown Source)
at java.base/java.util.regex.Pattern.matcher(Unknown Source)
at org.apache.sling.cli.impl.release.Release.fromString(Release.java:37)
at 
org.apache.sling.cli.impl.jira.VersionFinder.findVersion(VersionFinder.java:61)
at 
org.apache.sling.cli.impl.jira.VersionFinder.find(VersionFinder.java:42)
at 
org.apache.sling.cli.impl.release.PrepareVoteEmailCommand.execute(PrepareVoteEmailCommand.java:85)
at 
org.apache.sling.cli.impl.CommandProcessor.runCommand(CommandProcessor.java:66)
at 
org.apache.sling.cli.impl.ExecutionTrigger.lambda$activate$0(ExecutionTrigger.java:33)
at java.base/java.lang.Thread.run(Unknown Source){noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-7534) Release policy - stop providing MD5 and start providing SHA-512 signatures

2019-04-18 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-7534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-7534:
---
Fix Version/s: (was: Parent 35)
   Parent 36

> Release policy - stop providing MD5 and start providing SHA-512 signatures
> --
>
> Key: SLING-7534
> URL: https://issues.apache.org/jira/browse/SLING-7534
> Project: Sling
>  Issue Type: Task
>  Components: Tooling
>Reporter: Robert Munteanu
>Priority: Major
> Fix For: Parent 36
>
>
> See http://www.apache.org/dev/release-distribution#sigs-and-sums , we SHOULD 
> no longer provide MD5 checksums for new releases.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [sling-org-apache-sling-xss] rombert commented on issue #6: SLING-8353 Change embedded ESAPI version in sling.xss

2019-04-18 Thread GitBox
rombert commented on issue #6: SLING-8353 Change embedded ESAPI version in 
sling.xss
URL: 
https://github.com/apache/sling-org-apache-sling-xss/pull/6#issuecomment-484513600
 
 
   Ack, thanks. I missed looking at the issue in Jira.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (SLING-8363) [cp2fm] map rep:SystemUser JCR nodes to repoinit Feature extension

2019-04-18 Thread Simone Tripodi (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821084#comment-16821084
 ] 

Simone Tripodi commented on SLING-8363:
---

Initial impl provided on 
[677c411|https://github.com/apache/sling-org-apache-sling-feature-cpconverter/commit/677c41117e09feb596532e7524aac8aeb932892a]

> [cp2fm] map rep:SystemUser JCR nodes to repoinit Feature extension
> --
>
> Key: SLING-8363
> URL: https://issues.apache.org/jira/browse/SLING-8363
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model, Maven Plugins and Archetypes
>Reporter: Simone Tripodi
>Assignee: Simone Tripodi
>Priority: Major
>
> As per summary, a JCR {{rep:SystemUser}} node, such as
> {noformat}
> http://www.jcp.org/jcr/1.0"; xmlns:rep="internal"
>   jcr:primaryType="rep:SystemUser"
>   rep:authorizableId="asd"
>   rep:principalName="asd"/>
> {noformat}
> has to be mapped to the {{repoinit}} Feature Model extension:
> {noformat}
> "repoinit:TEXT|true":[
>   "create service user asd"
> ]
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [sling-org-apache-sling-xss] raducotescu commented on issue #6: SLING-8353 Change embedded ESAPI version in sling.xss

2019-04-18 Thread GitBox
raducotescu commented on issue #6: SLING-8353 Change embedded ESAPI version in 
sling.xss
URL: 
https://github.com/apache/sling-org-apache-sling-xss/pull/6#issuecomment-484499842
 
 
   I've already assigned the issue to me and started working on it. The full
   fix includes more than just updating the version number - imports have to
   be readjusted, otherwise the bundle does not start on the latest Sling
   Starter app.
   
   On Thu, 18 Apr 2019 at 14:09, Robert Munteanu 
   wrote:
   
   > @raducotescu  - is this something that
   > you can review?
   >
   > —
   > You are receiving this because you were mentioned.
   >
   >
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (SLING-8363) [cp2fm] map rep:SystemUser JCR nodes to repoinit Feature extension

2019-04-18 Thread Simone Tripodi (JIRA)
Simone Tripodi created SLING-8363:
-

 Summary: [cp2fm] map rep:SystemUser JCR nodes to repoinit Feature 
extension
 Key: SLING-8363
 URL: https://issues.apache.org/jira/browse/SLING-8363
 Project: Sling
  Issue Type: Bug
  Components: Feature Model, Maven Plugins and Archetypes
Reporter: Simone Tripodi
Assignee: Simone Tripodi


As per summary, a JCR {{rep:SystemUser}} node, such as

{noformat}
http://www.jcp.org/jcr/1.0"; xmlns:rep="internal"
  jcr:primaryType="rep:SystemUser"
  rep:authorizableId="asd"
  rep:principalName="asd"/>
{noformat}

has to be mapped to the {{repoinit}} Feature Model extension:

{noformat}
"repoinit:TEXT|true":[
  "create service user asd"
]
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Timothee Maret (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821069#comment-16821069
 ] 

Timothee Maret commented on SLING-8357:
---

Thanks [~rombert]! That helps moving forward while the SonarCloud integration 
is being setup. 

> Activate Journal based Sling Content Distribution projects on SonarCloud
> 
>
> Key: SLING-8357
> URL: https://issues.apache.org/jira/browse/SLING-8357
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
> Distribution projects. The repositories are listed below
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>   
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal 
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
> (default-cli) on project org.apache.sling.distribution.journal.messages: 
> You're not authorized to run analysis. Please contact the project 
> administrator. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [sling-org-apache-sling-xss] rombert commented on issue #6: SLING-8353 Change embedded ESAPI version in sling.xss

2019-04-18 Thread GitBox
rombert commented on issue #6: SLING-8353 Change embedded ESAPI version in 
sling.xss
URL: 
https://github.com/apache/sling-org-apache-sling-xss/pull/6#issuecomment-484474360
 
 
   @raducotescu - is this something that you can review?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (SLING-8362) Log cleared offsets from package status watcher

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-8362.
---
Resolution: Fixed

Done.

> Log cleared offsets from package status watcher 
> 
>
> Key: SLING-8362
> URL: https://issues.apache.org/jira/browse/SLING-8362
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8362) Log cleared offsets from package status watcher

2019-04-18 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-8362:
-

 Summary: Log cleared offsets from package status watcher 
 Key: SLING-8362
 URL: https://issues.apache.org/jira/browse/SLING-8362
 Project: Sling
  Issue Type: Improvement
  Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret
 Fix For: Content Distribution Journal Core 0.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Sling projects connected to SonarCloud

2019-04-18 Thread Robert Munteanu
Hi,

We have finished working on the SonarQube/SonarCloud integration for
Sling projects.

As of now SonarCloud will check and record quality metrics (coverage
included) for all Sling modules. PR analysis is also enabled.

I have documented this at [1], with some open issues:

- PRs seem to be processed with a delay ( INFRA-18219 [2] )
- Onboarding is manual, recently created repositories are not yet
enabled for SonarCloud ( [3] )

In case anyone wants to be part of the 'Sling Admins' group in
SonarCloud, please first login to SonarCloud and then drop me an email
( documented at [1] ).

Thanks!

Robert


[1]: https://cwiki.apache.org/confluence/display/SLING/SonarCloud+analysis
[2]: https://issues.apache.org/jira/browse/INFRA-18219
[3]: https://issues.apache.org/jira/browse/SLING-8357



[jira] [Resolved] (SLING-8262) Add SonarQube analysis to Jenkins jobs

2019-04-18 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8262.

Resolution: Fixed

All important parts are complete, considering "done". Thanks for your help 
[~bellingard]

> Add SonarQube analysis to Jenkins jobs
> --
>
> Key: SLING-8262
> URL: https://issues.apache.org/jira/browse/SLING-8262
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: screenshot-1.png
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With the pipeline jobs it becomes simple to run a SonarQube analysis ( see 
> https://cwiki.apache.org/confluence/display/INFRA/Multibranch+Pipeline+recipies
>  ) so let's do that.
> We should also look if this can be done for pull requests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (SLING-8262) Add SonarQube analysis to Jenkins jobs

2019-04-18 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16758292#comment-16758292
 ] 

Robert Munteanu edited comment on SLING-8262 at 4/18/19 11:33 AM:
--

*Current status*:

* enable SonarCloud analysis for branches and PRs (/)
* create shared filter in SonarCloud (/) - 
https://sonarcloud.io/organizations/apache/projects?sort=-analysis_date&tags=sling
* enable SonarQube analysis on pull requests (/) - but see INFRA-18219, some PR 
builds are not triggered
* document onboarding to SonarCloud (/) - 
https://cwiki.apache.org/confluence/display/SLING/SonarCloud+analysis
* document including new admins to SonarCloud (/) - 
https://cwiki.apache.org/confluence/display/SLING/SonarCloud+analysis
* configure Sling-specific quality gate that applies to all Sling projects (?)
* configure Sling-specific quality profile that applies to all Sling projects 
(?)


was (Author: rombert):
*Current status*:

* enable SonarCloud analysis for branches and PRs (/)
* create shared filter in SonarCloud (/) - 
https://sonarcloud.io/organizations/apache/projects?sort=-analysis_date&tags=sling
* enable SonarQube analysis on pull requests (/) - but see INFRA-18219, some PR 
builds are not triggered
* document onboarding to SonarCloud (x)
* document including new admins to SonarCloud (x)
* configure Sling-specific quality gate that applies to all Sling projects (?)
* configure Sling-specific quality profile that applies to all Sling projects 
(?)

> Add SonarQube analysis to Jenkins jobs
> --
>
> Key: SLING-8262
> URL: https://issues.apache.org/jira/browse/SLING-8262
> Project: Sling
>  Issue Type: Improvement
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: screenshot-1.png
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> With the pipeline jobs it becomes simple to run a SonarQube analysis ( see 
> https://cwiki.apache.org/confluence/display/INFRA/Multibranch+Pipeline+recipies
>  ) so let's do that.
> We should also look if this can be done for pull requests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8361) Log subscriber steps to manage consumption status

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-8361.
---
Resolution: Fixed

Done.

> Log subscriber steps to manage consumption status 
> --
>
> Key: SLING-8361
> URL: https://issues.apache.org/jira/browse/SLING-8361
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> The management of status is not logged currently. We should log stored and 
> sent status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8358) Build should not fail if a project is not onboarded to SonarCloud

2019-04-18 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8358.

Resolution: Fixed

Build is now marked _UNSTABLE_ if the SonarCloud step fails.

> Build should not fail if a project is not onboarded to SonarCloud
> -
>
> Key: SLING-8358
> URL: https://issues.apache.org/jira/browse/SLING-8358
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> Onbooarding a project to SonarCloud is a manual process so we should not fail 
> the build if the SonarQube stage fails due to the project not being onboarded.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-8361) Log subscriber steps to manage consumption status

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-8361:
--
Description: The management of status is not logged currently. We should 
log stored and sent status.

> Log subscriber steps to manage consumption status 
> --
>
> Key: SLING-8361
> URL: https://issues.apache.org/jira/browse/SLING-8361
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> The management of status is not logged currently. We should log stored and 
> sent status.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8361) Log subscriber steps to manage consumption status

2019-04-18 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-8361:
-

 Summary: Log subscriber steps to manage consumption status 
 Key: SLING-8361
 URL: https://issues.apache.org/jira/browse/SLING-8361
 Project: Sling
  Issue Type: Improvement
  Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret
 Fix For: Content Distribution Journal Core 0.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-8360) Move Journal messaging API to messages bundle

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-8360:
--
Fix Version/s: Content Distribution Journal Messages 0.1.0
   Content Distribution Journal Core 0.1.0

> Move Journal messaging API to messages bundle
> -
>
> Key: SLING-8360
> URL: https://issues.apache.org/jira/browse/SLING-8360
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0, Content 
> Distribution Journal Messages 0.1.0
>
>
> The Journal messaging API exported as 
> {{org.apache.sling.distribution.journal}} the package is currently contained 
> in the 
> [sling-org-apache-sling-distribution-journal|https://github.com/apache/sling-org-apache-sling-distribution-journal]
>  bundle. To reduce dependency tree we should move the API (same 
> package/version) to the 
> [sling-org-apache-sling-distribution-journal-messages|https://github.com/apache/sling-org-apache-sling-distribution-journal-messages]
>  bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-8360) Move Journal messaging API to messages bundle

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-8360:
--
Description: The Journal messaging API exported as 
{{org.apache.sling.distribution.journal}} the package is currently contained in 
the 
[sling-org-apache-sling-distribution-journal|https://github.com/apache/sling-org-apache-sling-distribution-journal]
 bundle. To reduce dependency tree we should move the API (same 
package/version) to the 
[sling-org-apache-sling-distribution-journal-messages|https://github.com/apache/sling-org-apache-sling-distribution-journal-messages]
 bundle.  (was: The Journal messaging API exported as 
{{org.apache.sling.distribution.journal}} the package is currently contained in 
the 
[[sling-org-apache-sling-distribution-journal|https://github.com/apache/sling-org-apache-sling-distribution-journal]|[https://github.com/apache/sling-org-apache-sling-distribution-journal]]
 bundle. To reduce dependency tree we should move the API (same 
package/version) to the 
[[sling-org-apache-sling-distribution-journal-messages|https://github.com/apache/sling-org-apache-sling-distribution-journal-messages]|[https://github.com/apache/sling-org-apache-sling-distribution-journal-messages]]
 bundle.)

> Move Journal messaging API to messages bundle
> -
>
> Key: SLING-8360
> URL: https://issues.apache.org/jira/browse/SLING-8360
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
>
> The Journal messaging API exported as 
> {{org.apache.sling.distribution.journal}} the package is currently contained 
> in the 
> [sling-org-apache-sling-distribution-journal|https://github.com/apache/sling-org-apache-sling-distribution-journal]
>  bundle. To reduce dependency tree we should move the API (same 
> package/version) to the 
> [sling-org-apache-sling-distribution-journal-messages|https://github.com/apache/sling-org-apache-sling-distribution-journal-messages]
>  bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8360) Move Journal messaging API to messages bundle

2019-04-18 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-8360:
-

 Summary: Move Journal messaging API to messages bundle
 Key: SLING-8360
 URL: https://issues.apache.org/jira/browse/SLING-8360
 Project: Sling
  Issue Type: Improvement
  Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret


The Journal messaging API exported as {{org.apache.sling.distribution.journal}} 
the package is currently contained in the 
[[sling-org-apache-sling-distribution-journal|https://github.com/apache/sling-org-apache-sling-distribution-journal]|[https://github.com/apache/sling-org-apache-sling-distribution-journal]]
 bundle. To reduce dependency tree we should move the API (same 
package/version) to the 
[[sling-org-apache-sling-distribution-journal-messages|https://github.com/apache/sling-org-apache-sling-distribution-journal-messages]|[https://github.com/apache/sling-org-apache-sling-distribution-journal-messages]]
 bundle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820967#comment-16820967
 ] 

Robert Munteanu commented on SLING-8357:


[~marett] - in the meantime I've configured the Jenkins jobs to not fail if 
SonarCloud is not available, the build is marked UNSTABLE instead. That should 
help with getting the CI sorted out.

> Activate Journal based Sling Content Distribution projects on SonarCloud
> 
>
> Key: SLING-8357
> URL: https://issues.apache.org/jira/browse/SLING-8357
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
> Distribution projects. The repositories are listed below
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>   
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal 
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
> (default-cli) on project org.apache.sling.distribution.journal.messages: 
> You're not authorized to run analysis. Please contact the project 
> administrator. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [sling-org-apache-sling-caconfig-api] ompandeyy commented on a change in pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR

2019-04-18 Thread GitBox
ompandeyy commented on a change in pull request #2: [SLING-8272] Check if 
Caconfig Node Exists in JCR
URL: 
https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/2#discussion_r276602842
 
 

 ##
 File path: src/main/java/org/apache/sling/caconfig/ConfigurationBuilder.java
 ##
 @@ -86,4 +86,15 @@
  */
 @NotNull  Collection asAdaptableCollection(@NotNull Class clazz);
 
+/**
+ * Check if the configuration node is existing in the JCR. This method 
checks for the configuration existence based on {@code configName} defined in 
the
 
 Review comment:
   thanks, I have updated the comments


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-caconfig-api] ompandeyy commented on a change in pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR

2019-04-18 Thread GitBox
ompandeyy commented on a change in pull request #2: [SLING-8272] Check if 
Caconfig Node Exists in JCR
URL: 
https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/2#discussion_r276602756
 
 

 ##
 File path: src/main/java/org/apache/sling/caconfig/ConfigurationBuilder.java
 ##
 @@ -86,4 +86,15 @@
  */
 @NotNull  Collection asAdaptableCollection(@NotNull Class clazz);
 
+/**
+ * Check if the configuration node is existing in the JCR. This method 
checks for the configuration existence based on {@code configName} defined in 
the
+ * configuration definition. It checks if the configuration is available 
for the context path in the current resource hierarchy and if not found, also
+ * checks in the global fall-back paths configured via {@link 
org.apache.sling.caconfig.resource.impl.def.DefaultConfigurationResourceResolvingStrategy}
+ * which by default are {@code /conf/global}, {@code /apps/config} and 
{@code /libs/config}.This method does not consider the default values provided 
in
+ * the configuration definition.
+ * @param clazz Class that can be adapted from a {@link 
org.apache.sling.api.resource.Resource}
+ * @param  Annotation class type
+ * @return True/False based on configuration resource node existence in 
JCR.
+ */
+@NotNull  boolean has(@NotNull Class clazz);
 
 Review comment:
   I have refactored this method and now it expects a `configName ` parameter 
for all the cases.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [sling-org-apache-sling-caconfig-api] ompandeyy commented on a change in pull request #2: [SLING-8272] Check if Caconfig Node Exists in JCR

2019-04-18 Thread GitBox
ompandeyy commented on a change in pull request #2: [SLING-8272] Check if 
Caconfig Node Exists in JCR
URL: 
https://github.com/apache/sling-org-apache-sling-caconfig-api/pull/2#discussion_r276602491
 
 

 ##
 File path: src/main/java/org/apache/sling/caconfig/ConfigurationBuilder.java
 ##
 @@ -86,4 +86,15 @@
  */
 @NotNull  Collection asAdaptableCollection(@NotNull Class clazz);
 
+/**
+ * Check if the configuration node is existing in the JCR. This method 
checks for the configuration existence based on {@code configName} defined in 
the
+ * configuration definition. It checks if the configuration is available 
for the context path in the current resource hierarchy and if not found, also
+ * checks in the global fall-back paths configured via {@link 
org.apache.sling.caconfig.resource.impl.def.DefaultConfigurationResourceResolvingStrategy}
+ * which by default are {@code /conf/global}, {@code /apps/config} and 
{@code /libs/config}.This method does not consider the default values provided 
in
+ * the configuration definition.
+ * @param clazz Class that can be adapted from a {@link 
org.apache.sling.api.resource.Resource}
+ * @param  Annotation class type
+ * @return True/False based on configuration resource node existence in 
JCR.
+ */
+@NotNull  boolean has(@NotNull Class clazz);
 
 Review comment:
   removed this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Resolved] (SLING-8359) Set SCM to distribution journal modules

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-8359.
---
Resolution: Fixed

> Set SCM to distribution journal modules
> ---
>
> Key: SLING-8359
> URL: https://issues.apache.org/jira/browse/SLING-8359
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0, Content 
> Distribution Journal Kafka 0.1.0, Content Distribution Journal ITs 0.1.0, 
> Content Distribution Journal Messages 0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8359) Set SCM to distribution journal modules

2019-04-18 Thread Timothee Maret (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820878#comment-16820878
 ] 

Timothee Maret commented on SLING-8359:
---

Done

> Set SCM to distribution journal modules
> ---
>
> Key: SLING-8359
> URL: https://issues.apache.org/jira/browse/SLING-8359
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0, Content 
> Distribution Journal Kafka 0.1.0, Content Distribution Journal ITs 0.1.0, 
> Content Distribution Journal Messages 0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8359) Set SCM to distribution journal modules

2019-04-18 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-8359:
-

 Summary: Set SCM to distribution journal modules
 Key: SLING-8359
 URL: https://issues.apache.org/jira/browse/SLING-8359
 Project: Sling
  Issue Type: Task
  Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret
 Fix For: Content Distribution Journal Core 0.1.0, Content 
Distribution Journal Kafka 0.1.0, Content Distribution Journal ITs 0.1.0, 
Content Distribution Journal Messages 0.1.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-8358) Build should not fail if a project is not onboarded to SonarCloud

2019-04-18 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu updated SLING-8358:
---
Component/s: Build and Source Control

> Build should not fail if a project is not onboarded to SonarCloud
> -
>
> Key: SLING-8358
> URL: https://issues.apache.org/jira/browse/SLING-8358
> Project: Sling
>  Issue Type: Bug
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> Onbooarding a project to SonarCloud is a manual process so we should not fail 
> the build if the SonarQube stage fails due to the project not being onboarded.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (SLING-8358) Build should not fail if a project is not onboarded to SonarCloud

2019-04-18 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-8358:
--

Assignee: Robert Munteanu

> Build should not fail if a project is not onboarded to SonarCloud
> -
>
> Key: SLING-8358
> URL: https://issues.apache.org/jira/browse/SLING-8358
> Project: Sling
>  Issue Type: Bug
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> Onbooarding a project to SonarCloud is a manual process so we should not fail 
> the build if the SonarQube stage fails due to the project not being onboarded.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8358) Build should not fail if a project is not onboarded to SonarCloud

2019-04-18 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-8358:
--

 Summary: Build should not fail if a project is not onboarded to 
SonarCloud
 Key: SLING-8358
 URL: https://issues.apache.org/jira/browse/SLING-8358
 Project: Sling
  Issue Type: Bug
Reporter: Robert Munteanu


Onbooarding a project to SonarCloud is a manual process so we should not fail 
the build if the SonarQube stage fails due to the project not being onboarded.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Robert Munteanu (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820839#comment-16820839
 ] 

Robert Munteanu commented on SLING-8357:


[~bellingard] - can you please enable SonarQube integration for the 
repositories mentioned in this ticket? Thanks!

> Activate Journal based Sling Content Distribution projects on SonarCloud
> 
>
> Key: SLING-8357
> URL: https://issues.apache.org/jira/browse/SLING-8357
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
> Distribution projects. The repositories are listed below
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>   
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal 
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
> (default-cli) on project org.apache.sling.distribution.journal.messages: 
> You're not authorized to run analysis. Please contact the project 
> administrator. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8326) Donation proposal of Journal based Sling Content Distribution

2019-04-18 Thread Timothee Maret (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820838#comment-16820838
 ] 

Timothee Maret commented on SLING-8326:
---

Thanks [~rombert]!

> Donation proposal of Journal based Sling Content Distribution
> -
>
> Key: SLING-8326
> URL: https://issues.apache.org/jira/browse/SLING-8326
> Project: Sling
>  Issue Type: Task
>Reporter: Timothee Maret
>Assignee: Robert Munteanu
>Priority: Major
>  Labels: distribution
> Attachments: org.apache.sling.distribution.journal.it.tar.gz, 
> org.apache.sling.distribution.journal.kafka.tar.gz, 
> org.apache.sling.distribution.journal.messages.tar.gz, 
> org.apache.sling.distribution.journal.tar.gz
>
>
> h1. Modules
> The donation proposal covers 4 modules listed in the table below.
> ||Module||Source||Description||
> |org.apache.sling.distribution.journal|on 
> [github|https://github.com/tmaret/org.apache.sling.distribution.journal] or
>  [^org.apache.sling.distribution.journal.tar.gz] (shasum 
> b49dbcd182765b2351b9204df095a64ae2beb598)|Implementation of SCD agents on top 
> of a journal & Journal messaging API|
> |org.apache.sling.distribution.journal.kafka|on 
> [github|https://github.com/tmaret/org.apache.sling.distribution.journal.kafka]
>  or
>  [^org.apache.sling.distribution.journal.kafka.tar.gz] (shasum 
> 9be2740511619bc91832c24f00e093ce61f1f128)|Implementation of the Journal 
> messaging API on Apache Kafka|
> |org.apache.sling.distribution.journal.messages|on 
> [github|https://github.com/tmaret/org.apache.sling.distribution.journal.messages]
>  or
>  [^org.apache.sling.distribution.journal.messages.tar.gz] (shasum 
> c75bd3feafd335b23c169e57bb8b298ab25aed76)|Defines the messages exchanged by 
> the SCD agents|
> |org.apache.sling.distribution.journal.it|on 
> [github|https://github.com/tmaret/org.apache.sling.distribution.journal.it] or
>  [^org.apache.sling.distribution.journal.it.tar.gz] (shasum 
> bea916c7428dabf6dc66048087dbc3a4e0a7c610)|Integration Test for the journal 
> distribution modules|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Request for a Sling Repository for the Sling Project Archetype

2019-04-18 Thread Robert Munteanu
Hi Andy,

On Mon, 2019-04-15 at 07:11 -0700, Andreas Schaefer wrote:
> HI Robert
> 
> As of now it is:
> 
> org.apache.sling:sling-project-archetype
> 
> Going along with the other sling archetypes (taglib-archetype,
> slingstarter-archertype.
> 
> But I was thinking about something like this:
> 
> org.apache.sling:org-apache-sling-maven-project-archetype

I would suggest not prefixing with 'org.apache.sling' since it's
becoming hard to type/select when using mvn archetype:create or mvn
archetype:generate.

So org.apache.sling:sling-project-archetype sounds good to me.

I will create this repository tomorrow unless someone objects.

Thanks!

Robert



> 
> At the end I leave this up to the Sling team.
> 
> Thanks - Andy
> 
> > On Apr 15, 2019, at 12:33 AM, Robert Munteanu 
> > wrote:
> > 
> > Hi Andy,
> > 
> > What are the proposed groupId / repository name?
> > 
> > Thanks,
> > 
> > Robert
> > 
> > On Fri, 2019-04-12 at 10:38 -0700, Andreas Schaefer wrote:
> > > Hi
> > > 
> > > I updated the Sling Project Archetype project inside the Sling
> > > Whitebox project to Sling 11:
> > > 
> > > https://github.com/apache/sling-whiteboard/tree/feature/sling-7276/project-archetype
> > >  > > 7276/project-archetype>
> > > 
> > > And would like to request a Sling Repository to be created by a
> > > PMC.
> > > 
> > > The Project Archetype creates a Sling Project with Packages
> > > (instead
> > > of Content Bundles). It has two different flavors where a bundle
> > > is
> > > either part of a package (core inside ui.apps) or it creates an
> > > All
> > > package that contains both core and ui.apps side by side. The
> > > later
> > > is more extensible for projects with multiple bundles and/or
> > > packages.
> > > In addition the archetype can either be an empty project or come
> > > with
> > > sample code.
> > > 
> > > Cheers - Andreas Schaefer



[jira] [Updated] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-8357:
--
Fix Version/s: (was: Content Distribution J)
   Content Distribution Journal Core 0.1.0

> Activate Journal based Sling Content Distribution projects on SonarCloud
> 
>
> Key: SLING-8357
> URL: https://issues.apache.org/jira/browse/SLING-8357
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.0
>
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
> Distribution projects. The repositories are listed below
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>   
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal 
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
> (default-cli) on project org.apache.sling.distribution.journal.messages: 
> You're not authorized to run analysis. Please contact the project 
> administrator. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8326) Donation proposal of Journal based Sling Content Distribution

2019-04-18 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8326.

Resolution: Fixed
  Assignee: Robert Munteanu

This is complete, thanks again [~marett] for driving this contribution!

> Donation proposal of Journal based Sling Content Distribution
> -
>
> Key: SLING-8326
> URL: https://issues.apache.org/jira/browse/SLING-8326
> Project: Sling
>  Issue Type: Task
>Reporter: Timothee Maret
>Assignee: Robert Munteanu
>Priority: Major
>  Labels: distribution
> Attachments: org.apache.sling.distribution.journal.it.tar.gz, 
> org.apache.sling.distribution.journal.kafka.tar.gz, 
> org.apache.sling.distribution.journal.messages.tar.gz, 
> org.apache.sling.distribution.journal.tar.gz
>
>
> h1. Modules
> The donation proposal covers 4 modules listed in the table below.
> ||Module||Source||Description||
> |org.apache.sling.distribution.journal|on 
> [github|https://github.com/tmaret/org.apache.sling.distribution.journal] or
>  [^org.apache.sling.distribution.journal.tar.gz] (shasum 
> b49dbcd182765b2351b9204df095a64ae2beb598)|Implementation of SCD agents on top 
> of a journal & Journal messaging API|
> |org.apache.sling.distribution.journal.kafka|on 
> [github|https://github.com/tmaret/org.apache.sling.distribution.journal.kafka]
>  or
>  [^org.apache.sling.distribution.journal.kafka.tar.gz] (shasum 
> 9be2740511619bc91832c24f00e093ce61f1f128)|Implementation of the Journal 
> messaging API on Apache Kafka|
> |org.apache.sling.distribution.journal.messages|on 
> [github|https://github.com/tmaret/org.apache.sling.distribution.journal.messages]
>  or
>  [^org.apache.sling.distribution.journal.messages.tar.gz] (shasum 
> c75bd3feafd335b23c169e57bb8b298ab25aed76)|Defines the messages exchanged by 
> the SCD agents|
> |org.apache.sling.distribution.journal.it|on 
> [github|https://github.com/tmaret/org.apache.sling.distribution.journal.it] or
>  [^org.apache.sling.distribution.journal.it.tar.gz] (shasum 
> bea916c7428dabf6dc66048087dbc3a4e0a7c610)|Integration Test for the journal 
> distribution modules|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (SLING-8346) Import Journal based Sling Content Distribution source code

2019-04-18 Thread Robert Munteanu (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8346.

Resolution: Fixed

Repositories created and content pushed. Resolving as fixed

> Import Journal based Sling Content Distribution source code
> ---
>
> Key: SLING-8346
> URL: https://issues.apache.org/jira/browse/SLING-8346
> Project: Sling
>  Issue Type: Sub-task
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> Once the ip clearance is complete we will import the 4 new modules in 
> Github/GitBox



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Timothee Maret (JIRA)


 [ 
https://issues.apache.org/jira/browse/SLING-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-8357:
--
Fix Version/s: Content Distribution J

> Activate Journal based Sling Content Distribution projects on SonarCloud
> 
>
> Key: SLING-8357
> URL: https://issues.apache.org/jira/browse/SLING-8357
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Content Distribution J
>
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
> Distribution projects. The repositories are listed below
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>   
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal 
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
> (default-cli) on project org.apache.sling.distribution.journal.messages: 
> You're not authorized to run analysis. Please contact the project 
> administrator. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Timothee Maret (JIRA)


[ 
https://issues.apache.org/jira/browse/SLING-8357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820826#comment-16820826
 ] 

Timothee Maret commented on SLING-8357:
---

[~rombert] could you help with this integration ?

> Activate Journal based Sling Content Distribution projects on SonarCloud
> 
>
> Key: SLING-8357
> URL: https://issues.apache.org/jira/browse/SLING-8357
> Project: Sling
>  Issue Type: Task
>  Components: Content Distribution
>Reporter: Timothee Maret
>Priority: Major
>
> Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
> Distribution projects. The repositories are listed below
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
>  * 
> [https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
>   
> Those Jenkins jobs fail currently with an error similar to
> {code:java}
> [ERROR] Failed to execute goal 
> org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar 
> (default-cli) on project org.apache.sling.distribution.journal.messages: 
> You're not authorized to run analysis. Please contact the project 
> administrator. -> [Help 1]
> [ERROR] 
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR] 
> [ERROR] For more information about the errors and possible solutions, please 
> read the following articles:
> [ERROR] [Help 1] 
> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
> {code}
> which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SLING-8357) Activate Journal based Sling Content Distribution projects on SonarCloud

2019-04-18 Thread Timothee Maret (JIRA)
Timothee Maret created SLING-8357:
-

 Summary: Activate Journal based Sling Content Distribution 
projects on SonarCloud
 Key: SLING-8357
 URL: https://issues.apache.org/jira/browse/SLING-8357
 Project: Sling
  Issue Type: Task
  Components: Content Distribution
Reporter: Timothee Maret


Jenkins Jobs have been created (thanks!) for the Journal based Sling Content 
Distribution projects. The repositories are listed below
 * 
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal]
 * 
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it]
 * 
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-kafka]
 * 
[https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-messages]
  

Those Jenkins jobs fail currently with an error similar to
{code:java}
[ERROR] Failed to execute goal 
org.sonarsource.scanner.maven:sonar-maven-plugin:3.6.0.1398:sonar (default-cli) 
on project org.apache.sling.distribution.journal.messages: You're not 
authorized to run analysis. Please contact the project administrator. -> [Help 
1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
{code}

which seems related to a missing integration with Sonar.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)