Re: [VOTE]: Release Apache Sling Project Archetype 1.0.0

[Andreas Schaefer]

This is weird. When opening https://people.apache.org/keys/group/sling.asc 
 I see this (excerpt):

ASF ID: andysch
LDAP PGP key: 49EC C3FC FD4C DF49 F308  DEC2 7493 91D1 63EF CDEF

49EC C3FC FD4C DF49 F308  DEC2 7493 91D1 63EF CDEF
-BEGIN PGP PUBLIC KEY BLOCK-
Version: GnuPG v1
The public key is hosted here: hkps://hkps.pool.sks-keyservers.net 


Not sure why you don’t see it.

Cheers - Andy Schaefer


> On Apr 26, 2019, at 11:46 AM, Daniel Klco  wrote:
> 
> The command output:
> 
> 
> PRFT-12626-MAC:sling dan.klco$ gpg --verify
> /tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0.pom.asc
> 
> 
> gpg: assuming signed data in
> '/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0.pom'
> 
> gpg: Signature made Wed Apr 24 12:41:30 2019 EDT
> 
> gpg:using RSA key 49ECC3FCFD4CDF49F308DEC2749391D163EFCDEF
> 
> gpg: Can't check signature: No public key

[jira] [Updated] (SLING-8375) SlingPostServlet: :import operation must skip protected properties if present

[Viorel Lupu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viorel Lupu updated SLING-8375:
---
Description: 
h2. Description

Posting JSON content to the SlingPostServlet with *:import* operation as 
documented at 
[https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#slingpostservlet-operations]
 fails when the JSON payload contains protected property names such as:

 
{code:java}
"jcr:createdBy",
"jcr:created",
"jcr:createdBy",
"jcr:baseVersion",
"jcr:lastModified",
"jcr:lastModifiedBy",
"jcr:uuid",
"cq:lastModified",
"cq:lastModifiedBy",
"cq:lastReplicated",
"jcr:versionHistory",
"rep:policy",
"onTime",
"offTime"
{code}
{code:java}
# curl invocation

curl -L -vv -u admin:admin \
-F ":operation=import" \
-F ":contentType=json" \
-F ":name=newcontentnode" \
-F ":content=@data.json" \
-F ":replace=true" \
-H 'Referer: http://localhost:4502/content/we-retail/language-masters/en' \
-H 'User-Agent: Adobe-Campaign/5.0' \
 http://localhost:4502/content/we-retail/language-masters/en{code}
 
h2. Suggested Improvement

The importer should skip protected properties and proceed with import rather 
than failing.
h2. Error.log:

more detailed error log attached to issue

 
{code:java}
26.04.2019 16:34:55.298 *ERROR* [0:0:0:0:0:0:0:1 [1556289295274] POST 
/content/we-retail/language-masters HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ImportOperation Exception during 
response processing.
javax.jcr.nodetype.ConstraintViolationException: Property is protected: 
jcr:createdBy = admin
at 
org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.setProperty(NodeDelegate.java:525)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl$35.perform(NodeImpl.java:1376)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl$35.perform(NodeImpl.java:1364)
at 
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:208)
at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112)
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl.internalSetProperty(NodeImpl.java:1364)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl.setProperty(NodeImpl.java:434)
at 
org.apache.sling.jcr.contentloader.internal.DefaultContentCreator.createProperty(DefaultContentCreator.java:361)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.createProperty(JsonReader.java:226)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.createNode(JsonReader.java:199)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.createNode(JsonReader.java:197)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.parse(JsonReader.java:159)
at 
org.apache.sling.jcr.contentloader.internal.DefaultContentImporter.importContent(DefaultContentImporter.java:93)
at 
org.apache.sling.servlets.post.impl.operations.ImportOperation.doRun(ImportOperation.java:176)
at 
org.apache.sling.servlets.post.AbstractPostOperation.run(AbstractPostOperation.java:97)
at 
org.apache.sling.servlets.post.impl.SlingPostServlet.doPost(SlingPostServlet.java:205)
at 
org.apache.sling.api.servlets.SlingAllMethodsServlet.mayService(SlingAllMethodsServlet.java:146)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
at 
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
{code}

  was:
h2. Description

Posting JSON content to the SlingPostServlet with *:import* operation as 
documented at 
[https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#slingpostservlet-operations]
 fails when the JSON payload contains protected property names such as:

 
{code:java}
"jcr:createdBy",
"jcr:created",
"jcr:createdBy",
"jcr:baseVersion",
"jcr:lastModified",
"jcr:lastModifiedBy",
"jcr:uuid",
"cq:lastModified",
"cq:lastModifiedBy",
"cq:lastReplicated",
"jcr:versionHistory",
"rep:policy",
"onTime",
"offTime"
{code}
{code:java}
# curl invocation

curl -L -vv -u admin:admin \
-F ":operation=import" \
-F ":contentType=json" \
-F ":name=newcontentnode" \
-F ":content=@data.json" \
-F ":replace=true" \
-H 'Referer: http://localhost:6900/content/campaigns' \
-H 'User-Agent: Adobe-Campaign/5.0' \
 http://localhost:4502/content/we-retail/language-masters/en{code}
 
h2. Suggested Improvement

The importer should skip protected properties and proceed with import rather 
than failing.
h2. Error.log:

more detailed error log attached to issue

 
{code:java}
26.04.2019 16:34:55.298 *ERROR* [0:0:0:0:0:0:0:1 [1556289295274] POST 
/content/we-retail/language-masters HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ImportOperation Exception during 
response processing.
javax.jcr.nodetype.ConstraintViolationException: Property is protected: 
jcr:createdBy = 

[jira] [Updated] (SLING-8375) SlingPostServlet: :import operation must skip protected properties if present

[Viorel Lupu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Viorel Lupu updated SLING-8375:
---
Description: 
h2. Description

Posting JSON content to the SlingPostServlet with *:import* operation as 
documented at 
[https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#slingpostservlet-operations]
 fails when the JSON payload contains protected property names such as:

 
{code:java}
"jcr:createdBy",
"jcr:created",
"jcr:createdBy",
"jcr:baseVersion",
"jcr:lastModified",
"jcr:lastModifiedBy",
"jcr:uuid",
"cq:lastModified",
"cq:lastModifiedBy",
"cq:lastReplicated",
"jcr:versionHistory",
"rep:policy",
"onTime",
"offTime"
{code}
{code:java}
# curl invocation

curl -L -vv -u admin:admin \
-F ":operation=import" \
-F ":contentType=json" \
-F ":name=newcontentnode" \
-F ":content=@data.json" \
-F ":replace=true" \
-H 'Referer: http://localhost:6900/content/campaigns' \
-H 'User-Agent: Adobe-Campaign/5.0' \
 http://localhost:4502/content/we-retail/language-masters/en{code}
 
h2. Suggested Improvement

The importer should skip protected properties and proceed with import rather 
than failing.
h2. Error.log:

more detailed error log attached to issue

 
{code:java}
26.04.2019 16:34:55.298 *ERROR* [0:0:0:0:0:0:0:1 [1556289295274] POST 
/content/we-retail/language-masters HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ImportOperation Exception during 
response processing.
javax.jcr.nodetype.ConstraintViolationException: Property is protected: 
jcr:createdBy = admin
at 
org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.setProperty(NodeDelegate.java:525)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl$35.perform(NodeImpl.java:1376)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl$35.perform(NodeImpl.java:1364)
at 
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:208)
at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112)
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl.internalSetProperty(NodeImpl.java:1364)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl.setProperty(NodeImpl.java:434)
at 
org.apache.sling.jcr.contentloader.internal.DefaultContentCreator.createProperty(DefaultContentCreator.java:361)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.createProperty(JsonReader.java:226)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.createNode(JsonReader.java:199)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.createNode(JsonReader.java:197)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.parse(JsonReader.java:159)
at 
org.apache.sling.jcr.contentloader.internal.DefaultContentImporter.importContent(DefaultContentImporter.java:93)
at 
org.apache.sling.servlets.post.impl.operations.ImportOperation.doRun(ImportOperation.java:176)
at 
org.apache.sling.servlets.post.AbstractPostOperation.run(AbstractPostOperation.java:97)
at 
org.apache.sling.servlets.post.impl.SlingPostServlet.doPost(SlingPostServlet.java:205)
at 
org.apache.sling.api.servlets.SlingAllMethodsServlet.mayService(SlingAllMethodsServlet.java:146)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
at 
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
{code}

  was:
h2. Description

Posting JSON content to the SlingPostServlet with *:import* operation as 
documented at 
[https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#slingpostservlet-operations]
 fails when the JSON payload contains protected property names such as:

 
{code:java}
"jcr:createdBy",
"jcr:created",
"jcr:createdBy",
"jcr:baseVersion",
"jcr:lastModified",
"jcr:lastModifiedBy",
"jcr:uuid",
"cq:lastModified",
"cq:lastModifiedBy",
"cq:lastReplicated",
"jcr:versionHistory",
"rep:policy",
"onTime",
"offTime"
{code}
 
h2. Suggested Improvement

The importer should skip protected properties and proceed with import rather 
than failing.
h2. Error.log:

more detailed error log attached to issue

 
{code:java}
26.04.2019 16:34:55.298 *ERROR* [0:0:0:0:0:0:0:1 [1556289295274] POST 
/content/we-retail/language-masters HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ImportOperation Exception during 
response processing.
javax.jcr.nodetype.ConstraintViolationException: Property is protected: 
jcr:createdBy = admin
at 
org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.setProperty(NodeDelegate.java:525)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl$35.perform(NodeImpl.java:1376)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl$35.perform(NodeImpl.java:1364)
at 
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:208)
at 

[VOTE] Release Apache Sling Service User WebConsole 1.0.2, Repoinit Parser 1.2.4 and Repoinit JCR 1.1.10

[Daniel Klco]

Hi,

We solved 4 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12342697
https://issues.apache.org/jira/projects/SLING/versions/12342578
https://issues.apache.org/jira/projects/SLING/versions/12342698

There are still some outstanding issues which are deferred for future
releases of Repoinit Parser and Repoinit JCR:
https://issues.apache.org/jira/projects/SLING/versions/12342698
https://issues.apache.org/jira/projects/SLING/versions/12345439

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2072/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob_plain;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2072 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

[jira] [Resolved] (SLING-8374) Missing out exceptions in catch clause in DistributionSubscriber class

[Timothee Maret (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret resolved SLING-8374.
---
   Resolution: Fixed
Fix Version/s: Content Distribution Journal Core 0.1.2

> Missing out exceptions in catch clause in DistributionSubscriber class
> --
>
> Key: SLING-8374
> URL: https://issues.apache.org/jira/browse/SLING-8374
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.0
>Reporter: Alexei Krainiouk
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal Core 0.1.2
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> In 
> [DistributionSubscriber.importPackage|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
>  method. catch (Exception e) should be replaced with catch (Throwable e) in 
> order to count all possible errors in failedPackageImports metric.
> This pull request provides fixes for above issues: 
> https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/4



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8374) Missing out exceptions in catch clause in DistributionSubscriber class

[Timothee Maret (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827268#comment-16827268
 ] 

Timothee Maret commented on SLING-8374:
---

Thanks Alexei Krainiouk, merged 
[PR#4|https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/4].

> Missing out exceptions in catch clause in DistributionSubscriber class
> --
>
> Key: SLING-8374
> URL: https://issues.apache.org/jira/browse/SLING-8374
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.0
>Reporter: Alexei Krainiouk
>Assignee: Timothee Maret
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> In 
> [DistributionSubscriber.importPackage|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
>  method. catch (Exception e) should be replaced with catch (Throwable e) in 
> order to count all possible errors in failedPackageImports metric.
> This pull request provides fixes for above issues: 
> https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/4



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-8374) Missing out exceptions in catch clause in DistributionSubscriber class

[Timothee Maret (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret reassigned SLING-8374:
-

Assignee: Timothee Maret

> Missing out exceptions in catch clause in DistributionSubscriber class
> --
>
> Key: SLING-8374
> URL: https://issues.apache.org/jira/browse/SLING-8374
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.0
>Reporter: Alexei Krainiouk
>Assignee: Timothee Maret
>Priority: Major
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> In 
> [DistributionSubscriber.importPackage|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
>  method. catch (Exception e) should be replaced with catch (Throwable e) in 
> order to count all possible errors in failedPackageImports metric.
> This pull request provides fixes for above issues: 
> https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/4



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SLING-8374) Missing out exceptions in catch clause in DistributionSubscriber class

[Alexei Krainiouk (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827263#comment-16827263
 ] 

Alexei Krainiouk commented on SLING-8374:
-

New pull request submitted. Reverted Case 1 and changed case 2 to re-throw all 
errors.

> Missing out exceptions in catch clause in DistributionSubscriber class
> --
>
> Key: SLING-8374
> URL: https://issues.apache.org/jira/browse/SLING-8374
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.0
>Reporter: Alexei Krainiouk
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In 
> [DistributionSubscriber.importPackage|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
>  method. catch (Exception e) should be replaced with catch (Throwable e) in 
> order to count all possible errors in failedPackageImports metric.
> This pull request provides fixes for above issues: 
> https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/4



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7147) Support ACL remove * statement

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-7147:

Fix Version/s: (was: Repoinit JCR 1.1.10)
   Repoinit JCR 1.1.12

> Support ACL remove * statement
> --
>
> Key: SLING-7147
> URL: https://issues.apache.org/jira/browse/SLING-7147
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Affects Versions: Repoinit JCR 1.1.6
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Repoinit JCR 1.1.12
>
>
> The repoinit parser supports removing all ACLs with the syntax
> {code}
> set ACL on 
> remove * for 
> end
> {code}
> and 
> {code}
> set ACL for 
> remove * on 
> end
> {code}
> However, the JCR implementation does not seem to support it.
> This issue is about implementing the {{remove *}} statements for ACLs in the 
> JCR repoinit implementation.
> cc [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-8374) Missing out exceptions in catch clause in DistributionSubscriber class

[Alexei Krainiouk (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexei Krainiouk updated SLING-8374:

Description: 
In 
[DistributionSubscriber.importPackage|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
 method. catch (Exception e) should be replaced with catch (Throwable e) in 
order to count all possible errors in failedPackageImports metric.

This pull request provides fixes for above issues: 
https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/4

  was:
There are two cases when catch clause is not catching necessary exceptions.
 #  in 
[DistributionSubscriber.timedSendStoredStatus|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L663]
 method. Apparently the intent is to catch an exception thrown by 
sendStatusMessage() method which in turn triggered by 
[sender.send()|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
 invocation. However sender.send() method throws MessagingException which 
subclasses RuntimeError rather then Exception. As a result the exception is 
never caught.
 # in 
[DistributionSubscriber.importPackage|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
 method. catch (Exception e) should be replaced with catch (Throwable e) in 
order to count all possible errors in failedPackageImports metric.

This pull request provides fixes for above issues: 
[https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/3]


> Missing out exceptions in catch clause in DistributionSubscriber class
> --
>
> Key: SLING-8374
> URL: https://issues.apache.org/jira/browse/SLING-8374
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.0
>Reporter: Alexei Krainiouk
>Priority: Major
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> In 
> [DistributionSubscriber.importPackage|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
>  method. catch (Exception e) should be replaced with catch (Throwable e) in 
> order to count all possible errors in failedPackageImports metric.
> This pull request provides fixes for above issues: 
> https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/4



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-7143) Support complete set of symbols for paths

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-7143:

Fix Version/s: (was: Repoinit Parser 1.2.4)
   Repoinit Parser 1.2.6

> Support complete set of symbols for paths
> -
>
> Key: SLING-7143
> URL: https://issues.apache.org/jira/browse/SLING-7143
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Affects Versions: Repoinit Parser 1.2.0
>Reporter: Timothee Maret
>Priority: Major
> Fix For: Repoinit Parser 1.2.6
>
>
> As discussed in SLING-6774 and suggested by [~olli], we should support a 
> complete set of symbols for paths.
> cc [~oli], [~bdelacretaz]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SLING-6423) Allow for specifying ACL merge mode (ACHandling) in repoinit

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-6423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco updated SLING-6423:

Fix Version/s: (was: Repoinit JCR 1.1.10)
   Repoinit JCR 1.1.12

> Allow for specifying ACL merge mode (ACHandling) in repoinit
> 
>
> Key: SLING-6423
> URL: https://issues.apache.org/jira/browse/SLING-6423
> Project: Sling
>  Issue Type: New Feature
>  Components: Repoinit
>Reporter: Nitin Nizhawan
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Repoinit JCR 1.1.12
>
> Attachments: SLING-6423_parser_changes.patch, 
> SLING-6423_testcases.patch, SLING_6423_testcasesV2.patch
>
>
> Repoinit by default just add new ACLs if they are not already present.
> By contract package manager provides various strategies for ACL merging
> Extend repoinit to allow specifying these strategies 
> https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/io/AccessControlHandling.html#MERGE



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE]: Release Apache Sling Project Archetype 1.0.0

[Daniel Klco]

I'm getting a signature failure:

PRFT-12626-MAC:sling dan.klco$ ./check_staged_release.sh 2070



   DOWNLOAD STAGED REPOSITORY




2019-04-26 14:44:52 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/
[1304] -> "/tmp/sling-staging/2070/org/apache/sling/index.html.tmp" [1]

2019-04-26 14:44:53 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/
[2535] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/index.html.tmp"
[1]

2019-04-26 14:44:55 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/
[8131] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/index.html.tmp"
[1]

2019-04-26 14:44:56 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/maven-metadata.xml
[319/319] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/maven-metadata.xml"
[1]

2019-04-26 14:44:58 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/maven-metadata.xml.md5
[32/32] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/maven-metadata.xml.md5"
[1]

2019-04-26 14:45:35 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/maven-metadata.xml.sha1
[40/40] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/maven-metadata.xml.sha1"
[1]

2019-04-26 14:45:37 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-source-release.zip
[84140/84140] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-source-release.zip"
[1]

2019-04-26 14:45:38 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-source-release.zip.asc
[833/833] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-source-release.zip.asc"
[1]

2019-04-26 14:45:40 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-source-release.zip.md5
[32/32] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-source-release.zip.md5"
[1]

2019-04-26 14:45:42 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-source-release.zip.sha1
[40/40] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-source-release.zip.sha1"
[1]

2019-04-26 14:45:43 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-sources.jar
[60268/60268] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-sources.jar"
[1]

2019-04-26 14:45:45 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-sources.jar.asc
[833/833] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-sources.jar.asc"
[1]

2019-04-26 14:45:47 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-sources.jar.md5
[32/32] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-sources.jar.md5"
[1]

2019-04-26 14:45:48 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-sources.jar.sha1
[40/40] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0-sources.jar.sha1"
[1]

2019-04-26 14:45:50 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0.jar
[51009/51009] ->
"/tmp/sling-staging/2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0.jar"
[1]

2019-04-26 14:45:52 URL:
https://repository.apache.org/content/repositories/orgapachesling-2070/org/apache/sling/sling-project-archetype/1.0.0/sling-project-archetype-1.0.0.jar.asc
[833/833] ->

Re: [DISCUSSION] RepoInit Release

[Daniel Klco]

Sorry for the delay on this. I checked into the partial commit situation,
it appears *only* the Unit Tests were merged into the codebase (and then
marked with @Ignore). The implementation is in an unapplied patch against
the old project structure. Unfortunately, this patch will be very difficult
to apply as there has been quite a bit of drift both in the project
structure and the affected files since the patch was created.

At this point, I believe we're able to start the release for these
libraries and will update the thread asking for a new patch against the
repo to support the merge functionality.

On Wed, Apr 17, 2019 at 3:54 AM Bertrand Delacretaz 
wrote:

> Hi,
>
> On Wed, Apr 17, 2019 at 7:30 AM Carsten Ziegeler 
> wrote:
> > ...I think it's fine to move, however it seems SLING-6423 is partially
> > committed, so this might need some attention before a release...
>
> +1
>
>
>
> -Bertrand
>

[jira] [Resolved] (SLING-7415) [ServiceUser WebConsole] - Remove Unnecessary Exposed Package

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-7415.
-
Resolution: Fixed

Fixed in 
[https://github.com/apache/sling-org-apache-sling-serviceuser-webconsole/commit/2a8c0eaaa23d63a8323304a69c303a24ba1dbd7d]

> [ServiceUser WebConsole] - Remove Unnecessary Exposed Package
> -
>
> Key: SLING-7415
> URL: https://issues.apache.org/jira/browse/SLING-7415
> Project: Sling
>  Issue Type: Bug
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: Service User WebConsole 1.0.2
>
>
> Currently the ServiceUser WebConsole exposes the package 
> org.apache.sling.serviceuser.webconsole which should be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (SLING-8376) Unclosed ResourceResolver with Service User Webconsole

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-8376.
-
Resolution: Fixed

Fixed in 
[https://github.com/apache/sling-org-apache-sling-serviceuser-webconsole/commit/da9192d93425be677b94c0b9c7d257e332136569]

> Unclosed ResourceResolver with Service User Webconsole
> --
>
> Key: SLING-8376
> URL: https://issues.apache.org/jira/browse/SLING-8376
> Project: Sling
>  Issue Type: Improvement
>  Components: Service User Mapper
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: Service User WebConsole 1.0.2
>
>
> When using the Service User Webconsole without a ResourceResolver set in the 
> "org.apache.sling.auth.core.ResourceResolver" request parameter, the 
> Webconsole will instantiate and not close an administrative resource 
> resolver. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8376) Unclosed ResourceResolver with Service User Webconsole

[Dan Klco (JIRA)]

Dan Klco created SLING-8376:
---

 Summary: Unclosed ResourceResolver with Service User Webconsole
 Key: SLING-8376
 URL: https://issues.apache.org/jira/browse/SLING-8376
 Project: Sling
  Issue Type: Improvement
  Components: Service User Mapper
Reporter: Dan Klco
Assignee: Dan Klco
 Fix For: Service User WebConsole 1.0.2


When using the Service User Webconsole without a ResourceResolver set in the 
"org.apache.sling.auth.core.ResourceResolver" request parameter, the Webconsole 
will instantiate and not close an administrative resource resolver. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (SLING-7415) [ServiceUser WebConsole] - Remove Unnecessary Exposed Package

[Dan Klco (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SLING-7415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco reassigned SLING-7415:
---

Assignee: Dan Klco

> [ServiceUser WebConsole] - Remove Unnecessary Exposed Package
> -
>
> Key: SLING-7415
> URL: https://issues.apache.org/jira/browse/SLING-7415
> Project: Sling
>  Issue Type: Bug
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: Service User WebConsole 1.0.2
>
>
> Currently the ServiceUser WebConsole exposes the package 
> org.apache.sling.serviceuser.webconsole which should be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (SLING-8375) SlingPostServlet: :import operation must skip protected properties if present

[Viorel Lupu (JIRA)]

Viorel Lupu created SLING-8375:
--

 Summary: SlingPostServlet: :import operation must skip protected 
properties if present
 Key: SLING-8375
 URL: https://issues.apache.org/jira/browse/SLING-8375
 Project: Sling
  Issue Type: Improvement
  Components: Servlets
 Environment: AEM 6.3
Reporter: Viorel Lupu
 Attachments: error-import-json.log

h2. Description

Posting JSON content to the SlingPostServlet with *:import* operation as 
documented at 
[https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#slingpostservlet-operations]
 fails when the JSON payload contains protected property names such as:

 
{code:java}
"jcr:createdBy",
"jcr:created",
"jcr:createdBy",
"jcr:baseVersion",
"jcr:lastModified",
"jcr:lastModifiedBy",
"jcr:uuid",
"cq:lastModified",
"cq:lastModifiedBy",
"cq:lastReplicated",
"jcr:versionHistory",
"rep:policy",
"onTime",
"offTime"
{code}
 
h2. Suggested Improvement

The importer should skip protected properties and proceed with import rather 
than failing.
h2. Error.log:

more detailed error log attached to issue

 
{code:java}
26.04.2019 16:34:55.298 *ERROR* [0:0:0:0:0:0:0:1 [1556289295274] POST 
/content/we-retail/language-masters HTTP/1.1] 
org.apache.sling.servlets.post.impl.operations.ImportOperation Exception during 
response processing.
javax.jcr.nodetype.ConstraintViolationException: Property is protected: 
jcr:createdBy = admin
at 
org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.setProperty(NodeDelegate.java:525)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl$35.perform(NodeImpl.java:1376)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl$35.perform(NodeImpl.java:1364)
at 
org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:208)
at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112)
at 
org.apache.jackrabbit.oak.jcr.session.NodeImpl.internalSetProperty(NodeImpl.java:1364)
at org.apache.jackrabbit.oak.jcr.session.NodeImpl.setProperty(NodeImpl.java:434)
at 
org.apache.sling.jcr.contentloader.internal.DefaultContentCreator.createProperty(DefaultContentCreator.java:361)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.createProperty(JsonReader.java:226)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.createNode(JsonReader.java:199)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.createNode(JsonReader.java:197)
at 
org.apache.sling.jcr.contentloader.internal.readers.JsonReader.parse(JsonReader.java:159)
at 
org.apache.sling.jcr.contentloader.internal.DefaultContentImporter.importContent(DefaultContentImporter.java:93)
at 
org.apache.sling.servlets.post.impl.operations.ImportOperation.doRun(ImportOperation.java:176)
at 
org.apache.sling.servlets.post.AbstractPostOperation.run(AbstractPostOperation.java:97)
at 
org.apache.sling.servlets.post.impl.SlingPostServlet.doPost(SlingPostServlet.java:205)
at 
org.apache.sling.api.servlets.SlingAllMethodsServlet.mayService(SlingAllMethodsServlet.java:146)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
at 
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
at 
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: [VOTE]: Release Apache Sling Project Archetype 1.0.0

[Timothee Maret]

+1 (non binding)

Timothee

Le mer. 24 avr. 2019 à 19:45, Andreas Schaefer  a
écrit :

> Hi
>
> This is the first release of the Sling Project Archetype. This archetype
> is creating a Sling Project composed of a core, ui.apps and optionally an
> all package with or without examples.
>
> Staging Repository:
> https://repository.apache.org/content/repositories/orgapachesling-2070 <
> https://repository.apache.org/content/repositories/orgapachesling-2070>
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> <
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
>
> Usage:
> sh check_staged_release.sh 2070 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards - Andy Schaefer Sr.

Re: [VOTE]: Release Apache Sling Project Archetype 1.0.0

[David Bosschaert]

+1

David

On Wed, 24 Apr 2019 at 18:45, Andreas Schaefer 
wrote:

> Hi
>
> This is the first release of the Sling Project Archetype. This archetype
> is creating a Sling Project composed of a core, ui.apps and optionally an
> all package with or without examples.
>
> Staging Repository:
> https://repository.apache.org/content/repositories/orgapachesling-2070 <
> https://repository.apache.org/content/repositories/orgapachesling-2070>
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> <
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> >
>
> Usage:
> sh check_staged_release.sh 2070 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards - Andy Schaefer Sr.

[VOTE] Release Sling Feature Model Inventory Printer 1.0.0

[davidb]

Hi all,

I would like to release the Sling Feature Model Inventory Printer version
1.0.0.
The inventory printer is a plugin to the Web Console and is exposed via the
Status | Launch Feature menu and this URL: http://host:port
/system/console/status-launch_feature
It prints out the effective feature that is launched by the feature
launcher.

More information here:
https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-feature-inventoryprinter.git;a=blob;f=README.md

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2071/

You can use this UNIX script to download the release and verify the
signatures:
http://svn.apache.org/repos/asf/sling/trunk/check_staged_release.sh

Usage:
sh check_staged_release.sh 2071 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Best regards,

David Bosschaert

[jira] [Commented] (SLING-8374) Missing out exceptions in catch clause in DistributionSubscriber class

[Timothee Maret (JIRA)]

[ 
https://issues.apache.org/jira/browse/SLING-8374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826811#comment-16826811
 ] 

Timothee Maret commented on SLING-8374:
---

Thanks [~akrainiouk]! I commented on the two cases reported below.

Case 1. The reasoning is based on an incorrect premise. 
[MessagingException|https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/blob/6830b0388a62d4294c3890d6764d23e6302bf3b9/src/main/java/org/apache/sling/distribution/journal/MessagingException.java#L21]
 extends from {{java.lang.RuntimeException}} which extends from 
{{java.lang.Exception}}. The catch block in 
[timedSendStoredStatus|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L663]
 catches {{MessagingException}} exceptions.

Case 2. Good point, we could catch {{java.lang.Throwable}} such that the 
metrics count all errors. However we should then re-throw all 
{{java.lang.Error}} exceptions instead of only the 
{{java.lang.VirtualMachineError}} exceptions.

> Missing out exceptions in catch clause in DistributionSubscriber class
> --
>
> Key: SLING-8374
> URL: https://issues.apache.org/jira/browse/SLING-8374
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.0
>Reporter: Alexei Krainiouk
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> There are two cases when catch clause is not catching necessary exceptions.
>  #  in 
> [DistributionSubscriber.timedSendStoredStatus|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L663]
>  method. Apparently the intent is to catch an exception thrown by 
> sendStatusMessage() method which in turn triggered by 
> [sender.send()|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
>  invocation. However sender.send() method throws MessagingException which 
> subclasses RuntimeError rather then Exception. As a result the exception is 
> never caught.
>  # in 
> [DistributionSubscriber.importPackage|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/subscriber/DistributionSubscriber.java#L690]
>  method. catch (Exception e) should be replaced with catch (Throwable e) in 
> order to count all possible errors in failedPackageImports metric.
> This pull request provides fixes for above issues: 
> [https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/3]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)