[jira] [Created] (SLING-8719) CMS - Add Support for Basic Forms

2019-09-18 Thread Dan Klco (Jira)
Dan Klco created SLING-8719:
---

 Summary: CMS - Add Support for Basic Forms
 Key: SLING-8719
 URL: https://issues.apache.org/jira/browse/SLING-8719
 Project: Sling
  Issue Type: Improvement
  Components: App CMS, App CMS Reference
Affects Versions: Version App CMS 0.12.0
Reporter: Dan Klco
 Fix For: App CMS 0.12.2


It would be a nice feature to show a basic form framework built in Apache Sling 
/ Sling CMS.

Included features:
 * Extensible actions
 * Basic Fields (textarea, textbox, select)
 * Extensible model for fields
 * Configurable look and feel
 * Extensible model for populating data
 * Basic security



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-8679) CMS - Update Health Check Support

2019-09-18 Thread Dan Klco (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Klco resolved SLING-8679.
-
Resolution: Fixed

Fixed in 
[https://github.com/apache/sling-org-apache-sling-app-cms/commit/c19ca94617f9723a917c145216c80f7845a4fe16]

[https://github.com/apache/sling-org-apache-sling-app-cms/commit/164e5e9d29cd3cef106cf43ba320a7ef769f2e63]

> CMS - Update Health Check Support
> -
>
> Key: SLING-8679
> URL: https://issues.apache.org/jira/browse/SLING-8679
> Project: Sling
>  Issue Type: New Feature
>  Components: App CMS
>Affects Versions: Version App CMS 0.12.0
>Reporter: Dan Klco
>Assignee: Dan Klco
>Priority: Major
> Fix For: App CMS 0.12.2
>
>
> Update the CMS to use Apache Felix Health checks to indicate if internal 
> features are configured. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-8576) NoClassDefFoundError for ScriptEngineManagerFactory

2019-09-18 Thread Stefan Seifert (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stefan Seifert resolved SLING-8576.
---
Fix Version/s: Testing Sling Mock 2.3.18
 Assignee: Stefan Seifert
   Resolution: Fixed

thanks, it's merged!
https://github.com/apache/sling-org-apache-sling-testing-sling-mock/commit/abaf290389f1a2066b98acc8a24419fd2bfdb55e


> NoClassDefFoundError for ScriptEngineManagerFactory
> ---
>
> Key: SLING-8576
> URL: https://issues.apache.org/jira/browse/SLING-8576
> Project: Sling
>  Issue Type: Bug
>  Components: Testing
>Affects Versions: Testing Sling Mock 2.3.14
>Reporter: Hans-Peter Stoerr
>Assignee: Stefan Seifert
>Priority: Minor
> Fix For: Testing Sling Mock 2.3.18
>
>
> When been upgrading our dependencies to the versions used in Sling Starter 
> 11, namely upgrading org.apache.sling.scripting.core to version 2.0.54, our 
> tests stopped working even when using the latest version 
> org.apache.sling.testing.sling-mock.core:2.3.14 with the following exception:
> java.lang.NoClassDefFoundError: 
> org/apache/sling/scripting/core/impl/ScriptEngineManagerFactory
> at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.registerDefaultServices(SlingContextImpl.java:153)
> at 
> org.apache.sling.testing.mock.sling.context.SlingContextImpl.setUp(SlingContextImpl.java:129)
> ...
> Caused by: java.lang.ClassNotFoundException: 
> org.apache.sling.scripting.core.impl.ScriptEngineManagerFactory
> The problem here is that the class 
> org.apache.sling.scripting.core.impl.ScriptEngineManagerFactory exists in the 
> sling.scripting.core:2.0.36 , which is used as a dependency of 
> sling-mock.core, but does not exist anymore in sling-scripting.core:2.0.54. 
> It would be nice if that could be fixed!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [sling-org-apache-sling-testing-sling-mock] stefanseifert merged pull request #3: Fix NoClassDefFoundError: ScriptEngineManagerFactory

2019-09-18 Thread GitBox
stefanseifert merged pull request #3: Fix NoClassDefFoundError: 
ScriptEngineManagerFactory
URL: https://github.com/apache/sling-org-apache-sling-testing-sling-mock/pull/3
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (SLING-8619) RepoInitGrammer: Add repository-level marker to pathsList

2019-09-18 Thread angela (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932612#comment-16932612
 ] 

angela commented on SLING-8619:
---

[~rombert], i had "repository" initially and changed it back and forth so, 
i don't have a strong preference here. in the JCR API it's a {{null}} value 
but as i said, i don't feel strongly about it.

> RepoInitGrammer: Add repository-level marker to pathsList
> -
>
> Key: SLING-8619
> URL: https://issues.apache.org/jira/browse/SLING-8619
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: angela
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: SLING-8619-jcr.patch, SLING-8619-parser.patch
>
>
> In order to be able to cover repository level access control entrieswith the 
> {{PrincipalAccessControlList}} (see SLING-8602), i would like to expand the 
> {{RepoInitGrammer.pathsList()}} such that it not only handles absolute paths 
> but in addition a marker for the repository level permissions (in JCR marked 
> with a _null_ path).
> essentially this would also create an alternative way to edit policies for 
> the _null_ path (today covered with _set repository ACL ..._).
> will provide a proposed patch and tests later this week.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-8619) RepoInitGrammer: Add repository-level marker to pathsList

2019-09-18 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932607#comment-16932607
 ] 

Robert Munteanu commented on SLING-8619:


Thanks for the patches [~angela], I think I managed to cover all dependencies 
and can start looking at this one now :-) . One thing that stands out on a 
cursory review is the usage of {{null}} to mean 'whole repository'. Maybe we 
can use something more descriptive like 'repository'? I assume that we never 
use relative paths here.

As for the documentation, what we have is at 
https://github.com/apache/sling-site/blob/master/src/main/jbake/content/documentation/bundles/repository-initialization.md
 .

/cc [~bdelacretaz] for the discussion on using null as the repository marker.

> RepoInitGrammer: Add repository-level marker to pathsList
> -
>
> Key: SLING-8619
> URL: https://issues.apache.org/jira/browse/SLING-8619
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: angela
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: SLING-8619-jcr.patch, SLING-8619-parser.patch
>
>
> In order to be able to cover repository level access control entrieswith the 
> {{PrincipalAccessControlList}} (see SLING-8602), i would like to expand the 
> {{RepoInitGrammer.pathsList()}} such that it not only handles absolute paths 
> but in addition a marker for the repository level permissions (in JCR marked 
> with a _null_ path).
> essentially this would also create an alternative way to edit policies for 
> the _null_ path (today covered with _set repository ACL ..._).
> will provide a proposed patch and tests later this week.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (SLING-8619) RepoInitGrammer: Add repository-level marker to pathsList

2019-09-18 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-8619:
--

Assignee: Robert Munteanu

> RepoInitGrammer: Add repository-level marker to pathsList
> -
>
> Key: SLING-8619
> URL: https://issues.apache.org/jira/browse/SLING-8619
> Project: Sling
>  Issue Type: Improvement
>  Components: Repoinit
>Reporter: angela
>Assignee: Robert Munteanu
>Priority: Major
> Attachments: SLING-8619-jcr.patch, SLING-8619-parser.patch
>
>
> In order to be able to cover repository level access control entrieswith the 
> {{PrincipalAccessControlList}} (see SLING-8602), i would like to expand the 
> {{RepoInitGrammer.pathsList()}} such that it not only handles absolute paths 
> but in addition a marker for the repository level permissions (in JCR marked 
> with a _null_ path).
> essentially this would also create an alternative way to edit policies for 
> the _null_ path (today covered with _set repository ACL ..._).
> will provide a proposed patch and tests later this week.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-8605) AclUtil.createLocalRestrictions should use JackrabbitAccessControlList.isMultiValueRestriction(String)

2019-09-18 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8605.

Resolution: Fixed

Reapplied in [sling-org-apache-sling-jcr-repoinit commit 
f142c89|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/f142c89],
 now that Jackrabbit and Oak versions are updated.

> AclUtil.createLocalRestrictions should use 
> JackrabbitAccessControlList.isMultiValueRestriction(String)
> --
>
> Key: SLING-8605
> URL: https://issues.apache.org/jira/browse/SLING-8605
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: angela
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Repoinit JCR 1.1.14
>
>
> today the {{AclUtil.createLocalRestrictions}} looks at the length of the 
> value array to determine if a given restriction is intended to be multivalued 
> or not. this may lead to an unexpected exception in cases where a single 
> value is defined for a restriction that is defined to be multivalued. instead 
> of looking at the length of the array, the code should make use of 
> {{JackrabbitAccessControlList.isMultiValueRestriction}} in order to find out 
> if a given restriction is multivalued or not.
> here the proposed change (also using the 'checkState' method that is part of 
> the patch for SLING-8604:
> {code}
> private static LocalRestrictions 
> createLocalRestrictions(List list, 
> JackrabbitAccessControlList jacl, Session s) throws RepositoryException {
> Map restrictions = new HashMap<>();
> Map mvrestrictions = new HashMap<>();
> if(list != null && !list.isEmpty()){
> ValueFactory vf = s.getValueFactory();
>for(RestrictionClause rc : list){
>String restrictionName = rc.getName();
>int type = jacl.getRestrictionType(restrictionName);
>boolean isMvRestriction = 
> jacl.isMultiValueRestriction(restrictionName);
>Value[] values = new Value[rc.getValues().size()];
>for(int i=0;ivalues[i] = vf.createValue(rc.getValues().get(i),type);
>}
>if("rep:glob".equals(restrictionName) && values.length == 0) {
>// SLING-7280 - special case for rep:glob which supports 
> an empty string
>// to mean "no values"
>restrictions.put(restrictionName, vf.createValue(""));
>} else if (isMvRestriction) {
>mvrestrictions.put(restrictionName, values);
>} else {
>checkState(values.length == 1, "Expected just one value 
> for single valued restriction with name " + restrictionName);
>restrictions.put(restrictionName, values[0]);
>}
>}
> }
> return new LocalRestrictions(restrictions,mvrestrictions);
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-8627) Update sling-jcr-repoinit to Oak 1.16.0 and Jackrabbit 2.18.2

2019-09-18 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu resolved SLING-8627.

Resolution: Fixed

[~angela] - I've update to the discussed Oak and Jackrabbit versions in 
[sling-org-apache-sling-jcr-repoinit commit 
534acf4|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/534acf4].
 Please reopen if something is missing.

> Update sling-jcr-repoinit to Oak 1.16.0 and Jackrabbit 2.18.2
> -
>
> Key: SLING-8627
> URL: https://issues.apache.org/jira/browse/SLING-8627
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Reporter: angela
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Repoinit JCR 1.1.14
>
> Attachments: SLING-8627.patch
>
>
> while working on the patch for SLING-8602 i noticed that the ITs are failing 
> as soon as i update oak and jackrabbit version in _sling-jcr-repoinit_. i 
> verified that by taking an unmodified checkout and just adjusting the the 
> _oak.version_ and _jackrabbit.version_ properties.
> the issue is (up to now) two fold:
> # the embedded org.apache.jackrabbit bundles in 
> _org.apache.sling.testing.sling-mock-oak_ (see SLING-8625) prevent the 
> configured oak/jackrabbit versions to take effect
> # once that is fix, the ITs (setup configuration with launchpad 9) will fail 
> the latter most likely require multiple changes
> - updating the _it-model.txt_ to list oak bundles in order to avoid 
> unresolved oak dependencies
> - once that is solved the ITs fail with missing SlingRepository service and 
> [~radu.cotescu] suspected that it might be required to additionally update 
> _org.apache.sling.jcr.oak.server_ to oak 1.16.0. if that turns out to be 
> needed i would cover it with another task.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (SLING-8605) AclUtil.createLocalRestrictions should use JackrabbitAccessControlList.isMultiValueRestriction(String)

2019-09-18 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reopened SLING-8605:


Actually I think this requires SLING-8627. Otherwise the code fails to compile. 
I reverted the change in [sling-org-apache-sling-jcr-repoinit commit 
5b7314e|https://github.com/apache/sling-org-apache-sling-jcr-repoinit/commit/5b7314e].

> AclUtil.createLocalRestrictions should use 
> JackrabbitAccessControlList.isMultiValueRestriction(String)
> --
>
> Key: SLING-8605
> URL: https://issues.apache.org/jira/browse/SLING-8605
> Project: Sling
>  Issue Type: Bug
>  Components: Repoinit
>Reporter: angela
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Repoinit JCR 1.1.14
>
>
> today the {{AclUtil.createLocalRestrictions}} looks at the length of the 
> value array to determine if a given restriction is intended to be multivalued 
> or not. this may lead to an unexpected exception in cases where a single 
> value is defined for a restriction that is defined to be multivalued. instead 
> of looking at the length of the array, the code should make use of 
> {{JackrabbitAccessControlList.isMultiValueRestriction}} in order to find out 
> if a given restriction is multivalued or not.
> here the proposed change (also using the 'checkState' method that is part of 
> the patch for SLING-8604:
> {code}
> private static LocalRestrictions 
> createLocalRestrictions(List list, 
> JackrabbitAccessControlList jacl, Session s) throws RepositoryException {
> Map restrictions = new HashMap<>();
> Map mvrestrictions = new HashMap<>();
> if(list != null && !list.isEmpty()){
> ValueFactory vf = s.getValueFactory();
>for(RestrictionClause rc : list){
>String restrictionName = rc.getName();
>int type = jacl.getRestrictionType(restrictionName);
>boolean isMvRestriction = 
> jacl.isMultiValueRestriction(restrictionName);
>Value[] values = new Value[rc.getValues().size()];
>for(int i=0;ivalues[i] = vf.createValue(rc.getValues().get(i),type);
>}
>if("rep:glob".equals(restrictionName) && values.length == 0) {
>// SLING-7280 - special case for rep:glob which supports 
> an empty string
>// to mean "no values"
>restrictions.put(restrictionName, vf.createValue(""));
>} else if (isMvRestriction) {
>mvrestrictions.put(restrictionName, values);
>} else {
>checkState(values.length == 1, "Expected just one value 
> for single valued restriction with name " + restrictionName);
>restrictions.put(restrictionName, values[0]);
>}
>}
> }
> return new LocalRestrictions(restrictions,mvrestrictions);
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Release Building Apache Sling Testing Clients 1.2.4

2019-09-18 Thread Radu Cotescu
+1

> On 18 Sep 2019, at 16:25, Andrei Dulvac  wrote:
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...



[jira] [Assigned] (SLING-8627) Update sling-jcr-repoinit to Oak 1.16.0 and Jackrabbit 2.18.2

2019-09-18 Thread Robert Munteanu (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Munteanu reassigned SLING-8627:
--

Assignee: Robert Munteanu

> Update sling-jcr-repoinit to Oak 1.16.0 and Jackrabbit 2.18.2
> -
>
> Key: SLING-8627
> URL: https://issues.apache.org/jira/browse/SLING-8627
> Project: Sling
>  Issue Type: Task
>  Components: Repoinit
>Reporter: angela
>Assignee: Robert Munteanu
>Priority: Major
> Fix For: Repoinit JCR 1.1.14
>
> Attachments: SLING-8627.patch
>
>
> while working on the patch for SLING-8602 i noticed that the ITs are failing 
> as soon as i update oak and jackrabbit version in _sling-jcr-repoinit_. i 
> verified that by taking an unmodified checkout and just adjusting the the 
> _oak.version_ and _jackrabbit.version_ properties.
> the issue is (up to now) two fold:
> # the embedded org.apache.jackrabbit bundles in 
> _org.apache.sling.testing.sling-mock-oak_ (see SLING-8625) prevent the 
> configured oak/jackrabbit versions to take effect
> # once that is fix, the ITs (setup configuration with launchpad 9) will fail 
> the latter most likely require multiple changes
> - updating the _it-model.txt_ to list oak bundles in order to avoid 
> unresolved oak dependencies
> - once that is solved the ITs fail with missing SlingRepository service and 
> [~radu.cotescu] suspected that it might be required to additionally update 
> _org.apache.sling.jcr.oak.server_ to oak 1.16.0. if that turns out to be 
> needed i would cover it with another task.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Release Building Apache Sling Testing Clients 1.2.4

2019-09-18 Thread Robert Munteanu
On Wed, 2019-09-18 at 16:25 +0200, Andrei Dulvac wrote:
> Please vote to approve this release:

+1

Robert


signature.asc
Description: This is a digitally signed message part


Re: [VOTE] Release Building Apache Sling Testing Clients 1.2.4

2019-09-18 Thread David Bosschaert
+1

David

On Wed, 18 Sep 2019 at 17:25, Andrei Dulvac  wrote:

> Hi,
>
> We solved 2 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12345717
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2131/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2121 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Have a great day!
> - Andrei
>


[VOTE] Release Building Apache Sling Testing Clients 1.2.4

2019-09-18 Thread Andrei Dulvac
Hi,

We solved 2 issues in this release:
https://issues.apache.org/jira/projects/SLING/versions/12345717

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2131/

You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2121 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Have a great day!
- Andrei


[jira] [Commented] (SLING-8702) Investigate automatically onboarding Sling projects to SonarCloud

2019-09-18 Thread Konrad Windszus (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932469#comment-16932469
 ] 

Konrad Windszus commented on SLING-8702:


[~bellingard] Do you have a public issue tracker with an issue for this feature 
that we can watch?

> Investigate automatically onboarding Sling projects to SonarCloud
> -
>
> Key: SLING-8702
> URL: https://issues.apache.org/jira/browse/SLING-8702
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> [~bellingard] - at our last Hackathon we discussed the option of 
> automatically onboarding projects to SonarCloud as they are created.  Is 
> there an API that we could use for this? Alternatively, can we somehow mark 
> the repositories in the ASF GitHub org for inclusion? We now have control of 
> the repository tags, for instance.
> Thanks!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-4330) Select script engines in SlingScriptAdapterFactory via mapping

2019-09-18 Thread Oliver Lietz (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932392#comment-16932392
 ] 

Oliver Lietz commented on SLING-4330:
-

Let's discuss on dev@sling.

> Select script engines in SlingScriptAdapterFactory via mapping
> --
>
> Key: SLING-4330
> URL: https://issues.apache.org/jira/browse/SLING-4330
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.28
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Core 2.0.60
>
>
> Running multiple script engines for same script (template) extension should 
> be possible.
> -Scripting Thymeleaf already provides that parameter, see 
> {{org.apache.sling.scripting.thymeleaf.SlingTemplateModeHandler#getPatternSpec():org.thymeleaf.PatternSpec}}.-
> Support for multiple script engines via mapping:
> {noformat}
> {
>   "sling:scripting": [
> "html=The HTL Templating Language:1.4",
> "js=ECMAScript:partial ECMAScript 2015 support"
>   ]
> }
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-4330) Select script engines in SlingScriptAdapterFactory via mapping

2019-09-18 Thread Oliver Lietz (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932391#comment-16932391
 ] 

Oliver Lietz commented on SLING-4330:
-

[~radu.cotescu], Moving {{SlingScriptEnginePicker}} to 
{{SlingScriptEngineManager}} is fine for me but we should consider the domains:
{{SlingScriptAdapterFactory}} is Sling ({{Resource}} API) and 
{{[ScriptEngineManager|https://docs.oracle.com/javase/8/docs/api/javax/script/ScriptEngineManager.html]}}
 is Java Scripting API (JSR 223)

{{SlingScriptEngineManager}} extends {{ScriptEngineManager}} and is only 
exposed as {{ScriptEngineManager}}. The API of {{ScriptEngineManager}} is quite 
poor and IMHO at least a method {{#getEngineByLanguage(String name, String 
version):ScriptEngine}} is missing (see also TODO in 
{{SlingScriptEnginePicker}} and {{Conditions}}).

In Scripting Thymeleaf we register the {{TemplateEngine}} as service 
{{ITemplateEngine}} – so there are already ways to get template and script 
engines for different use cases.

Can you describe the uses cases you have in mind?

How do you want to map a resource type to a script engine?

> Select script engines in SlingScriptAdapterFactory via mapping
> --
>
> Key: SLING-4330
> URL: https://issues.apache.org/jira/browse/SLING-4330
> Project: Sling
>  Issue Type: New Feature
>  Components: Scripting
>Affects Versions: Scripting Core 2.0.28
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
> Fix For: Scripting Core 2.0.60
>
>
> Running multiple script engines for same script (template) extension should 
> be possible.
> -Scripting Thymeleaf already provides that parameter, see 
> {{org.apache.sling.scripting.thymeleaf.SlingTemplateModeHandler#getPatternSpec():org.thymeleaf.PatternSpec}}.-
> Support for multiple script engines via mapping:
> {noformat}
> {
>   "sling:scripting": [
> "html=The HTL Templating Language:1.4",
> "js=ECMAScript:partial ECMAScript 2015 support"
>   ]
> }
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-8710) IndexingClient should have configurable lanes

2019-09-18 Thread Andrei Dulvac (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932390#comment-16932390
 ] 

Andrei Dulvac commented on SLING-8710:
--

Merged the PRs and added 
https://github.com/apache/sling-org-apache-sling-testing-clients/commit/09b429d7e4b1f69cccba9de1e7a1a25d0358a0dd

Will trigger a release later today.

> IndexingClient should have configurable lanes
> -
>
> Key: SLING-8710
> URL: https://issues.apache.org/jira/browse/SLING-8710
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Vikas Saurabh
>Priority: Major
>  Labels: sling-IT
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> {{IndexingClient}} currently relies on {{OsgiConsoleCient}} to peek into 
> system's lane configuration. That, in turn, requires access to 
> /system/console which might be blocked on the system which is being tested.
> As indexing lanes in a setup isn't a very dynamic property, a quick work 
> around could be for {{IndexingClient}} to allow setting up "expected index 
> lanes in target setup".
> This issue would be an improvement over what was implemented in SLING-7169. 
> [~rombert] and [~volteanu], since most of the comments over there are from 
> you guys, wdyt about this improvement?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-8710) IndexingClient should have configurable lanes

2019-09-18 Thread Andrei Dulvac (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac resolved SLING-8710.
--
Fix Version/s: Apache Sling Testing Clients 1.2.4
   Resolution: Fixed

> IndexingClient should have configurable lanes
> -
>
> Key: SLING-8710
> URL: https://issues.apache.org/jira/browse/SLING-8710
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Vikas Saurabh
>Priority: Major
>  Labels: sling-IT
> Fix For: Apache Sling Testing Clients 1.2.4
>
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> {{IndexingClient}} currently relies on {{OsgiConsoleCient}} to peek into 
> system's lane configuration. That, in turn, requires access to 
> /system/console which might be blocked on the system which is being tested.
> As indexing lanes in a setup isn't a very dynamic property, a quick work 
> around could be for {{IndexingClient}} to allow setting up "expected index 
> lanes in target setup".
> This issue would be an improvement over what was implemented in SLING-7169. 
> [~rombert] and [~volteanu], since most of the comments over there are from 
> you guys, wdyt about this improvement?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (SLING-8710) IndexingClient should have configurable lanes

2019-09-18 Thread Andrei Dulvac (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrei Dulvac updated SLING-8710:
-
Component/s: (was: Launchpad)
 Apache Sling Testing Clients

> IndexingClient should have configurable lanes
> -
>
> Key: SLING-8710
> URL: https://issues.apache.org/jira/browse/SLING-8710
> Project: Sling
>  Issue Type: Improvement
>  Components: Apache Sling Testing Clients
>Reporter: Vikas Saurabh
>Priority: Major
>  Labels: sling-IT
>  Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> {{IndexingClient}} currently relies on {{OsgiConsoleCient}} to peek into 
> system's lane configuration. That, in turn, requires access to 
> /system/console which might be blocked on the system which is being tested.
> As indexing lanes in a setup isn't a very dynamic property, a quick work 
> around could be for {{IndexingClient}} to allow setting up "expected index 
> lanes in target setup".
> This issue would be an improvement over what was implemented in SLING-7169. 
> [~rombert] and [~volteanu], since most of the comments over there are from 
> you guys, wdyt about this improvement?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (SLING-8698) Activate Apache Sling bnd Remove Parameters from OSGi Headers Plugin on SonarCloud

2019-09-18 Thread Oliver Lietz (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz closed SLING-8698.
---

> Activate Apache Sling bnd Remove Parameters from OSGi Headers Plugin on 
> SonarCloud
> --
>
> Key: SLING-8698
> URL: https://issues.apache.org/jira/browse/SLING-8698
> Project: Sling
>  Issue Type: Task
>Affects Versions: bnd Remove Parameters from OSGi Headers Plugin 1.0.0
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Project: 
> [sling-org-apache-sling-bnd-plugin-headers-parameters-remove|https://github.com/apache/sling-org-apache-sling-bnd-plugin-headers-parameters-remove]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-8698) Activate Apache Sling bnd Remove Parameters from OSGi Headers Plugin on SonarCloud

2019-09-18 Thread Oliver Lietz (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oliver Lietz resolved SLING-8698.
-
Resolution: Done

Thanks, [~bellingard]!

> Activate Apache Sling bnd Remove Parameters from OSGi Headers Plugin on 
> SonarCloud
> --
>
> Key: SLING-8698
> URL: https://issues.apache.org/jira/browse/SLING-8698
> Project: Sling
>  Issue Type: Task
>Affects Versions: bnd Remove Parameters from OSGi Headers Plugin 1.0.0
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Project: 
> [sling-org-apache-sling-bnd-plugin-headers-parameters-remove|https://github.com/apache/sling-org-apache-sling-bnd-plugin-headers-parameters-remove]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-8702) Investigate automatically onboarding Sling projects to SonarCloud

2019-09-18 Thread Robert Munteanu (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932351#comment-16932351
 ] 

Robert Munteanu commented on SLING-8702:


Thanks for the information [~bellingard] . I'll keep this ticket open for when 
that will happen. Where do you recommend that we look for information regarding 
this feature's availability, SonarCloud release notes - 
https://blog.sonarsource.com/product/SonarCloud?

> Investigate automatically onboarding Sling projects to SonarCloud
> -
>
> Key: SLING-8702
> URL: https://issues.apache.org/jira/browse/SLING-8702
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> [~bellingard] - at our last Hackathon we discussed the option of 
> automatically onboarding projects to SonarCloud as they are created.  Is 
> there an API that we could use for this? Alternatively, can we somehow mark 
> the repositories in the ASF GitHub org for inclusion? We now have control of 
> the repository tags, for instance.
> Thanks!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-8702) Investigate automatically onboarding Sling projects to SonarCloud

2019-09-18 Thread Fabrice Bellingard (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932334#comment-16932334
 ] 

Fabrice Bellingard commented on SLING-8702:
---

The Web API currently does not allow to onboard repositories (this action 
requires OAuth authentication from the user doing this, and this is done by the 
Web app for now). This is something we might work on in the near future, but no 
ETA yet.

> Investigate automatically onboarding Sling projects to SonarCloud
> -
>
> Key: SLING-8702
> URL: https://issues.apache.org/jira/browse/SLING-8702
> Project: Sling
>  Issue Type: Task
>  Components: Build and Source Control
>Reporter: Robert Munteanu
>Assignee: Robert Munteanu
>Priority: Major
>
> [~bellingard] - at our last Hackathon we discussed the option of 
> automatically onboarding projects to SonarCloud as they are created.  Is 
> there an API that we could use for this? Alternatively, can we somehow mark 
> the repositories in the ASF GitHub org for inclusion? We now have control of 
> the repository tags, for instance.
> Thanks!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (SLING-8698) Activate Apache Sling bnd Remove Parameters from OSGi Headers Plugin on SonarCloud

2019-09-18 Thread Fabrice Bellingard (Jira)


[ 
https://issues.apache.org/jira/browse/SLING-8698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932333#comment-16932333
 ] 

Fabrice Bellingard commented on SLING-8698:
---

Repo is onboarded, and Oliver is now part of the Sling group.

> Activate Apache Sling bnd Remove Parameters from OSGi Headers Plugin on 
> SonarCloud
> --
>
> Key: SLING-8698
> URL: https://issues.apache.org/jira/browse/SLING-8698
> Project: Sling
>  Issue Type: Task
>Affects Versions: bnd Remove Parameters from OSGi Headers Plugin 1.0.0
>Reporter: Oliver Lietz
>Assignee: Oliver Lietz
>Priority: Major
>
> Project: 
> [sling-org-apache-sling-bnd-plugin-headers-parameters-remove|https://github.com/apache/sling-org-apache-sling-bnd-plugin-headers-parameters-remove]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #320 is FIXED

2019-09-18 Thread Apache Jenkins Server
Please see 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/320/
 for details.

No further emails will be sent until the status of the build is changed.

[jira] [Closed] (SLING-8571) jspc-maven-plugin

2019-09-18 Thread mengln (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mengln closed SLING-8571.
-

> jspc-maven-plugin
> -
>
> Key: SLING-8571
> URL: https://issues.apache.org/jira/browse/SLING-8571
> Project: Sling
>  Issue Type: Wish
>Reporter: mengln
>Priority: Major
>
> Using jspc-maven-plugin in java11 At the beginning groupId 
> org.codehaus.mojo.jspc will report an error: can't find tools.jar, then 
> change to org.apache.sling also, I need help. Can other jspc plugins be used 
> in java11?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (SLING-8571) jspc-maven-plugin

2019-09-18 Thread mengln (Jira)


 [ 
https://issues.apache.org/jira/browse/SLING-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

mengln resolved SLING-8571.
---
Resolution: Fixed

> jspc-maven-plugin
> -
>
> Key: SLING-8571
> URL: https://issues.apache.org/jira/browse/SLING-8571
> Project: Sling
>  Issue Type: Wish
>Reporter: mengln
>Priority: Major
>
> Using jspc-maven-plugin in java11 At the beginning groupId 
> org.codehaus.mojo.jspc will report an error: can't find tools.jar, then 
> change to org.apache.sling also, I need help. Can other jspc plugins be used 
> in java11?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)