[jira] [Created] (SLING-9505) Failure to retry distributing content
Timothee Maret created SLING-9505:
-
Summary: Failure to retry distributing content
Key: SLING-9505
URL: https://issues.apache.org/jira/browse/SLING-9505
Project: Sling
Issue Type: Bug
Components: Content Distribution
Reporter: Timothee Maret
Assignee: Timothee Maret
Fix For: Content Distribution Core 0.4.4
{code}
05.06.2020 20:23:33.066 *ERROR* [127.0.0.1 [1591388613038] POST
/libs/sling/distribution/services/agents/publish-test HTTP/1.1]
org.apache.sling.distribution.agent.impl.SimpleDistributionAgent
[agent][publish-test] an error happened during package import
org.apache.sling.distribution.common.DistributionException:
org.apache.http.client.ClientProtocolException
at
org.apache.sling.distribution.transport.impl.SimpleHttpDistributionTransport.deliverPackage(SimpleHttpDistributionTransport.java:164)
[org.apache.sling.distribution.core:0.4.3.T202004281829-70214c0]
at
org.apache.sling.distribution.packaging.impl.importer.RemoteDistributionPackageImporter.importPackage(RemoteDistributionPackageImporter.java:69)
[org.apache.sling.distribution.core:0.4.3.T202004281829-70214c0]
at
org.apache.sling.distribution.agent.impl.ImportingDistributionPackageProcessor.process(ImportingDistributionPackageProcessor.java:78)
[org.apache.sling.distribution.core:0.4.3.T202004281829-70214c0]
at
org.apache.sling.distribution.packaging.impl.exporter.LocalDistributionPackageExporter.exportPackages(LocalDistributionPackageExporter.java:47)
[org.apache.sling.distribution.core:0.4.3.T202004281829-70214c0]
at
org.apache.sling.distribution.agent.impl.SimpleDistributionAgent.exportPackages(SimpleDistributionAgent.java:218)
[org.apache.sling.distribution.core:0.4.3.T202004281829-70214c0]
at
org.apache.sling.distribution.agent.impl.SimpleDistributionAgent.execute(SimpleDistributionAgent.java:182)
[org.apache.sling.distribution.core:0.4.3.T202004281829-70214c0]
at
org.apache.sling.distribution.servlet.DistributionAgentServlet.doPost(DistributionAgentServlet.java:62)
[org.apache.sling.distribution.core:0.4.3.T202004281829-70214c0]
at
org.apache.sling.api.servlets.SlingAllMethodsServlet.mayService(SlingAllMethodsServlet.java:146)
[org.apache.sling.api:2.22.0]
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:342)
[org.apache.sling.api:2.22.0]
at
org.apache.sling.api.servlets.SlingSafeMethodsServlet.service(SlingSafeMethodsServlet.java:374)
[org.apache.sling.api:2.22.0]
at
org.apache.sling.engine.impl.request.RequestData.service(RequestData.java:552)
[org.apache.sling.engine:2.7.2]
at
org.apache.sling.engine.impl.filter.SlingComponentFilterChain.render(SlingComponentFilterChain.java:44)
[org.apache.sling.engine:2.7.2]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:82)
[org.apache.sling.engine:2.7.2]
at
com.day.cq.wcm.core.impl.WCMDebugFilter.doFilter(WCMDebugFilter.java:138)
[com.day.cq.wcm.cq-wcm-core:5.13.122]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
[org.apache.sling.engine:2.7.2]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:78)
[org.apache.sling.engine:2.7.2]
at
com.day.cq.wcm.core.impl.WCMComponentFilter.filterRootInclude(WCMComponentFilter.java:375)
[com.day.cq.wcm.cq-wcm-core:5.13.122]
at
com.day.cq.wcm.core.impl.WCMComponentFilter.doFilter(WCMComponentFilter.java:190)
[com.day.cq.wcm.cq-wcm-core:5.13.122]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
[org.apache.sling.engine:2.7.2]
at
com.day.cq.wcm.core.impl.page.PageLockFilter.doFilter(PageLockFilter.java:91)
[com.day.cq.wcm.cq-wcm-core:5.13.122]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
[org.apache.sling.engine:2.7.2]
at
com.day.cq.personalization.impl.TargetComponentFilter.doFilter(TargetComponentFilter.java:94)
[com.day.cq.cq-personalization:5.13.14]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:72)
[org.apache.sling.engine:2.7.2]
at
org.apache.sling.engine.impl.SlingRequestProcessorImpl.processComponent(SlingRequestProcessorImpl.java:283)
[org.apache.sling.engine:2.7.2]
at
org.apache.sling.engine.impl.filter.RequestSlingFilterChain.render(RequestSlingFilterChain.java:49)
[org.apache.sling.engine:2.7.2]
at
org.apache.sling.engine.impl.filter.AbstractSlingFilterChain.doFilter(AbstractSlingFilterChain.java:76)
[org.apache.sling.engine:2.7.2]
at
org.apache.sl
[tooling] Launching feature model applications in testing
Hi, For SLING-9499 [1] I am looking into launching a feature model application as part of a Maven build, for integration testing. I have looked into what the current Maven tooling offers and found: - slingfeature-maven-plugin:launch-features, that launches a single application, in-process, blocking, based on one or more feature files - sling-kickstart-maven-plugin:start, that launches one or more kickstart jars, out-of-process, non-blocking What I am looking for is something in the middle: launch a single application, based on feature files, out-of-process, non-blocking. I guess adding multiple applications won't be that hard. I think that we can enhance the Maven tooling to better support starting and stopping 'pure' feature model applications. This will be useful for people developing on top of the feature model but not with Sling. Then we can rebase the kickstart tooling to take advantage of the new enhancements. Thoughts? Thanks, Robert [1]: https://issues.apache.org/jira/browse/SLING-9499
[jira] [Commented] (SLING-4443) Whitespace removal for Sightly HTML output
[ https://issues.apache.org/jira/browse/SLING-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17127088#comment-17127088 ] Jörg Hoh commented on SLING-4443: - This is still an issue; if have here a HTML page which is 30 MB (!!!) with > 25 MB of just whitespace. Of course mod_deflate makes that bearable, but it would definitely speed up a lot of processes if the whitespace would be removed. > Whitespace removal for Sightly HTML output > -- > > Key: SLING-4443 > URL: https://issues.apache.org/jira/browse/SLING-4443 > Project: Sling > Issue Type: New Feature > Components: Scripting >Affects Versions: Scripting Sightly Engine 1.0.0 >Reporter: Dan Chapman >Priority: Minor > > Can there be a way to remove whitespace from Sightly components HTML output, > that is created when elements are hidden e.g. Previously in JSPs we could use - trimDirectiveWhitespaces="true" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9499) Launchpad-Testing: branch which runs ITs against oak_tar feature model aggregate
[ https://issues.apache.org/jira/browse/SLING-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-9499: -- Assignee: Robert Munteanu > Launchpad-Testing: branch which runs ITs against oak_tar feature model > aggregate > > > Key: SLING-9499 > URL: https://issues.apache.org/jira/browse/SLING-9499 > Project: Sling > Issue Type: Sub-task > Components: Starter, Testing >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Launchpad Testing 12 > > > Create branch running ITs against the oak_tar aggregate created in the > previous step -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #10: SLING-9498 - Create feature model aggregates on the fly from the Sling Starter build
rombert merged pull request #10: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-9498) Create feature model aggregates on the fly from the Sling Starter build
[ https://issues.apache.org/jira/browse/SLING-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-9498. Resolution: Fixed Fixed with https://github.com/apache/sling-org-apache-sling-starter/pull/10 > Create feature model aggregates on the fly from the Sling Starter build > --- > > Key: SLING-9498 > URL: https://issues.apache.org/jira/browse/SLING-9498 > Project: Sling > Issue Type: Sub-task > Components: Starter >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: Starter 12 > > Time Spent: 1h > Remaining Estimate: 0h > > Create feature model aggregates on the fly from the build - oak_tar and > oak_mongo. This should use the feature-converter-maven-plugin to create the > feature files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #10: SLING-9498 - Create feature model aggregates on the fly from the Sling Starter build
sonarcloud[bot] commented on pull request #10: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/10#issuecomment-639777887 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=10&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=10) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=10&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=10&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_241) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request #10: SLING-9498 - Create feature model aggregates on the fly from the Sling Starter build
rombert opened a new pull request #10: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/10 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126866#comment-17126866 ] Carsten Ziegeler commented on SLING-9489: - As all of that is metadata, you could add a (boolean) configuration flag for comparing metadata But I would think that by default this should be off > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SLING-9489) Make it possible to compare parts of feature models
[ https://issues.apache.org/jira/browse/SLING-9489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126859#comment-17126859 ] A. J. David Bosschaert commented on SLING-9489: --- What about Artifact Metadata, aliases and start order? Should these match in the comparison? > Make it possible to compare parts of feature models > --- > > Key: SLING-9489 > URL: https://issues.apache.org/jira/browse/SLING-9489 > Project: Sling > Issue Type: New Feature > Components: Feature Model, Maven Plugins and Archetypes >Affects Versions: slingfeature-maven-plugin 1.3.4 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > We need a mojo that allows the comparison of parts of a feature model. If > these parts are not equal the mojo should fail the build. > Right now comparing extensions would be a good start. But comparing > configurations or bundles would also be good. > Key is that not everything needs to be compared. The configuration in the > pom.xml should specify what is being compared. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9495) Distributed Event is sending package type as distribution type
[
https://issues.apache.org/jira/browse/SLING-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dirk Rudolph reassigned SLING-9495:
---
Assignee: Dirk Rudolph
> Distributed Event is sending package type as distribution type
> --
>
> Key: SLING-9495
> URL: https://issues.apache.org/jira/browse/SLING-9495
> Project: Sling
> Issue Type: Bug
> Components: Content Distribution
>Affects Versions: Content Distribution Journal Core 0.1.10
>Reporter: Dirk Rudolph
>Assignee: Dirk Rudolph
>Priority: Major
>
> When using journal based content distribution the distributed event contains
> the package type instead of the distribution request type as distribution
> type.
> See the following series of events on the DistributionPublisher (author)
> |distribution.type|ADD|
> |distribution.component.kind|agent|
> |event.topics|*org/apache/sling/distribution/agent/package/created*|
> |distribution.package.id|dstrpck-159806534-03e0b77c-62fb-4781-8ec0-462a8a2e7e40|
> |distribution.paths|/content/wknd/ch/de|
> |distribution.component.name|journal|
> |distribution.type|ADD|
> |distribution.component.kind|agent|
> |event.topics|*org/apache/sling/distribution/agent/package/queued*|
> |distribution.package.id|dstrpck-159806534-03e0b77c-62fb-4781-8ec0-462a8a2e7e40
> |distribution.paths|/content/wknd/ch/de|
> |distribution.component.name|journal|
> |distribution.type|{color:red}default{color}|
> |distribution.component.kind|agent|
> |event.topics|*org/apache/sling/distribution/agent/package/distributed*|
> |distribution.package.id|dstrpck-159806534-03e0b77c-62fb-4781-8ec0-462a8a2e7e40|
> |distribution.paths|/content/wknd/ch/de|
> |distribution.component.name|journal|
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9504) Switch from protobuf to json
Christian Schneider created SLING-9504: -- Summary: Switch from protobuf to json Key: SLING-9504 URL: https://issues.apache.org/jira/browse/SLING-9504 Project: Sling Issue Type: Improvement Components: Content Distribution Affects Versions: Content Distribution Journal Messages 0.1.2 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: Content Distribution Journal Messages 0.1.8 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9501) Packages provided by a non-api-region enabled feature should be on par with the global region
[ https://issues.apache.org/jira/browse/SLING-9501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. J. David Bosschaert resolved SLING-9501. --- Resolution: Fixed > Packages provided by a non-api-region enabled feature should be on par with > the global region > - > > Key: SLING-9501 > URL: https://issues.apache.org/jira/browse/SLING-9501 > Project: Sling > Issue Type: Bug > Components: Feature Model >Affects Versions: Feature Model API Regions Runtime Fragment 1.1.2 >Reporter: A. J. David Bosschaert >Assignee: A. J. David Bosschaert >Priority: Major > Fix For: Feature Model API Regions Runtime Fragment 1.1.4 > > > The API Regions Runtime prefers packages coming from bundles that are in a > specific region to packages coming from the global region, if this specific > region is accessible to the requirer. This also applies to packages provided > from a bundle where this package is feature-local. > However, when a feature is not opting into the API Regions mechanism this > should not be applied. When a feature is not taking part in the API Regions > it should be considered to provide its packages in the global region and no > preference should be applied. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [sling-org-apache-sling-feature-apiregions] bosschaert merged pull request #11: SLING-9501 Packages provided by a non-api-region enabled feature should be on par with the global region
bosschaert merged pull request #11: URL: https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #830 is FIXED
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/830/ for details. No further emails will be sent until the status of the build is changed.
[GitHub] [sling-org-apache-sling-feature-apiregions] sonarcloud[bot] removed a comment on pull request #11: SLING-9501 Packages provided by a non-api-region enabled feature should be on par with the g
sonarcloud[bot] removed a comment on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/11#issuecomment-639399295 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_coverage&view=list) [86.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_241) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-apiregions] sonarcloud[bot] commented on pull request #11: SLING-9501 Packages provided by a non-api-region enabled feature should be on par with the global re
sonarcloud[bot] commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/11#issuecomment-639475246 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_coverage&view=list) [86.4% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_241) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-apiregions] sonarcloud[bot] commented on pull request #11: SLING-9501 Packages provided by a non-api-region enabled feature should be on par with the global re
sonarcloud[bot] commented on pull request #11: URL: https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/11#issuecomment-639399295 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_coverage&view=list) [86.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-apiregions&pullRequest=11&metric=new_duplicated_lines_density&view=list) The version of Java (1.8.0_241) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-feature-apiregions] bosschaert opened a new pull request #11: SLING-9501 Packages provided by a non-api-region enabled feature should be on par with the global region
bosschaert opened a new pull request #11: URL: https://github.com/apache/sling-org-apache-sling-feature-apiregions/pull/11 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (SLING-9503) Add control over variable replacement in feature models
[ https://issues.apache.org/jira/browse/SLING-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-9503. - Resolution: Fixed The replacement mechanism by default now only replaces project.artifactId, project.groupId, project.version and project.osgiVersion Added three new configuration properties - enableLegacyVariableReplacement : if set to true, the old mechanism is back in place - enableProjectVariableReplacement : if set to false, the above project variables are not replaced - replacePropertyVariables : comma separated list of properties from the maven project that are used in the replacement as well > Add control over variable replacement in feature models > --- > > Key: SLING-9503 > URL: https://issues.apache.org/jira/browse/SLING-9503 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > When a project feature model is read, a variable replacement based on the > maven project is performed over the whole feature text file > While the initial idea was to support "project.*" variables in the "id" of > the feature, it ended up as a way too flexible replacement mechanism > Variables are replaced in an unpredictable way, especially as also system > properties are used for replacement - which might result in having a > different replacement on different builds. > We should limit the replacement to the feature id - and only support > "project.*" variables there - and to a *configured* set of properties. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9503) Add control over variable replacement in feature models
[ https://issues.apache.org/jira/browse/SLING-9503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler updated SLING-9503: Fix Version/s: (was: Slingstart Maven Plugin 1.9.14) > Add control over variable replacement in feature models > --- > > Key: SLING-9503 > URL: https://issues.apache.org/jira/browse/SLING-9503 > Project: Sling > Issue Type: Improvement > Components: Feature Model, Maven Plugins and Archetypes >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: slingfeature-maven-plugin 1.3.6 > > > When a project feature model is read, a variable replacement based on the > maven project is performed over the whole feature text file > While the initial idea was to support "project.*" variables in the "id" of > the feature, it ended up as a way too flexible replacement mechanism > Variables are replaced in an unpredictable way, especially as also system > properties are used for replacement - which might result in having a > different replacement on different builds. > We should limit the replacement to the feature id - and only support > "project.*" variables there - and to a *configured* set of properties. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9503) Add control over variable replacement in feature models
Carsten Ziegeler created SLING-9503: --- Summary: Add control over variable replacement in feature models Key: SLING-9503 URL: https://issues.apache.org/jira/browse/SLING-9503 Project: Sling Issue Type: Improvement Components: Feature Model, Maven Plugins and Archetypes Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Slingstart Maven Plugin 1.9.14, slingfeature-maven-plugin 1.3.6 When a project feature model is read, a variable replacement based on the maven project is performed over the whole feature text file While the initial idea was to support "project.*" variables in the "id" of the feature, it ended up as a way too flexible replacement mechanism Variables are replaced in an unpredictable way, especially as also system properties are used for replacement - which might result in having a different replacement on different builds. We should limit the replacement to the feature id - and only support "project.*" variables there - and to a *configured* set of properties. -- This message was sent by Atlassian Jira (v8.3.4#803005)
