Re: Feature Model How-To Series Proposal

[Carsten Ziegeler]

Hi,

I think this is great and definitely needed. I like the proposal!

However (and this actually has little to do with your proposal) :) it 
raises the question of where/how we document things. At least parts are 
already covered in the feature documentation at:


https://github.com/apache/sling-org-apache-sling-feature/tree/master/docs

and also in the git repo of the slingmaven-feature-plugin

I think we should avoid having duplicate documentation which clearly 
will get out of sync over time.


Usually there is some documentation in each git repo, that's true for 
the feature model, the launcher, the maven plugin and some of the 
extensions. This is close to the code where changes happen.


Then we also have a published website for the slingfeature maven plugin 
- which is a poor (and pure) reference of the mojos - the better 
documentation is again in the git readme.


And then we have our website with additional/overlapping documentation.

Now, I don't want to open a big box here and I don't want to block such 
great contributions, but it would be great if we can agree on a single 
place where to document these things.


My preference is to use the git repos of the modules and simply have 
links from the website to them. The other way round works for me, too 
but then we need to move the existing documentation and the whole 
process gets more complicated.


Regards
Carsten

Am 17.06.2020 um 00:11 schrieb Gaston Gonzalez:

Hi All,

While working on the Sling Kickstart Launcher 
(https://github.com/apache/sling-org-apache-sling-kickstart 
), Ruben Reusser, 
Andreas Schaefer and myself thought that the community might benefit from some 
additional documentation around the Feature Model.

We have a preliminary draft written as a series of how-to documents. There are 
a few how-tos that we'd like to add to the series, but would like some feedback 
first to help gauge interest.

PR: https://github.com/apache/sling-site/pull/48 

JIRA: https://issues.apache.org/jira/browse/SLING-9522 


Here are some other how-to docs we're thinking of adding:

Feature Model JSON deep dive
Continue the Composite NodeStore example and demonstrate an application upgrade 
with the feature model
Feature Archive overview
Feature Model Launcher overview

Note: That the last two documents in the series currently fail during the Maven 
build due to SLING-9516.

Any and all feedback welcome.

Regards,
Gaston


Gaston Gonzalez
Senior Architect | www.headwire.com 





--
--
Carsten Ziegeler
Adobe Research Switzerland
cziege...@apache.org

[jira] [Commented] (SLING-7731) Call to addService is no longer needed for modification events in SlingAuthenticatorServiceListener

[Travis Estell (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-7731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17138121#comment-17138121
 ] 

Travis Estell commented on SLING-7731:
--

This bug is causing a major performance problem with my team's production 
application, because both modifiedService() and addService() get called on 
every modification event.

I have submitted a pull request here: 
https://github.com/apache/sling-org-apache-sling-auth-core/pull/3

> Call to addService is no longer needed for modification events in 
> SlingAuthenticatorServiceListener
> ---
>
> Key: SLING-7731
> URL: https://issues.apache.org/jira/browse/SLING-7731
> Project: Sling
>  Issue Type: Bug
>  Components: Authentication
>Affects Versions: Auth Core 1.3.18
>Reporter: Vincent Frey
>Priority: Major
>
> After introduction of modifiedService(...) method in 
> SlingAuthenticatorServiceListener, calling addService(...) is no longer 
> needed for modification event.
> [https://github.com/apache/sling-org-apache-sling-auth-core/blob/master/src/main/java/org/apache/sling/auth/core/impl/SlingAuthenticatorServiceListener.java#L85]
> Therefore line 85 should be changed from:
> {code}
> if ((event.getType() & (ServiceEvent.REGISTERED | ServiceEvent.MODIFIED)) != 
> 0) {
> {code}
> to:
> {code}
> if ((event.getType() & ServiceEvent.REGISTERED) != 0) {
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-org-apache-sling-auth-core] taestell opened a new pull request #3: Remove redundant call to addService after modifiedService is called.

[GitBox]

taestell opened a new pull request #3:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/3


   This fixes the Jira Issue: https://issues.apache.org/jira/browse/SLING-7731



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Resolved] (SLING-9516) Allow to specify execution environment as part of the feature model

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-9516.
-
Resolution: Fixed

Thanks for reporting, fixed in
https://github.com/apache/sling-org-apache-sling-feature-launcher/commit/5c16bc197d79417cf12ae45e82f353dd738a7176

> Allow to specify execution environment as part of the feature model
> ---
>
> Key: SLING-9516
> URL: https://issues.apache.org/jira/browse/SLING-9516
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Launcher 1.1.4, Feature Model Analyser 
> 1.2.8, Feature Model 1.2.2, slingfeature-maven-plugin 1.3.6
>
>
> It is currently not possible to specify in the feature model which framework 
> is used to launch the application. This results in repeatedly configuring 
> this information - in the launcher, for the analyser, in the slingfeature 
> maven plugin.
> We should add an extension capturing this information - this information can 
> then also be used if the requirements are met at launch time.
> Extension could look like this:
> {noformat}
> "execution-environment": {
>   "kind": "optional",
>   "type": "json",
>   "json": {
> "environment-capabilities”: [“osgi.ee(version=1.11)”,”...java 
> packages...”],
> "framework": {
>   "id" : "org.osgi:core:6.0.0"
> },
> "provided-bundles": ["org.osgi:logging:1.1“]
>   }
> }
> {noformat}
> We could start with a first implementation, just supporting the "framework" 
> property - and then enhance over time



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9522) Site documentation for Feature Model

[Gaston Gonzalez (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaston Gonzalez updated SLING-9522:
---
Description: 
While working on the Sling Kickstart Launcher, our team wrote a series of 
how-to documents around the Feature Model under the sling-site GitHub project. 

PR: [https://github.com/apache/sling-site/pull/48]

 

We'd like to contribute the series and expand on the how-to documents, but 
would appreciate some feedback first.

  was:
While working on the Sling Kickstart Launcher, our team wrote a series of 
how-to documents around the Feature Model under the sling-site GitHub project. 
We have a preliminary draft written as a series of how-to documents.  

PR: [https://github.com/apache/sling-site/pull/48]


> Site documentation for Feature Model
> 
>
> Key: SLING-9522
> URL: https://issues.apache.org/jira/browse/SLING-9522
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Gaston Gonzalez
>Priority: Trivial
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> While working on the Sling Kickstart Launcher, our team wrote a series of 
> how-to documents around the Feature Model under the sling-site GitHub 
> project. 
> PR: [https://github.com/apache/sling-site/pull/48]
>  
> We'd like to contribute the series and expand on the how-to documents, but 
> would appreciate some feedback first.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [sling-site] GastonGonzalez opened a new pull request #48: SLING-9522 -

[GitBox]

GastonGonzalez opened a new pull request #48:
URL: https://github.com/apache/sling-site/pull/48


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Feature Model How-To Series Proposal

[Gaston Gonzalez]

Hi All,

While working on the Sling Kickstart Launcher 
(https://github.com/apache/sling-org-apache-sling-kickstart 
), Ruben Reusser, 
Andreas Schaefer and myself thought that the community might benefit from some 
additional documentation around the Feature Model.

We have a preliminary draft written as a series of how-to documents. There are 
a few how-tos that we'd like to add to the series, but would like some feedback 
first to help gauge interest.

PR: https://github.com/apache/sling-site/pull/48 

JIRA: https://issues.apache.org/jira/browse/SLING-9522 


Here are some other how-to docs we're thinking of adding:

Feature Model JSON deep dive
Continue the Composite NodeStore example and demonstrate an application upgrade 
with the feature model
Feature Archive overview
Feature Model Launcher overview

Note: That the last two documents in the series currently fail during the Maven 
build due to SLING-9516.

Any and all feedback welcome.

Regards,
Gaston


Gaston Gonzalez
Senior Architect | www.headwire.com 

[jira] [Created] (SLING-9522) Site documentation for Feature Model

[Gaston Gonzalez (Jira)]

Gaston Gonzalez created SLING-9522:
--

 Summary: Site documentation for Feature Model
 Key: SLING-9522
 URL: https://issues.apache.org/jira/browse/SLING-9522
 Project: Sling
  Issue Type: Improvement
  Components: Feature Model
Reporter: Gaston Gonzalez


While working on the Sling Kickstart Launcher, our team wrote a series of 
how-to documents around the Feature Model under the sling-site GitHub project. 
We have a preliminary draft written as a series of how-to documents.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9522) Site documentation for Feature Model

[Gaston Gonzalez (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaston Gonzalez updated SLING-9522:
---
Description: 
While working on the Sling Kickstart Launcher, our team wrote a series of 
how-to documents around the Feature Model under the sling-site GitHub project. 
We have a preliminary draft written as a series of how-to documents.  

PR: [https://github.com/apache/sling-site/pull/48]

  was:While working on the Sling Kickstart Launcher, our team wrote a series of 
how-to documents around the Feature Model under the sling-site GitHub project. 
We have a preliminary draft written as a series of how-to documents.  


> Site documentation for Feature Model
> 
>
> Key: SLING-9522
> URL: https://issues.apache.org/jira/browse/SLING-9522
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Gaston Gonzalez
>Priority: Trivial
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> While working on the Sling Kickstart Launcher, our team wrote a series of 
> how-to documents around the Feature Model under the sling-site GitHub 
> project. We have a preliminary draft written as a series of how-to documents. 
>  
> PR: [https://github.com/apache/sling-site/pull/48]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Reopened] (SLING-9516) Allow to specify execution environment as part of the feature model

[Andreas Schaefer (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Schaefer reopened SLING-9516:
-

I using the Feature Launcher in Kickstart and w/o this is breaking now. If I 
reverse the changes in Bootstrap line 154 with the original code it works 
otherwise I get an NPE because Bootstrap.

getFrameworkArtifactId() returns null.

> Allow to specify execution environment as part of the feature model
> ---
>
> Key: SLING-9516
> URL: https://issues.apache.org/jira/browse/SLING-9516
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Launcher 1.1.4, Feature Model Analyser 
> 1.2.8, Feature Model 1.2.2, slingfeature-maven-plugin 1.3.6
>
>
> It is currently not possible to specify in the feature model which framework 
> is used to launch the application. This results in repeatedly configuring 
> this information - in the launcher, for the analyser, in the slingfeature 
> maven plugin.
> We should add an extension capturing this information - this information can 
> then also be used if the requirements are met at launch time.
> Extension could look like this:
> {noformat}
> "execution-environment": {
>   "kind": "optional",
>   "type": "json",
>   "json": {
> "environment-capabilities”: [“osgi.ee(version=1.11)”,”...java 
> packages...”],
> "framework": {
>   "id" : "org.osgi:core:6.0.0"
> },
> "provided-bundles": ["org.osgi:logging:1.1“]
>   }
> }
> {noformat}
> We could start with a first implementation, just supporting the "framework" 
> property - and then enhance over time



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9476) Journal IT tests fail due to wrong assumptions

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-9476:
--
Summary: Journal IT tests fail due to wrong assumptions  (was: Journal IT 
tests fail)

> Journal IT tests fail due to wrong assumptions
> --
>
> Key: SLING-9476
> URL: https://issues.apache.org/jira/browse/SLING-9476
> Project: Sling
>  Issue Type: Bug
>  Components: Content Distribution
>Reporter: Timothee Maret
>Assignee: Timothee Maret
>Priority: Major
> Fix For: Content Distribution Journal ITs 0.1.2
>
>
> Since the change SLING-9460, some IT test fail
> https://builds.apache.org/job/Sling/job/sling-org-apache-sling-distribution-journal-it/
> AuthorDistributeTest.testDistribute



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9504) Switch from protobuf to json

[Timothee Maret (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothee Maret updated SLING-9504:
--
Fix Version/s: (was: Content Distribution Journal Messages 0.1.8)
   Content Distribution Journal Messages 0.1.10

> Switch from protobuf to json
> 
>
> Key: SLING-9504
> URL: https://issues.apache.org/jira/browse/SLING-9504
> Project: Sling
>  Issue Type: Improvement
>  Components: Content Distribution
>Affects Versions: Content Distribution Journal Messages 0.1.2
>Reporter: Christian Schneider
>Assignee: Christian Schneider
>Priority: Major
> Fix For: Content Distribution Journal Messages 0.1.10
>
>
> Protobuf has the problem that it is difficult to diagnose. We would like to 
> switch all messages to json payload. 
> This is an incompatible change. So data of running instances will have to be 
> migrated to the new format or old messages will be lost.
> A good way for migration is to wait until the queues are empty. This way only 
> history in kafka is lost but there is no risk of inconsistencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (SLING-9521) Packages exported in earlier API Regions are not available to later API Regions

[A. J. David Bosschaert (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

A. J. David Bosschaert updated SLING-9521:
--
Description: 
The API Regions documentation states that "Exports declared earlier in the 
api-regions array also apply to later elements in the array, so the platform 
region also contains all exports declared for the global region" [0] 
However the API Regions runtime fragment doesn't honour this.

As a test case take 2 feature models:

Feature Model A:
* exports package {{foo.bar}} into region r1.
* exports package {{foo.test}} into region r2.
Note that according to the documentation mentioned above this means that 
{{foo.bar}} is also implicitly exported into region r2.

Feature Model B:
* exports package {{test.abc}} into region r2. 
Note that feature model B does not explicitly opt into region r1.

Feature Model B also contains a bundle that imports {{foo.bar}}. However 
running these feature models together, the API Regions runtime fragment 
prevents Feature Model B from seeing the {{foo.bar}} package.

[0] 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/blob/master/docs/api-regions.md#visibility-of-api

  was:
The API Regions documentation states that "Exports declared earlier in the 
api-regions array also apply to later elements in the array, so the platform 
region also contains all exports declared for the global region" [0] 
However the API Regions runtime fragment doesn't honour this.

As a test case take 2 feature models:

Feature Model A:
* exports package {{foo.bar}} into region r1.
* exports package {{foo.test}} into region r2.

Feature Model B:
* joing API region r2 by exporting package {{test.abc}} into region r2. 
Note that feature model B does not explicitly opt into region r1.

Feature Model B also contains a bundle that imports {{foo.bar}}. However 
running these feature models together, the API Regions runtime fragment 
prevents Feature Model B from seeing the {{foo.bar}} package.

[0] 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/blob/master/docs/api-regions.md#visibility-of-api


> Packages exported in earlier API Regions are not available to later API 
> Regions
> ---
>
> Key: SLING-9521
> URL: https://issues.apache.org/jira/browse/SLING-9521
> Project: Sling
>  Issue Type: Bug
>  Components: Feature Model
>Affects Versions: Feature Model API Regions Runtime Fragment 1.1.4
>Reporter: A. J. David Bosschaert
>Priority: Major
>
> The API Regions documentation states that "Exports declared earlier in the 
> api-regions array also apply to later elements in the array, so the platform 
> region also contains all exports declared for the global region" [0] 
> However the API Regions runtime fragment doesn't honour this.
> As a test case take 2 feature models:
> Feature Model A:
> * exports package {{foo.bar}} into region r1.
> * exports package {{foo.test}} into region r2.
> Note that according to the documentation mentioned above this means that 
> {{foo.bar}} is also implicitly exported into region r2.
> Feature Model B:
> * exports package {{test.abc}} into region r2. 
> Note that feature model B does not explicitly opt into region r1.
> Feature Model B also contains a bundle that imports {{foo.bar}}. However 
> running these feature models together, the API Regions runtime fragment 
> prevents Feature Model B from seeing the {{foo.bar}} package.
> [0] 
> https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/blob/master/docs/api-regions.md#visibility-of-api



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9521) Packages exported in earlier API Regions are not available to later API Regions

[A. J. David Bosschaert (Jira)]

A. J. David Bosschaert created SLING-9521:
-

 Summary: Packages exported in earlier API Regions are not 
available to later API Regions
 Key: SLING-9521
 URL: https://issues.apache.org/jira/browse/SLING-9521
 Project: Sling
  Issue Type: Bug
  Components: Feature Model
Affects Versions: Feature Model API Regions Runtime Fragment 1.1.4
Reporter: A. J. David Bosschaert


The API Regions documentation states that "Exports declared earlier in the 
api-regions array also apply to later elements in the array, so the platform 
region also contains all exports declared for the global region" [0] 
However the API Regions runtime fragment doesn't honour this.

As a test case take 2 feature models:

Feature Model A:
* exports package {{foo.bar}} into region r1.
* exports package {{foo.test}} into region r2.

Feature Model B:
* joing API region r2 by exporting package {{test.abc}} into region r2. 
Note that feature model B does not explicitly opt into region r1.

Feature Model B also contains a bundle that imports {{foo.bar}}. However 
running these feature models together, the API Regions runtime fragment 
prevents Feature Model B from seeing the {{foo.bar}} package.

[0] 
https://github.com/apache/sling-org-apache-sling-feature-extension-apiregions/blob/master/docs/api-regions.md#visibility-of-api



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9519) Modules to add to SonarCloud

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136764#comment-17136764
 ] 

Bertrand Delacretaz commented on SLING-9519:


In case you need the build URLs that's
* 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-graphql-core/job/master/
* 
https://builds.apache.org/job/Sling/job/sling-org-apache-sling-pipes/job/master/

> Modules to add to SonarCloud
> 
>
> Key: SLING-9519
> URL: https://issues.apache.org/jira/browse/SLING-9519
> Project: Sling
>  Issue Type: Task
>  Components: CI
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> Let's use this ticket to batch a few such requests ( 
> https://cwiki.apache.org/confluence/display/SLING/SonarCloud+analysis )
> So far:
> * https://github.com/apache/sling-org-apache-sling-graphql-core/
> * https://github.com/apache/sling-org-apache-sling-pipes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (SLING-9519) Modules to add to SonarCloud

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136762#comment-17136762
 ] 

Bertrand Delacretaz edited comment on SLING-9519 at 6/16/20, 3:56 PM:
--

Bonjour [~bellingard], could you please enable SonarQube integration for the 
two repositories mentioned in this ticket?

Thanks in advance!


was (Author: bdelacretaz):
Bonjour @bellingard , could you please enable SonarQube integration for the two 
repositories mentioned in this ticket?

Thanks in advance!

> Modules to add to SonarCloud
> 
>
> Key: SLING-9519
> URL: https://issues.apache.org/jira/browse/SLING-9519
> Project: Sling
>  Issue Type: Task
>  Components: CI
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> Let's use this ticket to batch a few such requests ( 
> https://cwiki.apache.org/confluence/display/SLING/SonarCloud+analysis )
> So far:
> * https://github.com/apache/sling-org-apache-sling-graphql-core/
> * https://github.com/apache/sling-org-apache-sling-pipes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (SLING-9519) Modules to add to SonarCloud

[Bertrand Delacretaz (Jira)]

[ 
https://issues.apache.org/jira/browse/SLING-9519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136762#comment-17136762
 ] 

Bertrand Delacretaz commented on SLING-9519:


Bonjour @bellingard , could you please enable SonarQube integration for the two 
repositories mentioned in this ticket?

Thanks in advance!

> Modules to add to SonarCloud
> 
>
> Key: SLING-9519
> URL: https://issues.apache.org/jira/browse/SLING-9519
> Project: Sling
>  Issue Type: Task
>  Components: CI
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
>
> Let's use this ticket to batch a few such requests ( 
> https://cwiki.apache.org/confluence/display/SLING/SonarCloud+analysis )
> So far:
> * https://github.com/apache/sling-org-apache-sling-graphql-core/
> * https://github.com/apache/sling-org-apache-sling-pipes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling GraphQL Core 0.0.2, Servlet Helpers 1.4.2

[Nicolas Peltier]

+1

Le mar. 16 juin 2020 à 11:33, Bertrand Delacretaz 
a écrit :

> Hi Radu,
>
> On Tue, Jun 16, 2020 at 10:58 AM Radu Cotescu  wrote:
> > ...Is there any reason for which we don’t have a JIRA release for the
> Sling GraphQL Core module?..
>
> My laziness maybe ;-)
>
> I have created it now,
> https://issues.apache.org/jira/projects/SLING/versions/12348396
>
> I didn't create JIRA tickets for this first version, just one -
> that'll be more serious when that first version is out.
>
> I have it on my list to document this new module at
> https://sling.apache.org
>
> -Bertrand
>

[jira] [Resolved] (SLING-9516) Allow to specify execution environment as part of the feature model

[Carsten Ziegeler (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Carsten Ziegeler resolved SLING-9516.
-
Resolution: Fixed

> Allow to specify execution environment as part of the feature model
> ---
>
> Key: SLING-9516
> URL: https://issues.apache.org/jira/browse/SLING-9516
> Project: Sling
>  Issue Type: Improvement
>  Components: Feature Model
>Reporter: Carsten Ziegeler
>Assignee: Carsten Ziegeler
>Priority: Major
> Fix For: Feature Model Launcher 1.1.4, Feature Model Analyser 
> 1.2.8, Feature Model 1.2.2, slingfeature-maven-plugin 1.3.6
>
>
> It is currently not possible to specify in the feature model which framework 
> is used to launch the application. This results in repeatedly configuring 
> this information - in the launcher, for the analyser, in the slingfeature 
> maven plugin.
> We should add an extension capturing this information - this information can 
> then also be used if the requirements are met at launch time.
> Extension could look like this:
> {noformat}
> "execution-environment": {
>   "kind": "optional",
>   "type": "json",
>   "json": {
> "environment-capabilities”: [“osgi.ee(version=1.11)”,”...java 
> packages...”],
> "framework": {
>   "id" : "org.osgi:core:6.0.0"
> },
> "provided-bundles": ["org.osgi:logging:1.1“]
>   }
> }
> {noformat}
> We could start with a first implementation, just supporting the "framework" 
> property - and then enhance over time



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9520) Expose the script name in the BundledScriptServlet

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9520.
-
Resolution: Fixed

Fixed in [commit 
f0183ec|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/f0183ec].

> Expose the script name in the BundledScriptServlet
> --
>
> Key: SLING-9520
> URL: https://issues.apache.org/jira/browse/SLING-9520
> Project: Sling
>  Issue Type: Bug
>  Components: Servlets
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Servlets Resolver 2.6.6
>
>
> The 
> {{org.apache.sling.servlets.resolver.bundle.tracker.internal.BundledScriptServlet}}
>  should expose the script name on behalf of which the rendering is performed. 
> This should be exposed in a similar way to the 
> {{org.apache.sling.scripting.core.impl.DefaultSlingScript#getServletInfo}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (SLING-9520) Expose the script name in the BundledScriptServlet

[Radu Cotescu (Jira)]

Radu Cotescu created SLING-9520:
---

 Summary: Expose the script name in the BundledScriptServlet
 Key: SLING-9520
 URL: https://issues.apache.org/jira/browse/SLING-9520
 Project: Sling
  Issue Type: Bug
  Components: Servlets
Reporter: Radu Cotescu
Assignee: Radu Cotescu
 Fix For: Servlets Resolver 2.6.6


The 
{{org.apache.sling.servlets.resolver.bundle.tracker.internal.BundledScriptServlet}}
 should expose the script name on behalf of which the rendering is performed. 
This should be exposed in a similar way to the 
{{org.apache.sling.scripting.core.impl.DefaultSlingScript#getServletInfo}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (SLING-9475) Do not register servlets using the default methods for bundled scripts

[Radu Cotescu (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radu Cotescu resolved SLING-9475.
-
Resolution: Fixed

Fixed in [commit 
b224407|https://github.com/apache/sling-org-apache-sling-servlets-resolver/commit/b224407].

> Do not register servlets using the default methods for bundled scripts
> --
>
> Key: SLING-9475
> URL: https://issues.apache.org/jira/browse/SLING-9475
> Project: Sling
>  Issue Type: Bug
>  Components: Scripting
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Servlets Resolver 2.6.6
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The 
> {{org.apache.sling.servlets.resolver.bundle.tracker.internal.BundledScriptTracker}}
>  should not allow servlets registered on the default methods for bundled 
> scripts if the capabilities don't explicitly define their own HTTP methods; 
> otherwise the registered servlets override the Default GET Servlet.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling GraphQL Core 0.0.2, Servlet Helpers 1.4.2

[Bertrand Delacretaz]

Hi Radu,

On Tue, Jun 16, 2020 at 10:58 AM Radu Cotescu  wrote:
> ...Is there any reason for which we don’t have a JIRA release for the Sling 
> GraphQL Core module?..

My laziness maybe ;-)

I have created it now,
https://issues.apache.org/jira/projects/SLING/versions/12348396

I didn't create JIRA tickets for this first version, just one -
that'll be more serious when that first version is out.

I have it on my list to document this new module at https://sling.apache.org

-Bertrand

[jira] [Updated] (SLING-9479) GraphQL fetcher comments convert to headings in GraphiQL docs

[Bertrand Delacretaz (Jira)]

 [ 
https://issues.apache.org/jira/browse/SLING-9479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bertrand Delacretaz updated SLING-9479:
---
Fix Version/s: GraphQL Core 0.0.2

> GraphQL fetcher comments convert to headings in GraphiQL docs
> -
>
> Key: SLING-9479
> URL: https://issues.apache.org/jira/browse/SLING-9479
> Project: Sling
>  Issue Type: Bug
>  Components: GraphQL
>Reporter: Bertrand Delacretaz
>Assignee: Bertrand Delacretaz
>Priority: Minor
> Fix For: GraphQL Core 0.0.2
>
>
> The GraphQL core currently uses comments like this to map fields to 
> DataFetchers:
> {code}
> ## fetch:samples/seeAlso
> {code}
> A common tool to look at those schemas is GraphiQL, which converts such 
> comments to headings, considering them to be Markdown.
> We should switch to a less intrusive marker that converts nicely to Markdown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [VOTE] Release Apache Sling GraphQL Core 0.0.2, Servlet Helpers 1.4.2

[Radu Cotescu]

Hi Bertrand,

Is there any reason for which we don’t have a JIRA release for the Sling 
GraphQL Core module?

Thanks,
Radu

> On 15 Jun 2020, at 17:25, Bertrand Delacretaz  wrote:
> 
> Hi,
> 
> It's the first release of the GraphQL Core module, and for the servlet
> helpers we fixed 4 issues:
> 
> https://issues.apache.org/jira/projects/SLING/versions/12346473
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2279/
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2279 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Here's my +1
> 
> -Bertrand

Re: [Discuss] Thoughts about renaming the 'master' branches to 'main'?

[Robert Munteanu]

On Mon, 2020-06-15 at 20:34 +0100, David Bosschaert wrote:
> I've created the wiki page to list actions take:
> 
> https://cwiki.apache.org/confluence/display/SLING/Removal+of+problematic+language
> 
> Best regards,

Thanks, David.

I've added some information to the wiki page based, including
references to [1] as a source of potential terms.

Thanks,
Robert


[1]: https://tools.ietf.org/id/draft-knodel-terminology-00.html

> 
> David
> 
> On Mon, 15 Jun 2020 at 17:14, Robert Munteanu 
> wrote:
> 
> > On Mon, 2020-06-15 at 17:10 +0100, David Bosschaert wrote:
> > > I just tried to create a wiki page where we can collaborate on
> > > this,
> > > but
> > > found out that I have no rights to create a page on the SLING
> > > wiki...
> > 
> > Hm. Can you please ask Infra? Permissions are managed via groups,
> > which
> > (I think) are synced from LDAP.
> > 
> > Thanks,
> > Robert
> > 
> > > Best regards,
> > > 
> > > David
> > > 
> > > On Mon, 15 Jun 2020 at 16:37, Bertrand Delacretaz <
> > > bdelacre...@apache.org>
> > > wrote:
> > > 
> > > > On Mon, Jun 15, 2020 at 5:30 PM Robert Munteanu <
> > > > romb...@apache.org
> > > > wrote:
> > > > > ...Let's please start by collecting all the required changes
> > > > > in a
> > > > > wiki
> > > > > page and seeing whether we have consensus on the change and
> > > > > whether we
> > > > > think it has a positive impact for the project...
> > > > 
> > > > Big +1 to this, thank you Robert for spelling out in
> > > > (tentative)
> > > > detail the "lots of work" that I envisioned.
> > > > 
> > > > -Bertrand
> > > >