[jira] [Commented] (SLING-9537) Emit metric for error accessing queues
[ https://issues.apache.org/jira/browse/SLING-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141725#comment-17141725 ] Amit Jain commented on SLING-9537: -- PR [https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/42] cc/ [~tmaret] > Emit metric for error accessing queues > -- > > Key: SLING-9537 > URL: https://issues.apache.org/jira/browse/SLING-9537 > Project: Sling > Issue Type: Improvement > Components: Content Distribution >Reporter: Amit Jain >Priority: Major > > Currently the errors (exceptions) when getting the queues are not measurred. > This error measure correspond to an API entry point (e.g. SCD > [getQueue|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L235-L236] > for DistributionAgent API). It will capture errors such as failures to seed > caches and more generally any failure getting the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9537) Emit metric for error accessing queues
Amit Jain created SLING-9537: Summary: Emit metric for error accessing queues Key: SLING-9537 URL: https://issues.apache.org/jira/browse/SLING-9537 Project: Sling Issue Type: Improvement Components: Content Distribution Reporter: Amit Jain Currently the errors (exceptions) when getting the queues are not measurred. This error measure correspond to an API entry point (e.g. SCD [getQueue|https://github.com/apache/sling-org-apache-sling-distribution-journal/blob/master/src/main/java/org/apache/sling/distribution/journal/impl/publisher/DistributionPublisher.java#L235-L236] for DistributionAgent API). It will capture errors such as failures to seed caches and more generally any failure getting the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9535) Improve performance of sling:alias Query when Optimize alias resolution is activated
[
https://issues.apache.org/jira/browse/SLING-9535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Derks updated SLING-9535:
--
Description:
Improve performance of sling:alias Query when Optimize alias resolution is
activated in the Resource Resolver Factory:
!image-2020-06-19-18-29-24-335.png!
By checking the logs at startup this query is executed:
{noformat}
(query=SELECT sling:alias FROM nt:base WHERE sling:alias IS NOT NULL, path=*,
property=[sling:alias=[is not null]]){noformat}
*The part that will be good to improve is that the query is not executed for
path=*, instead a predefined set of locations is used.*
(Something similar as it is for the Vanity Paths will be nice):
!image-2020-06-19-18-33-21-657.png!
Then if none fo these are configured then the query is executed with path=*.
In our project several versions are created per page and it turns out that the
sling:alias found under _/jcr:system/jcr:versionStorage_ are also including in
the query exceeding the 1 limit mentioned in the warning message of the
property:
_This might have an impact on the startup time and on the alias update time if
the number of aliases is huge (over 1)_
We might have a different approach to solve our issue but did not want to leave
this topic in the air. Might be also a good improvement for others.
Thanks
was:
Improve performance of sling:alias Query when Optimize alias resolution is
activated in the Resource Resolver Factory:
!image-2020-06-19-18-29-24-335.png!
By checking the logs at startup this query is executed:
{noformat}
(query=SELECT sling:alias FROM nt:base WHERE sling:alias IS NOT NULL, path=*,
property=[sling:alias=[is not null]]){noformat}
*The part that will be good to improve is that the query is not executed for
path=*, instead a predefined set of locations is used.*
(Something similar as it is for the Vanity Paths will be nice):
!image-2020-06-19-18-33-21-657.png!
Then if none fo these are configured the the query is executed with path=*.
In our project several versions are created per page and it turns out that the
sling:alias found under _/jcr:system/jcr:versionStorage_ are also including in
the query exceeding the 1 limit mentioned in the warning message of the
property:
_This might have an impact on the startup time and on the alias update time if
the number of aliases is huge (over 1)_
We might have a different approach to solve our issue but did not want to leave
this topic in the air. Might be also a good improvement for others.
Thanks
> Improve performance of sling:alias Query when Optimize alias resolution is
> activated
>
>
> Key: SLING-9535
> URL: https://issues.apache.org/jira/browse/SLING-9535
> Project: Sling
> Issue Type: Improvement
> Components: ResourceResolver
>Reporter: Leonardo Derks
>Priority: Major
> Attachments: image-2020-06-19-18-29-24-335.png,
> image-2020-06-19-18-33-21-657.png
>
>
> Improve performance of sling:alias Query when Optimize alias resolution is
> activated in the Resource Resolver Factory:
> !image-2020-06-19-18-29-24-335.png!
> By checking the logs at startup this query is executed:
> {noformat}
> (query=SELECT sling:alias FROM nt:base WHERE sling:alias IS NOT NULL, path=*,
> property=[sling:alias=[is not null]]){noformat}
> *The part that will be good to improve is that the query is not executed for
> path=*, instead a predefined set of locations is used.*
> (Something similar as it is for the Vanity Paths will be nice):
> !image-2020-06-19-18-33-21-657.png!
> Then if none fo these are configured then the query is executed with path=*.
>
> In our project several versions are created per page and it turns out that
> the sling:alias found under _/jcr:system/jcr:versionStorage_ are also
> including in the query exceeding the 1 limit mentioned in the warning
> message of the property:
> _This might have an impact on the startup time and on the alias update time
> if the number of aliases is huge (over 1)_
>
> We might have a different approach to solve our issue but did not want to
> leave this topic in the air. Might be also a good improvement for others.
>
> Thanks
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-8706) Injections for java.util.Optional<> should be automatic optional
[
https://issues.apache.org/jira/browse/SLING-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141464#comment-17141464
]
Jörg Hoh commented on SLING-8706:
-
[~sseifert], [~justin] ,[~kwin] : WDYT about the linked PR by [~etugarev]?
I would really love to have that feature available because it helps to make
sling models more resilient against declared but unimplemented behavior.
> Injections for java.util.Optional<> should be automatic optional
> -
>
> Key: SLING-8706
> URL: https://issues.apache.org/jira/browse/SLING-8706
> Project: Sling
> Issue Type: Improvement
> Components: Sling Models
>Reporter: Jörg Hoh
>Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The current approach to support optional injections requires to annotate the
> field with {{@Optional}} plus proper handling within the javacode (null
> checks etc), which can be forgotten.
> So instead of
> {code}
> @Inject @Optional
> String fieldname;
> {code}
> it should also be possible to use this
> {code}
> @Inject
> Optional fieldname;
> {code}
> with the very same semantic. But the developer is forced to deal with the
> case that the value is not present.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9536) Add analyser checking for duplicate symbolic names
[ https://issues.apache.org/jira/browse/SLING-9536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-9536. - Resolution: Fixed Added new check "duplicate-symbolic-names" https://github.com/apache/sling-org-apache-sling-feature-analyser/commit/40f86541b6c44263f87e9499b281ac6153dc7678 > Add analyser checking for duplicate symbolic names > -- > > Key: SLING-9536 > URL: https://issues.apache.org/jira/browse/SLING-9536 > Project: Sling > Issue Type: New Feature > Components: Feature Model Analyser >Reporter: Carsten Ziegeler >Assignee: Carsten Ziegeler >Priority: Major > Fix For: Feature Model Analyser 1.3.2 > > > A new analyser could check for duplicate symbolic names in the bundles and > report an error -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9536) Add analyser checking for duplicate symbolic names
Carsten Ziegeler created SLING-9536: --- Summary: Add analyser checking for duplicate symbolic names Key: SLING-9536 URL: https://issues.apache.org/jira/browse/SLING-9536 Project: Sling Issue Type: New Feature Components: Feature Model Analyser Reporter: Carsten Ziegeler Assignee: Carsten Ziegeler Fix For: Feature Model Analyser 1.3.2 A new analyser could check for duplicate symbolic names in the bundles and report an error -- This message was sent by Atlassian Jira (v8.3.4#803005)
