[Jenkins] Sling » Modules » sling-org-apache-sling-launchpad-testing » master #62 is BROKEN
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/62/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: [...truncated 1946 lines...] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.felix.scr.impl.inject.internal.ComponentConstructorImpl.newInstance(ComponentConstructorImpl.java:312) at org.apache.felix.scr.impl.manager.SingleComponentManager.createImplementationObject(SingleComponentManager.java:279) at org.apache.felix.scr.impl.manager.SingleComponentManager.createComponent(SingleComponentManager.java:115) at org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:984) at org.apache.felix.scr.impl.manager.SingleComponentManager.getServiceInternal(SingleComponentManager.java:957) at org.apache.felix.scr.impl.manager.SingleComponentManager.getService(SingleComponentManager.java:902) at org.apache.felix.framework.ServiceRegistrationImpl.getFactoryUnchecked(ServiceRegistrationImpl.java:348) at org.apache.felix.framework.ServiceRegistrationImpl.getService(ServiceRegistrationImpl.java:248) at org.apache.felix.framework.ServiceRegistry.getService(ServiceRegistry.java:350) at org.apache.felix.framework.Felix.getService(Felix.java:3954) at org.apache.felix.framework.BundleContextImpl.getService(BundleContextImpl.java:450) at org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.addingService(WebConsoleAdapter.java:152) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:943) at org.osgi.util.tracker.ServiceTracker$Tracked.customizerAdding(ServiceTracker.java:871) at org.osgi.util.tracker.AbstractTracked.trackAdding(AbstractTracked.java:256) at org.osgi.util.tracker.AbstractTracked.trackInitial(AbstractTracked.java:183) at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:321) at org.osgi.util.tracker.ServiceTracker.open(ServiceTracker.java:264) at org.apache.felix.inventory.impl.webconsole.WebConsoleAdapter.(WebConsoleAdapter.java:68) at org.apache.felix.inventory.impl.Activator.start(Activator.java:63) at org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:698) at org.apache.felix.framework.Felix.activateBundle(Felix.java:2402) at org.apache.felix.framework.Felix.startBundle(Felix.java:2308) at org.apache.felix.framework.Felix.setActiveStartLevel(Felix.java:1539) at org.apache.felix.framework.FrameworkStartLevelImpl.run(FrameworkStartLevelImpl.java:308) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.IllegalStateException: No bundle context property 'sling.properties.url' provided at org.apache.sling.settings.impl.SlingPropertiesPrinter.(SlingPropertiesPrinter.java:64) ... 30 more INFO : org.apache.felix.webconsole.plugins.memoryusage (59): Storing Memory Dumps in /home/jenkins/workspace/e-sling-launchpad-testing_master/target/launchers/sling-12-oak-tar/framework/bundle59/data/dumps INFO : org.apache.felix.webconsole.plugins.memoryusage (59): Setting Automatic Memory Dump Threshold to 0% for pools [Code Cache, Compressed Class Space, Metaspace, PS Old Gen] INFO : org.apache.felix.webconsole.plugins.memoryusage (59): Automatic Memory Dump cannot be set for pools [PS Eden Space, PS Survivor Space] INFO : org.apache.felix.webconsole.plugins.memoryusage (59): Setting Automatic Memory Dump Interval to 21600 seconds INFO : org.apache.felix.webconsole.plugins.memoryusage (59): Setting Automatic Memory Dump Threshold to 0% for pools [Code Cache, Compressed Class Space, Metaspace, PS Old Gen] INFO : org.apache.felix.webconsole.plugins.memoryusage (59): Automatic Memory Dump cannot be set for pools [PS Eden Space, PS Survivor Space] INFO : org.apache.felix.webconsole.plugins.memoryusage (59): Setting Automatic Memory Dump Interval to 21600 seconds INFO : org.apache.felix.webconsole.plugins.memoryusage (59): Storing Memory Dumps in /home/jenkins/workspace/e-sling-launchpad-testing_master/target/launchers/sling-12-oak-tar/framework/bundle59/data/dumps [INFO] Framework started [INFO] [INFO] --- maven-failsafe-plugin:2.21.0:integration-test (default) @ org.apache.sling.launchpad.testing --- [INFO] [INFO] --- [INFO] T E S T S [INFO] --- [INFO] Running org.apache.sling.launchpad.webapp.integrationtest.login.AuthRequestLoginTest 03:38:49,621 |-INFO in ch.qos.logback.classic.LoggerContext[default] - Could NOT find resource [logback.groovy] 03:38:49,622 |-INFO
[GitHub] [sling-org-apache-sling-scripting-sightly-models-provider] paul-bjorkstrand commented on pull request #1: Allow an adaptable argument
paul-bjorkstrand commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-models-provider/pull/1#issuecomment-682232542 @raducotescu, @vladbailescu, and @kwin: Quite a long time since I revisited this. I have attempted to make some changes to the tests as mentioned by Vlad, but I am not certain exactly how to run the tests. I have pushed my changes to my fork ([commit][1]). If one of you can guide me on how to execute the tests (and review the changes when that PR is opened) then I think we can get this change, and the associated test, merged in. [1]: https://github.com/paul-bjorkstrand/sling-org-apache-sling-scripting-sightly-testing-content/commit/2fd6a2902b270446070e4833865616df945639f7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly-models-provider] sonarcloud[bot] removed a comment on pull request #1: Allow an adaptable argument
sonarcloud[bot] removed a comment on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-models-provider/pull/1#issuecomment-671546217 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-a pache-sling-scripting-sightly-models-provider=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-scripting-sightly-models-provider] sonarcloud[bot] commented on pull request #1: Allow an adaptable argument
sonarcloud[bot] commented on pull request #1: URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly-models-provider/pull/1#issuecomment-682229296 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-a pache-sling-scripting-sightly-models-provider=1=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_coverage=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-scripting-sightly-models-provider=1=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #13: SLING-9695 Added options for datastore
rombert commented on pull request #13: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682179727 Oh, an according to https://github.com/apache/sling-org-apache-sling-feature-launcher/blob/7aa00ee307f5b3452b6a1cc3f3e2959251a3d6ca/src/main/java/org/apache/sling/feature/launcher/impl/Bootstrap.java#L73 , a variable named `sling.home` should be supported, please file a bug. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #13: SLING-9695 Added options for datastore
rombert commented on pull request #13:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682178850
Thanks for the update. I am not sure we should be generating so many
aggregates ... we have a large number of combinations of NodeStores and
DataStores, e.g.
- SegmentNodeStore
- DocumentNodeStore + MongoDB
- DocumentNodeStore + RDB (Postgres?)
- No BlobStore
- FileBlobStore
- MongoBlobStore
- RDBBlobStore
(etc, etc)
The idea behind having an additional file which configures just the
DataStore was to combine one NodeStore with one DataStore, instead of
'hardcoding' combinations. Additionally, if we generate `far` files as well, we
greatly increase the storage needed. But I should think about this some more
tomorrow, it's a bit late over here right now :-)
About the hardcoded path, I think you can work around it by defining another
variable
```
"variables": {
"repository.home": "${sling.home}/repository"
}
```
And then referencing `${repository.home}` in the configuration values.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] cmrockwell commented on pull request #13: SLING-9695 Added options for datastore
cmrockwell commented on pull request #13:
URL:
https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682058124
One note. The path was hard coded as shown below
`"org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore": {
"minRecordLength":4096,
"path":"sling/repository/datastore",
"cacheSizeInMB":128
}`
boot.json uses a variable ${sling.home} but when I tried using that for the
datastore `path` it created a directory with that variable name (not the
value). It created a directory literally called "${sling.home}"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Closed] (SLING-9663) Properly set authentication information when performing pre-authenticated login
[ https://issues.apache.org/jira/browse/SLING-9663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu closed SLING-9663. -- > Properly set authentication information when performing pre-authenticated > login > --- > > Key: SLING-9663 > URL: https://issues.apache.org/jira/browse/SLING-9663 > Project: Sling > Issue Type: Bug > Components: JCR, Oak >Reporter: Robert Munteanu >Assignee: Robert Munteanu >Priority: Major > Fix For: JCR Oak Server 1.2.6 > > Time Spent: 50m > Remaining Estimate: 0h > > Using pre-authenticated service users does not seem to work with the Sling > Starter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[RESULT] [VOTE] Release Apache Sling JCR Oak Server 1.2.6
Hi, The vote has passed with the following result: +1 (binding): Stefan Seifert, Robert Munteanu, Nicolas Peltier, Dan Klco +1 (non-binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Regards, Robert Munteanu
Re: [Feature Model] Binaries archive support in feature models and .far files.
Hi all, Thanks for the +1s. I have now moved the code to https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-feature-extension-unpack.git https://github.com/apache/sling-org-apache-sling-feature-extension-unpack I added the label to the .asf.yml file so that it shows up in the osgi-feature-model search, thanks for the suggestion, Bertrand! Best regards, David On Thu, 27 Aug 2020 at 10:08, Robert Munteanu wrote: > On Thu, 2020-08-27 at 08:38 +0100, dav...@apache.org wrote: > > Currently [4] is in the sling-whiteboard repository. It would be > > great if > > we can graduate it out of there into its own repository. > > Would the Sling community think that this is ok to do? > > > > We could call the new repository > > sling-org-apache-sling-feature-extension-unpack which follows the > > same > > format as existing extensions for apiregions and content already do. > > +1 from me. > > Robert > >
[jira] [Resolved] (SLING-9681) Update Badges to use ci-build.apache.org
[ https://issues.apache.org/jira/browse/SLING-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9681. - Resolution: Fixed Updates applied and script improvements made to reduce the "weight" of the script and move to a common language (Groovy vs Bash) with other scripts > Update Badges to use ci-build.apache.org > > > Key: SLING-9681 > URL: https://issues.apache.org/jira/browse/SLING-9681 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Major > > In SLING-9594, we moved the builds to ci-build.apache.org, we should > similarly update the > [add-badges.sh|https://github.com/apache/sling-aggregator/blob/master/add-badges.sh] > script to use ci-build.apache.org. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9682) Add SonarQube Badge
[ https://issues.apache.org/jira/browse/SLING-9682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Klco resolved SLING-9682. - Resolution: Fixed Applied across the applicable projects. > Add SonarQube Badge > --- > > Key: SLING-9682 > URL: https://issues.apache.org/jira/browse/SLING-9682 > Project: Sling > Issue Type: Task >Reporter: Dan Klco >Assignee: Dan Klco >Priority: Minor > > Currently the > [add-badges.sh|https://github.com/apache/sling-aggregator/blob/master/add-badges.sh] > script does not support adding badges for SonarQube, it should be updated to > add badges for SonarQube Quality Gate and Coverage metrics. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [RT] Markdown resource decorator
Thanks, good idea, I'll add something like that Regards Carsten Am 27.08.2020 um 12:09 schrieb Bertrand Delacretaz: Hi, On Thu, Aug 27, 2020 at 8:54 AM Carsten Ziegeler wrote: ...I created a markdown resource decorator module ( [1] ) based on Robert's md resource provider... Great idea, looks useful! One idea that comes to mind is providing a hook to set a specific resource type based on the front matter, path or other attributes. Or use a specific front matter property for that, like JBake that we use for the Sling website does with the "type" front matter property. -Bertrand -- -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[jira] [Resolved] (SLING-9696) HTL does not correctly cast the "false" string to Boolean
[
https://issues.apache.org/jira/browse/SLING-9696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-9696.
-
Fix Version/s: Scripting HTL Java Compiler 1.2.2-1.4.0
Scripting HTL Testing 1.0.24-1.4.0
Scripting HTL Compiler 1.2.8-1.4.0
Resolution: Fixed
Fixed in:
* [commit
4307b1e|https://github.com/apache/sling-org-apache-sling-scripting-sightly-runtime/commit/4307b1e]
* [commit
76bf4c8|https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler/commit/76bf4c8]
* [commit
bfb098b|https://github.com/apache/sling-org-apache-sling-scripting-sightly/commit/bfb098b]
* [commit
2cdbfef|https://github.com/apache/sling-org-apache-sling-scripting-sightly-testing/commit/2cdbfef]
Requires SLING-9706.
> HTL does not correctly cast the "false" string to Boolean
> -
>
> Key: SLING-9696
> URL: https://issues.apache.org/jira/browse/SLING-9696
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting Sightly Engine 1.0.0, Scripting HTL Engine
> 1.0.20, Scripting HTL Engine 1.1.0-1.4.0, Scripting HTL Engine 1.2.0-1.4.0,
> Scripting HTL Engine 1.3.0-1.4.0, Scripting HTL Engine 1.4.0-1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Compiler 1.2.8-1.4.0, Scripting HTL
> Testing 1.0.24-1.4.0, Scripting HTL Runtime 1.2.4-1.4.0, Scripting HTL Engine
> 1.4.4-1.4.0, Scripting HTL Java Compiler 1.2.2-1.4.0
>
>
> The HTL engine implementation from Apache Sling seems to have never correctly
> casted the "false" string to boolean. The HTL specification [0] mentions the
> following:
> {noformat}
> These expressions evaluate to false:
> * false
> * 0 (zero)
> * '' or "" (empty string)
> * [] (empty iterable)
> These evaluate to true:
> * "false" (non-empty string)
> * [0] (non-empty iterable)
> {noformat}
> However, all implementations have returned the Boolean {{false}} for any
> casing of the string "false".
> A change like this has the potential to break the functionality of existing
> HTL code, relying on the fact that the string "false" (irrespective of its
> casing) returns the Boolean {{false}}, however the implementation should obey
> the specification. Therefore I think the fix should be behind a configuration
> flag, which by default allows the engine to continue working with the wrong
> behaviour. Deployers can then decide via configuration if they would like to
> switch the engine to the correct behaviour.
>
> [0] -
> [https://github.com/adobe/htl-spec/blob/1.4/SPECIFICATION.md#115-casting]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9706) The HTL Java Compiler does not correctly negate equals
[
https://issues.apache.org/jira/browse/SLING-9706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Radu Cotescu resolved SLING-9706.
-
Resolution: Fixed
> The HTL Java Compiler does not correctly negate equals
> --
>
> Key: SLING-9706
> URL: https://issues.apache.org/jira/browse/SLING-9706
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting HTL Java Compiler 1.0.4, Scripting HTL Java
> Compiler 1.1.0-1.4.0, Scripting HTL Java Compiler 1.2.0-1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Java Compiler 1.2.2-1.4.0
>
>
> Although the {{equals}} operation is only generated for internal HTL Compiler
> commands, the operation is not correctly negated when using the
> {{Binary.NEQ}} operator.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-9706) The HTL Java Compiler does not correctly negate equals
[
https://issues.apache.org/jira/browse/SLING-9706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185761#comment-17185761
]
Radu Cotescu commented on SLING-9706:
-
Fixed in [commit
c092fb4|https://github.com/apache/sling-org-apache-sling-scripting-sightly-compiler-java/commit/c092fb4]
> The HTL Java Compiler does not correctly negate equals
> --
>
> Key: SLING-9706
> URL: https://issues.apache.org/jira/browse/SLING-9706
> Project: Sling
> Issue Type: Bug
> Components: Scripting
>Affects Versions: Scripting HTL Java Compiler 1.0.4, Scripting HTL Java
> Compiler 1.1.0-1.4.0, Scripting HTL Java Compiler 1.2.0-1.4.0
>Reporter: Radu Cotescu
>Assignee: Radu Cotescu
>Priority: Major
> Fix For: Scripting HTL Java Compiler 1.2.2-1.4.0
>
>
> Although the {{equals}} operation is only generated for internal HTL Compiler
> commands, the operation is not correctly negated when using the
> {{Binary.NEQ}} operator.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9706) The HTL Java Compiler does not correctly negate equals
Radu Cotescu created SLING-9706:
---
Summary: The HTL Java Compiler does not correctly negate equals
Key: SLING-9706
URL: https://issues.apache.org/jira/browse/SLING-9706
Project: Sling
Issue Type: Bug
Components: Scripting
Affects Versions: Scripting HTL Java Compiler 1.2.0-1.4.0, Scripting HTL
Java Compiler 1.1.0-1.4.0, Scripting HTL Java Compiler 1.0.4
Reporter: Radu Cotescu
Assignee: Radu Cotescu
Fix For: Scripting HTL Java Compiler 1.2.2-1.4.0
Although the {{equals}} operation is only generated for internal HTL Compiler
commands, the operation is not correctly negated when using the {{Binary.NEQ}}
operator.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [RT] Markdown resource decorator
Hi, On Thu, Aug 27, 2020 at 8:54 AM Carsten Ziegeler wrote: > ...I created a markdown resource decorator module ( [1] ) based on Robert's > md resource provider... Great idea, looks useful! One idea that comes to mind is providing a hook to set a specific resource type based on the front matter, path or other attributes. Or use a specific front matter property for that, like JBake that we use for the Sling website does with the "type" front matter property. -Bertrand
[jira] [Resolved] (SLING-9705) Enable code coverage with JaCoCo
[ https://issues.apache.org/jira/browse/SLING-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9705. - Resolution: Done > Enable code coverage with JaCoCo > > > Key: SLING-9705 > URL: https://issues.apache.org/jira/browse/SLING-9705 > Project: Sling > Issue Type: Task > Components: Scripting >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Scripting Core 2.3.4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9705) Enable code coverage with JaCoCo
Oliver Lietz created SLING-9705: --- Summary: Enable code coverage with JaCoCo Key: SLING-9705 URL: https://issues.apache.org/jira/browse/SLING-9705 Project: Sling Issue Type: Task Components: Scripting Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: Scripting Core 2.3.4 -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [RT] Markdown resource decorator
Hi Carsten, On Thu, 2020-08-27 at 08:54 +0200, Carsten Ziegeler wrote: > Hi, > > I created a markdown resource decorator module ( [1] ) based on > Robert's > md resource provider. > > With a decorator you can decorate resources from any provider, so > you > can handle file resources, JCR resources etc. > > Based on configuration it can extract a yaml frontmatter, title and > render the md to markdown - all of this gets put as additional > attributes into the value map of the decorated resource. (Similar to > the > md resource provider) > > I've also added initial code for link rewriting in the rendered html. > > The solution is more flexible than the md resource provider but is > missing the index feature of that provider. Looks good! Robert > > Right now, the md is rendered as html on first access of the value > map. > This could be made more lazy by putting a Supplier into the value > map > which triggers rendering the first time the Supplier is used. > > > [1] > https://github.com/apache/sling-whiteboard/tree/master/mdresourcedecorator > > Regards > Carsten > -- > Carsten Ziegeler > Adobe Research Switzerland > cziege...@apache.org
Re: [Feature Model] Binaries archive support in feature models and .far files.
On Thu, 2020-08-27 at 08:38 +0100, dav...@apache.org wrote: > Currently [4] is in the sling-whiteboard repository. It would be > great if > we can graduate it out of there into its own repository. > Would the Sling community think that this is ok to do? > > We could call the new repository > sling-org-apache-sling-feature-extension-unpack which follows the > same > format as existing extensions for apiregions and content already do. +1 from me. Robert
[jira] [Resolved] (SLING-9704) Enable code coverage with JaCoCo
[ https://issues.apache.org/jira/browse/SLING-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9704. - Resolution: Done > Enable code coverage with JaCoCo > > > Key: SLING-9704 > URL: https://issues.apache.org/jira/browse/SLING-9704 > Project: Sling > Issue Type: Task > Components: JCR, Oak >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: JCR Oak Server 1.2.8 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9703) Enable code coverage with JaCoCo
[ https://issues.apache.org/jira/browse/SLING-9703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9703. - Resolution: Done > Enable code coverage with JaCoCo > > > Key: SLING-9703 > URL: https://issues.apache.org/jira/browse/SLING-9703 > Project: Sling > Issue Type: Task > Components: Scripting >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Scripting Thymeleaf 2.0.4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9702) Enable code coverage with JaCoCo
[ https://issues.apache.org/jira/browse/SLING-9702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9702. - Resolution: Done > Enable code coverage with JaCoCo > > > Key: SLING-9702 > URL: https://issues.apache.org/jira/browse/SLING-9702 > Project: Sling > Issue Type: Task > Components: Scripting >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Scripting Groovy 1.2.2 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9701) Enable code coverage with JaCoCo
[ https://issues.apache.org/jira/browse/SLING-9701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oliver Lietz resolved SLING-9701. - Resolution: Done > Enable code coverage with JaCoCo > > > Key: SLING-9701 > URL: https://issues.apache.org/jira/browse/SLING-9701 > Project: Sling > Issue Type: Task > Components: Scripting >Reporter: Oliver Lietz >Assignee: Oliver Lietz >Priority: Major > Fix For: Scripting FreeMarker 1.0.4 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [Feature Model] Binaries archive support in feature models and .far files.
Hi, On Thu, Aug 27, 2020 at 9:38 AM wrote: > ...Currently [4] is in the sling-whiteboard repository. It would be great if > we can graduate it out of there into its own repository. > Would the Sling community think that this is ok to do?.. Sounds good to me! > We could call the new repository > sling-org-apache-sling-feature-extension-unpack which follows the same > format as existing extensions for apiregions and content already do... +1 and please add the osgi-feature-model topic (using .asf.yaml) so that the new repository is listed at https://github.com/search?q=topic%3Asling+topic%3Aosgi-feature-model+topic%3Aosgi+org%3Aapache=Repositories - that query is used in https://sling.apache.org/documentation/development/feature-model.html -Bertrand > [1] https://issues.apache.org/jira/browse/SLING-9670 > [2] https://issues.apache.org/jira/browse/SLING-9658 > [3] > https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-installer-factory-feature.git > [4] > https://gitbox.apache.org/repos/asf?p=sling-whiteboard.git;a=tree;f=featuremodel-unpack-extension;hb=HEAD
[jira] [Created] (SLING-9704) Enable code coverage with JaCoCo
Oliver Lietz created SLING-9704: --- Summary: Enable code coverage with JaCoCo Key: SLING-9704 URL: https://issues.apache.org/jira/browse/SLING-9704 Project: Sling Issue Type: Task Components: JCR, Oak Reporter: Oliver Lietz Assignee: Oliver Lietz Fix For: JCR Oak Server 1.2.8 -- This message was sent by Atlassian Jira (v8.3.4#803005)
SonarCloud rules
Hi Olli, I see you've been adding some SonarClud rules to skip to various modules. Could I ask you to briefly list the rules that you suppress and the reason? A page [1] would be great, and would help us be consistent about what rules we ignore. Maybe at some point it would be possible to create a 'Sling' ruleset and ignore them altogether. Thanks, Robert [1]: https://cwiki.apache.org/confluence/display/SLING/Developing+for+Sling
[Feature Model] Binaries archive support in feature models and .far files.
Hi all, Over the past weeks Karl Pauls and I have been working on supporting binary archives in features models. In short, this allows archives (jar/zip files) to be listed in a feature model extension, which are then extracted to a configurable location on disk when the feature is launched, either via the Feature Launcher through a Launcher Extension, or through the OSGi installer. It relates to the following issues: SLING-9670 Support binary zip files in feature extension [1] SLING-9658 Support binary archives in .far files [2] While some of the changes are done in sling-org-apache-sling-installer-factory-feature [3] most of the work is done in a new component which is available at [4] which provides the Launcher Extension as well as services that are picked up by the OSGi installer to perform this task. Currently [4] is in the sling-whiteboard repository. It would be great if we can graduate it out of there into its own repository. Would the Sling community think that this is ok to do? We could call the new repository sling-org-apache-sling-feature-extension-unpack which follows the same format as existing extensions for apiregions and content already do. Thoughts? Best regards, David and Karl [1] https://issues.apache.org/jira/browse/SLING-9670 [2] https://issues.apache.org/jira/browse/SLING-9658 [3] https://gitbox.apache.org/repos/asf?p=sling-org-apache-sling-installer-factory-feature.git [4] https://gitbox.apache.org/repos/asf?p=sling-whiteboard.git;a=tree;f=featuremodel-unpack-extension;hb=HEAD
[RT] Markdown resource decorator
Hi, I created a markdown resource decorator module ( [1] ) based on Robert's md resource provider. With a decorator you can decorate resources from any provider, so you can handle file resources, JCR resources etc. Based on configuration it can extract a yaml frontmatter, title and render the md to markdown - all of this gets put as additional attributes into the value map of the decorated resource. (Similar to the md resource provider) I've also added initial code for link rewriting in the rendered html. The solution is more flexible than the md resource provider but is missing the index feature of that provider. Right now, the md is rendered as html on first access of the value map. This could be made more lazy by putting a Supplier into the value map which triggers rendering the first time the Supplier is used. [1] https://github.com/apache/sling-whiteboard/tree/master/mdresourcedecorator Regards Carsten -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org
[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare commented on a change in pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
saurabh-khare commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r478183139 ## File path: pom.xml ## @@ -43,120 +42,120 @@ - + -org.apache.felix -maven-scr-plugin +org.apache.sling +sling-maven-plugin - + -org.apache.felix -maven-bundle-plugin -true - - - org.apache.sling.superimposing - org.apache.sling.superimposing.impl - org.apache.felix.webconsole - SLING-INF/nodetypes/superimposing.cnd - - +biz.aQute.bnd +bnd-maven-plugin - -org.apache.sling -maven-sling-plugin +biz.aQute.bnd +bnd-baseline-maven-plugin - org.apache.sling org.apache.sling.api -2.2.0 +2.18.4 provided org.apache.sling org.apache.sling.commons.osgi -2.1.0 +2.4.0 provided org.apache.sling org.apache.sling.settings -1.0.0 +1.3.8 provided - + + org.apache.sling + org.apache.sling.serviceusermapper + 1.3.6 + provided + + + org.apache.commons + commons-lang3 +3.6 + -commons-lang -commons-lang -2.4 + org.apache.commons + commons-collections4 +4.1 + + + + org.osgi + org.osgi.service.component.annotations provided - - -commons-collections -commons-collections -3.1 + + + org.osgi + org.osgi.service.metatype.annotations +1.4.0 Review comment: Removed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare commented on a change in pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
saurabh-khare commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r478182961 ## File path: pom.xml ## @@ -43,120 +42,120 @@ - + -org.apache.felix -maven-scr-plugin +org.apache.sling +sling-maven-plugin - + -org.apache.felix -maven-bundle-plugin -true - - - org.apache.sling.superimposing - org.apache.sling.superimposing.impl - org.apache.felix.webconsole - SLING-INF/nodetypes/superimposing.cnd - - +biz.aQute.bnd +bnd-maven-plugin - -org.apache.sling -maven-sling-plugin +biz.aQute.bnd +bnd-baseline-maven-plugin - org.apache.sling org.apache.sling.api -2.2.0 +2.18.4 Review comment: Reverted to previous versions for runtime dependencies This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare commented on a change in pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
saurabh-khare commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r478182354 ## File path: bnd.bnd ## @@ -0,0 +1,17 @@ +Bundle-Category: sling Review comment: Removed duplicated information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-superimposing] saurabh-khare commented on a change in pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
saurabh-khare commented on a change in pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#discussion_r478182573 ## File path: pom.xml ## @@ -19,14 +19,13 @@ 4.0.0 org.apache.sling -sling -26 - +sling-bundle-parent +38 Review comment: Updated to version 39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-superimposing] sonarcloud[bot] removed a comment on pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
sonarcloud[bot] removed a comment on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#issuecomment-680872125 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false =SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_coverage=list) [89.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [sling-org-apache-sling-superimposing] sonarcloud[bot] commented on pull request #2: SLING-9688 - Upgrade Sling superimposing to use OSGi R7 annotations
sonarcloud[bot] commented on pull request #2: URL: https://github.com/apache/sling-org-apache-sling-superimposing/pull/2#issuecomment-681622019 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false =SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-superimposing=2=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_coverage=list) [89.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_coverage=list) [](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-superimposing=2=new_duplicated_lines_density=list) The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. Read more [here](https://sonarcloud.io/documentation/upcoming/) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
