[jira] [Resolved] (SLING-9734) Add a health check component that monitors bundle content loading
[ https://issues.apache.org/jira/browse/SLING-9734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-9734. Resolution: Fixed Fixed at: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/609f1178d80763cf3acab2b9715be44c62c1f1b8 > Add a health check component that monitors bundle content loading > - > > Key: SLING-9734 > URL: https://issues.apache.org/jira/browse/SLING-9734 > Project: Sling > Issue Type: Improvement >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR ContentLoader 2.4.0 > > > Add a new health check component that monitors the bundle content loading > progress for all of the applicable deployed bundles. > This can be used to do a quick check for bundles that fail content loading, > or as a way to query the system to check if the content loading has completed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9734) Add a health check component that monitors bundle content loading
Eric Norman created SLING-9734: -- Summary: Add a health check component that monitors bundle content loading Key: SLING-9734 URL: https://issues.apache.org/jira/browse/SLING-9734 Project: Sling Issue Type: Improvement Reporter: Eric Norman Assignee: Eric Norman Fix For: JCR ContentLoader 2.4.0 Add a new health check component that monitors the bundle content loading progress for all of the applicable deployed bundles. This can be used to do a quick check for bundles that fail content loading, or as a way to query the system to check if the content loading has completed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (SLING-9733) Refactor o.a.s.jcr.contentloader tests to make them work with java 11
[ https://issues.apache.org/jira/browse/SLING-9733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Norman resolved SLING-9733. Resolution: Fixed Fixed at: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/commit/3f30ff3a3b9bb8db4ee35cf7c1123367eb064e30 > Refactor o.a.s.jcr.contentloader tests to make them work with java 11 > - > > Key: SLING-9733 > URL: https://issues.apache.org/jira/browse/SLING-9733 > Project: Sling > Issue Type: Sub-task >Reporter: Eric Norman >Assignee: Eric Norman >Priority: Major > Fix For: JCR ContentLoader 2.4.0 > > > The JCR ContentLoader unit tests don't work when using java 11. > Fix by refactoring using the guidance from SLING-7166 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SLING-9733) Refactor o.a.s.jcr.contentloader tests to make them work with java 11
Eric Norman created SLING-9733: -- Summary: Refactor o.a.s.jcr.contentloader tests to make them work with java 11 Key: SLING-9733 URL: https://issues.apache.org/jira/browse/SLING-9733 Project: Sling Issue Type: Sub-task Reporter: Eric Norman Assignee: Eric Norman Fix For: JCR ContentLoader 2.4.0 The JCR ContentLoader unit tests don't work when using java 11. Fix by refactoring using the guidance from SLING-7166 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SLING-9732) Friendly Names for persisted GraphQL queries
[
https://issues.apache.org/jira/browse/SLING-9732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Knobloch updated SLING-9732:
---
Description:
The current implementation generates a URL with a hash, for instance
\{{/persisted/9bae4aa26ea4b2e06889a1e02179e02a902211bf970185c45bceba537107e2fc}}
It would be great to be able to specify a "friendly name" that an external
application could use, for instance {{/persisted/listArticles}}
Should probably have things like
* POST - register a query, ensuring a unique name is used
* PUT - to update existing query
* DELETE - to remove a persisted query
I wonder if there should be some namespacing for the query name, like
{{/persisted/projectA/listArticles}} and {{/persisted/projectB/listArticles}}
to give it more flexibility.
And probably an endpoint for listing existing queries within such a scope.
was:
The current implementation generates a URL with a hash, for instance
\{{/persisted/9bae4aa26ea4b2e06889a1e02179e02a902211bf970185c45bceba537107e2fc}}
It would be great to be able to specify a "friendly name" that an external
application could use, for instance {{/persisted/listArticles}}
Should probably have things like
* POST - register a query, ensuring a unique name is used
* PUT - to update existing query
* DELETE - to remove a persisted query
I wonder if there should be some namespacing for the query name, like
{{/persisted/projectA/listArticles}} and {{/persisted/projectB/listArticles}}
to give it more flexibility.
> Friendly Names for persisted GraphQL queries
>
>
> Key: SLING-9732
> URL: https://issues.apache.org/jira/browse/SLING-9732
> Project: Sling
> Issue Type: New Feature
> Components: GraphQL
>Reporter: Gilles Knobloch
>Priority: Major
>
> The current implementation generates a URL with a hash, for instance
> \{{/persisted/9bae4aa26ea4b2e06889a1e02179e02a902211bf970185c45bceba537107e2fc}}
> It would be great to be able to specify a "friendly name" that an external
> application could use, for instance {{/persisted/listArticles}}
> Should probably have things like
> * POST - register a query, ensuring a unique name is used
> * PUT - to update existing query
> * DELETE - to remove a persisted query
> I wonder if there should be some namespacing for the query name, like
> {{/persisted/projectA/listArticles}} and {{/persisted/projectB/listArticles}}
> to give it more flexibility.
> And probably an endpoint for listing existing queries within such a scope.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (SLING-9732) Friendly Names for persisted GraphQL queries
Gilles Knobloch created SLING-9732:
--
Summary: Friendly Names for persisted GraphQL queries
Key: SLING-9732
URL: https://issues.apache.org/jira/browse/SLING-9732
Project: Sling
Issue Type: New Feature
Components: GraphQL
Reporter: Gilles Knobloch
The current implementation generates a URL with a hash, for instance
\{{/persisted/9bae4aa26ea4b2e06889a1e02179e02a902211bf970185c45bceba537107e2fc}}
It would be great to be able to specify a "friendly name" that an external
application could use, for instance {{/persisted/listArticles}}
Should probably have things like
* POST - register a query, ensuring a unique name is used
* PUT - to update existing query
* DELETE - to remove a persisted query
I wonder if there should be some namespacing for the query name, like
{{/persisted/projectA/listArticles}} and {{/persisted/projectB/listArticles}}
to give it more flexibility.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196222#comment-17196222
]
Konrad Windszus commented on SLING-2938:
Please create a repo in your personal github space. Once that is done we can
easily push that repo to a new repo location beneath Apache Sling.
Alternatively feel free to fork https://github.com/apache/sling-whiteboard and
create a new project in it.
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196221#comment-17196221
]
Henry Kuijpers commented on SLING-2938:
---
I see, [~kwin]. Would it be possible to create a dedicated
"annotations"-project for this one?
[https://github.com/apache/sling-org-apache-sling-adapter]
I'd like to submit a PR then, to get this merged in and released.
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196213#comment-17196213
]
Konrad Windszus edited comment on SLING-2938 at 9/15/20, 3:11 PM:
--
This is a misunderstanding: https://github.com/apache/sling-adapter-annotations
is used by
https://sling.apache.org/components/sling-maven-plugin/generate-adapter-metadata-mojo.html
to build JSON metadata (only evaluated in the Felix WebConsole). It won't
generate the actual SCR definitions. Compare also with
https://sling.apache.org/documentation/the-sling-engine/adapters.html#implementing-adaptable.
In the long run I would also like to replace generating that JSON in the
dedicated goal of the {{maven-sling-plugin}} by a custom bnd plugin (similar to
https://github.com/apache/sling-org-apache-sling-caconfig-bnd-plugin) .
was (Author: kwin):
This is a misunderstanding: https://github.com/apache/sling-adapter-annotations
is used by
https://sling.apache.org/components/sling-maven-plugin/generate-adapter-metadata-mojo.html
to build JSON metadata (only evaluated in the Felix WebConsole). It won't
generate the actual SCR definitions. Compare also with
https://sling.apache.org/documentation/the-sling-engine/adapters.html#implementing-adaptable.
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Issue Comment Deleted] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Henry Kuijpers updated SLING-2938:
--
Comment: was deleted
(was: I did notice that that module is not very up-to-date with the Sling
parent. It has multiple dependency check warnings:
{code:java}
[ERROR] Failed to execute goal org.owasp:dependency-check-maven:5.3.0:check
(check-dependencies-for-vulnerabilities) on project services:
[ERROR]
[ERROR] One or more dependencies were identified with vulnerabilities:
[ERROR]
[ERROR] adapter-annotations-1.0.0.jar: CVE-2013-4390, CVE-2016-5394,
CVE-2016-0956, CVE-2016-6798
[ERROR]
[ERROR] See the dependency-check report for more details.
{code})
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196218#comment-17196218
]
Henry Kuijpers commented on SLING-2938:
---
I did notice that that module is not very up-to-date with the Sling parent. It
has multiple dependency check warnings:
{code:java}
[ERROR] Failed to execute goal org.owasp:dependency-check-maven:5.3.0:check
(check-dependencies-for-vulnerabilities) on project services:
[ERROR]
[ERROR] One or more dependencies were identified with vulnerabilities:
[ERROR]
[ERROR] adapter-annotations-1.0.0.jar: CVE-2013-4390, CVE-2016-5394,
CVE-2016-0956, CVE-2016-6798
[ERROR]
[ERROR] See the dependency-check report for more details.
{code}
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196213#comment-17196213
]
Konrad Windszus edited comment on SLING-2938 at 9/15/20, 3:08 PM:
--
This is a misunderstanding: https://github.com/apache/sling-adapter-annotations
is used by
https://sling.apache.org/components/sling-maven-plugin/generate-adapter-metadata-mojo.html
to build JSON metadata (only evaluated in the Felix WebConsole). It won't
generate the actual SCR definitions. Compare also with
https://sling.apache.org/documentation/the-sling-engine/adapters.html#implementing-adaptable.
was (Author: kwin):
This is a misunderstanding: https://github.com/apache/sling-adapter-annotations
is used by
https://sling.apache.org/components/sling-maven-plugin/generate-adapter-metadata-mojo.html
to build JSON metadata (only evaluated in the Felix WebConsole). It won't
generate the actual SCR definitions.
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196213#comment-17196213
]
Konrad Windszus commented on SLING-2938:
This is a misunderstanding: https://github.com/apache/sling-adapter-annotations
is used by
https://sling.apache.org/components/sling-maven-plugin/generate-adapter-metadata-mojo.html
to build JSON metadata (only evaluated in the Felix WebConsole). It won't
generate the actual SCR definitions.
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (SLING-2938) AdapterMethods annotation and adapter proxy service
[
https://issues.apache.org/jira/browse/SLING-2938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196211#comment-17196211
]
Henry Kuijpers commented on SLING-2938:
---
Ehrr. You know what's funny? This is already in place?!
[https://github.com/apache/sling-adapter-annotations/blob/master/src/main/java/org/apache/sling/adapter/annotations/Adaptables.java]
> AdapterMethods annotation and adapter proxy service
> ---
>
> Key: SLING-2938
> URL: https://issues.apache.org/jira/browse/SLING-2938
> Project: Sling
> Issue Type: Bug
> Components: Engine, Extensions
>Affects Versions: Adapter 2.1.0
>Reporter: Bertrand Delacretaz
>Priority: Minor
> Attachments: SLING-2938-api.patch, console.jpg
>
>
> Following up on an idea that Olaf Otto presented at CQCon last week, I've
> been working on an @AdapterMethod annotation that makes it easier to create
> Sling adapters, as in
> @Component
> @Service
> public class MyAdapters implements AdapterMethodProvider {
> @AdapterMethod
> public Bar toBar(Foo f) { ... adapt Foo to Bar ... }
> }
> As this requires changes to the sling.api bundle, I'll commit to my
> whiteboard first, for review
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (SLING-9720) Present the persisted queries endpoints using the same extension the GraphQL servlet uses
[ https://issues.apache.org/jira/browse/SLING-9720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu resolved SLING-9720. - Resolution: Fixed Implemented in [commit df6e19c|https://github.com/apache/sling-org-apache-sling-graphql-core/commit/df6e19c]. > Present the persisted queries endpoints using the same extension the GraphQL > servlet uses > - > > Key: SLING-9720 > URL: https://issues.apache.org/jira/browse/SLING-9720 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Radu Cotescu >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.6 > > > Starting with SLING-9655, the GraphQL servlet supports persisted queries. In > order to better provide support for caching these queries at HTTP layers > above the Sling instance, it would be better to provide these resources using > the same extension that the GraphQL servlet uses. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (SLING-9724) Validate queries before persisting
[ https://issues.apache.org/jira/browse/SLING-9724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Radu Cotescu reassigned SLING-9724: --- Assignee: Radu Cotescu > Validate queries before persisting > -- > > Key: SLING-9724 > URL: https://issues.apache.org/jira/browse/SLING-9724 > Project: Sling > Issue Type: Improvement > Components: GraphQL >Reporter: Gilles Knobloch >Assignee: Radu Cotescu >Priority: Major > Fix For: GraphQL Core 0.0.6 > > > GraphQL queries sent for being persisted should be validated. > There should be an error message if someone tries to persist a wrong GraphQL > query. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: [VOTE] Release Apache Sling Commons Scheduler 2.7.12
+1 -Georg On 2020-09-14 19:02, Karl Pauls wrote: We solved 3 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12348801 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2335/ You can use this UNIX script to download the release and verify the signatures: https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD Usage: sh check_staged_release.sh 2335 /tmp/sling-staging Please vote to approve this release: [ ] +1 Approve the release [ ] 0 Don't care [ ] -1 Don't release, because ...
